v1.13.0: message_parts table + dual-write at every tool_calls/tool_results site

Adds a granular message_parts table (one row per text/tool_call/tool_result
chunk) without changing any read path. Old messages.content / tool_calls /
tool_results columns remain authoritative for v1.13.0; this dispatch is
write-only mirroring so the AI SDK migration in v1.13.1 can flip read
authority without a backfill window.

Schema:
  CREATE TABLE message_parts (id, message_id FK ON DELETE CASCADE,
    sequence int, kind text CHECK (text|tool_call|tool_result|reasoning|step_start),
    payload jsonb, created_at, UNIQUE (message_id, sequence))

New module services/inference/parts.ts with two pure derive helpers
(partsFromAssistantMessage, partsFromToolMessage) and insertParts that
fan-outs a multi-row INSERT via postgres-js.

Wired dual-write at every site that writes tool_calls or tool_results:
- tool-phase.ts: assistant finalize UPDATE, executed-tool UPDATE,
  ask_user_input sentinel UPDATE
- messages.ts answer flow: DELETE pending tool_result part + INSERT
  answered one inside the existing sql.begin
- skills.ts: synthetic assistant + tool INSERTs both inside existing tx
- chats.ts fork: CTE clones parts via ROW_NUMBER pairing (source→dest
  message id mapping in one statement, no N+1)
- error-handler.ts finalizeCompletion: text part for plain text-only
  assistant turns

Deviation: tool-phase.ts finalize UPDATEs and finalizeCompletion text-part
write are not wrapped in fresh sql.begin transactions. Safe in v1.13.0
because JSON columns are authoritative for reads. v1.13.1 must wrap these
sites before flipping read authority — TODO comments added at each
unwrapped site referencing v1.13.1.

Tests: 8 new unit tests for the derive helpers in
services/__tests__/parts.test.ts. Existing 162 tests untouched. 170 total.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-22 05:46:29 +00:00
parent ca64bf9f0a
commit 1cb6eee24c
8 changed files with 290 additions and 0 deletions

View File

@@ -0,0 +1,91 @@
import { describe, it, expect } from 'vitest';
import { partsFromAssistantMessage, partsFromToolMessage } from '../inference/parts.js';
import type { ToolCall, ToolResult } from '../../types/api.js';
describe('partsFromAssistantMessage', () => {
it('emits one text part for content-only assistant', () => {
const parts = partsFromAssistantMessage({ content: 'hello world', tool_calls: null });
expect(parts).toHaveLength(1);
expect(parts[0]).toEqual({
sequence: 0,
kind: 'text',
payload: { text: 'hello world' },
});
});
it('emits one tool_call part for empty-content + single tool_call', () => {
const tc: ToolCall = { id: 'call_1', name: 'view_file', args: { path: 'src/a.ts' } };
const parts = partsFromAssistantMessage({ content: '', tool_calls: [tc] });
expect(parts).toHaveLength(1);
expect(parts[0]).toEqual({
sequence: 0,
kind: 'tool_call',
payload: { id: 'call_1', name: 'view_file', args: { path: 'src/a.ts' } },
});
});
it('emits text then tool_call parts in order when both present', () => {
const tc: ToolCall = { id: 'call_2', name: 'grep', args: { pattern: 'foo' } };
const parts = partsFromAssistantMessage({ content: 'let me search', tool_calls: [tc] });
expect(parts.map((p) => [p.sequence, p.kind])).toEqual([
[0, 'text'],
[1, 'tool_call'],
]);
});
it('preserves tool_call order with multiple calls', () => {
const calls: ToolCall[] = [
{ id: 'a', name: 'list_dir', args: { path: '.' } },
{ id: 'b', name: 'view_file', args: { path: 'x.ts' } },
{ id: 'c', name: 'grep', args: { pattern: 'y' } },
];
const parts = partsFromAssistantMessage({ content: '', tool_calls: calls });
expect(parts).toHaveLength(3);
expect(parts.map((p) => p.payload)).toEqual([
{ id: 'a', name: 'list_dir', args: { path: '.' } },
{ id: 'b', name: 'view_file', args: { path: 'x.ts' } },
{ id: 'c', name: 'grep', args: { pattern: 'y' } },
]);
expect(parts.map((p) => p.sequence)).toEqual([0, 1, 2]);
});
it('returns empty array for empty content + null tool_calls', () => {
expect(partsFromAssistantMessage({ content: '', tool_calls: null })).toEqual([]);
});
});
describe('partsFromToolMessage', () => {
it('emits a single tool_result part at sequence 0', () => {
const tr: ToolResult = {
tool_call_id: 'call_1',
output: { contents: 'console.log(1)' },
truncated: false,
};
const parts = partsFromToolMessage({ tool_results: tr });
expect(parts).toHaveLength(1);
expect(parts[0]).toEqual({
sequence: 0,
kind: 'tool_result',
payload: {
tool_call_id: 'call_1',
output: { contents: 'console.log(1)' },
truncated: false,
},
});
});
it('includes error in payload when present', () => {
const tr: ToolResult = {
tool_call_id: 'call_2',
output: null,
truncated: false,
error: 'permission denied',
};
const parts = partsFromToolMessage({ tool_results: tr });
expect(parts[0]!.payload).toMatchObject({ error: 'permission denied' });
});
it('returns empty array when tool_results is null', () => {
expect(partsFromToolMessage({ tool_results: null })).toEqual([]);
});
});