From 89d685105ad8840391acfcea770aae3f0f4ef7e4 Mon Sep 17 00:00:00 2001 From: indifferentketchup Date: Fri, 15 May 2026 15:58:45 +0000 Subject: [PATCH] batch3 T8 review fix: preserve cloneElement key in linkifyChildren cloneElement does not carry el.key through unless explicitly passed. Without it, react-markdown's inline-element siblings (strong/em/text) lose their reconciler keys on every render, causing potential diffing churn. Pass el.key (with fallback) explicitly. Co-Authored-By: Claude Opus 4.7 (1M context) --- apps/web/src/components/MessageBubble.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/web/src/components/MessageBubble.tsx b/apps/web/src/components/MessageBubble.tsx index 3d15bb3..66d20d7 100644 --- a/apps/web/src/components/MessageBubble.tsx +++ b/apps/web/src/components/MessageBubble.tsx @@ -74,6 +74,7 @@ function linkifyChildren(children: ReactNode, keyPrefix = 'l'): ReactNode { const grandchildren = el.props.children; if (grandchildren === undefined) return child; return cloneElement(el, { + key: el.key ?? `linkified-${i}`, children: linkifyChildren(grandchildren, `${keyPrefix}-${i}`), }); }