Compare commits
10 Commits
v1.6.0-mob
...
934f739ca1
| Author | SHA1 | Date | |
|---|---|---|---|
| 934f739ca1 | |||
| e9895fd694 | |||
| 83c7d33f3c | |||
| c3415574d6 | |||
| 50a756aca1 | |||
| 3cb1ead5e2 | |||
| 5ee266a4d9 | |||
| c750ce9e62 | |||
| bbf9fac936 | |||
| 6fa6eb7f32 |
@@ -120,6 +120,15 @@ export function registerSessionRoutes(
|
||||
return { error: 'invalid body', details: parsed.error.flatten() };
|
||||
}
|
||||
const { name, model, system_prompt } = parsed.data;
|
||||
// Read the prior name so the post-update publish can skip no-op renames
|
||||
// (PATCH { name: "Foo" } where the session is already "Foo"). The window
|
||||
// between SELECT and UPDATE is sub-millisecond in the same request handler;
|
||||
// a concurrent rename in that gap would just mean one stale publish, which
|
||||
// existing clients dedup by id.
|
||||
const before = await sql<{ name: string }[]>`
|
||||
SELECT name FROM sessions WHERE id = ${req.params.id}
|
||||
`;
|
||||
const priorName = before[0]?.name;
|
||||
const rows = await sql<Session[]>`
|
||||
UPDATE sessions
|
||||
SET
|
||||
@@ -135,7 +144,7 @@ export function registerSessionRoutes(
|
||||
return { error: 'session not found' };
|
||||
}
|
||||
const session = rows[0]!;
|
||||
if (name !== undefined) {
|
||||
if (name !== undefined && session.name !== priorName) {
|
||||
broker.publishUser('default', {
|
||||
type: 'session_renamed',
|
||||
session_id: session.id,
|
||||
|
||||
@@ -144,4 +144,23 @@ export async function maybeAutoNameChat(
|
||||
updated_at: updated[0]!.updated_at,
|
||||
});
|
||||
ctx.log.info({ chatId, name }, 'chat auto-named');
|
||||
|
||||
// Propagate to the parent session if it's still on its default name.
|
||||
// The WHERE guard makes the check atomic — if the user has already
|
||||
// renamed (or a prior chat already propagated), this UPDATE matches
|
||||
// zero rows and we do nothing. First chat wins; manual renames win.
|
||||
const renamedSession = await ctx.sql<{ id: string; name: string }[]>`
|
||||
UPDATE sessions
|
||||
SET name = ${name}
|
||||
WHERE id = ${sessionId} AND name = 'New session'
|
||||
RETURNING id, name
|
||||
`;
|
||||
if (renamedSession.length > 0) {
|
||||
ctx.publishUser({
|
||||
type: 'session_renamed',
|
||||
session_id: sessionId,
|
||||
name,
|
||||
});
|
||||
ctx.log.info({ sessionId, name }, 'session auto-named from chat');
|
||||
}
|
||||
}
|
||||
|
||||
@@ -10,7 +10,7 @@ const BASE_SYSTEM_PROMPT = (projectPath: string) =>
|
||||
`You are BooCode Chat, a code investigation assistant. The user is working on a project located at ${projectPath}. Use the file-read tools (view_file, list_dir, grep, find_files) to investigate code when needed. Be concise. Cite file paths and line numbers when discussing code. Do not hallucinate file contents — read the file first. Tool results may be truncated; if so, narrow your query rather than guessing.`;
|
||||
|
||||
const DB_FLUSH_INTERVAL_MS = 500;
|
||||
const MAX_TOOL_LOOP_DEPTH = 5;
|
||||
const MAX_TOOL_LOOP_DEPTH = 15;
|
||||
|
||||
export interface InferenceFrame {
|
||||
type:
|
||||
|
||||
@@ -1,16 +1,26 @@
|
||||
import { useCallback, useEffect, useRef, useState, type KeyboardEvent } from 'react';
|
||||
import { useCallback, useEffect, useRef, useState, type DragEvent, type KeyboardEvent } from 'react';
|
||||
import { Send } from 'lucide-react';
|
||||
import { toast } from 'sonner';
|
||||
import { Textarea } from '@/components/ui/textarea';
|
||||
import { Button } from '@/components/ui/button';
|
||||
import { flattenToMessage, inferLanguage, type Attachment } from '@/lib/attachments';
|
||||
import {
|
||||
flattenToMessage,
|
||||
inferLanguage,
|
||||
looksBinary,
|
||||
MAX_FILE_SIZE_BYTES,
|
||||
PASTE_INLINE_MAX_LINES,
|
||||
type Attachment,
|
||||
} from '@/lib/attachments';
|
||||
import { AttachmentChip } from '@/components/AttachmentChip';
|
||||
import { AttachmentPreviewModal } from '@/components/AttachmentPreviewModal';
|
||||
import { FileMentionPopover } from '@/components/FileMentionPopover';
|
||||
import { DropOverlay } from '@/components/DropOverlay';
|
||||
import { api } from '@/api/client';
|
||||
import { sessionEvents } from '@/hooks/sessionEvents';
|
||||
import { useViewport } from '@/hooks/useViewport';
|
||||
|
||||
const MAX_ATTACHMENTS = 10;
|
||||
|
||||
interface Props {
|
||||
disabled?: boolean;
|
||||
projectId: string;
|
||||
@@ -24,6 +34,9 @@ export function ChatInput({ disabled, projectId, onSend, onForceSend }: Props) {
|
||||
const [busy, setBusy] = useState(false);
|
||||
const [attachments, setAttachments] = useState<Attachment[]>([]);
|
||||
const [previewAttachment, setPreviewAttachment] = useState<Attachment | null>(null);
|
||||
const [isDraggingOver, setIsDraggingOver] = useState(false);
|
||||
const dropRootRef = useRef<HTMLDivElement | null>(null);
|
||||
const pasteCounterRef = useRef(0);
|
||||
const [mentionState, setMentionState] = useState<{
|
||||
open: boolean;
|
||||
query: string;
|
||||
@@ -35,8 +48,8 @@ export function ChatInput({ disabled, projectId, onSend, onForceSend }: Props) {
|
||||
|
||||
function addAttachment(a: Attachment) {
|
||||
setAttachments(prev => {
|
||||
if (prev.length >= 10) {
|
||||
toast.error('Max 10 attachments per message');
|
||||
if (prev.length >= MAX_ATTACHMENTS) {
|
||||
toast.error(`Max ${MAX_ATTACHMENTS} attachments per message`);
|
||||
return prev;
|
||||
}
|
||||
return [...prev, a];
|
||||
@@ -185,6 +198,162 @@ export function ChatInput({ disabled, projectId, onSend, onForceSend }: Props) {
|
||||
|
||||
const closeMention = useCallback(() => setMentionState(null), []);
|
||||
|
||||
// ---- Drag & drop (F1 + F3 + F4) ----------------------------------------
|
||||
// The drop zone is the outer ChatInput container (ref'd as dropRootRef).
|
||||
// onDragLeave only clears the highlight when the cursor leaves the
|
||||
// container, not when it crosses into a child element.
|
||||
|
||||
async function processDroppedFile(file: File) {
|
||||
// Size gate
|
||||
if (file.size > MAX_FILE_SIZE_BYTES) {
|
||||
const mb = (file.size / (1024 * 1024)).toFixed(1);
|
||||
toast.error(`File ${file.name} is too large (${mb} MB). Limit is 5 MB.`);
|
||||
return;
|
||||
}
|
||||
// Read once as ArrayBuffer so we can do byte-level binary detection
|
||||
// before deciding whether to decode as text.
|
||||
let buf: ArrayBuffer;
|
||||
try {
|
||||
buf = await file.arrayBuffer();
|
||||
} catch (err) {
|
||||
toast.error(`Failed to read ${file.name}: ${err instanceof Error ? err.message : String(err)}`);
|
||||
return;
|
||||
}
|
||||
if (looksBinary(buf)) {
|
||||
toast.error(`${file.name} appears to be binary.`);
|
||||
return;
|
||||
}
|
||||
const text = new TextDecoder('utf-8', { fatal: false }).decode(buf);
|
||||
addAttachment({
|
||||
id: crypto.randomUUID(),
|
||||
kind: 'file',
|
||||
filename: file.name,
|
||||
language: inferLanguage(file.name),
|
||||
content: text,
|
||||
source: 'drop',
|
||||
});
|
||||
}
|
||||
|
||||
function isFolderItem(item: DataTransferItem | undefined): boolean {
|
||||
if (!item) return false;
|
||||
// webkitGetAsEntry is non-standard but supported in Chromium + Safari.
|
||||
// If unavailable, we conservatively treat the entry as a file.
|
||||
const entry =
|
||||
typeof item.webkitGetAsEntry === 'function' ? item.webkitGetAsEntry() : null;
|
||||
if (entry && entry.isDirectory) return true;
|
||||
// Heuristic fallback: folders dragged from Finder have type === '' and
|
||||
// a 0-byte File. The empty-type alone isn't reliable for files (some
|
||||
// plaintext drops also lack a type), so we only flag when the entry
|
||||
// explicitly says directory.
|
||||
return false;
|
||||
}
|
||||
|
||||
async function handleDroppedItems(dt: DataTransfer) {
|
||||
// Snapshot items first because reading files inside the loop can
|
||||
// detach the DataTransfer between awaits.
|
||||
const itemsArray: { file: File | null; isFolder: boolean }[] = [];
|
||||
if (dt.items && dt.items.length > 0) {
|
||||
for (let i = 0; i < dt.items.length; i++) {
|
||||
const it = dt.items[i];
|
||||
if (!it || it.kind !== 'file') continue;
|
||||
const folder = isFolderItem(it);
|
||||
const file = folder ? null : it.getAsFile();
|
||||
itemsArray.push({ file, isFolder: folder });
|
||||
}
|
||||
} else {
|
||||
for (let i = 0; i < dt.files.length; i++) {
|
||||
const f = dt.files[i];
|
||||
if (f) itemsArray.push({ file: f, isFolder: false });
|
||||
}
|
||||
}
|
||||
|
||||
let remainingSlots = MAX_ATTACHMENTS - attachments.length;
|
||||
let folderRejected = false;
|
||||
for (const { file, isFolder } of itemsArray) {
|
||||
if (isFolder) {
|
||||
if (!folderRejected) {
|
||||
toast.error('Folders are not supported');
|
||||
folderRejected = true;
|
||||
}
|
||||
continue;
|
||||
}
|
||||
if (!file) continue;
|
||||
if (remainingSlots <= 0) {
|
||||
toast.error(`Attachment limit reached (${MAX_ATTACHMENTS}).`);
|
||||
return;
|
||||
}
|
||||
await processDroppedFile(file);
|
||||
remainingSlots -= 1;
|
||||
}
|
||||
}
|
||||
|
||||
function onDragEnter(e: DragEvent<HTMLDivElement>) {
|
||||
if (disabled || busy) return;
|
||||
e.preventDefault();
|
||||
setIsDraggingOver(true);
|
||||
}
|
||||
|
||||
function onDragOver(e: DragEvent<HTMLDivElement>) {
|
||||
if (disabled || busy) return;
|
||||
e.preventDefault();
|
||||
e.dataTransfer.dropEffect = 'copy';
|
||||
}
|
||||
|
||||
function onDragLeave(e: DragEvent<HTMLDivElement>) {
|
||||
// Only clear when the cursor actually leaves the root container.
|
||||
// relatedTarget is the element being entered; if it's inside the root,
|
||||
// ignore — we're just crossing into a child.
|
||||
const root = dropRootRef.current;
|
||||
if (!root) return;
|
||||
const related = e.relatedTarget as Node | null;
|
||||
if (related && root.contains(related)) return;
|
||||
setIsDraggingOver(false);
|
||||
}
|
||||
|
||||
function onDrop(e: DragEvent<HTMLDivElement>) {
|
||||
e.preventDefault();
|
||||
setIsDraggingOver(false);
|
||||
if (disabled || busy) return;
|
||||
void handleDroppedItems(e.dataTransfer);
|
||||
}
|
||||
// ---- end Drag & drop -----------------------------------------------------
|
||||
|
||||
// ---- Paste-as-attachment (F2) -------------------------------------------
|
||||
// Pasting >PASTE_INLINE_MAX_LINES lines of text becomes a chip rather than
|
||||
// inline content. Image pastes are rejected with a toast. If both text and
|
||||
// image are present (e.g. screenshot tool that sets both), prefer text.
|
||||
|
||||
function onPaste(e: React.ClipboardEvent<HTMLTextAreaElement>) {
|
||||
const cd = e.clipboardData;
|
||||
if (!cd) return;
|
||||
const text = cd.getData('text/plain');
|
||||
const hasImage = Array.from(cd.items ?? []).some((it) =>
|
||||
it.type.startsWith('image/'),
|
||||
);
|
||||
if (text) {
|
||||
const lineCount = text.split('\n').length;
|
||||
if (lineCount > PASTE_INLINE_MAX_LINES) {
|
||||
e.preventDefault();
|
||||
pasteCounterRef.current += 1;
|
||||
addAttachment({
|
||||
id: crypto.randomUUID(),
|
||||
kind: 'paste',
|
||||
filename: `pasted-${pasteCounterRef.current}.txt`,
|
||||
language: 'plaintext',
|
||||
content: text,
|
||||
source: 'paste',
|
||||
});
|
||||
}
|
||||
// <= threshold: let default paste insert inline.
|
||||
return;
|
||||
}
|
||||
if (hasImage) {
|
||||
e.preventDefault();
|
||||
toast.error('Image paste is not supported. Drop a file or paste text.');
|
||||
}
|
||||
}
|
||||
// ---- end Paste-as-attachment --------------------------------------------
|
||||
|
||||
function onKeyDown(e: KeyboardEvent<HTMLTextAreaElement>) {
|
||||
if (mentionState?.open) return;
|
||||
// IME safety: never act on Enter while an IME composition is in flight
|
||||
@@ -228,7 +397,16 @@ export function ChatInput({ disabled, projectId, onSend, onForceSend }: Props) {
|
||||
}
|
||||
|
||||
return (
|
||||
<div className="border-t" style={{ paddingBottom: 'env(safe-area-inset-bottom)' }}>
|
||||
<div
|
||||
ref={dropRootRef}
|
||||
className="border-t relative"
|
||||
style={{ paddingBottom: 'env(safe-area-inset-bottom)' }}
|
||||
onDragEnter={onDragEnter}
|
||||
onDragOver={onDragOver}
|
||||
onDragLeave={onDragLeave}
|
||||
onDrop={onDrop}
|
||||
>
|
||||
<DropOverlay visible={isDraggingOver} />
|
||||
<div className="max-w-[1000px] mx-auto w-full">
|
||||
{attachments.length > 0 && (
|
||||
<div className="flex flex-wrap gap-1.5 px-4 pt-3">
|
||||
@@ -248,6 +426,7 @@ export function ChatInput({ disabled, projectId, onSend, onForceSend }: Props) {
|
||||
value={value}
|
||||
onChange={handleChange}
|
||||
onKeyDown={onKeyDown}
|
||||
onPaste={onPaste}
|
||||
placeholder={
|
||||
isMobile
|
||||
? 'Ask about this project. Tap send to submit.'
|
||||
|
||||
18
apps/web/src/components/DropOverlay.tsx
Normal file
18
apps/web/src/components/DropOverlay.tsx
Normal file
@@ -0,0 +1,18 @@
|
||||
interface Props {
|
||||
visible: boolean;
|
||||
}
|
||||
|
||||
// Visual cue layered over the ChatInput while a drag is in progress.
|
||||
// Pointer-events: none so the underlying drop handler still receives the
|
||||
// drop event. Renders nothing when not visible (cheap and out of layout).
|
||||
export function DropOverlay({ visible }: Props) {
|
||||
if (!visible) return null;
|
||||
return (
|
||||
<div
|
||||
className="absolute inset-0 z-10 pointer-events-none flex items-center justify-center rounded border-2 border-dashed border-primary bg-background/85"
|
||||
aria-hidden="true"
|
||||
>
|
||||
<div className="text-sm font-medium text-primary">Drop to attach</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -8,6 +8,34 @@ export type Attachment = {
|
||||
source: '@' | 'line-select' | 'drop' | 'paste';
|
||||
};
|
||||
|
||||
// v1.7: caps shared between drag-drop and paste-as-attachment so both paths
|
||||
// reject the same way. Match the existing 10-attachment cap in
|
||||
// ChatInput.addAttachment.
|
||||
export const MAX_FILE_SIZE_BYTES = 5 * 1024 * 1024; // 5 MB
|
||||
export const PASTE_INLINE_MAX_LINES = 8;
|
||||
|
||||
// First-8KB null-byte scan. Returns true if the content looks binary.
|
||||
// Accepts a string (post-decode), an ArrayBuffer (pre-decode), or a Uint8Array.
|
||||
// For binary files like PNG, scanning bytes is more reliable than scanning
|
||||
// post-UTF-8-decode strings because invalid sequences may be replaced rather
|
||||
// than preserved.
|
||||
export function looksBinary(content: string | ArrayBuffer | Uint8Array): boolean {
|
||||
const SCAN_BYTES = 8192;
|
||||
if (typeof content === 'string') {
|
||||
const max = Math.min(content.length, SCAN_BYTES);
|
||||
for (let i = 0; i < max; i++) {
|
||||
if (content.charCodeAt(i) === 0) return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
const bytes = content instanceof Uint8Array ? content : new Uint8Array(content);
|
||||
const max = Math.min(bytes.length, SCAN_BYTES);
|
||||
for (let i = 0; i < max; i++) {
|
||||
if (bytes[i] === 0) return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
export const LANG_MAP: Record<string, string> = {
|
||||
ts: 'typescript', tsx: 'tsx', js: 'javascript', jsx: 'jsx',
|
||||
mjs: 'javascript', cjs: 'javascript',
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import { useEffect, useState } from 'react';
|
||||
import { ChevronDown, ChevronRight, Folder, RotateCcw } from 'lucide-react';
|
||||
import { ChevronDown, ChevronRight, Folder, FolderTree, Menu, RotateCcw } from 'lucide-react';
|
||||
import { toast } from 'sonner';
|
||||
import { Button } from '@/components/ui/button';
|
||||
import { AddProjectModal } from '@/components/AddProjectModal';
|
||||
@@ -8,6 +8,9 @@ import { api } from '@/api/client';
|
||||
import type { Project } from '@/api/types';
|
||||
import { sessionEvents } from '@/hooks/sessionEvents';
|
||||
import { useSidebar } from '@/hooks/useSidebar';
|
||||
import { useSidebarDrawer } from '@/hooks/useSidebarDrawer';
|
||||
import { useRightRailDrawer } from '@/hooks/useRightRailDrawer';
|
||||
import { useViewport } from '@/hooks/useViewport';
|
||||
|
||||
export function Home() {
|
||||
const { data } = useSidebar();
|
||||
@@ -15,6 +18,9 @@ export function Home() {
|
||||
const [createOpen, setCreateOpen] = useState(false);
|
||||
const [archived, setArchived] = useState<Project[] | null>(null);
|
||||
const [showArchived, setShowArchived] = useState(false);
|
||||
const { setOpen: setSidebarOpen } = useSidebarDrawer();
|
||||
const { toggle: toggleRightRail } = useRightRailDrawer();
|
||||
const { isMobile } = useViewport();
|
||||
|
||||
const empty = data ? data.projects.length === 0 : false;
|
||||
|
||||
@@ -70,8 +76,32 @@ export function Home() {
|
||||
}
|
||||
|
||||
return (
|
||||
<div className="flex-1 flex flex-col items-center px-6 py-12 overflow-y-auto">
|
||||
<div className="w-full max-w-md space-y-6">
|
||||
<div className="flex-1 flex flex-col min-h-0">
|
||||
{isMobile && (
|
||||
<header
|
||||
className="border-b px-3 sm:px-4 py-2 flex items-center gap-1.5 shrink-0 text-sm"
|
||||
style={{ paddingTop: 'max(0.5rem, env(safe-area-inset-top))' }}
|
||||
>
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => setSidebarOpen(true)}
|
||||
className="inline-flex items-center justify-center -ml-1 min-w-[44px] min-h-[44px] rounded text-muted-foreground hover:bg-muted hover:text-foreground shrink-0"
|
||||
aria-label="Open sidebar"
|
||||
>
|
||||
<Menu className="size-5" />
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
onClick={toggleRightRail}
|
||||
className="inline-flex items-center justify-center -mr-1 ml-auto min-w-[44px] min-h-[44px] rounded text-muted-foreground hover:bg-muted hover:text-foreground shrink-0"
|
||||
aria-label="Toggle file browser"
|
||||
>
|
||||
<FolderTree className="size-5" />
|
||||
</button>
|
||||
</header>
|
||||
)}
|
||||
<div className="flex-1 flex flex-col items-center px-6 py-12 overflow-y-auto">
|
||||
<div className="w-full max-w-md space-y-6">
|
||||
<div className="text-center space-y-3">
|
||||
{empty ? (
|
||||
<>
|
||||
@@ -127,9 +157,10 @@ export function Home() {
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
<AddProjectModal open={addOpen} onOpenChange={setAddOpen} onAdded={() => {}} />
|
||||
<CreateProjectModal open={createOpen} onOpenChange={setCreateOpen} />
|
||||
</div>
|
||||
<AddProjectModal open={addOpen} onOpenChange={setAddOpen} onAdded={() => {}} />
|
||||
<CreateProjectModal open={createOpen} onOpenChange={setCreateOpen} />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -27,8 +27,9 @@ Live at `https://code.indifferentketchup.com` (Caddy → Authelia → Tailscale
|
||||
|v1.4 |Fork from message + delete message + header polish + housekeeping |✅ Merged |Was original “Batch 5” |
|
||||
|v1.5 |Refactor splits, vitest harness (23 tests), error-log surfacing, `/opt:ro` + `BOOTSTRAP_ROOT`, persistent context-window tracker |✅ Merged |— |
|
||||
|v1.5.1 |Bootstrap hotfix: git in container, SSH keypair, known_hosts, SSH URL rewrite, /opt/projects label |✅ Merged |`4a9f207` |
|
||||
|v1.6-mobile-pass|Mobile pass: drawer, pane stacking, long-press, swipe-to-close, pull-to-refresh, IME safety, safe-area, tap targets + H1 path-guard fix|🔄 Hand-back received, uncommitted|Was original “Batch 4” |
|
||||
|v1.6.1-cleanup |Stale code audit, overengineering audit, secrets hygiene, RightRail mobile fix |Planned (next) |— |
|
||||
|v1.6-mobile-pass|Mobile pass: drawer, pane stacking, long-press, swipe-to-close, pull-to-refresh, IME safety, safe-area, tap targets + H1 path-guard fix|✅ Merged |`57c883b..943ae7d` (6 commits) |
|
||||
|v1.6.1-cleanup |Mostly audit-only; one fix shipped: RightRail `max-md:hidden` wrapper. Audit reports for secrets, stale code, panes, mount scope, hand-rolled patterns deferred to follow-ups |✅ Merged |`6a9fe18` |
|
||||
|v1.6.2-mobile-ui-fixes|Mobile UI polish from device testing: kill single-pane navigator chrome, header rework, “New chat” in long-press menu, RightRail as mobile drawer (reverts v1.6.1 wrapper) |🔄 Hand-back received, uncommitted|— |
|
||||
|v1.7 |Drag-drop + paste-as-attachment (chip infra extension) |Planned |Was Batch 6 |
|
||||
|v1.8 |Settings drawer (system prompt per project + session, web search toggle) |Planned |Was Batch 7 |
|
||||
|v1.9 |Web search backend: SearXNG `web_search` + `web_fetch` tools |Planned |Was Batch 8 |
|
||||
@@ -139,15 +140,16 @@ Dockerfile (git installed in container), docker-compose.yml, project_bootstrap.t
|
||||
|
||||
-----
|
||||
|
||||
### v1.6-mobile-pass 🔄
|
||||
### v1.6-mobile-pass ✅
|
||||
|
||||
**Hand-back received, uncommitted on `v1.6-mobile-pass`.** 5-commit sequence proposed:
|
||||
**Merged via 6 commits `57c883b..943ae7d`** (5 functional + 1 docs):
|
||||
|
||||
1. `chore: fix resolveProjectPath whitelist-root bypass` (H1 — dropped `real !== whitelistReal` short-circuit; 23/23 pass).
|
||||
1. `feat(mobile): viewport hook + sidebar drawer + hamburger headers` (M1 + M2 + M6-header).
|
||||
1. `feat(mobile): single-pane stack + long-press tab menu + swipe-to-close` (M3 + M4 + A2).
|
||||
1. `feat(mobile): chat input keybinds + safe-area + tap targets + overflow safety` (M5 + M6-bottom + M7 + M8).
|
||||
1. `feat(mobile): pull-to-refresh sidebar list` (A1).
|
||||
1. `57c883b chore: fix resolveProjectPath whitelist-root bypass` (H1 — dropped `real !== whitelistReal` short-circuit; flipped the v1.5 BEHAVIOR GAP test; 23/23 pass).
|
||||
1. `a643b5f feat(mobile): viewport hook + sidebar drawer + hamburger headers` (M1 + M2 + M6-header).
|
||||
1. `cd897d6 feat(mobile): single-pane stack + long-press tab menu + swipe-to-close` (M3 + M4 + A2).
|
||||
1. `273eeac feat(mobile): chat input keybinds + safe-area + tap targets + overflow safety` (M5 + M6-bottom + M7 + M8).
|
||||
1. `4b5b9b2 feat(mobile): pull-to-refresh sidebar list` (A1).
|
||||
1. `943ae7d docs: add v1.x roadmap snapshot` (this file).
|
||||
|
||||
**Decisions:**
|
||||
|
||||
@@ -168,21 +170,41 @@ Dockerfile (git installed in container), docker-compose.yml, project_bootstrap.t
|
||||
|
||||
-----
|
||||
|
||||
### v1.6.1-cleanup — Stale + overengineering audit + secrets hygiene (next)
|
||||
### v1.6.1-cleanup ✅ (`6a9fe18`)
|
||||
|
||||
**Depends on:** v1.6 committed.
|
||||
**Shipped:** RightRail wrapped in `<div className="max-md:hidden contents">` so it's hidden entirely below the md breakpoint on mobile. (Note: v1.6.2 reverses this and replaces with a proper mobile drawer — see below.)
|
||||
|
||||
**Scope:**
|
||||
**Audited but not shipped (queued for follow-ups):**
|
||||
|
||||
1. RightRail mobile fix (`max-md:hidden` on outer container).
|
||||
1. Secrets audit: rotate `secrets/boocode_gitea`, confirm `.gitignore` covers `secrets/`, scan git history (`git log --all -- secrets/`), `git filter-repo` or BFG if exposed in history, force-push if rewriting.
|
||||
1. Fix agent SSH key path so future Claude Code dispatches don’t fall back to in-repo keys.
|
||||
1. Stale code audit: pruning unused exports, dead WS frames (e.g. `session_renamed` server publisher TODO from Batch 1), backup `.bak` files, unused imports.
|
||||
1. Overengineering audit: places where hand-rolled patterns are more complex than necessary, places where singleton hooks should consolidate (`useSessionStream` refcount).
|
||||
1. PATCH `/api/panes/:id` session-ownership check tightening.
|
||||
1. `/opt:/opt:ro` mount whitelist tightening (precursor to BooCoder).
|
||||
- **Secrets hygiene:** `secrets/boocode_gitea` is NOT tracked; never committed to any branch; `.gitignore` already covers `secrets/`. Rotation is a Gitea-side action, no repo change needed.
|
||||
- **`.bak` files:** 3 leftover from v1.5.1 (`docker-compose.yml.bak-20260516`, `Dockerfile.bak-20260516`, `apps/web/src/components/CreateProjectModal.tsx.bak-20260516`). Git-invisible via global `~/.gitignore_global` (`*.bak*`). Decide per file.
|
||||
- **Unused exports:** neither `knip` nor `ts-prune` installed. Proposal pending.
|
||||
- **Dead WS frames:** `session_renamed` HAS a server publisher (`routes/sessions.ts:140`, added in v1.4) — the roadmap's "no server publisher" open item is **STALE**, crossed off. The `InferenceFrame` union still declares `session_renamed` as a type variant but no code publishes it on the per-session channel; trivial 1-line cleanup deferred.
|
||||
- **Unused imports:** web `tsc --noUnusedLocals --noUnusedParameters` returns 0 warnings.
|
||||
- **`useSessionStream` refcount:** opportunity confirmed (~90 lines diff to apply the `useSidebar`-style module-scope singleton pattern). Risk LOW. Queued for v1.6.2 or later.
|
||||
- **PATCH `/api/panes/:id` ownership:** **MOOT** — endpoint does not exist (the pane REST API was never re-introduced after pane state moved to client-side localStorage in v1.2). Crossed off open items.
|
||||
- **Hand-rolled patterns vs library:** 5 hand-rolled hooks/components total 336 lines. None duplicates anything in existing deps; library swap (`@use-gesture`, `react-pull-to-refresh`) not worth the dep cost yet.
|
||||
- **`/opt:/opt:ro` mount tightening:** Two-option plan documented for v1.6.2 — Option A (per-project bind-mounts) or Option B (deny `.env` pattern in `pathGuard`). Option B is the simpler short-term fix.
|
||||
|
||||
**No new features. No schema changes.**
|
||||
-----
|
||||
|
||||
### v1.6.2-mobile-ui-fixes 🔄
|
||||
|
||||
**Hand-back received, uncommitted on `v1.6.2-mobile-ui-fixes`.** 4-commit sequence proposed:
|
||||
|
||||
1. `fix(mobile): hide Split button + single-pane navigator chrome` (G1 — wrap the Workspace Split row in `!isMobile`).
|
||||
1. `feat(mobile): rework Session and Project headers for narrow viewports` (G2 — breadcrumb `hidden sm:flex`, session name cap `max-w-[140px] sm:max-w-[280px]`, project page heading `text-base sm:text-lg`, “New session” icon-only on mobile).
|
||||
1. `feat(mobile): add "New chat" to tab long-press context menu` (G3 — top of menu, separator, then existing items).
|
||||
1. `feat(mobile): right-rail as drawer on mobile, header toggle button` (G4 option b — new `useRightRailDrawer` Context hook, `RightRail` renders as fixed `w-[85vw] max-w-sm` drawer on mobile, FolderTree button in Session header, **reverts v1.6.1's `max-md:hidden` wrapper**).
|
||||
|
||||
**Decisions:**
|
||||
|
||||
- G4 option b chosen: mobile file browsing IS useful; drawer pattern mirrors `useSidebarDrawer`.
|
||||
- G2 single-row session-name+model layout (model picker right-aligned), per spec example.
|
||||
- G3 "New chat" at top, separator, then Rename.
|
||||
- G2 "New session" button: icon-only on mobile via `<span className="hidden sm:inline">New session</span>`.
|
||||
|
||||
**Adjacent uncommitted change (not part of v1.6.2):** `MAX_TOOL_LOOP_DEPTH 5 → 15` in `apps/server/src/services/inference.ts`. Sam-authored, sitting in working tree on `v1.6.2-mobile-ui-fixes`. **NOT on main as of this update.** Commit separately.
|
||||
|
||||
-----
|
||||
|
||||
@@ -407,14 +429,17 @@ settings
|
||||
|
||||
## Known open items
|
||||
|
||||
- **`useSessionStream` refcount.** Two ChatPanes = two WS. Apply singleton pattern. Tracked in v1.6.1.
|
||||
- **PATCH `/api/panes/:id` lacks session-ownership check.** Single-user fine; tighten in v1.6.1.
|
||||
- **`/opt:/opt:ro` mount exposes all `.env` files.** Whitelist scope before BooCoder. Tracked in v1.6.1.
|
||||
- **`session_renamed` no server WS publisher.** Carried from Batch 2. Tracked in v1.6.1.
|
||||
- **`secrets/boocode_gitea` in repo.** v1.5.1 dispatch fallback. Rotation + history scrub in v1.6.1.
|
||||
- **`useSessionStream` refcount.** Two ChatPanes = two WS. Apply singleton pattern. Audited in v1.6.1, queued.
|
||||
- **`/opt:/opt:ro` mount exposes all `.env` files.** Whitelist scope before BooCoder. Two-option plan documented in v1.6.1 audit; ship in v1.6.2 or v1.7.
|
||||
- **`secrets/boocode_gitea` in repo working tree.** Never committed (git-invisible via global ignore). Rotate the Gitea-side key when convenient; no repo action required.
|
||||
- **Dormant in-boolab BooCode mode.** Reference only.
|
||||
- **BooCoder container.** Post-v1.x.
|
||||
|
||||
**Closed since last update:**
|
||||
|
||||
- ~~`session_renamed` no server WS publisher~~ — server publishes via `broker.publishUser` from `routes/sessions.ts:140` (added in v1.4). Confirmed in v1.6.1 audit.
|
||||
- ~~PATCH `/api/panes/:id` lacks session-ownership check~~ — endpoint does not exist; the pane REST API was never re-introduced after v1.2 moved pane state to localStorage.
|
||||
|
||||
-----
|
||||
|
||||
## Dependency graph
|
||||
@@ -456,7 +481,10 @@ v1.5.1 (bootstrap hotfix) │
|
||||
v1.6-mobile-pass │
|
||||
│ │
|
||||
▼ │
|
||||
v1.6.1-cleanup ◄─────────────┘
|
||||
v1.6.1-cleanup │
|
||||
│ │
|
||||
▼ │
|
||||
v1.6.2-mobile-ui-fixes ◄─────┘
|
||||
│
|
||||
▼
|
||||
v1.7 (drag-drop) ◄── v1.1-batch3.5
|
||||
|
||||
Reference in New Issue
Block a user