Compare commits
3 Commits
v2.7.6-age
...
main
| Author | SHA1 | Date | |
|---|---|---|---|
| 7098014261 | |||
| c56d169ef9 | |||
| b7fb254e5d |
@@ -2,6 +2,10 @@
|
|||||||
|
|
||||||
All notable changes per release tag. Most recent on top, ordered by tag creation date (which matches the git history). Tag names follow `vMAJOR.MINOR.PATCH-slug` — the slug describes what shipped, so the tag name alone is enough to recall the batch.
|
All notable changes per release tag. Most recent on top, ordered by tag creation date (which matches the git history). Tag names follow `vMAJOR.MINOR.PATCH-slug` — the slug describes what shipped, so the tag name alone is enough to recall the batch.
|
||||||
|
|
||||||
|
## v2.7.7-pane-header-actions — 2026-06-01
|
||||||
|
|
||||||
|
In-flight workspace UX work, committed alongside the v2.7 review batches. Extracts a shared `PaneHeaderActions` cluster (the +/Split/Reopen-closed-pane/Session-history/Close controls) used across the `ChatTabBar` and the desktop coder + terminal pane headers in `Workspace`, replacing the divergent per-header copies, with `SessionLandingPage` history enhancements and `useWorkspacePanes` tweaks. Also fixes a coder-side correctness bug: `resolveChatId` (`apps/coder/src/routes/chat-resolve.ts`) still read `sessions.workspace_panes` as a bare `WorkspacePane[]`, but `v2.6.5-panes-tabs-composer` widened it to a `WorkspaceState` envelope — so it mis-read the panes and, worse, clobbered `tabNumbers`/`nextTabNumber`/`closedPaneStack` back to a bare array on every pane-chat write; a new `normalizeWorkspaceState` accepts either shape and preserves the envelope (with a regression test). Plus a CLAUDE.md doc-sync (apps/coder vitest suite, deploy-by-surface, dual-remote push, in-flight-web-WIP staging, release-branch naming). Web tsc + coder build + coder tests green. Builds on `v2.7.6-agent-status-normalize`.
|
||||||
|
|
||||||
## v2.7.6-agent-status-normalize — 2026-06-01
|
## v2.7.6-agent-status-normalize — 2026-06-01
|
||||||
|
|
||||||
The scoped half of `boocode_code_review_v2.md` §1 #10 — normalized external-agent status, surfaced from BooCoder's own dispatch observation (the heavier config-injection notify-hook, clean-room from superset's ELv2 `agent-setup`, is documented as the follow-on). The review's premise ("PTY agents have no status") had partly aged out — warm-ACP/opencode/SDK already carry working/done — so the real gap was that BooCoder never *published* a normalized per-`(chat,agent)` status (blocked-on-permission was invisible; crash/idle weren't pushed). Adds an `agent_status_updated` WS frame (`working|blocked|idle|error`, server+web parity) published from the dispatcher's turn boundaries across all four external paths (warm-acp/opencode/sdk/pty — `working` at start, `idle`/`error` at end) and the permission flow (`blocked` on request, `working` on resolve), best-effort so it never breaks a turn. A clean-room `normalizeAgentEvent` helper (superset's ~30-vendor-event → Start/blocked/Stop collapse, reimplemented with the event names as facts) ships now with 25 tests so the deferred notify-hook injection reuses it verbatim. The `AgentComposerBar` gains a normalized status dot (working=spinner, blocked=amber, idle=gray, error=red) distinct from the WS-liveness dot, fed by a `useAgentStatus` map `CoderPane` tracks per `(chat,agent)`. Built by two parallel agents (data plane + view plane) against a pinned frame contract; server 545 + coder 294 tests passing (25 new), web tsc + builds clean, ws-frames parity green. Clears the actionable review backlog (#1/#3/#4/#6–#12). Builds on `v2.7.5-claude-sdk-sessionstore`; openspec `agent-status-normalize`.
|
The scoped half of `boocode_code_review_v2.md` §1 #10 — normalized external-agent status, surfaced from BooCoder's own dispatch observation (the heavier config-injection notify-hook, clean-room from superset's ELv2 `agent-setup`, is documented as the follow-on). The review's premise ("PTY agents have no status") had partly aged out — warm-ACP/opencode/SDK already carry working/done — so the real gap was that BooCoder never *published* a normalized per-`(chat,agent)` status (blocked-on-permission was invisible; crash/idle weren't pushed). Adds an `agent_status_updated` WS frame (`working|blocked|idle|error`, server+web parity) published from the dispatcher's turn boundaries across all four external paths (warm-acp/opencode/sdk/pty — `working` at start, `idle`/`error` at end) and the permission flow (`blocked` on request, `working` on resolve), best-effort so it never breaks a turn. A clean-room `normalizeAgentEvent` helper (superset's ~30-vendor-event → Start/blocked/Stop collapse, reimplemented with the event names as facts) ships now with 25 tests so the deferred notify-hook injection reuses it verbatim. The `AgentComposerBar` gains a normalized status dot (working=spinner, blocked=amber, idle=gray, error=red) distinct from the WS-liveness dot, fed by a `useAgentStatus` map `CoderPane` tracks per `(chat,agent)`. Built by two parallel agents (data plane + view plane) against a pinned frame contract; server 545 + coder 294 tests passing (25 new), web tsc + builds clean, ws-frames parity green. Clears the actionable review backlog (#1/#3/#4/#6–#12). Builds on `v2.7.5-claude-sdk-sessionstore`; openspec `agent-status-normalize`.
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ npx tsc -p apps/web/tsconfig.app.json --noEmit # web app specifically
|
|||||||
docker compose build --no-cache boocode && docker compose up -d
|
docker compose build --no-cache boocode && docker compose up -d
|
||||||
```
|
```
|
||||||
|
|
||||||
Tests: `pnpm -C apps/server test` runs the vitest suite. No test harness on `apps/web` (adding it requires installing vitest as a new devDep). Vitest pinned to `^3` because Vite 5 / vitest 4 are incompatible. No linters configured. Vitest include glob is `src/**/__tests__/**/*.test.ts` (see `apps/server/vitest.config.ts`) — tests outside `src/**/__tests__/` silently won't run; match the per-domain convention (`apps/server/src/services/__tests__/foo.test.ts`).
|
Tests: `pnpm -C apps/server test` runs the vitest suite. No test harness on `apps/web` (adding it requires installing vitest as a new devDep). Vitest pinned to `^3` because Vite 5 / vitest 4 are incompatible. No linters configured. Vitest include glob is `src/**/__tests__/**/*.test.ts` (see `apps/server/vitest.config.ts`) — tests outside `src/**/__tests__/` silently won't run; match the per-domain convention (`apps/server/src/services/__tests__/foo.test.ts`). `apps/coder` has its own vitest suite too — `pnpm -C apps/coder test` (same `src/**/__tests__/**/*.test.ts` glob; `globals:false`, so import `describe`/`it`/`expect` from `vitest`). Extract pure helpers to unit-test (`backends/turn-guard.ts`, `lifecycle-decisions.ts` are the pattern).
|
||||||
|
|
||||||
## Architecture
|
## Architecture
|
||||||
|
|
||||||
@@ -81,6 +81,7 @@ Route registration: all routes registered in `index.ts` via `register*Routes(app
|
|||||||
- **Workspace dependency on `@boocode/server`**: imports `createInferenceRunner`, `createBroker`, `ALL_TOOLS`, `appendMcpTools` from the server's compiled `dist/`. apps/server's `package.json` has an `exports` map with `types` conditions for NodeNext resolution. apps/server must build FIRST.
|
- **Workspace dependency on `@boocode/server`**: imports `createInferenceRunner`, `createBroker`, `ALL_TOOLS`, `appendMcpTools` from the server's compiled `dist/`. apps/server's `package.json` has an `exports` map with `types` conditions for NodeNext resolution. apps/server must build FIRST.
|
||||||
- Build + deploy: `pnpm -C apps/server build && pnpm -C apps/coder build && sudo systemctl restart boocoder`. Env file at `apps/coder/.env.host`. Service file at `/etc/systemd/system/boocoder.service`.
|
- Build + deploy: `pnpm -C apps/server build && pnpm -C apps/coder build && sudo systemctl restart boocoder`. Env file at `apps/coder/.env.host`. Service file at `/etc/systemd/system/boocoder.service`.
|
||||||
- After `pnpm -C apps/coder build` the host `boocoder.service` keeps running the OLD process until `sudo systemctl restart boocoder` — a stale process shows **new routes 404 with `{error:'not found'}` while old routes still 200** (the `/api` not-found handler returns that shape). Restart, don't re-debug.
|
- After `pnpm -C apps/coder build` the host `boocoder.service` keeps running the OLD process until `sudo systemctl restart boocoder` — a stale process shows **new routes 404 with `{error:'not found'}` while old routes still 200** (the `/api` not-found handler returns that shape). Restart, don't re-debug.
|
||||||
|
- **Deploy by surface:** an `apps/coder` change → `sudo systemctl restart boocoder`; an `apps/web` or `apps/server` change → `docker compose up --build -d boocode` (rebuilds web+server from the working tree). `:9502/api/health` is down ~15–20s after a boocoder restart while the startup agent-probe scan runs — retry; an early connection-refused is not a failed deploy.
|
||||||
- Agent dispatch spawns binaries directly using `install_path` from `available_agents` — no `spawn('sh', ['-c', ...])` (fails under systemd). Follows Paseo's pattern: `spawn(fullBinaryPath, argsArray, { cwd })`.
|
- Agent dispatch spawns binaries directly using `install_path` from `available_agents` — no `spawn('sh', ['-c', ...])` (fails under systemd). Follows Paseo's pattern: `spawn(fullBinaryPath, argsArray, { cwd })`.
|
||||||
- systemd hardening: only `NoNewPrivileges=true` is safe. `ProtectSystem`, `ProtectHome`, `PrivateTmp` all break agent dispatch (agents need full filesystem access to read configs, write to worktrees).
|
- systemd hardening: only `NoNewPrivileges=true` is safe. `ProtectSystem`, `ProtectHome`, `PrivateTmp` all break agent dispatch (agents need full filesystem access to read configs, write to worktrees).
|
||||||
- `apps/server/tsconfig.json` has `declaration: true` so `.d.ts` files exist for workspace consumers.
|
- `apps/server/tsconfig.json` has `declaration: true` so `.d.ts` files exist for workspace consumers.
|
||||||
@@ -148,12 +149,14 @@ BooCoder at port 9502: `curl http://100.114.205.53:9502/api/health`. Runs as `bo
|
|||||||
## Workflow
|
## Workflow
|
||||||
|
|
||||||
- Sam reviews all diffs and commits manually. Do not commit unless explicitly asked.
|
- Sam reviews all diffs and commits manually. Do not commit unless explicitly asked.
|
||||||
|
- Sam often has uncommitted `apps/web` work in flight mid-session — stage your own commits **explicitly by path** (never `git add -A`); and `docker compose up --build -d boocode` builds the working tree, so a container rebuild also ships his uncommitted web changes.
|
||||||
|
- Cutting a release: name the feature branch DIFFERENTLY from the tag (branch `f1-interrupt-guard`, tag `v2.6.7-interrupt-guard`) — identical branch+tag names trigger `warning: refname ... is ambiguous`.
|
||||||
- Per-batch docs live under `openspec/changes/<slug>/{proposal,tasks,design}.md`. Already-shipped batches are snapshots in `openspec/changes/archived/`. New batches follow the proposal+tasks shape; see `openspec/README.md` for the convention.
|
- Per-batch docs live under `openspec/changes/<slug>/{proposal,tasks,design}.md`. Already-shipped batches are snapshots in `openspec/changes/archived/`. New batches follow the proposal+tasks shape; see `openspec/README.md` for the convention.
|
||||||
- Tag naming: `vMAJOR.MINOR.PATCH-slug` (e.g. `v1.13.13-ws-publish`). Monotonic per minor — the slug describes the batch's content so the tag name alone is enough to recall what shipped. No letter suffixes (`-a`/`-b`), no pseudo-ranges (`v1.11.x`), no slug-only sub-versions sharing a number (`v1.13.15-tools` + `-openspec` + `-agentlint` — split into sequential patches instead).
|
- Tag naming: `vMAJOR.MINOR.PATCH-slug` (e.g. `v1.13.13-ws-publish`). Monotonic per minor — the slug describes the batch's content so the tag name alone is enough to recall what shipped. No letter suffixes (`-a`/`-b`), no pseudo-ranges (`v1.11.x`), no slug-only sub-versions sharing a number (`v1.13.15-tools` + `-openspec` + `-agentlint` — split into sequential patches instead).
|
||||||
- `CHANGELOG.md` is the per-tag release log, most-recent on top. When a new tag is created, add a `## <tag> — <YYYY-MM-DD>` section with a 3–6 sentence paragraph summarizing what shipped, drawn from the commit body. Cross-reference other tags by name when the batch builds on, fixes, or pairs with prior work (e.g. "pairs with `v1.13.12-ws-schemas`", "fixed in `v1.13.5-stability-bundle`"). No nested bullets — one paragraph.
|
- `CHANGELOG.md` is the per-tag release log, most-recent on top. When a new tag is created, add a `## <tag> — <YYYY-MM-DD>` section with a 3–6 sentence paragraph summarizing what shipped, drawn from the commit body. Cross-reference other tags by name when the batch builds on, fixes, or pairs with prior work (e.g. "pairs with `v1.13.12-ws-schemas`", "fixed in `v1.13.5-stability-bundle`"). No nested bullets — one paragraph.
|
||||||
- Deploy: `cd /opt/boocode && docker compose up --build -d` (or `docker compose build --no-cache boocode && docker compose up -d` if you suspect a layer-cache issue).
|
- Deploy: `cd /opt/boocode && docker compose up --build -d` (or `docker compose build --no-cache boocode && docker compose up -d` if you suspect a layer-cache issue).
|
||||||
- The `boocode` container is `build: .` — it builds web+server from the **working tree**, so uncommitted changes deploy. Web edits are live on the Vite dev server (HMR) but NOT on production (`:9500` / code.indifferentketchup.com) until `docker compose up --build -d boocode`.
|
- The `boocode` container is `build: .` — it builds web+server from the **working tree**, so uncommitted changes deploy. Web edits are live on the Vite dev server (HMR) but NOT on production (`:9500` / code.indifferentketchup.com) until `docker compose up --build -d boocode`.
|
||||||
- Git push to Gitea: `GIT_SSH_COMMAND="ssh -i /opt/boocode/secrets/boocode_gitea -o IdentitiesOnly=yes" git push origin <branch>`. The default agent identity is rejected; the in-repo deploy key (`secrets/`, gitignored) is the working one. Transient `Connection reset by peer` retries cleanly after `sleep 5`.
|
- Git push to Gitea: `GIT_SSH_COMMAND="ssh -i /opt/boocode/secrets/boocode_gitea -o IdentitiesOnly=yes" git push origin <branch>`. The default agent identity is rejected; the in-repo deploy key (`secrets/`, gitignored) is the working one. Transient `Connection reset by peer` retries cleanly after `sleep 5`. Keep both remotes synced: push `main` + the release tag to `origin` (Gitea, deploy key above) AND `backup` (`git@github.com:indifferentketchup/boocode.git`, default key).
|
||||||
- Don't accumulate `.bak-*` files. Clean them up in the same batch or immediately after merge.
|
- Don't accumulate `.bak-*` files. Clean them up in the same batch or immediately after merge.
|
||||||
- DB-integration tests opt-in via env var: `DATABASE_URL='postgres://boocode:devpass@localhost:5500/boochat' pnpm -C apps/server test`. Host port is 5500 (mapped from `boocode_db:5432`); password is `${POSTGRES_PASSWORD}` from `.env` (`devpass`), NOT the literal in `.env`'s `DATABASE_URL=postgres://boocode:Ketchup1479@boocode_db:5432/...` line. `psql` is not on the host PATH — for an interactive query use `docker exec boocode_db psql -U boocode -d boochat -c "..."`. Pattern: `describe.runIf(!!process.env.DATABASE_URL)(...)` with a `beforeAll` that applies the schema via `sql.unsafe(readFileSync(schemaPath))`. Tests skip cleanly when var is unset. `tool_cost_stats.test.ts` is the reference.
|
- DB-integration tests opt-in via env var: `DATABASE_URL='postgres://boocode:devpass@localhost:5500/boochat' pnpm -C apps/server test`. Host port is 5500 (mapped from `boocode_db:5432`); password is `${POSTGRES_PASSWORD}` from `.env` (`devpass`), NOT the literal in `.env`'s `DATABASE_URL=postgres://boocode:Ketchup1479@boocode_db:5432/...` line. `psql` is not on the host PATH — for an interactive query use `docker exec boocode_db psql -U boocode -d boochat -c "..."`. Pattern: `describe.runIf(!!process.env.DATABASE_URL)(...)` with a `beforeAll` that applies the schema via `sql.unsafe(readFileSync(schemaPath))`. Tests skip cleanly when var is unset. `tool_cost_stats.test.ts` is the reference.
|
||||||
- Host-side smoke endpoint: `curl http://100.114.205.53:9500/api/...`. The boocode container's port mapping binds to the Tailscale IP, not `0.0.0.0`, so `localhost:9500` doesn't work from the host shell. Same for booterm at `:9501`.
|
- Host-side smoke endpoint: `curl http://100.114.205.53:9500/api/...`. The boocode container's port mapping binds to the Tailscale IP, not `0.0.0.0`, so `localhost:9500` doesn't work from the host shell. Same for booterm at `:9501`.
|
||||||
|
|||||||
110
apps/coder/src/routes/__tests__/chat-resolve.test.ts
Normal file
110
apps/coder/src/routes/__tests__/chat-resolve.test.ts
Normal file
@@ -0,0 +1,110 @@
|
|||||||
|
import { describe, it, expect } from 'vitest';
|
||||||
|
import { resolveChatId } from '../chat-resolve.js';
|
||||||
|
import type { Sql } from '../../db.js';
|
||||||
|
|
||||||
|
// Mock the porsager/postgres surface that chat-resolve.ts uses: a tagged-template
|
||||||
|
// `tx` (dispatched by query substring), `tx.json`, and `sql.begin(fn)` which just
|
||||||
|
// runs fn(tx). Captures the value written back to workspace_panes so we can assert
|
||||||
|
// the WorkspaceState envelope survives the UPDATE.
|
||||||
|
interface MockState {
|
||||||
|
stored: unknown; // initial sessions.workspace_panes value
|
||||||
|
existingChatOpen: boolean; // whether `SELECT id FROM chats ...` finds the active chat
|
||||||
|
newChatId: string;
|
||||||
|
written?: unknown; // captured tx.json(...) payload from `UPDATE sessions`
|
||||||
|
inserted: boolean; // whether INSERT INTO chats ran
|
||||||
|
}
|
||||||
|
|
||||||
|
interface MockTx {
|
||||||
|
(strings: TemplateStringsArray): Promise<unknown>;
|
||||||
|
json: (v: unknown) => unknown;
|
||||||
|
}
|
||||||
|
|
||||||
|
function mockSql(state: MockState): Sql {
|
||||||
|
const tx = ((strings: TemplateStringsArray) => {
|
||||||
|
const q = strings.join('');
|
||||||
|
if (q.includes('SELECT workspace_panes FROM sessions')) {
|
||||||
|
return Promise.resolve([{ workspace_panes: state.stored }]);
|
||||||
|
}
|
||||||
|
if (q.includes('FROM chats')) {
|
||||||
|
return Promise.resolve(state.existingChatOpen ? [{ id: 'placeholder' }] : []);
|
||||||
|
}
|
||||||
|
if (q.includes('INSERT INTO chats')) {
|
||||||
|
state.inserted = true;
|
||||||
|
return Promise.resolve([{ id: state.newChatId }]);
|
||||||
|
}
|
||||||
|
if (q.includes('UPDATE sessions')) {
|
||||||
|
return Promise.resolve([]);
|
||||||
|
}
|
||||||
|
return Promise.resolve([]);
|
||||||
|
}) as unknown as MockTx;
|
||||||
|
tx.json = (v: unknown) => {
|
||||||
|
state.written = v;
|
||||||
|
return v;
|
||||||
|
};
|
||||||
|
const sql = {
|
||||||
|
begin: (fn: (t: Sql) => Promise<unknown>) => fn(tx as unknown as Sql),
|
||||||
|
};
|
||||||
|
return sql as unknown as Sql;
|
||||||
|
}
|
||||||
|
|
||||||
|
const ENVELOPE = () => ({
|
||||||
|
panes: [{ id: 'pane-1', kind: 'coder', chatIds: [] as string[], activeChatIdx: 0 }],
|
||||||
|
tabNumbers: { 'chat-x': 3 },
|
||||||
|
nextTabNumber: 7,
|
||||||
|
closedPaneStack: [{ kind: 'coder', chatIds: ['old'], activeChatIdx: 0 }],
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('resolveChatId — v2.6.5 WorkspaceState envelope', () => {
|
||||||
|
it('reads panes from the envelope without crashing (regression: panes.findIndex is not a function)', async () => {
|
||||||
|
const state: MockState = {
|
||||||
|
stored: ENVELOPE(),
|
||||||
|
existingChatOpen: false,
|
||||||
|
newChatId: 'new-chat-1',
|
||||||
|
inserted: false,
|
||||||
|
};
|
||||||
|
const chatId = await resolveChatId(mockSql(state), 'session-1', 'pane-1');
|
||||||
|
expect(chatId).toBe('new-chat-1');
|
||||||
|
expect(state.inserted).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('preserves the envelope (tabNumbers/nextTabNumber/closedPaneStack) on write-back', async () => {
|
||||||
|
const state: MockState = {
|
||||||
|
stored: ENVELOPE(),
|
||||||
|
existingChatOpen: false,
|
||||||
|
newChatId: 'new-chat-1',
|
||||||
|
inserted: false,
|
||||||
|
};
|
||||||
|
await resolveChatId(mockSql(state), 'session-1', 'pane-1');
|
||||||
|
const w = state.written as Record<string, unknown>;
|
||||||
|
expect(Array.isArray(w.panes)).toBe(true); // envelope, not a bare array
|
||||||
|
expect(w.tabNumbers).toEqual({ 'chat-x': 3 });
|
||||||
|
expect(w.nextTabNumber).toBe(7);
|
||||||
|
expect(w.closedPaneStack).toEqual([{ kind: 'coder', chatIds: ['old'], activeChatIdx: 0 }]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns the existing open chat when the pane already has one', async () => {
|
||||||
|
const env = ENVELOPE();
|
||||||
|
env.panes[0]!.chatIds = ['existing-1'];
|
||||||
|
const state: MockState = {
|
||||||
|
stored: env,
|
||||||
|
existingChatOpen: true,
|
||||||
|
newChatId: 'should-not-be-used',
|
||||||
|
inserted: false,
|
||||||
|
};
|
||||||
|
const chatId = await resolveChatId(mockSql(state), 'session-1', 'pane-1');
|
||||||
|
expect(chatId).toBe('existing-1');
|
||||||
|
expect(state.inserted).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('still accepts a legacy bare WorkspacePane[] array', async () => {
|
||||||
|
const state: MockState = {
|
||||||
|
stored: [{ id: 'pane-1', kind: 'coder', chatId: 'legacy-1', chatIds: ['legacy-1'], activeChatIdx: 0 }],
|
||||||
|
existingChatOpen: true,
|
||||||
|
newChatId: 'should-not-be-used',
|
||||||
|
inserted: false,
|
||||||
|
};
|
||||||
|
const chatId = await resolveChatId(mockSql(state), 'session-1', 'pane-1');
|
||||||
|
expect(chatId).toBe('legacy-1');
|
||||||
|
expect(state.inserted).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -8,6 +8,36 @@ interface WorkspacePaneRow {
|
|||||||
activeChatIdx?: number;
|
activeChatIdx?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// v2.6.5: sessions.workspace_panes widened from a bare WorkspacePane[] to a
|
||||||
|
// WorkspaceState envelope { panes, tabNumbers, nextTabNumber, closedPaneStack }.
|
||||||
|
// (See the union validator in apps/server routes/sessions.ts + normalizeWorkspaceState
|
||||||
|
// in apps/server read_tab_by_number.ts — this is the coder-side mirror.)
|
||||||
|
interface WorkspaceStateRow {
|
||||||
|
panes: WorkspacePaneRow[];
|
||||||
|
tabNumbers: Record<string, number>;
|
||||||
|
nextTabNumber: number;
|
||||||
|
closedPaneStack: unknown[];
|
||||||
|
}
|
||||||
|
|
||||||
|
// MIGRATION: the stored value may be the legacy bare array OR the envelope.
|
||||||
|
// Normalize to a full envelope so callers always read `.panes` as an array and
|
||||||
|
// write the envelope back intact (preserving tabNumbers/nextTabNumber/closedPaneStack).
|
||||||
|
export function normalizeWorkspaceState(v: unknown): WorkspaceStateRow {
|
||||||
|
if (Array.isArray(v)) {
|
||||||
|
return { panes: v as WorkspacePaneRow[], tabNumbers: {}, nextTabNumber: 1, closedPaneStack: [] };
|
||||||
|
}
|
||||||
|
if (v && typeof v === 'object' && Array.isArray((v as { panes?: unknown }).panes)) {
|
||||||
|
const env = v as Partial<WorkspaceStateRow>;
|
||||||
|
return {
|
||||||
|
panes: env.panes ?? [],
|
||||||
|
tabNumbers: env.tabNumbers ?? {},
|
||||||
|
nextTabNumber: env.nextTabNumber ?? 1,
|
||||||
|
closedPaneStack: env.closedPaneStack ?? [],
|
||||||
|
};
|
||||||
|
}
|
||||||
|
return { panes: [], tabNumbers: {}, nextTabNumber: 1, closedPaneStack: [] };
|
||||||
|
}
|
||||||
|
|
||||||
function chatNameForKind(kind: string): string {
|
function chatNameForKind(kind: string): string {
|
||||||
if (kind === 'coder' || kind === 'agent') return 'BooCoder';
|
if (kind === 'coder' || kind === 'agent') return 'BooCoder';
|
||||||
if (kind === 'terminal') return 'Terminal';
|
if (kind === 'terminal') return 'Terminal';
|
||||||
@@ -28,12 +58,13 @@ export async function resolveChatId(
|
|||||||
paneId: string,
|
paneId: string,
|
||||||
): Promise<string | null> {
|
): Promise<string | null> {
|
||||||
return sql.begin(async (tx) => {
|
return sql.begin(async (tx) => {
|
||||||
const sessionRows = await tx<{ workspace_panes: WorkspacePaneRow[] }[]>`
|
const sessionRows = await tx<{ workspace_panes: unknown }[]>`
|
||||||
SELECT workspace_panes FROM sessions WHERE id = ${sessionId} FOR UPDATE
|
SELECT workspace_panes FROM sessions WHERE id = ${sessionId} FOR UPDATE
|
||||||
`;
|
`;
|
||||||
if (sessionRows.length === 0) return null;
|
if (sessionRows.length === 0) return null;
|
||||||
|
|
||||||
const panes = sessionRows[0]!.workspace_panes ?? [];
|
const state = normalizeWorkspaceState(sessionRows[0]!.workspace_panes);
|
||||||
|
const panes = state.panes;
|
||||||
const paneIdx = panes.findIndex((p) => p.id === paneId);
|
const paneIdx = panes.findIndex((p) => p.id === paneId);
|
||||||
if (paneIdx < 0) return null;
|
if (paneIdx < 0) return null;
|
||||||
|
|
||||||
@@ -69,9 +100,10 @@ export async function resolveChatId(
|
|||||||
: p,
|
: p,
|
||||||
);
|
);
|
||||||
|
|
||||||
|
const nextState: WorkspaceStateRow = { ...state, panes: nextPanes };
|
||||||
await tx`
|
await tx`
|
||||||
UPDATE sessions
|
UPDATE sessions
|
||||||
SET workspace_panes = ${tx.json(nextPanes as never)},
|
SET workspace_panes = ${tx.json(nextState as never)},
|
||||||
updated_at = clock_timestamp()
|
updated_at = clock_timestamp()
|
||||||
WHERE id = ${sessionId}
|
WHERE id = ${sessionId}
|
||||||
`;
|
`;
|
||||||
|
|||||||
@@ -1,7 +1,8 @@
|
|||||||
import { useState } from 'react';
|
import { useState } from 'react';
|
||||||
import { Code, Columns2, History, MessageSquare, Plus, RotateCcw, Terminal, X } from 'lucide-react';
|
import { History, MessageSquare, X } from 'lucide-react';
|
||||||
import type { Chat, WorkspacePane } from '@/api/types';
|
import type { Chat, WorkspacePane } from '@/api/types';
|
||||||
import { StatusDot } from '@/components/StatusDot';
|
import { StatusDot } from '@/components/StatusDot';
|
||||||
|
import { PaneHeaderActions } from '@/components/PaneHeaderActions';
|
||||||
import {
|
import {
|
||||||
ContextMenu,
|
ContextMenu,
|
||||||
ContextMenuContent,
|
ContextMenuContent,
|
||||||
@@ -9,12 +10,6 @@ import {
|
|||||||
ContextMenuSeparator,
|
ContextMenuSeparator,
|
||||||
ContextMenuTrigger,
|
ContextMenuTrigger,
|
||||||
} from '@/components/ui/context-menu';
|
} from '@/components/ui/context-menu';
|
||||||
import {
|
|
||||||
DropdownMenu,
|
|
||||||
DropdownMenuContent,
|
|
||||||
DropdownMenuItem,
|
|
||||||
DropdownMenuTrigger,
|
|
||||||
} from '@/components/ui/dropdown-menu';
|
|
||||||
import { useLongPress } from '@/hooks/useLongPress';
|
import { useLongPress } from '@/hooks/useLongPress';
|
||||||
import { sessionEvents } from '@/hooks/sessionEvents';
|
import { sessionEvents } from '@/hooks/sessionEvents';
|
||||||
import { cn } from '@/lib/utils';
|
import { cn } from '@/lib/utils';
|
||||||
@@ -191,90 +186,15 @@ export function ChatTabBar({
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
<div className="flex items-center ml-auto gap-0.5 px-1 shrink-0">
|
<PaneHeaderActions
|
||||||
<DropdownMenu>
|
className="ml-auto px-1"
|
||||||
<DropdownMenuTrigger asChild>
|
onNewTab={onNewTab}
|
||||||
<button
|
onSplitPane={onSplitPane}
|
||||||
type="button"
|
onReopenPane={onReopenPane}
|
||||||
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
onShowHistory={onShowHistory}
|
||||||
aria-label="New chat, terminal, or coder"
|
onRemovePane={onRemovePane}
|
||||||
title="New chat / terminal / coder"
|
historyActive={pane.kind === 'empty'}
|
||||||
>
|
/>
|
||||||
<Plus size={12} />
|
|
||||||
</button>
|
|
||||||
</DropdownMenuTrigger>
|
|
||||||
<DropdownMenuContent align="end" className="w-fit">
|
|
||||||
{/* New BooChat opens a tab in THIS pane; terminal/coder can't be
|
|
||||||
tabs, so they split into a new pane (matches the Split menu). */}
|
|
||||||
<DropdownMenuItem onSelect={onNewTab}>
|
|
||||||
<MessageSquare size={14} /> New BooChat
|
|
||||||
</DropdownMenuItem>
|
|
||||||
<DropdownMenuItem onSelect={() => onSplitPane('terminal')}>
|
|
||||||
<Terminal size={14} /> New BooTerm
|
|
||||||
</DropdownMenuItem>
|
|
||||||
<DropdownMenuItem onSelect={() => onSplitPane('coder')}>
|
|
||||||
<Code size={14} /> New BooCode
|
|
||||||
</DropdownMenuItem>
|
|
||||||
</DropdownMenuContent>
|
|
||||||
</DropdownMenu>
|
|
||||||
<DropdownMenu>
|
|
||||||
<DropdownMenuTrigger asChild>
|
|
||||||
<button
|
|
||||||
type="button"
|
|
||||||
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
|
||||||
aria-label="Split pane"
|
|
||||||
title="Split pane"
|
|
||||||
>
|
|
||||||
<Columns2 size={12} />
|
|
||||||
</button>
|
|
||||||
</DropdownMenuTrigger>
|
|
||||||
<DropdownMenuContent align="end" className="w-fit">
|
|
||||||
<DropdownMenuItem onSelect={() => onSplitPane('chat')}>
|
|
||||||
<MessageSquare size={14} /> New BooChat
|
|
||||||
</DropdownMenuItem>
|
|
||||||
<DropdownMenuItem onSelect={() => onSplitPane('terminal')}>
|
|
||||||
<Terminal size={14} /> New BooTerm
|
|
||||||
</DropdownMenuItem>
|
|
||||||
<DropdownMenuItem onSelect={() => onSplitPane('coder')}>
|
|
||||||
<Code size={14} /> New BooCode
|
|
||||||
</DropdownMenuItem>
|
|
||||||
</DropdownMenuContent>
|
|
||||||
</DropdownMenu>
|
|
||||||
{onReopenPane && (
|
|
||||||
<button
|
|
||||||
type="button"
|
|
||||||
onClick={onReopenPane}
|
|
||||||
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
|
||||||
aria-label="Reopen closed pane"
|
|
||||||
title="Reopen closed pane"
|
|
||||||
>
|
|
||||||
<RotateCcw size={12} />
|
|
||||||
</button>
|
|
||||||
)}
|
|
||||||
<button
|
|
||||||
type="button"
|
|
||||||
onClick={onShowHistory}
|
|
||||||
className={cn(
|
|
||||||
'inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]',
|
|
||||||
pane.kind === 'empty' && 'text-foreground bg-muted/50'
|
|
||||||
)}
|
|
||||||
aria-label="Session history"
|
|
||||||
title="Session history"
|
|
||||||
>
|
|
||||||
<History size={12} />
|
|
||||||
</button>
|
|
||||||
{onRemovePane && (
|
|
||||||
<button
|
|
||||||
type="button"
|
|
||||||
onClick={onRemovePane}
|
|
||||||
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
|
||||||
aria-label="Close pane"
|
|
||||||
title="Close pane"
|
|
||||||
>
|
|
||||||
<X size={12} />
|
|
||||||
</button>
|
|
||||||
)}
|
|
||||||
</div>
|
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
139
apps/web/src/components/PaneHeaderActions.tsx
Normal file
139
apps/web/src/components/PaneHeaderActions.tsx
Normal file
@@ -0,0 +1,139 @@
|
|||||||
|
import { Code, Columns2, History, MessageSquare, Plus, RotateCcw, Terminal, X } from 'lucide-react';
|
||||||
|
import {
|
||||||
|
DropdownMenu,
|
||||||
|
DropdownMenuContent,
|
||||||
|
DropdownMenuItem,
|
||||||
|
DropdownMenuTrigger,
|
||||||
|
} from '@/components/ui/dropdown-menu';
|
||||||
|
import { cn } from '@/lib/utils';
|
||||||
|
|
||||||
|
// Shared pane-header action cluster: + (new) / Split / Reopen-closed-pane /
|
||||||
|
// Session history / Close. Rendered in the chat tab bar (ChatTabBar) and the
|
||||||
|
// desktop coder + terminal pane headers (Workspace) so all pane kinds share one
|
||||||
|
// control set. Extracted to avoid a divergent copy per header.
|
||||||
|
interface Props {
|
||||||
|
// When provided (chat panes), the "+" menu's New BooChat opens an in-pane
|
||||||
|
// tab. When omitted (coder/terminal panes, which can't host tabs), New BooChat
|
||||||
|
// splits into a new pane instead.
|
||||||
|
onNewTab?: () => void;
|
||||||
|
onSplitPane: (kind: 'chat' | 'terminal' | 'coder') => void;
|
||||||
|
onReopenPane?: () => void;
|
||||||
|
onShowHistory: () => void;
|
||||||
|
onRemovePane?: () => void;
|
||||||
|
// Highlights the History button when the pane is showing the landing page.
|
||||||
|
historyActive?: boolean;
|
||||||
|
// Positioning/spacing supplied by the parent (e.g. "ml-auto px-1").
|
||||||
|
className?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
const BTN =
|
||||||
|
'inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]';
|
||||||
|
|
||||||
|
export function PaneHeaderActions({
|
||||||
|
onNewTab,
|
||||||
|
onSplitPane,
|
||||||
|
onReopenPane,
|
||||||
|
onShowHistory,
|
||||||
|
onRemovePane,
|
||||||
|
historyActive,
|
||||||
|
className,
|
||||||
|
}: Props) {
|
||||||
|
return (
|
||||||
|
<div className={cn('flex items-center gap-0.5 shrink-0', className)}>
|
||||||
|
<DropdownMenu>
|
||||||
|
<DropdownMenuTrigger asChild>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={(e) => e.stopPropagation()}
|
||||||
|
className={BTN}
|
||||||
|
aria-label="New chat, terminal, or coder"
|
||||||
|
title="New chat / terminal / coder"
|
||||||
|
>
|
||||||
|
<Plus size={12} />
|
||||||
|
</button>
|
||||||
|
</DropdownMenuTrigger>
|
||||||
|
<DropdownMenuContent align="end" className="w-fit">
|
||||||
|
{/* Chat panes: New BooChat opens a tab in THIS pane. Coder/terminal
|
||||||
|
panes can't host tabs, so it splits into a new pane. */}
|
||||||
|
<DropdownMenuItem onSelect={onNewTab ?? (() => onSplitPane('chat'))}>
|
||||||
|
<MessageSquare size={14} /> New BooChat
|
||||||
|
</DropdownMenuItem>
|
||||||
|
<DropdownMenuItem onSelect={() => onSplitPane('terminal')}>
|
||||||
|
<Terminal size={14} /> New BooTerm
|
||||||
|
</DropdownMenuItem>
|
||||||
|
<DropdownMenuItem onSelect={() => onSplitPane('coder')}>
|
||||||
|
<Code size={14} /> New BooCode
|
||||||
|
</DropdownMenuItem>
|
||||||
|
</DropdownMenuContent>
|
||||||
|
</DropdownMenu>
|
||||||
|
|
||||||
|
<DropdownMenu>
|
||||||
|
<DropdownMenuTrigger asChild>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={(e) => e.stopPropagation()}
|
||||||
|
className={cn(BTN, 'max-md:hidden')}
|
||||||
|
aria-label="Split pane"
|
||||||
|
title="Split pane"
|
||||||
|
>
|
||||||
|
<Columns2 size={12} />
|
||||||
|
</button>
|
||||||
|
</DropdownMenuTrigger>
|
||||||
|
<DropdownMenuContent align="end" className="w-fit">
|
||||||
|
<DropdownMenuItem onSelect={() => onSplitPane('chat')}>
|
||||||
|
<MessageSquare size={14} /> New BooChat
|
||||||
|
</DropdownMenuItem>
|
||||||
|
<DropdownMenuItem onSelect={() => onSplitPane('terminal')}>
|
||||||
|
<Terminal size={14} /> New BooTerm
|
||||||
|
</DropdownMenuItem>
|
||||||
|
<DropdownMenuItem onSelect={() => onSplitPane('coder')}>
|
||||||
|
<Code size={14} /> New BooCode
|
||||||
|
</DropdownMenuItem>
|
||||||
|
</DropdownMenuContent>
|
||||||
|
</DropdownMenu>
|
||||||
|
|
||||||
|
{onReopenPane && (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={(e) => {
|
||||||
|
e.stopPropagation();
|
||||||
|
onReopenPane();
|
||||||
|
}}
|
||||||
|
className={cn(BTN, 'max-md:hidden')}
|
||||||
|
aria-label="Reopen closed pane"
|
||||||
|
title="Reopen closed pane"
|
||||||
|
>
|
||||||
|
<RotateCcw size={12} />
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={(e) => {
|
||||||
|
e.stopPropagation();
|
||||||
|
onShowHistory();
|
||||||
|
}}
|
||||||
|
className={cn(BTN, 'max-md:hidden', historyActive && 'text-foreground bg-muted/50')}
|
||||||
|
aria-label="Session history"
|
||||||
|
title="Session history"
|
||||||
|
>
|
||||||
|
<History size={12} />
|
||||||
|
</button>
|
||||||
|
|
||||||
|
{onRemovePane && (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={(e) => {
|
||||||
|
e.stopPropagation();
|
||||||
|
onRemovePane();
|
||||||
|
}}
|
||||||
|
className={BTN}
|
||||||
|
aria-label="Close pane"
|
||||||
|
title="Close pane"
|
||||||
|
>
|
||||||
|
<X size={12} />
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -1,7 +1,15 @@
|
|||||||
import { useCallback, useEffect, useState } from 'react';
|
import { useCallback, useEffect, useState } from 'react';
|
||||||
import { Archive, MessageSquare, RotateCcw } from 'lucide-react';
|
import { Archive, Code, MessageSquare, RotateCcw, Terminal, Trash2 } from 'lucide-react';
|
||||||
import { toast } from 'sonner';
|
import { toast } from 'sonner';
|
||||||
import { ChatInput } from '@/components/ChatInput';
|
import { ChatInput } from '@/components/ChatInput';
|
||||||
|
import { Button } from '@/components/ui/button';
|
||||||
|
import {
|
||||||
|
Dialog,
|
||||||
|
DialogContent,
|
||||||
|
DialogDescription,
|
||||||
|
DialogHeader,
|
||||||
|
DialogTitle,
|
||||||
|
} from '@/components/ui/dialog';
|
||||||
import { api } from '@/api/client';
|
import { api } from '@/api/client';
|
||||||
import type { Chat } from '@/api/types';
|
import type { Chat } from '@/api/types';
|
||||||
|
|
||||||
@@ -22,6 +30,8 @@ interface Props {
|
|||||||
chats: Chat[];
|
chats: Chat[];
|
||||||
onOpenChat: (chatId: string) => void;
|
onOpenChat: (chatId: string) => void;
|
||||||
onUnarchiveChat: (chatId: string) => Promise<void>;
|
onUnarchiveChat: (chatId: string) => Promise<void>;
|
||||||
|
onArchiveChat: (chatId: string) => Promise<void>;
|
||||||
|
onDeleteChat: (chatId: string) => Promise<void>;
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatRelative(iso: string): string {
|
function formatRelative(iso: string): string {
|
||||||
@@ -42,6 +52,16 @@ function byRecent(a: Chat, b: Chat): number {
|
|||||||
return (b.updated_at ?? '').localeCompare(a.updated_at ?? '');
|
return (b.updated_at ?? '').localeCompare(a.updated_at ?? '');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Pick the row icon by the chat's seed name: coder and terminal panes create
|
||||||
|
// placeholder chats named 'BooCoder' / 'Terminal' (see useWorkspacePanes
|
||||||
|
// chatNameForPaneKind + the coder chat-resolve). A name heuristic keeps this
|
||||||
|
// frontend-only — matches ProjectSidebar's isCoderSessionName approach.
|
||||||
|
function iconForChat(name: string | null) {
|
||||||
|
if (name === 'BooCoder') return Code;
|
||||||
|
if (name === 'Terminal') return Terminal;
|
||||||
|
return MessageSquare;
|
||||||
|
}
|
||||||
|
|
||||||
export function SessionLandingPage({
|
export function SessionLandingPage({
|
||||||
projectId,
|
projectId,
|
||||||
sessionId,
|
sessionId,
|
||||||
@@ -53,9 +73,13 @@ export function SessionLandingPage({
|
|||||||
chats,
|
chats,
|
||||||
onOpenChat,
|
onOpenChat,
|
||||||
onUnarchiveChat,
|
onUnarchiveChat,
|
||||||
|
onArchiveChat,
|
||||||
|
onDeleteChat,
|
||||||
}: Props) {
|
}: Props) {
|
||||||
const [chatId, setChatId] = useState<string | null>(null);
|
const [chatId, setChatId] = useState<string | null>(null);
|
||||||
const [archived, setArchived] = useState<Chat[]>([]);
|
const [archived, setArchived] = useState<Chat[]>([]);
|
||||||
|
// Plain Cancel/Confirm delete (no type-to-confirm), mirroring ProjectSidebar.
|
||||||
|
const [deleteConfirm, setDeleteConfirm] = useState<{ id: string; name: string | null } | null>(null);
|
||||||
|
|
||||||
// Archived chats aren't in the default (open-only) list, so fetch them. One
|
// Archived chats aren't in the default (open-only) list, so fetch them. One
|
||||||
// shot on session change — the history view is transient (pick a chat and
|
// shot on session change — the history view is transient (pick a chat and
|
||||||
@@ -130,14 +154,19 @@ export function SessionLandingPage({
|
|||||||
Conversations
|
Conversations
|
||||||
</h3>
|
</h3>
|
||||||
<div className="space-y-0.5 mb-4">
|
<div className="space-y-0.5 mb-4">
|
||||||
{openChats.map((c) => (
|
{openChats.map((c) => {
|
||||||
<button
|
const Icon = iconForChat(c.name);
|
||||||
|
return (
|
||||||
|
<div
|
||||||
key={c.id}
|
key={c.id}
|
||||||
|
className="group/row flex items-center gap-2 px-2 py-1.5 rounded hover:bg-muted text-sm max-md:min-h-[44px]"
|
||||||
|
>
|
||||||
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
onClick={() => onOpenChat(c.id)}
|
onClick={() => onOpenChat(c.id)}
|
||||||
className="w-full flex items-center gap-2 text-left px-2 py-1.5 rounded hover:bg-muted text-sm max-md:min-h-[44px]"
|
className="flex items-center gap-2 flex-1 min-w-0 text-left"
|
||||||
>
|
>
|
||||||
<MessageSquare size={14} className="shrink-0 text-muted-foreground" />
|
<Icon size={14} className="shrink-0 text-muted-foreground" />
|
||||||
<span className="truncate shrink-0 max-w-[45%]">{c.name ?? 'New chat'}</span>
|
<span className="truncate shrink-0 max-w-[45%]">{c.name ?? 'New chat'}</span>
|
||||||
{c.last_message_preview && (
|
{c.last_message_preview && (
|
||||||
<span className="truncate flex-1 text-xs text-muted-foreground hidden sm:block">
|
<span className="truncate flex-1 text-xs text-muted-foreground hidden sm:block">
|
||||||
@@ -148,7 +177,29 @@ export function SessionLandingPage({
|
|||||||
{formatRelative(c.updated_at)}
|
{formatRelative(c.updated_at)}
|
||||||
</span>
|
</span>
|
||||||
</button>
|
</button>
|
||||||
))}
|
<div className="shrink-0 flex items-center gap-0.5 opacity-0 group-hover/row:opacity-100 focus-within:opacity-100 transition-opacity">
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={(e) => { e.stopPropagation(); void onArchiveChat(c.id); }}
|
||||||
|
className="inline-flex items-center justify-center size-7 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:size-9"
|
||||||
|
aria-label="Archive chat"
|
||||||
|
title="Archive"
|
||||||
|
>
|
||||||
|
<Archive size={14} />
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={(e) => { e.stopPropagation(); setDeleteConfirm({ id: c.id, name: c.name }); }}
|
||||||
|
className="inline-flex items-center justify-center size-7 rounded text-muted-foreground hover:bg-destructive/20 hover:text-destructive max-md:size-9"
|
||||||
|
aria-label="Delete chat"
|
||||||
|
title="Delete"
|
||||||
|
>
|
||||||
|
<Trash2 size={14} />
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
})}
|
||||||
</div>
|
</div>
|
||||||
</>
|
</>
|
||||||
)}
|
)}
|
||||||
@@ -159,12 +210,15 @@ export function SessionLandingPage({
|
|||||||
</h3>
|
</h3>
|
||||||
<div className="space-y-0.5">
|
<div className="space-y-0.5">
|
||||||
{archivedChats.map((c) => (
|
{archivedChats.map((c) => (
|
||||||
<button
|
<div
|
||||||
key={c.id}
|
key={c.id}
|
||||||
|
className="group/arch flex items-center gap-2 px-2 py-1.5 rounded hover:bg-muted text-sm text-muted-foreground max-md:min-h-[44px]"
|
||||||
|
>
|
||||||
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
onClick={() => void restoreAndOpen(c.id)}
|
onClick={() => void restoreAndOpen(c.id)}
|
||||||
title="Restore and open"
|
title="Restore and open"
|
||||||
className="group/arch w-full flex items-center gap-2 text-left px-2 py-1.5 rounded hover:bg-muted text-sm text-muted-foreground max-md:min-h-[44px]"
|
className="flex items-center gap-2 flex-1 min-w-0 text-left"
|
||||||
>
|
>
|
||||||
<Archive size={14} className="shrink-0" />
|
<Archive size={14} className="shrink-0" />
|
||||||
<span className="truncate flex-1">{c.name ?? 'New chat'}</span>
|
<span className="truncate flex-1">{c.name ?? 'New chat'}</span>
|
||||||
@@ -174,6 +228,16 @@ export function SessionLandingPage({
|
|||||||
className="shrink-0 opacity-0 group-hover/arch:opacity-100"
|
className="shrink-0 opacity-0 group-hover/arch:opacity-100"
|
||||||
/>
|
/>
|
||||||
</button>
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={(e) => { e.stopPropagation(); setDeleteConfirm({ id: c.id, name: c.name }); }}
|
||||||
|
className="shrink-0 inline-flex items-center justify-center size-7 rounded hover:bg-destructive/20 hover:text-destructive max-md:size-9 opacity-0 group-hover/arch:opacity-100 focus-within:opacity-100 transition-opacity"
|
||||||
|
aria-label="Delete chat"
|
||||||
|
title="Delete"
|
||||||
|
>
|
||||||
|
<Trash2 size={14} />
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
</>
|
</>
|
||||||
@@ -195,6 +259,31 @@ export function SessionLandingPage({
|
|||||||
messages={[]}
|
messages={[]}
|
||||||
modelContextLimit={null}
|
modelContextLimit={null}
|
||||||
/>
|
/>
|
||||||
|
<Dialog
|
||||||
|
open={deleteConfirm !== null}
|
||||||
|
onOpenChange={(open) => { if (!open) setDeleteConfirm(null); }}
|
||||||
|
>
|
||||||
|
<DialogContent>
|
||||||
|
<DialogHeader>
|
||||||
|
<DialogTitle>Delete chat?</DialogTitle>
|
||||||
|
<DialogDescription>
|
||||||
|
Permanently deletes "{deleteConfirm?.name ?? 'New chat'}" and all its messages. This cannot be undone.
|
||||||
|
</DialogDescription>
|
||||||
|
</DialogHeader>
|
||||||
|
<div className="flex gap-2 justify-end pt-2">
|
||||||
|
<Button variant="outline" onClick={() => setDeleteConfirm(null)}>Cancel</Button>
|
||||||
|
<Button
|
||||||
|
variant="destructive"
|
||||||
|
onClick={() => {
|
||||||
|
if (deleteConfirm) void onDeleteChat(deleteConfirm.id);
|
||||||
|
setDeleteConfirm(null);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Delete
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
</DialogContent>
|
||||||
|
</Dialog>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
import { useEffect, useMemo, useState } from 'react';
|
import { useEffect, useMemo, useState } from 'react';
|
||||||
import { MessageSquare, Terminal, Code, Clipboard, Plus, X } from 'lucide-react';
|
import { Terminal, Code, Clipboard } from 'lucide-react';
|
||||||
import { api } from '@/api/client';
|
import { api } from '@/api/client';
|
||||||
import type { Chat, Project, Session, WorkspacePane } from '@/api/types';
|
import type { Chat, Project, Session, WorkspacePane } from '@/api/types';
|
||||||
import { MAX_PANES, activePaneChatId, type UseWorkspacePanesResult } from '@/hooks/useWorkspacePanes';
|
import { MAX_PANES, activePaneChatId, type UseWorkspacePanesResult } from '@/hooks/useWorkspacePanes';
|
||||||
@@ -13,13 +13,8 @@ import { CoderPane } from '@/components/panes/CoderPane';
|
|||||||
import { MarkdownArtifactPane } from '@/components/MarkdownArtifactPane';
|
import { MarkdownArtifactPane } from '@/components/MarkdownArtifactPane';
|
||||||
import { HtmlArtifactPane } from '@/components/HtmlArtifactPane';
|
import { HtmlArtifactPane } from '@/components/HtmlArtifactPane';
|
||||||
import { ChatTabBar } from '@/components/ChatTabBar';
|
import { ChatTabBar } from '@/components/ChatTabBar';
|
||||||
|
import { PaneHeaderActions } from '@/components/PaneHeaderActions';
|
||||||
import { SessionLandingPage } from '@/components/SessionLandingPage';
|
import { SessionLandingPage } from '@/components/SessionLandingPage';
|
||||||
import {
|
|
||||||
DropdownMenu,
|
|
||||||
DropdownMenuContent,
|
|
||||||
DropdownMenuItem,
|
|
||||||
DropdownMenuTrigger,
|
|
||||||
} from '@/components/ui/dropdown-menu';
|
|
||||||
import { cn } from '@/lib/utils';
|
import { cn } from '@/lib/utils';
|
||||||
|
|
||||||
interface Props {
|
interface Props {
|
||||||
@@ -223,41 +218,13 @@ export function Workspace({
|
|||||||
<div className="flex items-center gap-1 border-b border-border px-2 py-1 shrink-0">
|
<div className="flex items-center gap-1 border-b border-border px-2 py-1 shrink-0">
|
||||||
<Code size={12} className="text-muted-foreground" />
|
<Code size={12} className="text-muted-foreground" />
|
||||||
<span className="text-xs text-muted-foreground">BooCode</span>
|
<span className="text-xs text-muted-foreground">BooCode</span>
|
||||||
<div className="ml-auto flex items-center gap-1">
|
<PaneHeaderActions
|
||||||
<DropdownMenu>
|
className="ml-auto"
|
||||||
<DropdownMenuTrigger asChild>
|
onSplitPane={onAddPane}
|
||||||
<button
|
onReopenPane={hasClosedPanes ? reopenPane : undefined}
|
||||||
type="button"
|
onShowHistory={() => showLandingPage(idx)}
|
||||||
onClick={(e) => e.stopPropagation()}
|
onRemovePane={panes.length > 1 ? () => removePane(idx) : undefined}
|
||||||
className="inline-flex items-center justify-center size-5 rounded text-muted-foreground hover:bg-muted hover:text-foreground"
|
/>
|
||||||
aria-label="New pane"
|
|
||||||
>
|
|
||||||
<Plus size={12} />
|
|
||||||
</button>
|
|
||||||
</DropdownMenuTrigger>
|
|
||||||
<DropdownMenuContent align="end" className="w-fit">
|
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('chat')}>
|
|
||||||
<MessageSquare size={14} /> New BooChat
|
|
||||||
</DropdownMenuItem>
|
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('terminal')}>
|
|
||||||
<Terminal size={14} /> New BooTerm
|
|
||||||
</DropdownMenuItem>
|
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('coder')}>
|
|
||||||
<Code size={14} /> New BooCode
|
|
||||||
</DropdownMenuItem>
|
|
||||||
</DropdownMenuContent>
|
|
||||||
</DropdownMenu>
|
|
||||||
{panes.length > 1 && (
|
|
||||||
<button
|
|
||||||
type="button"
|
|
||||||
onClick={(e) => { e.stopPropagation(); removePane(idx); }}
|
|
||||||
className="inline-flex items-center justify-center size-5 rounded text-muted-foreground hover:bg-muted hover:text-foreground"
|
|
||||||
aria-label="Close pane"
|
|
||||||
>
|
|
||||||
<X size={12} />
|
|
||||||
</button>
|
|
||||||
)}
|
|
||||||
</div>
|
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
{isTerminal && (
|
{isTerminal && (
|
||||||
@@ -266,30 +233,7 @@ export function Workspace({
|
|||||||
<span className="text-xs text-muted-foreground">
|
<span className="text-xs text-muted-foreground">
|
||||||
{terminalLabels.get(pane.id) ?? 'Terminal'}
|
{terminalLabels.get(pane.id) ?? 'Terminal'}
|
||||||
</span>
|
</span>
|
||||||
<DropdownMenu>
|
<div className="ml-auto flex items-center gap-0.5">
|
||||||
<DropdownMenuTrigger asChild>
|
|
||||||
<button
|
|
||||||
type="button"
|
|
||||||
onClick={(e) => e.stopPropagation()}
|
|
||||||
className="ml-auto inline-flex items-center justify-center size-5 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:size-7"
|
|
||||||
aria-label="New pane"
|
|
||||||
title="New pane"
|
|
||||||
>
|
|
||||||
<Plus size={12} />
|
|
||||||
</button>
|
|
||||||
</DropdownMenuTrigger>
|
|
||||||
<DropdownMenuContent align="end" className="w-fit">
|
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('chat')}>
|
|
||||||
<MessageSquare size={14} /> New BooChat
|
|
||||||
</DropdownMenuItem>
|
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('terminal')}>
|
|
||||||
<Terminal size={14} /> New BooTerm
|
|
||||||
</DropdownMenuItem>
|
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('coder')}>
|
|
||||||
<Code size={14} /> New BooCode
|
|
||||||
</DropdownMenuItem>
|
|
||||||
</DropdownMenuContent>
|
|
||||||
</DropdownMenu>
|
|
||||||
{/* v1.10.4: iOS Safari restricts navigator.clipboard.readText
|
{/* v1.10.4: iOS Safari restricts navigator.clipboard.readText
|
||||||
outside direct user gestures. A real button click IS a
|
outside direct user gestures. A real button click IS a
|
||||||
gesture, so this works where keystroke-driven paste may
|
gesture, so this works where keystroke-driven paste may
|
||||||
@@ -301,26 +245,19 @@ export function Workspace({
|
|||||||
e.stopPropagation();
|
e.stopPropagation();
|
||||||
terminalsRegistry.get(pane.id)?.paste();
|
terminalsRegistry.get(pane.id)?.paste();
|
||||||
}}
|
}}
|
||||||
className="inline-flex items-center justify-center size-5 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:size-7"
|
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
||||||
aria-label="Paste from clipboard"
|
aria-label="Paste from clipboard"
|
||||||
title="Paste from clipboard"
|
title="Paste from clipboard"
|
||||||
>
|
>
|
||||||
<Clipboard size={12} />
|
<Clipboard size={12} />
|
||||||
</button>
|
</button>
|
||||||
{panes.length > 1 && (
|
<PaneHeaderActions
|
||||||
<button
|
onSplitPane={onAddPane}
|
||||||
type="button"
|
onReopenPane={hasClosedPanes ? reopenPane : undefined}
|
||||||
onClick={(e) => {
|
onShowHistory={() => showLandingPage(idx)}
|
||||||
e.stopPropagation();
|
onRemovePane={panes.length > 1 ? () => removePane(idx) : undefined}
|
||||||
removePane(idx);
|
/>
|
||||||
}}
|
</div>
|
||||||
className="inline-flex items-center justify-center size-5 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:size-7"
|
|
||||||
aria-label="Close terminal pane"
|
|
||||||
title="Close terminal pane"
|
|
||||||
>
|
|
||||||
<X size={12} />
|
|
||||||
</button>
|
|
||||||
)}
|
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
@@ -395,6 +332,8 @@ export function Workspace({
|
|||||||
chats={chats}
|
chats={chats}
|
||||||
onOpenChat={(chatId) => openChatInPane(idx, chatId)}
|
onOpenChat={(chatId) => openChatInPane(idx, chatId)}
|
||||||
onUnarchiveChat={unarchiveChat}
|
onUnarchiveChat={unarchiveChat}
|
||||||
|
onArchiveChat={archiveChat}
|
||||||
|
onDeleteChat={deleteChat}
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -640,13 +640,23 @@ export function useWorkspacePanes(sessionId: string): UseWorkspacePanesResult {
|
|||||||
const showLandingPage = useCallback((paneIdx: number) => {
|
const showLandingPage = useCallback((paneIdx: number) => {
|
||||||
setPanes((prev) => {
|
setPanes((prev) => {
|
||||||
const pane = prev[paneIdx];
|
const pane = prev[paneIdx];
|
||||||
// Coder/terminal panes are not chat hosts — history button is chat-only.
|
if (!pane) return prev;
|
||||||
if (!pane || pane.kind === 'coder' || pane.kind === 'terminal') return prev;
|
|
||||||
const next = [...prev];
|
const next = [...prev];
|
||||||
|
if (pane.kind === 'coder' || pane.kind === 'terminal') {
|
||||||
|
// Scoped panes don't host chat tabs. Leaving one for the session
|
||||||
|
// history closes it: drop the pane→chat binding, and for terminals
|
||||||
|
// kill the tmux session (terminals are ephemeral — closing = killing,
|
||||||
|
// mirroring removePane).
|
||||||
|
if (pane.kind === 'terminal') {
|
||||||
|
api.terminals.kill(sessionId, pane.id).catch(() => { /* non-fatal */ });
|
||||||
|
}
|
||||||
|
next[paneIdx] = { ...pane, kind: 'empty', chatId: undefined, chatIds: [], activeChatIdx: -1 };
|
||||||
|
} else {
|
||||||
next[paneIdx] = { ...pane, kind: 'empty', chatId: undefined };
|
next[paneIdx] = { ...pane, kind: 'empty', chatId: undefined };
|
||||||
|
}
|
||||||
return next;
|
return next;
|
||||||
});
|
});
|
||||||
}, []);
|
}, [sessionId]);
|
||||||
|
|
||||||
const addSplitPane = useCallback((kind: 'chat' | 'terminal' | 'coder'): string | null => {
|
const addSplitPane = useCallback((kind: 'chat' | 'terminal' | 'coder'): string | null => {
|
||||||
// Generate the id outside the updater so we can return it deterministically.
|
// Generate the id outside the updater so we can return it deterministically.
|
||||||
|
|||||||
Reference in New Issue
Block a user