Compare commits
7 Commits
v2.7.8-emb
...
v2.7.12-au
| Author | SHA1 | Date | |
|---|---|---|---|
| 8c200216eb | |||
| e5ce01ae72 | |||
| 81470f5a77 | |||
| 35dba828e1 | |||
| ce621bc003 | |||
| afaca9e426 | |||
| 7ca4a6b344 |
@@ -11,6 +11,10 @@ POSTGRES_PASSWORD=CHANGE_ME
|
|||||||
# point BooCode at a different SearXNG instance.
|
# point BooCode at a different SearXNG instance.
|
||||||
SEARXNG_URL=http://100.114.205.53:8888
|
SEARXNG_URL=http://100.114.205.53:8888
|
||||||
|
|
||||||
|
# Context7 MCP key. Referenced from data/mcp.json as "{env:CONTEXT7_API_KEY}"
|
||||||
|
# ({env:VAR} substitution, opencode-compatible). Leave unset to send no key.
|
||||||
|
# CONTEXT7_API_KEY=ctx7sk-...
|
||||||
|
|
||||||
# Task model: lightweight model for auto-naming, search rewrite, etc.
|
# Task model: lightweight model for auto-naming, search rewrite, etc.
|
||||||
# Direct llama-server instance (NOT llama-swap). Falls back to LLAMA_SWAP_URL
|
# Direct llama-server instance (NOT llama-swap). Falls back to LLAMA_SWAP_URL
|
||||||
# with FAST_MODEL when unset.
|
# with FAST_MODEL when unset.
|
||||||
|
|||||||
2
.gitignore
vendored
2
.gitignore
vendored
@@ -15,6 +15,6 @@ secrets/
|
|||||||
data/*
|
data/*
|
||||||
!data/AGENTS.md
|
!data/AGENTS.md
|
||||||
!data/skills/
|
!data/skills/
|
||||||
!data/mcp.json
|
!data/mcp.example.json
|
||||||
!data/coder-providers.example.json
|
!data/coder-providers.example.json
|
||||||
codecontext/fork.tar.gz
|
codecontext/fork.tar.gz
|
||||||
|
|||||||
16
CHANGELOG.md
16
CHANGELOG.md
@@ -2,6 +2,22 @@
|
|||||||
|
|
||||||
All notable changes per release tag. Most recent on top, ordered by tag creation date (which matches the git history). Tag names follow `vMAJOR.MINOR.PATCH-slug` — the slug describes what shipped, so the tag name alone is enough to recall the batch.
|
All notable changes per release tag. Most recent on top, ordered by tag creation date (which matches the git history). Tag names follow `vMAJOR.MINOR.PATCH-slug` — the slug describes what shipped, so the tag name alone is enough to recall the batch.
|
||||||
|
|
||||||
|
## v2.7.12-audit-cleanup — 2026-06-02
|
||||||
|
|
||||||
|
A repo-wide audit and aggressive cleanup pass, run as a multi-agent orchestration (five read-only Opus auditors over server/web/coder/booterm + cross-cutting deps/build/parity + a structural-architecture lens) followed by phased, behavior-preserving implementation — every change gated on the per-app test suites and delivered behind a strict DEFER discipline that never touched the files in flight for `v2.7.9`–`v2.7.11` (`mcp-config`, the `ws-frames` pair, `dispatcher`, `claude-sdk-map`, `AgentComposerBar`/`CoderMessageList`/`CoderPane`), so the branch rebased onto current main with zero conflicts. **Dead code/deps/schema**: removed ~9 dead files and a swathe of dead exports/write-only state across all four apps, dropped dead deps (`next-themes`, `@xterm/addon-webgl`, booterm `tslib`; `shadcn`→devDep), and idempotently dropped dead schema columns/tables (`sessions.tags`, `tasks.worktree_path`/`feature_values`, `available_agents.supports_mcp_client`, the superseded `session_worktrees` table, the always-empty `list_worktrees` MCP tool) — chat/session/message DATA untouched, only never-read columns. **Server dedup + reshapes**: collapsed the dead `budget.ts` tier system (surfacing a latent `READ_ONLY_TOOL_NAMES` drift, then deleted), extracted shared `MESSAGE_COLUMNS`/`selectProject`/`stripQuotes`/`SENTINEL_KINDS`/`samplerOptsFromAgent`/`createContentFlusher`/`insertSentinel`/a `makeCodecontextTool` factory/a pending-tool-call resolver, split `tools.ts` (799→46 barrel + `tools/{types,fs-tools,misc-tools,registry,tiers}`, register-through registry preserved so coder's import contract stays byte-stable), and decomposed the inference pipeline (`sentinel-summaries`→`runWrapUpSummary`, `turn.ts`→`turn-config`+`step-decision`, a pure `stream-phase-adapter`, shared finalize atoms — stopping short of fusing synthesis to preserve frame timing). **Coder reshapes**: split the 1062-line `opencode-server.ts` god-class into supervisor / sse-loop / pure event-map / port-utils + extracted `buildAcpClient`/`makeFrameEmitter`/`worktree-risk`, plus happy-path-safe concurrency hardening (reconnect backoff, double-spawn guard; a defensive busy-assert + ensureSession coalescing flagged for review). **Web**: `React.memo` on `MessageBubble`/`MarkdownRenderer` + module-hoisted markdown components (the streaming re-parse was the biggest perf cost), shared `linkifyPaths`/artifact/tab dedup, two latent bug fixes (`ChatPane` index-keys → stable ids; `FileViewerOverlay` blank-line line-number desync), and decomposed the 1298-line `TerminalPane.tsx` into fit/socket/selection hooks + presentational pieces (verbatim move, all ~30 listeners/timers inventoried; the label-dep fix stops a live terminal tearing down on pane renumber). +78 parity/unit tests (server 597, coder 328 green; `apps/web` has no harness, so its changes are typecheck + manual/device QA). Net ≈ −4,600 LOC. Deferred (designed; blueprints in the audit reports): the `tasks` dual-CREATE / `project_id` FK (a cross-service deploy-ordering decision, not a data migration), web structural decomposition of `useWorkspacePanes`/`MessageBubble` (needs a web test harness first), a `@boocode/contracts` shared package, and the `dispatcher.ts` split — the last two now unblocked since their in-flight files shipped in `v2.7.9`–`v2.7.11`. Rebased clean onto `v2.7.11-coder-model-snapshot`.
|
||||||
|
|
||||||
|
## v2.7.11-coder-model-snapshot — 2026-06-02
|
||||||
|
|
||||||
|
Hotfix for the coder model-attribution chip vanishing on refresh. The chip showed during a live turn (the `message_complete` frame carries `model`) but disappeared when a BooCoder session was reloaded — only in the coder, not BooChat. Root cause: `CoderPane`'s `useCoderMessages` hydrates from two sources on load — the HTTP `listMessages` fetch (whose SELECT includes `model`, added `v2.7.8`) AND the WS `snapshot` frame — and the WS snapshot's query in `apps/coder/src/routes/ws.ts` had its own column list that omitted `model`. The client's `snapshot` handler `setMessages`-overwrites the HTTP load, so the model-less rows won, and with no later `message_complete` for historical messages the chip stayed gone. Fix is one column: add `model` to the WS snapshot SELECT so both hydration paths agree. The `apps/coder/CLAUDE.md` "update every mapper" note now lists the WS snapshot SELECT explicitly (it was the one place not enumerated). apps/server + apps/coder builds green; deployed via `systemctl restart boocoder` (host service — the earlier `v2.7.10` docker deploy rebuilt only the container, never this route). Fixes the chip shipped in `v2.7.8-ember-coder-tabs-model-chips` / completed in `v2.7.9-mcp-keys-docs-coder-fixes`.
|
||||||
|
|
||||||
|
## v2.7.10-composer-chips — 2026-06-02
|
||||||
|
|
||||||
|
A composer control-row refresh shared by BooChat and BooCoder via `ChatInput`. The slash-commands menu moves out of the full-width `AgentCommandsHint` disclosure (now removed) into a compact chip in the message box's bottom controls row — clicking it opens the existing `SlashCommandPicker` anchored to the chip and selecting inserts `/<name> `, while the typed-`/` autocomplete is unchanged. A new attach-file button sits beside it, opening a native multi-file picker that funnels picks through the same drag-drop pipeline (5 MB / binary gate, 10-attachment cap, chips + preview, `source:'drop'`). On mobile both collapse to icon-only — the slash count is `max-md:hidden` and the paperclip is icon-only — so the row stays on one line per the no-scroll toolbar rule. Web tsc + build green; deployed (docker). Builds on the BooCode 2.0 composer work in `v2.7.8-ember-coder-tabs-model-chips`.
|
||||||
|
|
||||||
|
## v2.7.9-mcp-keys-docs-coder-fixes — 2026-06-02
|
||||||
|
|
||||||
|
The MCP-key hygiene feature plus accumulated in-flight coder fixes and a docs refactor. **MCP `{env:VAR}` substitution** (`mcp-config.ts:substituteEnvVars`, opencode-compatible) recursively resolves `{env:NAME}` references in any string value of `data/mcp.json` from `process.env` *before* Zod validation, so real keys live in `.env` (`env_file`) instead of the gitignored config — an unset var resolves to `''` with a boot-log warning, and on a validation failure the loader names the unset vars alongside the field errors (an empty `{env:VAR}` in a strict url/command field invalidates the whole config, an otherwise-disconnected warning). `data/mcp.json` is now untracked (`.gitignore` flips `!data/mcp.json` → `!data/mcp.example.json`); the tracked template `data/mcp.example.json` carries `"CONTEXT7_API_KEY": "{env:CONTEXT7_API_KEY}"` and `.env.example` documents the key (9 mcp-config tests). **Two coder bug fixes** ride along: the `message_complete` frame's `model` is widened `string` → `string | null` in both ws-frames copies (server + web parity) and the dispatcher now publishes `model: task.model` at all four external assistant-completion points — without the nullable widen a null model would fail-closed in `publishFrame` and drop the entire frame including the `status:'complete'` transition (regression test added); and Claude-SDK `mapUserToolResults` now maps `user`-message `tool_result` blocks → terminal `tool_update` events (completed/failed with output) so external-agent tool snapshots resolve instead of spinning forever (the SDK feeds tool output back as a user message, previously unmapped). On the view side the `AgentComposerBar` drops the §9b resumed/history/new-session chip and token-usage readout and loses `flex-wrap` so the control row stays on one line, while `CoderPane` gains a per-chat `localStorage` agent-config cache (provider/model/mode/thinking keyed by chat id, restoring the last model on reopen) and threads the new `model` field into the timeline + attribution chip. **Docs refactor**: the root `CLAUDE.md` is slimmed (~190 lines) with per-app deep references split into `apps/{coder,server,web}/CLAUDE.md` (auto-loaded in-subtree), plus a new 372-line `docs/coder-backends.md` dispatch reference, a `docs/project-discovery.md` stack inventory, and a `docs/coding-standards/` set (the `cross-app-contract-parity` standard, fronted by `.claude/rules` path-scoped indexes) — `ARCHITECTURE.md` links the backends doc. Server 555 + coder 299 tests passing (incl. new mcp-config, ws-frames, and claude-sdk-map suites), web tsc + server + coder builds green. Builds on `v2.7.8-ember-coder-tabs-model-chips`.
|
||||||
|
|
||||||
## v2.7.8-ember-coder-tabs-model-chips — 2026-06-01
|
## v2.7.8-ember-coder-tabs-model-chips — 2026-06-01
|
||||||
|
|
||||||
The BooCode 2.0 visual identity plus two workflow features. **Ember theme** (`styles/themes/ember.css`, now `DEFAULT_THEME_ID`) is the signature orange-on-near-black look — rebuilt on Obsidian's flat charcoal structure (`#0c0c0e`/`#15151a`/`#1f1f23`) with `#ff7a18` swapped in for the purple, after a Reinvented-direction detour (neon borders + a scanline/glow texture overlay) was dialed back to taste; the server `theme_id` whitelist gains `ember` so it can actually be selected. The **brand banner** (`ProjectSidebar`) shows the eye-patch Westie mascot + the `>_BooCode` wordmark big and edge-to-edge on transparent backgrounds — the source PNGs shipped with baked-white canvases, so they were flood-filled to transparency from the corners (preserving the white dog, which a naive white-key would have destroyed) and cropped to bounds. **Coder panes are now multi-tab**: `+` opens a new BooCode tab (a fresh chat = a new agent context sharing the session worktree) while the split button still opens a pane — coder panes reuse the shared `ChatTabBar` via a kind-aware `tabKind`, backed by a new `createCoderTab` action with `closeOtherTabs`/tab-numbering extended to coder kind. **Model-attribution chips**: a new `messages.model` column (both apps share the table) stamped at `finalizeCompletion` (BooChat + native coder) and at the dispatcher's assistant-row creation (external coder), surfaced through the `messages_with_parts` view + wire types + the live `message_complete` frame (the Zod already allowed `model`; nothing consumed it), and rendered as a subtle accent chip with a shortened label (`shortenModelName` → `Sonnet 4.6`, `Qwen3.6 35B`) beside the message stats — so swapping models mid-coder-session stays legible. Also the composer moved its Web toggle into a boxed, focus-ringed input, tool rows lead with a glowing accent dot, and the Claude-SDK-backend follow-ups validated live this session (1M context window, follow-up-message fix, collapsed thinking/tool chips) land with `CLAUDE_SDK_BACKEND=1` flipped on. One snag fixed mid-deploy: the view's new `m.model` was first inserted mid-list and `CREATE OR REPLACE VIEW` can't reorder columns (42P16) — appended at the end. Web tsc + server + coder builds green; deployed (docker + boocoder, tools:34). Builds on `v2.7.7-pane-header-actions`.
|
The BooCode 2.0 visual identity plus two workflow features. **Ember theme** (`styles/themes/ember.css`, now `DEFAULT_THEME_ID`) is the signature orange-on-near-black look — rebuilt on Obsidian's flat charcoal structure (`#0c0c0e`/`#15151a`/`#1f1f23`) with `#ff7a18` swapped in for the purple, after a Reinvented-direction detour (neon borders + a scanline/glow texture overlay) was dialed back to taste; the server `theme_id` whitelist gains `ember` so it can actually be selected. The **brand banner** (`ProjectSidebar`) shows the eye-patch Westie mascot + the `>_BooCode` wordmark big and edge-to-edge on transparent backgrounds — the source PNGs shipped with baked-white canvases, so they were flood-filled to transparency from the corners (preserving the white dog, which a naive white-key would have destroyed) and cropped to bounds. **Coder panes are now multi-tab**: `+` opens a new BooCode tab (a fresh chat = a new agent context sharing the session worktree) while the split button still opens a pane — coder panes reuse the shared `ChatTabBar` via a kind-aware `tabKind`, backed by a new `createCoderTab` action with `closeOtherTabs`/tab-numbering extended to coder kind. **Model-attribution chips**: a new `messages.model` column (both apps share the table) stamped at `finalizeCompletion` (BooChat + native coder) and at the dispatcher's assistant-row creation (external coder), surfaced through the `messages_with_parts` view + wire types + the live `message_complete` frame (the Zod already allowed `model`; nothing consumed it), and rendered as a subtle accent chip with a shortened label (`shortenModelName` → `Sonnet 4.6`, `Qwen3.6 35B`) beside the message stats — so swapping models mid-coder-session stays legible. Also the composer moved its Web toggle into a boxed, focus-ringed input, tool rows lead with a glowing accent dot, and the Claude-SDK-backend follow-ups validated live this session (1M context window, follow-up-message fix, collapsed thinking/tool chips) land with `CLAUDE_SDK_BACKEND=1` flipped on. One snag fixed mid-deploy: the view's new `m.model` was first inserted mid-list and `CREATE OR REPLACE VIEW` can't reorder columns (42P16) — appended at the end. Web tsc + server + coder builds green; deployed (docker + boocoder, tools:34). Builds on `v2.7.7-pane-header-actions`.
|
||||||
|
|||||||
184
CLAUDE.md
184
CLAUDE.md
@@ -2,11 +2,11 @@
|
|||||||
|
|
||||||
This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
|
This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
|
||||||
|
|
||||||
**Cursor agents:** start with `docs/ARCHITECTURE.md` (diagram). This file is the deep engineering reference. (Note: the root navigation `AGENTS.md` was removed in v1.12; `data/AGENTS.md` is the agent *registry*, not navigation.)
|
**Cursor agents:** start with `docs/ARCHITECTURE.md` (diagram); this file is the deep engineering reference. `data/AGENTS.md` is the agent *registry*, not navigation (the root navigation `AGENTS.md` was removed).
|
||||||
|
|
||||||
## What is BooCode
|
## What is BooCode
|
||||||
|
|
||||||
Self-hosted single-user developer chat app. AI assistant with read-only file tools (view_file, list_dir, grep, find_files) running against a local llama-swap inference server. Sessions organized by project, with a multi-pane workspace (chat + file browser side by side).
|
Self-hosted single-user developer chat app. AI assistant with read-only file tools (view_file, list_dir, grep, find_files) against a local llama-swap inference server. Sessions organized by project, multi-pane workspace (chat + file browser side by side).
|
||||||
|
|
||||||
Plus `apps/booterm` (second container, port 9501, bookworm-slim+glibc): Fastify + node-pty + tmux. Browser terminal panes WS to `/ws/term/sessions/:sid/panes/:pid`; per-session tmux session `bc-<sid>`, per-pane window `term-<pid>`. Shells drop privs to samkintop via `gosu` in `tmux.conf` default-command.
|
Plus `apps/booterm` (second container, port 9501, bookworm-slim+glibc): Fastify + node-pty + tmux. Browser terminal panes WS to `/ws/term/sessions/:sid/panes/:pid`; per-session tmux session `bc-<sid>`, per-pane window `term-<pid>`. Shells drop privs to samkintop via `gosu` in `tmux.conf` default-command.
|
||||||
|
|
||||||
@@ -35,86 +35,22 @@ npx tsc -p apps/web/tsconfig.app.json --noEmit # web app specifically
|
|||||||
docker compose build --no-cache boocode && docker compose up -d
|
docker compose build --no-cache boocode && docker compose up -d
|
||||||
```
|
```
|
||||||
|
|
||||||
Tests: `pnpm -C apps/server test` runs the vitest suite. No test harness on `apps/web` (adding it requires installing vitest as a new devDep). Vitest pinned to `^3` because Vite 5 / vitest 4 are incompatible. No linters configured. Vitest include glob is `src/**/__tests__/**/*.test.ts` (see `apps/server/vitest.config.ts`) — tests outside `src/**/__tests__/` silently won't run; match the per-domain convention (`apps/server/src/services/__tests__/foo.test.ts`). `apps/coder` has its own vitest suite too — `pnpm -C apps/coder test` (same `src/**/__tests__/**/*.test.ts` glob; `globals:false`, so import `describe`/`it`/`expect` from `vitest`). Extract pure helpers to unit-test (`backends/turn-guard.ts`, `lifecycle-decisions.ts` are the pattern).
|
Tests: `pnpm -C apps/server test` (vitest); `apps/coder` has its own suite — `pnpm -C apps/coder test` (`globals:false`, so import `describe`/`it`/`expect` from `vitest`). No `apps/web` test harness, no linters. Vitest pinned to `^3` (Vite 5 / vitest 4 incompatible). Include glob is `src/**/__tests__/**/*.test.ts` — tests outside it silently won't run. Extract pure helpers to unit-test (`backends/turn-guard.ts`, `lifecycle-decisions.ts` are the pattern).
|
||||||
|
|
||||||
## Architecture
|
## Architecture
|
||||||
|
|
||||||
**Monorepo**: pnpm workspaces with `apps/server` (Fastify + postgres), `apps/web` (React + Vite), and `apps/booterm` (Fastify + node-pty + tmux).
|
**Monorepo**: pnpm workspaces with `apps/server` (Fastify + postgres), `apps/web` (React + Vite), `apps/booterm` (Fastify + node-pty + tmux), `apps/coder` (BooCoder, host service).
|
||||||
|
|
||||||
### Server (`apps/server/src/`)
|
### Per-app deep references
|
||||||
|
|
||||||
- **Fastify** with `@fastify/websocket` and `@fastify/static` (serves built frontend)
|
Detailed engineering notes live in per-app `CLAUDE.md` files, **auto-loaded when you read/edit files in that subtree** (and worth opening before non-trivial work there):
|
||||||
- **postgres** (porsager/postgres) with tagged-template SQL — no ORM. Schema in `schema.sql`, applied on startup. LSP may false-positive on `sql<Type[]>\`...\`` generics; CLI `tsc` / `pnpm build` is authoritative.
|
|
||||||
- **Zod** for request validation and config parsing.
|
|
||||||
|
|
||||||
Key services:
|
- **`apps/server/CLAUDE.md`** — inference pipeline, AI-SDK adapter gotchas, tools, compaction, broker, the `messages_with_parts` view, sidecar routing, secret guard, the `data/AGENTS.md` registry.
|
||||||
- **`services/inference/`** — Public surface re-exported via `inference/index.ts`; callers import from `./services/inference/index.js` explicitly (NodeNext doesn't honor directory-index resolution). Layout: `turn.ts` (runAssistantTurn / runInference / createInferenceRunner; exports `InferenceFrame`, `InferenceContext`, `TurnArgs`, `StreamResult`, `MAX_STEPS`), `stream-phase.ts` (streamCompletion as a v1.13.1-A AI SDK adapter + executeStreamPhase), `provider.ts` (`upstreamModel(baseURL, modelId)` wrapping `createOpenAICompatible` against llama-swap), `tool-phase.ts` (executeToolPhase → returns `ToolPhaseResult`; no longer recurses into runAssistantTurn — v1.14.0 converted the recursion to an explicit while loop in turn.ts), `sentinel-summaries.ts` (runCapHitSummary + runDoomLoopSummary + runStepCapSummary + their sentinel inserters), `error-handler.ts` (handleAbortOrError, finalizeCompletion), `payload.ts` (buildMessagesPayload, loadContext, maybeFlagForCompaction, `OpenAiMessage`), `sentinels.ts` (`detectDoomLoop`, `DOOM_LOOP_THRESHOLD`, sentinel predicates), `budget.ts` (resolveToolBudget), `xml-parser.ts` (qwen3.6 XML tool-call fallback — KEEP, AI SDK doesn't handle inline-XML tool calls), `parts.ts` (parts-table write helpers: `partsFromAssistantMessage`, `partsFromToolMessage`, `insertParts` — v1.13.20 made parts the sole source of truth), `prune.ts` (v1.13.4 two-tier compaction; `selectPruneTargets` is the pure decision helper), `types.ts` (`StreamPhaseState`, `DB_FLUSH_INTERVAL_MS`). **`TurnArgs`** is the per-turn state envelope populated from loop locals each iteration; reset in `runInference` at user-message boundary. The outer loop in `runAssistantTurn` (v1.14.0) runs `while (stepNumber < effectiveCap)` where `effectiveCap = Math.min(agent.steps ?? Infinity, MAX_STEPS=200)`. Per-agent `steps:` field in AGENTS.md frontmatter. `steps: 0` means text-only (no tool execution). Step-cap hit writes a `cap_hit` sentinel so `CapHitSentinel.tsx` renders it.
|
- **`apps/coder/CLAUDE.md`** — BooCoder dispatch, provider registry/probe/snapshot, opencode/ACP/PTY/Claude-SDK backends, `agent_sessions` resume.
|
||||||
- **AI SDK v6 streamCompletion adapter** (v1.13.1-A; `services/inference/stream-phase.ts`). `streamText` is the underlying call; the BooCode layer above (executeStreamPhase, finalize, dual-write) is shape-preserved via an adapter. Five gotchas the LSP/test suite won't catch:
|
- **`apps/web/CLAUDE.md`** — React app, hooks/event buses, font & CSS pipeline, multi-pane workspace, all UI conventions.
|
||||||
- **Abort signals are swallowed.** `streamText`'s `fullStream` iterator exits cleanly when `abortSignal` fires — no throw. Post-iteration `if (signal?.aborted) throw <AbortError>` is required; without it the row finalizes as `complete` instead of `cancelled`. Comment in stream-phase.ts pins this; don't refactor it away.
|
- **`docs/project-discovery.md`** — full stack / tooling / command inventory across all packages (read-on-demand).
|
||||||
- **Usage lands only at stream end** via `await result.usage` (`inputTokens` / `outputTokens` v6 names → mapped to `promptTokens` / `completionTokens` for the existing onUsage callback). Mid-stream live tok/s is gone vs v1.12.2; ChatThroughput shows a single value at stream end.
|
|
||||||
- **Tools have NO `execute` field.** BooCode dispatches tools in tool-phase.ts, not the AI SDK loop. Only `description` + `inputSchema: jsonSchema(parameters)` — surfacing tool-call parts via `fullStream` and stopping is what we want.
|
|
||||||
- **`includeUsage: true` MUST be set on `createOpenAICompatible`** in `services/inference/provider.ts`. The adapter defaults it false, omitting `stream_options.include_usage` from the request body; llama-swap then never emits the usage block and `result.usage.inputTokens/outputTokens` resolve to `undefined`. Latent regression from v1.13.1-A through v1.13.7 — every assistant row in that window has `tokens_used`/`ctx_used` NULL. Don't remove this flag during refactor.
|
|
||||||
- **Tool-call-only turns may emit a leading `\n` text-delta** as the assistant content. `MessageList.flatten`'s `hasText` and `MessageBubble`'s `hasContent` both `.trim()` before the length check — otherwise whitespace-only content renders an empty bubble + ActionRow between every tool call (v1.13.7 fix). `payload.ts:buildMessagesPayload` also skips `status='failed'` AND complete-but-empty (no content, no tool_calls) assistant rows to avoid "Cannot have 2 or more assistant messages at the end of the list" upstream rejections after cap-hit + Continue.
|
|
||||||
- **AI SDK ModelMessage conversion** (`toModelMessages` in stream-phase.ts). Tool messages need a `toolName` for `ToolResultPart` — BooCode's OpenAI-shape history doesn't carry it, so a forward-scan builds a `tool_call_id → toolName` map from prior assistant `tool_calls`. Tool outputs wrapped as `{ type: 'json' | 'text', value }` matching the v6 `ToolResultOutput` union. Assistant messages with reasoning emit a `ReasoningPart` first in the content array (v1.13.1-C).
|
|
||||||
- **`experimental_repairToolCall`** (v1.13.3) wired into `streamText` to keep the stream alive when qwen3.6 emits malformed tool args. Pass-through implementation — logs the bad call and returns it unmodified; `executeToolPhase`'s existing zod-reject error path routes it to the model on the next turn.
|
|
||||||
- **`chat_status` frame shape** (published via `broker.publishUser`) — `status: 'streaming' | 'tool_running' | 'waiting_for_input' | 'idle' | 'error'` (widened from `working|idle|error` in v1.12.1). Frontend `useChatStatus` derives `idle_warm` (<30s since idle) vs `idle_cold`. `ChatThroughput` renders inline beside `StatusDot` only when streaming or tool_running, fed by 500ms-throttled `'usage'` WS frames (`completion_tokens` + `ctx_used` + `ctx_max`). The `POST /api/chats/:id/discard_stale` endpoint exists to mark a stuck-streaming row as `failed` when the frontend's 60s no-token-activity timer (`ChatPane` content-length watcher) gives up.
|
|
||||||
- **Boot-time stale-streaming sweep** in `apps/server/src/index.ts` after `applySchema()`: any `messages.status='streaming'` older than 5 minutes flips to `'failed'`. Logs only on non-zero count. Recovers from container restart while inference was mid-stream (v1.12.1).
|
|
||||||
- **Periodic 60s sweeper** in `apps/server/src/index.ts` (v1.13.3 + v1.13.5). Same `setInterval` runs `sweepStaleStreaming` (marks `messages.status='streaming'` older than 5 min as `failed`, publishes `chat_status='idle'` so the UI dot drops) and `cleanupTruncations` (TTL + orphan reap of tmpfs truncation files). `app.addHook('onClose')` clears the timer. No-op when nothing to reap.
|
|
||||||
- **`services/broker.ts`** — In-memory pub/sub with two channel types: per-session (message streaming) and per-user (sidebar updates). No persistence; clients reconnect on restart. v1.13.11: every WS publish goes through `broker.publishFrame(sessionId, frame)` or `broker.publishUserFrame(user, frame)` — both Zod-validate against `WsFrameSchema` (`types/ws-frames.ts`) and fail-closed (log + drop). `ctx.publish` / `ctx.publishUser` in inference + auto_name route through the index.ts adapter that calls publishFrame internally. The schema is duplicated byte-identical at `apps/web/src/api/ws-frames.ts`; a `ws-frames.test.ts` case enforces parity. Don't add new raw `broker.publish()` / `publishUser()` calls.
|
|
||||||
- **`services/tools.ts`** — Tool registry (`ALL_TOOLS`, `READ_ONLY_TOOL_NAMES`, `TOOLS_BY_NAME`). Filesystem tools (view_file/list_dir/grep/find_files) go through three guard layers: `path_guard.ts` (workspace scope), `secret_guard.ts` (filename deny list), `url_guard.ts` (SSRF/private-IP block for web_fetch). v1.11.8+ web tools (`web_search`, `web_fetch`) are opt-in per chat via `session.web_search_enabled` (resolved with `project.default_web_search_enabled` fallback) and filtered out of the LLM's tool schema when false. v1.13.5 truncation: when a tool slice cuts content, `services/truncate.ts` stashes the full text on tmpfs at `BOOCODE_TRUNCATION_DIR` (default `/tmp/boocode-truncations`, 0o700) keyed by an opaque `tr_<12 base32 chars>` id, and the `view_truncated_output(id)` tool retrieves it. 5MB cap (matches `view_file`'s `MAX_FILE_BYTES`), 7-day TTL, reaped by the periodic sweeper. Tmpfs path means container restart loses retrieval — acceptable, the model usually has moved on.
|
|
||||||
- **`services/compaction.ts`** + **`services/model-context.ts`** — v1.11.0 anchored rolling summary (single `summary=true` assistant row per chat, supersedes itself on each compaction). Triggered when `chats.needs_compaction` is set after an inference turn exceeds `usable(ctx_max) = floor(0.85 × ctx_max)` (v1.13.9 opencode-pattern early trigger; was `ctx_max - 20k` pre-v1.13.9, which gave only 7.6% headroom at 262k and 0 budget for ≤20k contexts). **`ctx_max` comes from `model-context.getModelContext()` which fetches `${LLAMA_SWAP_URL}/upstream/<model>/props`** — NOT from `parsed.timings.n_ctx` (the stream completion's `timings` doesn't carry n_ctx; that read was dead code until v1.11.3 ripped it out). First inferences after a boocode boot may have `ctx_max=NULL` if llama-swap hasn't loaded the model yet; negative cache TTL is 60s, recovers on next turn. v1.13.6: `buildHeadPayload` embeds `reasoning_parts` as a `<reasoning>...</reasoning>` prose prefix on the assistant `content` (OpenAI wire shape has no structured reasoning field; the summarizer reads text). Standalone tag when content is empty (tool-call-only turn). `buildHeadPayload` + `OpenAiMessage` exported for test access — keep them exported.
|
|
||||||
- **`services/system-prompt.ts`** — `buildSystemPrompt` is the string-returning shim; `buildSystemPromptWithFingerprint` is the canonical impl returning `{prompt, fingerprint, drift}`. v1.13.8 instrumentation: SHA-256 of the assembled prefix is logged per `buildMessagesPayload` call (msg `prefix-fingerprint`, level=info); a `Map<sessionId, lastHash>` observer fires `prefix-drift` (level=warn) on hash change with a field-level `changed_inputs` diff. Smoke proved the prefix is byte-stable across turns in steady-state — the originally-planned `system_prompt_cache` DB table was dropped as redundant against the v1.12.0 input-layer mtime caches (BOOCHAT.md here + AGENTS.md global+per-project in `agents.ts:safeStat`).
|
|
||||||
- **`services/inference/budget.ts`** — tool-call budgets: `BUDGET_READ_ONLY = 30`, `BUDGET_NON_READ_ONLY = 10` (forward-looking; no write tools yet), `BUDGET_NO_AGENT = 30` (v1.13.7; was 15 — every tool in `ALL_TOOLS` is read-only today, so no-agent mode shares the read-only-agent cap). Per-agent `max_tool_calls` from AGENTS.md frontmatter overrides.
|
|
||||||
- **`messages_with_parts` view** (v1.13.1-B; `schema.sql`). Read sites that need `tool_calls` / `tool_results` / `reasoning_parts` SELECT from this view, NOT `messages` directly. v1.13.20 dropped the legacy `messages.tool_calls` / `messages.tool_results` JSON columns; the view now reads parts-only subselects. Writes target `message_parts` exclusively via `insertParts` (or via the helpers `partsFromAssistantMessage` / `partsFromToolMessage`). The `Message` wire type still carries `tool_calls?` / `tool_results?` because the view synthesizes them from parts — frontend reads are unchanged. Shapes: `tool_calls jsonb[]`, `tool_results jsonb` single object, `reasoning_parts jsonb[]` of `{text}`. If you ever need to UPDATE a message and return its full Message shape, do a two-step UPDATE returning `id` followed by SELECT from the view — RETURNING off the bare `messages` table no longer carries the tool fields.
|
|
||||||
- **`services/file_ops.ts`** — Shared file operation implementations used by both inference tools and HTTP routes.
|
|
||||||
- **`services/auto_name.ts`** — Non-streaming LLM call to generate 4-word session titles after first assistant reply.
|
|
||||||
- **`apps/coder/src/services/provider-registry.ts`** (BooCoder, NOT apps/server) — Static registry of provider metadata (label, transport, model source). `PROVIDERS` array, `PROVIDERS_BY_NAME` map. 5 providers: boocode (native), opencode (acp), goose (pty), claude (pty), qwen (pty).
|
|
||||||
- **`apps/coder/src/services/agent-probe.ts`** (BooCoder) — Startup probe using direct `exec()` (not SSH). Discovers installed agents on host, their versions, ACP support, and models. Qwen models read from `~/.qwen/settings.json`. Claude models are static from the registry. Results persisted to `available_agents` table.
|
|
||||||
- **`apps/coder/src/routes/providers.ts`** (BooCoder) — `GET /api/providers` returns installed providers with models. Transport field reflects actual capability (checks `supports_acp` from DB, not just registry preference). The apps/server side of this flow is the "Provider picker dispatch" bullet below.
|
|
||||||
- **Provider picker dispatch**: when `provider !== 'boocode'`, the message route creates a `tasks` row (with `session_id` set) instead of calling `inference.enqueue`. The dispatcher picks it up and dispatches via ACP or PTY using the agent's `install_path`.
|
|
||||||
|
|
||||||
Route registration: all routes registered in `index.ts` via `register*Routes(app, sql, ...)` functions. Routes are in `routes/*.ts`.
|
Cross-app contracts (WS-frame & provider-type parity, sentinels) and everything below stay here.
|
||||||
|
|
||||||
### BooCoder (`apps/coder/src/`)
|
|
||||||
|
|
||||||
- Write-capable coding agent. Runs as a **systemd service on the host** (`boocoder.service`), NOT in Docker. Fastify server at port 9502, connects to postgres at `127.0.0.1:5500`.
|
|
||||||
- **Workspace dependency on `@boocode/server`**: imports `createInferenceRunner`, `createBroker`, `ALL_TOOLS`, `appendMcpTools` from the server's compiled `dist/`. apps/server's `package.json` has an `exports` map with `types` conditions for NodeNext resolution. apps/server must build FIRST.
|
|
||||||
- Build + deploy: `pnpm -C apps/server build && pnpm -C apps/coder build && sudo systemctl restart boocoder`. Env file at `apps/coder/.env.host`. Service file at `/etc/systemd/system/boocoder.service`.
|
|
||||||
- After `pnpm -C apps/coder build` the host `boocoder.service` keeps running the OLD process until `sudo systemctl restart boocoder` — a stale process shows **new routes 404 with `{error:'not found'}` while old routes still 200** (the `/api` not-found handler returns that shape). Restart, don't re-debug.
|
|
||||||
- **Deploy by surface:** an `apps/coder` change → `sudo systemctl restart boocoder`; an `apps/web` or `apps/server` change → `docker compose up --build -d boocode` (rebuilds web+server from the working tree). `:9502/api/health` is down ~15–20s after a boocoder restart while the startup agent-probe scan runs — retry; an early connection-refused is not a failed deploy.
|
|
||||||
- Agent dispatch spawns binaries directly using `install_path` from `available_agents` — no `spawn('sh', ['-c', ...])` (fails under systemd). Follows Paseo's pattern: `spawn(fullBinaryPath, argsArray, { cwd })`.
|
|
||||||
- systemd hardening: only `NoNewPrivileges=true` is safe. `ProtectSystem`, `ProtectHome`, `PrivateTmp` all break agent dispatch (agents need full filesystem access to read configs, write to worktrees).
|
|
||||||
- `apps/server/tsconfig.json` has `declaration: true` so `.d.ts` files exist for workspace consumers.
|
|
||||||
- Write tools (`edit_file`, `create_file`, `delete_file`, `apply_pending`, `rewind`) queue in `pending_changes` table. Nothing hits disk until `apply_pending` is called. `write_guard.ts` validates paths (resolve + prefix-check, no realpath since files may not exist for creates).
|
|
||||||
- Frontend: NOT a separate SPA. BooCoder is a `'coder'` pane type within BooChat's SPA (`apps/web/`). `CoderPane.tsx` in `apps/web/src/components/panes/`. API requests go through `/api/coder/*` proxy (Vite dev + Fastify production) which rewrites to the boocoder host service (`BOOCODER_URL` env var, default `http://100.114.205.53:9502`). WS connects directly to `:9502`.
|
|
||||||
- `apps/coder/web/` is a STANDALONE fallback SPA served at `:9502` directly. The PRIMARY BooCoder frontend is the `CoderPane` in BooChat's SPA (`apps/web/src/components/panes/CoderPane.tsx`), accessible via the "Coder" pane in the workspace at `code.indifferentketchup.com`. Both exist; the pane is what Sam uses.
|
|
||||||
- **Provider snapshot lifecycle** (`apps/coder/src/services/`): `provider-config.ts` (Zod config, never-throws on bad input) → `provider-config-registry.ts` (`buildResolvedRegistry`, singleton) → `provider-snapshot.ts` (two-tier probe: tier-1 fast presence, tier-2 cold ACP probe skipped unless force / stale `PROVIDER_PROBE_TTL_MS` 24h / dbEmpty; cached). Verify live: `curl http://100.114.205.53:9502/api/providers/snapshot` — returns providers + models + commands, the exact shape `AgentComposerBar` renders.
|
|
||||||
- `PATCH /api/providers/config` replaces a provider id's override object **wholesale** (per-id shallow merge) — to flip one field send `{...existing, enabled}`, or a custom ACP entry's `command`/`label` is wiped and it drops out of the resolved registry. `data/coder-providers.json` is **gitignored** (it's live runtime config — the coder reads AND writes it on UI toggles); the tracked reference is `data/coder-providers.example.json`. The loader falls back to `{providers:{}}` (built-ins only) when the live file is absent, so a fresh checkout needs no copy.
|
|
||||||
- **opencode** runs as a warm HTTP server (v2.6 Phase 1, `services/backends/opencode-server.ts` — `opencode serve` per BooCoder process, one opencode session per BooCode session, resumed via `agent_sessions`). goose/qwen/claude still dispatch **one-shot** ACP/PTY with no ctx/token usage; only native `boocode` (llama-swap engine) tracks ctx. Paseo's per-provider native clients (design §12) deliberately not ported.
|
|
||||||
- **opencode SSE** (`opencode-server.ts`): live streaming arrives as `session.next.text.delta` / `session.next.reasoning.delta` / `session.next.tool.{called,success,failed}` — NOT `message.part.*` (those are terminal/post-hoc). `client.event.subscribe({ directory })` MUST pass the session's worktree directory; omit it and opencode scopes events to the server's `process.cwd()` → zero session events (empty turns, 180s watchdog timeout). Per-session SSE (P1.5-a): each live session owns its own `event.subscribe({directory})` loop + AbortController, so concurrent sessions in different worktrees stream independently; a `sessionID` demux guard drops cross-session events when two share a dir. Turn completes on `session.idle`; `promptAsync` is fire-and-forget (204).
|
|
||||||
- **opencode model strings** must be provider-prefixed (`llama-swap/<model>`) AND exist in `~/.config/opencode/opencode.json` `provider.llama-swap.models` — not merely loadable by llama-swap. `parseModel` infers `llama-swap/` for a bare id; the dispatcher coalesces empty→DEFAULT_MODEL then prefixes. `agent-probe` populates opencode's `available_agents.models` via `mergeLlamaSwap` (fetches `/v1/models`); empty model list → frontend sends `''` → no inference (`input:0`, empty turn).
|
|
||||||
- **agent_sessions resume**: `config_hash = sha256('opencode_server|<model>')` — must NOT include the server port (random per boot; including it breaks cross-restart resume). P1.5-b: `agent_sessions` is keyed `(chat_id, agent)` — the tab/chat is the context unit (two opencode tabs in one session = two contexts sharing one worktree). `chat_id` CASCADEs from `chats`; `session_id`/`worktree_id` are informational `SET NULL`. The `worktrees` table (one-per-session, `session_id` SET NULL so it survives session delete) supersedes the defanged `session_worktrees`. `tasks.chat_id` threads the tab id to the dispatcher; `runOpenCodeServerTask` falls back to resolve-or-create a chat when it's null (arena/MCP/new_task). The `@opencode-ai/sdk` v2 client takes flattened params (`{sessionID, directory, parts, model:{providerID,modelID}}`), imports `createOpencodeClient` from `@opencode-ai/sdk/v2/client`.
|
|
||||||
|
|
||||||
### Frontend (`apps/web/src/`)
|
|
||||||
|
|
||||||
- **React 18** + React Router v6 + **Tailwind v4** + shadcn/radix-ui primitives.
|
|
||||||
- **Shiki** for syntax highlighting (async `codeToHtml` in `CodeBlock.tsx` and `FileViewer` in `FileBrowserPane.tsx`).
|
|
||||||
- Path alias: `@/` maps to `src/`.
|
|
||||||
- **Mobile interaction primitives** (post-v1.6): `useViewport` (matchMedia, breakpoints mobile <768 / tablet 768–1023 / desktop ≥1024), `useSidebarDrawer` / `useRightRailDrawer` (Context + auto-close on `useLocation().pathname` change), `useLongPress` (500ms timer, dispatches synthetic `contextmenu` on `[data-tab-id]`), `usePullToRefresh` (80px threshold, 600ms hold), `SwipeablePaneTab` (60px close, 30px vertical bail). Tap-target convention: `max-md:min-h-[44px] max-md:min-w-[44px]`. Mobile headers: `border-b px-3 sm:px-4 py-2` + `style={{ paddingTop: 'max(0.5rem, env(safe-area-inset-top))' }}`. Hamburger left, FolderTree right.
|
|
||||||
|
|
||||||
Key patterns:
|
|
||||||
- **`hooks/sessionEvents.ts`** — Module-singleton event bus (Set of listeners). Used for cross-component communication: session renames, file-open events, attachment dispatch. 9 event types in the discriminated union. When adding a new event type to the `SessionEvent` union, you must also add a case to the `applyEvent` switch in `useSidebar.ts` (even if it's a no-op `return prev`).
|
|
||||||
- **`hooks/useSessionStream.ts`** — WebSocket per session, `applyFrame` reducer builds message list from streaming frames.
|
|
||||||
- **`hooks/useUserEvents.ts`** — Single app-level WS to `/api/ws/user` with exponential backoff reconnect. Forwards frames onto the sessionEvents bus.
|
|
||||||
- **`hooks/useSidebar.ts`** — Module-singleton with Set<setState> subscriber pattern; one bus subscription guarded by `globalThis.__boocode_sidebar_subscribed` for HMR safety. Every new `SessionEvent` type needs a `case` in the `applyEvent` switch (no-op `return prev` is fine).
|
|
||||||
- **`api/client.ts`** — Centralized typed fetch wrapper. All endpoints under `api.*` namespace.
|
|
||||||
|
|
||||||
Font / CSS pipeline (apps/web):
|
|
||||||
- Tailwind v4's `@import "tailwindcss"` directive strips font URLs from subsequent CSS `@import`s — `@fontsource*` packages must be imported as JS side-effect modules in `apps/web/src/main.tsx`, not via `@import` in `globals.css`. Otherwise the woff2 files never make it to `dist/`.
|
|
||||||
- Lightning CSS (inside `@tailwindcss/postcss` v4) collapses contiguous unicode-ranges to wildcard shorthand (`U+0000-FFFF` → `U+????`), which iOS Safari/Vivaldi mishandles (silently drops the font from those codepoints). Use explicit non-wildcard-collapsible subranges (e.g. `U+2500-259F` not `U+2500-25FF`). The `apps/web` build script greps `dist/assets/*.css` for `U+2500-259F` and fails the build if missing — preserve that guard.
|
|
||||||
- `@font-face` blocks must live AFTER all `@import` statements (CSS spec). Earlier placement silently breaks every subsequent `@import` (this broke the 18 theme palette imports in globals.css for one session).
|
|
||||||
- JetBrainsMono Nerd Font self-hosted in `apps/web/src/fonts/` (TTF from ryanoasis/nerd-fonts release) — needed because `@fontsource-variable/jetbrains-mono` ships subsetted woff2s that don't cover `U+2500-259F` (box drawing + block elements, used by opencode's banner). "NL" = No Ligatures (matches `font-feature-settings: "liga" 0`); "Mono" = single-cell icon width so TUI layouts don't desync.
|
|
||||||
- xterm-addon-webgl rasterizes glyphs via Canvas2D into a GPU texture atlas. Canvas2D does NOT honor `font-display: block` — it uses whatever font is currently registered. Gate xterm initialization on `document.fonts.load(<font-name>)` resolving before calling `term.open()` (see `fontsReady` useState in `TerminalPane.tsx`). iOS Safari/Vivaldi also reclaims WebGL contexts from backgrounded tabs: keep `webgl.onContextLoss(() => webgl.dispose())` + recreate via visibilitychange. Do NOT manually dispose+recreate the addon after font load — iOS silently fails the second GL context creation and the terminal drops to DOM renderer with stale metrics.
|
|
||||||
|
|
||||||
### Data flow for chat
|
### Data flow for chat
|
||||||
|
|
||||||
@@ -125,92 +61,64 @@ Font / CSS pipeline (apps/web):
|
|||||||
5. Tool calls: inference executes tools server-side, publishes tool_call/tool_result frames, loops back to LLM
|
5. Tool calls: inference executes tools server-side, publishes tool_call/tool_result frames, loops back to LLM
|
||||||
6. Terminal states (complete/error): DB updated with final content + token counts, `session_updated` frame published on user channel
|
6. Terminal states (complete/error): DB updated with final content + token counts, `session_updated` frame published on user channel
|
||||||
|
|
||||||
### Multi-pane workspace
|
|
||||||
|
|
||||||
Sessions hold 1–5 panes (chat / empty / placeholder terminal+agent). v1.12.1 moved pane state from per-device localStorage to `sessions.workspace_panes jsonb` for cross-device sync. `PATCH /api/sessions/:id/workspace` persists; `session_workspace_updated` user-channel frame broadcasts to every device watching the session. `useWorkspacePanes` debounces saves 300ms and dedups echoes by JSON string. Legacy localStorage key `boocode.workspace.panes.<sessionId>` is read once on first hydrate (one-time seed-and-delete migration when server is empty but localStorage has data); no longer written. The deprecated `session_panes` table was dropped. `validatePanes(validChatIds)` prunes panes referencing chat IDs that no longer exist (called by `useSessionChats` after the chat list fetch lands). Each chat lives in at most one pane; tab strip is per-pane and tracks `chatIds[]` + `activeChatIdx`. Tab reorder via native HTML5 drag events. v2.6.5: `workspace_panes` is now a `WorkspaceState` envelope `{panes, tabNumbers (chatId→stable session-scoped tab number, assigned on chat-pane open, retired on close, never reused), nextTabNumber, closedPaneStack (reopen LIFO, max 10, persisted so it survives reload)}` — not a bare `WorkspacePane[]`. Hydrate (`toWorkspaceState`) and the server PATCH validator (`z.union([array, envelope])` in `routes/sessions.ts`) both accept the legacy array and normalize to the envelope on read/write. Closing a chat pane relocates its tabs to the oldest chat/empty pane; `reopenPane` strips the restored chatIds from all live panes first (no duplication). `read_tab_by_number` resolves a number→chatId through `tabNumbers`.
|
|
||||||
|
|
||||||
## Database
|
## Database
|
||||||
|
|
||||||
PostgreSQL 16. Database name: `boochat` (renamed from `boocode` in v2.0.0-alpha; Docker service name stays `boocode_db`). Tables: `projects`, `sessions`, `chats`, `messages`, `settings`, `message_parts` (v1.13.0), `pending_changes` (v2.0.0), `tasks` (v2.0.0), `available_agents` (v2.0.0). Views: `messages_with_parts` (v1.13.1-B parts-merge read path), `tool_cost_stats` (v1.13.10 per-tool 100-call rolling window), `human_inbox` (v2.0.0 — tasks WHERE state IN blocked/failed). (`session_panes` was dropped in v1.12.1; workspace pane state lives in `sessions.workspace_panes jsonb`.) Schema applied idempotently on startup via `applySchema()`. Use `clock_timestamp()` (not `NOW()`) inside transactions. CHECK constraints in place: `projects_status_chk` ('open'|'archived'), `sessions_status_chk` (same), `chats_status_chk` (same), `messages_role_chk`, `messages_status_chk` — keep in sync with the `*_STATUSES` const arrays in `apps/server/src/types/api.ts`. The older anonymous `messages_status_check` (without 'cancelled') and `messages_role_check` (without 'system') were dropped in v1.12.1; only the `_chk` variants remain. **Two schema files, one DB:** `apps/server/src/schema.sql` owns `sessions`/`chats`/`messages`/`message_parts`; `apps/coder/src/schema.sql` (applied by the boocoder host service) owns `agent_sessions`, `worktrees`, `pending_changes`, `available_agents` and extends `tasks`. Both apply idempotently to the one `boochat` DB — so e.g. an `agent_sessions` FK change goes in the **coder** schema, not the server one. Idempotent FK-action flips (e.g. `ON DELETE CASCADE`→`SET NULL`) guard on `pg_constraint.confdeltype` so a re-run/fresh-deploy is a no-op (see the `session_worktrees`/`agent_sessions` defang blocks).
|
PostgreSQL 16. DB name: `boochat` (Docker service stays `boocode_db`). Tables: `projects`, `sessions`, `chats`, `messages`, `settings`, `message_parts`, `pending_changes`, `tasks`, `available_agents`. Views: `messages_with_parts` (parts-merge read path), `tool_cost_stats` (per-tool 100-call rolling window), `human_inbox` (tasks WHERE state IN blocked/failed). Schema applied idempotently on startup via `applySchema()`. Use `clock_timestamp()` (not `NOW()`) inside transactions. CHECK constraints: `projects_status_chk`/`sessions_status_chk`/`chats_status_chk` ('open'|'archived'), `messages_role_chk`, `messages_status_chk` — keep in sync with the `*_STATUSES` const arrays in `apps/server/src/types/api.ts`. **Two schema files, one DB:** `apps/server/src/schema.sql` owns `sessions`/`chats`/`messages`/`message_parts`; `apps/coder/src/schema.sql` (applied by the boocoder host service) owns `agent_sessions`, `worktrees`, `pending_changes`, `available_agents` and extends `tasks` — so e.g. an `agent_sessions` FK change goes in the **coder** schema. Idempotent FK-action flips (e.g. `ON DELETE CASCADE`→`SET NULL`) guard on `pg_constraint.confdeltype` so re-runs are no-ops.
|
||||||
|
|
||||||
Schema CHECK migration order when renaming allowed values: (1) `ALTER TABLE ... DROP CONSTRAINT IF EXISTS <system_name>` (inline `CREATE TABLE` checks get `<table>_<column>_check`), (2) `UPDATE` rows to new values, (3) wrap new constraint ADD in `DO $$ ... pg_constraint` guard — that block is the only way to get `ADD CONSTRAINT IF NOT EXISTS`.
|
Schema CHECK migration order when renaming allowed values: (1) `ALTER TABLE ... DROP CONSTRAINT IF EXISTS <system_name>` (inline `CREATE TABLE` checks get `<table>_<column>_check`), (2) `UPDATE` rows to new values, (3) wrap the new constraint ADD in a `DO $$ ... pg_constraint` guard — the only way to get `ADD CONSTRAINT IF NOT EXISTS`.
|
||||||
|
|
||||||
|
**`CREATE OR REPLACE VIEW` can't reorder/rename columns** (Postgres `42P16`): append a new `messages_with_parts` column at the END of the SELECT — a mid-list insert shifts an existing column → crash-loops boot. Add it to each explicit read SELECT too (`routes/messages.ts`/`chats.ts`/`ws.ts`).
|
||||||
|
|
||||||
## Environment
|
## Environment
|
||||||
|
|
||||||
Required: `DATABASE_URL`, `LLAMA_SWAP_URL`. Optional: `PORT` (3000), `HOST` (0.0.0.0), `PROJECT_ROOT_WHITELIST` (/opt, read-only scope for add-existing path resolution), `BOOTSTRAP_ROOT` (/opt/projects, writable scope for create-new-project bootstrap mkdir target — host must `mkdir -p /opt/projects` before container start), `DEFAULT_MODEL`, `LOG_LEVEL`, `SEARXNG_URL` (default `http://100.114.205.53:8888` — internal Tailscale Fathom; the public `search.indifferentketchup.com` is behind Authelia and unusable from server context), `BOOCODE_TOOLS` (`core` | `standard` | `all`, default `all`; v1.13.15-tools tier filter — ceiling, never expands an agent's whitelist), `MCP_CONFIG_PATH` (optional; default `/data/mcp.json` — JSON config for MCP servers matching opencode's `mcpServers` shape; file missing = no MCP).
|
Required: `DATABASE_URL`, `LLAMA_SWAP_URL`. Optional: `PORT` (3000), `HOST` (0.0.0.0), `PROJECT_ROOT_WHITELIST` (/opt, read-only add-existing scope), `BOOTSTRAP_ROOT` (/opt/projects, writable bootstrap mkdir target — host must `mkdir -p` it before container start), `DEFAULT_MODEL`, `LOG_LEVEL`, `SEARXNG_URL` (default `http://100.114.205.53:8888` — internal Tailscale; the public host is behind Authelia, unusable from server context), `BOOCODE_TOOLS` (`core`|`standard`|`all`, default `all`; a ceiling, never expands an agent's whitelist), `MCP_CONFIG_PATH` (default `/data/mcp.json`, opencode `mcpServers` shape; missing = no MCP), `CONTEXT7_API_KEY` (the Context7 MCP key, referenced from `data/mcp.json` as `"{env:CONTEXT7_API_KEY}"`). `data/mcp.json` is **gitignored** but no longer holds secrets — string values support opencode-style `{env:VAR}` substitution (`mcp-config.ts:substituteEnvVars`, applied before Zod validation; unset var → `''` + warn), so real keys live in `.env`; template `data/mcp.example.json`. A config-only edit there needs only `docker compose restart boocode` (data/ is bind-mounted); changing a referenced secret edits `.env`. MCP loads at server startup with per-server graceful degradation; the coder does NOT load MCP (BooChat only).
|
||||||
|
|
||||||
BooCoder at port 9502: `curl http://100.114.205.53:9502/api/health`. Runs as `boocoder.service` on the host (not Docker). Deploy: `pnpm -C apps/server build && pnpm -C apps/coder build && sudo systemctl restart boocoder`. Health reports tool count: `{"ok":true,"db":true,"tools":33}`.
|
BooCoder at port 9502: `curl http://100.114.205.53:9502/api/health`. Runs as `boocoder.service` on the host (not Docker). Deploy: `pnpm -C apps/server build && pnpm -C apps/coder build && sudo systemctl restart boocoder`. Health reports tool count: `{"ok":true,"db":true,"tools":33}`.
|
||||||
|
|
||||||
- `FAST_MODEL` (optional) — cheaper model for titles, summaries, labeling (auto_name.ts, tool-summaries.ts). Falls back to session model or DEFAULT_MODEL when unset. Set to a small model on llama-swap (e.g. `nemotron-nano-4b`) to avoid loading the 35B for 20-token calls.
|
- `FAST_MODEL` (optional) — cheaper model for titles, summaries, labeling (auto_name.ts, tool-summaries.ts). Falls back to session model or DEFAULT_MODEL. Set to a small llama-swap model (e.g. `nemotron-nano-4b`) to avoid loading the 35B for 20-token calls.
|
||||||
- Qwen Code dispatch: `OPENAI_BASE_URL=http://100.101.41.16:8401/v1 OPENAI_API_KEY=dummy qwen -p "<task>" --output-format stream-json`. Install: `npm install -g @qwen-code/qwen-code@latest`. Node ≥22 required on host (container stays Node 20; BooCoder dispatches via direct spawn on host). No `--yolo` flag — non-interactive mode (`-p`) runs autonomously without approval prompts. ACP bridge is HTTP daemon (not stdio); use PTY dispatch.
|
- Qwen Code dispatch: `OPENAI_BASE_URL=http://100.101.41.16:8401/v1 OPENAI_API_KEY=dummy qwen -p "<task>" --output-format stream-json`. Install: `npm install -g @qwen-code/qwen-code@latest`. Node ≥22 on host (container stays Node 20; BooCoder dispatches via direct spawn on host). No `--yolo` flag — `-p` runs autonomously without prompts. ACP bridge is an HTTP daemon (not stdio); use PTY dispatch.
|
||||||
- Arena (v2.0.5): `POST /api/arena {project_id, input, contestants: [{agent?, model?}]}` dispatches the same task to N models/agents in parallel. Each contestant gets its own task + worktree. `GET /api/arena/:id` for results. `POST /api/arena/:id/select/:task_id` picks winner.
|
- Arena: `POST /api/arena {project_id, input, contestants: [{agent?, model?}]}` dispatches the same task to N models/agents in parallel; each contestant gets its own task + worktree. `GET /api/arena/:id` for results; `POST /api/arena/:id/select/:task_id` picks a winner.
|
||||||
|
|
||||||
## Workflow
|
## Workflow
|
||||||
|
|
||||||
- Sam reviews all diffs and commits manually. Do not commit unless explicitly asked.
|
- Sam reviews all diffs and commits manually. Do not commit unless explicitly asked.
|
||||||
- Sam often has uncommitted `apps/web` work in flight mid-session — stage your own commits **explicitly by path** (never `git add -A`); and `docker compose up --build -d boocode` builds the working tree, so a container rebuild also ships his uncommitted web changes.
|
- Sam often has uncommitted `apps/web` work in flight — stage your own commits **explicitly by path** (never `git add -A`); `docker compose up --build -d boocode` builds the working tree, so a container rebuild also ships his uncommitted web changes.
|
||||||
- Cutting a release: name the feature branch DIFFERENTLY from the tag (branch `f1-interrupt-guard`, tag `v2.6.7-interrupt-guard`) — identical branch+tag names trigger `warning: refname ... is ambiguous`.
|
- **Deploy by surface:** an `apps/coder` change → `sudo systemctl restart boocoder`; an `apps/web` or `apps/server` change → `docker compose up --build -d boocode` (rebuilds web+server from the working tree). The `boocode` container is `build: .`, so uncommitted changes deploy; web edits are live on the Vite dev server (HMR) but NOT on production (`:9500` / code.indifferentketchup.com) until a rebuild. Use `docker compose build --no-cache boocode && docker compose up -d` if you suspect a layer-cache issue.
|
||||||
- Per-batch docs live under `openspec/changes/<slug>/{proposal,tasks,design}.md`. Already-shipped batches are snapshots in `openspec/changes/archived/`. New batches follow the proposal+tasks shape; see `openspec/README.md` for the convention.
|
- Cutting a release: name the feature branch DIFFERENTLY from the tag (branch `f1-interrupt-guard`, tag `v2.6.7-interrupt-guard`) — identical names trigger `warning: refname ... is ambiguous`.
|
||||||
- Tag naming: `vMAJOR.MINOR.PATCH-slug` (e.g. `v1.13.13-ws-publish`). Monotonic per minor — the slug describes the batch's content so the tag name alone is enough to recall what shipped. No letter suffixes (`-a`/`-b`), no pseudo-ranges (`v1.11.x`), no slug-only sub-versions sharing a number (`v1.13.15-tools` + `-openspec` + `-agentlint` — split into sequential patches instead).
|
- Per-batch docs live under `openspec/changes/<slug>/{proposal,tasks,design}.md`; shipped batches are snapshots in `openspec/changes/archived/`. New batches follow the proposal+tasks shape (see `openspec/README.md`).
|
||||||
- `CHANGELOG.md` is the per-tag release log, most-recent on top. When a new tag is created, add a `## <tag> — <YYYY-MM-DD>` section with a 3–6 sentence paragraph summarizing what shipped, drawn from the commit body. Cross-reference other tags by name when the batch builds on, fixes, or pairs with prior work (e.g. "pairs with `v1.13.12-ws-schemas`", "fixed in `v1.13.5-stability-bundle`"). No nested bullets — one paragraph.
|
- Tag naming: `vMAJOR.MINOR.PATCH-slug` (e.g. `v1.13.13-ws-publish`), monotonic per minor — the slug alone recalls what shipped. No letter suffixes, no pseudo-ranges, no slug-only sub-versions sharing a number (split into sequential patches).
|
||||||
- Deploy: `cd /opt/boocode && docker compose up --build -d` (or `docker compose build --no-cache boocode && docker compose up -d` if you suspect a layer-cache issue).
|
- `CHANGELOG.md` is the per-tag release log, newest on top. New tag → add a `## <tag> — <YYYY-MM-DD>` section, one 3–6 sentence paragraph (no nested bullets) from the commit body; cross-reference related tags by name when the batch builds on / fixes / pairs with prior work.
|
||||||
- The `boocode` container is `build: .` — it builds web+server from the **working tree**, so uncommitted changes deploy. Web edits are live on the Vite dev server (HMR) but NOT on production (`:9500` / code.indifferentketchup.com) until `docker compose up --build -d boocode`.
|
|
||||||
- Git push to Gitea: `GIT_SSH_COMMAND="ssh -i /opt/boocode/secrets/boocode_gitea -o IdentitiesOnly=yes" git push origin <branch>`. The default agent identity is rejected; the in-repo deploy key (`secrets/`, gitignored) is the working one. Transient `Connection reset by peer` retries cleanly after `sleep 5`. Keep both remotes synced: push `main` + the release tag to `origin` (Gitea, deploy key above) AND `backup` (`git@github.com:indifferentketchup/boocode.git`, default key).
|
- Git push to Gitea: `GIT_SSH_COMMAND="ssh -i /opt/boocode/secrets/boocode_gitea -o IdentitiesOnly=yes" git push origin <branch>`. The default agent identity is rejected; the in-repo deploy key (`secrets/`, gitignored) is the working one. Transient `Connection reset by peer` retries cleanly after `sleep 5`. Keep both remotes synced: push `main` + the release tag to `origin` (Gitea, deploy key above) AND `backup` (`git@github.com:indifferentketchup/boocode.git`, default key).
|
||||||
- Don't accumulate `.bak-*` files. Clean them up in the same batch or immediately after merge.
|
- Don't accumulate `.bak-*` files. Clean them up in the same batch or immediately after merge.
|
||||||
- DB-integration tests opt-in via env var: `DATABASE_URL='postgres://boocode:devpass@localhost:5500/boochat' pnpm -C apps/server test`. Host port is 5500 (mapped from `boocode_db:5432`); password is `${POSTGRES_PASSWORD}` from `.env` (`devpass`), NOT the literal in `.env`'s `DATABASE_URL=postgres://boocode:Ketchup1479@boocode_db:5432/...` line. `psql` is not on the host PATH — for an interactive query use `docker exec boocode_db psql -U boocode -d boochat -c "..."`. Pattern: `describe.runIf(!!process.env.DATABASE_URL)(...)` with a `beforeAll` that applies the schema via `sql.unsafe(readFileSync(schemaPath))`. Tests skip cleanly when var is unset. `tool_cost_stats.test.ts` is the reference.
|
- DB-integration tests opt-in via env var: `DATABASE_URL='postgres://boocode:devpass@localhost:5500/boochat' pnpm -C apps/server test`. Host port 5500; password is `${POSTGRES_PASSWORD}` from `.env` (`devpass`), NOT the literal in `.env`'s `DATABASE_URL` line. `psql` isn't on host PATH — use `docker exec boocode_db psql -U boocode -d boochat -c "..."`. Pattern: `describe.runIf(!!process.env.DATABASE_URL)(...)` + `beforeAll` applying schema via `sql.unsafe(readFileSync(schemaPath))`. `tool_cost_stats.test.ts` is the reference.
|
||||||
- Host-side smoke endpoint: `curl http://100.114.205.53:9500/api/...`. The boocode container's port mapping binds to the Tailscale IP, not `0.0.0.0`, so `localhost:9500` doesn't work from the host shell. Same for booterm at `:9501`.
|
- Host-side smoke endpoint: `curl http://100.114.205.53:9500/api/...`. The container's port mapping binds to the Tailscale IP, not `0.0.0.0`, so `localhost:9500` doesn't work from the host shell. Same for booterm at `:9501`.
|
||||||
- Frontend blank-screen / runtime crash: get the stack-trace column offset from the browser console, then `cut -c <start>-<end> apps/web/dist/assets/index-*.js | sed -n '<line>p'` to read the exact minified expression that threw. Faster than bisecting source. Watch for `=== null`/`!== null` on optional fields fed an `as unknown as` cast — those bypass tsc.
|
- Frontend blank-screen / runtime crash: get the stack-trace column offset from the browser console, then `cut -c <start>-<end> apps/web/dist/assets/index-*.js | sed -n '<line>p'` to read the exact minified expression that threw. Watch for `=== null`/`!== null` on optional fields fed an `as unknown as` cast — those bypass tsc.
|
||||||
- Fastify global JSON parser tolerates empty bodies (overridden in `index.ts`); bodyless POSTs (archive, unarchive, stop) work without setting `Content-Type` tricks on the client.
|
- Fastify global JSON parser tolerates empty bodies (overridden in `index.ts`); bodyless POSTs (archive, unarchive, stop) work without `Content-Type` tricks on the client.
|
||||||
- Event dedup discipline: for any mutation the server publishes via `broker.publishUser`, do NOT add a local `sessionEvents.emit(...)` after the API call — `useUserEvents` forwards the WS frame onto the bus. Frontend mutation handlers must be idempotent (dedup by id, no-op on already-present).
|
- Event dedup discipline: for any mutation the server publishes via `broker.publishUser`, do NOT add a local `sessionEvents.emit(...)` after the API call — `useUserEvents` forwards the WS frame onto the bus. Frontend mutation handlers must be idempotent (dedup by id, no-op on already-present).
|
||||||
- `node:20-*` base images ship a `node` user at uid/gid 1000 — delete it (`userdel`/`groupdel` on debian, `deluser`/`delgroup` on alpine) before adding samkintop at 1000.
|
- `node:20-*` base images ship a `node` user at uid/gid 1000 — delete it (`userdel`/`groupdel` on debian, `deluser`/`delgroup` on alpine) before adding samkintop at 1000.
|
||||||
- node-pty's compiled `.node` is libc-specific: proddeps and runtime Dockerfile stages must share libc (alpine↔musl or bookworm-slim↔glibc); the TS-only builder stage can stay alpine for speed.
|
- node-pty's compiled `.node` is libc-specific: proddeps and runtime Dockerfile stages must share libc (alpine↔musl or bookworm-slim↔glibc); the TS-only builder stage can stay alpine for speed.
|
||||||
- pnpm 10 `--frozen-lockfile` skips node-pty's postinstall — the Docker proddeps stage runs `cd node_modules/node-pty && npm run install` to force the native compile.
|
- pnpm 10 `--frozen-lockfile` skips node-pty's postinstall — the Docker proddeps stage runs `cd node_modules/node-pty && npm run install` to force the native compile.
|
||||||
- A local PreToolUse hook (`security_reminder_hook.py`) regex-flags Node's older `child_process` spawn helpers as unsafe (false positive even on the File-suffixed variant). Use `spawn` — it's accepted.
|
- A local PreToolUse hook (`security_reminder_hook.py`) regex-flags Node's older `child_process` spawn helpers as unsafe (false positive even on the File-suffixed variant). Use `spawn` — it's accepted.
|
||||||
- `/opt/boolab` hosts a working sibling BooCode terminal at `boocode.indifferentketchup.com`. Useful for visual side-by-side comparison on the same iPhone when debugging booterm rendering. Boolab uses Tailwind v3 (`@tailwind base`); boocode uses v4 — many subtle build differences. Don't assume parity.
|
- `/opt/boolab` hosts a sibling BooCode at `boocode.indifferentketchup.com` — useful for side-by-side iPhone comparison when debugging booterm rendering. It uses Tailwind v3, boocode uses v4 — don't assume build parity.
|
||||||
- booterm SSHs to the host as `samkintop@100.114.205.53` (the Tailscale IP). The hostname `ubuntu-homelab` (shown in the bash prompt after login) does NOT resolve from inside the container — only the host's `/etc/hosts` knows it. Override via `BOOTERM_SSH_HOST` / `BOOTERM_SSH_USER` env vars in docker-compose if you ever move the shell to a different machine.
|
- booterm SSHs to the host as `samkintop@100.114.205.53` (the Tailscale IP). The hostname `ubuntu-homelab` (in the bash prompt) does NOT resolve inside the container. Override via `BOOTERM_SSH_HOST` / `BOOTERM_SSH_USER` env vars in docker-compose if the shell moves to a different machine.
|
||||||
- codecontext sidecar lives at `/opt/boocode/codecontext/`. Sidecar HTTP API at `http://codecontext:8080/v1/<tool_name>` over the `boocode_net` bridge (no host port). BooCode wrappers in `apps/server/src/services/tools/codecontext/`. The `.codecontextignore` at project root is honored when `--respect-gitignore` is passed (enabled in the shim).
|
- codecontext sidecar lives at `/opt/boocode/codecontext/`. HTTP API at `http://codecontext:8080/v1/<tool_name>` over the `boocode_net` bridge (no host port). BooCode wrappers in `apps/server/src/services/tools/codecontext/`. The `.codecontextignore` at project root is honored when `--respect-gitignore` is passed (enabled in the shim).
|
||||||
- codecontext fork at `/opt/forks/codecontext/` — separate git repo (branch `boocode-ts`), pushed via the same boocode_gitea SSH key to `indifferentketchup/codecontext`. Build: `go build ./...`. Test: `go test ./...`. Docker rebuild requires staging the fork source first: `tar -czf codecontext/fork.tar.gz -C /opt/forks/codecontext --exclude=.git --exclude=bin .` then `docker compose build --no-cache codecontext`. The Dockerfile COPYs `fork.tar.gz` into the builder stage (Gitea is behind Authelia, no HTTP clone). `fork.tar.gz` is gitignored.
|
- codecontext fork at `/opt/forks/codecontext/` — separate git repo (branch `boocode-ts`), pushed via the boocode_gitea SSH key to `indifferentketchup/codecontext`. Build `go build ./...`; test `go test ./...`. Docker rebuild requires staging the fork first: `tar -czf codecontext/fork.tar.gz -C /opt/forks/codecontext --exclude=.git --exclude=bin .` then `docker compose build --no-cache codecontext` (the Dockerfile COPYs `fork.tar.gz` into the builder stage; Gitea is behind Authelia, no HTTP clone). `fork.tar.gz` is gitignored.
|
||||||
- Go binary: `/snap/go/current/bin/go` (not on PATH by default). Use `export PATH=$PATH:/snap/go/current/bin` or full path for Go commands.
|
- Go binary: `/snap/go/current/bin/go` (not on PATH). Use `export PATH=$PATH:/snap/go/current/bin` or the full path.
|
||||||
- `os/exec` child supervisors must explicitly call `child.Wait()` in a goroutine and `os.Exit` on child death. `Signal(0)` returns nil on zombies and is NOT a liveness check. Without `Wait()`, docker's `restart: unless-stopped` policy never fires because the parent stays alive. The `codecontext/shim.go` implementation is the reference pattern.
|
- `os/exec` child supervisors must call `child.Wait()` in a goroutine and `os.Exit` on child death. `Signal(0)` returns nil on zombies and is NOT a liveness check. Without `Wait()`, docker's `restart: unless-stopped` never fires because the parent stays alive. `codecontext/shim.go` is the reference.
|
||||||
|
|
||||||
## Conventions
|
## Conventions
|
||||||
|
|
||||||
- `overflowWrap` not `wordWrap` — TypeScript's CSSStyleDeclaration marks `wordWrap` as deprecated (error 6385).
|
Cross-cutting only. Per-app conventions live in the matching `apps/*/CLAUDE.md`.
|
||||||
|
|
||||||
- No app-layer auth. Authelia handles auth at the reverse proxy. All `broker.publishUser`/`subscribeUser` calls use `'default'` as the user key.
|
- No app-layer auth. Authelia handles auth at the reverse proxy. All `broker.publishUser`/`subscribeUser` calls use `'default'` as the user key.
|
||||||
- TypeScript strict mode. Both apps share `tsconfig.base.json`.
|
- TypeScript strict mode. Both apps share `tsconfig.base.json`. Server + coder use NodeNext module resolution (`.js` extensions in imports).
|
||||||
- Server uses NodeNext module resolution (`.js` extensions in imports).
|
|
||||||
- Discriminated unions for type narrowing: `Pane` (by `kind`), `SessionEvent` (by `type`), `InferenceFrame` (by `type`).
|
- Discriminated unions for type narrowing: `Pane` (by `kind`), `SessionEvent` (by `type`), `InferenceFrame` (by `type`).
|
||||||
- **Adding a new WS frame type** requires updating BOTH the server's `InferenceFrame` (loose `type:` union + optional fields in `services/inference/turn.ts`) AND the web `WsFrame` (strict discriminated union in `apps/web/src/api/types.ts`). Server publish is permissive; the frontend type is the wire-format gate. The `'usage'` frame added in v1.12.2 needed both sides; missing the web side silently drops the frame at JSON-parse.
|
- **Adding a new WS frame type** (cross-app) requires updating BOTH the server's `InferenceFrame` (loose `type:` union + optional fields in `services/inference/turn.ts`) AND the web `WsFrame` (strict discriminated union in `apps/web/src/api/types.ts`). Server publish is permissive; the frontend type is the wire-format gate — missing the web side silently drops the frame at JSON-parse.
|
||||||
- shadcn primitives live in `components/ui/`. Don't modify them unless adding a new primitive.
|
- **Sentinels** (cross-app) are `role='system'` rows with structured `metadata.kind` (`cap_hit`, `doom_loop`). UI-only — `buildMessagesPayload` strips them via `isAnySentinel` so the LLM never sees them. A new kind requires arms in `MessageMetadata` in BOTH `apps/server/src/types/api.ts` AND `apps/web/src/api/types.ts`, plus a render branch in `apps/web/src/components/MessageBubble.tsx`.
|
||||||
- `ui/` primitives present: button, card, context-menu, dialog, dropdown-menu, input, label, radio-group, sonner, textarea. No switch/sheet/drawer/badge/checkbox — use a `<button role="switch" aria-checked>` toggle (a hand-rolled `Switch` already lives in `SettingsPane.tsx`) and a Dialog-based panel for "drawers".
|
- **Coder↔web provider-type parity** (`apps/coder/src/services/provider-types.ts` ↔ `apps/web/src/api/types.ts`): enforced by runtime `provider-types-parity.test.ts` (compile-time cross-import is blocked by TS6307 on web's composite tsconfig). Mirror of the ws-frames parity pattern — edit both copies together.
|
||||||
- `inferLanguage()` from `lib/attachments.ts` is the canonical file-extension-to-language map. `CodeBlock.tsx` keeps its own `LANG_MAP` because it also resolves markdown fence names.
|
- **JSONB columns**: use `sql.json(value as never)` — NOT `${JSON.stringify(value)}::jsonb` which double-serializes (stores a JSON string instead of an object/array). Pattern in `parts.ts`, `settings.ts`.
|
||||||
- Two UI event buses: `hooks/sessionEvents.ts` for DB-state events (chat_created, session_updated); `lib/events.ts` for ephemeral UI (`sendToTerminal`, `terminalsRegistry`). Don't merge — different subscriber lifecycles.
|
- Skills live in `data/skills/<vendor>/`; Sam's own namespace is `boocode/` (`committing-changes`, `using-worktrees`, `improving-boocode-guidance`, `systematic-debugging`) — `SKILL.md` + optional `eval.yaml` (gerund names; eval = `skill:` + `tasks:` of `prompt`+`grader`, incl. a negative-trigger task). `data/skills/` is canonical; a divergent mirror at `/opt/skills/` exists.
|
||||||
- `vite.config.ts` proxy entries are order-sensitive: more-specific prefixes (`/api/term`, `/ws/term`) must come BEFORE `/api`.
|
|
||||||
- Mobile pane URL sync (`Session.tsx`): the `?pane=<id>` effect resets `activePaneIdx` whenever `panes` changes. New-pane creation on mobile must push `?pane=` atomically — `addPaneAndSwitch` is the wrapper that does this. `addSplitPane` returns the new pane id for callers.
|
### Coding standards
|
||||||
- A scrollable list inside a Dialog on mobile: cap `DialogContent` (`max-h-[85vh]` + `grid-rows-[auto_minmax(0,1fr)_auto]`) and make the list the single scroll region with `overscroll-contain` — otherwise touch-scroll drags the whole fixed modal / chains to the page.
|
|
||||||
- xterm.js v5 uses canvas rendering — browser doesn't see xterm's selection; the native right-click menu has no working Copy for terminal text. App keybindings (`Cmd/Ctrl-C`, `Cmd/Ctrl-Shift-C`) are the path.
|
Coding standards live in `docs/coding-standards/` (canonical, human-readable). They are exposed to Claude Code through per-file-type/subsystem index files under `.claude/rules/coding-standards/`. Each index is a path-scoped rule that lists the standards relevant to its `paths:` glob with a one-line description of each. When Claude reads a file matching an index's `paths:`, it loads only that small index and then decides which (if any) standards to open with Read — the full text of a standard is never loaded automatically, and standards do not appear in the skills picker. Browse `docs/coding-standards/` for the readable form.
|
||||||
- **New tools** live in their own `services/<name>.ts` file (see `web_search.ts`, `web_fetch.ts`) — exports a pure `executeFoo(input, ...deps)` for direct test access plus a `ToolDef` wrapper that `loadConfig()`s its real dependencies. Register the ToolDef in `tools.ts` `ALL_TOOLS` (and `READ_ONLY_TOOL_NAMES` if applicable). Inject `fetcher: typeof fetch = fetch` rather than `vi.spyOn(globalThis, 'fetch')` — cleanup is simpler and the production call site stays unchanged.
|
|
||||||
- **DB/session-aware tools** take an optional 4th `ToolExecCtx { sql, sessionId }` arg on `ToolDef.execute`, plumbed `executeToolPhase`→`executeToolCall`→`execute`. It's optional so the filesystem tools and the `apps/coder` `ALL_TOOLS` consumer stay compatible; filesystem tools ignore it. `read_tab_by_number` (reads `sessions.workspace_panes` + the chat's messages via `sql`) is the reference.
|
|
||||||
- **Sentinels** are `role='system'` rows with structured `metadata.kind` (`cap_hit`, `doom_loop`). UI-only — `buildMessagesPayload` strips them via `isAnySentinel` so the LLM never sees them. A new kind requires arms in `MessageMetadata` in BOTH `apps/server/src/types/api.ts` AND `apps/web/src/api/types.ts`, plus a render branch in `apps/web/src/components/MessageBubble.tsx`.
|
|
||||||
- **ReadableStream test stubs** use `pull()` (not `start()`) so chunks are produced lazily — `start()` enqueues everything and calls `controller.close()` before the consumer reads, so a subsequent `reader.cancel()` finds the stream already closed and the `cancel()` callback never fires. Also provide MORE chunks than the test will consume so the source stays in 'readable' state when cancel runs (e.g. cap test reads ~6 chunks, stub provides 10).
|
|
||||||
- React **StrictMode is on** (`main.tsx`): an updater passed to one `setState` that itself calls another `setState` (e.g. `setClosedPaneStack` inside a `setPanes` updater) is double-invoked in dev. Make such nested updates idempotent — `useWorkspacePanes`'s `appendClosed` dedupes a value-identical top entry for exactly this reason.
|
|
||||||
- Tool-name whitelists must derive from `ALL_TOOLS` in `services/tools.ts`, never hardcoded. `services/agents.ts` `ALL_TOOL_NAMES` had this drift class until v1.12 — same pattern applies to any future tool-aware code.
|
|
||||||
- Agent registry lives at `data/AGENTS.md` (global, bind-mounted at `/data/AGENTS.md`). No per-project `AGENTS.md` in this repo — removed in v1.12 to eliminate the two-files-must-stay-in-sync drift. The `getAgentsForProject` per-project override mechanism remains for *other* projects.
|
|
||||||
- `data/AGENTS.md` is PARSED (`agents.ts` `splitSections`/`parseAgentSection`): each `## <Name>` is one agent and must be followed by a `---` frontmatter fence or the block throws; content before the first `## ` is discarded. Do NOT add free-form `## ` rule sections — they break the registry. Cross-cutting agent rules go in CLAUDE.md or a parser-ignored preamble.
|
|
||||||
- Skills live in `data/skills/<vendor>/`; Sam's own namespace is `boocode/` (`committing-changes`, `using-worktrees`, `improving-boocode-guidance`) — `SKILL.md` + optional `eval.yaml` (gerund names; eval = `skill:` + `tasks:` of `prompt`+`grader`, incl. a negative-trigger task). `data/skills/` is canonical; a divergent mirror at `/opt/skills/` exists.
|
|
||||||
- MCP stdio transport uses newline-delimited JSON (NDJSON), NOT LSP-style `Content-Length` headers. The `codecontext/shim.go` framing implementation is the reference; per the MCP spec (modelcontextprotocol.io/specification/server/transports).
|
|
||||||
- **Workspace dependency pattern** (`apps/coder` → `@boocode/server`): the consuming package adds `"@boocode/server": "workspace:*"` in `package.json`. The provider's `package.json` needs `exports` with `types` + `default` conditions per subpath: `"./inference": { "types": "./dist/.../index.d.ts", "default": "./dist/.../index.js" }`. Without the `types` condition, NodeNext resolution can't find `.d.ts` files and tsc fails with "Cannot find module" in the consumer.
|
|
||||||
- **JSONB columns**: use `sql.json(value as never)` — NOT `${JSON.stringify(value)}::jsonb` which double-serializes (stores a JSON string instead of a JSON object/array). Pattern established in `parts.ts`, `settings.ts`.
|
|
||||||
- **`payload.ts:loadContext` SELECT**: must include every `Session` field that downstream code reads. The tool phase reads `session.allowed_read_paths`; if the SELECT omits it, cross-repo read grants silently fail. The `Session` TypeScript type doesn't catch this because `sql<Session[]>` doesn't enforce column coverage.
|
|
||||||
- **Sidecar routing** (`services/inference/provider.ts`): `upstreamModel(config, modelId, agent)` routes to `LLAMA_SIDECAR_URL` when agent has `llama_extra_args`, otherwise `LLAMA_SWAP_URL`. `resolveRoute(agent)` returns `{route: 'swap'|'sidecar', flags}`. Sidecar provider created fresh per call (not cached) because `X-Agent-Flags` header varies per agent. Boot-time guard in `index.ts` refuses to start if any agent has `llama_extra_args` but `LLAMA_SIDECAR_URL` is unset.
|
|
||||||
- **Secret guard safe patterns** (`services/secret_guard.ts`): `.env.example`, `.env.sample`, `.env.template`, `.env.defaults` are allowlisted via `SAFE_PATTERNS` set. Do NOT add `.env.production`/`.env.development`/`.env.test` — those can hold real secrets.
|
|
||||||
- **CoderPane uses ChatInput** (`components/panes/CoderPane.tsx`): shares the same `ChatInput` component as BooChat for full parity — attachments, paste-to-chip, auto-grow textarea, queued messages during send. CoderPane's `sendOneMessage` is the send callback; queued messages drain via `useEffect` when `sending` goes false.
|
|
||||||
- **Adding a new `SessionEvent` type**: add the interface, add it to the `SessionEvent` union, add a `case` in `useSidebar.ts` `applyEvent` switch (no-op `return prev` is fine), and subscribe in any hook that needs it (e.g. `useSessionStream` for `refetch_messages`).
|
|
||||||
- **BooCoder provider registry** (`apps/coder/src/services/provider-registry.ts`): static list of provider defs (boocode, opencode, goose, claude, qwen). `PROBED_AGENT_NAMES` derives from it. Adding/removing providers means editing this file, not the frontend.
|
|
||||||
- **AgentComposerBar filters `e.installed`**: provider snapshot entries with `installed:false` (loading/unavailable) are dropped from the dropdown. `getProviderSnapshot` must await the full build — returning synchronous `loading` placeholders makes every provider vanish (the v2.5.7 "no providers showing up" regression); surfacing loading states needs a client poll.
|
|
||||||
- **Coder↔web provider-type parity** (`apps/coder/src/services/provider-types.ts` ↔ `apps/web/src/api/types.ts`): enforced by runtime `provider-types-parity.test.ts` (compile-time cross-import is blocked by TS6307 on web's composite tsconfig). Mirror of the ws-frames parity pattern — edit both copies together or the test fails.
|
|
||||||
- **ACP command discovery is async**: `acp-probe.ts` must poll after `newSession` for `available_commands_update` (commands arrive in a later notification; reading synchronously captures 0). PTY providers (claude) instead discover from disk via `claude-command-discovery.ts` (`~/.claude/commands` + `enabledPlugins` `skills/`+`commands/`, bare names, deduped). `AgentCommand.kind` tags `'command'` vs `'skill'`; `CoderPane`'s `slashGroups` splits them into icon'd groups. `SlashCommandPicker`'s `groups?` prop is opt-in — BooChat passes flat `items` (unchanged).
|
|
||||||
- **Pane header architecture (mobile vs desktop)**: Desktop coder pane header (BooCode label + [+] [×]) lives in `Workspace.tsx` gated by `isCoder && !isMobile`. Mobile coder controls (● ×) live in `Session.tsx` header row next to `MobileTabSwitcher`/`NewPaneMenu`. `AgentComposerBar` (provider/mode/model pickers) renders inside `CoderPane.tsx` on both. The ● status dot is passed via `connected` prop from CoderPane to AgentComposerBar.
|
|
||||||
- **MessageBubble shared between BooChat and BooCoder** (`components/MessageBubble.tsx`): accepts optional `actions?: MessageActions` callbacks (onRegenerate, onResend, onFork, onDelete) and `hideActions?: ('fork'|'delete'|'openInPane')[]`. Defaults use BooChat API; CoderPane overrides via `CoderMessageList` props. `CoderTextBubble` was removed. **`CoderMessageList` passes `CoderMessageWire as unknown as Message`** — the coder wire shape lacks `metadata`/`kind`/`summary`, so those fields are `undefined` (not `null`) on coder messages. Null-guards on any `Message` field MUST use loose `!= null`, not strict `!== null` (`undefined !== null` is `true` → `.kind` throws → blank-screen crash). The `as unknown as` cast hides this from tsc; build + typecheck pass while runtime crashes.
|
|
||||||
- **llama-sidecar** (`/opt/forks/llama-sidecar/`): Go daemon for per-agent llama-server process pool. Cross-compile: `GOOS=windows GOARCH=amd64 /snap/go/current/bin/go build -o bin/llama-sidecar.exe ./cmd/llama-sidecar`. Gitea: `indifferentketchup/llama-sidecar`. Windows child process gotchas: use `context.Background()` for child lifetime (not request ctx), `os.Open(os.DevNull)` for stdin, `os.Pipe()` for stdout with drain goroutine, `DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP` creation flags. SSH to sam-desktop: `ssh samki@100.101.41.16`; use `schtasks` for persistent process spawning (SSH `start /B` doesn't survive session close).
|
|
||||||
|
|||||||
11
CURRENT.md
11
CURRENT.md
@@ -1,10 +1,9 @@
|
|||||||
# Current focus
|
# Current focus
|
||||||
|
|
||||||
Last updated: 2026-05-26
|
Last updated: 2026-06-02
|
||||||
|
|
||||||
- **Batch:** v2.3-provider-lifecycle (openspec drafted; not started)
|
- **Last shipped:** `v2.7.8-ember-coder-tabs-model-chips` (2026-06-01)
|
||||||
- **Branch:** `main`
|
- **Branch:** `codebase-audit-cleanup` (audit + cleanup epic, off main HEAD)
|
||||||
- **Blockers:** none
|
- **In progress:** Phase 3 — stale comments + docs refresh
|
||||||
- **Last shipped:** `v2.2.2-xml-placeholder-reject`
|
|
||||||
|
|
||||||
Update this file when starting or finishing a batch. Agents: read this first for session intent; if stale vs `CHANGELOG.md`, trust CHANGELOG for shipped state.
|
See `CHANGELOG.md` for the full shipped history. That file is always authoritative; this file is a quick orientation pointer only.
|
||||||
|
|||||||
@@ -15,7 +15,6 @@
|
|||||||
"fastify": "^4.28.1",
|
"fastify": "^4.28.1",
|
||||||
"node-pty": "^1.0.0",
|
"node-pty": "^1.0.0",
|
||||||
"pg": "^8.13.0",
|
"pg": "^8.13.0",
|
||||||
"tslib": "^2.6.3",
|
|
||||||
"zod": "^3.23.8"
|
"zod": "^3.23.8"
|
||||||
},
|
},
|
||||||
"devDependencies": {
|
"devDependencies": {
|
||||||
|
|||||||
@@ -9,7 +9,7 @@ const ConfigSchema = z.object({
|
|||||||
TMUX_CONF_PATH: z.string().default('/etc/booterm/tmux.conf'),
|
TMUX_CONF_PATH: z.string().default('/etc/booterm/tmux.conf'),
|
||||||
});
|
});
|
||||||
|
|
||||||
export type Config = z.infer<typeof ConfigSchema>;
|
type Config = z.infer<typeof ConfigSchema>;
|
||||||
|
|
||||||
let cached: Config | null = null;
|
let cached: Config | null = null;
|
||||||
|
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ export function getPool(databaseUrl: string): pg.Pool {
|
|||||||
return pool;
|
return pool;
|
||||||
}
|
}
|
||||||
|
|
||||||
export interface SessionInfo {
|
interface SessionInfo {
|
||||||
id: string;
|
id: string;
|
||||||
project_id: string;
|
project_id: string;
|
||||||
project_path: string;
|
project_path: string;
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
import * as pty from 'node-pty';
|
import * as pty from 'node-pty';
|
||||||
import type { IPty } from 'node-pty';
|
import type { IPty } from 'node-pty';
|
||||||
|
|
||||||
export interface AttachPtyOptions {
|
interface AttachPtyOptions {
|
||||||
sessionName: string;
|
sessionName: string;
|
||||||
projectRoot: string;
|
projectRoot: string;
|
||||||
cols: number;
|
cols: number;
|
||||||
|
|||||||
34
apps/coder/CLAUDE.md
Normal file
34
apps/coder/CLAUDE.md
Normal file
@@ -0,0 +1,34 @@
|
|||||||
|
# apps/coder — BooCoder (deep reference)
|
||||||
|
|
||||||
|
> Per-app engineering notes for `apps/coder/src/`. BooCoder runs as a **systemd service on the host** (`boocoder.service`), NOT in Docker — Fastify at port 9502, postgres at `127.0.0.1:5500`. Cross-cutting commands, database, environment, workflow, and cross-app contracts live in the **root `CLAUDE.md`**. This file auto-loads when you read/edit files under `apps/coder/`.
|
||||||
|
|
||||||
|
## Probe & provider discovery
|
||||||
|
|
||||||
|
- **`services/provider-registry.ts`** — Static registry of provider metadata (label, transport, model source). `PROVIDERS` array, `PROVIDERS_BY_NAME` map. 5 providers: boocode (native), opencode (acp), goose (pty), claude (pty), qwen (pty). `PROBED_AGENT_NAMES` derives from it — adding/removing providers means editing this file, not the frontend.
|
||||||
|
- **`services/agent-probe.ts`** — Startup probe via direct `exec()` (not SSH): discovers installed agents, versions, ACP support, models. Qwen models from `~/.qwen/settings.json`; Claude models static from the registry. Persisted to `available_agents`.
|
||||||
|
- **`routes/providers.ts`** — `GET /api/providers` returns installed providers with models. Transport reflects actual capability (checks `supports_acp` from DB, not just registry preference). The apps/server side is "Provider picker dispatch" (see `apps/server/CLAUDE.md`).
|
||||||
|
- **Provider snapshot lifecycle** (`services/`): `provider-config.ts` (Zod config, never-throws) → `provider-config-registry.ts` (`buildResolvedRegistry`, singleton) → `provider-snapshot.ts` (two-tier probe: tier-1 fast presence, tier-2 cold ACP probe skipped unless force / stale `PROVIDER_PROBE_TTL_MS` 24h / dbEmpty; cached). Verify live: `curl http://100.114.205.53:9502/api/providers/snapshot` — returns providers + models + commands, the exact shape `AgentComposerBar` renders.
|
||||||
|
- `PATCH /api/providers/config` replaces a provider id's override object **wholesale** (per-id shallow merge) — to flip one field send `{...existing, enabled}`, or a custom ACP entry's `command`/`label` is wiped and it drops out of the resolved registry. `data/coder-providers.json` is **gitignored** (live runtime config — the coder reads AND writes it on UI toggles); tracked reference is `data/coder-providers.example.json`. The loader falls back to `{providers:{}}` (built-ins only) when absent, so a fresh checkout needs no copy.
|
||||||
|
|
||||||
|
## Build, deploy, dispatch
|
||||||
|
|
||||||
|
- **Workspace dependency on `@boocode/server`**: imports `createInferenceRunner`, `createBroker`, `ALL_TOOLS`, `appendMcpTools` from the server's compiled `dist/`. apps/server's `package.json` has an `exports` map with `types` conditions for NodeNext resolution. **apps/server must build FIRST.**
|
||||||
|
- Build + deploy: `pnpm -C apps/server build && pnpm -C apps/coder build && sudo systemctl restart boocoder`. Env file at `apps/coder/.env.host`. Service file at `/etc/systemd/system/boocoder.service`.
|
||||||
|
- After `pnpm -C apps/coder build` the host service keeps running the OLD process until `sudo systemctl restart boocoder` — a stale process shows **new routes 404 with `{error:'not found'}` while old routes still 200** (the `/api` not-found handler shape). Restart, don't re-debug.
|
||||||
|
- `:9502/api/health` is down ~15–20s after a boocoder restart while the startup agent-probe scan runs — retry; an early connection-refused is not a failed deploy.
|
||||||
|
- Agent dispatch spawns binaries directly using `install_path` from `available_agents` — no `spawn('sh', ['-c', ...])` (fails under systemd). Paseo's pattern: `spawn(fullBinaryPath, argsArray, { cwd })`.
|
||||||
|
- systemd hardening: only `NoNewPrivileges=true` is safe. `ProtectSystem`, `ProtectHome`, `PrivateTmp` all break agent dispatch (agents need full filesystem access to read configs, write to worktrees).
|
||||||
|
- `apps/server/tsconfig.json` has `declaration: true` so `.d.ts` files exist for workspace consumers. The provider's `package.json` needs `exports` with `types` + `default` conditions per subpath (`"./inference": { "types": "./dist/.../index.d.ts", "default": "./dist/.../index.js" }`) — without the `types` condition, NodeNext can't find `.d.ts` files and tsc fails "Cannot find module" here.
|
||||||
|
- Write tools (`edit_file`, `create_file`, `delete_file`, `apply_pending`, `rewind`) queue in `pending_changes`. Nothing hits disk until `apply_pending`. `write_guard.ts` validates paths (resolve + prefix-check, no realpath since files may not exist for creates).
|
||||||
|
|
||||||
|
## Backends
|
||||||
|
|
||||||
|
> Behavioral overview + flows + data model: see [/docs/coder-backends.md](/docs/coder-backends.md). The notes below are the deep per-fact reference.
|
||||||
|
|
||||||
|
- **opencode** runs as a warm HTTP server (`services/backends/opencode-server.ts` — `opencode serve` per BooCoder process, one opencode session per BooCode session, resumed via `agent_sessions`). goose/qwen/claude dispatch **one-shot** ACP/PTY with no ctx/token usage; only native `boocode` (llama-swap) tracks ctx.
|
||||||
|
- **opencode SSE** (`opencode-server.ts`): live streaming is `session.next.text.delta` / `.reasoning.delta` / `.tool.{called,success,failed}` — NOT `message.part.*` (terminal/post-hoc). `client.event.subscribe({ directory })` MUST pass the session's worktree dir; omit it and opencode scopes events to the server `process.cwd()` → zero session events (empty turns, 180s timeout). Each live session owns its own subscribe loop + AbortController (a `sessionID` demux guard drops cross-session events when two share a dir). Turn completes on `session.idle`; `promptAsync` is fire-and-forget (204).
|
||||||
|
- **opencode model strings** must be provider-prefixed (`llama-swap/<model>`) AND exist in `~/.config/opencode/opencode.json` `provider.llama-swap.models` — not merely loadable by llama-swap. `parseModel` infers `llama-swap/` for a bare id; the dispatcher coalesces empty→DEFAULT_MODEL then prefixes. `agent-probe` populates opencode's `available_agents.models` via `mergeLlamaSwap` (fetches `/v1/models`); empty model list → frontend sends `''` → no inference (empty turn).
|
||||||
|
- **agent_sessions resume**: `config_hash = sha256('opencode_server|<model>')` — must NOT include the server port (random per boot; breaks cross-restart resume). Keyed `(chat_id, agent)` — the tab/chat is the context unit (two opencode tabs = two contexts sharing one worktree). `chat_id` CASCADEs from `chats`; `session_id`/`worktree_id` are informational `SET NULL`. The `worktrees` table (one-per-session, survives session delete) supersedes the defanged `session_worktrees`. `tasks.chat_id` threads the tab id to the dispatcher; `runOpenCodeServerTask` resolves-or-creates a chat when null. The `@opencode-ai/sdk` v2 client takes flattened params (`{sessionID, directory, parts, model:{providerID,modelID}}`), `createOpencodeClient` from `@opencode-ai/sdk/v2/client`.
|
||||||
|
- **Claude SDK backend tool RESULTS arrive as `type:'user'` SDK messages** (tool_result content blocks): `mapSdkMessage` (`claude-sdk-map.ts`) MUST map the `user` case → a terminal `tool_update` (completed/failed + output), else the tool_call persists `status:'running'` and the UI spinner never stops. The dispatcher's `tool_update` path then publishes + persists it.
|
||||||
|
- **ACP command discovery is async**: `acp-probe.ts` must poll after `newSession` for `available_commands_update` (commands arrive in a later notification; reading synchronously captures 0). PTY providers (claude) discover from disk via `claude-command-discovery.ts` (`~/.claude/commands` + `enabledPlugins`, bare names, deduped). `AgentCommand.kind` tags `'command'` vs `'skill'`; `CoderPane`'s `slashGroups` splits them into icon'd groups. `SlashCommandPicker`'s `groups?` prop is opt-in.
|
||||||
|
- **A new per-message coder field silently drops unless you update every mapper**: the HTTP read SELECT + `mapCoderMessageRow` (`apps/coder/src/routes/messages.ts`), **the WS `snapshot` SELECT (`apps/coder/src/routes/ws.ts`)** — it has its OWN column list and the client's `snapshot` handler `setMessages`-overwrites the HTTP load, so a field present in the HTTP route but absent here shows live yet vanishes on refresh — `CoderPane.tsx` (`RawCoderMessage`/`CoderMessage`/`mapCoderTimelineRow` + the live `message_complete` WS reducer), `CoderMessageWire` (`CoderMessageList.tsx`), and `api/types.ts`. The client `mapCoderTimelineRow` whitelists fields — easiest to forget. This bit `model` twice: the client chain (`v2.7.9`) and then the WS snapshot SELECT (`v2.7.11`) — the chip showed live but vanished on coder refresh until both were fixed.
|
||||||
@@ -95,7 +95,7 @@ export function registerTaskRoutes(app: FastifyInstance, sql: Sql, inference: In
|
|||||||
// GET /api/tasks/:id — single task detail
|
// GET /api/tasks/:id — single task detail
|
||||||
app.get<{ Params: { id: string } }>('/api/tasks/:id', async (req, reply) => {
|
app.get<{ Params: { id: string } }>('/api/tasks/:id', async (req, reply) => {
|
||||||
const rows = await sql`
|
const rows = await sql`
|
||||||
SELECT id, project_id, parent_task_id, state, input, output_summary, agent, model, execution_path, worktree_path, session_id, cost_tokens, started_at, ended_at, created_at
|
SELECT id, project_id, parent_task_id, state, input, output_summary, agent, model, execution_path, session_id, cost_tokens, started_at, ended_at, created_at
|
||||||
FROM tasks
|
FROM tasks
|
||||||
WHERE id = ${req.params.id}
|
WHERE id = ${req.params.id}
|
||||||
`;
|
`;
|
||||||
|
|||||||
@@ -9,7 +9,7 @@
|
|||||||
*/
|
*/
|
||||||
import type { FastifyInstance } from 'fastify';
|
import type { FastifyInstance } from 'fastify';
|
||||||
import type { Sql } from '../db.js';
|
import type { Sql } from '../db.js';
|
||||||
import { checkWorktreeWorkAtRisk, stashWorktree } from '../services/worktrees.js';
|
import { checkWorktreeWorkAtRisk, stashWorktree } from '../services/worktree-risk.js';
|
||||||
|
|
||||||
export function registerWorktreeSafetyRoutes(app: FastifyInstance, sql: Sql): void {
|
export function registerWorktreeSafetyRoutes(app: FastifyInstance, sql: Sql): void {
|
||||||
// GET risk for a session's worktree(s). One row per session today (PK on
|
// GET risk for a session's worktree(s). One row per session today (PK on
|
||||||
|
|||||||
@@ -25,7 +25,7 @@ export function registerWebSocket(
|
|||||||
|
|
||||||
// Send snapshot of existing messages so client can hydrate
|
// Send snapshot of existing messages so client can hydrate
|
||||||
const messages = await sql<Record<string, unknown>[]>`
|
const messages = await sql<Record<string, unknown>[]>`
|
||||||
SELECT id, session_id, chat_id, role, content, kind, tool_calls, tool_results, reasoning_parts, status, last_seq,
|
SELECT id, session_id, chat_id, role, content, kind, tool_calls, tool_results, reasoning_parts, status, model, last_seq,
|
||||||
tokens_used, ctx_used, ctx_max, started_at, finished_at, created_at, metadata,
|
tokens_used, ctx_used, ctx_max, started_at, finished_at, created_at, metadata,
|
||||||
summary, tail_start_id, compacted_at
|
summary, tail_start_id, compacted_at
|
||||||
FROM messages_with_parts
|
FROM messages_with_parts
|
||||||
|
|||||||
@@ -25,7 +25,6 @@ CREATE TABLE IF NOT EXISTS tasks (
|
|||||||
agent TEXT,
|
agent TEXT,
|
||||||
model TEXT,
|
model TEXT,
|
||||||
execution_path TEXT,
|
execution_path TEXT,
|
||||||
worktree_path TEXT,
|
|
||||||
cost_tokens INTEGER,
|
cost_tokens INTEGER,
|
||||||
started_at TIMESTAMPTZ,
|
started_at TIMESTAMPTZ,
|
||||||
ended_at TIMESTAMPTZ,
|
ended_at TIMESTAMPTZ,
|
||||||
@@ -39,9 +38,9 @@ CREATE TABLE IF NOT EXISTS available_agents (
|
|||||||
install_path TEXT,
|
install_path TEXT,
|
||||||
version TEXT,
|
version TEXT,
|
||||||
supports_acp BOOLEAN NOT NULL DEFAULT false,
|
supports_acp BOOLEAN NOT NULL DEFAULT false,
|
||||||
supports_mcp_client BOOLEAN NOT NULL DEFAULT false,
|
|
||||||
last_probed_at TIMESTAMPTZ
|
last_probed_at TIMESTAMPTZ
|
||||||
);
|
);
|
||||||
|
ALTER TABLE available_agents DROP COLUMN IF EXISTS supports_mcp_client;
|
||||||
|
|
||||||
-- v2.0.0 Phase 4: link tasks to their inference sessions.
|
-- v2.0.0 Phase 4: link tasks to their inference sessions.
|
||||||
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS session_id UUID REFERENCES sessions(id);
|
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS session_id UUID REFERENCES sessions(id);
|
||||||
@@ -74,31 +73,10 @@ ALTER TABLE available_agents ADD COLUMN IF NOT EXISTS commands JSONB DEFAULT '[]
|
|||||||
-- v2.2.0: Paseo-style session config on tasks.
|
-- v2.2.0: Paseo-style session config on tasks.
|
||||||
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS mode_id TEXT;
|
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS mode_id TEXT;
|
||||||
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS thinking_option_id TEXT;
|
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS thinking_option_id TEXT;
|
||||||
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS feature_values JSONB;
|
-- tasks.feature_values and tasks.worktree_path were never read or written by any
|
||||||
|
-- code path; drop them from existing DBs (fresh DBs never had them in the CREATE).
|
||||||
-- v2.6: one shared worktree per session (all agents/panes in the session operate in it).
|
ALTER TABLE tasks DROP COLUMN IF EXISTS feature_values;
|
||||||
CREATE TABLE IF NOT EXISTS session_worktrees (
|
ALTER TABLE tasks DROP COLUMN IF EXISTS worktree_path;
|
||||||
session_id UUID PRIMARY KEY REFERENCES sessions(id) ON DELETE CASCADE,
|
|
||||||
worktree_path TEXT NOT NULL,
|
|
||||||
base_commit TEXT,
|
|
||||||
created_at TIMESTAMPTZ NOT NULL DEFAULT clock_timestamp()
|
|
||||||
);
|
|
||||||
-- P1.5-b: DEFANG the CASCADE — a session delete must no longer wipe its worktree
|
|
||||||
-- row. This table is SUPERSEDED by `worktrees` below; all readers are repointed
|
|
||||||
-- this phase, so the row just persists (dead) on session delete until a later
|
|
||||||
-- cleanup drops the table. session_id is this table's PRIMARY KEY, so it cannot be
|
|
||||||
-- nullable → SET NULL is invalid and NO ACTION/RESTRICT would block deletes; the
|
|
||||||
-- only valid defang is to drop the FK with no replacement. Idempotent: only fires
|
|
||||||
-- while the FK is still ON DELETE CASCADE ('c').
|
|
||||||
DO $$ BEGIN
|
|
||||||
IF EXISTS (
|
|
||||||
SELECT 1 FROM pg_constraint
|
|
||||||
WHERE conname = 'session_worktrees_session_id_fkey'
|
|
||||||
AND confdeltype = 'c'
|
|
||||||
) THEN
|
|
||||||
ALTER TABLE session_worktrees DROP CONSTRAINT session_worktrees_session_id_fkey;
|
|
||||||
END IF;
|
|
||||||
END $$;
|
|
||||||
|
|
||||||
-- v2.6: one backend session per (session, agent); resumed on switch-back.
|
-- v2.6: one backend session per (session, agent); resumed on switch-back.
|
||||||
CREATE TABLE IF NOT EXISTS agent_sessions (
|
CREATE TABLE IF NOT EXISTS agent_sessions (
|
||||||
@@ -168,12 +146,9 @@ CREATE TABLE IF NOT EXISTS worktrees (
|
|||||||
);
|
);
|
||||||
CREATE UNIQUE INDEX IF NOT EXISTS worktrees_active_path_uidx ON worktrees(path) WHERE status='active';
|
CREATE UNIQUE INDEX IF NOT EXISTS worktrees_active_path_uidx ON worktrees(path) WHERE status='active';
|
||||||
|
|
||||||
-- Migrate any surviving session_worktrees rows → worktrees (idempotent; 0 rows
|
-- session_worktrees was superseded by worktrees (v2.6/P1.5-b); all rows migrated
|
||||||
-- after the test-session delete, kept for generality / fresh-DB safety).
|
-- before P2 cleanup. Drop the dead table; no-op on fresh DBs that never had it.
|
||||||
INSERT INTO worktrees (session_id, path, branch, base_commit, status)
|
DROP TABLE IF EXISTS session_worktrees;
|
||||||
SELECT sw.session_id, sw.worktree_path, 'session-' || sw.session_id, sw.base_commit, 'active'
|
|
||||||
FROM session_worktrees sw
|
|
||||||
WHERE NOT EXISTS (SELECT 1 FROM worktrees w WHERE w.session_id = sw.session_id AND w.status='active');
|
|
||||||
|
|
||||||
-- Dispatch hint: which chat (tab) a task belongs to. The coder message route and
|
-- Dispatch hint: which chat (tab) a task belongs to. The coder message route and
|
||||||
-- skills route set it from the frontend tab; session-less creators (arena, MCP,
|
-- skills route set it from the frontend tab; session-less creators (arena, MCP,
|
||||||
|
|||||||
74
apps/coder/src/services/__tests__/acp-client.test.ts
Normal file
74
apps/coder/src/services/__tests__/acp-client.test.ts
Normal file
@@ -0,0 +1,74 @@
|
|||||||
|
import { describe, it, expect, vi } from 'vitest';
|
||||||
|
import type { RequestPermissionRequest, CreateElicitationRequest, SessionNotification } from '@agentclientprotocol/sdk';
|
||||||
|
import { buildAcpClient, type AcpTurnContext } from '../acp-client.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* buildAcpClient (v2.7 audit reshape): the shared ACP `Client` closures. These
|
||||||
|
* tests cover the pure routing decisions that don't require the permission-waiter
|
||||||
|
* broker machinery — the auto-select/decline fallbacks and the between-turns drop.
|
||||||
|
*/
|
||||||
|
|
||||||
|
describe('buildAcpClient — sessionUpdate', () => {
|
||||||
|
it('drops the update when no turn is active (resolveTurn → null)', async () => {
|
||||||
|
const client = buildAcpClient('/wt', () => null);
|
||||||
|
// Must resolve without throwing and without an onSessionUpdate to call.
|
||||||
|
await expect(client.sessionUpdate({ sessionId: 's', update: {} } as unknown as SessionNotification)).resolves.toBeUndefined();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('forwards the update to the active turn', async () => {
|
||||||
|
const onSessionUpdate = vi.fn();
|
||||||
|
const turn: AcpTurnContext = { taskId: 't', sessionId: 's', modeId: undefined, agent: 'goose', onSessionUpdate };
|
||||||
|
const client = buildAcpClient('/wt', () => turn);
|
||||||
|
const note = { sessionId: 's', update: {} } as unknown as SessionNotification;
|
||||||
|
await client.sessionUpdate(note);
|
||||||
|
expect(onSessionUpdate).toHaveBeenCalledWith(note);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('buildAcpClient — requestPermission fallback (no UI routing)', () => {
|
||||||
|
function req(options: Array<{ optionId: string }>): RequestPermissionRequest {
|
||||||
|
return { options } as unknown as RequestPermissionRequest;
|
||||||
|
}
|
||||||
|
|
||||||
|
it('auto-selects the first option when there is no turn', async () => {
|
||||||
|
const client = buildAcpClient('/wt', () => null);
|
||||||
|
const res = await client.requestPermission(req([{ optionId: 'allow' }, { optionId: 'deny' }]));
|
||||||
|
expect(res).toEqual({ outcome: { outcome: 'selected', optionId: 'allow' } });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('cancels when there is no turn and no options', async () => {
|
||||||
|
const client = buildAcpClient('/wt', () => null);
|
||||||
|
const res = await client.requestPermission(req([]));
|
||||||
|
expect(res).toEqual({ outcome: { outcome: 'cancelled' } });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('auto-selects when the turn has no taskId (UI routing gated off)', async () => {
|
||||||
|
const turn: AcpTurnContext = { taskId: undefined, sessionId: 's', modeId: undefined, agent: 'goose', onSessionUpdate: () => {} };
|
||||||
|
const client = buildAcpClient('/wt', () => turn);
|
||||||
|
const res = await client.requestPermission(req([{ optionId: 'ok' }]));
|
||||||
|
expect(res).toEqual({ outcome: { outcome: 'selected', optionId: 'ok' } });
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('buildAcpClient — elicitation fallback', () => {
|
||||||
|
it('declines when there is no turn', async () => {
|
||||||
|
const client = buildAcpClient('/wt', () => null);
|
||||||
|
const res = await client.unstable_createElicitation!({} as CreateElicitationRequest);
|
||||||
|
expect(res).toEqual({ action: 'decline' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('declines when the turn has no taskId', async () => {
|
||||||
|
const turn: AcpTurnContext = { taskId: undefined, sessionId: 's', modeId: undefined, agent: 'goose', onSessionUpdate: () => {} };
|
||||||
|
const client = buildAcpClient('/wt', () => turn);
|
||||||
|
const res = await client.unstable_createElicitation!({} as CreateElicitationRequest);
|
||||||
|
expect(res).toEqual({ action: 'decline' });
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('buildAcpClient — createTerminal', () => {
|
||||||
|
it('returns the noop terminal id', async () => {
|
||||||
|
const client = buildAcpClient('/wt', () => null);
|
||||||
|
const res = await client.createTerminal!({} as never);
|
||||||
|
expect(res).toEqual({ terminalId: 'noop' });
|
||||||
|
});
|
||||||
|
});
|
||||||
102
apps/coder/src/services/__tests__/frame-emitter.test.ts
Normal file
102
apps/coder/src/services/__tests__/frame-emitter.test.ts
Normal file
@@ -0,0 +1,102 @@
|
|||||||
|
import { describe, it, expect } from 'vitest';
|
||||||
|
import type { Broker } from '@boocode/server/broker';
|
||||||
|
import { makeFrameEmitter } from '../frame-emitter.js';
|
||||||
|
import { makeDcpStreamStripper } from '../dcp-strip.js';
|
||||||
|
import type { AcpToolSnapshot } from '../acp-tool-snapshot.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* makeFrameEmitter (v2.7 audit reshape): the AgentEvent → WS-frame mapping + turn
|
||||||
|
* accumulators extracted from AcpStreamContext. Pure-ish over an injected broker.
|
||||||
|
*/
|
||||||
|
|
||||||
|
function fakeBroker(): { broker: Broker; frames: Array<{ sid: string; frame: Record<string, unknown> }> } {
|
||||||
|
const frames: Array<{ sid: string; frame: Record<string, unknown> }> = [];
|
||||||
|
const broker = {
|
||||||
|
publishFrame: (sid: string, frame: unknown) => {
|
||||||
|
frames.push({ sid, frame: frame as Record<string, unknown> });
|
||||||
|
},
|
||||||
|
} as unknown as Broker;
|
||||||
|
return { broker, frames };
|
||||||
|
}
|
||||||
|
|
||||||
|
const toolSnap: AcpToolSnapshot = { toolCallId: 'c1', title: 'grep', status: 'completed', rawOutput: 'x' };
|
||||||
|
|
||||||
|
describe('makeFrameEmitter — streaming frames', () => {
|
||||||
|
it('maps text/reasoning/tool events to delta/reasoning_delta/tool_call frames', () => {
|
||||||
|
const { broker, frames } = fakeBroker();
|
||||||
|
const em = makeFrameEmitter({ broker, sessionId: 's1', chatId: 'ch1', assistantId: 'm1' });
|
||||||
|
|
||||||
|
em.onEvent({ type: 'text', text: 'hello ' });
|
||||||
|
em.onEvent({ type: 'reasoning', text: 'mulling' });
|
||||||
|
em.onEvent({ type: 'tool_call', toolCall: toolSnap });
|
||||||
|
|
||||||
|
expect(frames.map((f) => f.frame.type)).toEqual(['delta', 'reasoning_delta', 'tool_call']);
|
||||||
|
expect(frames[0]!.frame).toMatchObject({ message_id: 'm1', chat_id: 'ch1', content: 'hello ' });
|
||||||
|
expect(frames[2]!.frame).toMatchObject({ message_id: 'm1', chat_id: 'ch1' });
|
||||||
|
expect(em.output).toBe('hello ');
|
||||||
|
expect(em.reasoningText).toBe('mulling');
|
||||||
|
expect(em.snapshots).toHaveLength(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('publishes a tool_call frame for BOTH tool_call and tool_update events', () => {
|
||||||
|
const { broker, frames } = fakeBroker();
|
||||||
|
const em = makeFrameEmitter({ broker, sessionId: 's1', chatId: 'ch1', assistantId: 'm1' });
|
||||||
|
em.onEvent({ type: 'tool_update', toolCall: toolSnap });
|
||||||
|
expect(frames).toHaveLength(1);
|
||||||
|
expect(frames[0]!.frame.type).toBe('tool_call');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('publishes an agent_commands frame and merges the command cache', () => {
|
||||||
|
const { broker, frames } = fakeBroker();
|
||||||
|
const taskId = `task-fe-${Math.floor(performance.now())}-${frames.length}`;
|
||||||
|
const em = makeFrameEmitter({ broker, sessionId: 's1', chatId: 'ch1', assistantId: 'm1', taskId });
|
||||||
|
em.onEvent({ type: 'commands', commands: [{ name: 'plan' }] });
|
||||||
|
expect(frames).toHaveLength(1);
|
||||||
|
expect(frames[0]!.frame).toMatchObject({ type: 'agent_commands', task_id: taskId, session_id: 's1' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not publish a commands frame without a taskId', () => {
|
||||||
|
const { broker, frames } = fakeBroker();
|
||||||
|
const em = makeFrameEmitter({ broker, sessionId: 's1', chatId: 'ch1', assistantId: 'm1' });
|
||||||
|
em.onEvent({ type: 'commands', commands: [{ name: 'plan' }] });
|
||||||
|
expect(frames).toHaveLength(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('makeFrameEmitter — no broker (one-shot accumulation)', () => {
|
||||||
|
it('accumulates output/reasoning/snapshots but publishes nothing', () => {
|
||||||
|
const em = makeFrameEmitter({ sessionId: 's1', chatId: 'ch1', assistantId: 'm1' });
|
||||||
|
em.onEvent({ type: 'text', text: 'abc' });
|
||||||
|
em.onEvent({ type: 'reasoning', text: 'r' });
|
||||||
|
em.onEvent({ type: 'tool_call', toolCall: toolSnap });
|
||||||
|
expect(em.output).toBe('abc');
|
||||||
|
expect(em.reasoningText).toBe('r');
|
||||||
|
expect(em.snapshots).toHaveLength(1);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('makeFrameEmitter — dcp stripping (opencode path contract)', () => {
|
||||||
|
it('strips a split dcp tag across deltas and flushes the tail on finalize', () => {
|
||||||
|
const { broker, frames } = fakeBroker();
|
||||||
|
const em = makeFrameEmitter({ broker, sessionId: 's1', chatId: 'ch1', assistantId: 'm1', dcp: makeDcpStreamStripper() });
|
||||||
|
|
||||||
|
for (const chunk of ['Answer.', '<dcp', '-message', '-id>m1</dcp', '-message-id>', ' tail']) {
|
||||||
|
em.onEvent({ type: 'text', text: chunk });
|
||||||
|
}
|
||||||
|
em.finalize();
|
||||||
|
|
||||||
|
expect(em.output).toBe('Answer. tail');
|
||||||
|
const published = frames.filter((f) => f.frame.type === 'delta').map((f) => f.frame.content).join('');
|
||||||
|
expect(published).toBe('Answer. tail');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('finalize is a no-op without a dcp stripper', () => {
|
||||||
|
const { broker, frames } = fakeBroker();
|
||||||
|
const em = makeFrameEmitter({ broker, sessionId: 's1', chatId: 'ch1', assistantId: 'm1' });
|
||||||
|
em.onEvent({ type: 'text', text: 'raw <dcp-message-id>m</dcp-message-id>' });
|
||||||
|
em.finalize();
|
||||||
|
// No stripping without a stripper — verbatim text (prior ACP-path behavior).
|
||||||
|
expect(em.output).toBe('raw <dcp-message-id>m</dcp-message-id>');
|
||||||
|
expect(frames).toHaveLength(1);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,83 +0,0 @@
|
|||||||
import { describe, it, expect } from 'vitest';
|
|
||||||
import { normalizeAgentEvent } from '../normalize-agent-status.js';
|
|
||||||
|
|
||||||
describe('normalizeAgentEvent', () => {
|
|
||||||
describe('working bucket', () => {
|
|
||||||
const cases = [
|
|
||||||
'SessionStart',
|
|
||||||
'UserPromptSubmit',
|
|
||||||
'UserPromptSubmitted',
|
|
||||||
'PostToolUse',
|
|
||||||
'PostToolUseFailure',
|
|
||||||
'BeforeAgent',
|
|
||||||
'AfterTool',
|
|
||||||
'task_started',
|
|
||||||
];
|
|
||||||
for (const name of cases) {
|
|
||||||
it(`maps ${name} → working`, () => {
|
|
||||||
expect(normalizeAgentEvent(name)).toBe('working');
|
|
||||||
});
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('blocked bucket', () => {
|
|
||||||
const cases = [
|
|
||||||
'PreToolUse',
|
|
||||||
'Notification',
|
|
||||||
'PermissionRequest',
|
|
||||||
'exec_approval_request',
|
|
||||||
'apply_patch_approval_request',
|
|
||||||
'request_user_input',
|
|
||||||
];
|
|
||||||
for (const name of cases) {
|
|
||||||
it(`maps ${name} → blocked`, () => {
|
|
||||||
expect(normalizeAgentEvent(name)).toBe('blocked');
|
|
||||||
});
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('done bucket', () => {
|
|
||||||
const cases = [
|
|
||||||
'Stop',
|
|
||||||
'AfterAgent',
|
|
||||||
'SessionEnd',
|
|
||||||
'task_complete',
|
|
||||||
'agent-turn-complete',
|
|
||||||
];
|
|
||||||
for (const name of cases) {
|
|
||||||
it(`maps ${name} → done`, () => {
|
|
||||||
expect(normalizeAgentEvent(name)).toBe('done');
|
|
||||||
});
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('unknown / nullish → null', () => {
|
|
||||||
it('returns null for an unrecognized event', () => {
|
|
||||||
expect(normalizeAgentEvent('SomeRandomEvent')).toBeNull();
|
|
||||||
});
|
|
||||||
it('returns null for empty string', () => {
|
|
||||||
expect(normalizeAgentEvent('')).toBeNull();
|
|
||||||
});
|
|
||||||
it('returns null for undefined', () => {
|
|
||||||
expect(normalizeAgentEvent(undefined)).toBeNull();
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('case- and separator-insensitive matching', () => {
|
|
||||||
it('matches snake_case spelling of a PascalCase event', () => {
|
|
||||||
expect(normalizeAgentEvent('session_start')).toBe('working');
|
|
||||||
expect(normalizeAgentEvent('post_tool_use')).toBe('working');
|
|
||||||
expect(normalizeAgentEvent('pre_tool_use')).toBe('blocked');
|
|
||||||
});
|
|
||||||
it('matches camelCase spelling', () => {
|
|
||||||
expect(normalizeAgentEvent('userPromptSubmitted')).toBe('working');
|
|
||||||
expect(normalizeAgentEvent('postToolUse')).toBe('working');
|
|
||||||
expect(normalizeAgentEvent('preToolUse')).toBe('blocked');
|
|
||||||
expect(normalizeAgentEvent('sessionEnd')).toBe('done');
|
|
||||||
});
|
|
||||||
it('matches arbitrary case', () => {
|
|
||||||
expect(normalizeAgentEvent('STOP')).toBe('done');
|
|
||||||
expect(normalizeAgentEvent('notification')).toBe('blocked');
|
|
||||||
});
|
|
||||||
});
|
|
||||||
});
|
|
||||||
88
apps/coder/src/services/acp-client.ts
Normal file
88
apps/coder/src/services/acp-client.ts
Normal file
@@ -0,0 +1,88 @@
|
|||||||
|
/**
|
||||||
|
* Shared ACP `Client` builder — the callback closures every ACP connection needs
|
||||||
|
* (worktree-scoped FS bridge + permission/elicitation routing + session updates).
|
||||||
|
*
|
||||||
|
* Extracted (v2.7 audit reshape) from the byte-identical `buildClient` closures in
|
||||||
|
* `acp-dispatch.ts` (one-shot) and `backends/warm-acp.ts` (warm). The two differed
|
||||||
|
* only in WHERE the per-turn context comes from (a fixed dispatch vs. the warm
|
||||||
|
* backend's `activeTurn`) and a trivially-equivalent permission gate — both are now
|
||||||
|
* supplied via the `resolveTurn` callback, so the FS/permission/elicitation wiring
|
||||||
|
* lives once. Behavior is preserved exactly:
|
||||||
|
* - `sessionUpdate` drops when `resolveTurn()` returns null (between turns).
|
||||||
|
* - permission/elicitation route to the UI only when BOTH a taskId AND sessionId
|
||||||
|
* are present (warm always has a sessionId, so this matches its prior
|
||||||
|
* `turn?.taskId` gate); otherwise the same auto-select-first / decline fallback.
|
||||||
|
*/
|
||||||
|
import type {
|
||||||
|
Client,
|
||||||
|
SessionNotification,
|
||||||
|
RequestPermissionRequest,
|
||||||
|
RequestPermissionResponse,
|
||||||
|
ReadTextFileRequest,
|
||||||
|
ReadTextFileResponse,
|
||||||
|
WriteTextFileRequest,
|
||||||
|
WriteTextFileResponse,
|
||||||
|
CreateTerminalRequest,
|
||||||
|
CreateTerminalResponse,
|
||||||
|
CreateElicitationRequest,
|
||||||
|
CreateElicitationResponse,
|
||||||
|
} from '@agentclientprotocol/sdk';
|
||||||
|
import { readWorktreeTextFile, writeWorktreeTextFile } from './acp-client-fs.js';
|
||||||
|
import { waitForPermissionResponse, waitForElicitationResponse } from './permission-waiter.js';
|
||||||
|
|
||||||
|
/** The per-turn context an ACP `Client` closure needs, resolved lazily per call. */
|
||||||
|
export interface AcpTurnContext {
|
||||||
|
/** Per-turn task id, for routing permission/elicitation prompts back to the UI. */
|
||||||
|
taskId: string | undefined;
|
||||||
|
/** BooCode session id (for permission-waiter's broker frames). */
|
||||||
|
sessionId: string | undefined;
|
||||||
|
/** Per-turn mode id (autonomous-mode gate in permission-waiter). */
|
||||||
|
modeId: string | undefined;
|
||||||
|
/** The agent name (for permission-waiter routing). */
|
||||||
|
agent: string;
|
||||||
|
/** Forward a session/update notification to the turn's event sink. */
|
||||||
|
onSessionUpdate: (params: SessionNotification) => void | Promise<void>;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Build the ACP `Client` callbacks once per connection. `resolveTurn` is called at
|
||||||
|
* the moment each callback fires and returns the live turn context (or null when no
|
||||||
|
* turn is active — `sessionUpdate` then drops, matching the warm backend's
|
||||||
|
* between-turns behavior). The FS bridge is scoped to `worktreePath`.
|
||||||
|
*/
|
||||||
|
export function buildAcpClient(worktreePath: string, resolveTurn: () => AcpTurnContext | null): Client {
|
||||||
|
return {
|
||||||
|
sessionUpdate: async (params: SessionNotification): Promise<void> => {
|
||||||
|
const turn = resolveTurn();
|
||||||
|
if (!turn) return; // between turns — drop (no orphan settles a future turn)
|
||||||
|
await turn.onSessionUpdate(params);
|
||||||
|
},
|
||||||
|
requestPermission: async (params: RequestPermissionRequest): Promise<RequestPermissionResponse> => {
|
||||||
|
const turn = resolveTurn();
|
||||||
|
if (turn && turn.taskId && turn.sessionId) {
|
||||||
|
return waitForPermissionResponse(turn.taskId, turn.sessionId, turn.agent, turn.modeId, params);
|
||||||
|
}
|
||||||
|
const firstOption = params.options[0];
|
||||||
|
if (firstOption) return { outcome: { outcome: 'selected', optionId: firstOption.optionId } };
|
||||||
|
return { outcome: { outcome: 'cancelled' } };
|
||||||
|
},
|
||||||
|
readTextFile: async (params: ReadTextFileRequest): Promise<ReadTextFileResponse> => {
|
||||||
|
const content = await readWorktreeTextFile(worktreePath, params.path, params.line, params.limit);
|
||||||
|
return { content };
|
||||||
|
},
|
||||||
|
writeTextFile: async (params: WriteTextFileRequest): Promise<WriteTextFileResponse> => {
|
||||||
|
await writeWorktreeTextFile(worktreePath, params.path, params.content);
|
||||||
|
return {};
|
||||||
|
},
|
||||||
|
createTerminal: async (_params: CreateTerminalRequest): Promise<CreateTerminalResponse> => {
|
||||||
|
return { terminalId: 'noop' };
|
||||||
|
},
|
||||||
|
unstable_createElicitation: async (params: CreateElicitationRequest): Promise<CreateElicitationResponse> => {
|
||||||
|
const turn = resolveTurn();
|
||||||
|
if (turn && turn.taskId && turn.sessionId) {
|
||||||
|
return waitForElicitationResponse(turn.taskId, turn.sessionId, turn.agent, turn.modeId, params);
|
||||||
|
}
|
||||||
|
return { action: 'decline' };
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -9,35 +9,20 @@ import {
|
|||||||
ClientSideConnection,
|
ClientSideConnection,
|
||||||
type Client,
|
type Client,
|
||||||
type SessionNotification,
|
type SessionNotification,
|
||||||
type RequestPermissionRequest,
|
|
||||||
type RequestPermissionResponse,
|
|
||||||
type ReadTextFileRequest,
|
|
||||||
type ReadTextFileResponse,
|
|
||||||
type WriteTextFileRequest,
|
|
||||||
type WriteTextFileResponse,
|
|
||||||
type CreateTerminalRequest,
|
|
||||||
type CreateTerminalResponse,
|
|
||||||
type CreateElicitationRequest,
|
|
||||||
type CreateElicitationResponse,
|
|
||||||
type SessionConfigOption,
|
type SessionConfigOption,
|
||||||
type ClientSideConnection as ConnectionType,
|
type ClientSideConnection as ConnectionType,
|
||||||
} from '@agentclientprotocol/sdk';
|
} from '@agentclientprotocol/sdk';
|
||||||
import type { Broker } from '@boocode/server/broker';
|
import type { Broker } from '@boocode/server/broker';
|
||||||
import type { WsFrame } from '@boocode/server/ws-frames';
|
|
||||||
import { spawn } from 'node:child_process';
|
import { spawn } from 'node:child_process';
|
||||||
import { findThoughtLevelConfigId } from './acp-derive.js';
|
import { findThoughtLevelConfigId } from './acp-derive.js';
|
||||||
import { resolveLaunchSpec } from './acp-spawn.js';
|
import { resolveLaunchSpec } from './acp-spawn.js';
|
||||||
import { getResolvedRegistry, type ResolvedProviderDef } from './provider-config-registry.js';
|
import { getResolvedRegistry, type ResolvedProviderDef } from './provider-config-registry.js';
|
||||||
import { createAcpNdJsonStream } from './acp-stream.js';
|
import { createAcpNdJsonStream } from './acp-stream.js';
|
||||||
import { waitForPermissionResponse, waitForElicitationResponse, cancelPendingPermission } from './permission-waiter.js';
|
import { cancelPendingPermission } from './permission-waiter.js';
|
||||||
import { mergeTaskCommands, getTaskCommands } from './agent-commands-cache.js';
|
|
||||||
import { readWorktreeTextFile, writeWorktreeTextFile } from './acp-client-fs.js';
|
|
||||||
import { mapSessionUpdate } from './acp-event-map.js';
|
import { mapSessionUpdate } from './acp-event-map.js';
|
||||||
import {
|
import { type AcpToolSnapshot, synthesizeCanceledSnapshots } from './acp-tool-snapshot.js';
|
||||||
type AcpToolSnapshot,
|
import { makeFrameEmitter, type FrameEmitter } from './frame-emitter.js';
|
||||||
snapshotToWireToolCall,
|
import { buildAcpClient } from './acp-client.js';
|
||||||
synthesizeCanceledSnapshots,
|
|
||||||
} from './acp-tool-snapshot.js';
|
|
||||||
|
|
||||||
export interface AcpDispatchResult {
|
export interface AcpDispatchResult {
|
||||||
exitCode: number;
|
exitCode: number;
|
||||||
@@ -111,144 +96,61 @@ async function applySessionOverrides(
|
|||||||
}
|
}
|
||||||
|
|
||||||
class AcpStreamContext {
|
class AcpStreamContext {
|
||||||
readonly textChunks: string[] = [];
|
/** AgentEvent → WS-frame mapping + text/reasoning/tool accumulation (shared
|
||||||
readonly reasoningChunks: string[] = [];
|
* `makeFrameEmitter`). The one-shot path passes no `dcp` stripper, so text is
|
||||||
readonly toolSnapshots = new Map<string, AcpToolSnapshot>();
|
* emitted verbatim — byte-identical to the prior inline switch. */
|
||||||
private aborted = false;
|
private readonly emitter: FrameEmitter;
|
||||||
|
|
||||||
constructor(
|
constructor(
|
||||||
private readonly opts: Pick<
|
opts: Pick<AcpDispatchOpts, 'broker' | 'sessionId' | 'chatId' | 'messageId' | 'taskId'>,
|
||||||
AcpDispatchOpts,
|
|
||||||
'broker' | 'sessionId' | 'chatId' | 'messageId' | 'taskId'
|
|
||||||
>,
|
|
||||||
private readonly worktreePath: string,
|
private readonly worktreePath: string,
|
||||||
) {}
|
) {
|
||||||
|
this.emitter = makeFrameEmitter({
|
||||||
|
broker: opts.broker,
|
||||||
|
sessionId: opts.sessionId,
|
||||||
|
chatId: opts.chatId,
|
||||||
|
assistantId: opts.messageId,
|
||||||
|
taskId: opts.taskId,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
get reasoningText(): string {
|
get reasoningText(): string {
|
||||||
return this.reasoningChunks.join('');
|
return this.emitter.reasoningText;
|
||||||
}
|
}
|
||||||
|
|
||||||
get output(): string {
|
get output(): string {
|
||||||
return this.textChunks.join('');
|
return this.emitter.output;
|
||||||
}
|
}
|
||||||
|
|
||||||
get snapshots(): AcpToolSnapshot[] {
|
get snapshots(): AcpToolSnapshot[] {
|
||||||
return [...this.toolSnapshots.values()];
|
return this.emitter.snapshots;
|
||||||
}
|
}
|
||||||
|
|
||||||
markAborted(): void {
|
markAborted(): void {
|
||||||
this.aborted = true;
|
// Synthesize 'canceled' updates for still-running tool calls so the UI doesn't
|
||||||
for (const snap of synthesizeCanceledSnapshots(this.toolSnapshots.values())) {
|
// leave them spinning, then emit them through the same frame path (tool_update
|
||||||
this.toolSnapshots.set(snap.toolCallId, snap);
|
// → the same `tool_call` wire frame the original published).
|
||||||
this.publishToolSnapshot(snap);
|
for (const snap of synthesizeCanceledSnapshots(this.emitter.toolSnapshots.values())) {
|
||||||
|
this.emitter.onEvent({ type: 'tool_update', toolCall: snap });
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private canStream(): boolean {
|
handleSessionUpdate(params: SessionNotification): void {
|
||||||
return !!(this.opts.broker && this.opts.sessionId && this.opts.chatId && this.opts.messageId);
|
// The merge accumulator (`this.emitter.toolSnapshots`) is the same Map the
|
||||||
}
|
// emitter publishes from, so a later tool_call_update merges over its tool_call.
|
||||||
|
for (const event of mapSessionUpdate(params, this.emitter.toolSnapshots)) {
|
||||||
private publishToolSnapshot(snapshot: AcpToolSnapshot): void {
|
this.emitter.onEvent(event);
|
||||||
if (!this.canStream()) return;
|
|
||||||
const wire = snapshotToWireToolCall(snapshot);
|
|
||||||
this.opts.broker!.publishFrame(this.opts.sessionId!, {
|
|
||||||
type: 'tool_call',
|
|
||||||
message_id: this.opts.messageId!,
|
|
||||||
chat_id: this.opts.chatId!,
|
|
||||||
tool_call: wire,
|
|
||||||
} as WsFrame);
|
|
||||||
}
|
|
||||||
|
|
||||||
async handleSessionUpdate(params: SessionNotification): Promise<void> {
|
|
||||||
// v2.6 Phase 2: the case-by-case mapping now lives in the shared, pure
|
|
||||||
// `mapSessionUpdate` (reused by the warm ACP backend). This method keeps the
|
|
||||||
// identical broker-publishing side effects — it just translates the normalized
|
|
||||||
// AgentEvents back into the same frames it always emitted. `this.toolSnapshots`
|
|
||||||
// is the merge accumulator, so a later tool_call_update merges over its
|
|
||||||
// tool_call (the prior `handleToolUpdate` behavior, byte-for-byte).
|
|
||||||
for (const event of mapSessionUpdate(params, this.toolSnapshots)) {
|
|
||||||
switch (event.type) {
|
|
||||||
case 'text':
|
|
||||||
this.textChunks.push(event.text);
|
|
||||||
if (this.canStream()) {
|
|
||||||
this.opts.broker!.publishFrame(this.opts.sessionId!, {
|
|
||||||
type: 'delta',
|
|
||||||
message_id: this.opts.messageId!,
|
|
||||||
chat_id: this.opts.chatId!,
|
|
||||||
content: event.text,
|
|
||||||
} as WsFrame);
|
|
||||||
}
|
|
||||||
break;
|
|
||||||
case 'reasoning':
|
|
||||||
this.reasoningChunks.push(event.text);
|
|
||||||
if (this.canStream()) {
|
|
||||||
this.opts.broker!.publishFrame(this.opts.sessionId!, {
|
|
||||||
type: 'reasoning_delta',
|
|
||||||
message_id: this.opts.messageId!,
|
|
||||||
chat_id: this.opts.chatId!,
|
|
||||||
content: event.text,
|
|
||||||
} as WsFrame);
|
|
||||||
}
|
|
||||||
break;
|
|
||||||
case 'tool_call':
|
|
||||||
case 'tool_update':
|
|
||||||
// mapSessionUpdate already stored the merged snapshot in this.toolSnapshots.
|
|
||||||
this.publishToolSnapshot(event.toolCall);
|
|
||||||
break;
|
|
||||||
case 'commands':
|
|
||||||
if (this.opts.taskId && event.commands.length > 0) {
|
|
||||||
mergeTaskCommands(this.opts.taskId, event.commands);
|
|
||||||
if (this.canStream() && this.opts.sessionId) {
|
|
||||||
const all = getTaskCommands(this.opts.taskId) ?? event.commands;
|
|
||||||
this.opts.broker!.publishFrame(this.opts.sessionId, {
|
|
||||||
type: 'agent_commands',
|
|
||||||
task_id: this.opts.taskId,
|
|
||||||
session_id: this.opts.sessionId,
|
|
||||||
commands: all,
|
|
||||||
} as WsFrame);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
buildClient(agent: string, modeId: string | undefined, taskId: string | undefined, sessionId: string | undefined): Client {
|
buildClient(agent: string, modeId: string | undefined, taskId: string | undefined, sessionId: string | undefined): Client {
|
||||||
return {
|
return buildAcpClient(this.worktreePath, () => ({
|
||||||
sessionUpdate: (params) => this.handleSessionUpdate(params),
|
taskId,
|
||||||
requestPermission: async (params: RequestPermissionRequest): Promise<RequestPermissionResponse> => {
|
sessionId,
|
||||||
if (taskId && sessionId) {
|
modeId,
|
||||||
return waitForPermissionResponse(taskId, sessionId, agent, modeId, params);
|
agent,
|
||||||
}
|
onSessionUpdate: (params) => this.handleSessionUpdate(params),
|
||||||
const firstOption = params.options[0];
|
}));
|
||||||
if (firstOption) {
|
|
||||||
return { outcome: { outcome: 'selected', optionId: firstOption.optionId } };
|
|
||||||
}
|
|
||||||
return { outcome: { outcome: 'cancelled' } };
|
|
||||||
},
|
|
||||||
readTextFile: async (params: ReadTextFileRequest): Promise<ReadTextFileResponse> => {
|
|
||||||
const content = await readWorktreeTextFile(
|
|
||||||
this.worktreePath,
|
|
||||||
params.path,
|
|
||||||
params.line,
|
|
||||||
params.limit,
|
|
||||||
);
|
|
||||||
return { content };
|
|
||||||
},
|
|
||||||
writeTextFile: async (params: WriteTextFileRequest): Promise<WriteTextFileResponse> => {
|
|
||||||
await writeWorktreeTextFile(this.worktreePath, params.path, params.content);
|
|
||||||
return {};
|
|
||||||
},
|
|
||||||
createTerminal: async (_params: CreateTerminalRequest): Promise<CreateTerminalResponse> => {
|
|
||||||
return { terminalId: 'noop' };
|
|
||||||
},
|
|
||||||
unstable_createElicitation: async (params: CreateElicitationRequest): Promise<CreateElicitationResponse> => {
|
|
||||||
if (taskId && sessionId) {
|
|
||||||
return waitForElicitationResponse(taskId, sessionId, agent, modeId, params);
|
|
||||||
}
|
|
||||||
return { action: 'decline' };
|
|
||||||
},
|
|
||||||
};
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ import { Readable, Writable } from 'node:stream';
|
|||||||
import type { ChildProcess } from 'node:child_process';
|
import type { ChildProcess } from 'node:child_process';
|
||||||
import { ndJsonStream } from '@agentclientprotocol/sdk';
|
import { ndJsonStream } from '@agentclientprotocol/sdk';
|
||||||
|
|
||||||
export function nodeReadableToWeb(nodeStream: NodeJS.ReadableStream): ReadableStream<Uint8Array> {
|
function nodeReadableToWeb(nodeStream: NodeJS.ReadableStream): ReadableStream<Uint8Array> {
|
||||||
return new ReadableStream<Uint8Array>({
|
return new ReadableStream<Uint8Array>({
|
||||||
start(controller) {
|
start(controller) {
|
||||||
nodeStream.on('data', (chunk: Buffer) => controller.enqueue(new Uint8Array(chunk)));
|
nodeStream.on('data', (chunk: Buffer) => controller.enqueue(new Uint8Array(chunk)));
|
||||||
@@ -17,7 +17,7 @@ export function nodeReadableToWeb(nodeStream: NodeJS.ReadableStream): ReadableSt
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
export function nodeWritableToWeb(nodeStream: NodeJS.WritableStream): WritableStream<Uint8Array> {
|
function nodeWritableToWeb(nodeStream: NodeJS.WritableStream): WritableStream<Uint8Array> {
|
||||||
return new WritableStream<Uint8Array>({
|
return new WritableStream<Uint8Array>({
|
||||||
write(chunk) {
|
write(chunk) {
|
||||||
return new Promise<void>((resolve, reject) => {
|
return new Promise<void>((resolve, reject) => {
|
||||||
|
|||||||
@@ -179,3 +179,73 @@ describe('mapSdkMessage — non-content messages', () => {
|
|||||||
).toEqual([]);
|
).toEqual([]);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('mapSdkMessage — user tool results', () => {
|
||||||
|
/** A `user` message carrying tool_result blocks (the SDK feeds tool output back here). */
|
||||||
|
function userMsg(content: unknown): SDKMessage {
|
||||||
|
return msg({ type: 'user', message: { role: 'user', content }, parent_tool_use_id: null, uuid: 'u', session_id: 's' });
|
||||||
|
}
|
||||||
|
|
||||||
|
it('maps a string tool_result to a completed tool_update carrying the output', () => {
|
||||||
|
const state = createClaudeSdkMapState();
|
||||||
|
const out = mapSdkMessage(userMsg([{ type: 'tool_result', tool_use_id: 't1', content: 'done' }]), state);
|
||||||
|
expect(out).toEqual<AgentEvent[]>([
|
||||||
|
{
|
||||||
|
type: 'tool_update',
|
||||||
|
toolCall: { toolCallId: 't1', title: 't1', kind: null, status: 'completed', rawInput: undefined, rawOutput: 'done' },
|
||||||
|
},
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('marks an is_error result failed', () => {
|
||||||
|
const state = createClaudeSdkMapState();
|
||||||
|
const out = mapSdkMessage(userMsg([{ type: 'tool_result', tool_use_id: 't1', content: 'boom', is_error: true }]), state);
|
||||||
|
const ev = out[0]!;
|
||||||
|
if (ev.type !== 'tool_update') throw new Error('expected tool_update');
|
||||||
|
expect(ev.toolCall.status).toBe('failed');
|
||||||
|
expect(ev.toolCall.rawOutput).toBe('boom');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('flattens array text blocks (skipping non-text) and reuses a prior snapshot title', () => {
|
||||||
|
const state = createClaudeSdkMapState();
|
||||||
|
mapSdkMessage(
|
||||||
|
streamEvent({ type: 'content_block_start', index: 1, content_block: { type: 'tool_use', id: 't2', name: 'view_file', input: {} } }),
|
||||||
|
state,
|
||||||
|
);
|
||||||
|
const out = mapSdkMessage(
|
||||||
|
userMsg([
|
||||||
|
{
|
||||||
|
type: 'tool_result',
|
||||||
|
tool_use_id: 't2',
|
||||||
|
content: [
|
||||||
|
{ type: 'text', text: 'line1' },
|
||||||
|
{ type: 'image', source: {} },
|
||||||
|
{ type: 'text', text: 'line2' },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
]),
|
||||||
|
state,
|
||||||
|
);
|
||||||
|
const ev = out[0]!;
|
||||||
|
if (ev.type !== 'tool_update') throw new Error('expected tool_update');
|
||||||
|
expect(ev.toolCall.toolCallId).toBe('t2');
|
||||||
|
expect(ev.toolCall.title).toBe('view_file');
|
||||||
|
expect(ev.toolCall.status).toBe('completed');
|
||||||
|
expect(ev.toolCall.rawOutput).toBe('line1\nline2');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('surfaces a result for an unknown tool_use_id with the id as the title', () => {
|
||||||
|
const state = createClaudeSdkMapState();
|
||||||
|
const out = mapSdkMessage(userMsg([{ type: 'tool_result', tool_use_id: 'orphan-id', content: 'x' }]), state);
|
||||||
|
expect(out[0]).toMatchObject({
|
||||||
|
type: 'tool_update',
|
||||||
|
toolCall: { toolCallId: 'orphan-id', title: 'orphan-id', kind: null, status: 'completed' },
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('ignores non-tool_result blocks and non-array content', () => {
|
||||||
|
const state = createClaudeSdkMapState();
|
||||||
|
expect(mapSdkMessage(userMsg([{ type: 'text', text: 'hi' }]), state)).toEqual([]);
|
||||||
|
expect(mapSdkMessage(userMsg('plain string'), state)).toEqual([]);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -0,0 +1,173 @@
|
|||||||
|
import { describe, it, expect, vi } from 'vitest';
|
||||||
|
import type { Event, OpencodeClient } from '@opencode-ai/sdk/v2/client';
|
||||||
|
import {
|
||||||
|
reconnectDecision,
|
||||||
|
runSessionEventLoop,
|
||||||
|
DEFAULT_RECONNECT_POLICY,
|
||||||
|
type SessionState,
|
||||||
|
type SseLoopDeps,
|
||||||
|
} from '../opencode-sse.js';
|
||||||
|
import { shouldStartServer } from '../opencode-server-process.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* v2.7 concurrency hardening (Phase 7): the pure decision cores for SSE reconnect
|
||||||
|
* backoff + the ensureServer double-spawn guard, plus a deterministic exercise of
|
||||||
|
* the loop's breaker (injected sleep, fake client). Happy path is asserted to be
|
||||||
|
* unchanged (clean stream end → reset → base-delay reconnect).
|
||||||
|
*/
|
||||||
|
|
||||||
|
function freshState(): SessionState {
|
||||||
|
return {
|
||||||
|
boocodeSessionId: 'boo1',
|
||||||
|
agentSessionId: 'oc1',
|
||||||
|
worktreePath: '/wt',
|
||||||
|
streamedPartKeys: new Set(),
|
||||||
|
partTypeById: new Map(),
|
||||||
|
activeTurn: { onEvent: () => {}, settle: () => {} },
|
||||||
|
watchdog: null,
|
||||||
|
sseAbort: null,
|
||||||
|
swallowNextTerminal: false,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
const silentLog = {
|
||||||
|
warn: () => {},
|
||||||
|
info: () => {},
|
||||||
|
error: () => {},
|
||||||
|
debug: () => {},
|
||||||
|
} as unknown as SseLoopDeps['log'];
|
||||||
|
|
||||||
|
describe('reconnectDecision (pure backoff + breaker)', () => {
|
||||||
|
it('first failure uses the base delay (matches pre-hardening flat delay)', () => {
|
||||||
|
expect(reconnectDecision(1)).toEqual({ action: 'reconnect', delayMs: DEFAULT_RECONNECT_POLICY.baseMs });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('grows exponentially and caps at maxMs', () => {
|
||||||
|
const policy = { baseMs: 1000, maxMs: 30_000, maxAttempts: 10 };
|
||||||
|
expect(reconnectDecision(2, policy)).toEqual({ action: 'reconnect', delayMs: 2000 });
|
||||||
|
expect(reconnectDecision(3, policy)).toEqual({ action: 'reconnect', delayMs: 4000 });
|
||||||
|
expect(reconnectDecision(6, policy)).toEqual({ action: 'reconnect', delayMs: 30_000 }); // 32000 capped
|
||||||
|
expect(reconnectDecision(9, policy)).toEqual({ action: 'reconnect', delayMs: 30_000 });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('gives up once failures exceed maxAttempts', () => {
|
||||||
|
const policy = { baseMs: 1, maxMs: 8, maxAttempts: 3 };
|
||||||
|
expect(reconnectDecision(3, policy).action).toBe('reconnect');
|
||||||
|
expect(reconnectDecision(4, policy)).toEqual({ action: 'give-up' });
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('shouldStartServer (double-spawn guard)', () => {
|
||||||
|
it('does not start when the server is live', () => {
|
||||||
|
expect(shouldStartServer({ up: true, hasClient: true, serverStarting: true, childDead: false, startInFlight: false })).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('starts on a fresh process (no start in flight)', () => {
|
||||||
|
expect(shouldStartServer({ up: false, hasClient: false, serverStarting: false, childDead: false, startInFlight: false })).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('re-spawns after a crash once the prior start finished', () => {
|
||||||
|
expect(shouldStartServer({ up: false, hasClient: false, serverStarting: true, childDead: true, startInFlight: false })).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does NOT double-spawn while a start is already in flight (the race fix)', () => {
|
||||||
|
expect(shouldStartServer({ up: false, hasClient: false, serverStarting: true, childDead: true, startInFlight: true })).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does NOT double-spawn when a crash nulled serverStarting mid-start', () => {
|
||||||
|
// The narrow window: a crash during the in-flight start (await freePort) nulls
|
||||||
|
// serverStarting while startInFlight is still true. The startInFlight guard must
|
||||||
|
// win over the !serverStarting branch, else a second server spawns on a new port.
|
||||||
|
expect(shouldStartServer({ up: false, hasClient: false, serverStarting: false, childDead: true, startInFlight: true })).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('waits (no spawn) when a cached start exists and the child is still alive', () => {
|
||||||
|
expect(shouldStartServer({ up: false, hasClient: false, serverStarting: true, childDead: false, startInFlight: false })).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('runSessionEventLoop — happy path (unchanged)', () => {
|
||||||
|
it('dispatches streamed events, reconciles on clean end, reconnects at base delay', async () => {
|
||||||
|
const state = freshState();
|
||||||
|
const abort = new AbortController();
|
||||||
|
const events = [
|
||||||
|
{ type: 'session.next.text.delta', properties: { sessionID: 'oc1', delta: 'hi' } },
|
||||||
|
{ type: 'session.idle', properties: { sessionID: 'oc1' } },
|
||||||
|
] as unknown as Event[];
|
||||||
|
|
||||||
|
const client = {
|
||||||
|
event: {
|
||||||
|
subscribe: vi.fn(async () => ({
|
||||||
|
stream: (async function* () {
|
||||||
|
for (const ev of events) yield ev;
|
||||||
|
})(),
|
||||||
|
})),
|
||||||
|
},
|
||||||
|
} as unknown as OpencodeClient;
|
||||||
|
|
||||||
|
const dispatched: Event[] = [];
|
||||||
|
const sleeps: number[] = [];
|
||||||
|
let reconciles = 0;
|
||||||
|
|
||||||
|
const deps: SseLoopDeps = {
|
||||||
|
isUp: () => true,
|
||||||
|
getClient: () => client,
|
||||||
|
dispatchEvent: (ev) => dispatched.push(ev),
|
||||||
|
reconcile: async () => {
|
||||||
|
reconciles += 1;
|
||||||
|
abort.abort(); // stop the loop after the first clean cycle
|
||||||
|
return false;
|
||||||
|
},
|
||||||
|
onReconnectGiveUp: () => {
|
||||||
|
throw new Error('should not give up on the happy path');
|
||||||
|
},
|
||||||
|
log: silentLog,
|
||||||
|
sleep: async (ms) => {
|
||||||
|
sleeps.push(ms);
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
await runSessionEventLoop(state, abort, deps);
|
||||||
|
|
||||||
|
expect(dispatched).toHaveLength(2);
|
||||||
|
expect(reconciles).toBe(1);
|
||||||
|
expect(sleeps).toEqual([DEFAULT_RECONNECT_POLICY.baseMs]); // base delay, not backed off
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('runSessionEventLoop — circuit breaker', () => {
|
||||||
|
it('backs off on repeated throws then gives up + fails the turn', async () => {
|
||||||
|
const state = freshState();
|
||||||
|
const abort = new AbortController();
|
||||||
|
const policy = { baseMs: 1, maxMs: 8, maxAttempts: 3 };
|
||||||
|
|
||||||
|
const subscribe = vi.fn(async () => {
|
||||||
|
throw new Error('connection refused');
|
||||||
|
});
|
||||||
|
const client = { event: { subscribe } } as unknown as OpencodeClient;
|
||||||
|
|
||||||
|
const sleeps: number[] = [];
|
||||||
|
const gaveUp = vi.fn();
|
||||||
|
|
||||||
|
const deps: SseLoopDeps = {
|
||||||
|
isUp: () => true,
|
||||||
|
getClient: () => client,
|
||||||
|
dispatchEvent: () => {},
|
||||||
|
reconcile: async () => false,
|
||||||
|
onReconnectGiveUp: gaveUp,
|
||||||
|
log: silentLog,
|
||||||
|
sleep: async (ms) => {
|
||||||
|
sleeps.push(ms);
|
||||||
|
},
|
||||||
|
policy,
|
||||||
|
};
|
||||||
|
|
||||||
|
await runSessionEventLoop(state, abort, deps);
|
||||||
|
|
||||||
|
// 3 backoff sleeps (1, 2, 4), then the 4th failure trips the breaker.
|
||||||
|
expect(sleeps).toEqual([1, 2, 4]);
|
||||||
|
expect(subscribe).toHaveBeenCalledTimes(4);
|
||||||
|
expect(gaveUp).toHaveBeenCalledTimes(1);
|
||||||
|
expect(gaveUp).toHaveBeenCalledWith(state);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,226 @@
|
|||||||
|
import { describe, it, expect } from 'vitest';
|
||||||
|
import type { Event, Part } from '@opencode-ai/sdk/v2/client';
|
||||||
|
import {
|
||||||
|
stripDcpTags,
|
||||||
|
eventSessionId,
|
||||||
|
resolvePartDedupeKey,
|
||||||
|
mapToolStatus,
|
||||||
|
toolPartToSnapshot,
|
||||||
|
toolCalledSnapshot,
|
||||||
|
toolSuccessSnapshot,
|
||||||
|
toolFailedSnapshot,
|
||||||
|
classifyPartDelta,
|
||||||
|
classifyUpdatedPart,
|
||||||
|
errToString,
|
||||||
|
errMsg,
|
||||||
|
type DedupState,
|
||||||
|
} from '../opencode-event-map.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Pure opencode Event → AgentEvent translation + dedup gate (v2.7 audit reshape).
|
||||||
|
* Mirrors the original `dispatchEvent` / `handleUpdatedPart` arms verbatim — no
|
||||||
|
* I/O, so it's unit-testable. The slimmed backend keeps the routing + side effects.
|
||||||
|
*/
|
||||||
|
|
||||||
|
function freshDedup(): DedupState {
|
||||||
|
return { streamedPartKeys: new Set(), partTypeById: new Map() };
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('stripDcpTags', () => {
|
||||||
|
it('removes a complete dcp tag', () => {
|
||||||
|
expect(stripDcpTags('hi <dcp-message-id>m1</dcp-message-id> there')).toBe('hi there');
|
||||||
|
});
|
||||||
|
it('leaves untagged text untouched', () => {
|
||||||
|
expect(stripDcpTags('plain text <div>')).toBe('plain text <div>');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('eventSessionId', () => {
|
||||||
|
it('reads properties.sessionID for a normal event', () => {
|
||||||
|
const ev = { type: 'session.idle', properties: { sessionID: 's1' } } as unknown as Event;
|
||||||
|
expect(eventSessionId(ev)).toBe('s1');
|
||||||
|
});
|
||||||
|
it('reads properties.part.sessionID for message.part.updated', () => {
|
||||||
|
const ev = {
|
||||||
|
type: 'message.part.updated',
|
||||||
|
properties: { part: { sessionID: 's2' } },
|
||||||
|
} as unknown as Event;
|
||||||
|
expect(eventSessionId(ev)).toBe('s2');
|
||||||
|
});
|
||||||
|
it('returns null when there is no session', () => {
|
||||||
|
const ev = { type: 'server.connected', properties: {} } as unknown as Event;
|
||||||
|
expect(eventSessionId(ev)).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('resolvePartDedupeKey', () => {
|
||||||
|
it('prefers the part id', () => {
|
||||||
|
expect(resolvePartDedupeKey({ id: 'p1', messageID: 'm1' }, 'text')).toBe('text:p1');
|
||||||
|
});
|
||||||
|
it('falls back to the message id', () => {
|
||||||
|
expect(resolvePartDedupeKey({ id: ' ', messageID: 'm1' }, 'reasoning')).toBe('reasoning:message:m1');
|
||||||
|
});
|
||||||
|
it('returns null when neither is present', () => {
|
||||||
|
expect(resolvePartDedupeKey({ id: '', messageID: '' }, 'text')).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('mapToolStatus', () => {
|
||||||
|
it('maps the opencode tool states to ACP statuses', () => {
|
||||||
|
expect(mapToolStatus('pending')).toBe('pending');
|
||||||
|
expect(mapToolStatus('running')).toBe('in_progress');
|
||||||
|
expect(mapToolStatus('completed')).toBe('completed');
|
||||||
|
expect(mapToolStatus('error')).toBe('failed');
|
||||||
|
expect(mapToolStatus(undefined)).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('session.next.tool.* snapshot builders', () => {
|
||||||
|
it('toolCalledSnapshot → in_progress with tool title + raw input', () => {
|
||||||
|
expect(toolCalledSnapshot({ callID: 'c1', tool: 'read_file', input: { path: 'a.ts' } })).toEqual({
|
||||||
|
toolCallId: 'c1',
|
||||||
|
title: 'read_file',
|
||||||
|
kind: null,
|
||||||
|
status: 'in_progress',
|
||||||
|
rawInput: { path: 'a.ts' },
|
||||||
|
rawOutput: undefined,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
it('toolSuccessSnapshot → completed with joined text content', () => {
|
||||||
|
const snap = toolSuccessSnapshot({ callID: 'c1', content: [{ text: 'foo' }, { text: 'bar' }, { other: 1 }] });
|
||||||
|
expect(snap.status).toBe('completed');
|
||||||
|
expect(snap.title).toBe('c1');
|
||||||
|
expect(snap.rawOutput).toBe('foobar');
|
||||||
|
});
|
||||||
|
it('toolSuccessSnapshot → empty output when content is missing', () => {
|
||||||
|
expect(toolSuccessSnapshot({ callID: 'c1' }).rawOutput).toBe('');
|
||||||
|
});
|
||||||
|
it('toolFailedSnapshot → failed with stringified error', () => {
|
||||||
|
const snap = toolFailedSnapshot({ callID: 'c1', error: 'boom' });
|
||||||
|
expect(snap.status).toBe('failed');
|
||||||
|
expect(snap.title).toBe('c1');
|
||||||
|
expect(snap.rawOutput).toBe('boom');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('toolPartToSnapshot', () => {
|
||||||
|
it('extracts input/output/title/status from the tool state', () => {
|
||||||
|
const part = {
|
||||||
|
type: 'tool',
|
||||||
|
callID: 'c1',
|
||||||
|
tool: 'grep',
|
||||||
|
state: { status: 'completed', input: { q: 'x' }, output: 'result', title: 'Grep run' },
|
||||||
|
} as unknown as Parameters<typeof toolPartToSnapshot>[0];
|
||||||
|
expect(toolPartToSnapshot(part)).toEqual({
|
||||||
|
toolCallId: 'c1',
|
||||||
|
title: 'Grep run',
|
||||||
|
kind: null,
|
||||||
|
status: 'completed',
|
||||||
|
rawInput: { q: 'x' },
|
||||||
|
rawOutput: 'result',
|
||||||
|
});
|
||||||
|
});
|
||||||
|
it('falls back to the tool name and uses error as output', () => {
|
||||||
|
const part = {
|
||||||
|
type: 'tool',
|
||||||
|
callID: 'c2',
|
||||||
|
tool: 'edit',
|
||||||
|
state: { status: 'error', error: 'nope' },
|
||||||
|
} as unknown as Parameters<typeof toolPartToSnapshot>[0];
|
||||||
|
const snap = toolPartToSnapshot(part);
|
||||||
|
expect(snap.title).toBe('edit');
|
||||||
|
expect(snap.status).toBe('failed');
|
||||||
|
expect(snap.rawOutput).toBe('nope');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('classifyPartDelta (message.part.delta dedup recording)', () => {
|
||||||
|
it('records a reasoning key and emits a reasoning event', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
const e = classifyPartDelta({ partID: 'p1', field: 'reasoning', delta: 'thinking' }, st);
|
||||||
|
expect(e).toEqual({ type: 'reasoning', text: 'thinking' });
|
||||||
|
expect(st.streamedPartKeys.has('reasoning:p1')).toBe(true);
|
||||||
|
});
|
||||||
|
it('records a text key, strips dcp, and emits text', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
const e = classifyPartDelta({ partID: 'p2', field: 'text', delta: 'hi <dcp-message-id>m</dcp-message-id>' }, st);
|
||||||
|
expect(e).toEqual({ type: 'text', text: 'hi ' });
|
||||||
|
expect(st.streamedPartKeys.has('text:p2')).toBe(true);
|
||||||
|
});
|
||||||
|
it('still records the text key even when the cleaned delta is empty', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
const e = classifyPartDelta({ partID: 'p3', field: 'text', delta: '<dcp-message-id>m</dcp-message-id>' }, st);
|
||||||
|
expect(e).toBeNull();
|
||||||
|
expect(st.streamedPartKeys.has('text:p3')).toBe(true);
|
||||||
|
});
|
||||||
|
it('uses the recorded part type when the field is absent', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
st.partTypeById.set('p4', 'reasoning');
|
||||||
|
const e = classifyPartDelta({ partID: 'p4', delta: 'more' }, st);
|
||||||
|
expect(e).toEqual({ type: 'reasoning', text: 'more' });
|
||||||
|
});
|
||||||
|
it('returns null for an unknown field', () => {
|
||||||
|
expect(classifyPartDelta({ partID: 'p5', field: 'other', delta: 'x' }, freshDedup())).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('classifyUpdatedPart (message.part.updated dedup gate)', () => {
|
||||||
|
function textPart(over: Partial<Part> = {}): Part {
|
||||||
|
return {
|
||||||
|
type: 'text',
|
||||||
|
id: 'p1',
|
||||||
|
messageID: 'm1',
|
||||||
|
sessionID: 's1',
|
||||||
|
text: 'final text',
|
||||||
|
time: { start: 1, end: 2 },
|
||||||
|
...over,
|
||||||
|
} as unknown as Part;
|
||||||
|
}
|
||||||
|
|
||||||
|
it('drops a terminal part already streamed via deltas', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
st.streamedPartKeys.add('text:p1');
|
||||||
|
expect(classifyUpdatedPart(textPart(), st)).toBeNull();
|
||||||
|
// the key is consumed
|
||||||
|
expect(st.streamedPartKeys.has('text:p1')).toBe(false);
|
||||||
|
});
|
||||||
|
it('emits a finished (ended) text part not seen via deltas', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
expect(classifyUpdatedPart(textPart(), st)).toEqual({ type: 'text', text: 'final text' });
|
||||||
|
expect(st.partTypeById.get('p1')).toBe('text');
|
||||||
|
});
|
||||||
|
it('does not emit a part that has not ended yet', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
expect(classifyUpdatedPart(textPart({ time: { start: 1 } as never }), st)).toBeNull();
|
||||||
|
});
|
||||||
|
it('strips dcp tags from the finished text', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
const part = textPart({ text: 'a <dcp-message-id>m</dcp-message-id>b' });
|
||||||
|
expect(classifyUpdatedPart(part, st)).toEqual({ type: 'text', text: 'a b' });
|
||||||
|
});
|
||||||
|
it('maps a running tool part to tool_call', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
const part = { type: 'tool', callID: 'c1', tool: 'grep', state: { status: 'running' } } as unknown as Part;
|
||||||
|
const e = classifyUpdatedPart(part, st);
|
||||||
|
expect(e?.type).toBe('tool_call');
|
||||||
|
});
|
||||||
|
it('maps a completed tool part to tool_update', () => {
|
||||||
|
const st = freshDedup();
|
||||||
|
const part = { type: 'tool', callID: 'c1', tool: 'grep', state: { status: 'completed', output: 'x' } } as unknown as Part;
|
||||||
|
const e = classifyUpdatedPart(part, st);
|
||||||
|
expect(e?.type).toBe('tool_update');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('error formatters', () => {
|
||||||
|
it('errMsg unwraps Error.message', () => {
|
||||||
|
expect(errMsg(new Error('x'))).toBe('x');
|
||||||
|
expect(errMsg('plain')).toBe('plain');
|
||||||
|
});
|
||||||
|
it('errToString handles null/string/Error/object', () => {
|
||||||
|
expect(errToString(null)).toBe('unknown error');
|
||||||
|
expect(errToString('s')).toBe('s');
|
||||||
|
expect(errToString(new Error('e'))).toBe('e');
|
||||||
|
expect(errToString({ a: 1 })).toBe('{"a":1}');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -49,6 +49,7 @@ import type { AcpToolSnapshot } from '../acp-tool-snapshot.js';
|
|||||||
type StreamEvent = Extract<SDKMessage, { type: 'stream_event' }>['event'];
|
type StreamEvent = Extract<SDKMessage, { type: 'stream_event' }>['event'];
|
||||||
type AssistantContent = Extract<SDKMessage, { type: 'assistant' }>['message']['content'];
|
type AssistantContent = Extract<SDKMessage, { type: 'assistant' }>['message']['content'];
|
||||||
type ContentBlock = AssistantContent extends readonly (infer B)[] ? B : never;
|
type ContentBlock = AssistantContent extends readonly (infer B)[] ? B : never;
|
||||||
|
type UserContent = Extract<SDKMessage, { type: 'user' }>['message']['content'];
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Caller-owned accumulator threaded across `mapSdkMessage` calls within ONE turn.
|
* Caller-owned accumulator threaded across `mapSdkMessage` calls within ONE turn.
|
||||||
@@ -81,6 +82,12 @@ export function mapSdkMessage(msg: SDKMessage, state: ClaudeSdkMapState): AgentE
|
|||||||
return mapStreamEvent(msg.event, state);
|
return mapStreamEvent(msg.event, state);
|
||||||
case 'assistant':
|
case 'assistant':
|
||||||
return mapFinalAssistant(msg.message.content, state);
|
return mapFinalAssistant(msg.message.content, state);
|
||||||
|
case 'user':
|
||||||
|
// Tool RESULTS ride in as user messages (tool_result blocks): the SDK ran
|
||||||
|
// the tool and feeds its output back. Without mapping these, the tool_call
|
||||||
|
// never reaches a terminal snapshot — it persists as status:'running' with
|
||||||
|
// no output and the UI spinner never stops (the bug this fixes).
|
||||||
|
return mapUserToolResults(msg.message.content, state);
|
||||||
default:
|
default:
|
||||||
// system/init, status, result, hooks, task_*, etc. — no turn content here.
|
// system/init, status, result, hooks, task_*, etc. — no turn content here.
|
||||||
// (The backend reads session_id off the init message and usage/cost off the
|
// (The backend reads session_id off the init message and usage/cost off the
|
||||||
@@ -180,6 +187,52 @@ function mapFinalAssistant(content: ContentBlock[], state: ClaudeSdkMapState): A
|
|||||||
return out;
|
return out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* User-message tool_result blocks → terminal tool_update events. The SDK runs
|
||||||
|
* each tool and feeds the output back in a `user` message; we mark the matching
|
||||||
|
* snapshot completed (or failed, on is_error) WITH its output so the snapshot
|
||||||
|
* persists/renders as resolved instead of spinning. Unknown ids (no prior
|
||||||
|
* snapshot) are still surfaced so a stray result isn't silently lost.
|
||||||
|
*/
|
||||||
|
function mapUserToolResults(content: UserContent, state: ClaudeSdkMapState): AgentEvent[] {
|
||||||
|
if (!Array.isArray(content)) return [];
|
||||||
|
const out: AgentEvent[] = [];
|
||||||
|
for (const raw of content) {
|
||||||
|
const block = raw as { type?: string; tool_use_id?: string; content?: unknown; is_error?: boolean };
|
||||||
|
if (block.type !== 'tool_result' || !block.tool_use_id) continue;
|
||||||
|
const prev = state.snapshots.get(block.tool_use_id);
|
||||||
|
const snap: AcpToolSnapshot = {
|
||||||
|
toolCallId: block.tool_use_id,
|
||||||
|
title: prev?.title ?? block.tool_use_id,
|
||||||
|
kind: prev?.kind ?? null,
|
||||||
|
status: block.is_error ? 'failed' : 'completed',
|
||||||
|
rawInput: prev?.rawInput,
|
||||||
|
rawOutput: toolResultText(block.content),
|
||||||
|
};
|
||||||
|
state.snapshots.set(block.tool_use_id, snap);
|
||||||
|
out.push({ type: 'tool_update', toolCall: snap });
|
||||||
|
}
|
||||||
|
return out;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** tool_result content is a string OR an array of content blocks (text/image).
|
||||||
|
* Flatten text blocks; fall back to the raw value so nothing is lost. */
|
||||||
|
function toolResultText(content: unknown): unknown {
|
||||||
|
if (typeof content === 'string') return content;
|
||||||
|
if (Array.isArray(content)) {
|
||||||
|
const text = content
|
||||||
|
.map((c) =>
|
||||||
|
c && typeof c === 'object' && (c as { type?: string }).type === 'text'
|
||||||
|
? String((c as { text?: unknown }).text ?? '')
|
||||||
|
: '',
|
||||||
|
)
|
||||||
|
.filter(Boolean)
|
||||||
|
.join('\n');
|
||||||
|
return text || content;
|
||||||
|
}
|
||||||
|
return content ?? '';
|
||||||
|
}
|
||||||
|
|
||||||
/** Parse a buffered JSON string; fall back to a prior value on empty/invalid. */
|
/** Parse a buffered JSON string; fall back to a prior value on empty/invalid. */
|
||||||
function parseJsonOr(buf: string, fallback: unknown): unknown {
|
function parseJsonOr(buf: string, fallback: unknown): unknown {
|
||||||
const s = buf.trim();
|
const s = buf.trim();
|
||||||
|
|||||||
203
apps/coder/src/services/backends/opencode-event-map.ts
Normal file
203
apps/coder/src/services/backends/opencode-event-map.ts
Normal file
@@ -0,0 +1,203 @@
|
|||||||
|
/**
|
||||||
|
* Pure opencode `Event` → normalized `AgentEvent` translation.
|
||||||
|
*
|
||||||
|
* Extracted (v2.7 audit reshape) from `OpenCodeServerBackend.dispatchEvent` /
|
||||||
|
* `handleUpdatedPart` and the file-local helpers. NO I/O, no timers, no DB, no
|
||||||
|
* `byOpencodeId` — every function here is a deterministic transform over its
|
||||||
|
* arguments (the dedup state is caller-owned and mutated in place, mirroring the
|
||||||
|
* `acp-event-map.ts` `priorSnapshots` pattern). This is the unit-testable core; the
|
||||||
|
* backend keeps the routing + side effects (watchdog, usage persistence, settle).
|
||||||
|
*
|
||||||
|
* Depends only on SDK TYPES + AcpToolSnapshot — safe to import anywhere.
|
||||||
|
*/
|
||||||
|
import type { Event, Part, ToolPart, ToolState } from '@opencode-ai/sdk/v2/client';
|
||||||
|
import type { ToolCallStatus } from '@agentclientprotocol/sdk';
|
||||||
|
import type { AcpToolSnapshot } from '../acp-tool-snapshot.js';
|
||||||
|
import type { AgentEvent } from '../agent-backend.js';
|
||||||
|
|
||||||
|
/** Per-(opencode session) dedup state the part-stream classifiers read + mutate. */
|
||||||
|
export interface DedupState {
|
||||||
|
/** dedup gate: `${type}:${id}` added on delta, deleted-and-tested on updated. */
|
||||||
|
streamedPartKeys: Set<string>;
|
||||||
|
/** partID → 'text' | 'reasoning', so a delta with a non-'reasoning' field is still classed right. */
|
||||||
|
partTypeById: Map<string, string>;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Strip opencode-dcp plugin tags that render as literal text in the UI. */
|
||||||
|
export function stripDcpTags(s: string): string {
|
||||||
|
return s.replace(/<dcp-message-id>[^<]*<\/dcp-message-id>/g, '');
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Extract the opencode sessionID an event belongs to, across event shapes.
|
||||||
|
* Most carry `properties.sessionID`; `message.part.updated` nests it under
|
||||||
|
* `properties.part.sessionID`. Returns null when the event has no session
|
||||||
|
* (the per-session loop then leaves it to dispatchEvent, which drops it). */
|
||||||
|
export function eventSessionId(ev: Event): string | null {
|
||||||
|
const props = (ev as { properties?: unknown }).properties;
|
||||||
|
if (!props || typeof props !== 'object') return null;
|
||||||
|
if (ev.type === 'message.part.updated') {
|
||||||
|
const part = (props as { part?: { sessionID?: string } }).part;
|
||||||
|
return part?.sessionID ?? null;
|
||||||
|
}
|
||||||
|
return (props as { sessionID?: string }).sessionID ?? null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Ported verbatim from Paseo opencode-agent.ts: id → message-id fallback → null. */
|
||||||
|
export function resolvePartDedupeKey(part: { id: string; messageID: string }, type: string): string | null {
|
||||||
|
if (part.id.trim().length > 0) return `${type}:${part.id}`;
|
||||||
|
if (part.messageID.trim().length > 0) return `${type}:message:${part.messageID}`;
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function mapToolStatus(s: ToolState['status'] | undefined): ToolCallStatus | null {
|
||||||
|
switch (s) {
|
||||||
|
case 'pending':
|
||||||
|
return 'pending';
|
||||||
|
case 'running':
|
||||||
|
return 'in_progress';
|
||||||
|
case 'completed':
|
||||||
|
return 'completed';
|
||||||
|
case 'error':
|
||||||
|
return 'failed';
|
||||||
|
default:
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** opencode ToolPart → ACP-shaped snapshot (reuses the existing persist/render path). */
|
||||||
|
export function toolPartToSnapshot(part: ToolPart): AcpToolSnapshot {
|
||||||
|
const state = part.state;
|
||||||
|
let rawInput: unknown;
|
||||||
|
let rawOutput: unknown;
|
||||||
|
let title: string | undefined;
|
||||||
|
if (state) {
|
||||||
|
if ('input' in state) rawInput = (state as { input?: unknown }).input;
|
||||||
|
if ('output' in state) rawOutput = (state as { output?: unknown }).output;
|
||||||
|
else if ('error' in state) rawOutput = (state as { error?: unknown }).error;
|
||||||
|
if ('title' in state) title = (state as { title?: string }).title;
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
toolCallId: part.callID,
|
||||||
|
title: title ?? part.tool,
|
||||||
|
kind: null,
|
||||||
|
status: mapToolStatus(state?.status),
|
||||||
|
rawInput,
|
||||||
|
rawOutput,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── session.next.tool.* snapshot builders ───────────────────────────────────
|
||||||
|
|
||||||
|
/** `session.next.tool.called` → an in-progress tool_call snapshot. */
|
||||||
|
export function toolCalledSnapshot(p: { callID: string; tool: string; input: unknown }): AcpToolSnapshot {
|
||||||
|
return {
|
||||||
|
toolCallId: p.callID,
|
||||||
|
title: p.tool,
|
||||||
|
kind: null,
|
||||||
|
status: 'in_progress',
|
||||||
|
rawInput: p.input,
|
||||||
|
rawOutput: undefined,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/** `session.next.tool.success` → a completed tool snapshot (text content joined). */
|
||||||
|
export function toolSuccessSnapshot(p: { callID: string; content?: ReadonlyArray<unknown> | null }): AcpToolSnapshot {
|
||||||
|
const output = p.content?.map((c) => (c && typeof c === 'object' && 'text' in c ? (c as { text: string }).text : '')).join('') ?? '';
|
||||||
|
return {
|
||||||
|
toolCallId: p.callID,
|
||||||
|
title: p.callID,
|
||||||
|
kind: null,
|
||||||
|
status: 'completed',
|
||||||
|
rawInput: undefined,
|
||||||
|
rawOutput: output,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/** `session.next.tool.failed` → a failed tool snapshot (error stringified). */
|
||||||
|
export function toolFailedSnapshot(p: { callID: string; error: unknown }): AcpToolSnapshot {
|
||||||
|
return {
|
||||||
|
toolCallId: p.callID,
|
||||||
|
title: p.callID,
|
||||||
|
kind: null,
|
||||||
|
status: 'failed',
|
||||||
|
rawInput: undefined,
|
||||||
|
rawOutput: errToString(p.error),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── message.part.* dedup gate ────────────────────────────────────────────────
|
||||||
|
|
||||||
|
/**
|
||||||
|
* `message.part.delta`: mark the part as streamed (so a later `message.part.updated`
|
||||||
|
* for the same part is deduped) and return the AgentEvent to emit, or null when the
|
||||||
|
* field is neither reasoning nor text, or a text delta strips down to empty. Mutates
|
||||||
|
* `st.streamedPartKeys` exactly as the original inline arm did (the key is recorded
|
||||||
|
* for text even when the cleaned delta is empty).
|
||||||
|
*/
|
||||||
|
export function classifyPartDelta(
|
||||||
|
p: { partID: string; field?: string; delta: string },
|
||||||
|
st: DedupState,
|
||||||
|
): AgentEvent | null {
|
||||||
|
const isReasoning = p.field === 'reasoning' || st.partTypeById.get(p.partID) === 'reasoning';
|
||||||
|
if (isReasoning) {
|
||||||
|
st.streamedPartKeys.add(`reasoning:${p.partID}`);
|
||||||
|
return { type: 'reasoning', text: p.delta };
|
||||||
|
}
|
||||||
|
if (p.field === 'text') {
|
||||||
|
st.streamedPartKeys.add(`text:${p.partID}`);
|
||||||
|
const cleaned = stripDcpTags(p.delta);
|
||||||
|
return cleaned ? { type: 'text', text: cleaned } : null;
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* `message.part.updated` terminal part: the dedup gate for text/reasoning (drop a
|
||||||
|
* part already streamed via deltas; otherwise emit the finished text) plus the
|
||||||
|
* tool-part → tool_call/tool_update mapping. Returns null when nothing should be
|
||||||
|
* emitted. Mutates `st.partTypeById` / `st.streamedPartKeys` like the original.
|
||||||
|
*/
|
||||||
|
export function classifyUpdatedPart(part: Part, st: DedupState): AgentEvent | null {
|
||||||
|
if (part.type === 'text' || part.type === 'reasoning') {
|
||||||
|
st.partTypeById.set(part.id, part.type);
|
||||||
|
const key = resolvePartDedupeKey(part, part.type);
|
||||||
|
if (key && st.streamedPartKeys.delete(key)) return null; // already streamed via delta
|
||||||
|
const raw = part.text ?? '';
|
||||||
|
const text = part.type === 'text' ? stripDcpTags(raw) : raw;
|
||||||
|
if (text && part.time?.end != null) {
|
||||||
|
return { type: part.type, text };
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (part.type === 'tool') {
|
||||||
|
const snap = toolPartToSnapshot(part);
|
||||||
|
const status = part.state?.status;
|
||||||
|
// tool_call on start (pending/running), tool_update on terminal (completed/error).
|
||||||
|
// The current ACP path merges both into one frame; the contract keeps them
|
||||||
|
// distinct because opencode's SSE distinguishes start from result.
|
||||||
|
return status === 'completed' || status === 'error'
|
||||||
|
? { type: 'tool_update', toolCall: snap }
|
||||||
|
: { type: 'tool_call', toolCall: snap };
|
||||||
|
}
|
||||||
|
// NOTE: opencode's SSE payload union carries no available-commands event, so the
|
||||||
|
// AgentEvent 'commands' arm is intentionally never emitted here.
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── shared error formatters (pure) ───────────────────────────────────────────
|
||||||
|
|
||||||
|
export function errMsg(e: unknown): string {
|
||||||
|
return e instanceof Error ? e.message : String(e);
|
||||||
|
}
|
||||||
|
|
||||||
|
export function errToString(e: unknown): string {
|
||||||
|
if (e == null) return 'unknown error';
|
||||||
|
if (typeof e === 'string') return e;
|
||||||
|
if (e instanceof Error) return e.message;
|
||||||
|
try {
|
||||||
|
return JSON.stringify(e);
|
||||||
|
} catch {
|
||||||
|
return String(e);
|
||||||
|
}
|
||||||
|
}
|
||||||
325
apps/coder/src/services/backends/opencode-server-process.ts
Normal file
325
apps/coder/src/services/backends/opencode-server-process.ts
Normal file
@@ -0,0 +1,325 @@
|
|||||||
|
/**
|
||||||
|
* OpenCodeServerSupervisor — the opencode `serve` child + HTTP client + port +
|
||||||
|
* health-counter lifecycle, extracted (v2.7 audit reshape) from the backend
|
||||||
|
* god-class. Owns spawn / ready / crash / proactive-health restart / dispose and
|
||||||
|
* exposes `client` / `port` / `health()` / `tickHealth()` to the backend.
|
||||||
|
*
|
||||||
|
* Session-level recovery (failing in-flight turns, marking agent_sessions crashed,
|
||||||
|
* tearing down SSE loops) is NOT a process concern — it's delegated back to the
|
||||||
|
* backend through the injected `hooks.onServerDown` callback, keeping this module
|
||||||
|
* free of the demux map / SQL / turn state.
|
||||||
|
*
|
||||||
|
* v2.7 concurrency hardening: `ensureServer` is guarded against the crash-window
|
||||||
|
* double-spawn (two concurrent callers each re-spawning on different ports) via a
|
||||||
|
* synchronous `startInFlight` flag — see `shouldStartServer`.
|
||||||
|
*/
|
||||||
|
import { spawn, type ChildProcess } from 'node:child_process';
|
||||||
|
import { createOpencodeClient, type OpencodeClient } from '@opencode-ai/sdk/v2/client';
|
||||||
|
import type { FastifyBaseLogger } from 'fastify';
|
||||||
|
import { decideRestart, DEFAULT_HEALTH_FAILURE_THRESHOLD } from './lifecycle-decisions.js';
|
||||||
|
import { reclaimPort, waitForPortRelease, freePort } from '../net/port-utils.js';
|
||||||
|
|
||||||
|
const READY_TIMEOUT_MS = 30_000;
|
||||||
|
|
||||||
|
/** Info handed to the backend when the server goes down (crash or forced restart). */
|
||||||
|
export interface ServerDownInfo {
|
||||||
|
code: number | null;
|
||||||
|
signal: NodeJS.Signals | null;
|
||||||
|
port: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface SupervisorHooks {
|
||||||
|
/** True iff ANY pooled session has an in-flight turn (defers a busy restart). */
|
||||||
|
isBusy: () => boolean;
|
||||||
|
/** Session-level recovery: fail in-flight turns, mark crashed, drop demux state. */
|
||||||
|
onServerDown: (info: ServerDownInfo) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface OpenCodeServerSupervisorDeps {
|
||||||
|
/** Absolute path to the opencode binary (resolved from available_agents). */
|
||||||
|
opencodeBinary: string;
|
||||||
|
log: FastifyBaseLogger;
|
||||||
|
hooks: SupervisorHooks;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Pure decision for `ensureServer`: should we (re)spawn the server right now?
|
||||||
|
*
|
||||||
|
* - A live, ready server (`up && client`) → no.
|
||||||
|
* - A start already in flight (`startInFlight`) → no, NEVER double-spawn — join the
|
||||||
|
* running start instead. This is checked BEFORE `serverStarting` because the crash
|
||||||
|
* handler can null `serverStarting` mid-start (a crash during `await freePort()`),
|
||||||
|
* and without this guard the `!serverStarting` branch would spawn a second server
|
||||||
|
* on a different port while the first is still coming up.
|
||||||
|
* - No start cached/running → yes (fresh start or post-crash re-spawn, since the
|
||||||
|
* crash handler nulls `serverStarting`).
|
||||||
|
* - A cached start that already finished, but the child has since died and the crash
|
||||||
|
* handler hasn't reset us yet → yes.
|
||||||
|
*/
|
||||||
|
export function shouldStartServer(s: {
|
||||||
|
up: boolean;
|
||||||
|
hasClient: boolean;
|
||||||
|
serverStarting: boolean;
|
||||||
|
childDead: boolean;
|
||||||
|
startInFlight: boolean;
|
||||||
|
}): boolean {
|
||||||
|
if (s.up && s.hasClient) return false;
|
||||||
|
if (s.startInFlight) return false;
|
||||||
|
if (!s.serverStarting) return true;
|
||||||
|
if (!s.up && s.childDead) return true;
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
export class OpenCodeServerSupervisor {
|
||||||
|
private readonly opencodeBinary: string;
|
||||||
|
private readonly log: FastifyBaseLogger;
|
||||||
|
private readonly hooks: SupervisorHooks;
|
||||||
|
|
||||||
|
private childProc: ChildProcess | null = null;
|
||||||
|
private opencodeClient: OpencodeClient | null = null;
|
||||||
|
private serverPort: number | null = null;
|
||||||
|
private up = false;
|
||||||
|
private serverStarting: Promise<void> | null = null;
|
||||||
|
/** True from the synchronous head of startServer() until it settles — the
|
||||||
|
* double-spawn guard reads it so a concurrent ensureServer joins instead of
|
||||||
|
* kicking a second spawn. */
|
||||||
|
private startInFlight = false;
|
||||||
|
// Phase 3 busy-aware health monitor (openchamber lift): consecutive failed
|
||||||
|
// probes + the start of an unhealthy-while-busy window feed `decideRestart`.
|
||||||
|
private consecutiveHealthFailures = 0;
|
||||||
|
private unhealthyBusySince = 0;
|
||||||
|
private restarting: Promise<void> | null = null;
|
||||||
|
|
||||||
|
constructor(deps: OpenCodeServerSupervisorDeps) {
|
||||||
|
this.opencodeBinary = deps.opencodeBinary;
|
||||||
|
this.log = deps.log;
|
||||||
|
this.hooks = deps.hooks;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** The live opencode HTTP client, or null between (re)starts. */
|
||||||
|
get client(): OpencodeClient | null {
|
||||||
|
return this.opencodeClient;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** The current server port, or null before the first start. */
|
||||||
|
get port(): number | null {
|
||||||
|
return this.serverPort;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** §2: liveness for the health endpoint + dispatcher fallback decision. */
|
||||||
|
health(): 'up' | 'down' {
|
||||||
|
return this.up ? 'up' : 'down';
|
||||||
|
}
|
||||||
|
|
||||||
|
isUp(): boolean {
|
||||||
|
return this.up;
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── lifecycle (spawn once + client + ready; crash-restart) ──────────────────
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Lazy: start the single server on first use; re-spawn after a crash. Idempotent
|
||||||
|
* within one live server — `serverStarting` caches the in-flight start, reset to
|
||||||
|
* null by the crash handler so the NEXT ensureServer re-spawns. A dead-but-not-
|
||||||
|
* yet-reaped child (exit handler raced) is also treated as needing a restart.
|
||||||
|
* Concurrent callers in a crash window are coalesced via `startInFlight`.
|
||||||
|
*/
|
||||||
|
ensureServer(): Promise<void> {
|
||||||
|
if (this.up && this.opencodeClient) return Promise.resolve();
|
||||||
|
const childDead =
|
||||||
|
this.childProc != null && (this.childProc.exitCode !== null || this.childProc.signalCode !== null);
|
||||||
|
if (
|
||||||
|
shouldStartServer({
|
||||||
|
up: this.up,
|
||||||
|
hasClient: this.opencodeClient != null,
|
||||||
|
serverStarting: this.serverStarting != null,
|
||||||
|
childDead,
|
||||||
|
startInFlight: this.startInFlight,
|
||||||
|
})
|
||||||
|
) {
|
||||||
|
this.serverStarting = this.startServer();
|
||||||
|
}
|
||||||
|
return this.serverStarting ?? Promise.resolve();
|
||||||
|
}
|
||||||
|
|
||||||
|
private async startServer(): Promise<void> {
|
||||||
|
// Set synchronously (before the first await) so a concurrent ensureServer sees
|
||||||
|
// the in-flight start and joins `serverStarting` instead of double-spawning.
|
||||||
|
this.startInFlight = true;
|
||||||
|
try {
|
||||||
|
const port = await freePort();
|
||||||
|
|
||||||
|
// Phase 1: run unsecured on loopback (opencode's documented default — serve.ts
|
||||||
|
// only WARNS when OPENCODE_SERVER_PASSWORD is unset). The real boundary is the
|
||||||
|
// 127.0.0.1 bind.
|
||||||
|
const child = spawn(this.opencodeBinary, ['serve', '--hostname', '127.0.0.1', '--port', String(port)], {
|
||||||
|
stdio: ['ignore', 'pipe', 'pipe'],
|
||||||
|
env: { ...process.env },
|
||||||
|
});
|
||||||
|
this.childProc = child;
|
||||||
|
this.serverPort = port;
|
||||||
|
|
||||||
|
// Child lifetime is the backend's (the pool's), NOT a request's. On unexpected
|
||||||
|
// exit we recover: settle in-flight turns, mark sessions crashed (the backend's
|
||||||
|
// onServerDown), reclaim the port, and reset state so the next ensureServer
|
||||||
|
// re-spawns.
|
||||||
|
child.on('exit', (code, signal) => {
|
||||||
|
// Only react to THIS child's exit (a restart may have swapped in a new one).
|
||||||
|
if (this.childProc !== child) return;
|
||||||
|
this.handleCrash(code, signal, port);
|
||||||
|
});
|
||||||
|
|
||||||
|
await waitForReady(child, READY_TIMEOUT_MS);
|
||||||
|
|
||||||
|
this.opencodeClient = createOpencodeClient({ baseUrl: `http://127.0.0.1:${port}` });
|
||||||
|
this.up = true;
|
||||||
|
this.log.info({ port }, 'opencode-server: ready');
|
||||||
|
} finally {
|
||||||
|
this.startInFlight = false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Server down (crash-exit or forced restart): reset process/port state, delegate
|
||||||
|
* session-level recovery to the backend, and reclaim the port. Mirrors the
|
||||||
|
* original `handleServerCrash` ordering (up=false → session cleanup → client/
|
||||||
|
* serverStarting null → reclaimPort).
|
||||||
|
*/
|
||||||
|
private handleCrash(code: number | null, signal: NodeJS.Signals | null, port: number): void {
|
||||||
|
this.up = false;
|
||||||
|
this.hooks.onServerDown({ code, signal, port });
|
||||||
|
this.opencodeClient = null;
|
||||||
|
this.serverStarting = null; // force a re-spawn on the next ensureServer
|
||||||
|
// Reclaim the port so a re-spawn on a fixed/leaked port isn't blocked. Best
|
||||||
|
// effort; the next start uses a fresh ephemeral port anyway.
|
||||||
|
reclaimPort(port);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Phase 3 proactive health monitor (openchamber `runHealthCheckCycle` lift,
|
||||||
|
* busy-aware). Probes /global/health; on a sustained failure of a NON-busy server,
|
||||||
|
* force a restart so the next turn isn't blocked by a wedged process. Busy servers
|
||||||
|
* are deferred via the stale-grace in `decideRestart`. No-op when never started or
|
||||||
|
* a restart is already in flight.
|
||||||
|
*/
|
||||||
|
async tickHealth(now: number = Date.now()): Promise<void> {
|
||||||
|
if (!this.childProc || this.restarting) return;
|
||||||
|
const childExited = this.childProc.exitCode !== null || this.childProc.signalCode !== null;
|
||||||
|
// An exited child is recovered lazily by ensureServer; don't double-restart it.
|
||||||
|
if (childExited) return;
|
||||||
|
|
||||||
|
const healthy = await this.probeHealth();
|
||||||
|
if (healthy) {
|
||||||
|
this.consecutiveHealthFailures = 0;
|
||||||
|
this.unhealthyBusySince = 0;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
this.consecutiveHealthFailures += 1;
|
||||||
|
const busy = this.hooks.isBusy();
|
||||||
|
const decision = decideRestart({
|
||||||
|
processExited: false,
|
||||||
|
consecutiveFailures: this.consecutiveHealthFailures,
|
||||||
|
busy,
|
||||||
|
unhealthyBusySince: this.unhealthyBusySince,
|
||||||
|
now,
|
||||||
|
failureThreshold: DEFAULT_HEALTH_FAILURE_THRESHOLD,
|
||||||
|
});
|
||||||
|
// Stamp the start of an unhealthy-while-busy window so the stale-grace can fire.
|
||||||
|
if (busy && this.unhealthyBusySince === 0) this.unhealthyBusySince = now;
|
||||||
|
if (decision.action === 'restart') {
|
||||||
|
this.log.warn(
|
||||||
|
{ failures: this.consecutiveHealthFailures, busy, reason: decision.reason },
|
||||||
|
'opencode-server: health monitor forcing restart',
|
||||||
|
);
|
||||||
|
this.consecutiveHealthFailures = 0;
|
||||||
|
this.unhealthyBusySince = 0;
|
||||||
|
await this.restartServer();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private async probeHealth(): Promise<boolean> {
|
||||||
|
if (!this.opencodeClient) return false;
|
||||||
|
try {
|
||||||
|
const res = await this.opencodeClient.global.health();
|
||||||
|
return !res.error;
|
||||||
|
} catch {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Force-kill the current server + reclaim its port; the next ensureServer
|
||||||
|
* re-spawns (lazy). Mirrors handleCrash's state reset but is initiated by the
|
||||||
|
* health monitor rather than the OS. */
|
||||||
|
private async restartServer(): Promise<void> {
|
||||||
|
if (this.restarting) return this.restarting;
|
||||||
|
this.restarting = (async () => {
|
||||||
|
const child = this.childProc;
|
||||||
|
const port = this.serverPort;
|
||||||
|
this.up = false;
|
||||||
|
// Fail in-flight turns + mark sessions crashed via the same path as a crash.
|
||||||
|
if (child) {
|
||||||
|
this.handleCrash(null, null, port ?? 0);
|
||||||
|
if (!child.killed) child.kill('SIGTERM');
|
||||||
|
}
|
||||||
|
if (port) {
|
||||||
|
reclaimPort(port);
|
||||||
|
await waitForPortRelease(port, 3_000);
|
||||||
|
}
|
||||||
|
this.childProc = null;
|
||||||
|
})().finally(() => {
|
||||||
|
this.restarting = null;
|
||||||
|
});
|
||||||
|
return this.restarting;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Full teardown of the child + client + port state. */
|
||||||
|
async dispose(): Promise<void> {
|
||||||
|
this.up = false;
|
||||||
|
const child = this.childProc;
|
||||||
|
this.childProc = null;
|
||||||
|
this.opencodeClient = null;
|
||||||
|
if (child && !child.killed) {
|
||||||
|
child.kill('SIGTERM');
|
||||||
|
const t = setTimeout(() => {
|
||||||
|
if (!child.killed) child.kill('SIGKILL');
|
||||||
|
}, 5_000);
|
||||||
|
t.unref();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Resolve when the child prints the ready line; reject on timeout or early exit. */
|
||||||
|
function waitForReady(child: ChildProcess, timeoutMs: number): Promise<void> {
|
||||||
|
return new Promise((resolve, reject) => {
|
||||||
|
let done = false;
|
||||||
|
let stderrBuf = '';
|
||||||
|
|
||||||
|
const finish = (err?: Error) => {
|
||||||
|
if (done) return;
|
||||||
|
done = true;
|
||||||
|
clearTimeout(timer);
|
||||||
|
child.stdout?.off('data', onOut);
|
||||||
|
child.stderr?.off('data', onErr);
|
||||||
|
child.off('exit', onExit);
|
||||||
|
if (err) reject(err);
|
||||||
|
else resolve();
|
||||||
|
};
|
||||||
|
|
||||||
|
const onOut = (buf: Buffer) => {
|
||||||
|
if (buf.toString().includes('opencode server listening on')) finish();
|
||||||
|
};
|
||||||
|
const onErr = (buf: Buffer) => {
|
||||||
|
stderrBuf += buf.toString();
|
||||||
|
};
|
||||||
|
const onExit = (code: number | null) =>
|
||||||
|
finish(new Error(`opencode serve exited before ready (code ${code}); stderr: ${stderrBuf.slice(-2000)}`));
|
||||||
|
const timer = setTimeout(
|
||||||
|
() => finish(new Error(`opencode serve not ready in ${timeoutMs}ms; stderr: ${stderrBuf.slice(-2000)}`)),
|
||||||
|
timeoutMs,
|
||||||
|
);
|
||||||
|
|
||||||
|
child.stdout?.on('data', onOut);
|
||||||
|
child.stderr?.on('data', onErr);
|
||||||
|
child.on('exit', onExit);
|
||||||
|
});
|
||||||
|
}
|
||||||
@@ -1,91 +1,64 @@
|
|||||||
/**
|
/**
|
||||||
* v2.6 Phase 1 — OpenCodeServerBackend.
|
* v2.6 Phase 1 — OpenCodeServerBackend (slimmed, v2.7 audit reshape).
|
||||||
*
|
*
|
||||||
* Warm, multi-turn backend for the `opencode` agent. One `opencode serve` HTTP
|
* Warm, multi-turn backend for the `opencode` agent. One `opencode serve` HTTP
|
||||||
* server per BooCoder process; one opencode session per BooCode session (resumed
|
* server per BooCoder process; one opencode session per BooCode session (resumed
|
||||||
* on switch-back); one SSE read loop PER session, each scoped to that session's
|
* on switch-back); one SSE read loop PER session, each scoped to that session's
|
||||||
* worktree directory so sessions in different directories stream concurrently
|
* worktree directory so sessions in different directories stream concurrently.
|
||||||
* (P1.5-a — replaced the Phase-1 single-stream-last-directory model).
|
*
|
||||||
|
* This file is now just the `AgentBackend` SURFACE — ensureSession / prompt /
|
||||||
|
* accumulateUsage / closeSession + the per-session demux side effects (watchdog,
|
||||||
|
* reconcile, usage). It composes three extracted collaborators:
|
||||||
|
* - `OpenCodeServerSupervisor` (opencode-server-process.ts) — child/client/port/
|
||||||
|
* health lifecycle, spawn/crash/restart/dispose.
|
||||||
|
* - the per-session SSE loop (opencode-sse.ts) — subscribe + reconnect/backoff.
|
||||||
|
* - the pure event map (opencode-event-map.ts) — Event → AgentEvent translation,
|
||||||
|
* dedup gate, dcp-strip, tool-snapshot.
|
||||||
*
|
*
|
||||||
* Implements the Phase 0 `AgentBackend` interface. Emits transport-agnostic
|
* Implements the Phase 0 `AgentBackend` interface. Emits transport-agnostic
|
||||||
* `AgentEvent`s — the dispatcher (Phase 1.7, NOT wired in this batch) maps them
|
* `AgentEvent`s; the dispatcher maps them to WS frames.
|
||||||
* to WS frames. No dispatcher/route references this file yet.
|
|
||||||
*
|
*
|
||||||
* Spec: openspec/changes/v2-6-persistent-agent-sessions/design.md §2 / §2a.
|
* Spec: openspec/changes/v2-6-persistent-agent-sessions/design.md §2 / §2a.
|
||||||
* SDK shapes verified by direct read of @opencode-ai/sdk@1.15.12 dist .d.ts:
|
|
||||||
* - client methods take FLATTENED params (sessionID/directory/body all inline),
|
|
||||||
* not {path,query,body}. create→{directory}, promptAsync→{sessionID,directory,
|
|
||||||
* parts,model}, abort→{sessionID,directory}. model is {providerID,modelID}.
|
|
||||||
* - client.event() resolves to { stream: AsyncGenerator<GlobalEvent> }; the
|
|
||||||
* real event is chunk.payload (discriminate on chunk.payload.type).
|
|
||||||
* - promptAsync is fire-and-forget (204); the turn completes via a
|
|
||||||
* 'session.idle' event for that opencode session id.
|
|
||||||
*/
|
*/
|
||||||
import { spawn, spawnSync, type ChildProcess } from 'node:child_process';
|
|
||||||
import { createHash } from 'node:crypto';
|
import { createHash } from 'node:crypto';
|
||||||
import { createServer, connect as netConnect } from 'node:net';
|
|
||||||
import type { FastifyBaseLogger } from 'fastify';
|
import type { FastifyBaseLogger } from 'fastify';
|
||||||
import {
|
import type { Event, AssistantMessage } from '@opencode-ai/sdk/v2/client';
|
||||||
createOpencodeClient,
|
|
||||||
type OpencodeClient,
|
|
||||||
type Event,
|
|
||||||
type Part,
|
|
||||||
type ToolPart,
|
|
||||||
type ToolState,
|
|
||||||
type AssistantMessage,
|
|
||||||
} from '@opencode-ai/sdk/v2/client';
|
|
||||||
import type { ToolCallStatus } from '@agentclientprotocol/sdk';
|
|
||||||
import type { Sql } from '../../db.js';
|
import type { Sql } from '../../db.js';
|
||||||
import type { AcpToolSnapshot } from '../acp-tool-snapshot.js';
|
|
||||||
import { armAbortGuard, noteTurnActivity, consumeTerminal } from './turn-guard.js';
|
import { armAbortGuard, noteTurnActivity, consumeTerminal } from './turn-guard.js';
|
||||||
import { stepEndedToUsage, type StepUsage } from './opencode-usage.js';
|
import { stepEndedToUsage, type StepUsage } from './opencode-usage.js';
|
||||||
import { decideRestart, DEFAULT_HEALTH_FAILURE_THRESHOLD } from './lifecycle-decisions.js';
|
import { OpenCodeServerSupervisor, type ServerDownInfo } from './opencode-server-process.js';
|
||||||
|
import {
|
||||||
|
startSessionEventLoop,
|
||||||
|
type SessionState,
|
||||||
|
type TurnState,
|
||||||
|
type SseLoopDeps,
|
||||||
|
} from './opencode-sse.js';
|
||||||
|
import {
|
||||||
|
classifyPartDelta,
|
||||||
|
classifyUpdatedPart,
|
||||||
|
toolCalledSnapshot,
|
||||||
|
toolSuccessSnapshot,
|
||||||
|
toolFailedSnapshot,
|
||||||
|
stripDcpTags,
|
||||||
|
errMsg,
|
||||||
|
errToString,
|
||||||
|
} from './opencode-event-map.js';
|
||||||
import type {
|
import type {
|
||||||
AgentBackend,
|
AgentBackend,
|
||||||
AgentEvent,
|
|
||||||
AgentSessionHandle,
|
AgentSessionHandle,
|
||||||
EnsureSessionOpts,
|
EnsureSessionOpts,
|
||||||
PromptCtx,
|
PromptCtx,
|
||||||
TurnResult,
|
TurnResult,
|
||||||
} from '../agent-backend.js';
|
} from '../agent-backend.js';
|
||||||
|
|
||||||
const READY_TIMEOUT_MS = 30_000;
|
|
||||||
const SSE_RECONNECT_DELAY_MS = 1_000;
|
|
||||||
/**
|
/**
|
||||||
* No-activity backstop for an in-flight turn. opencode streams reasoning/text/tool
|
* No-activity backstop for an in-flight turn. opencode streams reasoning/text/tool
|
||||||
* deltas continuously while working, so "zero events for this long" means the turn
|
* deltas continuously while working, so "zero events for this long" means the turn
|
||||||
* is wedged or its terminal event (session.idle) was lost (see the reconnect race
|
* is wedged or its terminal event (session.idle) was lost. Generous so a
|
||||||
* below). Generous so a legitimately slow turn never trips it.
|
* legitimately slow turn never trips it.
|
||||||
*/
|
*/
|
||||||
const TURN_INACTIVITY_MS = 180_000;
|
const TURN_INACTIVITY_MS = 180_000;
|
||||||
|
|
||||||
/** One in-flight turn's emitter + completion settler. */
|
|
||||||
interface TurnState {
|
|
||||||
onEvent: (e: AgentEvent) => void;
|
|
||||||
settle: (r: TurnResult) => void;
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Per-(opencode session) demux state. dedup sets scoped here, cleared per turn. */
|
|
||||||
interface SessionState {
|
|
||||||
boocodeSessionId: string;
|
|
||||||
agentSessionId: string;
|
|
||||||
/** Worktree directory for SDK `directory` routing; refreshed each turn from ctx. */
|
|
||||||
worktreePath: string;
|
|
||||||
/** dedup gate: `${type}:${id}` added on delta, deleted-and-tested on updated. Cleared at turn end. */
|
|
||||||
streamedPartKeys: Set<string>;
|
|
||||||
/** partID → 'text' | 'reasoning', so a delta with a non-'reasoning' field is still classed right. Cleared at turn end. */
|
|
||||||
partTypeById: Map<string, string>;
|
|
||||||
activeTurn: TurnState | null;
|
|
||||||
/** Inactivity backstop timer for the active turn; null when no turn in flight. */
|
|
||||||
watchdog: ReturnType<typeof setTimeout> | null;
|
|
||||||
/** Per-session SSE subscription handle. Non-null while the loop is running;
|
|
||||||
* aborting it tears down the underlying fetch and exits the loop. */
|
|
||||||
sseAbort: AbortController | null;
|
|
||||||
/** F.1 post-abort orphan-terminal guard: swallow the one session.idle/error
|
|
||||||
* opencode emits for an aborted turn so it can't settle the next turn. */
|
|
||||||
swallowNextTerminal: boolean;
|
|
||||||
}
|
|
||||||
|
|
||||||
export interface OpenCodeServerBackendDeps {
|
export interface OpenCodeServerBackendDeps {
|
||||||
sql: Sql;
|
sql: Sql;
|
||||||
log: FastifyBaseLogger;
|
log: FastifyBaseLogger;
|
||||||
@@ -98,36 +71,32 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
|
|
||||||
private readonly sql: Sql;
|
private readonly sql: Sql;
|
||||||
private readonly log: FastifyBaseLogger;
|
private readonly log: FastifyBaseLogger;
|
||||||
private readonly opencodeBinary: string;
|
private readonly supervisor: OpenCodeServerSupervisor;
|
||||||
|
|
||||||
private child: ChildProcess | null = null;
|
|
||||||
private client: OpencodeClient | null = null;
|
|
||||||
private port: number | null = null;
|
|
||||||
private up = false;
|
|
||||||
private serverStarting: Promise<void> | null = null;
|
|
||||||
// Phase 3 busy-aware health monitor (openchamber lift): consecutive failed
|
|
||||||
// probes + the start of an unhealthy-while-busy window feed `decideRestart`.
|
|
||||||
private consecutiveHealthFailures = 0;
|
|
||||||
private unhealthyBusySince = 0;
|
|
||||||
private restarting: Promise<void> | null = null;
|
|
||||||
|
|
||||||
/** opencode session id → demux state. Maintained by ensureSession; read by the SSE loop. */
|
/** opencode session id → demux state. Maintained by ensureSession; read by the SSE loop. */
|
||||||
private readonly byOpencodeId = new Map<string, SessionState>();
|
private readonly byOpencodeId = new Map<string, SessionState>();
|
||||||
|
/** Coalesces concurrent ensureSession calls for the same (chat, agent) key. */
|
||||||
|
private readonly ensuring = new Map<string, Promise<AgentSessionHandle>>();
|
||||||
|
|
||||||
constructor(deps: OpenCodeServerBackendDeps) {
|
constructor(deps: OpenCodeServerBackendDeps) {
|
||||||
this.sql = deps.sql;
|
this.sql = deps.sql;
|
||||||
this.log = deps.log;
|
this.log = deps.log;
|
||||||
this.opencodeBinary = deps.opencodeBinary;
|
this.supervisor = new OpenCodeServerSupervisor({
|
||||||
|
opencodeBinary: deps.opencodeBinary,
|
||||||
|
log: deps.log,
|
||||||
|
hooks: {
|
||||||
|
isBusy: () => this.isBusy(),
|
||||||
|
onServerDown: (info) => this.onServerDown(info),
|
||||||
|
},
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
/** §2: liveness for the health endpoint + dispatcher fallback decision. */
|
/** §2: liveness for the health endpoint + dispatcher fallback decision. */
|
||||||
health(): 'up' | 'down' {
|
health(): 'up' | 'down' {
|
||||||
return this.up ? 'up' : 'down';
|
return this.supervisor.health();
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Phase 3: busy iff ANY pooled opencode session has an in-flight turn. The
|
/** Phase 3: busy iff ANY pooled opencode session has an in-flight turn. */
|
||||||
* pool reads this to skip idle/LRU eviction and the health-monitor to defer a
|
|
||||||
* restart (never tear down a session mid-stream). */
|
|
||||||
isBusy(): boolean {
|
isBusy(): boolean {
|
||||||
for (const st of this.byOpencodeId.values()) {
|
for (const st of this.byOpencodeId.values()) {
|
||||||
if (st.activeTurn) return true;
|
if (st.activeTurn) return true;
|
||||||
@@ -135,72 +104,23 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
// ─── Server lifecycle (1.2: spawn once + client + ready; Phase 3 crash-restart) ──
|
/** Phase 3 proactive health probe + busy-aware self-restart, run by the pool's
|
||||||
|
* periodic sweep. Delegates to the supervisor. */
|
||||||
/**
|
async tickHealth(now: number = Date.now()): Promise<void> {
|
||||||
* Lazy: start the single server on first use; re-spawn after a crash. Idempotent
|
await this.supervisor.tickHealth(now);
|
||||||
* within one live server — `serverStarting` caches the in-flight start, and is
|
|
||||||
* reset to null by the crash handler so the NEXT ensureServer re-spawns a fresh
|
|
||||||
* server (Phase 3 crash recovery). A dead-but-not-yet-reaped child (exit handler
|
|
||||||
* raced) is also treated as needing a restart.
|
|
||||||
*/
|
|
||||||
private ensureServer(): Promise<void> {
|
|
||||||
const childDead = this.child != null && (this.child.exitCode !== null || this.child.signalCode !== null);
|
|
||||||
if (!this.serverStarting || (!this.up && childDead)) {
|
|
||||||
this.serverStarting = this.startServer();
|
|
||||||
}
|
|
||||||
return this.serverStarting;
|
|
||||||
}
|
|
||||||
|
|
||||||
private async startServer(): Promise<void> {
|
|
||||||
const port = await freePort();
|
|
||||||
|
|
||||||
// Phase 1: run unsecured on loopback (opencode's documented default — serve.ts
|
|
||||||
// only WARNS when OPENCODE_SERVER_PASSWORD is unset). The real boundary is the
|
|
||||||
// 127.0.0.1 bind. Defense-in-depth basic-auth is deferred: the hey-api client's
|
|
||||||
// auth wiring + opencode's exact scheme must be confirmed against a live server
|
|
||||||
// first, else every request 401s. Recon explicitly said "do NOT block on it".
|
|
||||||
const child = spawn(this.opencodeBinary, ['serve', '--hostname', '127.0.0.1', '--port', String(port)], {
|
|
||||||
stdio: ['ignore', 'pipe', 'pipe'],
|
|
||||||
env: { ...process.env },
|
|
||||||
});
|
|
||||||
this.child = child;
|
|
||||||
this.port = port;
|
|
||||||
|
|
||||||
// Child lifetime is the backend's (the pool's), NOT a request's. We never tie
|
|
||||||
// it to a per-turn abort signal. Phase 3: on unexpected exit we recover —
|
|
||||||
// settle any in-flight turns as failed, mark their agent_sessions rows crashed,
|
|
||||||
// and reset `serverStarting` so the next ensureServer re-spawns. opencode keeps
|
|
||||||
// sessions on disk, but a fresh server's in-memory state is gone, so the next
|
|
||||||
// turn's ensureSession (rows now 'crashed') creates fresh opencode sessions.
|
|
||||||
child.on('exit', (code, signal) => {
|
|
||||||
// Only react to THIS child's exit (a restart may have swapped in a new one).
|
|
||||||
if (this.child !== child) return;
|
|
||||||
this.handleServerCrash(code, signal, port);
|
|
||||||
});
|
|
||||||
|
|
||||||
await waitForReady(child, READY_TIMEOUT_MS);
|
|
||||||
|
|
||||||
this.client = createOpencodeClient({ baseUrl: `http://127.0.0.1:${port}` });
|
|
||||||
this.up = true;
|
|
||||||
this.log.info({ port }, 'opencode-server: ready');
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Crash handler (Phase 3, lift of openchamber's restart-on-exit path). The
|
* Server down (crash-exit or forced restart): fail every in-flight turn so its
|
||||||
* server died with N live opencode sessions; we can't restart it here (the next
|
* dispatcher unblocks, mark each session crashed so ensureSession won't resume a
|
||||||
* turn does, lazily — avoids a restart storm if the binary is broken). We:
|
* now-dead native id, and tear down the SSE loops + demux state. Invoked by the
|
||||||
* 1. fail every in-flight turn so its dispatcher unblocks + publishes an error,
|
* supervisor (it owns the process/port reset). Mirrors the original
|
||||||
* 2. mark each session's agent_sessions row 'crashed' so ensureSession won't
|
* handleServerCrash session-half byte-for-byte.
|
||||||
* resume a now-dead native session id (it creates fresh),
|
|
||||||
* 3. tear down the SSE loops + demux state (stale against the dead server),
|
|
||||||
* 4. reclaim the port + reset state so the next ensureServer re-spawns.
|
|
||||||
*/
|
*/
|
||||||
private handleServerCrash(code: number | null, signal: NodeJS.Signals | null, port: number): void {
|
private onServerDown(info: ServerDownInfo): void {
|
||||||
this.up = false;
|
|
||||||
const states = [...this.byOpencodeId.values()];
|
const states = [...this.byOpencodeId.values()];
|
||||||
this.log.warn(
|
this.log.warn(
|
||||||
{ code, signal, port, liveSessions: states.length },
|
{ code: info.code, signal: info.signal, port: info.port, liveSessions: states.length },
|
||||||
'opencode-server: child exited — recovering (fail in-flight, mark crashed, re-spawn next turn)',
|
'opencode-server: child exited — recovering (fail in-flight, mark crashed, re-spawn next turn)',
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -219,8 +139,6 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
}
|
}
|
||||||
// Drop the demux map: every session id is stale against a fresh server.
|
// Drop the demux map: every session id is stale against a fresh server.
|
||||||
this.byOpencodeId.clear();
|
this.byOpencodeId.clear();
|
||||||
this.client = null;
|
|
||||||
this.serverStarting = null; // force a re-spawn on the next ensureServer
|
|
||||||
|
|
||||||
if (crashedIds.length > 0) {
|
if (crashedIds.length > 0) {
|
||||||
this.sql`
|
this.sql`
|
||||||
@@ -230,146 +148,20 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
this.log.warn({ err: errMsg(err) }, 'opencode-server: failed to mark crashed sessions (non-fatal)');
|
this.log.warn({ err: errMsg(err) }, 'opencode-server: failed to mark crashed sessions (non-fatal)');
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
// Reclaim the port so a re-spawn on a fixed/leaked port isn't blocked. Best
|
|
||||||
// effort; the next start uses a fresh ephemeral port anyway.
|
|
||||||
reclaimPort(port);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
// ─── SSE loop wiring ─────────────────────────────────────────────────────────
|
||||||
* Phase 3 proactive health monitor (openchamber `runHealthCheckCycle` lift,
|
|
||||||
* busy-aware). Probes the server's /global/health; on a sustained failure of a
|
|
||||||
* NON-busy server, force a restart so the next turn isn't blocked by a wedged
|
|
||||||
* (hung-but-not-exited) process. Busy servers are deferred via the stale-grace in
|
|
||||||
* `decideRestart` — never tear down live work. Driven by the pool's periodic
|
|
||||||
* sweep (best-effort; a crash-exit is already handled by `handleServerCrash` +
|
|
||||||
* lazy `ensureServer` re-spawn, so this only catches the hung case). No-op when
|
|
||||||
* the server was never started or a restart is already in flight.
|
|
||||||
*/
|
|
||||||
async tickHealth(now: number = Date.now()): Promise<void> {
|
|
||||||
if (!this.child || this.restarting) return;
|
|
||||||
const childExited = this.child.exitCode !== null || this.child.signalCode !== null;
|
|
||||||
// An exited child is recovered lazily by ensureServer; don't double-restart it.
|
|
||||||
if (childExited) return;
|
|
||||||
|
|
||||||
const healthy = await this.probeHealth();
|
/** The dependency bundle the per-session SSE loop reads. */
|
||||||
if (healthy) {
|
private sseDeps(): SseLoopDeps {
|
||||||
this.consecutiveHealthFailures = 0;
|
return {
|
||||||
this.unhealthyBusySince = 0;
|
isUp: () => this.supervisor.isUp(),
|
||||||
return;
|
getClient: () => this.supervisor.client,
|
||||||
}
|
dispatchEvent: (ev) => this.dispatchEvent(ev),
|
||||||
this.consecutiveHealthFailures += 1;
|
reconcile: (st) => this.reconcile(st),
|
||||||
const busy = this.isBusy();
|
onReconnectGiveUp: (st) => this.onReconnectGiveUp(st),
|
||||||
const decision = decideRestart({
|
log: this.log,
|
||||||
processExited: false,
|
};
|
||||||
consecutiveFailures: this.consecutiveHealthFailures,
|
|
||||||
busy,
|
|
||||||
unhealthyBusySince: this.unhealthyBusySince,
|
|
||||||
now,
|
|
||||||
failureThreshold: DEFAULT_HEALTH_FAILURE_THRESHOLD,
|
|
||||||
});
|
|
||||||
// Stamp the start of an unhealthy-while-busy window so the stale-grace can fire.
|
|
||||||
if (busy && this.unhealthyBusySince === 0) this.unhealthyBusySince = now;
|
|
||||||
if (decision.action === 'restart') {
|
|
||||||
this.log.warn(
|
|
||||||
{ failures: this.consecutiveHealthFailures, busy, reason: decision.reason },
|
|
||||||
'opencode-server: health monitor forcing restart',
|
|
||||||
);
|
|
||||||
this.consecutiveHealthFailures = 0;
|
|
||||||
this.unhealthyBusySince = 0;
|
|
||||||
await this.restartServer();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
private async probeHealth(): Promise<boolean> {
|
|
||||||
if (!this.client) return false;
|
|
||||||
try {
|
|
||||||
const res = await this.client.global.health();
|
|
||||||
return !res.error;
|
|
||||||
} catch {
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Force-kill the current server + reclaim its port; the next ensureServer
|
|
||||||
* re-spawns (lazy). Mirrors handleServerCrash's state reset but is initiated by
|
|
||||||
* the health monitor rather than the OS. */
|
|
||||||
private async restartServer(): Promise<void> {
|
|
||||||
if (this.restarting) return this.restarting;
|
|
||||||
this.restarting = (async () => {
|
|
||||||
const child = this.child;
|
|
||||||
const port = this.port;
|
|
||||||
this.up = false;
|
|
||||||
// Fail in-flight turns + mark sessions crashed via the same path as a crash.
|
|
||||||
if (child) {
|
|
||||||
this.handleServerCrash(null, null, port ?? 0);
|
|
||||||
if (!child.killed) child.kill('SIGTERM');
|
|
||||||
}
|
|
||||||
if (port) {
|
|
||||||
reclaimPort(port);
|
|
||||||
await waitForPortRelease(port, 3_000);
|
|
||||||
}
|
|
||||||
this.child = null;
|
|
||||||
})().finally(() => {
|
|
||||||
this.restarting = null;
|
|
||||||
});
|
|
||||||
return this.restarting;
|
|
||||||
}
|
|
||||||
|
|
||||||
// ─── SSE read loop + demux + translate (1.3) + dedup (1.4) ───────────────────
|
|
||||||
|
|
||||||
/** Per-session SSE subscription, scoped to the session's worktree directory.
|
|
||||||
* opencode scopes events by the `directory` query param (defaults to the
|
|
||||||
* server's cwd if omitted), so two sessions in different worktrees each get
|
|
||||||
* their own dir-scoped stream and never drop each other's events. Idempotent:
|
|
||||||
* a no-op if this session's loop is already running. Started from ensureSession
|
|
||||||
* (and defensively from prompt) once worktreePath is known. */
|
|
||||||
private startSessionEventLoop(state: SessionState): void {
|
|
||||||
if (state.sseAbort) return; // already running
|
|
||||||
const abort = new AbortController();
|
|
||||||
state.sseAbort = abort;
|
|
||||||
void this.runSessionEventLoop(state, abort).finally(() => {
|
|
||||||
// Only clear if this controller is still the live one (a later restart may
|
|
||||||
// have already installed a new one).
|
|
||||||
if (state.sseAbort === abort) state.sseAbort = null;
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
private async runSessionEventLoop(state: SessionState, abort: AbortController): Promise<void> {
|
|
||||||
const signal = abort.signal;
|
|
||||||
while (this.up && this.client && !signal.aborted) {
|
|
||||||
try {
|
|
||||||
// Re-read worktreePath each (re)subscribe so a directory refresh is picked
|
|
||||||
// up on reconnect. Passing `signal` lets close/dispose tear down a stream
|
|
||||||
// that's parked in `for await` between events.
|
|
||||||
const sub = await this.client.event.subscribe(
|
|
||||||
{ directory: state.worktreePath },
|
|
||||||
{ signal },
|
|
||||||
);
|
|
||||||
for await (const ev of sub.stream) {
|
|
||||||
if (signal.aborted) break;
|
|
||||||
// Dir-scoped streams should only carry this session's events, but two
|
|
||||||
// sessions sharing a worktree (possible post-P1.5-b) each receive BOTH
|
|
||||||
// sessions' events — so drop anything that isn't ours, else the other
|
|
||||||
// session's deltas get processed twice (once per loop).
|
|
||||||
const sid = eventSessionId(ev);
|
|
||||||
if (sid != null && sid !== state.agentSessionId) continue;
|
|
||||||
this.dispatchEvent(ev);
|
|
||||||
}
|
|
||||||
if (this.up && !signal.aborted) {
|
|
||||||
await this.reconcile(state); // recover an idle/error lost during the gap
|
|
||||||
await sleep(SSE_RECONNECT_DELAY_MS);
|
|
||||||
}
|
|
||||||
} catch (err) {
|
|
||||||
if (!this.up || signal.aborted) break;
|
|
||||||
this.log.warn(
|
|
||||||
{ err: errMsg(err), agentSessionId: state.agentSessionId },
|
|
||||||
'opencode-server: session event loop error; reconnecting',
|
|
||||||
);
|
|
||||||
await this.reconcile(state);
|
|
||||||
await sleep(SSE_RECONNECT_DELAY_MS);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Demux one event to the owning session's active turn. Unknown/between-turns → drop. */
|
/** Demux one event to the owning session's active turn. Unknown/between-turns → drop. */
|
||||||
@@ -398,15 +190,7 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
const st = this.byOpencodeId.get(p.sessionID);
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
if (!st?.activeTurn) return;
|
if (!st?.activeTurn) return;
|
||||||
this.bumpActivity(st);
|
this.bumpActivity(st);
|
||||||
const snap: AcpToolSnapshot = {
|
st.activeTurn.onEvent({ type: 'tool_call', toolCall: toolCalledSnapshot(p) });
|
||||||
toolCallId: p.callID,
|
|
||||||
title: p.tool,
|
|
||||||
kind: null,
|
|
||||||
status: 'in_progress',
|
|
||||||
rawInput: p.input,
|
|
||||||
rawOutput: undefined,
|
|
||||||
};
|
|
||||||
st.activeTurn.onEvent({ type: 'tool_call', toolCall: snap });
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
case 'session.next.tool.success': {
|
case 'session.next.tool.success': {
|
||||||
@@ -414,16 +198,7 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
const st = this.byOpencodeId.get(p.sessionID);
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
if (!st?.activeTurn) return;
|
if (!st?.activeTurn) return;
|
||||||
this.bumpActivity(st);
|
this.bumpActivity(st);
|
||||||
const output = p.content?.map((c) => ('text' in c ? (c as { text: string }).text : '')).join('') ?? '';
|
st.activeTurn.onEvent({ type: 'tool_update', toolCall: toolSuccessSnapshot(p) });
|
||||||
const snap: AcpToolSnapshot = {
|
|
||||||
toolCallId: p.callID,
|
|
||||||
title: p.callID,
|
|
||||||
kind: null,
|
|
||||||
status: 'completed',
|
|
||||||
rawInput: undefined,
|
|
||||||
rawOutput: output,
|
|
||||||
};
|
|
||||||
st.activeTurn.onEvent({ type: 'tool_update', toolCall: snap });
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
case 'session.next.tool.failed': {
|
case 'session.next.tool.failed': {
|
||||||
@@ -431,15 +206,7 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
const st = this.byOpencodeId.get(p.sessionID);
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
if (!st?.activeTurn) return;
|
if (!st?.activeTurn) return;
|
||||||
this.bumpActivity(st);
|
this.bumpActivity(st);
|
||||||
const snap: AcpToolSnapshot = {
|
st.activeTurn.onEvent({ type: 'tool_update', toolCall: toolFailedSnapshot(p) });
|
||||||
toolCallId: p.callID,
|
|
||||||
title: p.callID,
|
|
||||||
kind: null,
|
|
||||||
status: 'failed',
|
|
||||||
rawInput: undefined,
|
|
||||||
rawOutput: errToString(p.error),
|
|
||||||
};
|
|
||||||
st.activeTurn.onEvent({ type: 'tool_update', toolCall: snap });
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
// ─── per-step usage (U.6) — token/cost accounting for opencode sessions ──
|
// ─── per-step usage (U.6) — token/cost accounting for opencode sessions ──
|
||||||
@@ -449,8 +216,7 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
if (!st?.activeTurn) return;
|
if (!st?.activeTurn) return;
|
||||||
this.bumpActivity(st);
|
this.bumpActivity(st);
|
||||||
// Accumulate this step's normalized usage onto the (chat_id, agent) row.
|
// Accumulate this step's normalized usage onto the (chat_id, agent) row.
|
||||||
// Fire-and-forget: a DB hiccup must not stall the turn. opencode emits this
|
// Fire-and-forget: a DB hiccup must not stall the turn.
|
||||||
// once per LLM step, so a multi-tool turn sums several deltas.
|
|
||||||
const usage = stepEndedToUsage(p);
|
const usage = stepEndedToUsage(p);
|
||||||
void this.accumulateUsage(st, usage);
|
void this.accumulateUsage(st, usage);
|
||||||
return;
|
return;
|
||||||
@@ -461,15 +227,8 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
const st = this.byOpencodeId.get(p.sessionID);
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
if (!st?.activeTurn) return;
|
if (!st?.activeTurn) return;
|
||||||
this.bumpActivity(st);
|
this.bumpActivity(st);
|
||||||
const isReasoning = p.field === 'reasoning' || st.partTypeById.get(p.partID) === 'reasoning';
|
const e = classifyPartDelta(p, st);
|
||||||
if (isReasoning) {
|
if (e) st.activeTurn.onEvent(e);
|
||||||
st.streamedPartKeys.add(`reasoning:${p.partID}`);
|
|
||||||
st.activeTurn.onEvent({ type: 'reasoning', text: p.delta });
|
|
||||||
} else if (p.field === 'text') {
|
|
||||||
st.streamedPartKeys.add(`text:${p.partID}`);
|
|
||||||
const cleaned = stripDcpTags(p.delta);
|
|
||||||
if (cleaned) st.activeTurn.onEvent({ type: 'text', text: cleaned });
|
|
||||||
}
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
case 'message.part.updated': {
|
case 'message.part.updated': {
|
||||||
@@ -477,7 +236,8 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
const st = this.byOpencodeId.get(part.sessionID);
|
const st = this.byOpencodeId.get(part.sessionID);
|
||||||
if (!st?.activeTurn) return;
|
if (!st?.activeTurn) return;
|
||||||
this.bumpActivity(st);
|
this.bumpActivity(st);
|
||||||
this.handleUpdatedPart(part, st);
|
const e = classifyUpdatedPart(part, st);
|
||||||
|
if (e) st.activeTurn.onEvent(e);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
// ─── lifecycle ─────────────────────────────────────────────────────────
|
// ─── lifecycle ─────────────────────────────────────────────────────────
|
||||||
@@ -502,40 +262,6 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Terminal part: dedup gate for text/reasoning; tool parts → tool_call/tool_update. */
|
|
||||||
private handleUpdatedPart(part: Part, st: SessionState): void {
|
|
||||||
const turn = st.activeTurn;
|
|
||||||
if (!turn) return;
|
|
||||||
|
|
||||||
if (part.type === 'text' || part.type === 'reasoning') {
|
|
||||||
st.partTypeById.set(part.id, part.type);
|
|
||||||
const key = resolvePartDedupeKey(part, part.type);
|
|
||||||
if (key && st.streamedPartKeys.delete(key)) return; // already streamed via delta
|
|
||||||
const raw = part.text ?? '';
|
|
||||||
const text = part.type === 'text' ? stripDcpTags(raw) : raw;
|
|
||||||
if (text && part.time?.end != null) {
|
|
||||||
turn.onEvent({ type: part.type, text });
|
|
||||||
}
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (part.type === 'tool') {
|
|
||||||
const snap = toolPartToSnapshot(part);
|
|
||||||
const status = part.state?.status;
|
|
||||||
// tool_call on start (pending/running), tool_update on terminal (completed/error).
|
|
||||||
// The current ACP path merges both into one frame; the contract keeps them
|
|
||||||
// distinct because opencode's SSE distinguishes start from result.
|
|
||||||
const event: AgentEvent =
|
|
||||||
status === 'completed' || status === 'error'
|
|
||||||
? { type: 'tool_update', toolCall: snap }
|
|
||||||
: { type: 'tool_call', toolCall: snap };
|
|
||||||
turn.onEvent(event);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
// NOTE: opencode's SSE payload union carries no available-commands event, so the
|
|
||||||
// AgentEvent 'commands' arm is intentionally never emitted here (1.3).
|
|
||||||
}
|
|
||||||
|
|
||||||
// ─── turn-completion resilience (watchdog + reconnect reconcile) ─────────────
|
// ─── turn-completion resilience (watchdog + reconnect reconcile) ─────────────
|
||||||
|
|
||||||
/** Reset the inactivity backstop on any event routed to a session's active turn. */
|
/** Reset the inactivity backstop on any event routed to a session's active turn. */
|
||||||
@@ -550,8 +276,8 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
st.watchdog.unref?.();
|
st.watchdog.unref?.();
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Watchdog fired: reconcile once; if the server says still-running we can't tell, so fail closed.
|
/** Watchdog fired: reconcile once; if still-running we can't tell, so fail closed.
|
||||||
* Also mark the agent_sessions row crashed so a stale session isn't resumed next turn. */
|
* Also mark the agent_sessions row crashed so a stale session isn't resumed. */
|
||||||
private async onTurnStall(st: SessionState): Promise<void> {
|
private async onTurnStall(st: SessionState): Promise<void> {
|
||||||
const settled = await this.reconcile(st);
|
const settled = await this.reconcile(st);
|
||||||
if (!settled) {
|
if (!settled) {
|
||||||
@@ -564,16 +290,27 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** SSE circuit-breaker fired (reconnect gave up): fail the active turn + mark the
|
||||||
|
* session crashed so it isn't resumed. The next turn re-creates a fresh session. */
|
||||||
|
private async onReconnectGiveUp(st: SessionState): Promise<void> {
|
||||||
|
if (!st.activeTurn) return;
|
||||||
|
await this.sql`
|
||||||
|
UPDATE agent_sessions SET status = 'crashed'
|
||||||
|
WHERE agent_session_id = ${st.agentSessionId}
|
||||||
|
`.catch(() => {});
|
||||||
|
st.activeTurn?.settle({ ok: false, error: 'opencode SSE stream lost (reconnect gave up)' });
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Ask the server whether this session's turn already finished — recovers a
|
* Ask the server whether this session's turn already finished — recovers a
|
||||||
* session.idle/error lost during an SSE gap. Returns true if it settled the turn.
|
* session.idle/error lost during an SSE gap. Returns true if it settled the turn.
|
||||||
* Inconclusive (still running / call failed) → false; the watchdog covers that.
|
|
||||||
*/
|
*/
|
||||||
private async reconcile(st: SessionState): Promise<boolean> {
|
private async reconcile(st: SessionState): Promise<boolean> {
|
||||||
const turn = st.activeTurn;
|
const turn = st.activeTurn;
|
||||||
if (!turn || !this.client) return false;
|
const client = this.supervisor.client;
|
||||||
|
if (!turn || !client) return false;
|
||||||
try {
|
try {
|
||||||
const res = await this.client.session.messages({
|
const res = await client.session.messages({
|
||||||
sessionID: st.agentSessionId,
|
sessionID: st.agentSessionId,
|
||||||
directory: st.worktreePath,
|
directory: st.worktreePath,
|
||||||
});
|
});
|
||||||
@@ -605,10 +342,8 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* Accumulate one `session.next.step.ended`'s normalized usage onto the session's
|
* Accumulate one `session.next.step.ended`'s normalized usage onto the session's
|
||||||
* agent_sessions row, keyed by the resumed `agent_session_id` (unique per active
|
* agent_sessions row. Running totals for the whole conversation context. Zero-delta
|
||||||
* row — the dispatcher's `(chat_id, agent)` lookup wrote it). Running totals for
|
* steps are skipped. Errors are swallowed: usage telemetry must never fail a turn.
|
||||||
* the whole conversation context (not last-step). Zero-delta steps are skipped to
|
|
||||||
* avoid a no-op write. Errors are swallowed: usage telemetry must never fail a turn.
|
|
||||||
*/
|
*/
|
||||||
private async accumulateUsage(st: SessionState, u: StepUsage): Promise<void> {
|
private async accumulateUsage(st: SessionState, u: StepUsage): Promise<void> {
|
||||||
if (u.input === 0 && u.output === 0 && u.cost === 0) return;
|
if (u.input === 0 && u.output === 0 && u.cost === 0) return;
|
||||||
@@ -631,13 +366,29 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
// ─── ensureSession: create-or-resume against agent_sessions (1.5) ────────────
|
// ─── ensureSession: create-or-resume against agent_sessions (1.5) ────────────
|
||||||
|
|
||||||
async ensureSession(sessionId: string, opts: EnsureSessionOpts): Promise<AgentSessionHandle> {
|
async ensureSession(sessionId: string, opts: EnsureSessionOpts): Promise<AgentSessionHandle> {
|
||||||
await this.ensureServer();
|
// Coalesce concurrent first-turns for the same (chat, agent) so the SELECT…
|
||||||
if (!this.client) throw new Error('opencode-server: client not ready after ensureServer');
|
// create…upsert can't race into two opencode sessions (the second orphaning
|
||||||
|
// the first). A single (non-concurrent) call is unaffected — the entry is set
|
||||||
|
// and removed within this call. Defensive: the dispatcher already serializes
|
||||||
|
// turns per (chat, agent) via its inflight map.
|
||||||
|
const key = `${opts.chatId}:${opts.agent}`;
|
||||||
|
const existing = this.ensuring.get(key);
|
||||||
|
if (existing) return existing;
|
||||||
|
const p = this.ensureSessionInner(sessionId, opts).finally(() => {
|
||||||
|
if (this.ensuring.get(key) === p) this.ensuring.delete(key);
|
||||||
|
});
|
||||||
|
this.ensuring.set(key, p);
|
||||||
|
return p;
|
||||||
|
}
|
||||||
|
|
||||||
|
private async ensureSessionInner(sessionId: string, opts: EnsureSessionOpts): Promise<AgentSessionHandle> {
|
||||||
|
await this.supervisor.ensureServer();
|
||||||
|
const client = this.supervisor.client;
|
||||||
|
if (!client) throw new Error('opencode-server: client not ready after ensureServer');
|
||||||
|
|
||||||
const configHash = sessionConfigHash(opts.model);
|
const configHash = sessionConfigHash(opts.model);
|
||||||
// P1.5-b: agent_sessions is keyed (chat_id, agent) — the tab/chat is the
|
// P1.5-b: agent_sessions is keyed (chat_id, agent) — the tab/chat is the
|
||||||
// context unit (two tabs in one session = two contexts sharing one worktree).
|
// context unit (two tabs in one session = two contexts sharing one worktree).
|
||||||
// session_id + worktree_id are retained as informational (SET NULL) columns.
|
|
||||||
const [row] = await this.sql<{ agent_session_id: string | null; status: string; config_hash: string | null }[]>`
|
const [row] = await this.sql<{ agent_session_id: string | null; status: string; config_hash: string | null }[]>`
|
||||||
SELECT agent_session_id, status, config_hash FROM agent_sessions
|
SELECT agent_session_id, status, config_hash FROM agent_sessions
|
||||||
WHERE chat_id = ${opts.chatId} AND agent = ${opts.agent}
|
WHERE chat_id = ${opts.chatId} AND agent = ${opts.agent}
|
||||||
@@ -655,7 +406,7 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
'opencode-server: not resuming stale session, creating fresh');
|
'opencode-server: not resuming stale session, creating fresh');
|
||||||
this.byOpencodeId.delete(agentSessionId);
|
this.byOpencodeId.delete(agentSessionId);
|
||||||
}
|
}
|
||||||
const created = await this.client.session.create({ directory: opts.worktreePath });
|
const created = await client.session.create({ directory: opts.worktreePath });
|
||||||
if (created.error || !created.data) {
|
if (created.error || !created.data) {
|
||||||
throw new Error(`opencode-server: session.create failed: ${errToString(created.error)}`);
|
throw new Error(`opencode-server: session.create failed: ${errToString(created.error)}`);
|
||||||
}
|
}
|
||||||
@@ -664,7 +415,7 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
INSERT INTO agent_sessions
|
INSERT INTO agent_sessions
|
||||||
(chat_id, session_id, worktree_id, agent, backend, agent_session_id, server_port, status, last_active_at, config_hash)
|
(chat_id, session_id, worktree_id, agent, backend, agent_session_id, server_port, status, last_active_at, config_hash)
|
||||||
VALUES
|
VALUES
|
||||||
(${opts.chatId}, ${sessionId}, ${opts.worktreeId}, ${opts.agent}, 'opencode_server', ${agentSessionId}, ${this.port}, 'active', clock_timestamp(), ${configHash})
|
(${opts.chatId}, ${sessionId}, ${opts.worktreeId}, ${opts.agent}, 'opencode_server', ${agentSessionId}, ${this.supervisor.port}, 'active', clock_timestamp(), ${configHash})
|
||||||
ON CONFLICT (chat_id, agent) DO UPDATE SET
|
ON CONFLICT (chat_id, agent) DO UPDATE SET
|
||||||
session_id = EXCLUDED.session_id,
|
session_id = EXCLUDED.session_id,
|
||||||
worktree_id = EXCLUDED.worktree_id,
|
worktree_id = EXCLUDED.worktree_id,
|
||||||
@@ -678,7 +429,7 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
} else {
|
} else {
|
||||||
await this.sql`
|
await this.sql`
|
||||||
UPDATE agent_sessions
|
UPDATE agent_sessions
|
||||||
SET status = 'active', last_active_at = clock_timestamp(), server_port = ${this.port}, config_hash = ${configHash}
|
SET status = 'active', last_active_at = clock_timestamp(), server_port = ${this.supervisor.port}, config_hash = ${configHash}
|
||||||
WHERE chat_id = ${opts.chatId} AND agent = ${opts.agent}
|
WHERE chat_id = ${opts.chatId} AND agent = ${opts.agent}
|
||||||
`;
|
`;
|
||||||
}
|
}
|
||||||
@@ -693,24 +444,13 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
state.boocodeSessionId = sessionId;
|
state.boocodeSessionId = sessionId;
|
||||||
state.worktreePath = opts.worktreePath;
|
state.worktreePath = opts.worktreePath;
|
||||||
} else {
|
} else {
|
||||||
state = {
|
state = this.makeSessionState(sessionId, ocSessionId, opts.worktreePath);
|
||||||
boocodeSessionId: sessionId,
|
|
||||||
agentSessionId: ocSessionId,
|
|
||||||
worktreePath: opts.worktreePath,
|
|
||||||
streamedPartKeys: new Set(),
|
|
||||||
partTypeById: new Map(),
|
|
||||||
activeTurn: null,
|
|
||||||
watchdog: null,
|
|
||||||
sseAbort: null,
|
|
||||||
swallowNextTerminal: false,
|
|
||||||
};
|
|
||||||
this.byOpencodeId.set(ocSessionId, state);
|
this.byOpencodeId.set(ocSessionId, state);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Start this session's own SSE loop, scoped to its worktree directory. Both
|
// Start this session's own SSE loop, scoped to its worktree directory. Both
|
||||||
// fresh-create and resume reach here; idempotent, so a re-ensure (e.g. a
|
// fresh-create and resume reach here; idempotent.
|
||||||
// second turn) won't spawn a duplicate loop.
|
startSessionEventLoop(state, this.sseDeps());
|
||||||
this.startSessionEventLoop(state);
|
|
||||||
|
|
||||||
return {
|
return {
|
||||||
sessionId,
|
sessionId,
|
||||||
@@ -719,40 +459,53 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
chatId: opts.chatId,
|
chatId: opts.chatId,
|
||||||
worktreeId: opts.worktreeId,
|
worktreeId: opts.worktreeId,
|
||||||
agentSessionId: ocSessionId,
|
agentSessionId: ocSessionId,
|
||||||
serverPort: this.port,
|
serverPort: this.supervisor.port,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Fresh per-(opencode session) demux state. */
|
||||||
|
private makeSessionState(boocodeSessionId: string, agentSessionId: string, worktreePath: string): SessionState {
|
||||||
|
return {
|
||||||
|
boocodeSessionId,
|
||||||
|
agentSessionId,
|
||||||
|
worktreePath,
|
||||||
|
streamedPartKeys: new Set(),
|
||||||
|
partTypeById: new Map(),
|
||||||
|
activeTurn: null,
|
||||||
|
watchdog: null,
|
||||||
|
sseAbort: null,
|
||||||
|
swallowNextTerminal: false,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
// ─── prompt: send one turn (1.6) ─────────────────────────────────────────────
|
// ─── prompt: send one turn (1.6) ─────────────────────────────────────────────
|
||||||
|
|
||||||
async prompt(handle: AgentSessionHandle, input: string, ctx: PromptCtx): Promise<TurnResult> {
|
async prompt(handle: AgentSessionHandle, input: string, ctx: PromptCtx): Promise<TurnResult> {
|
||||||
if (!this.client) throw new Error('opencode-server: client not ready');
|
const client = this.supervisor.client;
|
||||||
|
if (!client) throw new Error('opencode-server: client not ready');
|
||||||
const oc = handle.agentSessionId;
|
const oc = handle.agentSessionId;
|
||||||
if (!oc) throw new Error('opencode-server: handle has no agentSessionId');
|
if (!oc) throw new Error('opencode-server: handle has no agentSessionId');
|
||||||
|
|
||||||
let state = this.byOpencodeId.get(oc);
|
let state = this.byOpencodeId.get(oc);
|
||||||
if (!state) {
|
if (!state) {
|
||||||
state = {
|
state = this.makeSessionState(handle.sessionId, oc, ctx.worktreePath);
|
||||||
boocodeSessionId: handle.sessionId,
|
|
||||||
agentSessionId: oc,
|
|
||||||
worktreePath: ctx.worktreePath,
|
|
||||||
streamedPartKeys: new Set(),
|
|
||||||
partTypeById: new Map(),
|
|
||||||
activeTurn: null,
|
|
||||||
watchdog: null,
|
|
||||||
sseAbort: null,
|
|
||||||
swallowNextTerminal: false,
|
|
||||||
};
|
|
||||||
this.byOpencodeId.set(oc, state);
|
this.byOpencodeId.set(oc, state);
|
||||||
}
|
}
|
||||||
const session = state;
|
const session = state;
|
||||||
|
|
||||||
|
// v2.7 busy-assert: one in-flight turn per session. The dispatcher serializes
|
||||||
|
// turns per (chat, agent), so this never fires in normal dispatch — but if a
|
||||||
|
// second prompt arrives while one is live it would silently overwrite the slot
|
||||||
|
// and orphan the first turn, so reject instead.
|
||||||
|
if (session.activeTurn) {
|
||||||
|
return { ok: false, error: 'opencode-server: session already has an in-flight turn' };
|
||||||
|
}
|
||||||
|
|
||||||
// Authoritative per-turn directory for SDK routing + reconcile.
|
// Authoritative per-turn directory for SDK routing + reconcile.
|
||||||
session.worktreePath = ctx.worktreePath;
|
session.worktreePath = ctx.worktreePath;
|
||||||
// Defensive: ensureSession normally starts the loop, but if prompt is reached
|
// Defensive: ensureSession normally starts the loop, but if prompt is reached
|
||||||
// with a freshly-created state (no loop yet), start it so the turn streams.
|
// with a freshly-created state (no loop yet), start it so the turn streams.
|
||||||
// Idempotent when ensureSession already started one.
|
startSessionEventLoop(session, this.sseDeps());
|
||||||
this.startSessionEventLoop(session);
|
|
||||||
const client = this.client;
|
|
||||||
|
|
||||||
return await new Promise<TurnResult>((resolve) => {
|
return await new Promise<TurnResult>((resolve) => {
|
||||||
let settled = false;
|
let settled = false;
|
||||||
@@ -781,7 +534,8 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
settle({ ok: false, error: 'aborted' });
|
settle({ ok: false, error: 'aborted' });
|
||||||
};
|
};
|
||||||
|
|
||||||
session.activeTurn = { onEvent: ctx.onEvent, settle };
|
const turn: TurnState = { onEvent: ctx.onEvent, settle };
|
||||||
|
session.activeTurn = turn;
|
||||||
this.bumpActivity(session); // arm the inactivity backstop
|
this.bumpActivity(session); // arm the inactivity backstop
|
||||||
|
|
||||||
if (ctx.signal.aborted) {
|
if (ctx.signal.aborted) {
|
||||||
@@ -822,39 +576,15 @@ export class OpenCodeServerBackend implements AgentBackend {
|
|||||||
}
|
}
|
||||||
|
|
||||||
async dispose(): Promise<void> {
|
async dispose(): Promise<void> {
|
||||||
this.up = false;
|
|
||||||
// Abort every per-session SSE loop so none survive the teardown.
|
// Abort every per-session SSE loop so none survive the teardown.
|
||||||
for (const st of this.byOpencodeId.values()) st.sseAbort?.abort();
|
for (const st of this.byOpencodeId.values()) st.sseAbort?.abort();
|
||||||
const child = this.child;
|
|
||||||
this.child = null;
|
|
||||||
this.client = null;
|
|
||||||
this.byOpencodeId.clear();
|
this.byOpencodeId.clear();
|
||||||
if (child && !child.killed) {
|
await this.supervisor.dispose();
|
||||||
child.kill('SIGTERM');
|
|
||||||
const t = setTimeout(() => {
|
|
||||||
if (!child.killed) child.kill('SIGKILL');
|
|
||||||
}, 5_000);
|
|
||||||
t.unref();
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// ─── helpers ──────────────────────────────────────────────────────────────────
|
// ─── helpers ──────────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
/** Extract the opencode sessionID an event belongs to, across event shapes.
|
|
||||||
* Most carry `properties.sessionID`; `message.part.updated` nests it under
|
|
||||||
* `properties.part.sessionID`. Returns null when the event has no session
|
|
||||||
* (the per-session loop then leaves it to dispatchEvent, which drops it). */
|
|
||||||
function eventSessionId(ev: Event): string | null {
|
|
||||||
const props = (ev as { properties?: unknown }).properties;
|
|
||||||
if (!props || typeof props !== 'object') return null;
|
|
||||||
if (ev.type === 'message.part.updated') {
|
|
||||||
const part = (props as { part?: { sessionID?: string } }).part;
|
|
||||||
return part?.sessionID ?? null;
|
|
||||||
}
|
|
||||||
return (props as { sessionID?: string }).sessionID ?? null;
|
|
||||||
}
|
|
||||||
|
|
||||||
/** BooCoder model string "provider/model" → opencode's structured {providerID, modelID}. */
|
/** BooCoder model string "provider/model" → opencode's structured {providerID, modelID}. */
|
||||||
function parseModel(model: string | undefined): { providerID: string; modelID: string } | undefined {
|
function parseModel(model: string | undefined): { providerID: string; modelID: string } | undefined {
|
||||||
if (!model || !model.trim()) return undefined;
|
if (!model || !model.trim()) return undefined;
|
||||||
@@ -864,199 +594,14 @@ function parseModel(model: string | undefined): { providerID: string; modelID: s
|
|||||||
return { providerID: trimmed.slice(0, idx), modelID: trimmed.slice(idx + 1) };
|
return { providerID: trimmed.slice(0, idx), modelID: trimmed.slice(idx + 1) };
|
||||||
}
|
}
|
||||||
// No slash but non-empty → infer llama-swap (the only configured provider).
|
// No slash but non-empty → infer llama-swap (the only configured provider).
|
||||||
// Guard against bare '/' or trailing/leading slash.
|
|
||||||
if (idx < 0 && trimmed.length > 0) {
|
if (idx < 0 && trimmed.length > 0) {
|
||||||
return { providerID: 'llama-swap', modelID: trimmed };
|
return { providerID: 'llama-swap', modelID: trimmed };
|
||||||
}
|
}
|
||||||
return undefined;
|
return undefined;
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Ported verbatim from Paseo opencode-agent.ts: id → message-id fallback → null. */
|
|
||||||
function resolvePartDedupeKey(part: { id: string; messageID: string }, type: string): string | null {
|
|
||||||
if (part.id.trim().length > 0) return `${type}:${part.id}`;
|
|
||||||
if (part.messageID.trim().length > 0) return `${type}:message:${part.messageID}`;
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
/** opencode ToolPart → ACP-shaped snapshot (reuses the existing persist/render path). */
|
|
||||||
function toolPartToSnapshot(part: ToolPart): AcpToolSnapshot {
|
|
||||||
const state = part.state;
|
|
||||||
let rawInput: unknown;
|
|
||||||
let rawOutput: unknown;
|
|
||||||
let title: string | undefined;
|
|
||||||
if (state) {
|
|
||||||
if ('input' in state) rawInput = (state as { input?: unknown }).input;
|
|
||||||
if ('output' in state) rawOutput = (state as { output?: unknown }).output;
|
|
||||||
else if ('error' in state) rawOutput = (state as { error?: unknown }).error;
|
|
||||||
if ('title' in state) title = (state as { title?: string }).title;
|
|
||||||
}
|
|
||||||
return {
|
|
||||||
toolCallId: part.callID,
|
|
||||||
title: title ?? part.tool,
|
|
||||||
kind: null,
|
|
||||||
status: mapToolStatus(state?.status),
|
|
||||||
rawInput,
|
|
||||||
rawOutput,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
function mapToolStatus(s: ToolState['status'] | undefined): ToolCallStatus | null {
|
|
||||||
switch (s) {
|
|
||||||
case 'pending':
|
|
||||||
return 'pending';
|
|
||||||
case 'running':
|
|
||||||
return 'in_progress';
|
|
||||||
case 'completed':
|
|
||||||
return 'completed';
|
|
||||||
case 'error':
|
|
||||||
return 'failed';
|
|
||||||
default:
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Reclaim a loopback port a dead opencode child may still hold (lift of
|
|
||||||
* openchamber `killProcessOnPort`). Best-effort, POSIX-only (`lsof`/`kill`); a
|
|
||||||
* failure is harmless because the next spawn allocates a fresh ephemeral port.
|
|
||||||
* Never kills this process. Synchronous + short-timeout so the crash handler
|
|
||||||
* doesn't block.
|
|
||||||
*/
|
|
||||||
function reclaimPort(port: number | null): void {
|
|
||||||
if (!port || process.platform === 'win32') return;
|
|
||||||
try {
|
|
||||||
const res = spawnSync('lsof', ['-ti', `:${port}`], { encoding: 'utf8', timeout: 3_000, windowsHide: true });
|
|
||||||
const out = res.stdout || '';
|
|
||||||
const myPid = process.pid;
|
|
||||||
for (const pidStr of out.split(/\s+/)) {
|
|
||||||
const pid = parseInt(pidStr.trim(), 10);
|
|
||||||
if (pid && pid !== myPid) {
|
|
||||||
try {
|
|
||||||
spawnSync('kill', ['-9', String(pid)], { stdio: 'ignore', timeout: 2_000 });
|
|
||||||
} catch {
|
|
||||||
// ignore — best effort
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} catch {
|
|
||||||
// lsof absent or failed — the fresh-ephemeral-port spawn doesn't need this.
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Resolve true once nothing is listening on `port` (lift of openchamber
|
|
||||||
* `waitForPortRelease`). Used before re-spawning on a fixed port; with ephemeral
|
|
||||||
* ports it's a fast no-op. Probes 127.0.0.1; resolves false at the deadline.
|
|
||||||
*/
|
|
||||||
function waitForPortRelease(port: number, timeoutMs: number): Promise<boolean> {
|
|
||||||
const deadline = Date.now() + timeoutMs;
|
|
||||||
return new Promise((resolve) => {
|
|
||||||
const attempt = () => {
|
|
||||||
const socket = netConnect({ port, host: '127.0.0.1' });
|
|
||||||
let settled = false;
|
|
||||||
const finish = (released: boolean) => {
|
|
||||||
if (settled) return;
|
|
||||||
settled = true;
|
|
||||||
socket.removeAllListeners();
|
|
||||||
socket.destroy();
|
|
||||||
if (released || Date.now() >= deadline) {
|
|
||||||
resolve(released);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
setTimeout(attempt, 150);
|
|
||||||
};
|
|
||||||
socket.once('connect', () => finish(false));
|
|
||||||
socket.once('error', (err: NodeJS.ErrnoException) => {
|
|
||||||
if (err && (err.code === 'ECONNREFUSED' || err.code === 'EHOSTUNREACH')) finish(true);
|
|
||||||
else finish(false);
|
|
||||||
});
|
|
||||||
socket.setTimeout(500, () => finish(true));
|
|
||||||
};
|
|
||||||
attempt();
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Bind-probe an ephemeral port on loopback. */
|
|
||||||
function freePort(): Promise<number> {
|
|
||||||
return new Promise((resolve, reject) => {
|
|
||||||
const srv = createServer();
|
|
||||||
srv.unref();
|
|
||||||
srv.on('error', reject);
|
|
||||||
srv.listen(0, '127.0.0.1', () => {
|
|
||||||
const addr = srv.address();
|
|
||||||
if (addr && typeof addr === 'object') {
|
|
||||||
const { port } = addr;
|
|
||||||
srv.close(() => resolve(port));
|
|
||||||
} else {
|
|
||||||
srv.close(() => reject(new Error('opencode-server: could not determine a free port')));
|
|
||||||
}
|
|
||||||
});
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Resolve when the child prints the ready line; reject on timeout or early exit. */
|
|
||||||
function waitForReady(child: ChildProcess, timeoutMs: number): Promise<void> {
|
|
||||||
return new Promise((resolve, reject) => {
|
|
||||||
let done = false;
|
|
||||||
let stderrBuf = '';
|
|
||||||
|
|
||||||
const finish = (err?: Error) => {
|
|
||||||
if (done) return;
|
|
||||||
done = true;
|
|
||||||
clearTimeout(timer);
|
|
||||||
child.stdout?.off('data', onOut);
|
|
||||||
child.stderr?.off('data', onErr);
|
|
||||||
child.off('exit', onExit);
|
|
||||||
if (err) reject(err);
|
|
||||||
else resolve();
|
|
||||||
};
|
|
||||||
|
|
||||||
const onOut = (buf: Buffer) => {
|
|
||||||
if (buf.toString().includes('opencode server listening on')) finish();
|
|
||||||
};
|
|
||||||
const onErr = (buf: Buffer) => {
|
|
||||||
stderrBuf += buf.toString();
|
|
||||||
};
|
|
||||||
const onExit = (code: number | null) =>
|
|
||||||
finish(new Error(`opencode serve exited before ready (code ${code}); stderr: ${stderrBuf.slice(-2000)}`));
|
|
||||||
const timer = setTimeout(
|
|
||||||
() => finish(new Error(`opencode serve not ready in ${timeoutMs}ms; stderr: ${stderrBuf.slice(-2000)}`)),
|
|
||||||
timeoutMs,
|
|
||||||
);
|
|
||||||
|
|
||||||
child.stdout?.on('data', onOut);
|
|
||||||
child.stderr?.on('data', onErr);
|
|
||||||
child.on('exit', onExit);
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
function sleep(ms: number): Promise<void> {
|
|
||||||
return new Promise((r) => setTimeout(r, ms));
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Strip opencode-dcp plugin tags that render as literal text in the UI. */
|
|
||||||
function stripDcpTags(s: string): string {
|
|
||||||
return s.replace(/<dcp-message-id>[^<]*<\/dcp-message-id>/g, '');
|
|
||||||
}
|
|
||||||
|
|
||||||
function errMsg(e: unknown): string {
|
|
||||||
return e instanceof Error ? e.message : String(e);
|
|
||||||
}
|
|
||||||
|
|
||||||
function errToString(e: unknown): string {
|
|
||||||
if (e == null) return 'unknown error';
|
|
||||||
if (typeof e === 'string') return e;
|
|
||||||
if (e instanceof Error) return e.message;
|
|
||||||
try {
|
|
||||||
return JSON.stringify(e);
|
|
||||||
} catch {
|
|
||||||
return String(e);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Hash of stable config — detects model changes across sessions without
|
/** Hash of stable config — detects model changes across sessions without
|
||||||
* invalidating on ephemeral state like the random server port (which changes
|
* invalidating on ephemeral state like the random server port. */
|
||||||
* every BooCoder restart). */
|
|
||||||
function sessionConfigHash(model: string): string {
|
function sessionConfigHash(model: string): string {
|
||||||
return createHash('sha256').update(`opencode_server|${model}`).digest('hex').slice(0, 16);
|
return createHash('sha256').update(`opencode_server|${model}`).digest('hex').slice(0, 16);
|
||||||
}
|
}
|
||||||
|
|||||||
181
apps/coder/src/services/backends/opencode-sse.ts
Normal file
181
apps/coder/src/services/backends/opencode-sse.ts
Normal file
@@ -0,0 +1,181 @@
|
|||||||
|
/**
|
||||||
|
* Per-session SSE subscribe loop + reconnect/backoff + eventSessionId demux.
|
||||||
|
*
|
||||||
|
* Extracted (v2.7 audit reshape) from `OpenCodeServerBackend.startSessionEventLoop`
|
||||||
|
* / `runSessionEventLoop`. opencode scopes events by the `directory` query param, so
|
||||||
|
* each session runs its own dir-scoped stream and never drops a sibling's events.
|
||||||
|
*
|
||||||
|
* The loop is intentionally thin: it owns subscribe + the demux filter + reconnect
|
||||||
|
* timing only. Translating an event into turn side effects (watchdog, usage,
|
||||||
|
* settle) stays on the backend via the injected `dispatchEvent` / `reconcile`
|
||||||
|
* callbacks — `opencode-sse` knows nothing about turns or the DB.
|
||||||
|
*
|
||||||
|
* v2.7 concurrency hardening: the throw-driven reconnect path now backs off
|
||||||
|
* exponentially and trips a circuit-breaker (`onReconnectGiveUp`) after a bounded
|
||||||
|
* number of consecutive failures, instead of looping forever at a flat 1s. The
|
||||||
|
* HAPPY PATH is unchanged — a clean stream end (server still up) reconnects after
|
||||||
|
* `baseMs` (1s, as before) and resets the failure counter, so a long-lived session
|
||||||
|
* that re-subscribes normally never backs off.
|
||||||
|
*/
|
||||||
|
import type { FastifyBaseLogger } from 'fastify';
|
||||||
|
import type { Event, OpencodeClient } from '@opencode-ai/sdk/v2/client';
|
||||||
|
import type { AgentEvent } from '../agent-backend.js';
|
||||||
|
import type { TurnResult } from '../agent-backend.js';
|
||||||
|
import { eventSessionId, errMsg } from './opencode-event-map.js';
|
||||||
|
|
||||||
|
export const SSE_RECONNECT_DELAY_MS = 1_000;
|
||||||
|
|
||||||
|
/** One in-flight turn's emitter + completion settler. */
|
||||||
|
export interface TurnState {
|
||||||
|
onEvent: (e: AgentEvent) => void;
|
||||||
|
settle: (r: TurnResult) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Per-(opencode session) demux state. dedup sets scoped here, cleared per turn. */
|
||||||
|
export interface SessionState {
|
||||||
|
boocodeSessionId: string;
|
||||||
|
agentSessionId: string;
|
||||||
|
/** Worktree directory for SDK `directory` routing; refreshed each turn from ctx. */
|
||||||
|
worktreePath: string;
|
||||||
|
/** dedup gate: `${type}:${id}` added on delta, deleted-and-tested on updated. Cleared at turn end. */
|
||||||
|
streamedPartKeys: Set<string>;
|
||||||
|
/** partID → 'text' | 'reasoning', so a delta with a non-'reasoning' field is still classed right. Cleared at turn end. */
|
||||||
|
partTypeById: Map<string, string>;
|
||||||
|
activeTurn: TurnState | null;
|
||||||
|
/** Inactivity backstop timer for the active turn; null when no turn in flight. */
|
||||||
|
watchdog: ReturnType<typeof setTimeout> | null;
|
||||||
|
/** Per-session SSE subscription handle. Non-null while the loop is running;
|
||||||
|
* aborting it tears down the underlying fetch and exits the loop. */
|
||||||
|
sseAbort: AbortController | null;
|
||||||
|
/** F.1 post-abort orphan-terminal guard: swallow the one session.idle/error
|
||||||
|
* opencode emits for an aborted turn so it can't settle the next turn. */
|
||||||
|
swallowNextTerminal: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── reconnect backoff (pure) ────────────────────────────────────────────────
|
||||||
|
|
||||||
|
export interface ReconnectPolicy {
|
||||||
|
/** First retry delay (and the steady-state clean-reconnect delay). */
|
||||||
|
baseMs: number;
|
||||||
|
/** Cap on the exponential delay. */
|
||||||
|
maxMs: number;
|
||||||
|
/** Consecutive failures tolerated before the breaker trips (give up). */
|
||||||
|
maxAttempts: number;
|
||||||
|
}
|
||||||
|
|
||||||
|
export const DEFAULT_RECONNECT_POLICY: ReconnectPolicy = {
|
||||||
|
baseMs: SSE_RECONNECT_DELAY_MS,
|
||||||
|
maxMs: 30_000,
|
||||||
|
maxAttempts: 6,
|
||||||
|
};
|
||||||
|
|
||||||
|
export type ReconnectDecision =
|
||||||
|
| { action: 'reconnect'; delayMs: number }
|
||||||
|
| { action: 'give-up' };
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Pure backoff decision after `failures` consecutive throwing reconnect attempts
|
||||||
|
* (1-based: the first failure passes `failures=1`). Returns an exponentially
|
||||||
|
* growing delay capped at `maxMs`, or `give-up` once the count exceeds
|
||||||
|
* `maxAttempts`. `failures=1` yields `baseMs`, so the very first retry matches the
|
||||||
|
* pre-hardening flat delay (happy-path-preserving).
|
||||||
|
*/
|
||||||
|
export function reconnectDecision(
|
||||||
|
failures: number,
|
||||||
|
policy: ReconnectPolicy = DEFAULT_RECONNECT_POLICY,
|
||||||
|
): ReconnectDecision {
|
||||||
|
if (failures > policy.maxAttempts) return { action: 'give-up' };
|
||||||
|
const exp = policy.baseMs * 2 ** (failures - 1);
|
||||||
|
return { action: 'reconnect', delayMs: Math.min(policy.maxMs, exp) };
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── the loop ────────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
export interface SseLoopDeps {
|
||||||
|
/** Live iff the server is up (read each iteration so a crash stops the loop). */
|
||||||
|
isUp: () => boolean;
|
||||||
|
/** The current opencode client (null between server restarts). */
|
||||||
|
getClient: () => OpencodeClient | null;
|
||||||
|
/** Route one demuxed event to its turn (backend side effects live here). */
|
||||||
|
dispatchEvent: (ev: Event) => void;
|
||||||
|
/** Recover an idle/error lost during an SSE gap. Returns true if it settled. */
|
||||||
|
reconcile: (state: SessionState) => Promise<boolean>;
|
||||||
|
/** Circuit-breaker: called once the backoff gives up; fail the active turn. */
|
||||||
|
onReconnectGiveUp: (state: SessionState) => Promise<void> | void;
|
||||||
|
log: FastifyBaseLogger;
|
||||||
|
/** Injectable for tests; defaults to a real timer sleep. */
|
||||||
|
sleep?: (ms: number) => Promise<void>;
|
||||||
|
policy?: ReconnectPolicy;
|
||||||
|
}
|
||||||
|
|
||||||
|
function defaultSleep(ms: number): Promise<void> {
|
||||||
|
return new Promise((r) => setTimeout(r, ms));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Per-session SSE subscription, scoped to the session's worktree directory.
|
||||||
|
* Idempotent: a no-op if this session's loop is already running. */
|
||||||
|
export function startSessionEventLoop(state: SessionState, deps: SseLoopDeps): void {
|
||||||
|
if (state.sseAbort) return; // already running
|
||||||
|
const abort = new AbortController();
|
||||||
|
state.sseAbort = abort;
|
||||||
|
void runSessionEventLoop(state, abort, deps).finally(() => {
|
||||||
|
// Only clear if this controller is still the live one (a later restart may
|
||||||
|
// have already installed a new one).
|
||||||
|
if (state.sseAbort === abort) state.sseAbort = null;
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function runSessionEventLoop(
|
||||||
|
state: SessionState,
|
||||||
|
abort: AbortController,
|
||||||
|
deps: SseLoopDeps,
|
||||||
|
): Promise<void> {
|
||||||
|
const signal = abort.signal;
|
||||||
|
const sleep = deps.sleep ?? defaultSleep;
|
||||||
|
const policy = deps.policy ?? DEFAULT_RECONNECT_POLICY;
|
||||||
|
let failures = 0;
|
||||||
|
while (deps.isUp() && deps.getClient() && !signal.aborted) {
|
||||||
|
const client = deps.getClient()!;
|
||||||
|
try {
|
||||||
|
// Re-read worktreePath each (re)subscribe so a directory refresh is picked
|
||||||
|
// up on reconnect. Passing `signal` lets close/dispose tear down a stream
|
||||||
|
// that's parked in `for await` between events.
|
||||||
|
const sub = await client.event.subscribe({ directory: state.worktreePath }, { signal });
|
||||||
|
for await (const ev of sub.stream) {
|
||||||
|
if (signal.aborted) break;
|
||||||
|
// Dir-scoped streams should only carry this session's events, but two
|
||||||
|
// sessions sharing a worktree (possible post-P1.5-b) each receive BOTH
|
||||||
|
// sessions' events — so drop anything that isn't ours, else the other
|
||||||
|
// session's deltas get processed twice (once per loop).
|
||||||
|
const sid = eventSessionId(ev);
|
||||||
|
if (sid != null && sid !== state.agentSessionId) continue;
|
||||||
|
deps.dispatchEvent(ev);
|
||||||
|
}
|
||||||
|
// Clean stream end — a healthy reconnect, NOT a failure: recover any lost
|
||||||
|
// terminal then re-subscribe at the base delay (pre-hardening behavior).
|
||||||
|
failures = 0;
|
||||||
|
if (deps.isUp() && !signal.aborted) {
|
||||||
|
await deps.reconcile(state); // recover an idle/error lost during the gap
|
||||||
|
await sleep(policy.baseMs);
|
||||||
|
}
|
||||||
|
} catch (err) {
|
||||||
|
if (!deps.isUp() || signal.aborted) break;
|
||||||
|
failures += 1;
|
||||||
|
const decision = reconnectDecision(failures, policy);
|
||||||
|
deps.log.warn(
|
||||||
|
{ err: errMsg(err), agentSessionId: state.agentSessionId, failures, action: decision.action },
|
||||||
|
'opencode-server: session event loop error; reconnecting',
|
||||||
|
);
|
||||||
|
await deps.reconcile(state);
|
||||||
|
if (decision.action === 'give-up') {
|
||||||
|
deps.log.warn(
|
||||||
|
{ agentSessionId: state.agentSessionId, failures },
|
||||||
|
'opencode-server: SSE reconnect gave up (circuit breaker) — failing active turn',
|
||||||
|
);
|
||||||
|
await deps.onReconnectGiveUp(state);
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
await sleep(decision.delayMs);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -36,29 +36,15 @@
|
|||||||
*/
|
*/
|
||||||
import { spawn, type ChildProcess } from 'node:child_process';
|
import { spawn, type ChildProcess } from 'node:child_process';
|
||||||
import type { FastifyBaseLogger } from 'fastify';
|
import type { FastifyBaseLogger } from 'fastify';
|
||||||
import {
|
import { ClientSideConnection, type Client } from '@agentclientprotocol/sdk';
|
||||||
ClientSideConnection,
|
|
||||||
type Client,
|
|
||||||
type SessionNotification,
|
|
||||||
type RequestPermissionRequest,
|
|
||||||
type RequestPermissionResponse,
|
|
||||||
type ReadTextFileRequest,
|
|
||||||
type ReadTextFileResponse,
|
|
||||||
type WriteTextFileRequest,
|
|
||||||
type WriteTextFileResponse,
|
|
||||||
type CreateTerminalRequest,
|
|
||||||
type CreateTerminalResponse,
|
|
||||||
type CreateElicitationRequest,
|
|
||||||
type CreateElicitationResponse,
|
|
||||||
} from '@agentclientprotocol/sdk';
|
|
||||||
import type { Sql } from '../../db.js';
|
import type { Sql } from '../../db.js';
|
||||||
import { resolveLaunchSpec } from '../acp-spawn.js';
|
import { resolveLaunchSpec } from '../acp-spawn.js';
|
||||||
import { isTurnOkForStopReason } from './warm-acp-routing.js';
|
import { isTurnOkForStopReason } from './warm-acp-routing.js';
|
||||||
import { getResolvedRegistry, type ResolvedProviderDef } from '../provider-config-registry.js';
|
import { getResolvedRegistry, type ResolvedProviderDef } from '../provider-config-registry.js';
|
||||||
import { createAcpNdJsonStream } from '../acp-stream.js';
|
import { createAcpNdJsonStream } from '../acp-stream.js';
|
||||||
import { mapSessionUpdate } from '../acp-event-map.js';
|
import { mapSessionUpdate } from '../acp-event-map.js';
|
||||||
import { readWorktreeTextFile, writeWorktreeTextFile } from '../acp-client-fs.js';
|
import { buildAcpClient } from '../acp-client.js';
|
||||||
import { waitForPermissionResponse, waitForElicitationResponse, cancelPendingPermission } from '../permission-waiter.js';
|
import { cancelPendingPermission } from '../permission-waiter.js';
|
||||||
import { type AcpToolSnapshot, synthesizeCanceledSnapshots } from '../acp-tool-snapshot.js';
|
import { type AcpToolSnapshot, synthesizeCanceledSnapshots } from '../acp-tool-snapshot.js';
|
||||||
import type {
|
import type {
|
||||||
AgentBackend,
|
AgentBackend,
|
||||||
@@ -211,47 +197,25 @@ export class WarmAcpBackend implements AgentBackend {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Build the ACP Client callbacks ONCE per connection. They read `this.activeTurn`
|
/** Build the ACP Client callbacks ONCE per connection (shared `buildAcpClient`).
|
||||||
* so each turn's events/permissions route to the right place — exactly the
|
* `resolveTurn` reads `this.activeTurn` at each callback so events/permissions
|
||||||
* opencode-server `activeTurn` pattern. Worktree-scoped FS like AcpStreamContext. */
|
* route to the live turn — exactly the prior behavior. The warm session always
|
||||||
|
* has a non-empty `sessionId`, so the shared `taskId && sessionId` permission
|
||||||
|
* gate is equivalent to the old `turn?.taskId` gate. */
|
||||||
private buildClient(worktreePath: string): Client {
|
private buildClient(worktreePath: string): Client {
|
||||||
return {
|
return buildAcpClient(worktreePath, () => {
|
||||||
sessionUpdate: async (params: SessionNotification): Promise<void> => {
|
const turn = this.activeTurn;
|
||||||
const turn = this.activeTurn;
|
if (!turn) return null;
|
||||||
if (!turn) return; // between turns — drop (no orphan settles a future turn)
|
return {
|
||||||
for (const event of mapSessionUpdate(params, turn.snapshots)) {
|
taskId: turn.taskId,
|
||||||
turn.onEvent(event);
|
sessionId: turn.sessionId,
|
||||||
}
|
modeId: turn.modeId,
|
||||||
},
|
agent: this.agent,
|
||||||
requestPermission: async (params: RequestPermissionRequest): Promise<RequestPermissionResponse> => {
|
onSessionUpdate: (params) => {
|
||||||
const turn = this.activeTurn;
|
for (const event of mapSessionUpdate(params, turn.snapshots)) turn.onEvent(event);
|
||||||
if (turn?.taskId) {
|
},
|
||||||
// Route to the UI via the per-turn task id (same as the one-shot path).
|
};
|
||||||
return waitForPermissionResponse(turn.taskId, turn.sessionId, this.agent, turn.modeId, params);
|
});
|
||||||
}
|
|
||||||
const firstOption = params.options[0];
|
|
||||||
if (firstOption) return { outcome: { outcome: 'selected', optionId: firstOption.optionId } };
|
|
||||||
return { outcome: { outcome: 'cancelled' } };
|
|
||||||
},
|
|
||||||
readTextFile: async (params: ReadTextFileRequest): Promise<ReadTextFileResponse> => {
|
|
||||||
const content = await readWorktreeTextFile(worktreePath, params.path, params.line, params.limit);
|
|
||||||
return { content };
|
|
||||||
},
|
|
||||||
writeTextFile: async (params: WriteTextFileRequest): Promise<WriteTextFileResponse> => {
|
|
||||||
await writeWorktreeTextFile(worktreePath, params.path, params.content);
|
|
||||||
return {};
|
|
||||||
},
|
|
||||||
createTerminal: async (_params: CreateTerminalRequest): Promise<CreateTerminalResponse> => {
|
|
||||||
return { terminalId: 'noop' };
|
|
||||||
},
|
|
||||||
unstable_createElicitation: async (params: CreateElicitationRequest): Promise<CreateElicitationResponse> => {
|
|
||||||
const turn = this.activeTurn;
|
|
||||||
if (turn?.taskId) {
|
|
||||||
return waitForElicitationResponse(turn.taskId, turn.sessionId, this.agent, turn.modeId, params);
|
|
||||||
}
|
|
||||||
return { action: 'decline' };
|
|
||||||
},
|
|
||||||
};
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// ─── ensureSession: create-or-reuse the warm session (2.1) ───────────────────
|
// ─── ensureSession: create-or-reuse the warm session (2.1) ───────────────────
|
||||||
@@ -303,6 +267,14 @@ export class WarmAcpBackend implements AgentBackend {
|
|||||||
return { ok: false, error: 'warm-acp: no live ACP connection' };
|
return { ok: false, error: 'warm-acp: no live ACP connection' };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// v2.7 busy-assert: one in-flight turn per warm session. The dispatcher
|
||||||
|
// serializes turns per (chat, agent), so this never fires in normal dispatch —
|
||||||
|
// but a second concurrent prompt would silently overwrite `activeTurn` and
|
||||||
|
// orphan the first turn, so reject instead.
|
||||||
|
if (this.activeTurn) {
|
||||||
|
return { ok: false, error: 'warm-acp: session already has an in-flight turn' };
|
||||||
|
}
|
||||||
|
|
||||||
const snapshots = new Map<string, AcpToolSnapshot>();
|
const snapshots = new Map<string, AcpToolSnapshot>();
|
||||||
// taskId routes permission/elicitation prompts back to the UI. The dispatcher
|
// taskId routes permission/elicitation prompts back to the UI. The dispatcher
|
||||||
// passes it (plus mode) on the per-turn PromptCtx; permission-waiter keys on it.
|
// passes it (plus mode) on the per-turn PromptCtx; permission-waiter keys on it.
|
||||||
|
|||||||
@@ -536,6 +536,7 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
type: 'message_complete',
|
type: 'message_complete',
|
||||||
message_id: assistantId,
|
message_id: assistantId,
|
||||||
chat_id: chatId,
|
chat_id: chatId,
|
||||||
|
model: task.model,
|
||||||
} as WsFrame);
|
} as WsFrame);
|
||||||
|
|
||||||
if (stopping) {
|
if (stopping) {
|
||||||
@@ -864,6 +865,7 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
type: 'message_complete',
|
type: 'message_complete',
|
||||||
message_id: assistantId,
|
message_id: assistantId,
|
||||||
chat_id: chatId,
|
chat_id: chatId,
|
||||||
|
model: task.model,
|
||||||
} as WsFrame);
|
} as WsFrame);
|
||||||
|
|
||||||
if (stopping) {
|
if (stopping) {
|
||||||
@@ -1128,6 +1130,7 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
type: 'message_complete',
|
type: 'message_complete',
|
||||||
message_id: assistantId,
|
message_id: assistantId,
|
||||||
chat_id: chatId,
|
chat_id: chatId,
|
||||||
|
model: task.model,
|
||||||
} as WsFrame);
|
} as WsFrame);
|
||||||
|
|
||||||
if (stopping) {
|
if (stopping) {
|
||||||
@@ -1385,6 +1388,7 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
type: 'message_complete',
|
type: 'message_complete',
|
||||||
message_id: assistantId,
|
message_id: assistantId,
|
||||||
chat_id: chatId,
|
chat_id: chatId,
|
||||||
|
model: task.model,
|
||||||
} as WsFrame);
|
} as WsFrame);
|
||||||
|
|
||||||
if (stopping) {
|
if (stopping) {
|
||||||
|
|||||||
142
apps/coder/src/services/frame-emitter.ts
Normal file
142
apps/coder/src/services/frame-emitter.ts
Normal file
@@ -0,0 +1,142 @@
|
|||||||
|
/**
|
||||||
|
* AgentEvent → WS-frame emitter + turn accumulators.
|
||||||
|
*
|
||||||
|
* Extracted (v2.7 audit reshape) from `AcpStreamContext.handleSessionUpdate` in
|
||||||
|
* `acp-dispatch.ts` — the `AgentEvent → broker.publishFrame` switch that maps a
|
||||||
|
* backend's normalized events onto the wire frames the UI consumes, while
|
||||||
|
* accumulating the turn's text / reasoning / tool snapshots for persistence.
|
||||||
|
*
|
||||||
|
* The same shape backs the dispatcher's 4 inline `onEvent` copies (DEFERRED while
|
||||||
|
* dispatcher.ts has uncommitted edits), hence the optional `dcp` stripper + the
|
||||||
|
* `finalize()` flush: the opencode dispatch path strips dcp tags from text deltas,
|
||||||
|
* the ACP path does not (passes no `dcp`, so text is emitted verbatim — identical
|
||||||
|
* to the prior AcpStreamContext behavior).
|
||||||
|
*
|
||||||
|
* Publishing is gated on `canStream()` (all of broker/sessionId/chatId/assistantId
|
||||||
|
* present) exactly as the original — a one-shot dispatch with no broker accumulates
|
||||||
|
* but never publishes.
|
||||||
|
*/
|
||||||
|
import type { Broker } from '@boocode/server/broker';
|
||||||
|
import type { WsFrame } from '@boocode/server/ws-frames';
|
||||||
|
import type { AgentEvent } from './agent-backend.js';
|
||||||
|
import { type AcpToolSnapshot, snapshotToWireToolCall } from './acp-tool-snapshot.js';
|
||||||
|
import { mergeTaskCommands, getTaskCommands } from './agent-commands-cache.js';
|
||||||
|
import type { DcpStreamStripper } from './dcp-strip.js';
|
||||||
|
|
||||||
|
export interface FrameEmitterOpts {
|
||||||
|
broker?: Broker;
|
||||||
|
sessionId?: string;
|
||||||
|
chatId?: string;
|
||||||
|
/** The assistant message id — the frames' `message_id`. */
|
||||||
|
assistantId?: string;
|
||||||
|
/** Per-turn task id, for the agent_commands frame + command cache. */
|
||||||
|
taskId?: string;
|
||||||
|
/** Optional cross-chunk dcp stripper for text deltas (opencode path). When
|
||||||
|
* provided, text is stripped before push/publish and `finalize()` flushes the
|
||||||
|
* held-back tail. The ACP path passes none → text emitted verbatim. */
|
||||||
|
dcp?: DcpStreamStripper;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface FrameEmitter {
|
||||||
|
/** Map one AgentEvent to its WS frame(s) + accumulate it. */
|
||||||
|
onEvent: (e: AgentEvent) => void;
|
||||||
|
/** Flush a dcp stripper's held-back tail at turn end (no-op without `dcp`). */
|
||||||
|
finalize: () => void;
|
||||||
|
/** The merge accumulator for tool snapshots (toolCallId → snapshot). */
|
||||||
|
readonly toolSnapshots: Map<string, AcpToolSnapshot>;
|
||||||
|
/** Accumulated assistant text (post-dcp-strip when a stripper is set). */
|
||||||
|
readonly output: string;
|
||||||
|
/** Accumulated reasoning text. */
|
||||||
|
readonly reasoningText: string;
|
||||||
|
/** Tool snapshots in insertion order. */
|
||||||
|
readonly snapshots: AcpToolSnapshot[];
|
||||||
|
}
|
||||||
|
|
||||||
|
export function makeFrameEmitter(opts: FrameEmitterOpts): FrameEmitter {
|
||||||
|
const { broker, sessionId, chatId, assistantId, taskId, dcp } = opts;
|
||||||
|
const textChunks: string[] = [];
|
||||||
|
const reasoningChunks: string[] = [];
|
||||||
|
const toolSnapshots = new Map<string, AcpToolSnapshot>();
|
||||||
|
|
||||||
|
const canStream = (): boolean => !!(broker && sessionId && chatId && assistantId);
|
||||||
|
|
||||||
|
const publishText = (content: string): void => {
|
||||||
|
textChunks.push(content);
|
||||||
|
if (canStream()) {
|
||||||
|
broker!.publishFrame(sessionId!, {
|
||||||
|
type: 'delta',
|
||||||
|
message_id: assistantId!,
|
||||||
|
chat_id: chatId!,
|
||||||
|
content,
|
||||||
|
} as WsFrame);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const onEvent = (e: AgentEvent): void => {
|
||||||
|
switch (e.type) {
|
||||||
|
case 'text': {
|
||||||
|
const safe = dcp ? dcp.push(e.text) : e.text;
|
||||||
|
if (safe) publishText(safe);
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
case 'reasoning':
|
||||||
|
reasoningChunks.push(e.text);
|
||||||
|
if (canStream()) {
|
||||||
|
broker!.publishFrame(sessionId!, {
|
||||||
|
type: 'reasoning_delta',
|
||||||
|
message_id: assistantId!,
|
||||||
|
chat_id: chatId!,
|
||||||
|
content: e.text,
|
||||||
|
} as WsFrame);
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
case 'tool_call':
|
||||||
|
case 'tool_update':
|
||||||
|
toolSnapshots.set(e.toolCall.toolCallId, e.toolCall);
|
||||||
|
if (canStream()) {
|
||||||
|
broker!.publishFrame(sessionId!, {
|
||||||
|
type: 'tool_call',
|
||||||
|
message_id: assistantId!,
|
||||||
|
chat_id: chatId!,
|
||||||
|
tool_call: snapshotToWireToolCall(e.toolCall),
|
||||||
|
} as WsFrame);
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
case 'commands':
|
||||||
|
if (taskId && e.commands.length > 0) {
|
||||||
|
mergeTaskCommands(taskId, e.commands);
|
||||||
|
if (canStream() && sessionId) {
|
||||||
|
const all = getTaskCommands(taskId) ?? e.commands;
|
||||||
|
broker!.publishFrame(sessionId, {
|
||||||
|
type: 'agent_commands',
|
||||||
|
task_id: taskId,
|
||||||
|
session_id: sessionId,
|
||||||
|
commands: all,
|
||||||
|
} as WsFrame);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const finalize = (): void => {
|
||||||
|
if (!dcp) return;
|
||||||
|
const tail = dcp.flush();
|
||||||
|
if (tail) publishText(tail);
|
||||||
|
};
|
||||||
|
|
||||||
|
return {
|
||||||
|
onEvent,
|
||||||
|
finalize,
|
||||||
|
toolSnapshots,
|
||||||
|
get output() {
|
||||||
|
return textChunks.join('');
|
||||||
|
},
|
||||||
|
get reasoningText() {
|
||||||
|
return reasoningChunks.join('');
|
||||||
|
},
|
||||||
|
get snapshots() {
|
||||||
|
return [...toolSnapshots.values()];
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -25,13 +25,6 @@ interface PendingRow {
|
|||||||
session_id: string;
|
session_id: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
interface WorktreeRow {
|
|
||||||
id: string;
|
|
||||||
worktree_path: string;
|
|
||||||
agent: string;
|
|
||||||
started_at: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
interface ProjectPathRow {
|
interface ProjectPathRow {
|
||||||
path: string;
|
path: string;
|
||||||
}
|
}
|
||||||
@@ -196,28 +189,6 @@ export async function startMcpServer(sql: Sql): Promise<void> {
|
|||||||
},
|
},
|
||||||
);
|
);
|
||||||
|
|
||||||
// 6. boocoder.list_worktrees
|
|
||||||
server.tool(
|
|
||||||
'boocoder.list_worktrees',
|
|
||||||
'List active worktrees from running tasks',
|
|
||||||
{},
|
|
||||||
async () => {
|
|
||||||
const rows = await sql<WorktreeRow[]>`
|
|
||||||
SELECT id, worktree_path, agent, started_at
|
|
||||||
FROM tasks
|
|
||||||
WHERE worktree_path IS NOT NULL AND state = 'running'
|
|
||||||
ORDER BY started_at DESC
|
|
||||||
`;
|
|
||||||
const items = rows.map((r) => ({
|
|
||||||
task_id: r.id,
|
|
||||||
worktree_path: r.worktree_path,
|
|
||||||
agent: r.agent,
|
|
||||||
started_at: r.started_at,
|
|
||||||
}));
|
|
||||||
return textResult(items);
|
|
||||||
},
|
|
||||||
);
|
|
||||||
|
|
||||||
// Connect via stdio
|
// Connect via stdio
|
||||||
const transport = new StdioServerTransport();
|
const transport = new StdioServerTransport();
|
||||||
await server.connect(transport);
|
await server.connect(transport);
|
||||||
|
|||||||
88
apps/coder/src/services/net/port-utils.ts
Normal file
88
apps/coder/src/services/net/port-utils.ts
Normal file
@@ -0,0 +1,88 @@
|
|||||||
|
/**
|
||||||
|
* Generic POSIX loopback-port utilities.
|
||||||
|
*
|
||||||
|
* Extracted verbatim (v2.7 audit reshape) from `backends/opencode-server.ts`,
|
||||||
|
* where they were embedded in the backend god-class. They have nothing to do with
|
||||||
|
* opencode semantics — they reclaim/await/allocate a 127.0.0.1 port — so they live
|
||||||
|
* here as reusable infra. No behavior change from the original.
|
||||||
|
*/
|
||||||
|
import { createServer, connect as netConnect } from 'node:net';
|
||||||
|
import { spawnSync } from 'node:child_process';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Reclaim a loopback port a dead child may still hold (lift of openchamber
|
||||||
|
* `killProcessOnPort`). Best-effort, POSIX-only (`lsof`/`kill`); a failure is
|
||||||
|
* harmless because the next spawn allocates a fresh ephemeral port. Never kills
|
||||||
|
* this process. Synchronous + short-timeout so a crash handler doesn't block.
|
||||||
|
*/
|
||||||
|
export function reclaimPort(port: number | null): void {
|
||||||
|
if (!port || process.platform === 'win32') return;
|
||||||
|
try {
|
||||||
|
const res = spawnSync('lsof', ['-ti', `:${port}`], { encoding: 'utf8', timeout: 3_000, windowsHide: true });
|
||||||
|
const out = res.stdout || '';
|
||||||
|
const myPid = process.pid;
|
||||||
|
for (const pidStr of out.split(/\s+/)) {
|
||||||
|
const pid = parseInt(pidStr.trim(), 10);
|
||||||
|
if (pid && pid !== myPid) {
|
||||||
|
try {
|
||||||
|
spawnSync('kill', ['-9', String(pid)], { stdio: 'ignore', timeout: 2_000 });
|
||||||
|
} catch {
|
||||||
|
// ignore — best effort
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} catch {
|
||||||
|
// lsof absent or failed — the fresh-ephemeral-port spawn doesn't need this.
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Resolve true once nothing is listening on `port` (lift of openchamber
|
||||||
|
* `waitForPortRelease`). Used before re-spawning on a fixed port; with ephemeral
|
||||||
|
* ports it's a fast no-op. Probes 127.0.0.1; resolves false at the deadline.
|
||||||
|
*/
|
||||||
|
export function waitForPortRelease(port: number, timeoutMs: number): Promise<boolean> {
|
||||||
|
const deadline = Date.now() + timeoutMs;
|
||||||
|
return new Promise((resolve) => {
|
||||||
|
const attempt = () => {
|
||||||
|
const socket = netConnect({ port, host: '127.0.0.1' });
|
||||||
|
let settled = false;
|
||||||
|
const finish = (released: boolean) => {
|
||||||
|
if (settled) return;
|
||||||
|
settled = true;
|
||||||
|
socket.removeAllListeners();
|
||||||
|
socket.destroy();
|
||||||
|
if (released || Date.now() >= deadline) {
|
||||||
|
resolve(released);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
setTimeout(attempt, 150);
|
||||||
|
};
|
||||||
|
socket.once('connect', () => finish(false));
|
||||||
|
socket.once('error', (err: NodeJS.ErrnoException) => {
|
||||||
|
if (err && (err.code === 'ECONNREFUSED' || err.code === 'EHOSTUNREACH')) finish(true);
|
||||||
|
else finish(false);
|
||||||
|
});
|
||||||
|
socket.setTimeout(500, () => finish(true));
|
||||||
|
};
|
||||||
|
attempt();
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Bind-probe an ephemeral port on loopback. */
|
||||||
|
export function freePort(): Promise<number> {
|
||||||
|
return new Promise((resolve, reject) => {
|
||||||
|
const srv = createServer();
|
||||||
|
srv.unref();
|
||||||
|
srv.on('error', reject);
|
||||||
|
srv.listen(0, '127.0.0.1', () => {
|
||||||
|
const addr = srv.address();
|
||||||
|
if (addr && typeof addr === 'object') {
|
||||||
|
const { port } = addr;
|
||||||
|
srv.close(() => resolve(port));
|
||||||
|
} else {
|
||||||
|
srv.close(() => reject(new Error('port-utils: could not determine a free port')));
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
}
|
||||||
@@ -21,72 +21,3 @@
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
export type AgentStatus = 'working' | 'blocked' | 'idle' | 'error';
|
export type AgentStatus = 'working' | 'blocked' | 'idle' | 'error';
|
||||||
|
|
||||||
/** The coarse signal a raw vendor event collapses to. */
|
|
||||||
export type AgentEventBucket = 'working' | 'blocked' | 'done';
|
|
||||||
|
|
||||||
// Each bucket lists the canonical vendor event names. Lookup is
|
|
||||||
// case-insensitive AND separator-insensitive (snake_case / camelCase /
|
|
||||||
// PascalCase all fold to the same key), so we normalize the raw input the same
|
|
||||||
// way before matching rather than enumerating every spelling here.
|
|
||||||
const WORKING_EVENTS = [
|
|
||||||
'SessionStart',
|
|
||||||
'UserPromptSubmit',
|
|
||||||
'UserPromptSubmitted',
|
|
||||||
'PostToolUse',
|
|
||||||
'PostToolUseFailure',
|
|
||||||
'BeforeAgent',
|
|
||||||
'AfterTool',
|
|
||||||
'task_started',
|
|
||||||
] as const;
|
|
||||||
|
|
||||||
const BLOCKED_EVENTS = [
|
|
||||||
'PreToolUse',
|
|
||||||
'Notification',
|
|
||||||
'PermissionRequest',
|
|
||||||
'exec_approval_request',
|
|
||||||
'apply_patch_approval_request',
|
|
||||||
'request_user_input',
|
|
||||||
] as const;
|
|
||||||
|
|
||||||
const DONE_EVENTS = [
|
|
||||||
'Stop',
|
|
||||||
'AfterAgent',
|
|
||||||
'SessionEnd',
|
|
||||||
'task_complete',
|
|
||||||
'agent-turn-complete',
|
|
||||||
] as const;
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Fold a raw event name to a separator/case-insensitive key:
|
|
||||||
* strip every non-alphanumeric character and lowercase. So `post_tool_use`,
|
|
||||||
* `postToolUse`, `PostToolUse`, and `POST-TOOL-USE` all map to `posttooluse`.
|
|
||||||
*/
|
|
||||||
function foldKey(raw: string): string {
|
|
||||||
return raw.replace(/[^a-z0-9]/gi, '').toLowerCase();
|
|
||||||
}
|
|
||||||
|
|
||||||
function buildLookup(
|
|
||||||
groups: ReadonlyArray<readonly [AgentEventBucket, readonly string[]]>,
|
|
||||||
): Map<string, AgentEventBucket> {
|
|
||||||
const map = new Map<string, AgentEventBucket>();
|
|
||||||
for (const [bucket, names] of groups) {
|
|
||||||
for (const name of names) map.set(foldKey(name), bucket);
|
|
||||||
}
|
|
||||||
return map;
|
|
||||||
}
|
|
||||||
|
|
||||||
const EVENT_LOOKUP = buildLookup([
|
|
||||||
['working', WORKING_EVENTS],
|
|
||||||
['blocked', BLOCKED_EVENTS],
|
|
||||||
['done', DONE_EVENTS],
|
|
||||||
]);
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Map a raw vendor hook-event name to its normalized bucket, or `null` when the
|
|
||||||
* name is unknown / undefined. Case- and separator-insensitive.
|
|
||||||
*/
|
|
||||||
export function normalizeAgentEvent(raw: string | undefined): AgentEventBucket | null {
|
|
||||||
if (!raw) return null;
|
|
||||||
return EVENT_LOOKUP.get(foldKey(raw)) ?? null;
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -21,7 +21,8 @@ import { readdir, stat } from 'node:fs/promises';
|
|||||||
import { join } from 'node:path';
|
import { join } from 'node:path';
|
||||||
import type { FastifyBaseLogger } from 'fastify';
|
import type { FastifyBaseLogger } from 'fastify';
|
||||||
import type { Sql } from '../db.js';
|
import type { Sql } from '../db.js';
|
||||||
import { WORKTREE_BASE, checkWorktreeWorkAtRisk } from './worktrees.js';
|
import { WORKTREE_BASE } from './worktrees.js';
|
||||||
|
import { checkWorktreeWorkAtRisk } from './worktree-risk.js';
|
||||||
import { hostExec } from './host-exec.js';
|
import { hostExec } from './host-exec.js';
|
||||||
import {
|
import {
|
||||||
selectOrphanWorktreeTargets,
|
selectOrphanWorktreeTargets,
|
||||||
|
|||||||
@@ -181,10 +181,6 @@ export async function rejectOne(sql: Sql, changeId: string): Promise<void> {
|
|||||||
await sql`UPDATE pending_changes SET status = 'rejected' WHERE id = ${changeId} AND status = 'pending'`;
|
await sql`UPDATE pending_changes SET status = 'rejected' WHERE id = ${changeId} AND status = 'pending'`;
|
||||||
}
|
}
|
||||||
|
|
||||||
export async function rejectAll(sql: Sql, sessionId: string): Promise<void> {
|
|
||||||
await sql`UPDATE pending_changes SET status = 'rejected' WHERE session_id = ${sessionId} AND status = 'pending'`;
|
|
||||||
}
|
|
||||||
|
|
||||||
// --- Rewind functions --------------------------------------------------------
|
// --- Rewind functions --------------------------------------------------------
|
||||||
|
|
||||||
export async function rewindOne(
|
export async function rewindOne(
|
||||||
|
|||||||
@@ -127,7 +127,3 @@ export function getResolvedRegistry(): Map<string, ResolvedProviderDef> {
|
|||||||
return cachedRegistry ?? buildResolvedRegistry(PROVIDERS, { providers: {} });
|
return cachedRegistry ?? buildResolvedRegistry(PROVIDERS, { providers: {} });
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Resolved provider ids in registry order. */
|
|
||||||
export function getResolvedProviderIds(): string[] {
|
|
||||||
return [...getResolvedRegistry().keys()];
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -26,9 +26,4 @@ export const WRITE_TOOLS: readonly ToolDef<any>[] = [
|
|||||||
checkTaskStatusTool,
|
checkTaskStatusTool,
|
||||||
];
|
];
|
||||||
|
|
||||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
||||||
export const WRITE_TOOLS_BY_NAME: ReadonlyMap<string, ToolDef<any>> = new Map(
|
|
||||||
WRITE_TOOLS.map((t) => [t.name, t]),
|
|
||||||
);
|
|
||||||
|
|
||||||
export { editFileTool, createFileTool, deleteFileTool, applyPendingTool, rewindTool, newTaskTool, listTasksTool, checkTaskStatusTool };
|
export { editFileTool, createFileTool, deleteFileTool, applyPendingTool, rewindTool, newTaskTool, listTasksTool, checkTaskStatusTool };
|
||||||
|
|||||||
175
apps/coder/src/services/worktree-risk.ts
Normal file
175
apps/coder/src/services/worktree-risk.ts
Normal file
@@ -0,0 +1,175 @@
|
|||||||
|
/**
|
||||||
|
* Worktree work-at-risk assessment (split out of `worktrees.ts`, v2.7 audit
|
||||||
|
* reshape). The git-worktree create/diff/remove lifecycle stays in `worktrees.ts`;
|
||||||
|
* this module owns the orthogonal "would deleting this worktree lose work?" gate
|
||||||
|
* the server consults before a session delete, plus the recoverable stash escape.
|
||||||
|
*
|
||||||
|
* Session delete itself lives in apps/server (Docker), which CANNOT see the host
|
||||||
|
* worktree dirs or run git on them — only BooCoder (host systemd) can — so the
|
||||||
|
* server calls the routes that wrap these helpers. Behavior is unchanged from the
|
||||||
|
* original worktrees.ts implementation.
|
||||||
|
*/
|
||||||
|
import { hostExec } from './host-exec.js';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Risk report for a single worktree, returned by checkWorktreeWorkAtRisk.
|
||||||
|
* `atRisk` is the gate the server reads before allowing a session delete.
|
||||||
|
* A git error never silently passes — it forces `atRisk` true and surfaces
|
||||||
|
* the message in `error` (fail-closed).
|
||||||
|
*/
|
||||||
|
export interface RiskReport {
|
||||||
|
worktreePath: string;
|
||||||
|
branch: string;
|
||||||
|
dirty: boolean; // uncommitted working-tree changes (incl. untracked)
|
||||||
|
unpushed: number; // commits ahead of upstream, or -1 if no upstream is set
|
||||||
|
unmerged: number; // commits on this branch not in the project default branch
|
||||||
|
atRisk: boolean; // dirty || unmerged > 0 || (upstream && unpushed > 0) || git error
|
||||||
|
error?: string; // populated on a git failure; presence forces atRisk
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Resolve the project's default branch as a git-usable ref (e.g. "origin/main").
|
||||||
|
*
|
||||||
|
* `refs/remotes/origin/HEAD` lives in the repo's COMMON git dir and is shared
|
||||||
|
* across every linked worktree, so reading it from the session worktree returns
|
||||||
|
* the REMOTE's default branch — never this worktree's own `session-<id>` branch
|
||||||
|
* (that would be `symbolic-ref HEAD`, a different ref). Falls back to probing
|
||||||
|
* common defaults by verified existence when origin/HEAD isn't set (e.g. a repo
|
||||||
|
* that never ran `git remote set-head`). Returns null if none resolve, in which
|
||||||
|
* case the unmerged check is skipped (dirty + unpushed still protect the work).
|
||||||
|
*/
|
||||||
|
async function detectDefaultBranchRef(
|
||||||
|
worktreePath: string,
|
||||||
|
opts?: { signal?: AbortSignal },
|
||||||
|
): Promise<string | null> {
|
||||||
|
const head = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} symbolic-ref --short refs/remotes/origin/HEAD`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
if (head.exitCode === 0) {
|
||||||
|
const ref = head.stdout.trim(); // e.g. "origin/main"
|
||||||
|
if (ref) {
|
||||||
|
const verify = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-parse --verify --quiet ${shellEscape(ref + '^{commit}')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
if (verify.exitCode === 0 && verify.stdout.trim()) return ref;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// origin/HEAD unset or unresolvable — probe common defaults. Prefer the
|
||||||
|
// remote-tracking ref (always resolvable in a fresh worktree) over the local
|
||||||
|
// head, which may not exist if the default branch lives only in the main tree.
|
||||||
|
for (const cand of ['origin/main', 'origin/master', 'main', 'master']) {
|
||||||
|
const verify = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-parse --verify --quiet ${shellEscape(cand + '^{commit}')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
if (verify.exitCode === 0 && verify.stdout.trim()) return cand;
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Inspect a worktree for work that would be lost if its session were deleted.
|
||||||
|
* Three checks, all via the audited hostExec + shellEscape path (every
|
||||||
|
* interpolated value — paths, refs — is single-quote-escaped; no bare
|
||||||
|
* interpolation). Any unexpected git failure is treated as at-risk, never a
|
||||||
|
* silent pass.
|
||||||
|
*/
|
||||||
|
export async function checkWorktreeWorkAtRisk(
|
||||||
|
worktreePath: string,
|
||||||
|
opts?: { signal?: AbortSignal },
|
||||||
|
): Promise<RiskReport> {
|
||||||
|
// Branch name — also doubles as the "is this still a git worktree?" probe.
|
||||||
|
const br = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-parse --abbrev-ref HEAD`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
if (br.exitCode !== 0) {
|
||||||
|
return {
|
||||||
|
worktreePath,
|
||||||
|
branch: '',
|
||||||
|
dirty: false,
|
||||||
|
unpushed: 0,
|
||||||
|
unmerged: 0,
|
||||||
|
atRisk: true,
|
||||||
|
error: `git rev-parse failed: ${br.stderr.trim() || 'not a git worktree'}`,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
const branch = br.stdout.trim();
|
||||||
|
|
||||||
|
// (a) Uncommitted (dirty working tree, including untracked files).
|
||||||
|
const st = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} status --porcelain`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 15_000 },
|
||||||
|
);
|
||||||
|
if (st.exitCode !== 0) {
|
||||||
|
return {
|
||||||
|
worktreePath,
|
||||||
|
branch,
|
||||||
|
dirty: false,
|
||||||
|
unpushed: 0,
|
||||||
|
unmerged: 0,
|
||||||
|
atRisk: true,
|
||||||
|
error: `git status failed: ${st.stderr.trim()}`,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
const dirty = st.stdout.trim().length > 0;
|
||||||
|
|
||||||
|
// (b) Unpushed commits. No upstream configured => work exists only locally;
|
||||||
|
// treat as unpushed-by-definition (-1) rather than an error.
|
||||||
|
const up = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-list --count ${shellEscape('@{u}..HEAD')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 15_000 },
|
||||||
|
);
|
||||||
|
const unpushed = up.exitCode === 0 ? (parseInt(up.stdout.trim() || '0', 10) || 0) : -1;
|
||||||
|
|
||||||
|
// (c) Unmerged commits — on this branch but not in the project default branch.
|
||||||
|
const defaultRef = await detectDefaultBranchRef(worktreePath, opts);
|
||||||
|
let unmerged = 0;
|
||||||
|
if (defaultRef) {
|
||||||
|
const rl = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-list --count ${shellEscape(defaultRef + '..HEAD')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 15_000 },
|
||||||
|
);
|
||||||
|
if (rl.exitCode === 0) unmerged = parseInt(rl.stdout.trim() || '0', 10) || 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
// unpushed only contributes when an upstream actually exists. Session branches
|
||||||
|
// (session-<id>) never have one (unpushed === -1), and any real local-only work
|
||||||
|
// there already surfaces as unmerged > 0 — so the no-upstream case adds no
|
||||||
|
// protection, only friction (it flagged every pristine worktree-backed session).
|
||||||
|
// The unpushed > 0 arm stays forward-compatible with P1.5 pushable branches.
|
||||||
|
const hasUpstream = unpushed !== -1;
|
||||||
|
const atRisk = dirty || unmerged > 0 || (hasUpstream && unpushed > 0);
|
||||||
|
return { worktreePath, branch, dirty, unpushed, unmerged, atRisk };
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Stash a worktree's uncommitted changes (including untracked, via -u) so the
|
||||||
|
* working tree is clean. Stash entries live in the repo's common git dir, so
|
||||||
|
* they survive worktree-dir removal — this is the recoverable, safe-by-default
|
||||||
|
* escape. Note it only clears the *dirty* risk; unpushed/unmerged commits
|
||||||
|
* remain on the branch, so a re-attempted delete may still block on those.
|
||||||
|
*/
|
||||||
|
export async function stashWorktree(
|
||||||
|
worktreePath: string,
|
||||||
|
opts?: { signal?: AbortSignal },
|
||||||
|
): Promise<{ stashed: boolean; error?: string }> {
|
||||||
|
const r = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} stash push -u -m ${shellEscape('boocode: pre-delete stash')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 30_000 },
|
||||||
|
);
|
||||||
|
if (r.exitCode !== 0) {
|
||||||
|
return { stashed: false, error: r.stderr.trim() || r.stdout.trim() };
|
||||||
|
}
|
||||||
|
// "No local changes to save" => exit 0, nothing stashed — not an error.
|
||||||
|
const stashed = !/no local changes to save/i.test(r.stdout);
|
||||||
|
return { stashed };
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Minimal shell escape for paths (single-quote wrapping). */
|
||||||
|
function shellEscape(s: string): string {
|
||||||
|
// Replace single quotes with escaped version, wrap in single quotes
|
||||||
|
return "'" + s.replace(/'/g, "'\\''") + "'";
|
||||||
|
}
|
||||||
@@ -8,6 +8,7 @@
|
|||||||
*/
|
*/
|
||||||
import type { Sql } from '../db.js';
|
import type { Sql } from '../db.js';
|
||||||
import { hostExec } from './host-exec.js';
|
import { hostExec } from './host-exec.js';
|
||||||
|
import { checkWorktreeWorkAtRisk } from './worktree-risk.js';
|
||||||
|
|
||||||
export const WORKTREE_BASE = '/tmp/booworktrees';
|
export const WORKTREE_BASE = '/tmp/booworktrees';
|
||||||
|
|
||||||
@@ -378,165 +379,6 @@ export async function rebaselineWorktreeAfterApply(
|
|||||||
return { rebaselined: true, newBaseCommit: newBase };
|
return { rebaselined: true, newBaseCommit: newBase };
|
||||||
}
|
}
|
||||||
|
|
||||||
// ─── Session-delete work-loss guard ─────────────────────────────────────────
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Risk report for a single worktree, returned by checkWorktreeWorkAtRisk.
|
|
||||||
* `atRisk` is the gate the server reads before allowing a session delete.
|
|
||||||
* A git error never silently passes — it forces `atRisk` true and surfaces
|
|
||||||
* the message in `error` (fail-closed).
|
|
||||||
*/
|
|
||||||
export interface RiskReport {
|
|
||||||
worktreePath: string;
|
|
||||||
branch: string;
|
|
||||||
dirty: boolean; // uncommitted working-tree changes (incl. untracked)
|
|
||||||
unpushed: number; // commits ahead of upstream, or -1 if no upstream is set
|
|
||||||
unmerged: number; // commits on this branch not in the project default branch
|
|
||||||
atRisk: boolean; // dirty || unmerged > 0 || (upstream && unpushed > 0) || git error
|
|
||||||
error?: string; // populated on a git failure; presence forces atRisk
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Resolve the project's default branch as a git-usable ref (e.g. "origin/main").
|
|
||||||
*
|
|
||||||
* `refs/remotes/origin/HEAD` lives in the repo's COMMON git dir and is shared
|
|
||||||
* across every linked worktree, so reading it from the session worktree returns
|
|
||||||
* the REMOTE's default branch — never this worktree's own `session-<id>` branch
|
|
||||||
* (that would be `symbolic-ref HEAD`, a different ref). Falls back to probing
|
|
||||||
* common defaults by verified existence when origin/HEAD isn't set (e.g. a repo
|
|
||||||
* that never ran `git remote set-head`). Returns null if none resolve, in which
|
|
||||||
* case the unmerged check is skipped (dirty + unpushed still protect the work).
|
|
||||||
*/
|
|
||||||
async function detectDefaultBranchRef(
|
|
||||||
worktreePath: string,
|
|
||||||
opts?: { signal?: AbortSignal },
|
|
||||||
): Promise<string | null> {
|
|
||||||
const head = await hostExec(
|
|
||||||
`git -C ${shellEscape(worktreePath)} symbolic-ref --short refs/remotes/origin/HEAD`,
|
|
||||||
{ signal: opts?.signal, timeoutMs: 10_000 },
|
|
||||||
);
|
|
||||||
if (head.exitCode === 0) {
|
|
||||||
const ref = head.stdout.trim(); // e.g. "origin/main"
|
|
||||||
if (ref) {
|
|
||||||
const verify = await hostExec(
|
|
||||||
`git -C ${shellEscape(worktreePath)} rev-parse --verify --quiet ${shellEscape(ref + '^{commit}')}`,
|
|
||||||
{ signal: opts?.signal, timeoutMs: 10_000 },
|
|
||||||
);
|
|
||||||
if (verify.exitCode === 0 && verify.stdout.trim()) return ref;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
// origin/HEAD unset or unresolvable — probe common defaults. Prefer the
|
|
||||||
// remote-tracking ref (always resolvable in a fresh worktree) over the local
|
|
||||||
// head, which may not exist if the default branch lives only in the main tree.
|
|
||||||
for (const cand of ['origin/main', 'origin/master', 'main', 'master']) {
|
|
||||||
const verify = await hostExec(
|
|
||||||
`git -C ${shellEscape(worktreePath)} rev-parse --verify --quiet ${shellEscape(cand + '^{commit}')}`,
|
|
||||||
{ signal: opts?.signal, timeoutMs: 10_000 },
|
|
||||||
);
|
|
||||||
if (verify.exitCode === 0 && verify.stdout.trim()) return cand;
|
|
||||||
}
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Inspect a worktree for work that would be lost if its session were deleted.
|
|
||||||
* Three checks, all via the audited hostExec + shellEscape path (every
|
|
||||||
* interpolated value — paths, refs — is single-quote-escaped; no bare
|
|
||||||
* interpolation). Any unexpected git failure is treated as at-risk, never a
|
|
||||||
* silent pass.
|
|
||||||
*/
|
|
||||||
export async function checkWorktreeWorkAtRisk(
|
|
||||||
worktreePath: string,
|
|
||||||
opts?: { signal?: AbortSignal },
|
|
||||||
): Promise<RiskReport> {
|
|
||||||
// Branch name — also doubles as the "is this still a git worktree?" probe.
|
|
||||||
const br = await hostExec(
|
|
||||||
`git -C ${shellEscape(worktreePath)} rev-parse --abbrev-ref HEAD`,
|
|
||||||
{ signal: opts?.signal, timeoutMs: 10_000 },
|
|
||||||
);
|
|
||||||
if (br.exitCode !== 0) {
|
|
||||||
return {
|
|
||||||
worktreePath,
|
|
||||||
branch: '',
|
|
||||||
dirty: false,
|
|
||||||
unpushed: 0,
|
|
||||||
unmerged: 0,
|
|
||||||
atRisk: true,
|
|
||||||
error: `git rev-parse failed: ${br.stderr.trim() || 'not a git worktree'}`,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
const branch = br.stdout.trim();
|
|
||||||
|
|
||||||
// (a) Uncommitted (dirty working tree, including untracked files).
|
|
||||||
const st = await hostExec(
|
|
||||||
`git -C ${shellEscape(worktreePath)} status --porcelain`,
|
|
||||||
{ signal: opts?.signal, timeoutMs: 15_000 },
|
|
||||||
);
|
|
||||||
if (st.exitCode !== 0) {
|
|
||||||
return {
|
|
||||||
worktreePath,
|
|
||||||
branch,
|
|
||||||
dirty: false,
|
|
||||||
unpushed: 0,
|
|
||||||
unmerged: 0,
|
|
||||||
atRisk: true,
|
|
||||||
error: `git status failed: ${st.stderr.trim()}`,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
const dirty = st.stdout.trim().length > 0;
|
|
||||||
|
|
||||||
// (b) Unpushed commits. No upstream configured => work exists only locally;
|
|
||||||
// treat as unpushed-by-definition (-1) rather than an error.
|
|
||||||
const up = await hostExec(
|
|
||||||
`git -C ${shellEscape(worktreePath)} rev-list --count ${shellEscape('@{u}..HEAD')}`,
|
|
||||||
{ signal: opts?.signal, timeoutMs: 15_000 },
|
|
||||||
);
|
|
||||||
const unpushed = up.exitCode === 0 ? (parseInt(up.stdout.trim() || '0', 10) || 0) : -1;
|
|
||||||
|
|
||||||
// (c) Unmerged commits — on this branch but not in the project default branch.
|
|
||||||
const defaultRef = await detectDefaultBranchRef(worktreePath, opts);
|
|
||||||
let unmerged = 0;
|
|
||||||
if (defaultRef) {
|
|
||||||
const rl = await hostExec(
|
|
||||||
`git -C ${shellEscape(worktreePath)} rev-list --count ${shellEscape(defaultRef + '..HEAD')}`,
|
|
||||||
{ signal: opts?.signal, timeoutMs: 15_000 },
|
|
||||||
);
|
|
||||||
if (rl.exitCode === 0) unmerged = parseInt(rl.stdout.trim() || '0', 10) || 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
// unpushed only contributes when an upstream actually exists. Session branches
|
|
||||||
// (session-<id>) never have one (unpushed === -1), and any real local-only work
|
|
||||||
// there already surfaces as unmerged > 0 — so the no-upstream case adds no
|
|
||||||
// protection, only friction (it flagged every pristine worktree-backed session).
|
|
||||||
// The unpushed > 0 arm stays forward-compatible with P1.5 pushable branches.
|
|
||||||
const hasUpstream = unpushed !== -1;
|
|
||||||
const atRisk = dirty || unmerged > 0 || (hasUpstream && unpushed > 0);
|
|
||||||
return { worktreePath, branch, dirty, unpushed, unmerged, atRisk };
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Stash a worktree's uncommitted changes (including untracked, via -u) so the
|
|
||||||
* working tree is clean. Stash entries live in the repo's common git dir, so
|
|
||||||
* they survive worktree-dir removal — this is the recoverable, safe-by-default
|
|
||||||
* escape. Note it only clears the *dirty* risk; unpushed/unmerged commits
|
|
||||||
* remain on the branch, so a re-attempted delete may still block on those.
|
|
||||||
*/
|
|
||||||
export async function stashWorktree(
|
|
||||||
worktreePath: string,
|
|
||||||
opts?: { signal?: AbortSignal },
|
|
||||||
): Promise<{ stashed: boolean; error?: string }> {
|
|
||||||
const r = await hostExec(
|
|
||||||
`git -C ${shellEscape(worktreePath)} stash push -u -m ${shellEscape('boocode: pre-delete stash')}`,
|
|
||||||
{ signal: opts?.signal, timeoutMs: 30_000 },
|
|
||||||
);
|
|
||||||
if (r.exitCode !== 0) {
|
|
||||||
return { stashed: false, error: r.stderr.trim() || r.stdout.trim() };
|
|
||||||
}
|
|
||||||
// "No local changes to save" => exit 0, nothing stashed — not an error.
|
|
||||||
const stashed = !/no local changes to save/i.test(r.stdout);
|
|
||||||
return { stashed };
|
|
||||||
}
|
|
||||||
|
|
||||||
/** Minimal shell escape for paths (single-quote wrapping). */
|
/** Minimal shell escape for paths (single-quote wrapping). */
|
||||||
function shellEscape(s: string): string {
|
function shellEscape(s: string): string {
|
||||||
// Replace single quotes with escaped version, wrap in single quotes
|
// Replace single quotes with escaped version, wrap in single quotes
|
||||||
|
|||||||
2
apps/coder/web/vite.config.d.ts
vendored
2
apps/coder/web/vite.config.d.ts
vendored
@@ -1,2 +0,0 @@
|
|||||||
declare const _default: import("vite").UserConfig;
|
|
||||||
export default _default;
|
|
||||||
@@ -1,25 +0,0 @@
|
|||||||
import { defineConfig } from 'vite';
|
|
||||||
import react from '@vitejs/plugin-react';
|
|
||||||
import path from 'node:path';
|
|
||||||
export default defineConfig({
|
|
||||||
plugins: [react()],
|
|
||||||
resolve: {
|
|
||||||
alias: {
|
|
||||||
'@': path.resolve(__dirname, './src'),
|
|
||||||
},
|
|
||||||
},
|
|
||||||
server: {
|
|
||||||
port: 5174,
|
|
||||||
proxy: {
|
|
||||||
'/api': {
|
|
||||||
target: 'http://127.0.0.1:3000',
|
|
||||||
changeOrigin: true,
|
|
||||||
ws: true,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
build: {
|
|
||||||
outDir: 'dist',
|
|
||||||
emptyOutDir: true,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
48
apps/server/CLAUDE.md
Normal file
48
apps/server/CLAUDE.md
Normal file
@@ -0,0 +1,48 @@
|
|||||||
|
# apps/server — BooChat backend (deep reference)
|
||||||
|
|
||||||
|
> Per-app engineering notes for `apps/server/src/`. Cross-cutting commands, database, environment, workflow, and cross-app contracts (WS-frame / provider-type parity, sentinels) live in the **root `CLAUDE.md`**. This file auto-loads when you read/edit files under `apps/server/`.
|
||||||
|
|
||||||
|
## Stack
|
||||||
|
|
||||||
|
- **Fastify** with `@fastify/websocket` and `@fastify/static` (serves the built frontend).
|
||||||
|
- **postgres** (porsager/postgres) with tagged-template SQL — no ORM. Schema in `schema.sql`, applied on startup. LSP may false-positive on `sql<Type[]>\`...\`` generics; CLI `tsc` / `pnpm build` is authoritative.
|
||||||
|
- **Zod** for request validation and config parsing.
|
||||||
|
|
||||||
|
## Key services
|
||||||
|
|
||||||
|
- **`services/inference/`** — Public surface re-exported via `inference/index.ts`; callers import from `./services/inference/index.js` explicitly (NodeNext doesn't honor directory-index resolution). Layout: `turn.ts` (runAssistantTurn/runInference/createInferenceRunner; exports `InferenceFrame`, `InferenceContext`, `TurnArgs`, `StreamResult`, `MAX_STEPS`); `stream-phase.ts` (streamCompletion AI SDK adapter + executeStreamPhase); `provider.ts` (`upstreamModel(baseURL, modelId)` wrapping `createOpenAICompatible` against llama-swap); `tool-phase.ts` (executeToolPhase → `ToolPhaseResult`; the turn loop lives in turn.ts, not recursion); `sentinel-summaries.ts` (cap-hit/doom-loop/step-cap summaries + inserters); `error-handler.ts` (handleAbortOrError, finalizeCompletion); `payload.ts` (buildMessagesPayload, loadContext, maybeFlagForCompaction, `OpenAiMessage`); `sentinels.ts` (`detectDoomLoop`, `DOOM_LOOP_THRESHOLD`); `budget.ts` (resolveToolBudget); `xml-parser.ts` (qwen3.6 XML tool-call fallback — KEEP, AI SDK doesn't handle inline-XML tool calls); `parts.ts` (`partsFromAssistantMessage`/`partsFromToolMessage`/`insertParts` — parts are the sole source of truth); `prune.ts` (two-tier compaction; `selectPruneTargets` is the pure helper); `types.ts` (`StreamPhaseState`, `DB_FLUSH_INTERVAL_MS`). **`TurnArgs`** is the per-turn state envelope, reset in `runInference` at the user-message boundary. Outer loop: `while (stepNumber < effectiveCap)`, `effectiveCap = Math.min(agent.steps ?? Infinity, MAX_STEPS=200)`. Per-agent `steps:` in AGENTS.md frontmatter; `steps: 0` = text-only. Step-cap hit writes a `cap_hit` sentinel (`CapHitSentinel.tsx` renders it).
|
||||||
|
- **AI SDK v6 streamCompletion adapter** (`services/inference/stream-phase.ts`). `streamText` is the underlying call; the BooCode layer (executeStreamPhase, finalize, dual-write) is shape-preserved via an adapter. Five gotchas the LSP/tests won't catch:
|
||||||
|
- **Abort signals are swallowed.** `streamText`'s `fullStream` exits cleanly when `abortSignal` fires — no throw. Post-iteration `if (signal?.aborted) throw <AbortError>` is required, else the row finalizes `complete` instead of `cancelled`. Don't refactor away the pinning comment.
|
||||||
|
- **Usage lands only at stream end** via `await result.usage` (v6 `inputTokens`/`outputTokens` → mapped to `promptTokens`/`completionTokens`). No mid-stream tok/s; ChatThroughput shows one value at stream end.
|
||||||
|
- **Tools have NO `execute` field.** BooCode dispatches tools in tool-phase.ts, not the AI SDK loop — only `description` + `inputSchema: jsonSchema(parameters)`.
|
||||||
|
- **`includeUsage: true` MUST be set on `createOpenAICompatible`** in `provider.ts`. The adapter defaults it false → no `stream_options.include_usage` → llama-swap emits no usage block → `result.usage` resolves `undefined` (NULL token counts). Don't remove during refactor.
|
||||||
|
- **Tool-call-only turns may emit a leading `\n` text-delta.** `MessageList.flatten`'s `hasText` and `MessageBubble`'s `hasContent` both `.trim()` before the length check, else whitespace-only content renders an empty bubble + ActionRow between tool calls. `buildMessagesPayload` also skips `status='failed'` and complete-but-empty assistant rows (avoids "Cannot have 2 or more assistant messages at the end of the list" upstream rejection after cap-hit + Continue).
|
||||||
|
- **AI SDK ModelMessage conversion** (`toModelMessages` in stream-phase.ts). Tool messages need a `toolName` for `ToolResultPart`; BooCode's OpenAI-shape history lacks it, so a forward-scan builds a `tool_call_id → toolName` map from prior assistant `tool_calls`. Tool outputs wrapped as `{ type: 'json' | 'text', value }` (v6 `ToolResultOutput`). Reasoning emits a `ReasoningPart` first in the content array.
|
||||||
|
- **`experimental_repairToolCall`** wired into `streamText` to keep the stream alive when qwen3.6 emits malformed tool args. Pass-through: logs the bad call, returns it unmodified; `executeToolPhase`'s zod-reject path routes it back to the model next turn.
|
||||||
|
- **`chat_status` frame** (via `broker.publishUser`) — `status: 'streaming' | 'tool_running' | 'waiting_for_input' | 'idle' | 'error'`. Frontend `useChatStatus` derives `idle_warm` (<30s since idle) vs `idle_cold`. `ChatThroughput` renders beside `StatusDot` only when streaming/tool_running, fed by 500ms-throttled `'usage'` frames (`completion_tokens` + `ctx_used` + `ctx_max`). `POST /api/chats/:id/discard_stale` marks a stuck-streaming row `failed` when the frontend's 60s no-token timer gives up.
|
||||||
|
- **Stale-streaming sweeps** (`apps/server/src/index.ts`): a boot-time pass after `applySchema()` and a periodic 60s `setInterval` both flip `messages.status='streaming'` older than 5 min to `failed` (publishing `chat_status='idle'`); the interval also runs `cleanupTruncations` (TTL + orphan reap of tmpfs truncation files). `onClose` hook clears the timer. Recovers from a container restart mid-stream.
|
||||||
|
- **`services/broker.ts`** — In-memory pub/sub, two channel types: per-session (message streaming) and per-user (sidebar). No persistence; clients reconnect on restart. Every WS publish goes through `broker.publishFrame(sessionId, frame)` / `publishUserFrame(user, frame)` — both Zod-validate against `WsFrameSchema` (`types/ws-frames.ts`) and fail-closed (log + drop). Schema duplicated byte-identical at `apps/web/src/api/ws-frames.ts`; `ws-frames.test.ts` enforces parity. Don't add raw `broker.publish()`/`publishUser()` calls.
|
||||||
|
- **`services/tools.ts`** — Tool registry (`ALL_TOOLS`, `READ_ONLY_TOOL_NAMES`, `TOOLS_BY_NAME`). Filesystem tools (view_file/list_dir/grep/find_files) pass three guards: `path_guard.ts` (workspace scope), `secret_guard.ts` (filename deny list), `url_guard.ts` (SSRF/private-IP block for web_fetch). Web tools (`web_search`, `web_fetch`) are opt-in per chat via `session.web_search_enabled` (falls back to `project.default_web_search_enabled`) and filtered out of the LLM tool schema when false. Truncation: when a tool slice cuts content, `services/truncate.ts` stashes the full text on tmpfs (`BOOCODE_TRUNCATION_DIR`, default `/tmp/boocode-truncations`, 0o700) keyed by `tr_<12 base32>`; `view_truncated_output(id)` retrieves it. 5MB cap, 7-day TTL, reaped by the sweeper. Container restart loses retrieval — acceptable.
|
||||||
|
- **`services/compaction.ts`** + **`services/model-context.ts`** — Anchored rolling summary (single `summary=true` assistant row per chat, supersedes itself each compaction). Triggered when `chats.needs_compaction` is set after a turn exceeds `usable(ctx_max) = floor(0.85 × ctx_max)`. **`ctx_max` comes from `model-context.getModelContext()` fetching `${LLAMA_SWAP_URL}/upstream/<model>/props`** — NOT from `parsed.timings.n_ctx`. First inferences after boot may have `ctx_max=NULL` if llama-swap hasn't loaded the model; negative cache TTL 60s, recovers next turn. `buildHeadPayload` embeds `reasoning_parts` as a `<reasoning>...</reasoning>` prose prefix on assistant `content` (OpenAI wire shape has no structured reasoning field); standalone tag when content is empty. `buildHeadPayload` + `OpenAiMessage` exported for tests — keep them exported.
|
||||||
|
- **`services/system-prompt.ts`** — `buildSystemPrompt` is the string shim; `buildSystemPromptWithFingerprint` is the canonical impl returning `{prompt, fingerprint, drift}`. SHA-256 of the assembled prefix is logged per `buildMessagesPayload` (`prefix-fingerprint`, info); a `Map<sessionId, lastHash>` fires `prefix-drift` (warn) on change with a `changed_inputs` diff. The prefix is byte-stable in steady-state, so prefix caching is left to the input-layer mtime caches (BOOCHAT.md + AGENTS.md global/per-project in `agents.ts:safeStat`).
|
||||||
|
- **`services/inference/budget.ts`** — tool-call budgets: `BUDGET_READ_ONLY = 30`, `BUDGET_NON_READ_ONLY = 10` (forward-looking; no write tools yet), `BUDGET_NO_AGENT = 30` (every `ALL_TOOLS` tool is read-only today, so no-agent shares the read-only cap). Per-agent `max_tool_calls` from AGENTS.md overrides.
|
||||||
|
- **`messages_with_parts` view** (`schema.sql`). Read sites needing `tool_calls` / `tool_results` / `reasoning_parts` SELECT from this view, NOT `messages` — the legacy `messages.tool_calls`/`tool_results` JSON columns were dropped; the view reads parts-only subselects. Writes target `message_parts` via `insertParts` (or `partsFromAssistantMessage`/`partsFromToolMessage`). The `Message` wire type still carries `tool_calls?`/`tool_results?` because the view synthesizes them. Shapes: `tool_calls jsonb[]`, `tool_results jsonb` (single object), `reasoning_parts jsonb[]` of `{text}`. To UPDATE a message and return its full shape, do a two-step UPDATE returning `id` then SELECT from the view — RETURNING off bare `messages` no longer carries the tool fields. **`messages.model`** (attribution chip) stamps the model per assistant turn — at `finalizeCompletion` (BooChat + native coder) + the dispatcher's assistant-row INSERT (external coder); read via the view + the `message_complete` frame, rendered by `shortenModelName`.
|
||||||
|
- **`services/file_ops.ts`** — Shared file operation implementations used by both inference tools and HTTP routes.
|
||||||
|
- **`services/auto_name.ts`** — Non-streaming LLM call to generate 4-word session titles after the first assistant reply.
|
||||||
|
- **Provider picker dispatch**: when `provider !== 'boocode'`, the message route creates a `tasks` row (with `session_id` set) instead of calling `inference.enqueue`. The dispatcher (in `apps/coder`) picks it up and dispatches via ACP or PTY using the agent's `install_path`.
|
||||||
|
|
||||||
|
Route registration: all routes registered in `index.ts` via `register*Routes(app, sql, ...)`. Routes live in `routes/*.ts`.
|
||||||
|
|
||||||
|
## Server conventions
|
||||||
|
|
||||||
|
- **New tools** live in their own `services/<name>.ts` (see `web_search.ts`, `web_fetch.ts`) — a pure `executeFoo(input, ...deps)` for direct test access plus a `ToolDef` wrapper that `loadConfig()`s its real deps. Register the ToolDef in `tools.ts` `ALL_TOOLS` (and `READ_ONLY_TOOL_NAMES` if applicable). Inject `fetcher: typeof fetch = fetch` rather than `vi.spyOn(globalThis, 'fetch')`.
|
||||||
|
- **DB/session-aware tools** take an optional 4th `ToolExecCtx { sql, sessionId }` arg on `ToolDef.execute`, plumbed `executeToolPhase`→`executeToolCall`→`execute`. Optional so filesystem tools and the `apps/coder` `ALL_TOOLS` consumer stay compatible; filesystem tools ignore it. `read_tab_by_number` is the reference.
|
||||||
|
- **ReadableStream test stubs** use `pull()` (not `start()`) so chunks are produced lazily — `start()` enqueues everything and closes before the consumer reads, so a later `reader.cancel()` finds the stream closed and the `cancel()` callback never fires. Provide MORE chunks than the test consumes so the source stays 'readable' when cancel runs.
|
||||||
|
- Tool-name whitelists must derive from `ALL_TOOLS` in `services/tools.ts`, never hardcoded (this drift class hit `services/agents.ts` `ALL_TOOL_NAMES` before).
|
||||||
|
- Agent registry lives at `data/AGENTS.md` (global, bind-mounted at `/data/AGENTS.md`). No per-project `AGENTS.md` in this repo (removed to eliminate two-files-must-stay-in-sync drift); the `getAgentsForProject` per-project override mechanism remains for *other* projects.
|
||||||
|
- `data/AGENTS.md` is PARSED (`agents.ts` `splitSections`/`parseAgentSection`): each `## <Name>` is one agent and must be followed by a `---` frontmatter fence or the block throws; content before the first `## ` is discarded. Do NOT add free-form `## ` rule sections — they break the registry. Cross-cutting agent rules go in CLAUDE.md or a parser-ignored preamble.
|
||||||
|
- MCP stdio transport uses newline-delimited JSON (NDJSON), NOT LSP-style `Content-Length` headers. `codecontext/shim.go` is the reference (per the MCP spec, modelcontextprotocol.io/specification/server/transports).
|
||||||
|
- **`payload.ts:loadContext` SELECT** must include every `Session` field downstream code reads. The tool phase reads `session.allowed_read_paths`; if the SELECT omits it, cross-repo read grants silently fail. `sql<Session[]>` doesn't enforce column coverage, so the type doesn't catch it.
|
||||||
|
- **Sidecar routing** (`services/inference/provider.ts`): `upstreamModel(config, modelId, agent)` routes to `LLAMA_SIDECAR_URL` when the agent has `llama_extra_args`, else `LLAMA_SWAP_URL`. `resolveRoute(agent)` returns `{route, flags}`. Sidecar provider created fresh per call (not cached) because `X-Agent-Flags` varies per agent. Boot-time guard in `index.ts` refuses to start if any agent has `llama_extra_args` but `LLAMA_SIDECAR_URL` is unset.
|
||||||
|
- **Secret guard safe patterns** (`services/secret_guard.ts`): `.env.example`, `.env.sample`, `.env.template`, `.env.defaults` are allowlisted via `SAFE_PATTERNS`. Do NOT add `.env.production`/`.env.development`/`.env.test` — those can hold real secrets.
|
||||||
|
- **llama-sidecar** (`/opt/forks/llama-sidecar/`): Go daemon for a per-agent llama-server process pool (routed to via "Sidecar routing" above). Cross-compile: `GOOS=windows GOARCH=amd64 /snap/go/current/bin/go build -o bin/llama-sidecar.exe ./cmd/llama-sidecar`. Gitea: `indifferentketchup/llama-sidecar`. Windows child-process gotchas: `context.Background()` for child lifetime (not request ctx), `os.Open(os.DevNull)` for stdin, `os.Pipe()` for stdout with a drain goroutine, `DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP` flags. SSH to sam-desktop: `ssh samki@100.101.41.16`; use `schtasks` for persistent spawning (SSH `start /B` doesn't survive session close).
|
||||||
@@ -18,7 +18,6 @@ const ConfigSchema = z.object({
|
|||||||
GITEA_BASE_URL: z.string().url().default('https://git.indifferentketchup.com'),
|
GITEA_BASE_URL: z.string().url().default('https://git.indifferentketchup.com'),
|
||||||
GITEA_USER: z.string().default('indifferentketchup'),
|
GITEA_USER: z.string().default('indifferentketchup'),
|
||||||
GITEA_TOKEN: z.string().optional(),
|
GITEA_TOKEN: z.string().optional(),
|
||||||
GITEA_SSH_HOST: z.string().default('100.114.205.53:2222'),
|
|
||||||
// v1.15.0-mcp-multi: path to the MCP config JSON file. Default /data/mcp.json
|
// v1.15.0-mcp-multi: path to the MCP config JSON file. Default /data/mcp.json
|
||||||
// (bind-mounted alongside AGENTS.md). File missing = no MCP (opt-in).
|
// (bind-mounted alongside AGENTS.md). File missing = no MCP (opt-in).
|
||||||
MCP_CONFIG_PATH: z.string().optional(),
|
MCP_CONFIG_PATH: z.string().optional(),
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import type { Broker } from '../services/broker.js';
|
|||||||
import type { Chat, Message } from '../types/api.js';
|
import type { Chat, Message } from '../types/api.js';
|
||||||
import { getModelContext } from '../services/model-context.js';
|
import { getModelContext } from '../services/model-context.js';
|
||||||
import { notifyCoderClose } from '../services/coder-notify.js';
|
import { notifyCoderClose } from '../services/coder-notify.js';
|
||||||
|
import { MESSAGE_COLUMNS } from '../services/message-columns.js';
|
||||||
|
|
||||||
const CreateBody = z.object({
|
const CreateBody = z.object({
|
||||||
name: z.string().min(1).max(200).optional(),
|
name: z.string().min(1).max(200).optional(),
|
||||||
@@ -439,9 +440,7 @@ export function registerChatRoutes(
|
|||||||
}
|
}
|
||||||
// v1.13.1-B: reads tool_calls/tool_results via the parts-merged view.
|
// v1.13.1-B: reads tool_calls/tool_results via the parts-merged view.
|
||||||
const rows = await sql<Message[]>`
|
const rows = await sql<Message[]>`
|
||||||
SELECT id, session_id, chat_id, role, content, kind, tool_calls, tool_results, status, last_seq,
|
SELECT ${sql.unsafe(MESSAGE_COLUMNS)}
|
||||||
tokens_used, ctx_used, ctx_max, started_at, finished_at, created_at, metadata,
|
|
||||||
summary, tail_start_id, compacted_at, model
|
|
||||||
FROM messages_with_parts
|
FROM messages_with_parts
|
||||||
WHERE chat_id = ${req.params.id}
|
WHERE chat_id = ${req.params.id}
|
||||||
ORDER BY created_at ASC, id ASC
|
ORDER BY created_at ASC, id ASC
|
||||||
|
|||||||
@@ -8,6 +8,81 @@ import type { Chat, Message, Session, ToolCall } from '../types/api.js';
|
|||||||
// decision time (not at request time) so concurrent project changes don't
|
// decision time (not at request time) so concurrent project changes don't
|
||||||
// stale-bind the resolution.
|
// stale-bind the resolution.
|
||||||
import { resolveGrantRoot } from '../services/grant_resolver.js';
|
import { resolveGrantRoot } from '../services/grant_resolver.js';
|
||||||
|
import { MESSAGE_COLUMNS } from '../services/message-columns.js';
|
||||||
|
|
||||||
|
// Shared lookup for the answer_user_input + grant_read_access pause-resume
|
||||||
|
// endpoints. Finds the originating assistant tool_call by id in message_parts,
|
||||||
|
// validates the tool name, finds the pending tool_result part, and checks the
|
||||||
|
// already-answered guard. Returns ok:true+context on success, ok:false+HTTP
|
||||||
|
// status+body on any error (caller does reply.code(ctx.code); return ctx.body).
|
||||||
|
type PendingToolLookupResult =
|
||||||
|
| {
|
||||||
|
ok: true;
|
||||||
|
foundCall: ToolCall;
|
||||||
|
toolMessageId: string;
|
||||||
|
toolRow: { message_id: string; payload: { tool_call_id: string; output: unknown } };
|
||||||
|
}
|
||||||
|
| { ok: false; code: number; body: Record<string, unknown> };
|
||||||
|
|
||||||
|
async function lookupPendingToolCall(
|
||||||
|
sql: Sql,
|
||||||
|
chatId: string,
|
||||||
|
tool_call_id: string,
|
||||||
|
expectedToolName: string,
|
||||||
|
wrongToolError: string,
|
||||||
|
): Promise<PendingToolLookupResult> {
|
||||||
|
// Find the assistant's tool_call by id via message_parts.
|
||||||
|
const callerRows = await sql<{
|
||||||
|
message_id: string;
|
||||||
|
payload: { id: string; name: string; args: Record<string, unknown> };
|
||||||
|
}[]>`
|
||||||
|
SELECT p.message_id, p.payload
|
||||||
|
FROM message_parts p
|
||||||
|
JOIN messages m ON m.id = p.message_id
|
||||||
|
WHERE m.chat_id = ${chatId}
|
||||||
|
AND m.role = 'assistant'
|
||||||
|
AND p.kind = 'tool_call'
|
||||||
|
AND p.payload->>'id' = ${tool_call_id}
|
||||||
|
ORDER BY m.created_at DESC
|
||||||
|
LIMIT 1
|
||||||
|
`;
|
||||||
|
const callerRow = callerRows[0];
|
||||||
|
if (!callerRow) return { ok: false, code: 404, body: { error: 'unknown_tool_call_id' } };
|
||||||
|
|
||||||
|
const foundCall: ToolCall = {
|
||||||
|
id: callerRow.payload.id,
|
||||||
|
name: callerRow.payload.name,
|
||||||
|
args: callerRow.payload.args,
|
||||||
|
};
|
||||||
|
if (foundCall.name !== expectedToolName) {
|
||||||
|
return { ok: false, code: 400, body: { error: wrongToolError } };
|
||||||
|
}
|
||||||
|
|
||||||
|
// Find the pending tool_result part by tool_call_id.
|
||||||
|
const toolRows = await sql<{
|
||||||
|
message_id: string;
|
||||||
|
payload: { tool_call_id: string; output: unknown };
|
||||||
|
}[]>`
|
||||||
|
SELECT p.message_id, p.payload
|
||||||
|
FROM message_parts p
|
||||||
|
JOIN messages m ON m.id = p.message_id
|
||||||
|
WHERE m.chat_id = ${chatId}
|
||||||
|
AND m.role = 'tool'
|
||||||
|
AND p.kind = 'tool_result'
|
||||||
|
AND p.payload->>'tool_call_id' = ${tool_call_id}
|
||||||
|
ORDER BY m.created_at DESC
|
||||||
|
LIMIT 1
|
||||||
|
`;
|
||||||
|
const toolRow = toolRows[0];
|
||||||
|
if (!toolRow) {
|
||||||
|
return { ok: false, code: 404, body: { error: 'unknown_tool_call_id', detail: 'tool message not found' } };
|
||||||
|
}
|
||||||
|
if (toolRow.payload && toolRow.payload.output !== null) {
|
||||||
|
return { ok: false, code: 409, body: { error: 'tool_call_already_answered' } };
|
||||||
|
}
|
||||||
|
|
||||||
|
return { ok: true, foundCall, toolMessageId: toolRow.message_id, toolRow };
|
||||||
|
}
|
||||||
|
|
||||||
const SendBody = z.object({
|
const SendBody = z.object({
|
||||||
content: z.string().min(1).max(64_000),
|
content: z.string().min(1).max(64_000),
|
||||||
@@ -116,9 +191,7 @@ export function registerMessageRoutes(
|
|||||||
// see services/inference.ts loadContext + services/compaction.ts.
|
// see services/inference.ts loadContext + services/compaction.ts.
|
||||||
// v1.13.1-B: reads tool_calls/tool_results via the parts-merged view.
|
// v1.13.1-B: reads tool_calls/tool_results via the parts-merged view.
|
||||||
const rows = await sql<Message[]>`
|
const rows = await sql<Message[]>`
|
||||||
SELECT id, session_id, chat_id, role, content, kind, tool_calls, tool_results, status, last_seq,
|
SELECT ${sql.unsafe(MESSAGE_COLUMNS)}
|
||||||
tokens_used, ctx_used, ctx_max, started_at, finished_at, created_at, metadata,
|
|
||||||
summary, tail_start_id, compacted_at, model
|
|
||||||
FROM messages_with_parts
|
FROM messages_with_parts
|
||||||
WHERE session_id = ${req.params.id}
|
WHERE session_id = ${req.params.id}
|
||||||
ORDER BY created_at ASC, id ASC
|
ORDER BY created_at ASC, id ASC
|
||||||
@@ -493,40 +566,16 @@ export function registerMessageRoutes(
|
|||||||
const chat = chatRows[0]!;
|
const chat = chatRows[0]!;
|
||||||
const sessionId = chat.session_id;
|
const sessionId = chat.session_id;
|
||||||
|
|
||||||
// v1.13.1-C: find the assistant's tool_call by indexing message_parts
|
// v1.13.1-C: resolve the originating tool_call + pending tool row.
|
||||||
// directly on payload->>'id'. Scoped by chat_id + role via the JOIN.
|
// Pre-v1.13.0 history has no parts rows — those become unreachable (404).
|
||||||
// Pre-v1.13.0 history has no parts rows — those tool_calls become
|
const ctx = await lookupPendingToolCall(
|
||||||
// unreachable here (404). Acceptable per the dispatch decision: any
|
sql, chat.id, tool_call_id, 'ask_user_input', 'tool_call_not_ask_user_input',
|
||||||
// pending elicitation from before v1.13.0 is long timed out by now;
|
);
|
||||||
// promote to a hotfix with a JSON-column fallback if it ever surfaces.
|
if (!ctx.ok) {
|
||||||
const callerRows = await sql<{
|
reply.code(ctx.code);
|
||||||
message_id: string;
|
return ctx.body;
|
||||||
payload: { id: string; name: string; args: Record<string, unknown> };
|
|
||||||
}[]>`
|
|
||||||
SELECT p.message_id, p.payload
|
|
||||||
FROM message_parts p
|
|
||||||
JOIN messages m ON m.id = p.message_id
|
|
||||||
WHERE m.chat_id = ${chat.id}
|
|
||||||
AND m.role = 'assistant'
|
|
||||||
AND p.kind = 'tool_call'
|
|
||||||
AND p.payload->>'id' = ${tool_call_id}
|
|
||||||
ORDER BY m.created_at DESC
|
|
||||||
LIMIT 1
|
|
||||||
`;
|
|
||||||
const callerRow = callerRows[0];
|
|
||||||
if (!callerRow) {
|
|
||||||
reply.code(404);
|
|
||||||
return { error: 'unknown_tool_call_id' };
|
|
||||||
}
|
|
||||||
const foundCall: ToolCall = {
|
|
||||||
id: callerRow.payload.id,
|
|
||||||
name: callerRow.payload.name,
|
|
||||||
args: callerRow.payload.args,
|
|
||||||
};
|
|
||||||
if (foundCall.name !== 'ask_user_input') {
|
|
||||||
reply.code(400);
|
|
||||||
return { error: 'tool_call_not_ask_user_input' };
|
|
||||||
}
|
}
|
||||||
|
const { foundCall, toolMessageId } = ctx;
|
||||||
|
|
||||||
// Validate the args themselves — the LLM could have emitted bad JSON.
|
// Validate the args themselves — the LLM could have emitted bad JSON.
|
||||||
const argsParsed = AskUserInputArgs.safeParse(foundCall.args);
|
const argsParsed = AskUserInputArgs.safeParse(foundCall.args);
|
||||||
@@ -569,33 +618,6 @@ export function registerMessageRoutes(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// v1.13.1-C: find the pending tool row via message_parts on
|
|
||||||
// payload->>'tool_call_id'. Same fallback caveat as the caller lookup
|
|
||||||
// above — pre-v1.13.0 rows are unreachable here.
|
|
||||||
const toolRows = await sql<{
|
|
||||||
message_id: string;
|
|
||||||
payload: { tool_call_id: string; output: unknown };
|
|
||||||
}[]>`
|
|
||||||
SELECT p.message_id, p.payload
|
|
||||||
FROM message_parts p
|
|
||||||
JOIN messages m ON m.id = p.message_id
|
|
||||||
WHERE m.chat_id = ${chat.id}
|
|
||||||
AND m.role = 'tool'
|
|
||||||
AND p.kind = 'tool_result'
|
|
||||||
AND p.payload->>'tool_call_id' = ${tool_call_id}
|
|
||||||
ORDER BY m.created_at DESC
|
|
||||||
LIMIT 1
|
|
||||||
`;
|
|
||||||
const toolRow = toolRows[0];
|
|
||||||
if (!toolRow) {
|
|
||||||
reply.code(404);
|
|
||||||
return { error: 'unknown_tool_call_id', detail: 'tool message not found' };
|
|
||||||
}
|
|
||||||
if (toolRow.payload && toolRow.payload.output !== null) {
|
|
||||||
reply.code(409);
|
|
||||||
return { error: 'tool_call_already_answered' };
|
|
||||||
}
|
|
||||||
|
|
||||||
const answerSet = { answers };
|
const answerSet = { answers };
|
||||||
const newToolResults = {
|
const newToolResults = {
|
||||||
tool_call_id,
|
tool_call_id,
|
||||||
@@ -603,7 +625,6 @@ export function registerMessageRoutes(
|
|||||||
truncated: false,
|
truncated: false,
|
||||||
};
|
};
|
||||||
|
|
||||||
const toolMessageId = toolRow.message_id;
|
|
||||||
const result = await sql.begin(async (tx) => {
|
const result = await sql.begin(async (tx) => {
|
||||||
// v1.13.20: parts-only. Replace the pending tool_result part inserted
|
// v1.13.20: parts-only. Replace the pending tool_result part inserted
|
||||||
// at message creation (tool-phase.ts) with the answered one. Delete-
|
// at message creation (tool-phase.ts) with the answered one. Delete-
|
||||||
@@ -681,35 +702,15 @@ export function registerMessageRoutes(
|
|||||||
const chat = chatRows[0]!;
|
const chat = chatRows[0]!;
|
||||||
const sessionId = chat.session_id;
|
const sessionId = chat.session_id;
|
||||||
|
|
||||||
// Mirror the /answer lookup: assistant tool_call by id via message_parts.
|
const grantCtx = await lookupPendingToolCall(
|
||||||
const callerRows = await sql<{
|
sql, chat.id, tool_call_id, 'request_read_access', 'tool_call_not_request_read_access',
|
||||||
message_id: string;
|
);
|
||||||
payload: { id: string; name: string; args: Record<string, unknown> };
|
if (!grantCtx.ok) {
|
||||||
}[]>`
|
reply.code(grantCtx.code);
|
||||||
SELECT p.message_id, p.payload
|
return grantCtx.body;
|
||||||
FROM message_parts p
|
|
||||||
JOIN messages m ON m.id = p.message_id
|
|
||||||
WHERE m.chat_id = ${chat.id}
|
|
||||||
AND m.role = 'assistant'
|
|
||||||
AND p.kind = 'tool_call'
|
|
||||||
AND p.payload->>'id' = ${tool_call_id}
|
|
||||||
ORDER BY m.created_at DESC
|
|
||||||
LIMIT 1
|
|
||||||
`;
|
|
||||||
const callerRow = callerRows[0];
|
|
||||||
if (!callerRow) {
|
|
||||||
reply.code(404);
|
|
||||||
return { error: 'unknown_tool_call_id' };
|
|
||||||
}
|
|
||||||
const foundCall: ToolCall = {
|
|
||||||
id: callerRow.payload.id,
|
|
||||||
name: callerRow.payload.name,
|
|
||||||
args: callerRow.payload.args,
|
|
||||||
};
|
|
||||||
if (foundCall.name !== 'request_read_access') {
|
|
||||||
reply.code(400);
|
|
||||||
return { error: 'tool_call_not_request_read_access' };
|
|
||||||
}
|
}
|
||||||
|
const { foundCall, toolMessageId } = grantCtx;
|
||||||
|
|
||||||
const argsParsed = RequestReadAccessArgs.safeParse(foundCall.args);
|
const argsParsed = RequestReadAccessArgs.safeParse(foundCall.args);
|
||||||
if (!argsParsed.success) {
|
if (!argsParsed.success) {
|
||||||
reply.code(400);
|
reply.code(400);
|
||||||
@@ -717,31 +718,6 @@ export function registerMessageRoutes(
|
|||||||
}
|
}
|
||||||
const requestedPath = argsParsed.data.path;
|
const requestedPath = argsParsed.data.path;
|
||||||
|
|
||||||
// Find the pending tool row.
|
|
||||||
const toolRows = await sql<{
|
|
||||||
message_id: string;
|
|
||||||
payload: { tool_call_id: string; output: unknown };
|
|
||||||
}[]>`
|
|
||||||
SELECT p.message_id, p.payload
|
|
||||||
FROM message_parts p
|
|
||||||
JOIN messages m ON m.id = p.message_id
|
|
||||||
WHERE m.chat_id = ${chat.id}
|
|
||||||
AND m.role = 'tool'
|
|
||||||
AND p.kind = 'tool_result'
|
|
||||||
AND p.payload->>'tool_call_id' = ${tool_call_id}
|
|
||||||
ORDER BY m.created_at DESC
|
|
||||||
LIMIT 1
|
|
||||||
`;
|
|
||||||
const toolRow = toolRows[0];
|
|
||||||
if (!toolRow) {
|
|
||||||
reply.code(404);
|
|
||||||
return { error: 'unknown_tool_call_id', detail: 'tool message not found' };
|
|
||||||
}
|
|
||||||
if (toolRow.payload && toolRow.payload.output !== null) {
|
|
||||||
reply.code(409);
|
|
||||||
return { error: 'tool_call_already_answered' };
|
|
||||||
}
|
|
||||||
|
|
||||||
// Look up session + project so we can re-resolve the grant root and
|
// Look up session + project so we can re-resolve the grant root and
|
||||||
// append to allowed_read_paths atomically. We don't need agent or
|
// append to allowed_read_paths atomically. We don't need agent or
|
||||||
// history here — just the project path for the resolver.
|
// history here — just the project path for the resolver.
|
||||||
@@ -790,7 +766,6 @@ export function registerMessageRoutes(
|
|||||||
output: resultOutput,
|
output: resultOutput,
|
||||||
truncated: false,
|
truncated: false,
|
||||||
};
|
};
|
||||||
const toolMessageId = toolRow.message_id;
|
|
||||||
const dbResult = await sql.begin(async (tx) => {
|
const dbResult = await sql.begin(async (tx) => {
|
||||||
// v1.13.20: parts-only. Same delete+insert dance as /answer —
|
// v1.13.20: parts-only. Same delete+insert dance as /answer —
|
||||||
// UNIQUE (message_id, sequence) blocks plain UPDATE on append-style
|
// UNIQUE (message_id, sequence) blocks plain UPDATE on append-style
|
||||||
|
|||||||
@@ -67,6 +67,20 @@ export async function resolveProjectPath(
|
|||||||
return { real, name: basename(real) };
|
return { real, name: basename(real) };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function selectProject(sql: Sql, id: string): Promise<Project | null> {
|
||||||
|
const rows = await sql<Project[]>`
|
||||||
|
SELECT id, name, path, added_at, last_session_id, status, gitea_remote,
|
||||||
|
default_system_prompt, default_web_search_enabled
|
||||||
|
FROM projects WHERE id = ${id}
|
||||||
|
`;
|
||||||
|
return rows[0] ?? null;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function selectProjectPath(sql: Sql, id: string): Promise<string | null> {
|
||||||
|
const rows = await sql<{ path: string }[]>`SELECT path FROM projects WHERE id = ${id}`;
|
||||||
|
return rows[0]?.path ?? null;
|
||||||
|
}
|
||||||
|
|
||||||
export function registerProjectRoutes(
|
export function registerProjectRoutes(
|
||||||
app: FastifyInstance,
|
app: FastifyInstance,
|
||||||
sql: Sql,
|
sql: Sql,
|
||||||
@@ -199,16 +213,12 @@ export function registerProjectRoutes(
|
|||||||
// v1.9: single-project fetch so the settings pane can refetch on
|
// v1.9: single-project fetch so the settings pane can refetch on
|
||||||
// project_updated without pulling the whole project list.
|
// project_updated without pulling the whole project list.
|
||||||
app.get<{ Params: { id: string } }>('/api/projects/:id', async (req, reply) => {
|
app.get<{ Params: { id: string } }>('/api/projects/:id', async (req, reply) => {
|
||||||
const rows = await sql<Project[]>`
|
const project = await selectProject(sql, req.params.id);
|
||||||
SELECT id, name, path, added_at, last_session_id, status, gitea_remote,
|
if (!project) {
|
||||||
default_system_prompt, default_web_search_enabled
|
|
||||||
FROM projects WHERE id = ${req.params.id}
|
|
||||||
`;
|
|
||||||
if (rows.length === 0) {
|
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
return { error: 'not found' };
|
return { error: 'not found' };
|
||||||
}
|
}
|
||||||
return rows[0];
|
return project;
|
||||||
});
|
});
|
||||||
|
|
||||||
app.patch<{ Params: { id: string } }>('/api/projects/:id', async (req, reply) => {
|
app.patch<{ Params: { id: string } }>('/api/projects/:id', async (req, reply) => {
|
||||||
@@ -340,18 +350,14 @@ export function registerProjectRoutes(
|
|||||||
const { id } = req.params;
|
const { id } = req.params;
|
||||||
const relPath = req.query.path ?? '.';
|
const relPath = req.query.path ?? '.';
|
||||||
|
|
||||||
const rows = await sql<Project[]>`
|
const projectPath = await selectProjectPath(sql, id);
|
||||||
SELECT id, name, path, added_at, last_session_id, status, gitea_remote
|
if (projectPath === null) {
|
||||||
FROM projects WHERE id = ${id}
|
|
||||||
`;
|
|
||||||
if (rows.length === 0) {
|
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
return { error: 'not found' };
|
return { error: 'not found' };
|
||||||
}
|
}
|
||||||
const project = rows[0]!;
|
|
||||||
let projectRoot: string;
|
let projectRoot: string;
|
||||||
try {
|
try {
|
||||||
projectRoot = await resolveProjectRoot(project.path);
|
projectRoot = await resolveProjectRoot(projectPath);
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
if (err instanceof PathScopeError) {
|
if (err instanceof PathScopeError) {
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
@@ -385,18 +391,14 @@ export function registerProjectRoutes(
|
|||||||
return { error: 'path is required' };
|
return { error: 'path is required' };
|
||||||
}
|
}
|
||||||
|
|
||||||
const rows = await sql<Project[]>`
|
const projectPath = await selectProjectPath(sql, id);
|
||||||
SELECT id, name, path, added_at, last_session_id, status, gitea_remote
|
if (projectPath === null) {
|
||||||
FROM projects WHERE id = ${id}
|
|
||||||
`;
|
|
||||||
if (rows.length === 0) {
|
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
return { error: 'not found' };
|
return { error: 'not found' };
|
||||||
}
|
}
|
||||||
const project = rows[0]!;
|
|
||||||
let projectRoot: string;
|
let projectRoot: string;
|
||||||
try {
|
try {
|
||||||
projectRoot = await resolveProjectRoot(project.path);
|
projectRoot = await resolveProjectRoot(projectPath);
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
if (err instanceof PathScopeError) {
|
if (err instanceof PathScopeError) {
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
@@ -431,18 +433,14 @@ export function registerProjectRoutes(
|
|||||||
'/api/projects/:id/git',
|
'/api/projects/:id/git',
|
||||||
async (req, reply) => {
|
async (req, reply) => {
|
||||||
const { id } = req.params;
|
const { id } = req.params;
|
||||||
const rows = await sql<Project[]>`
|
const projectPath = await selectProjectPath(sql, id);
|
||||||
SELECT id, name, path, added_at, last_session_id, status, gitea_remote
|
if (projectPath === null) {
|
||||||
FROM projects WHERE id = ${id}
|
|
||||||
`;
|
|
||||||
if (rows.length === 0) {
|
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
return { error: 'not found' };
|
return { error: 'not found' };
|
||||||
}
|
}
|
||||||
const project = rows[0]!;
|
|
||||||
let projectRoot: string;
|
let projectRoot: string;
|
||||||
try {
|
try {
|
||||||
projectRoot = await resolveProjectRoot(project.path);
|
projectRoot = await resolveProjectRoot(projectPath);
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
if (err instanceof PathScopeError) {
|
if (err instanceof PathScopeError) {
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
@@ -461,18 +459,14 @@ export function registerProjectRoutes(
|
|||||||
async (req, reply) => {
|
async (req, reply) => {
|
||||||
const { id } = req.params;
|
const { id } = req.params;
|
||||||
|
|
||||||
const rows = await sql<Project[]>`
|
const projectPath = await selectProjectPath(sql, id);
|
||||||
SELECT id, name, path, added_at, last_session_id, status, gitea_remote
|
if (projectPath === null) {
|
||||||
FROM projects WHERE id = ${id}
|
|
||||||
`;
|
|
||||||
if (rows.length === 0) {
|
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
return { error: 'not found' };
|
return { error: 'not found' };
|
||||||
}
|
}
|
||||||
const project = rows[0]!;
|
|
||||||
let projectRoot: string;
|
let projectRoot: string;
|
||||||
try {
|
try {
|
||||||
projectRoot = await resolveProjectRoot(project.path);
|
projectRoot = await resolveProjectRoot(projectPath);
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
if (err instanceof PathScopeError) {
|
if (err instanceof PathScopeError) {
|
||||||
reply.code(404);
|
reply.code(404);
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ import type { FastifyInstance } from 'fastify';
|
|||||||
import type { Sql } from '../db.js';
|
import type { Sql } from '../db.js';
|
||||||
import type { Broker } from '../services/broker.js';
|
import type { Broker } from '../services/broker.js';
|
||||||
import type { Message } from '../types/api.js';
|
import type { Message } from '../types/api.js';
|
||||||
|
import { MESSAGE_COLUMNS } from '../services/message-columns.js';
|
||||||
|
|
||||||
export function registerWebSocket(
|
export function registerWebSocket(
|
||||||
app: FastifyInstance,
|
app: FastifyInstance,
|
||||||
@@ -25,9 +26,7 @@ export function registerWebSocket(
|
|||||||
// render the SummaryCard for summary=true rows on first connect.
|
// render the SummaryCard for summary=true rows on first connect.
|
||||||
// v1.13.1-B: reads tool_calls/tool_results via the parts-merged view.
|
// v1.13.1-B: reads tool_calls/tool_results via the parts-merged view.
|
||||||
const messages = await sql<Message[]>`
|
const messages = await sql<Message[]>`
|
||||||
SELECT id, session_id, chat_id, role, content, kind, tool_calls, tool_results, status, last_seq,
|
SELECT ${sql.unsafe(MESSAGE_COLUMNS)}
|
||||||
tokens_used, ctx_used, ctx_max, started_at, finished_at, created_at, metadata,
|
|
||||||
summary, tail_start_id, compacted_at, model
|
|
||||||
FROM messages_with_parts
|
FROM messages_with_parts
|
||||||
WHERE session_id = ${sessionId}
|
WHERE session_id = ${sessionId}
|
||||||
ORDER BY created_at ASC, id ASC
|
ORDER BY created_at ASC, id ASC
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
-- v1.13.3: statement_timeout is set at database level via:
|
-- v1.13.3: statement_timeout is set at database level via:
|
||||||
-- ALTER DATABASE boocode SET statement_timeout = '30s';
|
-- ALTER DATABASE boochat SET statement_timeout = '30s';
|
||||||
-- ALTER DATABASE can't run inside a DO block, so this is an operational
|
-- ALTER DATABASE can't run inside a DO block, so this is an operational
|
||||||
-- step rather than schema. Re-apply after a volume reset (the setting
|
-- step rather than schema. Re-apply after a volume reset (the setting
|
||||||
-- lives in pg_db which survives `docker compose up --build` but NOT a
|
-- lives in pg_db which survives `docker compose up --build` but NOT a
|
||||||
@@ -30,8 +30,6 @@ CREATE TABLE IF NOT EXISTS messages (
|
|||||||
session_id UUID NOT NULL REFERENCES sessions(id) ON DELETE CASCADE,
|
session_id UUID NOT NULL REFERENCES sessions(id) ON DELETE CASCADE,
|
||||||
role TEXT NOT NULL,
|
role TEXT NOT NULL,
|
||||||
content TEXT NOT NULL DEFAULT '',
|
content TEXT NOT NULL DEFAULT '',
|
||||||
tool_calls JSONB,
|
|
||||||
tool_results JSONB,
|
|
||||||
status TEXT NOT NULL DEFAULT 'complete',
|
status TEXT NOT NULL DEFAULT 'complete',
|
||||||
last_seq INT NOT NULL DEFAULT 0,
|
last_seq INT NOT NULL DEFAULT 0,
|
||||||
created_at TIMESTAMPTZ NOT NULL DEFAULT clock_timestamp()
|
created_at TIMESTAMPTZ NOT NULL DEFAULT clock_timestamp()
|
||||||
@@ -39,11 +37,10 @@ CREATE TABLE IF NOT EXISTS messages (
|
|||||||
|
|
||||||
CREATE INDEX IF NOT EXISTS idx_messages_session ON messages(session_id, created_at);
|
CREATE INDEX IF NOT EXISTS idx_messages_session ON messages(session_id, created_at);
|
||||||
|
|
||||||
-- v1.13.0: granular message parts table for AI SDK migration. Old
|
-- v1.13.0: granular message parts table. v1.13.20: legacy tool_calls/
|
||||||
-- messages.content / tool_calls / tool_results columns stay authoritative
|
-- tool_results columns dropped; message_parts is now the sole source of
|
||||||
-- for reads in v1.13.0; this table is dual-written so the swap can happen
|
-- truth for tool calls, tool results, and reasoning. ON DELETE CASCADE
|
||||||
-- in a later dispatch without a backfill window. ON DELETE CASCADE means
|
-- means removing a message removes its parts in one go.
|
||||||
-- removing a message removes its parts in one go.
|
|
||||||
CREATE TABLE IF NOT EXISTS message_parts (
|
CREATE TABLE IF NOT EXISTS message_parts (
|
||||||
id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
|
id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
|
||||||
message_id uuid NOT NULL REFERENCES messages(id) ON DELETE CASCADE,
|
message_id uuid NOT NULL REFERENCES messages(id) ON DELETE CASCADE,
|
||||||
@@ -142,10 +139,9 @@ ALTER TABLE messages DROP COLUMN IF EXISTS tool_calls;
|
|||||||
ALTER TABLE messages DROP COLUMN IF EXISTS tool_results;
|
ALTER TABLE messages DROP COLUMN IF EXISTS tool_results;
|
||||||
|
|
||||||
-- v1.13.10: per-tool token cost rolling window. Derives from
|
-- v1.13.10: per-tool token cost rolling window. Derives from
|
||||||
-- messages_with_parts (the v1.13.1-B view that COALESCEs message_parts over
|
-- messages_with_parts (the v1.13.1-B view; v1.13.20 removed the legacy
|
||||||
-- the legacy JSON column) so this works whether the chat predates v1.13.0
|
-- JSON-column COALESCE fallback — parts are sole source). No new write
|
||||||
-- or postdates v1.13.2 (column drop). No new write site — all source data
|
-- site — all source data already lands via tool-phase.ts:94-95 UPDATE.
|
||||||
-- already lands via the existing tool-phase.ts:94-95 UPDATE.
|
|
||||||
--
|
--
|
||||||
-- Attribution model: equal split. A turn emitting N tool calls divides its
|
-- Attribution model: equal split. A turn emitting N tool calls divides its
|
||||||
-- prompt/completion tokens by N before attribution. See v1.13.10 dispatch
|
-- prompt/completion tokens by N before attribution. See v1.13.10 dispatch
|
||||||
@@ -352,7 +348,7 @@ INSERT INTO settings (key, value) VALUES ('theme_mode', '"dark"') ON CONFLICT (k
|
|||||||
ALTER TABLE projects ADD COLUMN IF NOT EXISTS default_system_prompt TEXT NOT NULL DEFAULT '';
|
ALTER TABLE projects ADD COLUMN IF NOT EXISTS default_system_prompt TEXT NOT NULL DEFAULT '';
|
||||||
ALTER TABLE projects ADD COLUMN IF NOT EXISTS default_web_search_enabled BOOLEAN NOT NULL DEFAULT false;
|
ALTER TABLE projects ADD COLUMN IF NOT EXISTS default_web_search_enabled BOOLEAN NOT NULL DEFAULT false;
|
||||||
ALTER TABLE sessions ADD COLUMN IF NOT EXISTS web_search_enabled BOOLEAN;
|
ALTER TABLE sessions ADD COLUMN IF NOT EXISTS web_search_enabled BOOLEAN;
|
||||||
ALTER TABLE sessions ADD COLUMN IF NOT EXISTS tags TEXT[] DEFAULT '{}';
|
ALTER TABLE sessions DROP COLUMN IF EXISTS tags;
|
||||||
|
|
||||||
-- v1.11: anchored rolling compaction.
|
-- v1.11: anchored rolling compaction.
|
||||||
-- compacted_at — marks rows that are "behind the curtain" of the latest
|
-- compacted_at — marks rows that are "behind the curtain" of the latest
|
||||||
@@ -391,9 +387,7 @@ CREATE TABLE IF NOT EXISTS tasks (
|
|||||||
model TEXT,
|
model TEXT,
|
||||||
mode_id TEXT,
|
mode_id TEXT,
|
||||||
thinking_option_id TEXT,
|
thinking_option_id TEXT,
|
||||||
feature_values JSONB,
|
|
||||||
execution_path TEXT CHECK (execution_path IS NULL OR execution_path IN ('native','acp','pty','qwen')),
|
execution_path TEXT CHECK (execution_path IS NULL OR execution_path IN ('native','acp','pty','qwen')),
|
||||||
worktree_path TEXT,
|
|
||||||
cost_tokens INTEGER,
|
cost_tokens INTEGER,
|
||||||
started_at TIMESTAMPTZ,
|
started_at TIMESTAMPTZ,
|
||||||
ended_at TIMESTAMPTZ,
|
ended_at TIMESTAMPTZ,
|
||||||
|
|||||||
46
apps/server/src/services/__tests__/budget.test.ts
Normal file
46
apps/server/src/services/__tests__/budget.test.ts
Normal file
@@ -0,0 +1,46 @@
|
|||||||
|
import { describe, expect, it } from 'vitest';
|
||||||
|
import { resolveToolBudget } from '../inference/budget.js';
|
||||||
|
import type { Agent } from '../../types/api.js';
|
||||||
|
|
||||||
|
const BASE_AGENT: Agent = {
|
||||||
|
id: 'test-agent',
|
||||||
|
name: 'Test',
|
||||||
|
description: 'test',
|
||||||
|
system_prompt: '',
|
||||||
|
temperature: 0.7,
|
||||||
|
top_p: null,
|
||||||
|
top_k: null,
|
||||||
|
min_p: null,
|
||||||
|
presence_penalty: null,
|
||||||
|
top_n_sigma: null,
|
||||||
|
dry_multiplier: null,
|
||||||
|
dry_base: null,
|
||||||
|
dry_allowed_length: null,
|
||||||
|
dry_penalty_last_n: null,
|
||||||
|
tools: ['view_file'],
|
||||||
|
model: null,
|
||||||
|
source: 'global',
|
||||||
|
max_tool_calls: null,
|
||||||
|
steps: null,
|
||||||
|
llama_extra_args: null,
|
||||||
|
};
|
||||||
|
|
||||||
|
describe('resolveToolBudget', () => {
|
||||||
|
it('returns 100 when agent is null (no-agent raw chat)', () => {
|
||||||
|
expect(resolveToolBudget(null)).toBe(100);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns 100 when agent has no max_tool_calls override', () => {
|
||||||
|
expect(resolveToolBudget(BASE_AGENT)).toBe(100);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns max_tool_calls when agent overrides the default', () => {
|
||||||
|
const agent: Agent = { ...BASE_AGENT, max_tool_calls: 25 };
|
||||||
|
expect(resolveToolBudget(agent)).toBe(25);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns 0 when max_tool_calls is explicitly 0 (text-only mode)', () => {
|
||||||
|
const agent: Agent = { ...BASE_AGENT, max_tool_calls: 0 };
|
||||||
|
expect(resolveToolBudget(agent)).toBe(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
149
apps/server/src/services/__tests__/inference-helpers.test.ts
Normal file
149
apps/server/src/services/__tests__/inference-helpers.test.ts
Normal file
@@ -0,0 +1,149 @@
|
|||||||
|
import { describe, expect, it, vi, afterEach } from 'vitest';
|
||||||
|
import { samplerOptsFromAgent } from '../inference/stream-phase.js';
|
||||||
|
import { createContentFlusher } from '../inference/content-flusher.js';
|
||||||
|
import type { Sql } from '../../db.js';
|
||||||
|
import type { Agent } from '../../types/api.js';
|
||||||
|
|
||||||
|
const BASE_AGENT: Agent = {
|
||||||
|
id: 'test-agent',
|
||||||
|
name: 'Test',
|
||||||
|
description: 'test',
|
||||||
|
system_prompt: '',
|
||||||
|
temperature: 0.7,
|
||||||
|
top_p: null,
|
||||||
|
top_k: null,
|
||||||
|
min_p: null,
|
||||||
|
presence_penalty: null,
|
||||||
|
top_n_sigma: null,
|
||||||
|
dry_multiplier: null,
|
||||||
|
dry_base: null,
|
||||||
|
dry_allowed_length: null,
|
||||||
|
dry_penalty_last_n: null,
|
||||||
|
tools: ['view_file'],
|
||||||
|
model: null,
|
||||||
|
source: 'global',
|
||||||
|
max_tool_calls: null,
|
||||||
|
steps: null,
|
||||||
|
llama_extra_args: null,
|
||||||
|
};
|
||||||
|
|
||||||
|
describe('samplerOptsFromAgent', () => {
|
||||||
|
it('maps every nullable sampler field to undefined when agent is null', () => {
|
||||||
|
expect(samplerOptsFromAgent(null)).toEqual({
|
||||||
|
temperature: undefined,
|
||||||
|
top_p: undefined,
|
||||||
|
top_k: undefined,
|
||||||
|
min_p: undefined,
|
||||||
|
presence_penalty: undefined,
|
||||||
|
top_n_sigma: undefined,
|
||||||
|
dry_multiplier: undefined,
|
||||||
|
dry_base: undefined,
|
||||||
|
dry_allowed_length: undefined,
|
||||||
|
dry_penalty_last_n: undefined,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('strips null sampler fields to undefined but keeps numeric values', () => {
|
||||||
|
const agent: Agent = {
|
||||||
|
...BASE_AGENT,
|
||||||
|
temperature: 0.5,
|
||||||
|
top_p: 0.9,
|
||||||
|
top_k: null,
|
||||||
|
min_p: 0.05,
|
||||||
|
presence_penalty: null,
|
||||||
|
top_n_sigma: 1,
|
||||||
|
dry_multiplier: null,
|
||||||
|
dry_base: 1.75,
|
||||||
|
dry_allowed_length: null,
|
||||||
|
dry_penalty_last_n: 256,
|
||||||
|
};
|
||||||
|
expect(samplerOptsFromAgent(agent)).toEqual({
|
||||||
|
temperature: 0.5,
|
||||||
|
top_p: 0.9,
|
||||||
|
top_k: undefined,
|
||||||
|
min_p: 0.05,
|
||||||
|
presence_penalty: undefined,
|
||||||
|
top_n_sigma: 1,
|
||||||
|
dry_multiplier: undefined,
|
||||||
|
dry_base: 1.75,
|
||||||
|
dry_allowed_length: undefined,
|
||||||
|
dry_penalty_last_n: 256,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('never includes a tools field (callers add it)', () => {
|
||||||
|
expect('tools' in samplerOptsFromAgent(BASE_AGENT)).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('createContentFlusher', () => {
|
||||||
|
afterEach(() => {
|
||||||
|
vi.useRealTimers();
|
||||||
|
});
|
||||||
|
|
||||||
|
// A tagged-template stub matching postgres' sql`...` shape. Records the
|
||||||
|
// interpolated content snapshot (values[0]) of each UPDATE.
|
||||||
|
function makeSqlSpy() {
|
||||||
|
const writes: string[] = [];
|
||||||
|
const sql = ((_strings: TemplateStringsArray, ...values: unknown[]) => {
|
||||||
|
writes.push(values[0] as string);
|
||||||
|
return Promise.resolve([]);
|
||||||
|
}) as unknown as Sql;
|
||||||
|
return { sql, writes };
|
||||||
|
}
|
||||||
|
|
||||||
|
it('debounces: many scheduleFlush calls in one window produce one write', async () => {
|
||||||
|
vi.useFakeTimers();
|
||||||
|
const { sql, writes } = makeSqlSpy();
|
||||||
|
let content = '';
|
||||||
|
const flusher = createContentFlusher(sql, 'msg-1', () => content, 500);
|
||||||
|
|
||||||
|
content = 'a';
|
||||||
|
flusher.scheduleFlush();
|
||||||
|
content = 'ab';
|
||||||
|
flusher.scheduleFlush();
|
||||||
|
content = 'abc';
|
||||||
|
flusher.scheduleFlush();
|
||||||
|
|
||||||
|
expect(writes).toHaveLength(0); // nothing before the interval elapses
|
||||||
|
vi.advanceTimersByTime(500);
|
||||||
|
await flusher.drain();
|
||||||
|
|
||||||
|
expect(writes).toHaveLength(1);
|
||||||
|
// snapshot is read at fire time → latest content, not the value at schedule time
|
||||||
|
expect(writes[0]).toBe('abc');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('arms a fresh timer after a flush fires', async () => {
|
||||||
|
vi.useFakeTimers();
|
||||||
|
const { sql, writes } = makeSqlSpy();
|
||||||
|
let content = 'one';
|
||||||
|
const flusher = createContentFlusher(sql, 'msg-1', () => content, 500);
|
||||||
|
|
||||||
|
flusher.scheduleFlush();
|
||||||
|
vi.advanceTimersByTime(500);
|
||||||
|
await Promise.resolve();
|
||||||
|
|
||||||
|
content = 'two';
|
||||||
|
flusher.scheduleFlush();
|
||||||
|
vi.advanceTimersByTime(500);
|
||||||
|
await flusher.drain();
|
||||||
|
|
||||||
|
expect(writes).toEqual(['one', 'two']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('drain cancels a pending timer without performing a final flush', async () => {
|
||||||
|
vi.useFakeTimers();
|
||||||
|
const { sql, writes } = makeSqlSpy();
|
||||||
|
let content = 'pending';
|
||||||
|
const flusher = createContentFlusher(sql, 'msg-1', () => content, 500);
|
||||||
|
|
||||||
|
flusher.scheduleFlush();
|
||||||
|
// Drain before the timer fires — the pending flush is cancelled, not forced.
|
||||||
|
await flusher.drain();
|
||||||
|
vi.advanceTimersByTime(500);
|
||||||
|
await Promise.resolve();
|
||||||
|
|
||||||
|
expect(writes).toHaveLength(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
93
apps/server/src/services/__tests__/mcp-config.test.ts
Normal file
93
apps/server/src/services/__tests__/mcp-config.test.ts
Normal file
@@ -0,0 +1,93 @@
|
|||||||
|
/**
|
||||||
|
* Unit tests for `{env:VAR}` substitution in the MCP config loader.
|
||||||
|
* Pure — no live MCP server. Verifies secrets resolve from process.env
|
||||||
|
* (so real keys live in `.env`, not the gitignored config file).
|
||||||
|
*/
|
||||||
|
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
||||||
|
import { substituteEnvVars } from '../mcp-config.js';
|
||||||
|
|
||||||
|
// Minimal FastifyBaseLogger stub — only .warn is exercised here.
|
||||||
|
function fakeLog() {
|
||||||
|
const warnings: string[] = [];
|
||||||
|
const log = {
|
||||||
|
warn: (msg: unknown) => {
|
||||||
|
warnings.push(typeof msg === 'string' ? msg : JSON.stringify(msg));
|
||||||
|
},
|
||||||
|
};
|
||||||
|
return { log: log as never, warnings };
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('substituteEnvVars', () => {
|
||||||
|
const SAVED = process.env.MCP_TEST_SECRET;
|
||||||
|
beforeEach(() => {
|
||||||
|
process.env.MCP_TEST_SECRET = 'resolved-value';
|
||||||
|
});
|
||||||
|
afterEach(() => {
|
||||||
|
if (SAVED === undefined) delete process.env.MCP_TEST_SECRET;
|
||||||
|
else process.env.MCP_TEST_SECRET = SAVED;
|
||||||
|
delete process.env.MCP_TEST_MISSING;
|
||||||
|
});
|
||||||
|
|
||||||
|
it('replaces a {env:VAR} reference in a string value', () => {
|
||||||
|
const { log } = fakeLog();
|
||||||
|
expect(substituteEnvVars('{env:MCP_TEST_SECRET}', log)).toBe('resolved-value');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('substitutes inside nested objects and arrays', () => {
|
||||||
|
const { log } = fakeLog();
|
||||||
|
const out = substituteEnvVars(
|
||||||
|
{
|
||||||
|
headers: { CONTEXT7_API_KEY: '{env:MCP_TEST_SECRET}' },
|
||||||
|
args: ['--token', '{env:MCP_TEST_SECRET}'],
|
||||||
|
},
|
||||||
|
log,
|
||||||
|
);
|
||||||
|
expect(out).toEqual({
|
||||||
|
headers: { CONTEXT7_API_KEY: 'resolved-value' },
|
||||||
|
args: ['--token', 'resolved-value'],
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('leaves object keys untouched, only transforms values', () => {
|
||||||
|
const { log } = fakeLog();
|
||||||
|
const out = substituteEnvVars({ '{env:MCP_TEST_SECRET}': 'literal' }, log) as Record<string, string>;
|
||||||
|
expect(Object.keys(out)).toEqual(['{env:MCP_TEST_SECRET}']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('resolves an unset var to empty string and warns', () => {
|
||||||
|
const { log, warnings } = fakeLog();
|
||||||
|
expect(substituteEnvVars('{env:MCP_TEST_MISSING}', log)).toBe('');
|
||||||
|
expect(warnings.some((w) => w.includes('MCP_TEST_MISSING'))).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('passes non-string scalars through unchanged', () => {
|
||||||
|
const { log } = fakeLog();
|
||||||
|
expect(substituteEnvVars(true, log)).toBe(true);
|
||||||
|
expect(substituteEnvVars(42, log)).toBe(42);
|
||||||
|
expect(substituteEnvVars(null, log)).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('leaves strings without a reference unchanged', () => {
|
||||||
|
const { log } = fakeLog();
|
||||||
|
expect(substituteEnvVars('https://mcp.context7.com/mcp', log)).toBe('https://mcp.context7.com/mcp');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('resolves multiple references in one string (global flag)', () => {
|
||||||
|
const { log } = fakeLog();
|
||||||
|
expect(substituteEnvVars('{env:MCP_TEST_SECRET}/{env:MCP_TEST_SECRET}', log)).toBe(
|
||||||
|
'resolved-value/resolved-value',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('passes an empty string through unchanged', () => {
|
||||||
|
const { log } = fakeLog();
|
||||||
|
expect(substituteEnvVars('', log)).toBe('');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('collects unset var names into the optional collector set', () => {
|
||||||
|
const { log } = fakeLog();
|
||||||
|
const unset = new Set<string>();
|
||||||
|
substituteEnvVars({ url: '{env:MCP_TEST_MISSING}', headers: { k: '{env:MCP_TEST_SECRET}' } }, log, unset);
|
||||||
|
expect([...unset]).toEqual(['MCP_TEST_MISSING']);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -9,12 +9,9 @@ import {
|
|||||||
|
|
||||||
const TEST_URL = 'http://llama-swap.test:8401';
|
const TEST_URL = 'http://llama-swap.test:8401';
|
||||||
|
|
||||||
function mockOkProps(n_ctx: number, total_slots = 1) {
|
function mockOkProps(n_ctx: number) {
|
||||||
return new Response(
|
return new Response(
|
||||||
JSON.stringify({
|
JSON.stringify({ default_generation_settings: { n_ctx } }),
|
||||||
default_generation_settings: { n_ctx },
|
|
||||||
total_slots,
|
|
||||||
}),
|
|
||||||
{ status: 200, headers: { 'Content-Type': 'application/json' } },
|
{ status: 200, headers: { 'Content-Type': 'application/json' } },
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@@ -33,12 +30,10 @@ afterEach(() => {
|
|||||||
|
|
||||||
describe('getModelContext — positive cache', () => {
|
describe('getModelContext — positive cache', () => {
|
||||||
it('returns the parsed body on a 200 with valid shape', async () => {
|
it('returns the parsed body on a 200 with valid shape', async () => {
|
||||||
const fetchSpy = vi.spyOn(globalThis, 'fetch').mockResolvedValueOnce(mockOkProps(262_144, 1));
|
const fetchSpy = vi.spyOn(globalThis, 'fetch').mockResolvedValueOnce(mockOkProps(262_144));
|
||||||
const result = await getModelContext('qwen3.6');
|
const result = await getModelContext('qwen3.6');
|
||||||
expect(result).not.toBeNull();
|
expect(result).not.toBeNull();
|
||||||
expect(result!.n_ctx).toBe(262_144);
|
expect(result!.n_ctx).toBe(262_144);
|
||||||
expect(result!.total_slots).toBe(1);
|
|
||||||
expect(typeof result!.fetched_at).toBe('number');
|
|
||||||
// Verify the URL was constructed correctly — encodes the model name in
|
// Verify the URL was constructed correctly — encodes the model name in
|
||||||
// case it contains characters that would break the path.
|
// case it contains characters that would break the path.
|
||||||
expect(fetchSpy).toHaveBeenCalledExactlyOnceWith(
|
expect(fetchSpy).toHaveBeenCalledExactlyOnceWith(
|
||||||
@@ -57,19 +52,6 @@ describe('getModelContext — positive cache', () => {
|
|||||||
expect(fetchSpy).toHaveBeenCalledTimes(1);
|
expect(fetchSpy).toHaveBeenCalledTimes(1);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('defaults total_slots to 1 when the server omits it', async () => {
|
|
||||||
// Mirror the docstring claim — total_slots is informational and we don't
|
|
||||||
// reject the response just because it's missing.
|
|
||||||
vi.spyOn(globalThis, 'fetch').mockResolvedValueOnce(
|
|
||||||
new Response(JSON.stringify({ default_generation_settings: { n_ctx: 8192 } }), {
|
|
||||||
status: 200,
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
const result = await getModelContext('partial-model');
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
expect(result!.n_ctx).toBe(8192);
|
|
||||||
expect(result!.total_slots).toBe(1);
|
|
||||||
});
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// ---- negative cache (single-shot) ------------------------------------------
|
// ---- negative cache (single-shot) ------------------------------------------
|
||||||
|
|||||||
87
apps/server/src/services/__tests__/sentinels.test.ts
Normal file
87
apps/server/src/services/__tests__/sentinels.test.ts
Normal file
@@ -0,0 +1,87 @@
|
|||||||
|
import { describe, it, expect } from 'vitest';
|
||||||
|
import { SENTINEL_KINDS, isAnySentinel, isCapHitSentinel, isDoomLoopSentinel, isMistakeRecoverySentinel } from '../inference/sentinels.js';
|
||||||
|
import type { Message } from '../../types/api.js';
|
||||||
|
|
||||||
|
function makeSentinel(kind: string): Message {
|
||||||
|
return {
|
||||||
|
id: 'msg-1',
|
||||||
|
session_id: 's',
|
||||||
|
chat_id: 'c',
|
||||||
|
role: 'system',
|
||||||
|
content: '',
|
||||||
|
kind: 'message',
|
||||||
|
tool_calls: null,
|
||||||
|
tool_results: null,
|
||||||
|
status: 'complete',
|
||||||
|
last_seq: 0,
|
||||||
|
tokens_used: null,
|
||||||
|
ctx_used: null,
|
||||||
|
ctx_max: null,
|
||||||
|
started_at: null,
|
||||||
|
finished_at: null,
|
||||||
|
created_at: new Date().toISOString(),
|
||||||
|
metadata: { kind } as unknown as import('../../types/api.js').MessageMetadata,
|
||||||
|
summary: false,
|
||||||
|
tail_start_id: null,
|
||||||
|
compacted_at: null,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('SENTINEL_KINDS — single source of truth', () => {
|
||||||
|
it('contains the three known sentinel kinds', () => {
|
||||||
|
expect(SENTINEL_KINDS.has('cap_hit')).toBe(true);
|
||||||
|
expect(SENTINEL_KINDS.has('doom_loop')).toBe(true);
|
||||||
|
expect(SENTINEL_KINDS.has('mistake_recovery')).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not contain arbitrary strings', () => {
|
||||||
|
expect(SENTINEL_KINDS.has('user')).toBe(false);
|
||||||
|
expect(SENTINEL_KINDS.has('assistant')).toBe(false);
|
||||||
|
expect(SENTINEL_KINDS.has('')).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('isAnySentinel', () => {
|
||||||
|
it('returns true for cap_hit', () => {
|
||||||
|
expect(isAnySentinel(makeSentinel('cap_hit'))).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns true for doom_loop', () => {
|
||||||
|
expect(isAnySentinel(makeSentinel('doom_loop'))).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns true for mistake_recovery', () => {
|
||||||
|
expect(isAnySentinel(makeSentinel('mistake_recovery'))).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns false for non-system role', () => {
|
||||||
|
const m = { ...makeSentinel('cap_hit'), role: 'user' as const };
|
||||||
|
expect(isAnySentinel(m)).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns false for null metadata', () => {
|
||||||
|
const m = { ...makeSentinel('cap_hit'), metadata: null };
|
||||||
|
expect(isAnySentinel(m)).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns false for unknown kind', () => {
|
||||||
|
expect(isAnySentinel(makeSentinel('unknown_kind'))).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('individual sentinel predicates still work', () => {
|
||||||
|
it('isCapHitSentinel matches cap_hit only', () => {
|
||||||
|
expect(isCapHitSentinel(makeSentinel('cap_hit'))).toBe(true);
|
||||||
|
expect(isCapHitSentinel(makeSentinel('doom_loop'))).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('isDoomLoopSentinel matches doom_loop only', () => {
|
||||||
|
expect(isDoomLoopSentinel(makeSentinel('doom_loop'))).toBe(true);
|
||||||
|
expect(isDoomLoopSentinel(makeSentinel('cap_hit'))).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('isMistakeRecoverySentinel matches mistake_recovery only', () => {
|
||||||
|
expect(isMistakeRecoverySentinel(makeSentinel('mistake_recovery'))).toBe(true);
|
||||||
|
expect(isMistakeRecoverySentinel(makeSentinel('cap_hit'))).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
111
apps/server/src/services/__tests__/step-decision.test.ts
Normal file
111
apps/server/src/services/__tests__/step-decision.test.ts
Normal file
@@ -0,0 +1,111 @@
|
|||||||
|
import { describe, expect, it } from 'vitest';
|
||||||
|
import { resolveTurnConfig, MAX_STEPS } from '../inference/turn-config.js';
|
||||||
|
import { decideStep, decidePostToolAction } from '../inference/step-decision.js';
|
||||||
|
import { DOOM_LOOP_THRESHOLD } from '../inference/sentinels.js';
|
||||||
|
import type { MistakeState } from '../inference/mistake-tracker.js';
|
||||||
|
import type { Agent, ToolCall } from '../../types/api.js';
|
||||||
|
|
||||||
|
const BASE_AGENT: Agent = {
|
||||||
|
id: 'test-agent',
|
||||||
|
name: 'Test',
|
||||||
|
description: 'test',
|
||||||
|
system_prompt: '',
|
||||||
|
temperature: 0.7,
|
||||||
|
top_p: null,
|
||||||
|
top_k: null,
|
||||||
|
min_p: null,
|
||||||
|
presence_penalty: null,
|
||||||
|
top_n_sigma: null,
|
||||||
|
dry_multiplier: null,
|
||||||
|
dry_base: null,
|
||||||
|
dry_allowed_length: null,
|
||||||
|
dry_penalty_last_n: null,
|
||||||
|
tools: ['view_file'],
|
||||||
|
model: null,
|
||||||
|
source: 'global',
|
||||||
|
max_tool_calls: null,
|
||||||
|
steps: null,
|
||||||
|
llama_extra_args: null,
|
||||||
|
};
|
||||||
|
|
||||||
|
function call(name: string, args: Record<string, unknown> = {}): ToolCall {
|
||||||
|
return { id: `tc-${name}-${JSON.stringify(args)}`, name, args };
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('resolveTurnConfig', () => {
|
||||||
|
it('no agent → budget 100, cap MAX_STEPS, not text-only', () => {
|
||||||
|
expect(resolveTurnConfig(null)).toEqual({
|
||||||
|
effectiveCap: MAX_STEPS,
|
||||||
|
budget: 100,
|
||||||
|
isTextOnly: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('steps: 0 → effectiveCap 0 and isTextOnly true', () => {
|
||||||
|
expect(resolveTurnConfig({ ...BASE_AGENT, steps: 0 })).toEqual({
|
||||||
|
effectiveCap: 0,
|
||||||
|
budget: 100,
|
||||||
|
isTextOnly: true,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('steps below MAX_STEPS → effectiveCap is the agent value', () => {
|
||||||
|
expect(resolveTurnConfig({ ...BASE_AGENT, steps: 5 }).effectiveCap).toBe(5);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('steps above MAX_STEPS → effectiveCap clamps to MAX_STEPS', () => {
|
||||||
|
expect(resolveTurnConfig({ ...BASE_AGENT, steps: 9999 }).effectiveCap).toBe(MAX_STEPS);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('max_tool_calls overrides the budget', () => {
|
||||||
|
expect(resolveTurnConfig({ ...BASE_AGENT, max_tool_calls: 12 }).budget).toBe(12);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('decideStep (top-of-loop gate)', () => {
|
||||||
|
it('returns stream when no doom loop and under budget', () => {
|
||||||
|
expect(decideStep({ recentToolCalls: [], toolsUsed: 0, budget: 30 })).toEqual({ kind: 'stream' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns budget when toolsUsed has reached the budget', () => {
|
||||||
|
expect(decideStep({ recentToolCalls: [], toolsUsed: 30, budget: 30 })).toEqual({ kind: 'budget' });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns doom (with the looping call) on identical-repeat tail', () => {
|
||||||
|
const recent = Array.from({ length: DOOM_LOOP_THRESHOLD }, () => call('view_file', { path: '/a' }));
|
||||||
|
const d = decideStep({ recentToolCalls: recent, toolsUsed: 1, budget: 30 });
|
||||||
|
expect(d.kind).toBe('doom');
|
||||||
|
if (d.kind === 'doom') {
|
||||||
|
expect(d.loop.name).toBe('view_file');
|
||||||
|
expect(d.loop.args).toEqual({ path: '/a' });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('doom takes precedence over budget when both would trip', () => {
|
||||||
|
const recent = Array.from({ length: DOOM_LOOP_THRESHOLD }, () => call('grep', { q: 'x' }));
|
||||||
|
expect(decideStep({ recentToolCalls: recent, toolsUsed: 30, budget: 30 }).kind).toBe('doom');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('decidePostToolAction (post-tool decision)', () => {
|
||||||
|
const clean: MistakeState = { run: [], nudges: 0 };
|
||||||
|
|
||||||
|
it('non-continue actions stop the loop without consulting the tracker', () => {
|
||||||
|
expect(decidePostToolAction('paused', { run: ['exec_error', 'exec_error', 'exec_error'], nudges: 0 })).toBe('stop');
|
||||||
|
expect(decidePostToolAction('synthesis_done', clean)).toBe('stop');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('continue with a clean tracker → continue', () => {
|
||||||
|
expect(decidePostToolAction('continue', clean)).toBe('continue');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('continue with a threshold streak and no prior nudge → nudge', () => {
|
||||||
|
const tracker: MistakeState = { run: ['zod_reject', 'tool_not_found', 'exec_error'], nudges: 0 };
|
||||||
|
expect(decidePostToolAction('continue', tracker)).toBe('nudge');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('continue with a threshold streak after a nudge already fired → escalate', () => {
|
||||||
|
const tracker: MistakeState = { run: ['zod_reject', 'tool_not_found', 'exec_error'], nudges: 1 };
|
||||||
|
expect(decidePostToolAction('continue', tracker)).toBe('escalate');
|
||||||
|
});
|
||||||
|
});
|
||||||
68
apps/server/src/services/__tests__/tools-registry.test.ts
Normal file
68
apps/server/src/services/__tests__/tools-registry.test.ts
Normal file
@@ -0,0 +1,68 @@
|
|||||||
|
import { describe, it, expect } from 'vitest';
|
||||||
|
import { z } from 'zod';
|
||||||
|
import {
|
||||||
|
ALL_TOOLS,
|
||||||
|
TOOLS_BY_NAME,
|
||||||
|
appendMcpTools,
|
||||||
|
toolJsonSchemas,
|
||||||
|
type ToolDef,
|
||||||
|
} from '../tools.js';
|
||||||
|
|
||||||
|
// Parity test for the register-through MCP-discovery contract (Phase 6 split).
|
||||||
|
// `ALL_TOOLS` / `TOOLS_BY_NAME` are `let`-bound in tools/registry.ts and
|
||||||
|
// reassigned by appendMcpTools() at startup; this barrel re-exports them.
|
||||||
|
// apps/coder relies on this exact behavior: it imports `appendMcpTools` + the
|
||||||
|
// live `ALL_TOOLS` binding from @boocode/server/tools, calls appendMcpTools()
|
||||||
|
// once, then reads ALL_TOOLS. ESM live bindings must carry the mutation
|
||||||
|
// through the barrel re-export — if the split ever snapshots the array instead
|
||||||
|
// of re-exporting the live binding, these assertions fail. Each test file gets
|
||||||
|
// an isolated module instance (vitest default), so mutating the registry here
|
||||||
|
// does not leak into tools.test.ts.
|
||||||
|
function makeFakeMcpTool(name: string): ToolDef<unknown> {
|
||||||
|
return {
|
||||||
|
name,
|
||||||
|
description: `fake mcp tool ${name}`,
|
||||||
|
inputSchema: z.object({}) as z.ZodType<unknown>,
|
||||||
|
jsonSchema: {
|
||||||
|
type: 'function',
|
||||||
|
function: {
|
||||||
|
name,
|
||||||
|
description: `fake mcp tool ${name}`,
|
||||||
|
parameters: { type: 'object', properties: {}, additionalProperties: false },
|
||||||
|
},
|
||||||
|
},
|
||||||
|
async execute() {
|
||||||
|
return { ok: true };
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('appendMcpTools register-through contract', () => {
|
||||||
|
it('is a no-op for an empty array', () => {
|
||||||
|
const before = ALL_TOOLS.length;
|
||||||
|
appendMcpTools([]);
|
||||||
|
expect(ALL_TOOLS.length).toBe(before);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('mutates the live ALL_TOOLS / TOOLS_BY_NAME bindings observable through the barrel', () => {
|
||||||
|
const before = ALL_TOOLS.length;
|
||||||
|
// Names chosen so insertion lands away from the array ends, proving the
|
||||||
|
// re-sort runs (a naive concat would leave them at the tail).
|
||||||
|
const a = makeFakeMcpTool('mcp__alpha__probe');
|
||||||
|
const z2 = makeFakeMcpTool('mcp__zeta__probe');
|
||||||
|
appendMcpTools([z2, a]);
|
||||||
|
|
||||||
|
expect(ALL_TOOLS.length).toBe(before + 2);
|
||||||
|
expect(TOOLS_BY_NAME['mcp__alpha__probe']).toBe(a);
|
||||||
|
expect(TOOLS_BY_NAME['mcp__zeta__probe']).toBe(z2);
|
||||||
|
|
||||||
|
// Still alpha-sorted after the append (prompt-cache stability invariant).
|
||||||
|
const names = ALL_TOOLS.map((t) => t.name);
|
||||||
|
expect(names).toEqual([...names].sort((x, y) => x.localeCompare(y)));
|
||||||
|
|
||||||
|
// toolJsonSchemas() reads through the same live binding.
|
||||||
|
const schemaNames = toolJsonSchemas().map((s) => s.function.name);
|
||||||
|
expect(schemaNames).toContain('mcp__alpha__probe');
|
||||||
|
expect(schemaNames).toContain('mcp__zeta__probe');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -111,6 +111,19 @@ describe('WsFrameSchema (v1.13.11-a)', () => {
|
|||||||
expect(result.success).toBe(true);
|
expect(result.success).toBe(true);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('accepts a message_complete frame with a null model (external coder, no model selected)', () => {
|
||||||
|
// Regression guard: the dispatcher publishes `model: task.model` (string |
|
||||||
|
// null). When null, this MUST validate or publishFrame fail-closes and drops
|
||||||
|
// the whole frame, incl. the status:'complete' transition.
|
||||||
|
const result = WsFrameSchema.safeParse({
|
||||||
|
type: 'message_complete',
|
||||||
|
message_id: VALID_UUID_A,
|
||||||
|
chat_id: VALID_UUID_B,
|
||||||
|
model: null,
|
||||||
|
});
|
||||||
|
expect(result.success).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
it('every KNOWN_FRAME_TYPES entry has a discriminated branch', () => {
|
it('every KNOWN_FRAME_TYPES entry has a discriminated branch', () => {
|
||||||
// Probe each known type by attempting a minimal valid construction.
|
// Probe each known type by attempting a minimal valid construction.
|
||||||
// Failure here means the union and the KNOWN_FRAME_TYPES list drifted.
|
// Failure here means the union and the KNOWN_FRAME_TYPES list drifted.
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ import { join } from 'node:path';
|
|||||||
import type { Agent, AgentsResponse, AgentParseError } from '../types/api.js';
|
import type { Agent, AgentsResponse, AgentParseError } from '../types/api.js';
|
||||||
import { ALL_TOOLS, resolveToolTier } from './tools.js';
|
import { ALL_TOOLS, resolveToolTier } from './tools.js';
|
||||||
import { validateExtraArgs } from './inference/llama-args-validator.js';
|
import { validateExtraArgs } from './inference/llama-args-validator.js';
|
||||||
|
import { stripQuotes } from '../utils/string-utils.js';
|
||||||
|
|
||||||
// v1.8.1: global agents live at /data/AGENTS.md inside the container
|
// v1.8.1: global agents live at /data/AGENTS.md inside the container
|
||||||
// (./data:/data:ro mount on the host). Per-project AGENTS.md at the project
|
// (./data:/data:ro mount on the host). Per-project AGENTS.md at the project
|
||||||
@@ -107,17 +108,50 @@ interface ParsedFrontmatter {
|
|||||||
llama_extra_args?: string[];
|
llama_extra_args?: string[];
|
||||||
}
|
}
|
||||||
|
|
||||||
function stripQuotes(s: string): string {
|
// P5: table-driven validation for the "soft-range" numeric frontmatter fields.
|
||||||
if (
|
// Each was a near-identical Number() + finite/integer + range-warn + push-error
|
||||||
s.length >= 2 &&
|
// block. "Soft-range" = the value is STORED whenever the type checks out; an
|
||||||
(s[0] === '"' || s[0] === "'") &&
|
// out-of-range value only emits a console.warn (it is NOT skipped). A type
|
||||||
s[0] === s[s.length - 1]
|
// mismatch hard-fails the block. The range descriptor in the warn message is
|
||||||
) {
|
// `min-max` when both bounds exist, else `(≥min)` — matching the original
|
||||||
return s.slice(1, -1);
|
// hand-written strings byte-for-byte.
|
||||||
}
|
//
|
||||||
return s;
|
// max_tool_calls and steps are deliberately NOT in this table: they are
|
||||||
|
// "hard-range" (store ONLY if in range; an in-type-but-out-of-range value is
|
||||||
|
// warned AND skipped) with bespoke messages, so they stay explicit below.
|
||||||
|
type NumericFieldKey =
|
||||||
|
| 'temperature'
|
||||||
|
| 'top_p'
|
||||||
|
| 'top_k'
|
||||||
|
| 'min_p'
|
||||||
|
| 'presence_penalty'
|
||||||
|
| 'top_n_sigma'
|
||||||
|
| 'dry_multiplier'
|
||||||
|
| 'dry_base'
|
||||||
|
| 'dry_allowed_length'
|
||||||
|
| 'dry_penalty_last_n';
|
||||||
|
|
||||||
|
interface NumericFieldSpec {
|
||||||
|
key: NumericFieldKey;
|
||||||
|
isInt: boolean;
|
||||||
|
min?: number;
|
||||||
|
max?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const NUMERIC_FIELDS: readonly NumericFieldSpec[] = [
|
||||||
|
{ key: 'temperature', isInt: false },
|
||||||
|
{ key: 'top_p', isInt: false, min: 0, max: 1 },
|
||||||
|
{ key: 'top_k', isInt: true, min: 0, max: 200 },
|
||||||
|
{ key: 'min_p', isInt: false, min: 0, max: 1 },
|
||||||
|
{ key: 'presence_penalty', isInt: false, min: -2, max: 2 },
|
||||||
|
// v2.6 sampling-streamjson-tokens (#11): llama.cpp sampler extensions.
|
||||||
|
{ key: 'top_n_sigma', isInt: false, min: 0 },
|
||||||
|
{ key: 'dry_multiplier', isInt: false, min: 0 },
|
||||||
|
{ key: 'dry_base', isInt: false, min: 0 },
|
||||||
|
{ key: 'dry_allowed_length', isInt: true, min: 0 },
|
||||||
|
{ key: 'dry_penalty_last_n', isInt: true, min: -1 },
|
||||||
|
];
|
||||||
|
|
||||||
function parseFrontmatter(yaml: string): { data: ParsedFrontmatter; errors: string[] } {
|
function parseFrontmatter(yaml: string): { data: ParsedFrontmatter; errors: string[] } {
|
||||||
const data: ParsedFrontmatter = {};
|
const data: ParsedFrontmatter = {};
|
||||||
const errors: string[] = [];
|
const errors: string[] = [];
|
||||||
@@ -140,108 +174,33 @@ function parseFrontmatter(yaml: string): { data: ParsedFrontmatter; errors: stri
|
|||||||
const key = line.slice(0, colonIdx).trim();
|
const key = line.slice(0, colonIdx).trim();
|
||||||
const valueRaw = line.slice(colonIdx + 1).trim();
|
const valueRaw = line.slice(colonIdx + 1).trim();
|
||||||
|
|
||||||
if (key === 'temperature') {
|
const numericSpec = NUMERIC_FIELDS.find((f) => f.key === key);
|
||||||
|
if (numericSpec) {
|
||||||
const n = Number(valueRaw);
|
const n = Number(valueRaw);
|
||||||
if (Number.isFinite(n)) data.temperature = n;
|
const typeOk = numericSpec.isInt ? Number.isInteger(n) : Number.isFinite(n);
|
||||||
else errors.push(`temperature must be a number (got "${valueRaw}")`);
|
if (typeOk) {
|
||||||
} else if (key === 'top_p') {
|
// Soft-range: store regardless of range; out-of-range only warns.
|
||||||
const n = Number(valueRaw);
|
data[numericSpec.key] = n;
|
||||||
if (Number.isFinite(n)) {
|
const below = numericSpec.min !== undefined && n < numericSpec.min;
|
||||||
data.top_p = n;
|
const above = numericSpec.max !== undefined && n > numericSpec.max;
|
||||||
if (n < 0 || n > 1) {
|
if (below || above) {
|
||||||
console.warn(`agents: top_p ${n} out of range 0-1, ignoring (falling back to default)`);
|
const range =
|
||||||
|
numericSpec.max !== undefined
|
||||||
|
? `${numericSpec.min}-${numericSpec.max}`
|
||||||
|
: `(≥${numericSpec.min})`;
|
||||||
|
console.warn(
|
||||||
|
`agents: ${numericSpec.key} ${n} out of range ${range}, ignoring (falling back to default)`,
|
||||||
|
);
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
errors.push(`top_p must be a number (got "${valueRaw}")`);
|
errors.push(
|
||||||
|
`${numericSpec.key} must be ${numericSpec.isInt ? 'an integer' : 'a number'} (got "${valueRaw}")`,
|
||||||
|
);
|
||||||
}
|
}
|
||||||
} else if (key === 'top_k') {
|
continue;
|
||||||
const n = Number(valueRaw);
|
}
|
||||||
if (Number.isInteger(n)) {
|
|
||||||
data.top_k = n;
|
if (key === 'tools') {
|
||||||
if (n < 0 || n > 200) {
|
|
||||||
console.warn(`agents: top_k ${n} out of range 0-200, ignoring (falling back to default)`);
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
errors.push(`top_k must be an integer (got "${valueRaw}")`);
|
|
||||||
}
|
|
||||||
} else if (key === 'min_p') {
|
|
||||||
const n = Number(valueRaw);
|
|
||||||
if (Number.isFinite(n)) {
|
|
||||||
data.min_p = n;
|
|
||||||
if (n < 0 || n > 1) {
|
|
||||||
console.warn(`agents: min_p ${n} out of range 0-1, ignoring (falling back to default)`);
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
errors.push(`min_p must be a number (got "${valueRaw}")`);
|
|
||||||
}
|
|
||||||
} else if (key === 'presence_penalty') {
|
|
||||||
const n = Number(valueRaw);
|
|
||||||
if (Number.isFinite(n)) {
|
|
||||||
data.presence_penalty = n;
|
|
||||||
if (n < -2 || n > 2) {
|
|
||||||
console.warn(`agents: presence_penalty ${n} out of range -2-2, ignoring (falling back to default)`);
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
errors.push(`presence_penalty must be a number (got "${valueRaw}")`);
|
|
||||||
}
|
|
||||||
} else if (key === 'top_n_sigma') {
|
|
||||||
// v2.6 #11: llama.cpp top-n-sigma sampler. Float ≥ 0 (typical 0-3).
|
|
||||||
// Mirrors top_p/min_p: store then warn on out-of-range (non-numeric
|
|
||||||
// hard-fails the block).
|
|
||||||
const n = Number(valueRaw);
|
|
||||||
if (Number.isFinite(n)) {
|
|
||||||
data.top_n_sigma = n;
|
|
||||||
if (n < 0) {
|
|
||||||
console.warn(`agents: top_n_sigma ${n} out of range (≥0), ignoring (falling back to default)`);
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
errors.push(`top_n_sigma must be a number (got "${valueRaw}")`);
|
|
||||||
}
|
|
||||||
} else if (key === 'dry_multiplier') {
|
|
||||||
// v2.6 #11: DRY repetition-penalty multiplier. Float ≥ 0 (0 disables DRY).
|
|
||||||
const n = Number(valueRaw);
|
|
||||||
if (Number.isFinite(n)) {
|
|
||||||
data.dry_multiplier = n;
|
|
||||||
if (n < 0) {
|
|
||||||
console.warn(`agents: dry_multiplier ${n} out of range (≥0), ignoring (falling back to default)`);
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
errors.push(`dry_multiplier must be a number (got "${valueRaw}")`);
|
|
||||||
}
|
|
||||||
} else if (key === 'dry_base') {
|
|
||||||
// v2.6 #11: DRY penalty growth base. Float ≥ 0.
|
|
||||||
const n = Number(valueRaw);
|
|
||||||
if (Number.isFinite(n)) {
|
|
||||||
data.dry_base = n;
|
|
||||||
if (n < 0) {
|
|
||||||
console.warn(`agents: dry_base ${n} out of range (≥0), ignoring (falling back to default)`);
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
errors.push(`dry_base must be a number (got "${valueRaw}")`);
|
|
||||||
}
|
|
||||||
} else if (key === 'dry_allowed_length') {
|
|
||||||
// v2.6 #11: DRY max sequence length not penalized. Integer ≥ 0.
|
|
||||||
const n = Number(valueRaw);
|
|
||||||
if (Number.isInteger(n)) {
|
|
||||||
data.dry_allowed_length = n;
|
|
||||||
if (n < 0) {
|
|
||||||
console.warn(`agents: dry_allowed_length ${n} out of range (≥0), ignoring (falling back to default)`);
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
errors.push(`dry_allowed_length must be an integer (got "${valueRaw}")`);
|
|
||||||
}
|
|
||||||
} else if (key === 'dry_penalty_last_n') {
|
|
||||||
// v2.6 #11: DRY lookback window. Integer ≥ -1 (-1 = whole context, 0 = off).
|
|
||||||
const n = Number(valueRaw);
|
|
||||||
if (Number.isInteger(n)) {
|
|
||||||
data.dry_penalty_last_n = n;
|
|
||||||
if (n < -1) {
|
|
||||||
console.warn(`agents: dry_penalty_last_n ${n} out of range (≥-1), ignoring (falling back to default)`);
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
errors.push(`dry_penalty_last_n must be an integer (got "${valueRaw}")`);
|
|
||||||
}
|
|
||||||
} else if (key === 'tools') {
|
|
||||||
if (valueRaw === '') {
|
if (valueRaw === '') {
|
||||||
data.tools = [];
|
data.tools = [];
|
||||||
arrayKey = 'tools';
|
arrayKey = 'tools';
|
||||||
@@ -478,14 +437,6 @@ interface CacheEntry {
|
|||||||
// corresponding mtime so the next read sees a miss without a watcher.
|
// corresponding mtime so the next read sees a miss without a watcher.
|
||||||
const cache = new Map<string, CacheEntry>();
|
const cache = new Map<string, CacheEntry>();
|
||||||
|
|
||||||
export function invalidateAgentsCache(projectPath?: string): void {
|
|
||||||
if (projectPath === undefined) {
|
|
||||||
cache.clear();
|
|
||||||
} else {
|
|
||||||
cache.delete(projectPath);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// v1.13.8: cache-read accessor for the system-prompt prefix-fingerprint log.
|
// v1.13.8: cache-read accessor for the system-prompt prefix-fingerprint log.
|
||||||
// Returns the AGENTS.md mtimes that getAgentsForProject() observed on its
|
// Returns the AGENTS.md mtimes that getAgentsForProject() observed on its
|
||||||
// last cache fill for this projectPath. Both fields are null when the cache
|
// last cache fill for this projectPath. Both fields are null when the cache
|
||||||
|
|||||||
@@ -19,8 +19,6 @@ function cleanTitle(raw: string): string {
|
|||||||
return name;
|
return name;
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: wire suggestTags after task model validation
|
|
||||||
|
|
||||||
export async function maybeAutoNameChat(
|
export async function maybeAutoNameChat(
|
||||||
ctx: InferenceContext,
|
ctx: InferenceContext,
|
||||||
chatId: string,
|
chatId: string,
|
||||||
|
|||||||
@@ -113,7 +113,7 @@ export async function callCodecontext(
|
|||||||
fetcher: typeof fetch = fetch,
|
fetcher: typeof fetch = fetch,
|
||||||
): Promise<CodecontextResponse> {
|
): Promise<CodecontextResponse> {
|
||||||
// Step 1: realpath the project root, then realpath the requested target_dir
|
// Step 1: realpath the project root, then realpath the requested target_dir
|
||||||
// (defaulting to projectPath when the caller didn't pass one — the 8 wrappers
|
// (defaulting to projectPath when the caller didn't pass one — the 12 wrappers
|
||||||
// never pass target_dir; tests can override). A non-existent target_dir
|
// never pass target_dir; tests can override). A non-existent target_dir
|
||||||
// throws before we hit the network so the model gets a sharp error.
|
// throws before we hit the network so the model gets a sharp error.
|
||||||
const resolvedProject = await realpath(req.projectPath);
|
const resolvedProject = await realpath(req.projectPath);
|
||||||
|
|||||||
@@ -22,6 +22,8 @@ import type { Config } from '../config.js';
|
|||||||
import type { Broker } from './broker.js';
|
import type { Broker } from './broker.js';
|
||||||
import { SUMMARY_TEMPLATE } from './compaction-prompt.js';
|
import { SUMMARY_TEMPLATE } from './compaction-prompt.js';
|
||||||
import * as modelContextLookup from './model-context.js';
|
import * as modelContextLookup from './model-context.js';
|
||||||
|
import { SENTINEL_KINDS } from './inference/sentinels.js';
|
||||||
|
import type { OpenAiMessage } from './inference/payload.js';
|
||||||
|
|
||||||
// v1.13.9: ratio-only overflow trigger. Fires compaction at 85% of ctx_max
|
// v1.13.9: ratio-only overflow trigger. Fires compaction at 85% of ctx_max
|
||||||
// (opencode session/overflow.ts pattern). Replaces the v1.11.0-era
|
// (opencode session/overflow.ts pattern). Replaces the v1.11.0-era
|
||||||
@@ -256,24 +258,9 @@ export function buildPrompt(
|
|||||||
// would silently drop pre-legacy-compact history before the LLM sees it.
|
// would silently drop pre-legacy-compact history before the LLM sees it.
|
||||||
// Compaction wants to send the entire head, full stop.) ===
|
// Compaction wants to send the entire head, full stop.) ===
|
||||||
|
|
||||||
// v1.13.6: exported for unit-test access (reasoning render coverage).
|
// #12: SENTINEL_KINDS imported from inference/sentinels.ts (single source).
|
||||||
export interface OpenAiMessage {
|
// OpenAiMessage imported from inference/payload.ts (structurally compatible —
|
||||||
role: 'system' | 'user' | 'assistant' | 'tool';
|
// compaction's head payload doesn't need the optional reasoning? field).
|
||||||
content: string | null;
|
|
||||||
tool_calls?: Array<{
|
|
||||||
id: string;
|
|
||||||
type: 'function';
|
|
||||||
function: { name: string; arguments: string };
|
|
||||||
}>;
|
|
||||||
tool_call_id?: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
// #12: mirror inference/sentinels.ts:isAnySentinel over the CompactionMessage
|
|
||||||
// shape (which carries metadata as { kind?: string } | null, not the full
|
|
||||||
// Message type isAnySentinel expects). All UI-only sentinels are stripped from
|
|
||||||
// the head payload — they never go to the summarizer LLM. Keep the kind list in
|
|
||||||
// sync with isAnySentinel in sentinels.ts.
|
|
||||||
const SENTINEL_KINDS = new Set(['cap_hit', 'doom_loop', 'mistake_recovery']);
|
|
||||||
function isAnySentinel(m: CompactionMessage): boolean {
|
function isAnySentinel(m: CompactionMessage): boolean {
|
||||||
return (
|
return (
|
||||||
m.role === 'system' &&
|
m.role === 'system' &&
|
||||||
|
|||||||
@@ -200,7 +200,7 @@ export async function grep(
|
|||||||
export async function findFiles(
|
export async function findFiles(
|
||||||
projectRoot: string,
|
projectRoot: string,
|
||||||
pattern?: string,
|
pattern?: string,
|
||||||
opts?: { type?: 'file' | 'dir'; max_results?: number; path?: string; extra_roots?: readonly string[] }
|
opts?: { max_results?: number; path?: string; extra_roots?: readonly string[] }
|
||||||
): Promise<FindFilesResult> {
|
): Promise<FindFilesResult> {
|
||||||
const limit = Math.min(
|
const limit = Math.min(
|
||||||
Math.max(opts?.max_results ?? DEFAULT_FIND_RESULTS, 1),
|
Math.max(opts?.max_results ?? DEFAULT_FIND_RESULTS, 1),
|
||||||
|
|||||||
@@ -83,10 +83,3 @@ export async function getGitMeta(rootPath: string): Promise<GitMeta | null> {
|
|||||||
return value;
|
return value;
|
||||||
}
|
}
|
||||||
|
|
||||||
export function invalidateGitMetaCache(rootPath?: string): void {
|
|
||||||
if (rootPath) {
|
|
||||||
cache.delete(rootPath);
|
|
||||||
} else {
|
|
||||||
cache.clear();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -1,32 +1,10 @@
|
|||||||
import type { Agent } from '../../types/api.js';
|
import type { Agent } from '../../types/api.js';
|
||||||
import { READ_ONLY_TOOL_NAMES } from '../tools.js';
|
|
||||||
|
|
||||||
// v1.8.2: tool-call budget defaults. Resolved per-turn by resolveToolBudget.
|
|
||||||
// - Agent with explicit max_tool_calls: that value.
|
|
||||||
// - Agent with read-only-only tools: BUDGET_READ_ONLY (50).
|
|
||||||
// - Agent with any non-read-only tool: BUDGET_NON_READ_ONLY (10).
|
|
||||||
// - No agent (raw chat): BUDGET_NO_AGENT (50).
|
|
||||||
// v1.13.7: bumped BUDGET_NO_AGENT 15→30 to match BUDGET_READ_ONLY. Every tool
|
|
||||||
// in ALL_TOOLS today is read-only (see services/tools.ts comment at
|
|
||||||
// READ_ONLY_TOOL_NAMES); the cautious 15-cap was a forward-looking guard for
|
|
||||||
// write tools that haven't landed yet. No-agent mode gets the same toolset as
|
|
||||||
// an all-read-only agent at runtime, so they should share the same budget.
|
|
||||||
// v1.13.12: bumped read-only caps 30→50. Real recon sessions were hitting 30
|
|
||||||
// with ~3 turns wasted on codecontext parse failures (empty node_modules
|
|
||||||
// files); legitimate need was ~27, and Architect-class system overviews want
|
|
||||||
// deeper recon than a 30-cap permits. Headroom of 20 absorbs failure-retry
|
|
||||||
// turns + deeper exploration without changing the safety floor materially —
|
|
||||||
// the doom-loop guard (3 identical calls → abort) catches the actual failure
|
|
||||||
// mode this cap was guarding against.
|
|
||||||
export const BUDGET_READ_ONLY = 100;
|
|
||||||
export const BUDGET_NON_READ_ONLY = 100;
|
|
||||||
export const BUDGET_NO_AGENT = 100;
|
|
||||||
|
|
||||||
const READ_ONLY_SET: ReadonlySet<string> = new Set(READ_ONLY_TOOL_NAMES);
|
|
||||||
|
|
||||||
|
// Tool-call budget. All three historical tiers (read-only, non-read-only,
|
||||||
|
// no-agent) converged to 100 as of v1.13.12, collapsing the tier logic.
|
||||||
|
// The only remaining override is per-agent max_tool_calls from AGENTS.md
|
||||||
|
// frontmatter. Flat default of 100; doom-loop guard in sentinels.ts catches
|
||||||
|
// pathological cases well before the cap is reached.
|
||||||
export function resolveToolBudget(agent: Agent | null): number {
|
export function resolveToolBudget(agent: Agent | null): number {
|
||||||
if (agent?.max_tool_calls != null) return agent.max_tool_calls;
|
return agent?.max_tool_calls ?? 100;
|
||||||
if (!agent) return BUDGET_NO_AGENT;
|
|
||||||
const allReadOnly = agent.tools.every((t) => READ_ONLY_SET.has(t));
|
|
||||||
return allReadOnly ? BUDGET_READ_ONLY : BUDGET_NON_READ_ONLY;
|
|
||||||
}
|
}
|
||||||
|
|||||||
64
apps/server/src/services/inference/content-flusher.ts
Normal file
64
apps/server/src/services/inference/content-flusher.ts
Normal file
@@ -0,0 +1,64 @@
|
|||||||
|
// P5: the debounced DB content-flush timer, extracted from the verbatim copy
|
||||||
|
// that lived in executeStreamPhase + the three sentinel summaries (4 sites).
|
||||||
|
// Each site streamed deltas into a local `accumulated`/`state.accumulated`
|
||||||
|
// string and threw an UPDATE at the row at most once per DB_FLUSH_INTERVAL_MS
|
||||||
|
// to bound write rate under heavy streaming.
|
||||||
|
//
|
||||||
|
// The accumulated string stays owned by the caller (stream-phase keeps it on
|
||||||
|
// the shared StreamPhaseState; the summaries keep a local) — the flusher reads
|
||||||
|
// it through a `getContent` thunk at fire time, snapshotting the latest value
|
||||||
|
// exactly as the inline `const snapshot = accumulated` did. No final flush is
|
||||||
|
// performed on drain (matches the originals): every caller writes the full
|
||||||
|
// content itself in its terminal UPDATE, so drain only cancels the pending
|
||||||
|
// timer and awaits whatever write is already chained.
|
||||||
|
|
||||||
|
import type { Sql } from '../../db.js';
|
||||||
|
import { DB_FLUSH_INTERVAL_MS } from './types.js';
|
||||||
|
|
||||||
|
export interface ContentFlusher {
|
||||||
|
// Arm a debounced flush. No-op if one is already pending (the in-flight timer
|
||||||
|
// will pick up the latest content via getContent when it fires).
|
||||||
|
scheduleFlush: () => void;
|
||||||
|
// Cancel any pending timer and await the in-flight write chain. Does NOT
|
||||||
|
// perform a final flush — the caller's terminal UPDATE owns the final write.
|
||||||
|
drain: () => Promise<void>;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function createContentFlusher(
|
||||||
|
sql: Sql,
|
||||||
|
messageId: string,
|
||||||
|
getContent: () => string,
|
||||||
|
intervalMs: number = DB_FLUSH_INTERVAL_MS,
|
||||||
|
): ContentFlusher {
|
||||||
|
let pendingFlushTimer: NodeJS.Timeout | null = null;
|
||||||
|
let flushPromise: Promise<unknown> = Promise.resolve();
|
||||||
|
|
||||||
|
const flushNow = () => {
|
||||||
|
if (pendingFlushTimer) {
|
||||||
|
clearTimeout(pendingFlushTimer);
|
||||||
|
pendingFlushTimer = null;
|
||||||
|
}
|
||||||
|
const snapshot = getContent();
|
||||||
|
flushPromise = flushPromise.then(() =>
|
||||||
|
sql`UPDATE messages SET content = ${snapshot} WHERE id = ${messageId}`
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
const scheduleFlush = () => {
|
||||||
|
if (pendingFlushTimer) return;
|
||||||
|
pendingFlushTimer = setTimeout(() => {
|
||||||
|
pendingFlushTimer = null;
|
||||||
|
flushNow();
|
||||||
|
}, intervalMs);
|
||||||
|
};
|
||||||
|
|
||||||
|
const drain = async () => {
|
||||||
|
if (pendingFlushTimer) {
|
||||||
|
clearTimeout(pendingFlushTimer);
|
||||||
|
pendingFlushTimer = null;
|
||||||
|
}
|
||||||
|
await flushPromise;
|
||||||
|
};
|
||||||
|
|
||||||
|
return { scheduleFlush, drain };
|
||||||
|
}
|
||||||
@@ -10,7 +10,7 @@ import { maybeFlagForCompaction } from './payload.js';
|
|||||||
import { insertParts, partsFromAssistantMessage } from './parts.js';
|
import { insertParts, partsFromAssistantMessage } from './parts.js';
|
||||||
import type { PartInsert } from './parts.js';
|
import type { PartInsert } from './parts.js';
|
||||||
import { stripToolMarkup } from './tool-call-parser.js';
|
import { stripToolMarkup } from './tool-call-parser.js';
|
||||||
import type { InferenceContext, StreamResult, TurnArgs } from './turn.js';
|
import type { InferenceContext, StreamResult, TurnArgs } from './types.js';
|
||||||
|
|
||||||
export async function handleAbortOrError(
|
export async function handleAbortOrError(
|
||||||
ctx: InferenceContext,
|
ctx: InferenceContext,
|
||||||
@@ -95,6 +95,90 @@ export async function handleAbortOrError(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// P5: the success-finalize atom shared by the wrap-up summaries
|
||||||
|
// (sentinel-summaries.ts) and the synthesis pass (synthesisPipeline.ts). Both
|
||||||
|
// previously hand-rolled this exact ceremony — n_ctx lookup, the complete
|
||||||
|
// UPDATE (content/status/tokens/ctx/ctx_max/finished_at; NO model column), and
|
||||||
|
// the message_complete frame with the full token fields. Single-sourcing it
|
||||||
|
// means a message_complete frame-contract change lands in one place instead of
|
||||||
|
// silently skipping the summary/synthesis paths.
|
||||||
|
//
|
||||||
|
// `beforeComplete` runs AFTER the UPDATE and BEFORE the message_complete frame
|
||||||
|
// — synthesis uses it to write its kind='synthesis' part in the original order
|
||||||
|
// (UPDATE → insertParts → message_complete), preserving timing exactly.
|
||||||
|
//
|
||||||
|
// NOTE: finalizeCompletion does NOT use this — it additionally writes the
|
||||||
|
// `model` column, the text/reasoning/html_artifact parts, the compaction flag,
|
||||||
|
// and the session_updated bump, which this atom deliberately omits (the summary
|
||||||
|
// and synthesis paths handle those — or not — themselves).
|
||||||
|
export async function finalizeStreamedRow(
|
||||||
|
ctx: InferenceContext,
|
||||||
|
opts: {
|
||||||
|
sessionId: string;
|
||||||
|
chatId: string;
|
||||||
|
messageId: string;
|
||||||
|
model: string;
|
||||||
|
content: string;
|
||||||
|
completionTokens: number | null;
|
||||||
|
promptTokens: number | null;
|
||||||
|
startedAt: string | null;
|
||||||
|
beforeComplete?: () => Promise<void>;
|
||||||
|
},
|
||||||
|
): Promise<void> {
|
||||||
|
// v1.11.3: see executeToolPhase for the rationale.
|
||||||
|
const mctx = await modelContext.getModelContext(opts.model);
|
||||||
|
const nCtx = mctx?.n_ctx ?? null;
|
||||||
|
const [updated] = await ctx.sql<
|
||||||
|
{ tokens_used: number | null; ctx_used: number | null; ctx_max: number | null; finished_at: string | null }[]
|
||||||
|
>`
|
||||||
|
UPDATE messages
|
||||||
|
SET content = ${opts.content},
|
||||||
|
status = 'complete',
|
||||||
|
tokens_used = ${opts.completionTokens},
|
||||||
|
ctx_used = ${opts.promptTokens},
|
||||||
|
ctx_max = ${nCtx},
|
||||||
|
finished_at = clock_timestamp()
|
||||||
|
WHERE id = ${opts.messageId}
|
||||||
|
RETURNING tokens_used, ctx_used, ctx_max, finished_at
|
||||||
|
`;
|
||||||
|
if (opts.beforeComplete) await opts.beforeComplete();
|
||||||
|
ctx.publish(opts.sessionId, {
|
||||||
|
type: 'message_complete',
|
||||||
|
message_id: opts.messageId,
|
||||||
|
chat_id: opts.chatId,
|
||||||
|
tokens_used: updated?.tokens_used ?? null,
|
||||||
|
ctx_used: updated?.ctx_used ?? null,
|
||||||
|
ctx_max: updated?.ctx_max ?? null,
|
||||||
|
started_at: opts.startedAt,
|
||||||
|
finished_at: updated?.finished_at ?? null,
|
||||||
|
model: opts.model,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// P5: minimal empty-finalize for the mistake-escalate path. The escalate
|
||||||
|
// branch in runAssistantTurn stops the turn cap-hit-style; the next assistant
|
||||||
|
// row is still 'streaming', so it's finalized as an empty complete row (no
|
||||||
|
// tokens, no parts, no session bump — the escalate branch handles the sentinel
|
||||||
|
// + chat_status itself). Centralizing the status-column write + message_complete
|
||||||
|
// frame here keeps it next to the other finalize paths so a status-column
|
||||||
|
// change is found in one place.
|
||||||
|
export async function finalizeEmpty(
|
||||||
|
ctx: InferenceContext,
|
||||||
|
args: TurnArgs,
|
||||||
|
): Promise<void> {
|
||||||
|
const { sessionId, chatId, assistantMessageId } = args;
|
||||||
|
await ctx.sql`
|
||||||
|
UPDATE messages
|
||||||
|
SET content = '', status = 'complete', finished_at = clock_timestamp()
|
||||||
|
WHERE id = ${assistantMessageId}
|
||||||
|
`;
|
||||||
|
ctx.publish(sessionId, {
|
||||||
|
type: 'message_complete',
|
||||||
|
message_id: assistantMessageId,
|
||||||
|
chat_id: chatId,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
export async function finalizeCompletion(
|
export async function finalizeCompletion(
|
||||||
ctx: InferenceContext,
|
ctx: InferenceContext,
|
||||||
args: TurnArgs,
|
args: TurnArgs,
|
||||||
|
|||||||
@@ -7,26 +7,17 @@
|
|||||||
export {
|
export {
|
||||||
createInferenceRunner,
|
createInferenceRunner,
|
||||||
MAX_STEPS,
|
MAX_STEPS,
|
||||||
runAssistantTurn,
|
|
||||||
runInference,
|
runInference,
|
||||||
} from './turn.js';
|
} from './turn.js';
|
||||||
|
// P5: the shared pipeline types moved from turn.ts to types.ts (breaking the
|
||||||
|
// hub-and-leaf near-cycle). Re-exported here so the public surface is unchanged.
|
||||||
export type {
|
export type {
|
||||||
FramePublisher,
|
FramePublisher,
|
||||||
InferenceContext,
|
InferenceContext,
|
||||||
InferenceFrame,
|
InferenceFrame,
|
||||||
StreamResult,
|
StreamResult,
|
||||||
TurnArgs,
|
TurnArgs,
|
||||||
} from './turn.js';
|
} from './types.js';
|
||||||
export type { ToolPhaseResult } from './tool-phase.js';
|
export type { ToolPhaseResult } from './tool-phase.js';
|
||||||
export { detectDoomLoop, DOOM_LOOP_THRESHOLD } from './sentinels.js';
|
export { detectDoomLoop, DOOM_LOOP_THRESHOLD } from './sentinels.js';
|
||||||
export {
|
|
||||||
detectMistakePattern,
|
|
||||||
freshMistakeState,
|
|
||||||
recordStep,
|
|
||||||
MISTAKE_THRESHOLD,
|
|
||||||
MISTAKE_RECOVERY_NOTE,
|
|
||||||
} from './mistake-tracker.js';
|
|
||||||
export type { FailureKind, MistakeState } from './mistake-tracker.js';
|
|
||||||
export { buildMessagesPayload } from './payload.js';
|
export { buildMessagesPayload } from './payload.js';
|
||||||
export { generateToolUseSummary } from './tool-summaries.js';
|
|
||||||
export type { ToolInfo } from './tool-summaries.js';
|
|
||||||
|
|||||||
@@ -1,11 +1,10 @@
|
|||||||
import type { Sql } from '../../db.js';
|
import type { Sql } from '../../db.js';
|
||||||
import type { ToolCall, ToolResult } from '../../types/api.js';
|
import type { ToolCall, ToolResult } from '../../types/api.js';
|
||||||
|
|
||||||
// v1.13.0: dual-write helper. Every site that writes the legacy
|
// v1.13.0: message_parts write helpers. v1.13.20: legacy tool_calls/
|
||||||
// messages.tool_calls / messages.tool_results JSON columns calls into here
|
// tool_results JSON columns dropped; message_parts is the sole source of
|
||||||
// to mirror the same data into message_parts rows. Reads still go to the
|
// truth. All writes go through insertParts / partsFromAssistantMessage /
|
||||||
// JSON columns; the swap to parts-as-source-of-truth happens in a later
|
// partsFromToolMessage. Reads use the messages_with_parts view.
|
||||||
// v1.13 dispatch alongside the AI SDK streamText migration.
|
|
||||||
|
|
||||||
// v1.13.13: 'synthesis' added. Schema CHECK constraint is updated in lockstep
|
// v1.13.13: 'synthesis' added. Schema CHECK constraint is updated in lockstep
|
||||||
// (schema.sql adds 'synthesis' to message_parts_kind_chk on startup). The
|
// (schema.sql adds 'synthesis' to message_parts_kind_chk on startup). The
|
||||||
|
|||||||
@@ -10,7 +10,8 @@ import * as compaction from '../compaction.js';
|
|||||||
import { buildSystemPromptWithFingerprint } from '../system-prompt.js';
|
import { buildSystemPromptWithFingerprint } from '../system-prompt.js';
|
||||||
import { isAnySentinel } from './sentinels.js';
|
import { isAnySentinel } from './sentinels.js';
|
||||||
import { PRUNE_TRIGGER_TOKENS, prune } from './prune.js';
|
import { PRUNE_TRIGGER_TOKENS, prune } from './prune.js';
|
||||||
import type { InferenceContext } from './turn.js';
|
import type { InferenceContext } from './types.js';
|
||||||
|
import { INFERENCE_MESSAGE_COLUMNS } from '../message-columns.js';
|
||||||
|
|
||||||
export interface OpenAiMessage {
|
export interface OpenAiMessage {
|
||||||
role: 'system' | 'user' | 'assistant' | 'tool';
|
role: 'system' | 'user' | 'assistant' | 'tool';
|
||||||
@@ -205,9 +206,7 @@ export async function loadContext(
|
|||||||
// v1.13.1-C: also pull reasoning_parts so assistant messages from
|
// v1.13.1-C: also pull reasoning_parts so assistant messages from
|
||||||
// reasoning models can be replayed with their reasoning context preserved.
|
// reasoning models can be replayed with their reasoning context preserved.
|
||||||
const history = await sql<Message[]>`
|
const history = await sql<Message[]>`
|
||||||
SELECT id, session_id, chat_id, role, content, kind, tool_calls, tool_results, status, last_seq,
|
SELECT ${sql.unsafe(INFERENCE_MESSAGE_COLUMNS)}
|
||||||
tokens_used, ctx_used, ctx_max, started_at, finished_at, created_at, metadata,
|
|
||||||
reasoning_parts
|
|
||||||
FROM messages_with_parts
|
FROM messages_with_parts
|
||||||
WHERE chat_id = ${chatId} AND compacted_at IS NULL
|
WHERE chat_id = ${chatId} AND compacted_at IS NULL
|
||||||
ORDER BY created_at ASC, id ASC
|
ORDER BY created_at ASC, id ASC
|
||||||
|
|||||||
@@ -5,16 +5,16 @@ import type {
|
|||||||
Project,
|
Project,
|
||||||
Session,
|
Session,
|
||||||
} from '../../types/api.js';
|
} from '../../types/api.js';
|
||||||
import * as modelContext from '../model-context.js';
|
|
||||||
import { buildMessagesPayload } from './payload.js';
|
import { buildMessagesPayload } from './payload.js';
|
||||||
import { DOOM_LOOP_THRESHOLD } from './sentinels.js';
|
import { DOOM_LOOP_THRESHOLD } from './sentinels.js';
|
||||||
import { streamCompletion } from './stream-phase.js';
|
import { streamCompletion, samplerOptsFromAgent } from './stream-phase.js';
|
||||||
import { DB_FLUSH_INTERVAL_MS } from './types.js';
|
import { createContentFlusher } from './content-flusher.js';
|
||||||
|
import { finalizeStreamedRow } from './error-handler.js';
|
||||||
import type {
|
import type {
|
||||||
InferenceContext,
|
InferenceContext,
|
||||||
StreamResult,
|
StreamResult,
|
||||||
TurnArgs,
|
TurnArgs,
|
||||||
} from './turn.js';
|
} from './types.js';
|
||||||
|
|
||||||
// Synthetic system note appended to the cap-hit summary call. Verbatim from
|
// Synthetic system note appended to the cap-hit summary call. Verbatim from
|
||||||
// the v1.8.2 spec — do not paraphrase: the model is more reliable when the
|
// the v1.8.2 spec — do not paraphrase: the model is more reliable when the
|
||||||
@@ -25,21 +25,50 @@ const CAP_HIT_SUMMARY_NOTE = (limit: number) =>
|
|||||||
const DOOM_LOOP_NOTE = (name: string) =>
|
const DOOM_LOOP_NOTE = (name: string) =>
|
||||||
`You called ${name} with the same arguments ${DOOM_LOOP_THRESHOLD} times in a row. Stop calling it. Produce the best answer you can with what you have.`;
|
`You called ${name} with the same arguments ${DOOM_LOOP_THRESHOLD} times in a row. Stop calling it. Produce the best answer you can with what you have.`;
|
||||||
|
|
||||||
export async function runCapHitSummary(
|
// v1.14.0: step-cap wrap-up note. Names the step limit rather than the tool
|
||||||
|
// budget. The sentinel reuses metadata.kind = 'cap_hit' so the frontend
|
||||||
|
// CapHitSentinel component renders it without changes.
|
||||||
|
const STEP_CAP_NOTE = (steps: number, cap: number) =>
|
||||||
|
`You've reached the step limit (${steps}/${cap} steps). Produce the best answer you can with what you have. Do not call more tools.`;
|
||||||
|
|
||||||
|
// P5: the ONE generic wrap-up flow shared by the three sentinel summaries
|
||||||
|
// (cap-hit, doom-loop, step-cap). Each reuses the in-flight assistant slot to
|
||||||
|
// stream a short tools-disabled summary, finalizes via the same 3-outcome
|
||||||
|
// branch (complete / cancelled / failed), bumps the session, then drops a
|
||||||
|
// sentinel and the chat_status. The three differ only in:
|
||||||
|
// - `note`: the synthetic system instruction appended to the summary call.
|
||||||
|
// - `errorText`: the fallback used in the failed-status metadata + error frame.
|
||||||
|
// - sentinel timing: cap-hit inserts BEFORE the stream (`beforeStream`);
|
||||||
|
// doom-loop + step-cap insert AFTER the session bump (`afterSession`).
|
||||||
|
// - `logMsg` / `logFields`: per-kind log line + extra fields.
|
||||||
|
// All three use error_reason / chat_status reason = 'summary_after_cap_failed'
|
||||||
|
// (doom-loop reuses it deliberately — the user-visible failure mode is the
|
||||||
|
// same "model gave up mid-summary"; the ErrorReason union is shared and the UI
|
||||||
|
// surfaces a generic "summary failed" line for every sentinel path).
|
||||||
|
interface WrapUpOpts {
|
||||||
|
note: string;
|
||||||
|
errorText: string;
|
||||||
|
logMsg: string;
|
||||||
|
logFields: Record<string, unknown>;
|
||||||
|
beforeStream?: () => Promise<void>;
|
||||||
|
afterSession?: () => Promise<void>;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function runWrapUpSummary(
|
||||||
ctx: InferenceContext,
|
ctx: InferenceContext,
|
||||||
args: TurnArgs,
|
args: TurnArgs,
|
||||||
session: Session,
|
session: Session,
|
||||||
project: Project,
|
project: Project,
|
||||||
history: Message[],
|
history: Message[],
|
||||||
agent: Agent | null,
|
agent: Agent | null,
|
||||||
budget: number,
|
opts: WrapUpOpts,
|
||||||
): Promise<void> {
|
): Promise<void> {
|
||||||
const { sessionId, chatId, assistantMessageId, signal } = args;
|
const { sessionId, chatId, assistantMessageId, signal } = args;
|
||||||
|
|
||||||
await insertCapHitSentinel(ctx, sessionId, chatId, agent, budget);
|
if (opts.beforeStream) await opts.beforeStream();
|
||||||
|
|
||||||
const messages = await buildMessagesPayload(session, project, history, agent, ctx.log);
|
const messages = await buildMessagesPayload(session, project, history, agent, ctx.log);
|
||||||
messages.push({ role: 'system', content: CAP_HIT_SUMMARY_NOTE(budget) });
|
messages.push({ role: 'system', content: opts.note });
|
||||||
|
|
||||||
const startedRow = await ctx.sql<{ started_at: string }[]>`
|
const startedRow = await ctx.sql<{ started_at: string }[]>`
|
||||||
UPDATE messages
|
UPDATE messages
|
||||||
@@ -57,25 +86,7 @@ export async function runCapHitSummary(
|
|||||||
});
|
});
|
||||||
|
|
||||||
let accumulated = '';
|
let accumulated = '';
|
||||||
let pendingFlushTimer: NodeJS.Timeout | null = null;
|
const flusher = createContentFlusher(ctx.sql, assistantMessageId, () => accumulated);
|
||||||
let flushPromise: Promise<unknown> = Promise.resolve();
|
|
||||||
const flushNow = () => {
|
|
||||||
if (pendingFlushTimer) {
|
|
||||||
clearTimeout(pendingFlushTimer);
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
}
|
|
||||||
const snapshot = accumulated;
|
|
||||||
flushPromise = flushPromise.then(() =>
|
|
||||||
ctx.sql`UPDATE messages SET content = ${snapshot} WHERE id = ${assistantMessageId}`
|
|
||||||
);
|
|
||||||
};
|
|
||||||
const scheduleFlush = () => {
|
|
||||||
if (pendingFlushTimer) return;
|
|
||||||
pendingFlushTimer = setTimeout(() => {
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
flushNow();
|
|
||||||
}, DB_FLUSH_INTERVAL_MS);
|
|
||||||
};
|
|
||||||
|
|
||||||
let summaryOk = false;
|
let summaryOk = false;
|
||||||
let summarySoftCancelled = false;
|
let summarySoftCancelled = false;
|
||||||
@@ -86,7 +97,7 @@ export async function runCapHitSummary(
|
|||||||
ctx,
|
ctx,
|
||||||
session.model,
|
session.model,
|
||||||
messages,
|
messages,
|
||||||
{ tools: null, temperature: agent?.temperature, top_p: agent?.top_p ?? undefined, top_k: agent?.top_k ?? undefined, min_p: agent?.min_p ?? undefined, presence_penalty: agent?.presence_penalty ?? undefined, top_n_sigma: agent?.top_n_sigma ?? undefined, dry_multiplier: agent?.dry_multiplier ?? undefined, dry_base: agent?.dry_base ?? undefined, dry_allowed_length: agent?.dry_allowed_length ?? undefined, dry_penalty_last_n: agent?.dry_penalty_last_n ?? undefined },
|
{ tools: null, ...samplerOptsFromAgent(agent) },
|
||||||
(delta) => {
|
(delta) => {
|
||||||
accumulated += delta;
|
accumulated += delta;
|
||||||
ctx.publish(sessionId, {
|
ctx.publish(sessionId, {
|
||||||
@@ -95,7 +106,7 @@ export async function runCapHitSummary(
|
|||||||
chat_id: chatId,
|
chat_id: chatId,
|
||||||
content: delta,
|
content: delta,
|
||||||
});
|
});
|
||||||
scheduleFlush();
|
flusher.scheduleFlush();
|
||||||
},
|
},
|
||||||
undefined,
|
undefined,
|
||||||
signal,
|
signal,
|
||||||
@@ -108,44 +119,23 @@ export async function runCapHitSummary(
|
|||||||
summaryError = err instanceof Error ? err.message : String(err);
|
summaryError = err instanceof Error ? err.message : String(err);
|
||||||
}
|
}
|
||||||
} finally {
|
} finally {
|
||||||
if (pendingFlushTimer) {
|
await flusher.drain();
|
||||||
clearTimeout(pendingFlushTimer);
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
}
|
|
||||||
await flushPromise;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Finalize the summary message based on the three outcomes. The sentinel
|
// Finalize the summary message based on the three outcomes. The sentinel is
|
||||||
// is inserted regardless so the user always has the Continue affordance —
|
// inserted regardless (before or after, per opts) so the user always has the
|
||||||
// even on a partial / failed summary the chat history shows where the
|
// appropriate affordance — even on a partial / failed summary the chat
|
||||||
// budget was hit.
|
// history shows where the loop stopped.
|
||||||
if (summaryOk && result) {
|
if (summaryOk && result) {
|
||||||
// v1.11.3: see executeToolPhase for the rationale.
|
await finalizeStreamedRow(ctx, {
|
||||||
const mctx = await modelContext.getModelContext(session.model);
|
sessionId,
|
||||||
const nCtx = mctx?.n_ctx ?? null;
|
chatId,
|
||||||
const [updated] = await ctx.sql<
|
messageId: assistantMessageId,
|
||||||
{ tokens_used: number | null; ctx_used: number | null; ctx_max: number | null; finished_at: string | null }[]
|
|
||||||
>`
|
|
||||||
UPDATE messages
|
|
||||||
SET content = ${result.content},
|
|
||||||
status = 'complete',
|
|
||||||
tokens_used = ${result.completionTokens},
|
|
||||||
ctx_used = ${result.promptTokens},
|
|
||||||
ctx_max = ${nCtx},
|
|
||||||
finished_at = clock_timestamp()
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
RETURNING tokens_used, ctx_used, ctx_max, finished_at
|
|
||||||
`;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
tokens_used: updated?.tokens_used ?? null,
|
|
||||||
ctx_used: updated?.ctx_used ?? null,
|
|
||||||
ctx_max: updated?.ctx_max ?? null,
|
|
||||||
started_at: startedAt,
|
|
||||||
finished_at: updated?.finished_at ?? null,
|
|
||||||
model: session.model,
|
model: session.model,
|
||||||
|
content: result.content,
|
||||||
|
completionTokens: result.completionTokens,
|
||||||
|
promptTokens: result.promptTokens,
|
||||||
|
startedAt,
|
||||||
});
|
});
|
||||||
} else if (summarySoftCancelled) {
|
} else if (summarySoftCancelled) {
|
||||||
await ctx.sql`
|
await ctx.sql`
|
||||||
@@ -164,7 +154,7 @@ export async function runCapHitSummary(
|
|||||||
const errMeta: MessageMetadata = {
|
const errMeta: MessageMetadata = {
|
||||||
kind: 'error',
|
kind: 'error',
|
||||||
error_reason: 'summary_after_cap_failed',
|
error_reason: 'summary_after_cap_failed',
|
||||||
error_text: summaryError ?? 'summary failed',
|
error_text: summaryError ?? opts.errorText,
|
||||||
};
|
};
|
||||||
await ctx.sql`
|
await ctx.sql`
|
||||||
UPDATE messages
|
UPDATE messages
|
||||||
@@ -178,7 +168,7 @@ export async function runCapHitSummary(
|
|||||||
type: 'error',
|
type: 'error',
|
||||||
message_id: assistantMessageId,
|
message_id: assistantMessageId,
|
||||||
chat_id: chatId,
|
chat_id: chatId,
|
||||||
error: summaryError ?? 'summary failed',
|
error: summaryError ?? opts.errorText,
|
||||||
reason: 'summary_after_cap_failed',
|
reason: 'summary_after_cap_failed',
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
@@ -197,11 +187,11 @@ export async function runCapHitSummary(
|
|||||||
updated_at: sessRow!.updated_at,
|
updated_at: sessRow!.updated_at,
|
||||||
});
|
});
|
||||||
|
|
||||||
|
if (opts.afterSession) await opts.afterSession();
|
||||||
|
|
||||||
// Status frame fires last so the dot color reflects the terminal state.
|
// Status frame fires last so the dot color reflects the terminal state.
|
||||||
// Success → idle, abort → idle (user-driven stop), error → error+reason.
|
// Success → idle, abort → idle (user-driven stop), error → error+reason.
|
||||||
if (summaryOk) {
|
if (summaryOk || summarySoftCancelled) {
|
||||||
ctx.publishUser({ type: 'chat_status', chat_id: chatId, status: 'idle', at: new Date().toISOString() });
|
|
||||||
} else if (summarySoftCancelled) {
|
|
||||||
ctx.publishUser({ type: 'chat_status', chat_id: chatId, status: 'idle', at: new Date().toISOString() });
|
ctx.publishUser({ type: 'chat_status', chat_id: chatId, status: 'idle', at: new Date().toISOString() });
|
||||||
} else {
|
} else {
|
||||||
ctx.publishUser({
|
ctx.publishUser({
|
||||||
@@ -214,11 +204,113 @@ export async function runCapHitSummary(
|
|||||||
}
|
}
|
||||||
|
|
||||||
ctx.log.info(
|
ctx.log.info(
|
||||||
{ sessionId, chatId, assistantMessageId, budget, summaryOk, summaryCancelled: summarySoftCancelled },
|
{ sessionId, chatId, assistantMessageId, ...opts.logFields, summaryOk, summaryCancelled: summarySoftCancelled },
|
||||||
'inference cap-hit summary finished',
|
opts.logMsg,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// v1.8.2: cap-hit summary flow. Called instead of erroring when the loop hits
|
||||||
|
// its budget. The cap-hit sentinel is inserted FIRST (before the summary
|
||||||
|
// stream) so the UI shows the Continue affordance regardless of summary
|
||||||
|
// outcome.
|
||||||
|
export async function runCapHitSummary(
|
||||||
|
ctx: InferenceContext,
|
||||||
|
args: TurnArgs,
|
||||||
|
session: Session,
|
||||||
|
project: Project,
|
||||||
|
history: Message[],
|
||||||
|
agent: Agent | null,
|
||||||
|
budget: number,
|
||||||
|
): Promise<void> {
|
||||||
|
await runWrapUpSummary(ctx, args, session, project, history, agent, {
|
||||||
|
note: CAP_HIT_SUMMARY_NOTE(budget),
|
||||||
|
errorText: 'summary failed',
|
||||||
|
logMsg: 'inference cap-hit summary finished',
|
||||||
|
logFields: { budget },
|
||||||
|
beforeStream: () => insertCapHitSentinel(ctx, args.sessionId, args.chatId, agent, budget),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// v1.11.6: doom-loop wrap-up. The doom-loop sentinel is inserted AFTER the
|
||||||
|
// session bump (no Continue affordance — continuing would re-trigger the loop
|
||||||
|
// with the same tools available; the user needs to restate or switch agents).
|
||||||
|
export async function runDoomLoopSummary(
|
||||||
|
ctx: InferenceContext,
|
||||||
|
args: TurnArgs,
|
||||||
|
session: Session,
|
||||||
|
project: Project,
|
||||||
|
history: Message[],
|
||||||
|
agent: Agent | null,
|
||||||
|
loop: { name: string; args: Record<string, unknown> },
|
||||||
|
): Promise<void> {
|
||||||
|
await runWrapUpSummary(ctx, args, session, project, history, agent, {
|
||||||
|
note: DOOM_LOOP_NOTE(loop.name),
|
||||||
|
errorText: 'doom-loop summary failed',
|
||||||
|
logMsg: 'inference doom-loop summary finished',
|
||||||
|
logFields: { loopedTool: loop.name },
|
||||||
|
afterSession: () => insertDoomLoopSentinel(ctx, args.sessionId, args.chatId, loop),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// v1.14.0: step-cap wrap-up. Reuses the cap_hit sentinel (inserted AFTER the
|
||||||
|
// session bump) so the frontend CapHitSentinel component renders it without
|
||||||
|
// changes; the content text distinguishes step cap from budget.
|
||||||
|
export async function runStepCapSummary(
|
||||||
|
ctx: InferenceContext,
|
||||||
|
args: TurnArgs,
|
||||||
|
session: Session,
|
||||||
|
project: Project,
|
||||||
|
history: Message[],
|
||||||
|
agent: Agent | null,
|
||||||
|
steps: number,
|
||||||
|
cap: number,
|
||||||
|
): Promise<void> {
|
||||||
|
await runWrapUpSummary(ctx, args, session, project, history, agent, {
|
||||||
|
note: STEP_CAP_NOTE(steps, cap),
|
||||||
|
errorText: 'step-cap summary failed',
|
||||||
|
logMsg: 'inference step-cap summary finished',
|
||||||
|
logFields: { steps, cap },
|
||||||
|
afterSession: () => insertCapHitSentinel(ctx, args.sessionId, args.chatId, agent, cap),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// P5: the ONE INSERT + message_started → delta → message_complete frame
|
||||||
|
// sequence shared by every sentinel inserter. The sentinel row is a
|
||||||
|
// role='system', status='complete' message; the static content rides the same
|
||||||
|
// streaming-frame path useSessionStream's reducer uses for assistant messages
|
||||||
|
// (the delta carries the full text in one chunk).
|
||||||
|
async function insertSentinel(
|
||||||
|
ctx: InferenceContext,
|
||||||
|
sessionId: string,
|
||||||
|
chatId: string,
|
||||||
|
metadata: MessageMetadata,
|
||||||
|
content: string,
|
||||||
|
): Promise<void> {
|
||||||
|
const [row] = await ctx.sql<{ id: string }[]>`
|
||||||
|
INSERT INTO messages (session_id, chat_id, role, content, status, created_at, metadata)
|
||||||
|
VALUES (${sessionId}, ${chatId}, 'system', ${content}, 'complete', clock_timestamp(), ${ctx.sql.json(metadata as never)})
|
||||||
|
RETURNING id
|
||||||
|
`;
|
||||||
|
ctx.publish(sessionId, {
|
||||||
|
type: 'message_started',
|
||||||
|
message_id: row!.id,
|
||||||
|
chat_id: chatId,
|
||||||
|
role: 'system',
|
||||||
|
});
|
||||||
|
ctx.publish(sessionId, {
|
||||||
|
type: 'delta',
|
||||||
|
message_id: row!.id,
|
||||||
|
chat_id: chatId,
|
||||||
|
content,
|
||||||
|
});
|
||||||
|
ctx.publish(sessionId, {
|
||||||
|
type: 'message_complete',
|
||||||
|
message_id: row!.id,
|
||||||
|
chat_id: chatId,
|
||||||
|
metadata,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
async function insertCapHitSentinel(
|
async function insertCapHitSentinel(
|
||||||
ctx: InferenceContext,
|
ctx: InferenceContext,
|
||||||
sessionId: string,
|
sessionId: string,
|
||||||
@@ -246,430 +338,7 @@ async function insertCapHitSentinel(
|
|||||||
can_continue: canContinue,
|
can_continue: canContinue,
|
||||||
};
|
};
|
||||||
const content = `Reached tool budget (${budget}/${budget}). Continue to extend.`;
|
const content = `Reached tool budget (${budget}/${budget}). Continue to extend.`;
|
||||||
|
await insertSentinel(ctx, sessionId, chatId, metadata, content);
|
||||||
const [row] = await ctx.sql<{ id: string }[]>`
|
|
||||||
INSERT INTO messages (session_id, chat_id, role, content, status, created_at, metadata)
|
|
||||||
VALUES (${sessionId}, ${chatId}, 'system', ${content}, 'complete', clock_timestamp(), ${ctx.sql.json(metadata as never)})
|
|
||||||
RETURNING id
|
|
||||||
`;
|
|
||||||
|
|
||||||
// The sentinel content is static, but we still walk the standard frame
|
|
||||||
// sequence (started → delta → complete) so useSessionStream's reducer
|
|
||||||
// appends it via the same path it uses for streaming assistant messages.
|
|
||||||
// The delta carries the full text in one chunk.
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_started',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
role: 'system',
|
|
||||||
});
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'delta',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
content,
|
|
||||||
});
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
metadata,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
// v1.11.6: doom-loop wrap-up. Mirrors runCapHitSummary structurally — same
|
|
||||||
// in-flight-slot reuse, same tools-disabled streaming-summary call, same
|
|
||||||
// post-finalize sentinel insert + chat_status drop. Differences:
|
|
||||||
// - synthetic note text comes from DOOM_LOOP_NOTE (names the looping tool)
|
|
||||||
// - sentinel metadata is { kind: 'doom_loop', tool_name, args, threshold }
|
|
||||||
// and has no Continue affordance (manual retry would just re-loop)
|
|
||||||
// - chat_status error path uses reason: 'doom_loop_summary_failed'
|
|
||||||
// Kept as a clone rather than refactored into a shared helper because the
|
|
||||||
// two summary paths still differ in error reason + sentinel shape; a third
|
|
||||||
// sentinel would justify factoring out runWrapUpSummary(opts).
|
|
||||||
export async function runDoomLoopSummary(
|
|
||||||
ctx: InferenceContext,
|
|
||||||
args: TurnArgs,
|
|
||||||
session: Session,
|
|
||||||
project: Project,
|
|
||||||
history: Message[],
|
|
||||||
agent: Agent | null,
|
|
||||||
loop: { name: string; args: Record<string, unknown> },
|
|
||||||
): Promise<void> {
|
|
||||||
const { sessionId, chatId, assistantMessageId, signal } = args;
|
|
||||||
|
|
||||||
const messages = await buildMessagesPayload(session, project, history, agent, ctx.log);
|
|
||||||
messages.push({ role: 'system', content: DOOM_LOOP_NOTE(loop.name) });
|
|
||||||
|
|
||||||
const startedRow = await ctx.sql<{ started_at: string }[]>`
|
|
||||||
UPDATE messages
|
|
||||||
SET started_at = clock_timestamp()
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
RETURNING started_at
|
|
||||||
`;
|
|
||||||
const startedAt = startedRow[0]?.started_at ?? null;
|
|
||||||
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_started',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
role: 'assistant',
|
|
||||||
});
|
|
||||||
|
|
||||||
let accumulated = '';
|
|
||||||
let pendingFlushTimer: NodeJS.Timeout | null = null;
|
|
||||||
let flushPromise: Promise<unknown> = Promise.resolve();
|
|
||||||
const flushNow = () => {
|
|
||||||
if (pendingFlushTimer) {
|
|
||||||
clearTimeout(pendingFlushTimer);
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
}
|
|
||||||
const snapshot = accumulated;
|
|
||||||
flushPromise = flushPromise.then(() =>
|
|
||||||
ctx.sql`UPDATE messages SET content = ${snapshot} WHERE id = ${assistantMessageId}`
|
|
||||||
);
|
|
||||||
};
|
|
||||||
const scheduleFlush = () => {
|
|
||||||
if (pendingFlushTimer) return;
|
|
||||||
pendingFlushTimer = setTimeout(() => {
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
flushNow();
|
|
||||||
}, DB_FLUSH_INTERVAL_MS);
|
|
||||||
};
|
|
||||||
|
|
||||||
let summaryOk = false;
|
|
||||||
let summarySoftCancelled = false;
|
|
||||||
let summaryError: string | null = null;
|
|
||||||
let result: StreamResult | null = null;
|
|
||||||
try {
|
|
||||||
result = await streamCompletion(
|
|
||||||
ctx,
|
|
||||||
session.model,
|
|
||||||
messages,
|
|
||||||
{ tools: null, temperature: agent?.temperature, top_p: agent?.top_p ?? undefined, top_k: agent?.top_k ?? undefined, min_p: agent?.min_p ?? undefined, presence_penalty: agent?.presence_penalty ?? undefined, top_n_sigma: agent?.top_n_sigma ?? undefined, dry_multiplier: agent?.dry_multiplier ?? undefined, dry_base: agent?.dry_base ?? undefined, dry_allowed_length: agent?.dry_allowed_length ?? undefined, dry_penalty_last_n: agent?.dry_penalty_last_n ?? undefined },
|
|
||||||
(delta) => {
|
|
||||||
accumulated += delta;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'delta',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
content: delta,
|
|
||||||
});
|
|
||||||
scheduleFlush();
|
|
||||||
},
|
|
||||||
undefined,
|
|
||||||
signal,
|
|
||||||
);
|
|
||||||
summaryOk = true;
|
|
||||||
} catch (err) {
|
|
||||||
if (err instanceof Error && err.name === 'AbortError') {
|
|
||||||
summarySoftCancelled = true;
|
|
||||||
} else {
|
|
||||||
summaryError = err instanceof Error ? err.message : String(err);
|
|
||||||
}
|
|
||||||
} finally {
|
|
||||||
if (pendingFlushTimer) {
|
|
||||||
clearTimeout(pendingFlushTimer);
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
}
|
|
||||||
await flushPromise;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (summaryOk && result) {
|
|
||||||
const mctx = await modelContext.getModelContext(session.model);
|
|
||||||
const nCtx = mctx?.n_ctx ?? null;
|
|
||||||
const [updated] = await ctx.sql<
|
|
||||||
{ tokens_used: number | null; ctx_used: number | null; ctx_max: number | null; finished_at: string | null }[]
|
|
||||||
>`
|
|
||||||
UPDATE messages
|
|
||||||
SET content = ${result.content},
|
|
||||||
status = 'complete',
|
|
||||||
tokens_used = ${result.completionTokens},
|
|
||||||
ctx_used = ${result.promptTokens},
|
|
||||||
ctx_max = ${nCtx},
|
|
||||||
finished_at = clock_timestamp()
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
RETURNING tokens_used, ctx_used, ctx_max, finished_at
|
|
||||||
`;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
tokens_used: updated?.tokens_used ?? null,
|
|
||||||
ctx_used: updated?.ctx_used ?? null,
|
|
||||||
ctx_max: updated?.ctx_max ?? null,
|
|
||||||
started_at: startedAt,
|
|
||||||
finished_at: updated?.finished_at ?? null,
|
|
||||||
model: session.model,
|
|
||||||
});
|
|
||||||
} else if (summarySoftCancelled) {
|
|
||||||
await ctx.sql`
|
|
||||||
UPDATE messages
|
|
||||||
SET content = ${accumulated},
|
|
||||||
status = 'cancelled',
|
|
||||||
finished_at = clock_timestamp()
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
`;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
});
|
|
||||||
} else {
|
|
||||||
// Doom-loop summary failure reuses the existing summary_after_cap_failed
|
|
||||||
// error reason — the ErrorReason union is shared between sentinel paths
|
|
||||||
// and the UI surfaces a generic "summary failed" line for both. We don't
|
|
||||||
// add a new reason code because the user-visible failure mode is the
|
|
||||||
// same (model gave up mid-summary). Sentinel below still fires.
|
|
||||||
const errMeta: MessageMetadata = {
|
|
||||||
kind: 'error',
|
|
||||||
error_reason: 'summary_after_cap_failed',
|
|
||||||
error_text: summaryError ?? 'doom-loop summary failed',
|
|
||||||
};
|
|
||||||
await ctx.sql`
|
|
||||||
UPDATE messages
|
|
||||||
SET content = ${accumulated},
|
|
||||||
status = 'failed',
|
|
||||||
finished_at = clock_timestamp(),
|
|
||||||
metadata = ${ctx.sql.json(errMeta as never)}
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
`;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'error',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
error: summaryError ?? 'doom-loop summary failed',
|
|
||||||
reason: 'summary_after_cap_failed',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const [sessRow] = await ctx.sql<{ project_id: string; name: string; updated_at: string }[]>`
|
|
||||||
UPDATE sessions SET updated_at = clock_timestamp()
|
|
||||||
WHERE id = ${sessionId}
|
|
||||||
RETURNING project_id, name, updated_at
|
|
||||||
`;
|
|
||||||
ctx.publishUser({
|
|
||||||
type: 'session_updated',
|
|
||||||
session_id: sessionId,
|
|
||||||
project_id: sessRow!.project_id,
|
|
||||||
name: sessRow!.name,
|
|
||||||
updated_at: sessRow!.updated_at,
|
|
||||||
});
|
|
||||||
|
|
||||||
await insertDoomLoopSentinel(ctx, sessionId, chatId, loop);
|
|
||||||
|
|
||||||
if (summaryOk || summarySoftCancelled) {
|
|
||||||
ctx.publishUser({ type: 'chat_status', chat_id: chatId, status: 'idle', at: new Date().toISOString() });
|
|
||||||
} else {
|
|
||||||
ctx.publishUser({
|
|
||||||
type: 'chat_status',
|
|
||||||
chat_id: chatId,
|
|
||||||
status: 'error',
|
|
||||||
at: new Date().toISOString(),
|
|
||||||
reason: 'summary_after_cap_failed',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
ctx.log.info(
|
|
||||||
{ sessionId, chatId, assistantMessageId, loopedTool: loop.name, summaryOk, summaryCancelled: summarySoftCancelled },
|
|
||||||
'inference doom-loop summary finished',
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// v1.14.0: step-cap wrap-up. Mirrors runCapHitSummary structurally — same
|
|
||||||
// in-flight-slot reuse, same tools-disabled streaming-summary call, same
|
|
||||||
// post-finalize sentinel insert + chat_status drop. Difference: the note
|
|
||||||
// text names the step limit rather than the tool budget. Sentinel reuses
|
|
||||||
// metadata.kind = 'cap_hit' so the frontend CapHitSentinel component
|
|
||||||
// renders it without changes.
|
|
||||||
const STEP_CAP_NOTE = (steps: number, cap: number) =>
|
|
||||||
`You've reached the step limit (${steps}/${cap} steps). Produce the best answer you can with what you have. Do not call more tools.`;
|
|
||||||
|
|
||||||
export async function runStepCapSummary(
|
|
||||||
ctx: InferenceContext,
|
|
||||||
args: TurnArgs,
|
|
||||||
session: Session,
|
|
||||||
project: Project,
|
|
||||||
history: Message[],
|
|
||||||
agent: Agent | null,
|
|
||||||
steps: number,
|
|
||||||
cap: number,
|
|
||||||
): Promise<void> {
|
|
||||||
const { sessionId, chatId, assistantMessageId, signal } = args;
|
|
||||||
|
|
||||||
const messages = await buildMessagesPayload(session, project, history, agent, ctx.log);
|
|
||||||
messages.push({ role: 'system', content: STEP_CAP_NOTE(steps, cap) });
|
|
||||||
|
|
||||||
const startedRow = await ctx.sql<{ started_at: string }[]>`
|
|
||||||
UPDATE messages
|
|
||||||
SET started_at = clock_timestamp()
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
RETURNING started_at
|
|
||||||
`;
|
|
||||||
const startedAt = startedRow[0]?.started_at ?? null;
|
|
||||||
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_started',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
role: 'assistant',
|
|
||||||
});
|
|
||||||
|
|
||||||
let accumulated = '';
|
|
||||||
let pendingFlushTimer: NodeJS.Timeout | null = null;
|
|
||||||
let flushPromise: Promise<unknown> = Promise.resolve();
|
|
||||||
const flushNow = () => {
|
|
||||||
if (pendingFlushTimer) {
|
|
||||||
clearTimeout(pendingFlushTimer);
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
}
|
|
||||||
const snapshot = accumulated;
|
|
||||||
flushPromise = flushPromise.then(() =>
|
|
||||||
ctx.sql`UPDATE messages SET content = ${snapshot} WHERE id = ${assistantMessageId}`
|
|
||||||
);
|
|
||||||
};
|
|
||||||
const scheduleFlush = () => {
|
|
||||||
if (pendingFlushTimer) return;
|
|
||||||
pendingFlushTimer = setTimeout(() => {
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
flushNow();
|
|
||||||
}, DB_FLUSH_INTERVAL_MS);
|
|
||||||
};
|
|
||||||
|
|
||||||
let summaryOk = false;
|
|
||||||
let summarySoftCancelled = false;
|
|
||||||
let summaryError: string | null = null;
|
|
||||||
let result: StreamResult | null = null;
|
|
||||||
try {
|
|
||||||
result = await streamCompletion(
|
|
||||||
ctx,
|
|
||||||
session.model,
|
|
||||||
messages,
|
|
||||||
{ tools: null, temperature: agent?.temperature, top_p: agent?.top_p ?? undefined, top_k: agent?.top_k ?? undefined, min_p: agent?.min_p ?? undefined, presence_penalty: agent?.presence_penalty ?? undefined, top_n_sigma: agent?.top_n_sigma ?? undefined, dry_multiplier: agent?.dry_multiplier ?? undefined, dry_base: agent?.dry_base ?? undefined, dry_allowed_length: agent?.dry_allowed_length ?? undefined, dry_penalty_last_n: agent?.dry_penalty_last_n ?? undefined },
|
|
||||||
(delta) => {
|
|
||||||
accumulated += delta;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'delta',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
content: delta,
|
|
||||||
});
|
|
||||||
scheduleFlush();
|
|
||||||
},
|
|
||||||
undefined,
|
|
||||||
signal,
|
|
||||||
);
|
|
||||||
summaryOk = true;
|
|
||||||
} catch (err) {
|
|
||||||
if (err instanceof Error && err.name === 'AbortError') {
|
|
||||||
summarySoftCancelled = true;
|
|
||||||
} else {
|
|
||||||
summaryError = err instanceof Error ? err.message : String(err);
|
|
||||||
}
|
|
||||||
} finally {
|
|
||||||
if (pendingFlushTimer) {
|
|
||||||
clearTimeout(pendingFlushTimer);
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
}
|
|
||||||
await flushPromise;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (summaryOk && result) {
|
|
||||||
const mctx = await modelContext.getModelContext(session.model);
|
|
||||||
const nCtx = mctx?.n_ctx ?? null;
|
|
||||||
const [updated] = await ctx.sql<
|
|
||||||
{ tokens_used: number | null; ctx_used: number | null; ctx_max: number | null; finished_at: string | null }[]
|
|
||||||
>`
|
|
||||||
UPDATE messages
|
|
||||||
SET content = ${result.content},
|
|
||||||
status = 'complete',
|
|
||||||
tokens_used = ${result.completionTokens},
|
|
||||||
ctx_used = ${result.promptTokens},
|
|
||||||
ctx_max = ${nCtx},
|
|
||||||
finished_at = clock_timestamp()
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
RETURNING tokens_used, ctx_used, ctx_max, finished_at
|
|
||||||
`;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
tokens_used: updated?.tokens_used ?? null,
|
|
||||||
ctx_used: updated?.ctx_used ?? null,
|
|
||||||
ctx_max: updated?.ctx_max ?? null,
|
|
||||||
started_at: startedAt,
|
|
||||||
finished_at: updated?.finished_at ?? null,
|
|
||||||
model: session.model,
|
|
||||||
});
|
|
||||||
} else if (summarySoftCancelled) {
|
|
||||||
await ctx.sql`
|
|
||||||
UPDATE messages
|
|
||||||
SET content = ${accumulated},
|
|
||||||
status = 'cancelled',
|
|
||||||
finished_at = clock_timestamp()
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
`;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
});
|
|
||||||
} else {
|
|
||||||
const errMeta: MessageMetadata = {
|
|
||||||
kind: 'error',
|
|
||||||
error_reason: 'summary_after_cap_failed',
|
|
||||||
error_text: summaryError ?? 'step-cap summary failed',
|
|
||||||
};
|
|
||||||
await ctx.sql`
|
|
||||||
UPDATE messages
|
|
||||||
SET content = ${accumulated},
|
|
||||||
status = 'failed',
|
|
||||||
finished_at = clock_timestamp(),
|
|
||||||
metadata = ${ctx.sql.json(errMeta as never)}
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
`;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'error',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
error: summaryError ?? 'step-cap summary failed',
|
|
||||||
reason: 'summary_after_cap_failed',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const [sessRow] = await ctx.sql<{ project_id: string; name: string; updated_at: string }[]>`
|
|
||||||
UPDATE sessions SET updated_at = clock_timestamp()
|
|
||||||
WHERE id = ${sessionId}
|
|
||||||
RETURNING project_id, name, updated_at
|
|
||||||
`;
|
|
||||||
ctx.publishUser({
|
|
||||||
type: 'session_updated',
|
|
||||||
session_id: sessionId,
|
|
||||||
project_id: sessRow!.project_id,
|
|
||||||
name: sessRow!.name,
|
|
||||||
updated_at: sessRow!.updated_at,
|
|
||||||
});
|
|
||||||
|
|
||||||
// Reuse cap_hit sentinel so the frontend CapHitSentinel component renders
|
|
||||||
// it without changes. The content text distinguishes step cap from budget.
|
|
||||||
await insertCapHitSentinel(ctx, sessionId, chatId, agent, cap);
|
|
||||||
|
|
||||||
if (summaryOk || summarySoftCancelled) {
|
|
||||||
ctx.publishUser({ type: 'chat_status', chat_id: chatId, status: 'idle', at: new Date().toISOString() });
|
|
||||||
} else {
|
|
||||||
ctx.publishUser({
|
|
||||||
type: 'chat_status',
|
|
||||||
chat_id: chatId,
|
|
||||||
status: 'error',
|
|
||||||
at: new Date().toISOString(),
|
|
||||||
reason: 'summary_after_cap_failed',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
ctx.log.info(
|
|
||||||
{ sessionId, chatId, assistantMessageId, steps, cap, summaryOk, summaryCancelled: summarySoftCancelled },
|
|
||||||
'inference step-cap summary finished',
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
async function insertDoomLoopSentinel(
|
async function insertDoomLoopSentinel(
|
||||||
@@ -689,39 +358,12 @@ async function insertDoomLoopSentinel(
|
|||||||
threshold: DOOM_LOOP_THRESHOLD,
|
threshold: DOOM_LOOP_THRESHOLD,
|
||||||
};
|
};
|
||||||
const content = `Detected ${DOOM_LOOP_THRESHOLD} identical calls to ${loop.name}. Stopping the tool-call loop. Produce the best answer you can with what you have.`;
|
const content = `Detected ${DOOM_LOOP_THRESHOLD} identical calls to ${loop.name}. Stopping the tool-call loop. Produce the best answer you can with what you have.`;
|
||||||
|
await insertSentinel(ctx, sessionId, chatId, metadata, content);
|
||||||
const [row] = await ctx.sql<{ id: string }[]>`
|
|
||||||
INSERT INTO messages (session_id, chat_id, role, content, status, created_at, metadata)
|
|
||||||
VALUES (${sessionId}, ${chatId}, 'system', ${content}, 'complete', clock_timestamp(), ${ctx.sql.json(metadata as never)})
|
|
||||||
RETURNING id
|
|
||||||
`;
|
|
||||||
|
|
||||||
// Standard frame sequence — same as cap-hit sentinel — so
|
|
||||||
// useSessionStream's reducer appends the row via the existing path.
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_started',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
role: 'system',
|
|
||||||
});
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'delta',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
content,
|
|
||||||
});
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
metadata,
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// #12 MistakeTracker: heterogeneous-failure recovery sentinel. Mirrors
|
// #12 MistakeTracker: heterogeneous-failure recovery sentinel. A role='system',
|
||||||
// insertDoomLoopSentinel structurally — a role='system', status='complete' row
|
// status='complete' row firing the standard sentinel frame sequence. Two
|
||||||
// firing the standard message_started → delta → message_complete frame
|
// variants distinguished by `escalated`:
|
||||||
// sequence. Two variants distinguished by `escalated`:
|
|
||||||
// - escalated:false → a nudge fired; recovery guidance was injected into the
|
// - escalated:false → a nudge fired; recovery guidance was injected into the
|
||||||
// model's next step and the loop continued. can_continue is true (the turn
|
// model's next step and the loop continued. can_continue is true (the turn
|
||||||
// is still live).
|
// is still live).
|
||||||
@@ -744,30 +386,5 @@ export async function insertMistakeRecoverySentinel(
|
|||||||
const content = opts.escalated
|
const content = opts.escalated
|
||||||
? `Repeated different errors persisted after a recovery nudge (${opts.count} in a row). Stopping the tool-call loop.`
|
? `Repeated different errors persisted after a recovery nudge (${opts.count} in a row). Stopping the tool-call loop.`
|
||||||
: `Hit ${opts.count} different errors in a row. Injected recovery guidance and continuing.`;
|
: `Hit ${opts.count} different errors in a row. Injected recovery guidance and continuing.`;
|
||||||
|
await insertSentinel(ctx, sessionId, chatId, metadata, content);
|
||||||
const [row] = await ctx.sql<{ id: string }[]>`
|
|
||||||
INSERT INTO messages (session_id, chat_id, role, content, status, created_at, metadata)
|
|
||||||
VALUES (${sessionId}, ${chatId}, 'system', ${content}, 'complete', clock_timestamp(), ${ctx.sql.json(metadata as never)})
|
|
||||||
RETURNING id
|
|
||||||
`;
|
|
||||||
|
|
||||||
// Standard frame sequence — same as cap-hit / doom-loop sentinels.
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_started',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
role: 'system',
|
|
||||||
});
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'delta',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
content,
|
|
||||||
});
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: row!.id,
|
|
||||||
chat_id: chatId,
|
|
||||||
metadata,
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -27,6 +27,10 @@ export function detectDoomLoop(
|
|||||||
return { name: ref.name, args: ref.args };
|
return { name: ref.name, args: ref.args };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// All sentinel kinds. isAnySentinel and compaction.ts's local predicate both
|
||||||
|
// consume this set — single source so a new kind can't be missed in one.
|
||||||
|
export const SENTINEL_KINDS = new Set(['cap_hit', 'doom_loop', 'mistake_recovery']);
|
||||||
|
|
||||||
export function isCapHitSentinel(m: Message): boolean {
|
export function isCapHitSentinel(m: Message): boolean {
|
||||||
return (
|
return (
|
||||||
m.role === 'system' &&
|
m.role === 'system' &&
|
||||||
@@ -61,5 +65,10 @@ export function isMistakeRecoverySentinel(m: Message): boolean {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export function isAnySentinel(m: Message): boolean {
|
export function isAnySentinel(m: Message): boolean {
|
||||||
return isCapHitSentinel(m) || isDoomLoopSentinel(m) || isMistakeRecoverySentinel(m);
|
return (
|
||||||
|
m.role === 'system' &&
|
||||||
|
m.metadata !== null &&
|
||||||
|
typeof m.metadata === 'object' &&
|
||||||
|
SENTINEL_KINDS.has((m.metadata as { kind?: unknown }).kind as string)
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
47
apps/server/src/services/inference/step-decision.ts
Normal file
47
apps/server/src/services/inference/step-decision.ts
Normal file
@@ -0,0 +1,47 @@
|
|||||||
|
// P5 (SPLIT SKETCH 5): pure step-decision helpers for the runAssistantTurn
|
||||||
|
// loop. These COMPOSE the existing decision predicates (detectDoomLoop,
|
||||||
|
// detectMistakePattern) — they do not reimplement them — so the loop body in
|
||||||
|
// turn.ts becomes a thin driver and the branch logic is unit-testable without
|
||||||
|
// a DB, broker, or stream.
|
||||||
|
|
||||||
|
import type { ToolCall } from '../../types/api.js';
|
||||||
|
import { detectDoomLoop } from './sentinels.js';
|
||||||
|
import { detectMistakePattern, type MistakeState } from './mistake-tracker.js';
|
||||||
|
import type { ToolPhaseResult } from './tool-phase.js';
|
||||||
|
|
||||||
|
// Top-of-loop gate, evaluated before the stream phase. Order matters and
|
||||||
|
// matches the original inline checks exactly: doom-loop first (identical-repeat
|
||||||
|
// guard), then the cumulative tool-call budget, otherwise proceed to stream.
|
||||||
|
export type PreStepDecision =
|
||||||
|
| { kind: 'doom'; loop: { name: string; args: Record<string, unknown> } }
|
||||||
|
| { kind: 'budget' }
|
||||||
|
| { kind: 'stream' };
|
||||||
|
|
||||||
|
export function decideStep(input: {
|
||||||
|
recentToolCalls: ToolCall[];
|
||||||
|
toolsUsed: number;
|
||||||
|
budget: number;
|
||||||
|
}): PreStepDecision {
|
||||||
|
const loop = detectDoomLoop(input.recentToolCalls);
|
||||||
|
if (loop) return { kind: 'doom', loop };
|
||||||
|
if (input.toolsUsed >= input.budget) return { kind: 'budget' };
|
||||||
|
return { kind: 'stream' };
|
||||||
|
}
|
||||||
|
|
||||||
|
// Post-tool-phase decision, evaluated after the tool phase returns. 'stop'
|
||||||
|
// covers the tool-phase's own non-'continue' actions ('paused' for user input,
|
||||||
|
// 'synthesis_done'); on 'continue' the mistake-tracker pattern gates the
|
||||||
|
// nudge/escalate/continue choice (detectMistakePattern is only consulted on the
|
||||||
|
// 'continue' path, exactly as the original loop did).
|
||||||
|
export type PostToolDecision = 'continue' | 'nudge' | 'escalate' | 'stop';
|
||||||
|
|
||||||
|
export function decidePostToolAction(
|
||||||
|
action: ToolPhaseResult['action'],
|
||||||
|
mistakeTracker: MistakeState,
|
||||||
|
): PostToolDecision {
|
||||||
|
if (action !== 'continue') return 'stop';
|
||||||
|
const mistake = detectMistakePattern(mistakeTracker);
|
||||||
|
if (mistake === 'nudge') return 'nudge';
|
||||||
|
if (mistake === 'escalate') return 'escalate';
|
||||||
|
return 'continue';
|
||||||
|
}
|
||||||
405
apps/server/src/services/inference/stream-phase-adapter.ts
Normal file
405
apps/server/src/services/inference/stream-phase-adapter.ts
Normal file
@@ -0,0 +1,405 @@
|
|||||||
|
// P5 (SPLIT SKETCH): the generic AI-SDK adapter, split out of stream-phase.ts.
|
||||||
|
// This module is the v1.13.1-A streamText adapter and nothing else — it has NO
|
||||||
|
// SQL, broker, or BooCode persistence dependencies (its only `ctx` access is
|
||||||
|
// config + log), so it can be unit-tested without standing up a DB or broker.
|
||||||
|
// stream-phase.ts (the I/O layer) re-exports the public names below so existing
|
||||||
|
// importers (`./stream-phase.js`) are unchanged.
|
||||||
|
|
||||||
|
import type { FastifyBaseLogger } from 'fastify';
|
||||||
|
import type { Config } from '../../config.js';
|
||||||
|
import type { Agent, ToolCall } from '../../types/api.js';
|
||||||
|
import type { ToolJsonSchema } from '../tools.js';
|
||||||
|
import type { OpenAiMessage } from './payload.js';
|
||||||
|
import { extractToolCallBlocks } from './tool-call-parser.js';
|
||||||
|
import type { StreamResult } from './types.js';
|
||||||
|
import { upstreamModel } from './provider.js';
|
||||||
|
import {
|
||||||
|
jsonSchema,
|
||||||
|
streamText,
|
||||||
|
tool,
|
||||||
|
type JSONValue,
|
||||||
|
type ModelMessage,
|
||||||
|
type ToolCallRepairFunction,
|
||||||
|
} from 'ai';
|
||||||
|
|
||||||
|
// The slice of InferenceContext the adapter actually needs. Narrowing it here
|
||||||
|
// (instead of taking the full InferenceContext) keeps the adapter free of the
|
||||||
|
// SQL/broker/publish surface. InferenceContext structurally satisfies this, so
|
||||||
|
// callers pass their ctx unchanged.
|
||||||
|
export interface StreamAdapterContext {
|
||||||
|
config: Config;
|
||||||
|
log: FastifyBaseLogger;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface StreamOptions {
|
||||||
|
// null = omit tools entirely (compact phase); [] = caller stripped all tools
|
||||||
|
// (rare; we still omit from the request body to avoid OpenAI 400).
|
||||||
|
tools: ToolJsonSchema[] | null;
|
||||||
|
temperature?: number;
|
||||||
|
top_p?: number | null;
|
||||||
|
top_k?: number | null;
|
||||||
|
min_p?: number | null;
|
||||||
|
presence_penalty?: number | null;
|
||||||
|
// v2.6 sampling-streamjson-tokens (#11): llama.cpp sampler extensions. These
|
||||||
|
// are NOT standard AI-SDK streamText options and are NOT serialized by the
|
||||||
|
// openai-compatible provider's standardized-settings path (topK is even
|
||||||
|
// explicitly dropped with an "unsupported feature: topK" warning). They reach
|
||||||
|
// llama-server only via providerOptions.openaiCompatible (see buildSamplerProviderOptions).
|
||||||
|
top_n_sigma?: number | null;
|
||||||
|
dry_multiplier?: number | null;
|
||||||
|
dry_base?: number | null;
|
||||||
|
dry_allowed_length?: number | null;
|
||||||
|
dry_penalty_last_n?: number | null;
|
||||||
|
}
|
||||||
|
|
||||||
|
// P5: the 10-field sampler-options literal that was copy-pasted at 4 sites
|
||||||
|
// (the three sentinel summaries + executeStreamPhase). Builds the StreamOptions
|
||||||
|
// sampler subset from an agent's frontmatter knobs. `temperature` is
|
||||||
|
// `agent?.temperature` (already number|undefined); the nullable fields strip
|
||||||
|
// null → undefined so they're omitted from the request body when unset. Keep
|
||||||
|
// this in lockstep with the StreamOptions sampler fields — a new sampler knob
|
||||||
|
// (the v2.7.3 dry_* family did this) is added here once instead of at 4 sites.
|
||||||
|
export type SamplerOpts = Omit<StreamOptions, 'tools'>;
|
||||||
|
|
||||||
|
export function samplerOptsFromAgent(agent: Agent | null): SamplerOpts {
|
||||||
|
return {
|
||||||
|
temperature: agent?.temperature,
|
||||||
|
top_p: agent?.top_p ?? undefined,
|
||||||
|
top_k: agent?.top_k ?? undefined,
|
||||||
|
min_p: agent?.min_p ?? undefined,
|
||||||
|
presence_penalty: agent?.presence_penalty ?? undefined,
|
||||||
|
top_n_sigma: agent?.top_n_sigma ?? undefined,
|
||||||
|
dry_multiplier: agent?.dry_multiplier ?? undefined,
|
||||||
|
dry_base: agent?.dry_base ?? undefined,
|
||||||
|
dry_allowed_length: agent?.dry_allowed_length ?? undefined,
|
||||||
|
dry_penalty_last_n: agent?.dry_penalty_last_n ?? undefined,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// v2.6 #11: build the providerOptions.openaiCompatible extraBody object for the
|
||||||
|
// llama.cpp sampler extensions. @ai-sdk/openai-compatible (2.0.47) merges every
|
||||||
|
// non-reserved key under providerOptions.openaiCompatible straight into the
|
||||||
|
// chat-completion request body (see its getArgs: the Object.fromEntries spread
|
||||||
|
// filtered against openaiCompatibleLanguageModelChatOptions.shape). This is the
|
||||||
|
// ONLY working passthrough for these params:
|
||||||
|
// - top_k / min_p were latently dropped before this: top_k was passed as the
|
||||||
|
// AI-SDK `topK` setting which the openai-compatible provider rejects as
|
||||||
|
// unsupported; min_p was never passed to streamText at all.
|
||||||
|
// - top_n_sigma + the dry_* family have no AI-SDK equivalent.
|
||||||
|
// Keys use llama-server's snake_case body names so they land verbatim.
|
||||||
|
function buildSamplerProviderOptions(opts: StreamOptions): Record<string, number> | undefined {
|
||||||
|
const body: Record<string, number> = {};
|
||||||
|
if (typeof opts.top_k === 'number') body.top_k = opts.top_k;
|
||||||
|
if (typeof opts.min_p === 'number') body.min_p = opts.min_p;
|
||||||
|
if (typeof opts.top_n_sigma === 'number') body.top_n_sigma = opts.top_n_sigma;
|
||||||
|
if (typeof opts.dry_multiplier === 'number') body.dry_multiplier = opts.dry_multiplier;
|
||||||
|
if (typeof opts.dry_base === 'number') body.dry_base = opts.dry_base;
|
||||||
|
if (typeof opts.dry_allowed_length === 'number') body.dry_allowed_length = opts.dry_allowed_length;
|
||||||
|
if (typeof opts.dry_penalty_last_n === 'number') body.dry_penalty_last_n = opts.dry_penalty_last_n;
|
||||||
|
return Object.keys(body).length > 0 ? body : undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
// v1.13.1-A: convert BooCode's OpenAI-shaped history into AI SDK
|
||||||
|
// ModelMessage[]. Tool result messages need a `toolName` field that the
|
||||||
|
// OpenAI shape doesn't carry; we look it up by scanning earlier assistant
|
||||||
|
// `tool_calls` entries for a matching id.
|
||||||
|
function toModelMessages(messages: OpenAiMessage[]): ModelMessage[] {
|
||||||
|
const toolNameById = new Map<string, string>();
|
||||||
|
for (const m of messages) {
|
||||||
|
if (m.role === 'assistant' && m.tool_calls) {
|
||||||
|
for (const tc of m.tool_calls) {
|
||||||
|
toolNameById.set(tc.id, tc.function.name);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
const out: ModelMessage[] = [];
|
||||||
|
for (const m of messages) {
|
||||||
|
if (m.role === 'system' || m.role === 'user') {
|
||||||
|
out.push({ role: m.role, content: m.content ?? '' });
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
if (m.role === 'assistant') {
|
||||||
|
const hasTools = m.tool_calls && m.tool_calls.length > 0;
|
||||||
|
const hasReasoning = typeof m.reasoning === 'string' && m.reasoning.length > 0;
|
||||||
|
if (!hasTools && !hasReasoning) {
|
||||||
|
// Bare text assistant (string content). null content + no tool_calls
|
||||||
|
// is degenerate but harmless to forward.
|
||||||
|
out.push({ role: 'assistant', content: m.content ?? '' });
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
// v1.13.1-C: AI SDK ReasoningPart precedes text + tool-calls in the
|
||||||
|
// assistant content array. Reasoning models (qwen3.6) consume their
|
||||||
|
// prior reasoning context to resume mid-thought across tool boundaries.
|
||||||
|
const parts: Array<
|
||||||
|
| { type: 'reasoning'; text: string }
|
||||||
|
| { type: 'text'; text: string }
|
||||||
|
| { type: 'tool-call'; toolCallId: string; toolName: string; input: unknown }
|
||||||
|
> = [];
|
||||||
|
if (hasReasoning) {
|
||||||
|
parts.push({ type: 'reasoning', text: m.reasoning! });
|
||||||
|
}
|
||||||
|
if (m.content && m.content.length > 0) {
|
||||||
|
parts.push({ type: 'text', text: m.content });
|
||||||
|
}
|
||||||
|
for (const tc of m.tool_calls ?? []) {
|
||||||
|
let input: unknown = {};
|
||||||
|
try {
|
||||||
|
input = tc.function.arguments.length > 0 ? JSON.parse(tc.function.arguments) : {};
|
||||||
|
} catch {
|
||||||
|
// Malformed args from a prior turn: pass through as a raw blob so
|
||||||
|
// the model sees the same shape it emitted. Wraps the string under
|
||||||
|
// _raw to match the buildMessagesPayload upstream convention.
|
||||||
|
input = { _raw: tc.function.arguments };
|
||||||
|
}
|
||||||
|
parts.push({ type: 'tool-call', toolCallId: tc.id, toolName: tc.function.name, input });
|
||||||
|
}
|
||||||
|
out.push({ role: 'assistant', content: parts });
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
if (m.role === 'tool') {
|
||||||
|
const toolCallId = m.tool_call_id ?? '';
|
||||||
|
const toolName = toolNameById.get(toolCallId) ?? 'unknown';
|
||||||
|
const raw = m.content ?? '';
|
||||||
|
let output: { type: 'text'; value: string } | { type: 'json'; value: JSONValue };
|
||||||
|
try {
|
||||||
|
// JSON.parse returns `any`; cast to JSONValue since the upstream
|
||||||
|
// tool_results column is already JSON-serializable by construction.
|
||||||
|
output = { type: 'json', value: JSON.parse(raw) as JSONValue };
|
||||||
|
} catch {
|
||||||
|
output = { type: 'text', value: raw };
|
||||||
|
}
|
||||||
|
out.push({
|
||||||
|
role: 'tool',
|
||||||
|
content: [{ type: 'tool-result', toolCallId, toolName, output }],
|
||||||
|
});
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return out;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Build the AI SDK tools record from BooCode's JSON-schema tool definitions.
|
||||||
|
// No `execute` field: BooCode runs tools itself in tool-phase.ts; streamText
|
||||||
|
// surfaces the tool-call parts via fullStream and we capture them for the
|
||||||
|
// outer loop to dispatch.
|
||||||
|
function buildAiTools(schemas: ToolJsonSchema[]): Record<string, ReturnType<typeof tool>> {
|
||||||
|
const out: Record<string, ReturnType<typeof tool>> = {};
|
||||||
|
for (const s of schemas) {
|
||||||
|
out[s.function.name] = tool({
|
||||||
|
description: s.function.description,
|
||||||
|
inputSchema: jsonSchema(s.function.parameters),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
return out;
|
||||||
|
}
|
||||||
|
|
||||||
|
// v1.10.5 Qwen-coder XML fallback. Some local models (notably qwen3-coder via
|
||||||
|
// llama-swap) emit tool calls as inline XML inside delta.content rather than
|
||||||
|
// the structured tool_calls field. We extract them out of the streamed text
|
||||||
|
// before flushing it to the client.
|
||||||
|
//
|
||||||
|
// Qwen shape:
|
||||||
|
// <tool_call>
|
||||||
|
// <function=NAME>
|
||||||
|
// <parameter=KEY>VALUE</parameter>
|
||||||
|
// ...
|
||||||
|
// </function>
|
||||||
|
// </tool_call>
|
||||||
|
//
|
||||||
|
// v1.13.16: also recognize Anthropic <invoke> markup that qwen3.6-35b-a3b-mxfp4
|
||||||
|
// drifts to (training-data residue from Claude Code documentation):
|
||||||
|
// <invoke name="NAME">
|
||||||
|
// <parameter name="KEY">VALUE</parameter>
|
||||||
|
// </invoke>
|
||||||
|
// Both formats share the synthetic xml_call_${idx} ID space; the counter
|
||||||
|
// increments across whichever opener appears first. Multiple blocks may
|
||||||
|
// appear back-to-back in either format and they never nest.
|
||||||
|
export async function streamCompletion(
|
||||||
|
ctx: StreamAdapterContext,
|
||||||
|
model: string,
|
||||||
|
messages: OpenAiMessage[],
|
||||||
|
opts: StreamOptions,
|
||||||
|
onDelta: (content: string) => void,
|
||||||
|
onUsage: ((prompt: number | null, completion: number | null) => void) | undefined,
|
||||||
|
signal?: AbortSignal,
|
||||||
|
agent?: Agent | null,
|
||||||
|
): Promise<StreamResult> {
|
||||||
|
const aiMessages = toModelMessages(messages);
|
||||||
|
const hasTools = opts.tools !== null && opts.tools.length > 0;
|
||||||
|
const aiTools = hasTools ? buildAiTools(opts.tools!) : undefined;
|
||||||
|
|
||||||
|
const startedAt = Date.now();
|
||||||
|
// v1.13.1-C: accumulate reasoning text across reasoning-delta parts.
|
||||||
|
// qwen3.6 emits these on a separate channel from text content; we capture
|
||||||
|
// them per stream so finalizeCompletion can dual-write a 'reasoning' part.
|
||||||
|
// Replaces the v1.13.1-A counter-only diagnostic.
|
||||||
|
let reasoningAccumulated = '';
|
||||||
|
|
||||||
|
// v1.13.3: experimental_repairToolCall keeps the stream alive when the
|
||||||
|
// model emits a malformed tool call (bad JSON args, unknown name, etc.).
|
||||||
|
// Without a repair function streamText throws and the WHOLE stream dies;
|
||||||
|
// with one, the SDK invokes us and we route the bad call through normally.
|
||||||
|
// Strategy: pass through unmodified. executeToolPhase's existing error
|
||||||
|
// path (unknown tool name → "unknown tool: X" result; zod-reject → tool
|
||||||
|
// 'X' rejected — fieldname: required) already gives the model a clean
|
||||||
|
// recovery surface on the next turn. Logging gives us visibility into
|
||||||
|
// how often qwen3.6 actually emits broken calls.
|
||||||
|
const repairToolCall: ToolCallRepairFunction<NonNullable<typeof aiTools>> = async ({
|
||||||
|
toolCall,
|
||||||
|
error,
|
||||||
|
}) => {
|
||||||
|
ctx.log.warn(
|
||||||
|
{
|
||||||
|
toolCallId: toolCall.toolCallId,
|
||||||
|
toolName: toolCall.toolName,
|
||||||
|
error: error.message,
|
||||||
|
},
|
||||||
|
'malformed tool call surfaced via repairToolCall',
|
||||||
|
);
|
||||||
|
return toolCall;
|
||||||
|
};
|
||||||
|
|
||||||
|
// v2.6 #11: llama.cpp sampler extensions (top_k, min_p, top_n_sigma, dry_*)
|
||||||
|
// ride providerOptions.openaiCompatible — they are NOT standardized streamText
|
||||||
|
// settings. NB: top_k used to be passed below as the AI-SDK `topK` setting;
|
||||||
|
// the openai-compatible provider dropped it with an "unsupported feature: topK"
|
||||||
|
// warning and min_p was never wired at all, so both were dead on the wire
|
||||||
|
// before this. They now go through the same extraBody path as the new params.
|
||||||
|
const samplerBody = buildSamplerProviderOptions(opts);
|
||||||
|
|
||||||
|
const result = streamText({
|
||||||
|
model: upstreamModel(ctx.config, model, agent ?? null),
|
||||||
|
messages: aiMessages,
|
||||||
|
...(aiTools
|
||||||
|
? { tools: aiTools, toolChoice: 'auto' as const, experimental_repairToolCall: repairToolCall }
|
||||||
|
: {}),
|
||||||
|
...(typeof opts.temperature === 'number' ? { temperature: opts.temperature } : {}),
|
||||||
|
...(typeof opts.top_p === 'number' ? { topP: opts.top_p } : {}),
|
||||||
|
...(typeof opts.presence_penalty === 'number' ? { presencePenalty: opts.presence_penalty } : {}),
|
||||||
|
...(samplerBody ? { providerOptions: { openaiCompatible: samplerBody } } : {}),
|
||||||
|
abortSignal: signal,
|
||||||
|
});
|
||||||
|
|
||||||
|
let content = '';
|
||||||
|
let pendingBuffer = '';
|
||||||
|
let finishReason: string | null = null;
|
||||||
|
// v1.13.1-A: AI SDK emits one `tool-call` part per fully-aggregated call,
|
||||||
|
// so we no longer need the OpenAI-index reassembly map the manual SSE
|
||||||
|
// parser used. XML tool calls extracted from text content go into the
|
||||||
|
// same flat list and keep the v1.10.5 synthetic id convention.
|
||||||
|
const toolCalls: ToolCall[] = [];
|
||||||
|
|
||||||
|
for await (const part of result.fullStream) {
|
||||||
|
switch (part.type) {
|
||||||
|
case 'text-delta': {
|
||||||
|
pendingBuffer += part.text;
|
||||||
|
// v1.13.16: unified extraction. The helper finds the earliest-opening
|
||||||
|
// complete <tool_call> or <invoke> block, flushes prose between/around
|
||||||
|
// them, holds any partial opener for the next chunk, and silently
|
||||||
|
// drops blocks that fail to parse (matches pre-v1.13.16 behavior).
|
||||||
|
const extracted = extractToolCallBlocks(pendingBuffer);
|
||||||
|
if (extracted.flushed.length > 0) {
|
||||||
|
content += extracted.flushed;
|
||||||
|
onDelta(extracted.flushed);
|
||||||
|
}
|
||||||
|
for (const call of extracted.calls) {
|
||||||
|
const synthIdx = toolCalls.length;
|
||||||
|
toolCalls.push({
|
||||||
|
id: `xml_call_${synthIdx}`,
|
||||||
|
name: call.name,
|
||||||
|
args: call.args,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
pendingBuffer = extracted.remaining;
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
case 'tool-call': {
|
||||||
|
// AI SDK has already parsed the input into an object. Match the
|
||||||
|
// ToolCall shape BooCode passes around in toolCallsBuffer downstream.
|
||||||
|
toolCalls.push({
|
||||||
|
id: part.toolCallId,
|
||||||
|
name: part.toolName,
|
||||||
|
args: (part.input ?? {}) as Record<string, unknown>,
|
||||||
|
});
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
case 'reasoning-delta': {
|
||||||
|
// v1.13.1-C: accumulate; finalizeCompletion / executeToolPhase
|
||||||
|
// dual-write the resulting text as a kind='reasoning' part.
|
||||||
|
if (typeof part.text === 'string') {
|
||||||
|
reasoningAccumulated += part.text;
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
case 'finish': {
|
||||||
|
if (typeof part.finishReason === 'string') {
|
||||||
|
finishReason = part.finishReason;
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
case 'error': {
|
||||||
|
const err = part.error;
|
||||||
|
throw err instanceof Error ? err : new Error(String(err));
|
||||||
|
}
|
||||||
|
// Intentional no-op: start, start-step, text-start, text-end,
|
||||||
|
// reasoning-start, reasoning-end, source, file, tool-input-start,
|
||||||
|
// tool-input-delta, tool-input-end, tool-result, tool-error,
|
||||||
|
// finish-step, raw. We only care about the aggregated tool-call and
|
||||||
|
// text-delta paths above; the rest are AI SDK lifecycle/streaming
|
||||||
|
// breadcrumbs that don't change BooCode's persistence or WS contract.
|
||||||
|
default:
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// v1.13.1-A: drain any buffered partial XML opener as plain text. The
|
||||||
|
// pre-AI-SDK path did this on stream end too — better to leak `<tool_c`
|
||||||
|
// than vanish the text.
|
||||||
|
if (pendingBuffer.length > 0) {
|
||||||
|
content += pendingBuffer;
|
||||||
|
onDelta(pendingBuffer);
|
||||||
|
pendingBuffer = '';
|
||||||
|
}
|
||||||
|
|
||||||
|
// AI SDK v6 fullStream returns normally on abort; check signal explicitly.
|
||||||
|
// Without this throw the row would land as status='complete' with partial
|
||||||
|
// content instead of going through handleAbortOrError → status='cancelled'.
|
||||||
|
// Smoke D caught this in v1.13.1-A — don't refactor it away.
|
||||||
|
if (signal?.aborted) {
|
||||||
|
const abortErr = new Error('aborted');
|
||||||
|
abortErr.name = 'AbortError';
|
||||||
|
throw abortErr;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Usage lands as a promise on the result; awaiting after fullStream is
|
||||||
|
// drained is safe. AI SDK v6 names: `inputTokens` / `outputTokens`.
|
||||||
|
let promptTokens: number | null = null;
|
||||||
|
let completionTokens: number | null = null;
|
||||||
|
try {
|
||||||
|
const usage = await result.usage;
|
||||||
|
if (typeof usage.inputTokens === 'number') promptTokens = usage.inputTokens;
|
||||||
|
if (typeof usage.outputTokens === 'number') completionTokens = usage.outputTokens;
|
||||||
|
} catch {
|
||||||
|
// Some providers omit usage on partial streams; leave both null.
|
||||||
|
}
|
||||||
|
|
||||||
|
if (onUsage && (promptTokens !== null || completionTokens !== null)) {
|
||||||
|
onUsage(promptTokens, completionTokens);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (reasoningAccumulated.length > 0) {
|
||||||
|
ctx.log.debug(
|
||||||
|
{ reasoningChars: reasoningAccumulated.length, model, elapsed_ms: Date.now() - startedAt },
|
||||||
|
'streamCompletion: captured reasoning',
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
finishReason,
|
||||||
|
content,
|
||||||
|
toolCalls,
|
||||||
|
promptTokens,
|
||||||
|
completionTokens,
|
||||||
|
reasoning: reasoningAccumulated,
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -1,377 +1,34 @@
|
|||||||
import type {
|
// P5 (SPLIT SKETCH): stream-phase.ts is now the BooCode I/O layer for the
|
||||||
Agent,
|
// stream phase — `executeStreamPhase` owns the row UPDATE, message_started
|
||||||
Session,
|
// frame, debounced content flush, throttled usage publish, model-context
|
||||||
ToolCall,
|
// lookup, and tool-whitelist filter. The generic AI-SDK adapter
|
||||||
} from '../../types/api.js';
|
// (streamCompletion / toModelMessages / buildAiTools / sampler helpers) moved
|
||||||
|
// to ./stream-phase-adapter.ts, which has no SQL/broker/publish deps and is
|
||||||
|
// unit-testable on its own. The adapter's public names are re-exported below so
|
||||||
|
// existing importers of './stream-phase.js' (sentinel-summaries, synthesis
|
||||||
|
// pipeline, the helper tests) keep working unchanged.
|
||||||
|
|
||||||
|
import type { Agent, Session } from '../../types/api.js';
|
||||||
import * as modelContext from '../model-context.js';
|
import * as modelContext from '../model-context.js';
|
||||||
import { toolJsonSchemas, type ToolJsonSchema } from '../tools.js';
|
import { toolJsonSchemas, type ToolJsonSchema } from '../tools.js';
|
||||||
import { matchToolGlob } from '../agents.js';
|
import { matchToolGlob } from '../agents.js';
|
||||||
import type { OpenAiMessage } from './payload.js';
|
import type { OpenAiMessage } from './payload.js';
|
||||||
import { extractToolCallBlocks } from './tool-call-parser.js';
|
import { createContentFlusher } from './content-flusher.js';
|
||||||
import { DB_FLUSH_INTERVAL_MS, type StreamPhaseState } from './types.js';
|
|
||||||
import type {
|
import type {
|
||||||
|
StreamPhaseState,
|
||||||
InferenceContext,
|
InferenceContext,
|
||||||
StreamResult,
|
StreamResult,
|
||||||
TurnArgs,
|
TurnArgs,
|
||||||
} from './turn.js';
|
} from './types.js';
|
||||||
import { upstreamModel } from './provider.js';
|
import { streamCompletion, samplerOptsFromAgent } from './stream-phase-adapter.js';
|
||||||
import {
|
|
||||||
jsonSchema,
|
|
||||||
streamText,
|
|
||||||
tool,
|
|
||||||
type JSONValue,
|
|
||||||
type ModelMessage,
|
|
||||||
type ToolCallRepairFunction,
|
|
||||||
} from 'ai';
|
|
||||||
|
|
||||||
interface StreamOptions {
|
export {
|
||||||
// null = omit tools entirely (compact phase); [] = caller stripped all tools
|
streamCompletion,
|
||||||
// (rare; we still omit from the request body to avoid OpenAI 400).
|
samplerOptsFromAgent,
|
||||||
tools: ToolJsonSchema[] | null;
|
type StreamOptions,
|
||||||
temperature?: number;
|
type SamplerOpts,
|
||||||
top_p?: number | null;
|
type StreamAdapterContext,
|
||||||
top_k?: number | null;
|
} from './stream-phase-adapter.js';
|
||||||
min_p?: number | null;
|
|
||||||
presence_penalty?: number | null;
|
|
||||||
// v2.6 sampling-streamjson-tokens (#11): llama.cpp sampler extensions. These
|
|
||||||
// are NOT standard AI-SDK streamText options and are NOT serialized by the
|
|
||||||
// openai-compatible provider's standardized-settings path (topK is even
|
|
||||||
// explicitly dropped with an "unsupported feature: topK" warning). They reach
|
|
||||||
// llama-server only via providerOptions.openaiCompatible (see buildSamplerProviderOptions).
|
|
||||||
top_n_sigma?: number | null;
|
|
||||||
dry_multiplier?: number | null;
|
|
||||||
dry_base?: number | null;
|
|
||||||
dry_allowed_length?: number | null;
|
|
||||||
dry_penalty_last_n?: number | null;
|
|
||||||
}
|
|
||||||
|
|
||||||
// v2.6 #11: build the providerOptions.openaiCompatible extraBody object for the
|
|
||||||
// llama.cpp sampler extensions. @ai-sdk/openai-compatible (2.0.47) merges every
|
|
||||||
// non-reserved key under providerOptions.openaiCompatible straight into the
|
|
||||||
// chat-completion request body (see its getArgs: the Object.fromEntries spread
|
|
||||||
// filtered against openaiCompatibleLanguageModelChatOptions.shape). This is the
|
|
||||||
// ONLY working passthrough for these params:
|
|
||||||
// - top_k / min_p were latently dropped before this: top_k was passed as the
|
|
||||||
// AI-SDK `topK` setting which the openai-compatible provider rejects as
|
|
||||||
// unsupported; min_p was never passed to streamText at all.
|
|
||||||
// - top_n_sigma + the dry_* family have no AI-SDK equivalent.
|
|
||||||
// Keys use llama-server's snake_case body names so they land verbatim.
|
|
||||||
function buildSamplerProviderOptions(opts: StreamOptions): Record<string, number> | undefined {
|
|
||||||
const body: Record<string, number> = {};
|
|
||||||
if (typeof opts.top_k === 'number') body.top_k = opts.top_k;
|
|
||||||
if (typeof opts.min_p === 'number') body.min_p = opts.min_p;
|
|
||||||
if (typeof opts.top_n_sigma === 'number') body.top_n_sigma = opts.top_n_sigma;
|
|
||||||
if (typeof opts.dry_multiplier === 'number') body.dry_multiplier = opts.dry_multiplier;
|
|
||||||
if (typeof opts.dry_base === 'number') body.dry_base = opts.dry_base;
|
|
||||||
if (typeof opts.dry_allowed_length === 'number') body.dry_allowed_length = opts.dry_allowed_length;
|
|
||||||
if (typeof opts.dry_penalty_last_n === 'number') body.dry_penalty_last_n = opts.dry_penalty_last_n;
|
|
||||||
return Object.keys(body).length > 0 ? body : undefined;
|
|
||||||
}
|
|
||||||
|
|
||||||
// v1.13.1-A: convert BooCode's OpenAI-shaped history into AI SDK
|
|
||||||
// ModelMessage[]. Tool result messages need a `toolName` field that the
|
|
||||||
// OpenAI shape doesn't carry; we look it up by scanning earlier assistant
|
|
||||||
// `tool_calls` entries for a matching id.
|
|
||||||
function toModelMessages(messages: OpenAiMessage[]): ModelMessage[] {
|
|
||||||
const toolNameById = new Map<string, string>();
|
|
||||||
for (const m of messages) {
|
|
||||||
if (m.role === 'assistant' && m.tool_calls) {
|
|
||||||
for (const tc of m.tool_calls) {
|
|
||||||
toolNameById.set(tc.id, tc.function.name);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
const out: ModelMessage[] = [];
|
|
||||||
for (const m of messages) {
|
|
||||||
if (m.role === 'system' || m.role === 'user') {
|
|
||||||
out.push({ role: m.role, content: m.content ?? '' });
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
if (m.role === 'assistant') {
|
|
||||||
const hasTools = m.tool_calls && m.tool_calls.length > 0;
|
|
||||||
const hasReasoning = typeof m.reasoning === 'string' && m.reasoning.length > 0;
|
|
||||||
if (!hasTools && !hasReasoning) {
|
|
||||||
// Bare text assistant (string content). null content + no tool_calls
|
|
||||||
// is degenerate but harmless to forward.
|
|
||||||
out.push({ role: 'assistant', content: m.content ?? '' });
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
// v1.13.1-C: AI SDK ReasoningPart precedes text + tool-calls in the
|
|
||||||
// assistant content array. Reasoning models (qwen3.6) consume their
|
|
||||||
// prior reasoning context to resume mid-thought across tool boundaries.
|
|
||||||
const parts: Array<
|
|
||||||
| { type: 'reasoning'; text: string }
|
|
||||||
| { type: 'text'; text: string }
|
|
||||||
| { type: 'tool-call'; toolCallId: string; toolName: string; input: unknown }
|
|
||||||
> = [];
|
|
||||||
if (hasReasoning) {
|
|
||||||
parts.push({ type: 'reasoning', text: m.reasoning! });
|
|
||||||
}
|
|
||||||
if (m.content && m.content.length > 0) {
|
|
||||||
parts.push({ type: 'text', text: m.content });
|
|
||||||
}
|
|
||||||
for (const tc of m.tool_calls ?? []) {
|
|
||||||
let input: unknown = {};
|
|
||||||
try {
|
|
||||||
input = tc.function.arguments.length > 0 ? JSON.parse(tc.function.arguments) : {};
|
|
||||||
} catch {
|
|
||||||
// Malformed args from a prior turn: pass through as a raw blob so
|
|
||||||
// the model sees the same shape it emitted. Wraps the string under
|
|
||||||
// _raw to match the buildMessagesPayload upstream convention.
|
|
||||||
input = { _raw: tc.function.arguments };
|
|
||||||
}
|
|
||||||
parts.push({ type: 'tool-call', toolCallId: tc.id, toolName: tc.function.name, input });
|
|
||||||
}
|
|
||||||
out.push({ role: 'assistant', content: parts });
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
if (m.role === 'tool') {
|
|
||||||
const toolCallId = m.tool_call_id ?? '';
|
|
||||||
const toolName = toolNameById.get(toolCallId) ?? 'unknown';
|
|
||||||
const raw = m.content ?? '';
|
|
||||||
let output: { type: 'text'; value: string } | { type: 'json'; value: JSONValue };
|
|
||||||
try {
|
|
||||||
// JSON.parse returns `any`; cast to JSONValue since the upstream
|
|
||||||
// tool_results column is already JSON-serializable by construction.
|
|
||||||
output = { type: 'json', value: JSON.parse(raw) as JSONValue };
|
|
||||||
} catch {
|
|
||||||
output = { type: 'text', value: raw };
|
|
||||||
}
|
|
||||||
out.push({
|
|
||||||
role: 'tool',
|
|
||||||
content: [{ type: 'tool-result', toolCallId, toolName, output }],
|
|
||||||
});
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return out;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Build the AI SDK tools record from BooCode's JSON-schema tool definitions.
|
|
||||||
// No `execute` field: BooCode runs tools itself in tool-phase.ts; streamText
|
|
||||||
// surfaces the tool-call parts via fullStream and we capture them for the
|
|
||||||
// outer loop to dispatch.
|
|
||||||
function buildAiTools(schemas: ToolJsonSchema[]): Record<string, ReturnType<typeof tool>> {
|
|
||||||
const out: Record<string, ReturnType<typeof tool>> = {};
|
|
||||||
for (const s of schemas) {
|
|
||||||
out[s.function.name] = tool({
|
|
||||||
description: s.function.description,
|
|
||||||
inputSchema: jsonSchema(s.function.parameters),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
return out;
|
|
||||||
}
|
|
||||||
|
|
||||||
// v1.10.5 Qwen-coder XML fallback. Some local models (notably qwen3-coder via
|
|
||||||
// llama-swap) emit tool calls as inline XML inside delta.content rather than
|
|
||||||
// the structured tool_calls field. We extract them out of the streamed text
|
|
||||||
// before flushing it to the client.
|
|
||||||
//
|
|
||||||
// Qwen shape:
|
|
||||||
// <tool_call>
|
|
||||||
// <function=NAME>
|
|
||||||
// <parameter=KEY>VALUE</parameter>
|
|
||||||
// ...
|
|
||||||
// </function>
|
|
||||||
// </tool_call>
|
|
||||||
//
|
|
||||||
// v1.13.16: also recognize Anthropic <invoke> markup that qwen3.6-35b-a3b-mxfp4
|
|
||||||
// drifts to (training-data residue from Claude Code documentation):
|
|
||||||
// <invoke name="NAME">
|
|
||||||
// <parameter name="KEY">VALUE</parameter>
|
|
||||||
// </invoke>
|
|
||||||
// Both formats share the synthetic xml_call_${idx} ID space; the counter
|
|
||||||
// increments across whichever opener appears first. Multiple blocks may
|
|
||||||
// appear back-to-back in either format and they never nest.
|
|
||||||
export async function streamCompletion(
|
|
||||||
ctx: InferenceContext,
|
|
||||||
model: string,
|
|
||||||
messages: OpenAiMessage[],
|
|
||||||
opts: StreamOptions,
|
|
||||||
onDelta: (content: string) => void,
|
|
||||||
onUsage: ((prompt: number | null, completion: number | null) => void) | undefined,
|
|
||||||
signal?: AbortSignal,
|
|
||||||
agent?: Agent | null,
|
|
||||||
): Promise<StreamResult> {
|
|
||||||
const aiMessages = toModelMessages(messages);
|
|
||||||
const hasTools = opts.tools !== null && opts.tools.length > 0;
|
|
||||||
const aiTools = hasTools ? buildAiTools(opts.tools!) : undefined;
|
|
||||||
|
|
||||||
const startedAt = Date.now();
|
|
||||||
// v1.13.1-C: accumulate reasoning text across reasoning-delta parts.
|
|
||||||
// qwen3.6 emits these on a separate channel from text content; we capture
|
|
||||||
// them per stream so finalizeCompletion can dual-write a 'reasoning' part.
|
|
||||||
// Replaces the v1.13.1-A counter-only diagnostic.
|
|
||||||
let reasoningAccumulated = '';
|
|
||||||
|
|
||||||
// v1.13.3: experimental_repairToolCall keeps the stream alive when the
|
|
||||||
// model emits a malformed tool call (bad JSON args, unknown name, etc.).
|
|
||||||
// Without a repair function streamText throws and the WHOLE stream dies;
|
|
||||||
// with one, the SDK invokes us and we route the bad call through normally.
|
|
||||||
// Strategy: pass through unmodified. executeToolPhase's existing error
|
|
||||||
// path (unknown tool name → "unknown tool: X" result; zod-reject → tool
|
|
||||||
// 'X' rejected — fieldname: required) already gives the model a clean
|
|
||||||
// recovery surface on the next turn. Logging gives us visibility into
|
|
||||||
// how often qwen3.6 actually emits broken calls.
|
|
||||||
const repairToolCall: ToolCallRepairFunction<NonNullable<typeof aiTools>> = async ({
|
|
||||||
toolCall,
|
|
||||||
error,
|
|
||||||
}) => {
|
|
||||||
ctx.log.warn(
|
|
||||||
{
|
|
||||||
toolCallId: toolCall.toolCallId,
|
|
||||||
toolName: toolCall.toolName,
|
|
||||||
error: error.message,
|
|
||||||
},
|
|
||||||
'malformed tool call surfaced via repairToolCall',
|
|
||||||
);
|
|
||||||
return toolCall;
|
|
||||||
};
|
|
||||||
|
|
||||||
// v2.6 #11: llama.cpp sampler extensions (top_k, min_p, top_n_sigma, dry_*)
|
|
||||||
// ride providerOptions.openaiCompatible — they are NOT standardized streamText
|
|
||||||
// settings. NB: top_k used to be passed below as the AI-SDK `topK` setting;
|
|
||||||
// the openai-compatible provider dropped it with an "unsupported feature: topK"
|
|
||||||
// warning and min_p was never wired at all, so both were dead on the wire
|
|
||||||
// before this. They now go through the same extraBody path as the new params.
|
|
||||||
const samplerBody = buildSamplerProviderOptions(opts);
|
|
||||||
|
|
||||||
const result = streamText({
|
|
||||||
model: upstreamModel(ctx.config, model, agent ?? null),
|
|
||||||
messages: aiMessages,
|
|
||||||
...(aiTools
|
|
||||||
? { tools: aiTools, toolChoice: 'auto' as const, experimental_repairToolCall: repairToolCall }
|
|
||||||
: {}),
|
|
||||||
...(typeof opts.temperature === 'number' ? { temperature: opts.temperature } : {}),
|
|
||||||
...(typeof opts.top_p === 'number' ? { topP: opts.top_p } : {}),
|
|
||||||
...(typeof opts.presence_penalty === 'number' ? { presencePenalty: opts.presence_penalty } : {}),
|
|
||||||
...(samplerBody ? { providerOptions: { openaiCompatible: samplerBody } } : {}),
|
|
||||||
abortSignal: signal,
|
|
||||||
});
|
|
||||||
|
|
||||||
let content = '';
|
|
||||||
let pendingBuffer = '';
|
|
||||||
let finishReason: string | null = null;
|
|
||||||
// v1.13.1-A: AI SDK emits one `tool-call` part per fully-aggregated call,
|
|
||||||
// so we no longer need the OpenAI-index reassembly map the manual SSE
|
|
||||||
// parser used. XML tool calls extracted from text content go into the
|
|
||||||
// same flat list and keep the v1.10.5 synthetic id convention.
|
|
||||||
const toolCalls: ToolCall[] = [];
|
|
||||||
|
|
||||||
for await (const part of result.fullStream) {
|
|
||||||
switch (part.type) {
|
|
||||||
case 'text-delta': {
|
|
||||||
pendingBuffer += part.text;
|
|
||||||
// v1.13.16: unified extraction. The helper finds the earliest-opening
|
|
||||||
// complete <tool_call> or <invoke> block, flushes prose between/around
|
|
||||||
// them, holds any partial opener for the next chunk, and silently
|
|
||||||
// drops blocks that fail to parse (matches pre-v1.13.16 behavior).
|
|
||||||
const extracted = extractToolCallBlocks(pendingBuffer);
|
|
||||||
if (extracted.flushed.length > 0) {
|
|
||||||
content += extracted.flushed;
|
|
||||||
onDelta(extracted.flushed);
|
|
||||||
}
|
|
||||||
for (const call of extracted.calls) {
|
|
||||||
const synthIdx = toolCalls.length;
|
|
||||||
toolCalls.push({
|
|
||||||
id: `xml_call_${synthIdx}`,
|
|
||||||
name: call.name,
|
|
||||||
args: call.args,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
pendingBuffer = extracted.remaining;
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
case 'tool-call': {
|
|
||||||
// AI SDK has already parsed the input into an object. Match the
|
|
||||||
// ToolCall shape BooCode passes around in toolCallsBuffer downstream.
|
|
||||||
toolCalls.push({
|
|
||||||
id: part.toolCallId,
|
|
||||||
name: part.toolName,
|
|
||||||
args: (part.input ?? {}) as Record<string, unknown>,
|
|
||||||
});
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
case 'reasoning-delta': {
|
|
||||||
// v1.13.1-C: accumulate; finalizeCompletion / executeToolPhase
|
|
||||||
// dual-write the resulting text as a kind='reasoning' part.
|
|
||||||
if (typeof part.text === 'string') {
|
|
||||||
reasoningAccumulated += part.text;
|
|
||||||
}
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
case 'finish': {
|
|
||||||
if (typeof part.finishReason === 'string') {
|
|
||||||
finishReason = part.finishReason;
|
|
||||||
}
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
case 'error': {
|
|
||||||
const err = part.error;
|
|
||||||
throw err instanceof Error ? err : new Error(String(err));
|
|
||||||
}
|
|
||||||
// Intentional no-op: start, start-step, text-start, text-end,
|
|
||||||
// reasoning-start, reasoning-end, source, file, tool-input-start,
|
|
||||||
// tool-input-delta, tool-input-end, tool-result, tool-error,
|
|
||||||
// finish-step, raw. We only care about the aggregated tool-call and
|
|
||||||
// text-delta paths above; the rest are AI SDK lifecycle/streaming
|
|
||||||
// breadcrumbs that don't change BooCode's persistence or WS contract.
|
|
||||||
default:
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// v1.13.1-A: drain any buffered partial XML opener as plain text. The
|
|
||||||
// pre-AI-SDK path did this on stream end too — better to leak `<tool_c`
|
|
||||||
// than vanish the text.
|
|
||||||
if (pendingBuffer.length > 0) {
|
|
||||||
content += pendingBuffer;
|
|
||||||
onDelta(pendingBuffer);
|
|
||||||
pendingBuffer = '';
|
|
||||||
}
|
|
||||||
|
|
||||||
// AI SDK v6 fullStream returns normally on abort; check signal explicitly.
|
|
||||||
// Without this throw the row would land as status='complete' with partial
|
|
||||||
// content instead of going through handleAbortOrError → status='cancelled'.
|
|
||||||
// Smoke D caught this in v1.13.1-A — don't refactor it away.
|
|
||||||
if (signal?.aborted) {
|
|
||||||
const abortErr = new Error('aborted');
|
|
||||||
abortErr.name = 'AbortError';
|
|
||||||
throw abortErr;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Usage lands as a promise on the result; awaiting after fullStream is
|
|
||||||
// drained is safe. AI SDK v6 names: `inputTokens` / `outputTokens`.
|
|
||||||
let promptTokens: number | null = null;
|
|
||||||
let completionTokens: number | null = null;
|
|
||||||
try {
|
|
||||||
const usage = await result.usage;
|
|
||||||
if (typeof usage.inputTokens === 'number') promptTokens = usage.inputTokens;
|
|
||||||
if (typeof usage.outputTokens === 'number') completionTokens = usage.outputTokens;
|
|
||||||
} catch {
|
|
||||||
// Some providers omit usage on partial streams; leave both null.
|
|
||||||
}
|
|
||||||
|
|
||||||
if (onUsage && (promptTokens !== null || completionTokens !== null)) {
|
|
||||||
onUsage(promptTokens, completionTokens);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (reasoningAccumulated.length > 0) {
|
|
||||||
ctx.log.debug(
|
|
||||||
{ reasoningChars: reasoningAccumulated.length, model, elapsed_ms: Date.now() - startedAt },
|
|
||||||
'streamCompletion: captured reasoning',
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
return {
|
|
||||||
finishReason,
|
|
||||||
content,
|
|
||||||
toolCalls,
|
|
||||||
promptTokens,
|
|
||||||
completionTokens,
|
|
||||||
reasoning: reasoningAccumulated,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function executeStreamPhase(
|
export async function executeStreamPhase(
|
||||||
ctx: InferenceContext,
|
ctx: InferenceContext,
|
||||||
@@ -401,27 +58,7 @@ export async function executeStreamPhase(
|
|||||||
role: 'assistant',
|
role: 'assistant',
|
||||||
});
|
});
|
||||||
|
|
||||||
let pendingFlushTimer: NodeJS.Timeout | null = null;
|
const flusher = createContentFlusher(ctx.sql, assistantMessageId, () => state.accumulated);
|
||||||
let flushPromise: Promise<unknown> = Promise.resolve();
|
|
||||||
|
|
||||||
const flushNow = () => {
|
|
||||||
if (pendingFlushTimer) {
|
|
||||||
clearTimeout(pendingFlushTimer);
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
}
|
|
||||||
const snapshot = state.accumulated;
|
|
||||||
flushPromise = flushPromise.then(() =>
|
|
||||||
ctx.sql`UPDATE messages SET content = ${snapshot} WHERE id = ${assistantMessageId}`
|
|
||||||
);
|
|
||||||
};
|
|
||||||
|
|
||||||
const scheduleFlush = () => {
|
|
||||||
if (pendingFlushTimer) return;
|
|
||||||
pendingFlushTimer = setTimeout(() => {
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
flushNow();
|
|
||||||
}, DB_FLUSH_INTERVAL_MS);
|
|
||||||
};
|
|
||||||
|
|
||||||
// Tool whitelist: if an agent is set, filter the global tool list to only the
|
// Tool whitelist: if an agent is set, filter the global tool list to only the
|
||||||
// tool names it allows. v1.15.0-mcp-multi: uses matchToolGlob for glob
|
// tool names it allows. v1.15.0-mcp-multi: uses matchToolGlob for glob
|
||||||
@@ -434,17 +71,6 @@ export async function executeStreamPhase(
|
|||||||
? toolJsonSchemas().filter((t) => matchToolGlob(t.function.name, agent.tools))
|
? toolJsonSchemas().filter((t) => matchToolGlob(t.function.name, agent.tools))
|
||||||
: toolJsonSchemas()
|
: toolJsonSchemas()
|
||||||
).filter((t) => webToolsEnabled || !WEB_TOOL_NAMES.has(t.function.name));
|
).filter((t) => webToolsEnabled || !WEB_TOOL_NAMES.has(t.function.name));
|
||||||
const effectiveTemperature = agent?.temperature;
|
|
||||||
const effectiveTopP = agent?.top_p ?? undefined;
|
|
||||||
const effectiveTopK = agent?.top_k ?? undefined;
|
|
||||||
const effectiveMinP = agent?.min_p ?? undefined;
|
|
||||||
const effectivePresencePenalty = agent?.presence_penalty ?? undefined;
|
|
||||||
// v2.6 #11: llama.cpp sampler extensions, threaded the same way as top_k/min_p.
|
|
||||||
const effectiveTopNSigma = agent?.top_n_sigma ?? undefined;
|
|
||||||
const effectiveDryMultiplier = agent?.dry_multiplier ?? undefined;
|
|
||||||
const effectiveDryBase = agent?.dry_base ?? undefined;
|
|
||||||
const effectiveDryAllowedLength = agent?.dry_allowed_length ?? undefined;
|
|
||||||
const effectiveDryPenaltyLastN = agent?.dry_penalty_last_n ?? undefined;
|
|
||||||
|
|
||||||
// v1.12.2: ctx_max lookup is cached after the first hit per model, so this
|
// v1.12.2: ctx_max lookup is cached after the first hit per model, so this
|
||||||
// is a Map probe in steady state. We capture nCtx once at the top of the
|
// is a Map probe in steady state. We capture nCtx once at the top of the
|
||||||
@@ -484,16 +110,7 @@ export async function executeStreamPhase(
|
|||||||
messages,
|
messages,
|
||||||
{
|
{
|
||||||
tools: effectiveTools,
|
tools: effectiveTools,
|
||||||
temperature: effectiveTemperature,
|
...samplerOptsFromAgent(agent),
|
||||||
top_p: effectiveTopP,
|
|
||||||
top_k: effectiveTopK,
|
|
||||||
min_p: effectiveMinP,
|
|
||||||
presence_penalty: effectivePresencePenalty,
|
|
||||||
top_n_sigma: effectiveTopNSigma,
|
|
||||||
dry_multiplier: effectiveDryMultiplier,
|
|
||||||
dry_base: effectiveDryBase,
|
|
||||||
dry_allowed_length: effectiveDryAllowedLength,
|
|
||||||
dry_penalty_last_n: effectiveDryPenaltyLastN,
|
|
||||||
},
|
},
|
||||||
(delta) => {
|
(delta) => {
|
||||||
state.accumulated += delta;
|
state.accumulated += delta;
|
||||||
@@ -504,7 +121,7 @@ export async function executeStreamPhase(
|
|||||||
content: delta,
|
content: delta,
|
||||||
});
|
});
|
||||||
ctx.log.debug({ sessionId, delta }, 'inference delta');
|
ctx.log.debug({ sessionId, delta }, 'inference delta');
|
||||||
scheduleFlush();
|
flusher.scheduleFlush();
|
||||||
},
|
},
|
||||||
(prompt, completion) => {
|
(prompt, completion) => {
|
||||||
pendingUsage = { p: prompt, c: completion };
|
pendingUsage = { p: prompt, c: completion };
|
||||||
@@ -522,14 +139,10 @@ export async function executeStreamPhase(
|
|||||||
agent,
|
agent,
|
||||||
);
|
);
|
||||||
} finally {
|
} finally {
|
||||||
if (pendingFlushTimer) {
|
|
||||||
clearTimeout(pendingFlushTimer);
|
|
||||||
pendingFlushTimer = null;
|
|
||||||
}
|
|
||||||
if (usageTimer) {
|
if (usageTimer) {
|
||||||
clearTimeout(usageTimer);
|
clearTimeout(usageTimer);
|
||||||
usageTimer = null;
|
usageTimer = null;
|
||||||
}
|
}
|
||||||
await flushPromise;
|
await flusher.drain();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -22,7 +22,7 @@ import type {
|
|||||||
InferenceContext,
|
InferenceContext,
|
||||||
StreamResult,
|
StreamResult,
|
||||||
TurnArgs,
|
TurnArgs,
|
||||||
} from './turn.js';
|
} from './types.js';
|
||||||
// v1.13.13: synthesis pipeline — replaces the immediate recursive turn when
|
// v1.13.13: synthesis pipeline — replaces the immediate recursive turn when
|
||||||
// any of this batch's tool calls is in SYNTHESIS_TOOLS. Falls through to
|
// any of this batch's tool calls is in SYNTHESIS_TOOLS. Falls through to
|
||||||
// recursion on synthesis failure (timeout / model error). See module header
|
// recursion on synthesis failure (timeout / model error). See module header
|
||||||
|
|||||||
@@ -1,81 +0,0 @@
|
|||||||
/**
|
|
||||||
* v2.0.5: Tool-use summary generation.
|
|
||||||
*
|
|
||||||
* After a batch of tool calls completes, fire a cheap LLM call to generate
|
|
||||||
* a "git-commit-subject-style" one-liner label describing what the tools
|
|
||||||
* accomplished. Ported from the Qwen Code source recon.
|
|
||||||
*/
|
|
||||||
import type { FastifyBaseLogger } from 'fastify';
|
|
||||||
|
|
||||||
const TOOL_SUMMARY_SYSTEM_PROMPT = `Write a short summary label describing what these tool calls accomplished. Think git-commit-subject, not sentence. Past tense, most distinctive noun. Max 30 characters. Output ONLY the label.
|
|
||||||
|
|
||||||
Examples:
|
|
||||||
- Searched in auth/
|
|
||||||
- Fixed NPE in UserService
|
|
||||||
- Created signup endpoint
|
|
||||||
- Read config.json
|
|
||||||
- Ran failing tests`;
|
|
||||||
|
|
||||||
const INPUT_TRUNCATE = 300;
|
|
||||||
const MAX_SUMMARY_LENGTH = 100;
|
|
||||||
|
|
||||||
export interface ToolInfo {
|
|
||||||
name: string;
|
|
||||||
input: string;
|
|
||||||
output: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function generateToolUseSummary(opts: {
|
|
||||||
tools: ToolInfo[];
|
|
||||||
llamaSwapUrl: string;
|
|
||||||
model: string;
|
|
||||||
log: FastifyBaseLogger;
|
|
||||||
signal?: AbortSignal;
|
|
||||||
}): Promise<string | null> {
|
|
||||||
const { tools, llamaSwapUrl, model, log, signal } = opts;
|
|
||||||
if (tools.length === 0) return null;
|
|
||||||
if (signal?.aborted) return null;
|
|
||||||
|
|
||||||
const toolText = tools
|
|
||||||
.map(t => `Tool: ${t.name}\nInput: ${t.input.slice(0, INPUT_TRUNCATE)}\nOutput: ${t.output.slice(0, INPUT_TRUNCATE)}`)
|
|
||||||
.join('\n\n');
|
|
||||||
|
|
||||||
try {
|
|
||||||
const res = await fetch(`${llamaSwapUrl}/v1/chat/completions`, {
|
|
||||||
method: 'POST',
|
|
||||||
headers: { 'Content-Type': 'application/json' },
|
|
||||||
body: JSON.stringify({
|
|
||||||
model,
|
|
||||||
messages: [
|
|
||||||
{ role: 'system', content: TOOL_SUMMARY_SYSTEM_PROMPT },
|
|
||||||
{ role: 'user', content: toolText },
|
|
||||||
],
|
|
||||||
max_tokens: 30,
|
|
||||||
temperature: 0.2,
|
|
||||||
stream: false,
|
|
||||||
chat_template_kwargs: { enable_thinking: false },
|
|
||||||
}),
|
|
||||||
signal,
|
|
||||||
});
|
|
||||||
if (!res.ok) {
|
|
||||||
log.debug({ status: res.status }, 'tool-summary: LLM request failed');
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
const data = await res.json() as { choices?: Array<{ message?: { content?: string } }> };
|
|
||||||
const raw = data.choices?.[0]?.message?.content?.trim() ?? '';
|
|
||||||
if (!raw) return null;
|
|
||||||
// Clean: strip quotes, "Label:" prefix, cap length
|
|
||||||
let cleaned = raw.split('\n')[0]?.trim() ?? '';
|
|
||||||
cleaned = cleaned
|
|
||||||
.replace(/^[-*•]\s+/, '')
|
|
||||||
.replace(/^["'`‘’“”]|["'`‘’“”]$/g, '')
|
|
||||||
.replace(/^(label|summary)\s*:\s*/i, '')
|
|
||||||
.trim();
|
|
||||||
return cleaned.length > MAX_SUMMARY_LENGTH
|
|
||||||
? cleaned.slice(0, MAX_SUMMARY_LENGTH).trim()
|
|
||||||
: cleaned || null;
|
|
||||||
} catch (err) {
|
|
||||||
log.debug({ err: err instanceof Error ? err.message : String(err) }, 'tool-summary: error');
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
33
apps/server/src/services/inference/turn-config.ts
Normal file
33
apps/server/src/services/inference/turn-config.ts
Normal file
@@ -0,0 +1,33 @@
|
|||||||
|
// P5 (SPLIT SKETCH 5): pure per-turn configuration resolved once at the top of
|
||||||
|
// runAssistantTurn. No I/O — just the cap math + budget lookup so it can be
|
||||||
|
// unit-tested without a DB or broker.
|
||||||
|
|
||||||
|
import type { Agent } from '../../types/api.js';
|
||||||
|
import { resolveToolBudget } from './budget.js';
|
||||||
|
|
||||||
|
// v1.14.0: hard ceiling on the number of stream-and-tool iterations per
|
||||||
|
// user-message turn. Per-agent cap via agent.steps is the primary knob;
|
||||||
|
// MAX_STEPS is the safety ceiling. 200 is 4x the effective budget ceiling
|
||||||
|
// (50 tool calls) — in practice budget fires first unless the model makes
|
||||||
|
// many 0-tool-call iterations (which exit the loop via the non-tool finish
|
||||||
|
// path anyway).
|
||||||
|
export const MAX_STEPS = 200;
|
||||||
|
|
||||||
|
export interface TurnConfig {
|
||||||
|
// min(agent.steps ?? Infinity, MAX_STEPS). The while loop runs while
|
||||||
|
// stepNumber < effectiveCap.
|
||||||
|
effectiveCap: number;
|
||||||
|
// cumulative tool-call budget for the turn (resolveToolBudget).
|
||||||
|
budget: number;
|
||||||
|
// effectiveCap === 0 → the model responds text-only (no tool execution).
|
||||||
|
isTextOnly: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function resolveTurnConfig(agent: Agent | null): TurnConfig {
|
||||||
|
const budget = resolveToolBudget(agent);
|
||||||
|
// v1.14.0: effectiveCap = min(agent.steps ?? Infinity, MAX_STEPS).
|
||||||
|
// steps: 0 means "no tool calls allowed" — the first stream phase runs but
|
||||||
|
// any tool calls it emits are not executed (finalize as text-only).
|
||||||
|
const effectiveCap = Math.min(agent?.steps ?? Infinity, MAX_STEPS);
|
||||||
|
return { effectiveCap, budget, isTextOnly: effectiveCap === 0 };
|
||||||
|
}
|
||||||
@@ -1,33 +1,21 @@
|
|||||||
import type { FastifyBaseLogger } from 'fastify';
|
|
||||||
import type { Sql } from '../../db.js';
|
|
||||||
import type { Config } from '../../config.js';
|
|
||||||
import type {
|
import type {
|
||||||
Agent,
|
Agent,
|
||||||
ErrorReason,
|
|
||||||
Message,
|
Message,
|
||||||
MessageMetadata,
|
|
||||||
Project,
|
Project,
|
||||||
Session,
|
Session,
|
||||||
ToolCall,
|
|
||||||
UserStreamFrame,
|
UserStreamFrame,
|
||||||
} from '../../types/api.js';
|
} from '../../types/api.js';
|
||||||
import { ALL_TOOLS } from '../tools.js';
|
|
||||||
import { resolveProjectRoot } from '../path_guard.js';
|
import { resolveProjectRoot } from '../path_guard.js';
|
||||||
import { maybeAutoNameChat } from '../auto_name.js';
|
import { maybeAutoNameChat } from '../auto_name.js';
|
||||||
import { rewriteSearchQuery } from '../task-search-rewrite.js';
|
import { rewriteSearchQuery } from '../task-search-rewrite.js';
|
||||||
import { getAgentById } from '../agents.js';
|
import { getAgentById } from '../agents.js';
|
||||||
import * as compaction from '../compaction.js';
|
import * as compaction from '../compaction.js';
|
||||||
import type { Broker } from '../broker.js';
|
import { resolveTurnConfig } from './turn-config.js';
|
||||||
import { resolveToolBudget } from './budget.js';
|
import { decideStep, decidePostToolAction } from './step-decision.js';
|
||||||
import {
|
import {
|
||||||
detectDoomLoop,
|
|
||||||
} from './sentinels.js';
|
|
||||||
import {
|
|
||||||
detectMistakePattern,
|
|
||||||
freshMistakeState,
|
freshMistakeState,
|
||||||
recordStep,
|
recordStep,
|
||||||
MISTAKE_RECOVERY_NOTE,
|
MISTAKE_RECOVERY_NOTE,
|
||||||
type MistakeState,
|
|
||||||
} from './mistake-tracker.js';
|
} from './mistake-tracker.js';
|
||||||
import {
|
import {
|
||||||
buildMessagesPayload,
|
buildMessagesPayload,
|
||||||
@@ -35,13 +23,19 @@ import {
|
|||||||
} from './payload.js';
|
} from './payload.js';
|
||||||
import {
|
import {
|
||||||
finalizeCompletion,
|
finalizeCompletion,
|
||||||
|
finalizeEmpty,
|
||||||
handleAbortOrError,
|
handleAbortOrError,
|
||||||
} from './error-handler.js';
|
} from './error-handler.js';
|
||||||
import {
|
import {
|
||||||
executeStreamPhase,
|
executeStreamPhase,
|
||||||
} from './stream-phase.js';
|
} from './stream-phase.js';
|
||||||
import { executeToolPhase, type ToolPhaseResult } from './tool-phase.js';
|
import { executeToolPhase, type ToolPhaseResult } from './tool-phase.js';
|
||||||
import type { StreamPhaseState } from './types.js';
|
import type {
|
||||||
|
InferenceContext,
|
||||||
|
StreamPhaseState,
|
||||||
|
StreamResult,
|
||||||
|
TurnArgs,
|
||||||
|
} from './types.js';
|
||||||
import {
|
import {
|
||||||
runCapHitSummary,
|
runCapHitSummary,
|
||||||
runDoomLoopSummary,
|
runDoomLoopSummary,
|
||||||
@@ -49,121 +43,24 @@ import {
|
|||||||
insertMistakeRecoverySentinel,
|
insertMistakeRecoverySentinel,
|
||||||
} from './sentinel-summaries.js';
|
} from './sentinel-summaries.js';
|
||||||
|
|
||||||
// v1.14.0: hard ceiling on the number of stream-and-tool iterations per
|
// P5: MAX_STEPS moved to ./turn-config.ts (with resolveTurnConfig). Re-exported
|
||||||
// user-message turn. Per-agent cap via agent.steps is the primary knob;
|
// here so the public surface (index.ts → './turn.js') is unchanged.
|
||||||
// MAX_STEPS is the safety ceiling. 200 is 4x the effective budget ceiling
|
export { MAX_STEPS } from './turn-config.js';
|
||||||
// (50 tool calls) — in practice budget fires first unless the model makes
|
|
||||||
// many 0-tool-call iterations (which exit the loop via the non-tool finish
|
|
||||||
// path anyway).
|
|
||||||
export const MAX_STEPS = 200;
|
|
||||||
|
|
||||||
// v1.12.4: re-exported so external callers (tests, future consumers) keep
|
// v1.12.4: re-exported so external callers (tests, future consumers) keep
|
||||||
// importing from services/inference.js as the public surface.
|
// importing from services/inference.js as the public surface.
|
||||||
export { detectDoomLoop, DOOM_LOOP_THRESHOLD } from './sentinels.js';
|
export { detectDoomLoop, DOOM_LOOP_THRESHOLD } from './sentinels.js';
|
||||||
export { buildMessagesPayload } from './payload.js';
|
export { buildMessagesPayload } from './payload.js';
|
||||||
|
|
||||||
export interface InferenceFrame {
|
|
||||||
type:
|
|
||||||
| 'message_started'
|
|
||||||
| 'delta'
|
|
||||||
| 'tool_call'
|
|
||||||
| 'tool_result'
|
|
||||||
| 'message_complete'
|
|
||||||
| 'usage'
|
|
||||||
| 'messages_deleted'
|
|
||||||
| 'session_renamed'
|
|
||||||
| 'chat_renamed'
|
|
||||||
| 'error';
|
|
||||||
message_id?: string;
|
|
||||||
message_ids?: string[];
|
|
||||||
chat_id?: string;
|
|
||||||
tool_message_id?: string;
|
|
||||||
tool_call_id?: string;
|
|
||||||
// v1.8.2: 'system' added so cap-hit sentinel messages can announce themselves
|
|
||||||
// through the normal message_started → delta → message_complete sequence.
|
|
||||||
role?: 'assistant' | 'tool' | 'user' | 'system';
|
|
||||||
content?: string;
|
|
||||||
tool_call?: ToolCall;
|
|
||||||
output?: unknown;
|
|
||||||
truncated?: boolean;
|
|
||||||
error?: string;
|
|
||||||
// v1.8.2: structured error reason. Set on `type: 'error'` so the UI can
|
|
||||||
// surface a specific message; `error` stays the human-readable text.
|
|
||||||
reason?: ErrorReason;
|
|
||||||
// v1.8.2: piggybacks on `message_complete` so static or terminally-resolved
|
|
||||||
// messages can carry their persisted metadata to the live stream without a
|
|
||||||
// refetch (sentinels carry { kind: 'cap_hit', ... }; failed messages carry
|
|
||||||
// { kind: 'error', ... }).
|
|
||||||
metadata?: MessageMetadata | null;
|
|
||||||
tokens_used?: number | null;
|
|
||||||
ctx_used?: number | null;
|
|
||||||
ctx_max?: number | null;
|
|
||||||
completion_tokens?: number | null;
|
|
||||||
started_at?: string | null;
|
|
||||||
finished_at?: string | null;
|
|
||||||
model?: string;
|
|
||||||
session_id?: string;
|
|
||||||
name?: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export type FramePublisher = (sessionId: string, frame: InferenceFrame) => void;
|
|
||||||
|
|
||||||
export interface InferenceContext {
|
|
||||||
sql: Sql;
|
|
||||||
config: Config;
|
|
||||||
log: FastifyBaseLogger;
|
|
||||||
publish: FramePublisher;
|
|
||||||
publishUser: (frame: UserStreamFrame) => void;
|
|
||||||
// v1.11: passed through so compaction.process can publish 'compacted'
|
|
||||||
// frames on the same session WS channel useSessionStream subscribes to.
|
|
||||||
// Compaction is the only path that needs the raw broker handle (regular
|
|
||||||
// inference goes through `publish`); keeping a separate field avoids
|
|
||||||
// tempting other code paths into bypassing the session-id binding.
|
|
||||||
broker: Broker;
|
|
||||||
}
|
|
||||||
|
|
||||||
// v1.12.4: payload assembly extracted to ./inference/payload.ts (tests
|
// v1.12.4: payload assembly extracted to ./inference/payload.ts (tests
|
||||||
// import buildMessagesPayload from this module, so a re-export below
|
// import buildMessagesPayload from this module, so a re-export below
|
||||||
// preserves the public surface). Stream + tool phases extracted to
|
// preserves the public surface). Stream + tool phases extracted to
|
||||||
// ./inference/stream-phase.ts and ./inference/tool-phase.ts.
|
// ./inference/stream-phase.ts and ./inference/tool-phase.ts.
|
||||||
|
//
|
||||||
export interface StreamResult {
|
// P5: the shared pipeline types (InferenceFrame / FramePublisher /
|
||||||
finishReason: string | null;
|
// InferenceContext / StreamResult / TurnArgs) moved to ./types.js to break the
|
||||||
content: string;
|
// turn.ts type-hub-and-leaf near-cycle. They are re-exported from there via
|
||||||
toolCalls: ToolCall[];
|
// inference/index.ts for the public surface.
|
||||||
promptTokens: number | null;
|
|
||||||
completionTokens: number | null;
|
|
||||||
// v1.13.1-C: reasoning text accumulated across reasoning-delta parts.
|
|
||||||
// Empty string when the model doesn't emit reasoning (most cases).
|
|
||||||
reasoning: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
|
|
||||||
export interface TurnArgs {
|
|
||||||
sessionId: string;
|
|
||||||
chatId: string;
|
|
||||||
assistantMessageId: string;
|
|
||||||
// v1.8.2: cumulative tool calls executed this run. Compared against the
|
|
||||||
// resolved budget at the top of each turn. Replaces the older `depth`
|
|
||||||
// counter (which counted iterations, not invocations).
|
|
||||||
toolsUsed: number;
|
|
||||||
// v1.11.6: ordered tool calls executed in this user-message turn (across
|
|
||||||
// recursive runAssistantTurn invocations). Reset to [] at user-message
|
|
||||||
// boundaries by runInference, same as toolsUsed. Doom-loop check at the
|
|
||||||
// top of runAssistantTurn slices the last DOOM_LOOP_THRESHOLD entries.
|
|
||||||
recentToolCalls: ToolCall[];
|
|
||||||
// v#12 MistakeTracker: heterogeneous-failure recovery state. Loop-local,
|
|
||||||
// reset per runInference (user-message boundary) like recentToolCalls. Folds
|
|
||||||
// tool-phase outcomes via recordStep each iteration; detectMistakePattern
|
|
||||||
// gates the nudge/escalate decision.
|
|
||||||
mistakeTracker: MistakeState;
|
|
||||||
// v#12: transient model-facing recovery note set when a nudge fires. Consumed
|
|
||||||
// (appended as a role:'system' message + cleared) on the NEXT payload build.
|
|
||||||
// Never persisted — mirrors how the cap-hit/doom-loop notes live only inside
|
|
||||||
// the summary call's messages array.
|
|
||||||
pendingRecoveryNote?: string;
|
|
||||||
signal: AbortSignal | undefined;
|
|
||||||
}
|
|
||||||
|
|
||||||
|
|
||||||
export async function runAssistantTurn(
|
export async function runAssistantTurn(
|
||||||
@@ -184,17 +81,13 @@ export async function runAssistantTurn(
|
|||||||
const agent = session.agent_id
|
const agent = session.agent_id
|
||||||
? await getAgentById(project.path, session.agent_id)
|
? await getAgentById(project.path, session.agent_id)
|
||||||
: null;
|
: null;
|
||||||
const budget = resolveToolBudget(agent);
|
// P5: pure per-turn config (budget + cap math + text-only flag).
|
||||||
|
const { effectiveCap, budget, isTextOnly } = resolveTurnConfig(agent);
|
||||||
// v1.14.0: effectiveCap = min(agent.steps ?? Infinity, MAX_STEPS).
|
|
||||||
// steps: 0 means "no tool calls allowed" — the first stream phase runs
|
|
||||||
// but if it emits tool calls they are not executed (finalize as text-only).
|
|
||||||
const effectiveCap = Math.min(agent?.steps ?? Infinity, MAX_STEPS);
|
|
||||||
|
|
||||||
// steps: 0 special case — model responds text-only. The while loop would
|
// steps: 0 special case — model responds text-only. The while loop would
|
||||||
// never enter (effectiveCap === 0), so we handle it explicitly before the
|
// never enter (effectiveCap === 0), so we handle it explicitly before the
|
||||||
// loop. The model always gets at least one chance to respond with text.
|
// loop. The model always gets at least one chance to respond with text.
|
||||||
if (effectiveCap === 0) {
|
if (isTextOnly) {
|
||||||
const loaded = await loadContext(ctx.sql, sessionId, chatId);
|
const loaded = await loadContext(ctx.sql, sessionId, chatId);
|
||||||
if (loaded) {
|
if (loaded) {
|
||||||
await runTextOnlyTurn(ctx, args, loaded.session, loaded.project, loaded.history, agent);
|
await runTextOnlyTurn(ctx, args, loaded.session, loaded.project, loaded.history, agent);
|
||||||
@@ -214,20 +107,18 @@ export async function runAssistantTurn(
|
|||||||
let pendingRecoveryNote: string | undefined = args.pendingRecoveryNote;
|
let pendingRecoveryNote: string | undefined = args.pendingRecoveryNote;
|
||||||
|
|
||||||
while (stepNumber < effectiveCap) {
|
while (stepNumber < effectiveCap) {
|
||||||
// ---- doom-loop check (moved from top-of-function) ----
|
// ---- top-of-loop gate: doom-loop, then budget (pure decision) ----
|
||||||
const loop = detectDoomLoop(recentToolCalls);
|
const decision = decideStep({ recentToolCalls, toolsUsed, budget });
|
||||||
if (loop) {
|
if (decision.kind === 'doom') {
|
||||||
// Need fresh history for the summary.
|
// Need fresh history for the summary.
|
||||||
const loaded = await loadContext(ctx.sql, sessionId, chatId);
|
const loaded = await loadContext(ctx.sql, sessionId, chatId);
|
||||||
if (loaded) {
|
if (loaded) {
|
||||||
const iterArgs: TurnArgs = { sessionId, chatId, assistantMessageId, toolsUsed, recentToolCalls, mistakeTracker, signal };
|
const iterArgs: TurnArgs = { sessionId, chatId, assistantMessageId, toolsUsed, recentToolCalls, mistakeTracker, signal };
|
||||||
await runDoomLoopSummary(ctx, iterArgs, loaded.session, loaded.project, loaded.history, agent, loop);
|
await runDoomLoopSummary(ctx, iterArgs, loaded.session, loaded.project, loaded.history, agent, decision.loop);
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
if (decision.kind === 'budget') {
|
||||||
// ---- budget check (moved from top-of-function) ----
|
|
||||||
if (toolsUsed >= budget) {
|
|
||||||
const loaded = await loadContext(ctx.sql, sessionId, chatId);
|
const loaded = await loadContext(ctx.sql, sessionId, chatId);
|
||||||
if (loaded) {
|
if (loaded) {
|
||||||
const iterArgs: TurnArgs = { sessionId, chatId, assistantMessageId, toolsUsed, recentToolCalls, mistakeTracker, signal };
|
const iterArgs: TurnArgs = { sessionId, chatId, assistantMessageId, toolsUsed, recentToolCalls, mistakeTracker, signal };
|
||||||
@@ -235,6 +126,7 @@ export async function runAssistantTurn(
|
|||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
// decision.kind === 'stream' → proceed with compaction + stream + tools.
|
||||||
|
|
||||||
// ---- compaction check ----
|
// ---- compaction check ----
|
||||||
// v1.11: if the prior turn flagged this chat for compaction, run it
|
// v1.11: if the prior turn flagged this chat for compaction, run it
|
||||||
@@ -345,19 +237,17 @@ export async function runAssistantTurn(
|
|||||||
recordStep(mistakeTracker, o);
|
recordStep(mistakeTracker, o);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (toolPhaseResult.action !== 'continue') {
|
// v#12 MistakeTracker: post-tool decision (pure). 'stop' = the tool phase
|
||||||
// 'paused' (user input) or 'synthesis_done' — stop the loop. The turn is
|
// returned a non-'continue' action ('paused' for user input, or
|
||||||
// already ending, so neither a nudge nor an escalate would change the
|
// 'synthesis_done') — neither a nudge nor an escalate would change the
|
||||||
// control flow; we skip the mistake decision here.
|
// control flow, so the mistake check is skipped. On 'continue' the
|
||||||
|
// heterogeneous-failure pattern gates nudge/escalate/continue. Complements
|
||||||
|
// the doom-loop gate above, which only catches *identical* repeats.
|
||||||
|
const post = decidePostToolAction(toolPhaseResult.action, mistakeTracker);
|
||||||
|
if (post === 'stop') {
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
if (post === 'nudge') {
|
||||||
// v#12 MistakeTracker: heterogeneous-failure decision. Only evaluated on
|
|
||||||
// the 'continue' path (the only case where the loop would otherwise
|
|
||||||
// proceed to another step). Complements the doom-loop check above, which
|
|
||||||
// only catches *identical* repeats.
|
|
||||||
const mistake = detectMistakePattern(mistakeTracker);
|
|
||||||
if (mistake === 'nudge') {
|
|
||||||
// Soft intervention: inject model-facing recovery guidance into the NEXT
|
// Soft intervention: inject model-facing recovery guidance into the NEXT
|
||||||
// step's payload, drop a UI sentinel, bump nudges, reset the streak, and
|
// step's payload, drop a UI sentinel, bump nudges, reset the streak, and
|
||||||
// continue. The note is consumed (and cleared) at the top of the next
|
// continue. The note is consumed (and cleared) at the top of the next
|
||||||
@@ -379,23 +269,16 @@ export async function runAssistantTurn(
|
|||||||
assistantMessageId = toolPhaseResult.nextAssistantId!;
|
assistantMessageId = toolPhaseResult.nextAssistantId!;
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
if (mistake === 'escalate') {
|
if (post === 'escalate') {
|
||||||
// The nudge didn't break the failure run — stop the turn (cap-hit-style)
|
// The nudge didn't break the failure run — stop the turn (cap-hit-style)
|
||||||
// to avoid burning the whole step budget on heterogeneous failures. The
|
// to avoid burning the whole step budget on heterogeneous failures. The
|
||||||
// next assistant row is still 'streaming'; finalize it as a short note so
|
// next assistant row is still 'streaming'; finalize it as an empty
|
||||||
// the slot doesn't dangle, then drop the escalate sentinel.
|
// complete row so the slot doesn't dangle, then drop the escalate
|
||||||
|
// sentinel.
|
||||||
const failureKinds = [...mistakeTracker.run];
|
const failureKinds = [...mistakeTracker.run];
|
||||||
assistantMessageId = toolPhaseResult.nextAssistantId!;
|
assistantMessageId = toolPhaseResult.nextAssistantId!;
|
||||||
await ctx.sql`
|
const escalateArgs: TurnArgs = { sessionId, chatId, assistantMessageId, toolsUsed, recentToolCalls, mistakeTracker, signal };
|
||||||
UPDATE messages
|
await finalizeEmpty(ctx, escalateArgs);
|
||||||
SET content = '', status = 'complete', finished_at = clock_timestamp()
|
|
||||||
WHERE id = ${assistantMessageId}
|
|
||||||
`;
|
|
||||||
ctx.publish(sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: assistantMessageId,
|
|
||||||
chat_id: chatId,
|
|
||||||
});
|
|
||||||
await insertMistakeRecoverySentinel(ctx, sessionId, chatId, {
|
await insertMistakeRecoverySentinel(ctx, sessionId, chatId, {
|
||||||
failureKinds,
|
failureKinds,
|
||||||
count: failureKinds.length,
|
count: failureKinds.length,
|
||||||
@@ -562,4 +445,3 @@ export function createInferenceRunner(
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export const _toolNames = ALL_TOOLS.map((t) => t.name);
|
|
||||||
|
|||||||
@@ -1,6 +1,25 @@
|
|||||||
// v1.12.4: shared inter-phase types/constants for the extracted phase files.
|
// v1.12.4: shared inter-phase types/constants for the extracted phase files.
|
||||||
// Lives here so stream-phase, tool-phase, and the summary functions still in
|
// Lives here so stream-phase, tool-phase, and the summary functions still in
|
||||||
// inference.ts can all reference the same definitions without circular imports.
|
// inference.ts can all reference the same definitions without circular imports.
|
||||||
|
//
|
||||||
|
// P5: the shared pipeline types (InferenceContext / TurnArgs / StreamResult /
|
||||||
|
// InferenceFrame / FramePublisher) moved here from turn.ts. turn.ts was both the
|
||||||
|
// type hub (every phase imported these from './turn.js') AND the orchestration
|
||||||
|
// leaf (it imports functions back from payload/stream-phase/tool-phase/
|
||||||
|
// error-handler/sentinel-summaries) — a hub-and-leaf near-cycle. Hosting the
|
||||||
|
// shared types here (this module imports no inference functions) breaks it.
|
||||||
|
|
||||||
|
import type { FastifyBaseLogger } from 'fastify';
|
||||||
|
import type { Sql } from '../../db.js';
|
||||||
|
import type { Config } from '../../config.js';
|
||||||
|
import type {
|
||||||
|
ErrorReason,
|
||||||
|
MessageMetadata,
|
||||||
|
ToolCall,
|
||||||
|
UserStreamFrame,
|
||||||
|
} from '../../types/api.js';
|
||||||
|
import type { Broker } from '../broker.js';
|
||||||
|
import type { MistakeState } from './mistake-tracker.js';
|
||||||
|
|
||||||
export interface StreamPhaseState {
|
export interface StreamPhaseState {
|
||||||
accumulated: string;
|
accumulated: string;
|
||||||
@@ -11,3 +30,100 @@ export interface StreamPhaseState {
|
|||||||
// executeStreamPhase, runCapHitSummary, and runDoomLoopSummary — every site
|
// executeStreamPhase, runCapHitSummary, and runDoomLoopSummary — every site
|
||||||
// that does a debounced content flush during streaming.
|
// that does a debounced content flush during streaming.
|
||||||
export const DB_FLUSH_INTERVAL_MS = 500;
|
export const DB_FLUSH_INTERVAL_MS = 500;
|
||||||
|
|
||||||
|
export interface InferenceFrame {
|
||||||
|
type:
|
||||||
|
| 'message_started'
|
||||||
|
| 'delta'
|
||||||
|
| 'tool_call'
|
||||||
|
| 'tool_result'
|
||||||
|
| 'message_complete'
|
||||||
|
| 'usage'
|
||||||
|
| 'messages_deleted'
|
||||||
|
| 'session_renamed'
|
||||||
|
| 'chat_renamed'
|
||||||
|
| 'error';
|
||||||
|
message_id?: string;
|
||||||
|
message_ids?: string[];
|
||||||
|
chat_id?: string;
|
||||||
|
tool_message_id?: string;
|
||||||
|
tool_call_id?: string;
|
||||||
|
// v1.8.2: 'system' added so cap-hit sentinel messages can announce themselves
|
||||||
|
// through the normal message_started → delta → message_complete sequence.
|
||||||
|
role?: 'assistant' | 'tool' | 'user' | 'system';
|
||||||
|
content?: string;
|
||||||
|
tool_call?: ToolCall;
|
||||||
|
output?: unknown;
|
||||||
|
truncated?: boolean;
|
||||||
|
error?: string;
|
||||||
|
// v1.8.2: structured error reason. Set on `type: 'error'` so the UI can
|
||||||
|
// surface a specific message; `error` stays the human-readable text.
|
||||||
|
reason?: ErrorReason;
|
||||||
|
// v1.8.2: piggybacks on `message_complete` so static or terminally-resolved
|
||||||
|
// messages can carry their persisted metadata to the live stream without a
|
||||||
|
// refetch (sentinels carry { kind: 'cap_hit', ... }; failed messages carry
|
||||||
|
// { kind: 'error', ... }).
|
||||||
|
metadata?: MessageMetadata | null;
|
||||||
|
tokens_used?: number | null;
|
||||||
|
ctx_used?: number | null;
|
||||||
|
ctx_max?: number | null;
|
||||||
|
completion_tokens?: number | null;
|
||||||
|
started_at?: string | null;
|
||||||
|
finished_at?: string | null;
|
||||||
|
model?: string;
|
||||||
|
session_id?: string;
|
||||||
|
name?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export type FramePublisher = (sessionId: string, frame: InferenceFrame) => void;
|
||||||
|
|
||||||
|
export interface InferenceContext {
|
||||||
|
sql: Sql;
|
||||||
|
config: Config;
|
||||||
|
log: FastifyBaseLogger;
|
||||||
|
publish: FramePublisher;
|
||||||
|
publishUser: (frame: UserStreamFrame) => void;
|
||||||
|
// v1.11: passed through so compaction.process can publish 'compacted'
|
||||||
|
// frames on the same session WS channel useSessionStream subscribes to.
|
||||||
|
// Compaction is the only path that needs the raw broker handle (regular
|
||||||
|
// inference goes through `publish`); keeping a separate field avoids
|
||||||
|
// tempting other code paths into bypassing the session-id binding.
|
||||||
|
broker: Broker;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface StreamResult {
|
||||||
|
finishReason: string | null;
|
||||||
|
content: string;
|
||||||
|
toolCalls: ToolCall[];
|
||||||
|
promptTokens: number | null;
|
||||||
|
completionTokens: number | null;
|
||||||
|
// v1.13.1-C: reasoning text accumulated across reasoning-delta parts.
|
||||||
|
// Empty string when the model doesn't emit reasoning (most cases).
|
||||||
|
reasoning: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface TurnArgs {
|
||||||
|
sessionId: string;
|
||||||
|
chatId: string;
|
||||||
|
assistantMessageId: string;
|
||||||
|
// v1.8.2: cumulative tool calls executed this run. Compared against the
|
||||||
|
// resolved budget at the top of each turn. Replaces the older `depth`
|
||||||
|
// counter (which counted iterations, not invocations).
|
||||||
|
toolsUsed: number;
|
||||||
|
// v1.11.6: ordered tool calls executed in this user-message turn (across
|
||||||
|
// recursive runAssistantTurn invocations). Reset to [] at user-message
|
||||||
|
// boundaries by runInference, same as toolsUsed. Doom-loop check at the
|
||||||
|
// top of runAssistantTurn slices the last DOOM_LOOP_THRESHOLD entries.
|
||||||
|
recentToolCalls: ToolCall[];
|
||||||
|
// v#12 MistakeTracker: heterogeneous-failure recovery state. Loop-local,
|
||||||
|
// reset per runInference (user-message boundary) like recentToolCalls. Folds
|
||||||
|
// tool-phase outcomes via recordStep each iteration; detectMistakePattern
|
||||||
|
// gates the nudge/escalate decision.
|
||||||
|
mistakeTracker: MistakeState;
|
||||||
|
// v#12: transient model-facing recovery note set when a nudge fires. Consumed
|
||||||
|
// (appended as a role:'system' message + cleared) on the NEXT payload build.
|
||||||
|
// Never persisted — mirrors how the cap-hit/doom-loop notes live only inside
|
||||||
|
// the summary call's messages array.
|
||||||
|
pendingRecoveryNote?: string;
|
||||||
|
signal: AbortSignal | undefined;
|
||||||
|
}
|
||||||
|
|||||||
@@ -4,6 +4,12 @@
|
|||||||
* Reads a JSON config file (default `/data/mcp.json`) that declares MCP
|
* Reads a JSON config file (default `/data/mcp.json`) that declares MCP
|
||||||
* servers — their transport type, connection parameters, and enabled state.
|
* servers — their transport type, connection parameters, and enabled state.
|
||||||
* Schema shape matches opencode's `mcpServers` key for copy-paste compat.
|
* Schema shape matches opencode's `mcpServers` key for copy-paste compat.
|
||||||
|
*
|
||||||
|
* Secrets stay out of the config file via `{env:VAR}` substitution
|
||||||
|
* (opencode-compatible). Any string value can reference an environment
|
||||||
|
* variable, e.g. a header `"CONTEXT7_API_KEY": "{env:CONTEXT7_API_KEY}"`
|
||||||
|
* resolves from `process.env` at load. This keeps real keys in `.env`
|
||||||
|
* (`env_file` in docker-compose) rather than the gitignored config.
|
||||||
*/
|
*/
|
||||||
import { readFileSync } from 'node:fs';
|
import { readFileSync } from 'node:fs';
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
@@ -38,6 +44,49 @@ export interface McpServerEntry {
|
|||||||
config: McpServerConfig;
|
config: McpServerConfig;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ---- Env-var substitution ----
|
||||||
|
|
||||||
|
const ENV_VAR_PATTERN = /\{env:([A-Za-z_][A-Za-z0-9_]*)\}/g;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Recursively replace `{env:VAR}` references in string values with the
|
||||||
|
* matching environment variable (opencode-compatible). Runs before Zod
|
||||||
|
* validation so a resolved value (e.g. a `{env:...}` URL) still validates.
|
||||||
|
* An unset var resolves to '' and logs a warning so a missing secret is
|
||||||
|
* visible in the boot log rather than silently sending a literal placeholder.
|
||||||
|
* Pass an optional `unsetVars` set to collect the names that resolved to '';
|
||||||
|
* the loader surfaces them on a validation failure (an empty value in a strict
|
||||||
|
* url/command field invalidates the whole config — see loadMcpConfig).
|
||||||
|
*/
|
||||||
|
export function substituteEnvVars(
|
||||||
|
value: unknown,
|
||||||
|
log: FastifyBaseLogger,
|
||||||
|
unsetVars?: Set<string>,
|
||||||
|
): unknown {
|
||||||
|
if (typeof value === 'string') {
|
||||||
|
return value.replace(ENV_VAR_PATTERN, (_match, name: string) => {
|
||||||
|
const resolved = process.env[name];
|
||||||
|
if (resolved === undefined) {
|
||||||
|
unsetVars?.add(name);
|
||||||
|
log.warn(`mcp: env var ${name} referenced in config is unset; substituting empty string`);
|
||||||
|
return '';
|
||||||
|
}
|
||||||
|
return resolved;
|
||||||
|
});
|
||||||
|
}
|
||||||
|
if (Array.isArray(value)) {
|
||||||
|
return value.map((v) => substituteEnvVars(v, log, unsetVars));
|
||||||
|
}
|
||||||
|
if (value && typeof value === 'object') {
|
||||||
|
const out: Record<string, unknown> = {};
|
||||||
|
for (const [k, v] of Object.entries(value as Record<string, unknown>)) {
|
||||||
|
out[k] = substituteEnvVars(v, log, unsetVars);
|
||||||
|
}
|
||||||
|
return out;
|
||||||
|
}
|
||||||
|
return value;
|
||||||
|
}
|
||||||
|
|
||||||
// ---- Loader ----
|
// ---- Loader ----
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -61,9 +110,19 @@ export function loadMcpConfig(configPath: string, log: FastifyBaseLogger): McpSe
|
|||||||
return [];
|
return [];
|
||||||
}
|
}
|
||||||
|
|
||||||
const result = McpConfigSchema.safeParse(json);
|
const unsetVars = new Set<string>();
|
||||||
|
const result = McpConfigSchema.safeParse(substituteEnvVars(json, log, unsetVars));
|
||||||
if (!result.success) {
|
if (!result.success) {
|
||||||
log.warn({ errors: result.error.flatten().fieldErrors }, `mcp: invalid config at ${configPath}`);
|
// Connect the two otherwise-disconnected warnings: an unset {env:VAR} that
|
||||||
|
// resolved to '' can invalidate a strict field (url/command) and drop the
|
||||||
|
// whole config, so name the unset vars alongside the validation errors.
|
||||||
|
const hint = unsetVars.size
|
||||||
|
? ` — ${unsetVars.size} referenced env var(s) unset & substituted with '' (${[...unsetVars].join(', ')}); an unset {env:VAR} in a url/command field invalidates the whole config`
|
||||||
|
: '';
|
||||||
|
log.warn(
|
||||||
|
{ errors: result.error.flatten().fieldErrors, unsetEnvVars: [...unsetVars] },
|
||||||
|
`mcp: invalid config at ${configPath}${hint}`,
|
||||||
|
);
|
||||||
return [];
|
return [];
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
15
apps/server/src/services/message-columns.ts
Normal file
15
apps/server/src/services/message-columns.ts
Normal file
@@ -0,0 +1,15 @@
|
|||||||
|
// Shared column projections for queries against the messages_with_parts view.
|
||||||
|
// All sites that read the full Message wire shape for route responses use
|
||||||
|
// MESSAGE_COLUMNS. The inference load path uses INFERENCE_MESSAGE_COLUMNS —
|
||||||
|
// it adds reasoning_parts but omits the compaction-display fields
|
||||||
|
// (summary, tail_start_id, compacted_at, model) that only the UI needs.
|
||||||
|
|
||||||
|
export const MESSAGE_COLUMNS =
|
||||||
|
'id, session_id, chat_id, role, content, kind, tool_calls, tool_results, status, last_seq, ' +
|
||||||
|
'tokens_used, ctx_used, ctx_max, started_at, finished_at, created_at, metadata, ' +
|
||||||
|
'summary, tail_start_id, compacted_at, model';
|
||||||
|
|
||||||
|
export const INFERENCE_MESSAGE_COLUMNS =
|
||||||
|
'id, session_id, chat_id, role, content, kind, tool_calls, tool_results, status, last_seq, ' +
|
||||||
|
'tokens_used, ctx_used, ctx_max, started_at, finished_at, created_at, metadata, ' +
|
||||||
|
'reasoning_parts';
|
||||||
@@ -18,8 +18,6 @@
|
|||||||
|
|
||||||
export interface ModelContext {
|
export interface ModelContext {
|
||||||
n_ctx: number;
|
n_ctx: number;
|
||||||
total_slots: number;
|
|
||||||
fetched_at: number;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
const NEGATIVE_TTL_MS = 60_000;
|
const NEGATIVE_TTL_MS = 60_000;
|
||||||
@@ -77,19 +75,13 @@ export async function getModelContext(model: string): Promise<ModelContext | nul
|
|||||||
}
|
}
|
||||||
const body = (await res.json()) as {
|
const body = (await res.json()) as {
|
||||||
default_generation_settings?: { n_ctx?: number };
|
default_generation_settings?: { n_ctx?: number };
|
||||||
total_slots?: number;
|
|
||||||
};
|
};
|
||||||
const n_ctx = body?.default_generation_settings?.n_ctx;
|
const n_ctx = body?.default_generation_settings?.n_ctx;
|
||||||
if (typeof n_ctx !== 'number' || n_ctx <= 0) {
|
if (typeof n_ctx !== 'number' || n_ctx <= 0) {
|
||||||
negativeCache.set(model, Date.now());
|
negativeCache.set(model, Date.now());
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
// total_slots is informational; default to 1 if missing rather than
|
const entry: ModelContext = { n_ctx };
|
||||||
// reject the whole response. Most local llama-swap setups run a
|
|
||||||
// single slot anyway.
|
|
||||||
const total_slots =
|
|
||||||
typeof body?.total_slots === 'number' && body.total_slots > 0 ? body.total_slots : 1;
|
|
||||||
const entry: ModelContext = { n_ctx, total_slots, fetched_at: Date.now() };
|
|
||||||
positiveCache.set(model, entry);
|
positiveCache.set(model, entry);
|
||||||
// Clear any stale negative entry so a future query sees the positive
|
// Clear any stale negative entry so a future query sees the positive
|
||||||
// hit cleanly (otherwise the negative TTL never expires from the map).
|
// hit cleanly (otherwise the negative TTL never expires from the map).
|
||||||
|
|||||||
@@ -3,7 +3,7 @@
|
|||||||
// stored in the session's workspace_panes envelope (WorkspaceState.tabNumbers),
|
// stored in the session's workspace_panes envelope (WorkspaceState.tabNumbers),
|
||||||
// keyed by chat id. Lives in its own file (not appended to tools.ts) so tests
|
// keyed by chat id. Lives in its own file (not appended to tools.ts) so tests
|
||||||
// can import the executor directly without dragging in the whole tool registry.
|
// can import the executor directly without dragging in the whole tool registry.
|
||||||
// Registered in tools.ts ALL_TOOLS + READ_ONLY_TOOL_NAMES.
|
// Registered in tools.ts ALL_TOOLS.
|
||||||
|
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { Sql } from '../db.js';
|
import type { Sql } from '../db.js';
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import { promises as fs } from 'node:fs';
|
import { promises as fs } from 'node:fs';
|
||||||
import { join, isAbsolute, basename } from 'node:path';
|
import { join, isAbsolute, basename } from 'node:path';
|
||||||
import { pathGuard, PathScopeError } from './path_guard.js';
|
import { pathGuard, PathScopeError } from './path_guard.js';
|
||||||
|
import { stripQuotes } from '../utils/string-utils.js';
|
||||||
|
|
||||||
// Batch 9.6: read-only skill library. Folders under /data/skills/<group>/<skill>/
|
// Batch 9.6: read-only skill library. Folders under /data/skills/<group>/<skill>/
|
||||||
// contain a SKILL.md with YAML frontmatter (name + description) and a markdown
|
// contain a SKILL.md with YAML frontmatter (name + description) and a markdown
|
||||||
@@ -44,13 +45,6 @@ interface Frontmatter {
|
|||||||
description?: string;
|
description?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
function stripQuotes(s: string): string {
|
|
||||||
if (s.length >= 2 && (s[0] === '"' || s[0] === "'") && s[0] === s[s.length - 1]) {
|
|
||||||
return s.slice(1, -1);
|
|
||||||
}
|
|
||||||
return s;
|
|
||||||
}
|
|
||||||
|
|
||||||
function parseFrontmatter(yaml: string): Frontmatter {
|
function parseFrontmatter(yaml: string): Frontmatter {
|
||||||
const fm: Frontmatter = {};
|
const fm: Frontmatter = {};
|
||||||
for (const raw of yaml.split('\n')) {
|
for (const raw of yaml.split('\n')) {
|
||||||
|
|||||||
@@ -24,12 +24,12 @@ import { TOOLS_BY_NAME } from './tools.js';
|
|||||||
import { streamCompletion } from './inference/stream-phase.js';
|
import { streamCompletion } from './inference/stream-phase.js';
|
||||||
import { SYNTHESIS_SYSTEM_PROMPT } from './synthesisPrompt.js';
|
import { SYNTHESIS_SYSTEM_PROMPT } from './synthesisPrompt.js';
|
||||||
import { insertParts } from './inference/parts.js';
|
import { insertParts } from './inference/parts.js';
|
||||||
import * as modelContext from './model-context.js';
|
import { finalizeStreamedRow } from './inference/error-handler.js';
|
||||||
import { readTruncation } from './truncate.js';
|
import { readTruncation } from './truncate.js';
|
||||||
|
|
||||||
import type { Session } from '../types/api.js';
|
import type { Session } from '../types/api.js';
|
||||||
import type { OpenAiMessage } from './inference/payload.js';
|
import type { OpenAiMessage } from './inference/payload.js';
|
||||||
import type { InferenceContext, TurnArgs } from './inference/turn.js';
|
import type { InferenceContext, TurnArgs } from './inference/types.js';
|
||||||
|
|
||||||
export const SYNTHESIS_TOOLS: ReadonlySet<string> = new Set([
|
export const SYNTHESIS_TOOLS: ReadonlySet<string> = new Set([
|
||||||
'get_codebase_overview',
|
'get_codebase_overview',
|
||||||
@@ -192,44 +192,28 @@ export async function runSynthesisPass(p: SynthesisParams): Promise<boolean> {
|
|||||||
combinedSignal,
|
combinedSignal,
|
||||||
);
|
);
|
||||||
|
|
||||||
const mctx = await modelContext.getModelContext(p.session.model);
|
// P5: the n_ctx lookup + complete UPDATE + message_complete frame are the
|
||||||
const nCtx = mctx?.n_ctx ?? null;
|
// shared success-finalize atom (finalizeStreamedRow). beforeComplete writes
|
||||||
const [updated] = await p.ctx.sql<
|
// the kind='synthesis' part in the original order (UPDATE → insertParts →
|
||||||
{
|
// message_complete), preserving timing exactly.
|
||||||
tokens_used: number | null;
|
await finalizeStreamedRow(p.ctx, {
|
||||||
ctx_used: number | null;
|
sessionId: p.args.sessionId,
|
||||||
ctx_max: number | null;
|
chatId: p.args.chatId,
|
||||||
finished_at: string | null;
|
messageId: synthMessageId,
|
||||||
}[]
|
|
||||||
>`
|
|
||||||
UPDATE messages
|
|
||||||
SET content = ${streamResult.content},
|
|
||||||
status = 'complete',
|
|
||||||
tokens_used = ${streamResult.completionTokens},
|
|
||||||
ctx_used = ${streamResult.promptTokens},
|
|
||||||
ctx_max = ${nCtx},
|
|
||||||
finished_at = clock_timestamp()
|
|
||||||
WHERE id = ${synthMessageId}
|
|
||||||
RETURNING tokens_used, ctx_used, ctx_max, finished_at
|
|
||||||
`;
|
|
||||||
await insertParts(p.ctx.sql, [
|
|
||||||
{
|
|
||||||
message_id: synthMessageId,
|
|
||||||
sequence: 0,
|
|
||||||
kind: 'synthesis',
|
|
||||||
payload: { text: streamResult.content },
|
|
||||||
},
|
|
||||||
]);
|
|
||||||
p.ctx.publish(p.args.sessionId, {
|
|
||||||
type: 'message_complete',
|
|
||||||
message_id: synthMessageId,
|
|
||||||
chat_id: p.args.chatId,
|
|
||||||
tokens_used: updated?.tokens_used ?? null,
|
|
||||||
ctx_used: updated?.ctx_used ?? null,
|
|
||||||
ctx_max: updated?.ctx_max ?? null,
|
|
||||||
started_at: startedAt,
|
|
||||||
finished_at: updated?.finished_at ?? null,
|
|
||||||
model: p.session.model,
|
model: p.session.model,
|
||||||
|
content: streamResult.content,
|
||||||
|
completionTokens: streamResult.completionTokens,
|
||||||
|
promptTokens: streamResult.promptTokens,
|
||||||
|
startedAt,
|
||||||
|
beforeComplete: () =>
|
||||||
|
insertParts(p.ctx.sql, [
|
||||||
|
{
|
||||||
|
message_id: synthMessageId!,
|
||||||
|
sequence: 0,
|
||||||
|
kind: 'synthesis',
|
||||||
|
payload: { text: streamResult.content },
|
||||||
|
},
|
||||||
|
]),
|
||||||
});
|
});
|
||||||
p.ctx.publishUser({
|
p.ctx.publishUser({
|
||||||
type: 'chat_status',
|
type: 'chat_status',
|
||||||
|
|||||||
@@ -1,24 +0,0 @@
|
|||||||
import { taskModelCompletion } from './task-model.js';
|
|
||||||
|
|
||||||
const SYSTEM_PROMPT =
|
|
||||||
'Summarize this conversation in one sentence, 15 words max. No quotes, no prefix.';
|
|
||||||
|
|
||||||
const MAX_INPUT_CHARS = 1000;
|
|
||||||
|
|
||||||
export async function oneLineSummary(
|
|
||||||
messages: Array<{ role: string; content: string }>,
|
|
||||||
): Promise<string> {
|
|
||||||
const lastPairs = messages.slice(-6);
|
|
||||||
let input = lastPairs
|
|
||||||
.map((m) => `${m.role}: ${m.content}`)
|
|
||||||
.join('\n');
|
|
||||||
if (input.length > MAX_INPUT_CHARS) {
|
|
||||||
input = input.slice(0, MAX_INPUT_CHARS);
|
|
||||||
}
|
|
||||||
return taskModelCompletion({
|
|
||||||
system: SYSTEM_PROMPT,
|
|
||||||
user: input,
|
|
||||||
maxTokens: 30,
|
|
||||||
temperature: 0.3,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
@@ -1,22 +0,0 @@
|
|||||||
import { taskModelCompletion } from './task-model.js';
|
|
||||||
|
|
||||||
const SYSTEM_PROMPT =
|
|
||||||
'You tag chat sessions. Reply with 1 to 3 lowercase tags separated by commas. Tags should describe the topic. No explanation. Examples: "docker, deployment", "python, debugging", "react, styling".';
|
|
||||||
|
|
||||||
export async function suggestTags(
|
|
||||||
userMessage: string,
|
|
||||||
assistantReply: string,
|
|
||||||
): Promise<string[]> {
|
|
||||||
const input = `User: ${userMessage.slice(0, 300)}\nAssistant: ${assistantReply.slice(0, 300)}`;
|
|
||||||
const result = await taskModelCompletion({
|
|
||||||
system: SYSTEM_PROMPT,
|
|
||||||
user: input,
|
|
||||||
maxTokens: 30,
|
|
||||||
temperature: 0.3,
|
|
||||||
});
|
|
||||||
if (result.length === 0) return [];
|
|
||||||
return result
|
|
||||||
.split(',')
|
|
||||||
.map((t) => t.trim().toLowerCase())
|
|
||||||
.filter((t) => t.length > 0 && t.length <= 30);
|
|
||||||
}
|
|
||||||
@@ -1,844 +1,46 @@
|
|||||||
import { readFile, readdir, stat } from 'node:fs/promises';
|
// Tool registry barrel. The implementation was split into focused modules
|
||||||
import { resolve, basename, relative } from 'node:path';
|
// under ./tools/ (Sketch 4) while this file stays the stable public surface:
|
||||||
import { z } from 'zod';
|
// every import of './tools.js' and the @boocode/server/tools subpath (consumed
|
||||||
import type { Sql } from '../db.js';
|
// by apps/coder) resolves through here unchanged. The exports-map path
|
||||||
import { pathGuard, PathScopeError } from './path_guard.js';
|
// (dist/services/tools.js) is preserved.
|
||||||
import { isSecretPath, SecretBlockedError, filterSecretEntries } from './secret_guard.js';
|
|
||||||
import { grep as fileOpsGrep, findFiles as fileOpsFindFiles } from './file_ops.js';
|
|
||||||
import { getGitMeta } from './git_meta.js';
|
|
||||||
import { findSkills, getSkillBody, getSkillResource } from './skills.js';
|
|
||||||
import { webSearch } from './web_search.js';
|
|
||||||
import { webFetch } from './web_fetch.js';
|
|
||||||
import { readTruncation, truncateIfNeeded } from './truncate.js';
|
|
||||||
// v1.12 Track B.2: codecontext tools. 8 wrappers re-exported from
|
|
||||||
// tools/codecontext/index.ts. Each calls into services/codecontext_client.ts
|
|
||||||
// which talks to the codecontext sidecar at http://codecontext:8080.
|
|
||||||
import {
|
|
||||||
getCodebaseOverview,
|
|
||||||
getFileAnalysis,
|
|
||||||
getSymbolInfo,
|
|
||||||
searchSymbols,
|
|
||||||
getDependencies,
|
|
||||||
watchChanges,
|
|
||||||
getSemanticNeighborhoods,
|
|
||||||
getFrameworkAnalysis,
|
|
||||||
getBlastRadius,
|
|
||||||
getHotFiles,
|
|
||||||
getRoutes,
|
|
||||||
getMiddleware,
|
|
||||||
} from './tools/codecontext/index.js';
|
|
||||||
// v1.13.17-cross-repo-reads: cross-repo read grant request tool. Paired
|
|
||||||
// with the pause-on-pending-grant branch in inference/tool-phase.ts and the
|
|
||||||
// POST /api/chats/:id/grant_read_access endpoint in routes/messages.ts.
|
|
||||||
import { requestReadAccess } from './request_read_access.js';
|
|
||||||
// v2.6.x: read-only tool that reads a tab's transcript by its session-scoped
|
|
||||||
// tab number. Needs DB/session context (ToolExecCtx 4th arg).
|
|
||||||
import { readTabByNumber } from './read_tab_by_number.js';
|
|
||||||
|
|
||||||
const MAX_FILE_BYTES = 5 * 1024 * 1024;
|
|
||||||
const DEFAULT_VIEW_LINES = 200;
|
|
||||||
const MAX_GREP_RESULTS = 200;
|
|
||||||
const DEFAULT_GREP_RESULTS = 100;
|
|
||||||
const MAX_FIND_RESULTS = 200;
|
|
||||||
const DEFAULT_FIND_RESULTS = 100;
|
|
||||||
const MAX_DIR_ENTRIES = 500;
|
|
||||||
|
|
||||||
export interface ToolJsonSchema {
|
|
||||||
type: 'function';
|
|
||||||
function: {
|
|
||||||
name: string;
|
|
||||||
description: string;
|
|
||||||
parameters: Record<string, unknown>;
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// v2.6.x: optional DB/session context threaded into a tool's execute(). Only
|
|
||||||
// tools that need to read session-scoped DB state (e.g. read_tab_by_number)
|
|
||||||
// use it; every other tool ignores the 4th arg. Kept optional so existing
|
|
||||||
// 3-arg execute() implementations stay assignable (apps/coder consumes this
|
|
||||||
// type from the compiled dist — the optional param keeps it backward-compatible).
|
|
||||||
export interface ToolExecCtx {
|
|
||||||
sql: Sql;
|
|
||||||
sessionId: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
export interface ToolDef<TInput> {
|
|
||||||
name: string;
|
|
||||||
description: string;
|
|
||||||
inputSchema: z.ZodType<TInput>;
|
|
||||||
jsonSchema: ToolJsonSchema;
|
|
||||||
// v1.13.17-cross-repo-reads: extraRoots is the session's
|
|
||||||
// allowed_read_paths, threaded through executeToolCall in tool-phase.ts.
|
|
||||||
// Only the filesystem tools (view_file, list_dir, grep, find_files,
|
|
||||||
// view_truncated_output) forward it to pathGuard; other tools accept the
|
|
||||||
// arg and ignore it. The execute signature stays compatible with
|
|
||||||
// pre-v1.13.17 callsites because the parameter is optional.
|
|
||||||
// v2.6.x: optional 4th param toolCtx carries DB/session context for tools
|
|
||||||
// that read session-scoped state (read_tab_by_number). Optional so 3-arg
|
|
||||||
// implementations remain assignable.
|
|
||||||
execute(
|
|
||||||
input: TInput,
|
|
||||||
projectRoot: string,
|
|
||||||
extraRoots?: readonly string[],
|
|
||||||
toolCtx?: ToolExecCtx,
|
|
||||||
): Promise<unknown>;
|
|
||||||
}
|
|
||||||
|
|
||||||
const ViewFileInput = z.object({
|
|
||||||
path: z.string().min(1),
|
|
||||||
start_line: z.number().int().positive().optional(),
|
|
||||||
end_line: z.number().int().positive().optional(),
|
|
||||||
});
|
|
||||||
type ViewFileInputT = z.infer<typeof ViewFileInput>;
|
|
||||||
|
|
||||||
export const viewFile: ToolDef<ViewFileInputT> = {
|
|
||||||
name: 'view_file',
|
|
||||||
description:
|
|
||||||
"Read a file under the project. Returns first 200 lines by default, or a slice via start_line/end_line (1-indexed, inclusive). Files larger than 5MB are refused. Output is truncated if longer than the slice; the response indicates truncation.",
|
|
||||||
inputSchema: ViewFileInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'view_file',
|
|
||||||
description:
|
|
||||||
"Read a file under the project. Returns first 200 lines by default, or a slice via start_line/end_line (1-indexed, inclusive). Files larger than 5MB are refused.",
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
path: { type: 'string', description: 'absolute or project-relative path' },
|
|
||||||
start_line: { type: 'integer', description: 'first line (1-indexed)' },
|
|
||||||
end_line: { type: 'integer', description: 'last line (1-indexed, inclusive)' },
|
|
||||||
},
|
|
||||||
required: ['path'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
async execute(input, projectRoot, extraRoots) {
|
|
||||||
const real = await pathGuard(projectRoot, input.path, extraRoots);
|
|
||||||
// v1.11.7: secret-file deny check. Test the project-relative path
|
|
||||||
// (matches the form continue.dev's patterns expect: basenames + dir
|
|
||||||
// segments). Throw a typed error so executeToolCall in inference.ts
|
|
||||||
// surfaces a clear "blocked" message to the LLM instead of silently
|
|
||||||
// returning content the user wanted hidden.
|
|
||||||
// v1.13.17: when the resolved path is outside the primary projectRoot
|
|
||||||
// (i.e. via an allowed_read_paths grant), `relative()` returns "../…"
|
|
||||||
// which won't match secret-file basename patterns. Re-anchor on the
|
|
||||||
// file's basename so the secret deny still fires across all grant roots.
|
|
||||||
const rel = relative(projectRoot, real);
|
|
||||||
const relPath = rel && !rel.startsWith('..') ? rel : basename(real);
|
|
||||||
if (isSecretPath(relPath)) {
|
|
||||||
throw new SecretBlockedError(relPath);
|
|
||||||
}
|
|
||||||
const s = await stat(real);
|
|
||||||
if (!s.isFile()) {
|
|
||||||
throw new PathScopeError(`not a file: ${input.path}`);
|
|
||||||
}
|
|
||||||
if (s.size > MAX_FILE_BYTES) {
|
|
||||||
throw new Error(`file too large (${s.size} bytes, max ${MAX_FILE_BYTES})`);
|
|
||||||
}
|
|
||||||
const raw = await readFile(real, 'utf8');
|
|
||||||
const lines = raw.split('\n');
|
|
||||||
const total = lines.length;
|
|
||||||
let start = input.start_line ?? 1;
|
|
||||||
let end = input.end_line ?? Math.min(total, start + DEFAULT_VIEW_LINES - 1);
|
|
||||||
if (input.start_line == null && input.end_line == null) {
|
|
||||||
end = Math.min(total, DEFAULT_VIEW_LINES);
|
|
||||||
}
|
|
||||||
if (start < 1) start = 1;
|
|
||||||
if (end > total) end = total;
|
|
||||||
if (end < start) end = start;
|
|
||||||
const slice = lines.slice(start - 1, end);
|
|
||||||
const content = slice.join('\n');
|
|
||||||
const truncated = total > end || start > 1;
|
|
||||||
// v1.13.5: stash the full file on tmpfs so the model can retrieve more
|
|
||||||
// via view_truncated_output(id) without re-reading the file (which it
|
|
||||||
// may not have project-relative-path access to in future agent setups).
|
|
||||||
// raw is bounded by MAX_FILE_BYTES (5MB), within truncateIfNeeded's cap.
|
|
||||||
const wrapped = await truncateIfNeeded({
|
|
||||||
fullContent: raw,
|
|
||||||
slicedContent: content,
|
|
||||||
wasTruncated: truncated,
|
|
||||||
});
|
|
||||||
return {
|
|
||||||
path: relative(projectRoot, real) || basename(real),
|
|
||||||
content: wrapped.content,
|
|
||||||
total_lines: total,
|
|
||||||
returned_lines: [start, end],
|
|
||||||
truncated: wrapped.truncated,
|
|
||||||
...(wrapped.outputPath ? { outputPath: wrapped.outputPath } : {}),
|
|
||||||
};
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
const ListDirInput = z.object({
|
|
||||||
path: z.string().min(1),
|
|
||||||
show_hidden: z.boolean().optional(),
|
|
||||||
});
|
|
||||||
type ListDirInputT = z.infer<typeof ListDirInput>;
|
|
||||||
|
|
||||||
export const listDir: ToolDef<ListDirInputT> = {
|
|
||||||
name: 'list_dir',
|
|
||||||
description: 'List entries in a directory (up to 500). Hidden files excluded unless show_hidden=true.',
|
|
||||||
inputSchema: ListDirInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'list_dir',
|
|
||||||
description:
|
|
||||||
'List entries in a directory (up to 500). Hidden files (dot-prefixed) excluded unless show_hidden=true.',
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
path: { type: 'string' },
|
|
||||||
show_hidden: { type: 'boolean' },
|
|
||||||
},
|
|
||||||
required: ['path'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
async execute(input, projectRoot, extraRoots) {
|
|
||||||
const real = await pathGuard(projectRoot, input.path, extraRoots);
|
|
||||||
const s = await stat(real);
|
|
||||||
if (!s.isDirectory()) {
|
|
||||||
throw new PathScopeError(`not a directory: ${input.path}`);
|
|
||||||
}
|
|
||||||
const entries = await readdir(real, { withFileTypes: true });
|
|
||||||
const filtered = input.show_hidden
|
|
||||||
? entries
|
|
||||||
: entries.filter((e) => !e.name.startsWith('.'));
|
|
||||||
const total = filtered.length;
|
|
||||||
const wasTruncated = total > MAX_DIR_ENTRIES;
|
|
||||||
const relDir = relative(projectRoot, real) || '.';
|
|
||||||
// v1.13.5: when we'd truncate, render the FULL list to tmpfs so
|
|
||||||
// view_truncated_output can serve it. Stat sizes for all entries when
|
|
||||||
// truncating so the stored view matches the visible shape; this is the
|
|
||||||
// one extra cost for big directories, bounded by total entries (which
|
|
||||||
// is itself bounded by filesystem behavior).
|
|
||||||
const processOne = async (e: typeof filtered[number]) => {
|
|
||||||
const child = resolve(real, e.name);
|
|
||||||
let size: number | undefined;
|
|
||||||
if (e.isFile()) {
|
|
||||||
try {
|
|
||||||
const cs = await stat(child);
|
|
||||||
size = cs.size;
|
|
||||||
} catch { /* ignore */ }
|
|
||||||
}
|
|
||||||
return {
|
|
||||||
name: e.name,
|
|
||||||
type: e.isDirectory() ? ('dir' as const) : ('file' as const),
|
|
||||||
...(size != null ? { size } : {}),
|
|
||||||
};
|
|
||||||
};
|
|
||||||
const slice = filtered.slice(0, MAX_DIR_ENTRIES);
|
|
||||||
const out = await Promise.all(slice.map(processOne));
|
|
||||||
// v1.11.7: filter entries whose project-relative path matches a secret
|
|
||||||
// pattern. The same filter applies to the full-list snapshot below so
|
|
||||||
// the stashed file never holds entries the slice would have hidden.
|
|
||||||
const secretFilter = filterSecretEntries(out, (e) =>
|
|
||||||
relDir === '.' ? e.name : `${relDir}/${e.name}`,
|
|
||||||
);
|
|
||||||
let outputPath: string | undefined;
|
|
||||||
if (wasTruncated) {
|
|
||||||
const fullProcessed = await Promise.all(filtered.map(processOne));
|
|
||||||
const fullFiltered = filterSecretEntries(fullProcessed, (e) =>
|
|
||||||
relDir === '.' ? e.name : `${relDir}/${e.name}`,
|
|
||||||
);
|
|
||||||
// One line per entry, view_truncated_output's line slicing semantics
|
|
||||||
// map cleanly. Format: "<type>\t<name>[\tsize=N]". Header documents
|
|
||||||
// the shape so the model can grep / regex without prior schema lookup.
|
|
||||||
const header = `# list_dir ${relDir} — ${fullFiltered.kept.length} entries`;
|
|
||||||
const lines = [header, ...fullFiltered.kept.map((e) => {
|
|
||||||
const sz = 'size' in e && e.size != null ? `\tsize=${e.size}` : '';
|
|
||||||
return `${e.type}\t${e.name}${sz}`;
|
|
||||||
})];
|
|
||||||
const wrapped = await truncateIfNeeded({
|
|
||||||
fullContent: lines.join('\n'),
|
|
||||||
slicedContent: '',
|
|
||||||
wasTruncated: true,
|
|
||||||
});
|
|
||||||
outputPath = wrapped.outputPath;
|
|
||||||
}
|
|
||||||
return {
|
|
||||||
path: relDir,
|
|
||||||
entries: secretFilter.kept,
|
|
||||||
total: secretFilter.kept.length,
|
|
||||||
truncated: wasTruncated,
|
|
||||||
...(secretFilter.note ? { pathguard_note: secretFilter.note } : {}),
|
|
||||||
...(outputPath ? { outputPath } : {}),
|
|
||||||
};
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
const GrepInput = z.object({
|
|
||||||
pattern: z.string().min(1),
|
|
||||||
path: z.string().optional(),
|
|
||||||
case_sensitive: z.boolean().optional(),
|
|
||||||
max_results: z.number().int().positive().optional(),
|
|
||||||
hidden: z.boolean().optional(),
|
|
||||||
});
|
|
||||||
type GrepInputT = z.infer<typeof GrepInput>;
|
|
||||||
|
|
||||||
export const grep: ToolDef<GrepInputT> = {
|
|
||||||
name: 'grep',
|
|
||||||
description:
|
|
||||||
'Search file contents with ripgrep. Default path is project root. Max 100 results (200 cap).',
|
|
||||||
inputSchema: GrepInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'grep',
|
|
||||||
description:
|
|
||||||
'Search file contents with ripgrep. Returns up to 100 matches (cap 200). Set hidden=true to include dot-prefixed files.',
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
pattern: { type: 'string' },
|
|
||||||
path: { type: 'string' },
|
|
||||||
case_sensitive: { type: 'boolean' },
|
|
||||||
max_results: { type: 'integer' },
|
|
||||||
hidden: { type: 'boolean' },
|
|
||||||
},
|
|
||||||
required: ['pattern'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
async execute(input, projectRoot, extraRoots) {
|
|
||||||
const limit = Math.min(
|
|
||||||
Math.max(input.max_results ?? DEFAULT_GREP_RESULTS, 1),
|
|
||||||
MAX_GREP_RESULTS
|
|
||||||
);
|
|
||||||
// Delegate to file_ops.grep; reshape match objects to preserve LLM output format
|
|
||||||
// (file_ops uses {path, line, text}; tool output uses {path, line, content})
|
|
||||||
const result = await fileOpsGrep(projectRoot, input.pattern, {
|
|
||||||
path: input.path,
|
|
||||||
max_matches: limit,
|
|
||||||
case_sensitive: input.case_sensitive,
|
|
||||||
hidden: input.hidden,
|
|
||||||
extra_roots: extraRoots,
|
|
||||||
});
|
|
||||||
const reshaped = result.matches.map((m) => ({
|
|
||||||
path: m.path,
|
|
||||||
line: m.line,
|
|
||||||
content: m.text,
|
|
||||||
}));
|
|
||||||
// v1.11.7: drop matches whose source file is a known-secret pattern.
|
|
||||||
// file_ops.grep returns project-relative paths, so we feed them straight
|
|
||||||
// into isSecretPath. Multiple matches in the same secret file each get
|
|
||||||
// dropped individually — they all count in the hidden tally.
|
|
||||||
const secretFilter = filterSecretEntries(reshaped, (m) => m.path);
|
|
||||||
return {
|
|
||||||
matches: secretFilter.kept,
|
|
||||||
total: secretFilter.kept.length,
|
|
||||||
truncated: result.truncated,
|
|
||||||
...(secretFilter.note ? { pathguard_note: secretFilter.note } : {}),
|
|
||||||
};
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
const FindFilesInput = z.object({
|
|
||||||
pattern: z.string().min(1),
|
|
||||||
path: z.string().optional(),
|
|
||||||
max_results: z.number().int().positive().optional(),
|
|
||||||
});
|
|
||||||
type FindFilesInputT = z.infer<typeof FindFilesInput>;
|
|
||||||
|
|
||||||
export const findFiles: ToolDef<FindFilesInputT> = {
|
|
||||||
name: 'find_files',
|
|
||||||
description: 'Glob for filenames. Default path is project root. Max 100 results (200 cap).',
|
|
||||||
inputSchema: FindFilesInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'find_files',
|
|
||||||
description:
|
|
||||||
'Glob for filenames under a directory. Default path is project root. Max 100 results (cap 200). Pattern uses standard glob (e.g. "**/*.ts").',
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
pattern: { type: 'string' },
|
|
||||||
path: { type: 'string' },
|
|
||||||
max_results: { type: 'integer' },
|
|
||||||
},
|
|
||||||
required: ['pattern'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
async execute(input, projectRoot, extraRoots) {
|
|
||||||
const limit = Math.min(
|
|
||||||
Math.max(input.max_results ?? DEFAULT_FIND_RESULTS, 1),
|
|
||||||
MAX_FIND_RESULTS
|
|
||||||
);
|
|
||||||
// Delegate to file_ops.findFiles; reshape { files, total, truncated } to
|
|
||||||
// preserve the LLM-visible output format { paths, total, truncated }
|
|
||||||
const result = await fileOpsFindFiles(projectRoot, input.pattern, {
|
|
||||||
path: input.path,
|
|
||||||
max_results: limit,
|
|
||||||
extra_roots: extraRoots,
|
|
||||||
});
|
|
||||||
// v1.11.7: drop paths matching secret patterns. The original `total`
|
|
||||||
// from file_ops includes pre-truncation count; we report the visible
|
|
||||||
// count post-filter so the LLM can't infer hidden-count by subtraction.
|
|
||||||
const secretFilter = filterSecretEntries(result.files, (p) => p);
|
|
||||||
return {
|
|
||||||
paths: secretFilter.kept,
|
|
||||||
total: secretFilter.kept.length,
|
|
||||||
truncated: result.truncated,
|
|
||||||
...(secretFilter.note ? { pathguard_note: secretFilter.note } : {}),
|
|
||||||
};
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
// v1.13.5: retrieves the full content of a previously-truncated tool output
|
|
||||||
// via the opaque id stamped on the original tool_result. Line-based slicing
|
|
||||||
// matches view_file's mental model so the model uses the same affordances.
|
|
||||||
// Tmpfs-backed, 7-day TTL (see services/truncate.ts).
|
|
||||||
const VIEW_TRUNCATED_DEFAULT_LINES = 200;
|
|
||||||
|
|
||||||
const ViewTruncatedOutputInput = z.object({
|
|
||||||
id: z.string().regex(/^tr_[0-9a-v]{12}$/),
|
|
||||||
start_line: z.number().int().positive().optional(),
|
|
||||||
end_line: z.number().int().positive().optional(),
|
|
||||||
});
|
|
||||||
type ViewTruncatedOutputInputT = z.infer<typeof ViewTruncatedOutputInput>;
|
|
||||||
|
|
||||||
export const viewTruncatedOutput: ToolDef<ViewTruncatedOutputInputT> = {
|
|
||||||
name: 'view_truncated_output',
|
|
||||||
description: `Retrieve the full content of a previously-truncated tool output by its outputPath id. When a tool returns { truncated: true, outputPath: "tr_..." }, call this to view the full content. Defaults to the first ${VIEW_TRUNCATED_DEFAULT_LINES} lines. Use start_line and end_line (1-indexed, inclusive) to slice. Stored for 7 days.`,
|
|
||||||
inputSchema: ViewTruncatedOutputInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'view_truncated_output',
|
|
||||||
description: `Retrieve the full content of a previously-truncated tool output by its outputPath id. Returns the first ${VIEW_TRUNCATED_DEFAULT_LINES} lines by default; use start_line/end_line to slice. Stored for 7 days.`,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
id: { type: 'string', description: 'The outputPath value from an earlier truncated tool result (e.g. "tr_abc123def456").' },
|
|
||||||
start_line: { type: 'integer', description: 'First line (1-indexed). Default 1.' },
|
|
||||||
end_line: { type: 'integer', description: `Last line (1-indexed, inclusive). Default ${VIEW_TRUNCATED_DEFAULT_LINES} lines past start.` },
|
|
||||||
},
|
|
||||||
required: ['id'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
// view_truncated_output doesn't touch the filesystem — it pulls from tmpfs
|
|
||||||
// by opaque id. extraRoots is irrelevant here; declared for signature parity
|
|
||||||
// with the v1.13.17 ToolDef contract.
|
|
||||||
async execute(input, _projectRoot, _extraRoots) {
|
|
||||||
const content = await readTruncation(input.id);
|
|
||||||
if (content === null) {
|
|
||||||
return {
|
|
||||||
id: input.id,
|
|
||||||
content: '',
|
|
||||||
truncated: false,
|
|
||||||
error: `No truncation found for id "${input.id}". It may have been pruned (7-day TTL) or never existed.`,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
const lines = content.split('\n');
|
|
||||||
const total = lines.length;
|
|
||||||
let start = input.start_line ?? 1;
|
|
||||||
let end = input.end_line ?? Math.min(total, start + VIEW_TRUNCATED_DEFAULT_LINES - 1);
|
|
||||||
if (start < 1) start = 1;
|
|
||||||
if (end > total) end = total;
|
|
||||||
if (end < start) end = start;
|
|
||||||
const slice = lines.slice(start - 1, end).join('\n');
|
|
||||||
// Re-slicing this view isn't truncation in the dual-write sense — the
|
|
||||||
// model already has the id; no point stashing the slice again.
|
|
||||||
const truncated = total > end || start > 1;
|
|
||||||
return {
|
|
||||||
id: input.id,
|
|
||||||
content: slice,
|
|
||||||
total_lines: total,
|
|
||||||
returned_lines: [start, end],
|
|
||||||
truncated,
|
|
||||||
};
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
// v1.8 Level 1 branch awareness: gives the model a read-only view of the
|
|
||||||
// project's git state. No path input — operates on the inference-resolved
|
|
||||||
// project root via getGitMeta. Subprocess runs with a 2s timeout (see git_meta).
|
|
||||||
const GitStatusInput = z.object({}).strict();
|
|
||||||
type GitStatusInputT = z.infer<typeof GitStatusInput>;
|
|
||||||
|
|
||||||
export const gitStatus: ToolDef<GitStatusInputT> = {
|
|
||||||
name: 'git_status',
|
|
||||||
description:
|
|
||||||
"Returns the current git branch, whether the working tree is dirty, and ahead/behind counts vs upstream. Read-only. Use when you need to know which branch the user is currently working on.",
|
|
||||||
inputSchema: GitStatusInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'git_status',
|
|
||||||
description:
|
|
||||||
'Returns the current git branch, dirty flag, and ahead/behind counts vs upstream. Read-only.',
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {},
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
async execute(_input, projectRoot) {
|
|
||||||
const meta = await getGitMeta(projectRoot);
|
|
||||||
if (meta === null) {
|
|
||||||
return { repo: false, branch: null, is_dirty: false, ahead: 0, behind: 0 };
|
|
||||||
}
|
|
||||||
return { repo: true, ...meta };
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
// Batch 9.6: skill_find, skill_use, skill_resource. Lazy-loaded markdown
|
|
||||||
// playbooks at /data/skills/. Three tools rather than one to keep each call
|
|
||||||
// cheap — the model lists, then loads, then optionally pulls support files.
|
|
||||||
|
|
||||||
const SkillFindInput = z.object({
|
|
||||||
query: z.string().optional(),
|
|
||||||
});
|
|
||||||
type SkillFindInputT = z.infer<typeof SkillFindInput>;
|
|
||||||
|
|
||||||
export const skillFind: ToolDef<SkillFindInputT> = {
|
|
||||||
name: 'skill_find',
|
|
||||||
description:
|
|
||||||
'Find skills (markdown playbooks under /data/skills) by name or description. Returns up to 5 matches. Empty query or "*" returns all available skills. Call this first to discover what skills are available.',
|
|
||||||
inputSchema: SkillFindInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'skill_find',
|
|
||||||
description:
|
|
||||||
'Find skills by name or description. Returns up to 5 matches. Empty or "*" returns all.',
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
query: { type: 'string', description: 'substring matched against skill name and description' },
|
|
||||||
},
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
async execute(input) {
|
|
||||||
return await findSkills(input.query ?? '');
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
const SkillUseInput = z.object({
|
|
||||||
name: z.string().min(1),
|
|
||||||
});
|
|
||||||
type SkillUseInputT = z.infer<typeof SkillUseInput>;
|
|
||||||
|
|
||||||
export const skillUse: ToolDef<SkillUseInputT> = {
|
|
||||||
name: 'skill_use',
|
|
||||||
description:
|
|
||||||
"Load the full body of a skill's SKILL.md by name. Returns the markdown playbook to follow. Discover names via skill_find. Errors: unknown_skill.",
|
|
||||||
inputSchema: SkillUseInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'skill_use',
|
|
||||||
description: "Load the full body of a skill's SKILL.md by name.",
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
name: { type: 'string', description: 'skill name from skill_find' },
|
|
||||||
},
|
|
||||||
required: ['name'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
async execute(input) {
|
|
||||||
const body = await getSkillBody(input.name);
|
|
||||||
if (body === null) {
|
|
||||||
return { error: 'unknown_skill', message: `unknown skill: ${input.name}` };
|
|
||||||
}
|
|
||||||
return { body };
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
const SkillResourceInput = z.object({
|
|
||||||
name: z.string().min(1),
|
|
||||||
path: z.string().min(1),
|
|
||||||
});
|
|
||||||
type SkillResourceInputT = z.infer<typeof SkillResourceInput>;
|
|
||||||
|
|
||||||
export const skillResource: ToolDef<SkillResourceInputT> = {
|
|
||||||
name: 'skill_resource',
|
|
||||||
description:
|
|
||||||
"Read a support file inside a skill's folder (e.g. references/root-cause-tracing.md). Path is relative to the skill folder. Use skill_use to read SKILL.md itself. Errors: unknown_skill, unknown_resource, path_escape.",
|
|
||||||
inputSchema: SkillResourceInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'skill_resource',
|
|
||||||
description: "Read a support file inside a skill's folder. Path is relative to the skill folder.",
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
name: { type: 'string', description: 'skill name' },
|
|
||||||
path: { type: 'string', description: 'relative path under the skill folder' },
|
|
||||||
},
|
|
||||||
required: ['name', 'path'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
async execute(input) {
|
|
||||||
const result = await getSkillResource(input.name, input.path);
|
|
||||||
if (!result.ok) {
|
|
||||||
return { error: result.code, message: result.message };
|
|
||||||
}
|
|
||||||
return { content: result.content };
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
// Batch 9.7: ask_user_input. Interactive elicitation. The model emits a tool
|
|
||||||
// call with 1-3 structured questions; the inference loop PAUSES (does not
|
|
||||||
// execute the tool server-side, does not recurse) and waits for the frontend
|
|
||||||
// to POST /api/chats/:id/answer_user_input with the user's selections. See
|
|
||||||
// routes/messages.ts for the resume path and services/inference.ts for the
|
|
||||||
// pause branch in executeToolPhase.
|
|
||||||
const AskUserInputInput = z.object({
|
|
||||||
questions: z
|
|
||||||
.array(
|
|
||||||
z.object({
|
|
||||||
question: z.string().min(1).max(200),
|
|
||||||
type: z.enum(['single_select', 'multi_select']),
|
|
||||||
options: z.array(z.string().min(1).max(80)).min(2).max(6),
|
|
||||||
}),
|
|
||||||
)
|
|
||||||
.min(1)
|
|
||||||
.max(3),
|
|
||||||
});
|
|
||||||
type AskUserInputInputT = z.infer<typeof AskUserInputInput>;
|
|
||||||
|
|
||||||
export const askUserInput: ToolDef<AskUserInputInputT> = {
|
|
||||||
name: 'ask_user_input',
|
|
||||||
description:
|
|
||||||
"Ask the user 1-3 structured questions through an inline picker UI. Use when you genuinely need a choice the user must make (e.g. scope, options, preferences) before continuing. Each question has 2-6 options and accepts free-text answers in addition. The tool call pauses the conversation until the user submits — the next assistant turn sees their answers as the tool result. Do not use for trivial yes/no clarifications you could infer; prefer it over multi-paragraph speculation about what the user might want.",
|
|
||||||
inputSchema: AskUserInputInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'ask_user_input',
|
|
||||||
description:
|
|
||||||
'Ask the user 1-3 structured questions through an inline picker. Pauses the conversation until the user answers; the next turn sees their selections.',
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
questions: {
|
|
||||||
type: 'array',
|
|
||||||
minItems: 1,
|
|
||||||
maxItems: 3,
|
|
||||||
items: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
question: { type: 'string', description: '<=200 chars, shown to the user' },
|
|
||||||
type: {
|
|
||||||
type: 'string',
|
|
||||||
enum: ['single_select', 'multi_select'],
|
|
||||||
description: 'single_select = at most one option; multi_select = any subset',
|
|
||||||
},
|
|
||||||
options: {
|
|
||||||
type: 'array',
|
|
||||||
minItems: 2,
|
|
||||||
maxItems: 6,
|
|
||||||
items: { type: 'string' },
|
|
||||||
description: '2-6 strings, each <=80 chars; free-text input is always available alongside',
|
|
||||||
},
|
|
||||||
},
|
|
||||||
required: ['question', 'type', 'options'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
required: ['questions'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
// Server-side no-op. The "execution" of ask_user_input is the user's
|
|
||||||
// response, captured client-side and posted to /api/chats/:id/answer_user_input.
|
|
||||||
// The inference loop detects this tool by name and pauses before reaching
|
|
||||||
// executeToolCall — this fallback only runs if something bypasses that
|
|
||||||
// branch, in which case the pending sentinel matches the pause-path shape.
|
|
||||||
async execute(input) {
|
|
||||||
return { _pending: true, questions: input.questions };
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
// v1.13.3: alpha-sorted by tool.name at module load. llama.cpp's prompt
|
|
||||||
// cache hits on byte-identical prefixes; the tool list lives near the top
|
|
||||||
// of the system prompt, so any order drift would invalidate every cached
|
|
||||||
// turn. Single source of truth for ordering lives here — toolJsonSchemas()
|
|
||||||
// and TOOLS_BY_NAME inherit it.
|
|
||||||
// v1.14.1-mcp-poc: changed from ReadonlyArray to let-bound mutable array
|
|
||||||
// so appendMcpTools() can push MCP-discovered tools at startup.
|
|
||||||
export let ALL_TOOLS: ToolDef<unknown>[] = [
|
|
||||||
viewFile as ToolDef<unknown>,
|
|
||||||
viewTruncatedOutput as ToolDef<unknown>,
|
|
||||||
listDir as ToolDef<unknown>,
|
|
||||||
grep as ToolDef<unknown>,
|
|
||||||
findFiles as ToolDef<unknown>,
|
|
||||||
gitStatus as ToolDef<unknown>,
|
|
||||||
skillFind as ToolDef<unknown>,
|
|
||||||
skillUse as ToolDef<unknown>,
|
|
||||||
skillResource as ToolDef<unknown>,
|
|
||||||
askUserInput as ToolDef<unknown>,
|
|
||||||
// v1.11.8: web tools. Gated per-chat via session.web_search_enabled
|
|
||||||
// (with project default fallback) — see effectiveTools filter in
|
|
||||||
// services/inference.ts.
|
|
||||||
webSearch as ToolDef<unknown>,
|
|
||||||
webFetch as ToolDef<unknown>,
|
|
||||||
// v1.12 Track B.2: codecontext tools. Backed by the codecontext sidecar
|
|
||||||
// container. All read-only. target_dir is resolved server-side from the
|
|
||||||
// project root in codecontext_client.ts (the LLM never supplies it).
|
|
||||||
getCodebaseOverview as ToolDef<unknown>,
|
|
||||||
getFileAnalysis as ToolDef<unknown>,
|
|
||||||
getSymbolInfo as ToolDef<unknown>,
|
|
||||||
searchSymbols as ToolDef<unknown>,
|
|
||||||
getDependencies as ToolDef<unknown>,
|
|
||||||
watchChanges as ToolDef<unknown>,
|
|
||||||
getSemanticNeighborhoods as ToolDef<unknown>,
|
|
||||||
getFrameworkAnalysis as ToolDef<unknown>,
|
|
||||||
// v1.16: codesight-merge tools. Backed by the same codecontext sidecar.
|
|
||||||
getBlastRadius as ToolDef<unknown>,
|
|
||||||
getHotFiles as ToolDef<unknown>,
|
|
||||||
getRoutes as ToolDef<unknown>,
|
|
||||||
getMiddleware as ToolDef<unknown>,
|
|
||||||
// v1.13.17-cross-repo-reads: paired with the pause-on-pending-grant
|
|
||||||
// branch in tool-phase.ts. Read-only — only ever READS files; the only
|
|
||||||
// state change is appending to sessions.allowed_read_paths via the
|
|
||||||
// grant endpoint, gated by user consent.
|
|
||||||
requestReadAccess as ToolDef<unknown>,
|
|
||||||
// v2.6.x: read a tab's transcript by its session-scoped tab number.
|
|
||||||
// Read-only; uses the ToolExecCtx 4th arg for DB/session access.
|
|
||||||
readTabByNumber as ToolDef<unknown>,
|
|
||||||
].sort((a, b) => a.name.localeCompare(b.name));
|
|
||||||
|
|
||||||
// v1.8.2: forward-compatible read-only whitelist. An agent whose `tools` is
|
|
||||||
// fully contained in this set gets a generous default tool budget (30);
|
|
||||||
// anything outside means the agent can mutate state and gets a tighter
|
|
||||||
// default (10). Every tool in v1.8.2 happens to be read-only, so the
|
|
||||||
// non-RO branch only takes effect once BooCoder lands write tools.
|
|
||||||
// Batch 9.6: skill_* added; all still read-only.
|
|
||||||
// Batch 9.7: ask_user_input added — it pauses execution but doesn't mutate
|
|
||||||
// project state, so it belongs in the read-only set for budget purposes.
|
|
||||||
export const READ_ONLY_TOOL_NAMES = [
|
|
||||||
'view_file',
|
|
||||||
'view_truncated_output',
|
|
||||||
'list_dir',
|
|
||||||
'grep',
|
|
||||||
'find_files',
|
|
||||||
'git_status',
|
|
||||||
'skill_find',
|
|
||||||
'skill_use',
|
|
||||||
'skill_resource',
|
|
||||||
'ask_user_input',
|
|
||||||
// v1.11.8: web tools don't mutate project state; counted as read-only
|
|
||||||
// for the budget-tier calculation (BUDGET_READ_ONLY=30) when an agent's
|
|
||||||
// toolset is fully contained in this list.
|
|
||||||
'web_search',
|
|
||||||
'web_fetch',
|
|
||||||
// v1.12 Track B.2: codecontext tools. Read-only — they call the
|
|
||||||
// codecontext sidecar which only analyzes files (never writes).
|
|
||||||
'get_codebase_overview',
|
|
||||||
'get_file_analysis',
|
|
||||||
'get_symbol_info',
|
|
||||||
'search_symbols',
|
|
||||||
'get_dependencies',
|
|
||||||
'watch_changes',
|
|
||||||
'get_semantic_neighborhoods',
|
|
||||||
'get_framework_analysis',
|
|
||||||
// v1.13.17-cross-repo-reads: pauses execution but doesn't mutate project
|
|
||||||
// state directly (the grant endpoint appends to sessions.allowed_read_paths
|
|
||||||
// only with user consent). Belongs in the read-only budget tier.
|
|
||||||
'request_read_access',
|
|
||||||
// v2.6.x: reads a tab's transcript from session-scoped DB state; never
|
|
||||||
// writes. Belongs in the read-only budget tier.
|
|
||||||
'read_tab_by_number',
|
|
||||||
] as const;
|
|
||||||
|
|
||||||
export let TOOLS_BY_NAME: Record<string, ToolDef<unknown>> = Object.fromEntries(
|
|
||||||
ALL_TOOLS.map((t) => [t.name, t])
|
|
||||||
);
|
|
||||||
|
|
||||||
// v1.14.1-mcp-poc: append MCP-discovered tools at startup. Called once
|
|
||||||
// from index.ts after mcpClient.initialize(). Re-sorts ALL_TOOLS and
|
|
||||||
// rebuilds TOOLS_BY_NAME. READ_ONLY_TOOL_NAMES is not rebuilt because
|
|
||||||
// it's a const tuple used only for budget-tier checks; MCP tools are
|
|
||||||
// individually checked via their category at budget resolution time —
|
|
||||||
// they are all read_only by construction (the read-only guard in
|
|
||||||
// mcp-client.ts rejects any tool with readOnlyHint: false).
|
|
||||||
export function appendMcpTools(mcpTools: ToolDef<unknown>[]): void {
|
|
||||||
if (mcpTools.length === 0) return;
|
|
||||||
ALL_TOOLS = [...ALL_TOOLS, ...mcpTools].sort((a, b) => a.name.localeCompare(b.name));
|
|
||||||
TOOLS_BY_NAME = Object.fromEntries(ALL_TOOLS.map((t) => [t.name, t]));
|
|
||||||
}
|
|
||||||
|
|
||||||
// v1.13.15-tools: tiered tool loading. BOOCODE_TOOLS env var (`core` |
|
|
||||||
// `standard` | `all`) filters the agent's tool whitelist before LLM dispatch.
|
|
||||||
// Daily-driver token win on qwen3.6-35b-a3b — the 35B-A3B MoE benefits from
|
|
||||||
// any prompt-cache stability win (fewer tools = shorter, more stable tool
|
|
||||||
// schemas in the system prompt). Pattern lift from eyaltoledano/claude-task-
|
|
||||||
// master (MIT + Commons Clause — pattern only, no code lift).
|
|
||||||
//
|
//
|
||||||
// The env var is a CEILING. It only narrows; never expands an agent's
|
// ./tools/types.ts — ToolDef / ToolJsonSchema / ToolExecCtx
|
||||||
// declared whitelist. Default behavior (var unset) is unchanged: all tools.
|
// ./tools/fs-tools.ts — filesystem ToolDefs (view_file/list_dir/grep/
|
||||||
export const CORE_TOOL_NAMES = [
|
// find_files/view_truncated_output)
|
||||||
'view_file',
|
// ./tools/misc-tools.ts— git_status/skill_*/ask_user_input ToolDefs
|
||||||
'list_dir',
|
// ./tools/registry.ts — ALL_TOOLS/TOOLS_BY_NAME (register-through let
|
||||||
'grep',
|
// bindings), appendMcpTools, toolJsonSchemas
|
||||||
'find_files',
|
// ./tools/tiers.ts — CORE/STANDARD names + module-load validation +
|
||||||
] as const;
|
// resolveToolTier
|
||||||
|
//
|
||||||
|
// Re-exporting the `let`-bound ALL_TOOLS / TOOLS_BY_NAME preserves the
|
||||||
|
// register-through MCP-discovery contract: appendMcpTools() reassigns the
|
||||||
|
// bindings in registry.ts and ESM live bindings make the mutation visible
|
||||||
|
// through this barrel to every consumer (incl. apps/coder).
|
||||||
|
|
||||||
export const STANDARD_TOOL_NAMES = [
|
export type { ToolDef, ToolJsonSchema, ToolExecCtx } from './tools/types.js';
|
||||||
...CORE_TOOL_NAMES,
|
export {
|
||||||
'web_search',
|
viewFile,
|
||||||
'web_fetch',
|
listDir,
|
||||||
'git_status',
|
grep,
|
||||||
'get_codebase_overview',
|
findFiles,
|
||||||
'get_file_analysis',
|
viewTruncatedOutput,
|
||||||
'get_symbol_info',
|
} from './tools/fs-tools.js';
|
||||||
'search_symbols',
|
export {
|
||||||
'get_dependencies',
|
gitStatus,
|
||||||
'watch_changes',
|
skillFind,
|
||||||
'get_semantic_neighborhoods',
|
skillUse,
|
||||||
'get_framework_analysis',
|
skillResource,
|
||||||
] as const;
|
askUserInput,
|
||||||
|
} from './tools/misc-tools.js';
|
||||||
// Module-load validation: every name in CORE / STANDARD must exist in
|
export {
|
||||||
// TOOLS_BY_NAME. Catches typos and stale tier definitions before they reach
|
ALL_TOOLS,
|
||||||
// production; server boot fails loudly rather than silently filtering valid
|
TOOLS_BY_NAME,
|
||||||
// tools out of agent whitelists.
|
appendMcpTools,
|
||||||
for (const name of CORE_TOOL_NAMES) {
|
toolJsonSchemas,
|
||||||
if (!TOOLS_BY_NAME[name]) {
|
} from './tools/registry.js';
|
||||||
throw new Error(`CORE_TOOL_NAMES references unknown tool: '${name}'`);
|
export {
|
||||||
}
|
CORE_TOOL_NAMES,
|
||||||
}
|
STANDARD_TOOL_NAMES,
|
||||||
for (const name of STANDARD_TOOL_NAMES) {
|
resolveToolTier,
|
||||||
if (!TOOLS_BY_NAME[name]) {
|
} from './tools/tiers.js';
|
||||||
throw new Error(`STANDARD_TOOL_NAMES references unknown tool: '${name}'`);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
export function resolveToolTier(tier: string | undefined): readonly string[] {
|
|
||||||
switch ((tier ?? 'all').toLowerCase()) {
|
|
||||||
case 'core':
|
|
||||||
return CORE_TOOL_NAMES;
|
|
||||||
case 'standard':
|
|
||||||
return STANDARD_TOOL_NAMES;
|
|
||||||
case 'all':
|
|
||||||
default:
|
|
||||||
return ALL_TOOLS.map((t) => t.name);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
export function toolJsonSchemas(): ToolJsonSchema[] {
|
|
||||||
return ALL_TOOLS.map((t) => t.jsonSchema);
|
|
||||||
}
|
|
||||||
|
|||||||
43
apps/server/src/services/tools/codecontext/factory.ts
Normal file
43
apps/server/src/services/tools/codecontext/factory.ts
Normal file
@@ -0,0 +1,43 @@
|
|||||||
|
import { z } from 'zod';
|
||||||
|
import type { ToolDef } from '../types.js';
|
||||||
|
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
||||||
|
|
||||||
|
// Shared factory for the 12 codecontext shim ToolDefs.
|
||||||
|
// Each shim provides name/schema/description/jsonParameters/mapArgs; the
|
||||||
|
// factory builds the ToolDef and returns both the ToolDef and the standalone
|
||||||
|
// execute function (used by tests that inject a custom fetcher).
|
||||||
|
export function makeCodecontextTool<TInput>(opts: {
|
||||||
|
name: string;
|
||||||
|
schema: z.ZodType<TInput>;
|
||||||
|
description: string;
|
||||||
|
jsonParameters: Record<string, unknown>;
|
||||||
|
mapArgs: (input: TInput) => Record<string, unknown>;
|
||||||
|
}): {
|
||||||
|
toolDef: ToolDef<TInput>;
|
||||||
|
execute: (input: TInput, projectPath: string, fetcher?: typeof fetch) => Promise<CodecontextResponse>;
|
||||||
|
} {
|
||||||
|
const { name, schema, description, jsonParameters, mapArgs } = opts;
|
||||||
|
|
||||||
|
async function execute(
|
||||||
|
input: TInput,
|
||||||
|
projectPath: string,
|
||||||
|
fetcher: typeof fetch = fetch,
|
||||||
|
): Promise<CodecontextResponse> {
|
||||||
|
return callCodecontext({ toolName: name, args: mapArgs(input), projectPath }, fetcher);
|
||||||
|
}
|
||||||
|
|
||||||
|
const toolDef: ToolDef<TInput> = {
|
||||||
|
name,
|
||||||
|
description,
|
||||||
|
inputSchema: schema,
|
||||||
|
jsonSchema: {
|
||||||
|
type: 'function',
|
||||||
|
function: { name, description, parameters: jsonParameters },
|
||||||
|
},
|
||||||
|
async execute(input, projectRoot) {
|
||||||
|
return execute(input, projectRoot);
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
return { toolDef, execute };
|
||||||
|
}
|
||||||
@@ -1,6 +1,5 @@
|
|||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetBlastRadiusInput = z.object({
|
export const GetBlastRadiusInput = z.object({
|
||||||
file_path: z.string().trim().min(1),
|
file_path: z.string().trim().min(1),
|
||||||
@@ -12,40 +11,23 @@ const DESCRIPTION =
|
|||||||
'Use to assess the impact of changing a file — "what breaks if I modify this?" ' +
|
'Use to assess the impact of changing a file — "what breaks if I modify this?" ' +
|
||||||
'Traverses the import graph in reverse via BFS. Results sorted by distance (closest dependents first).';
|
'Traverses the import graph in reverse via BFS. Results sorted by distance (closest dependents first).';
|
||||||
|
|
||||||
export async function executeGetBlastRadius(
|
const { toolDef: getBlastRadius, execute: executeGetBlastRadius } =
|
||||||
input: GetBlastRadiusInputT,
|
makeCodecontextTool<GetBlastRadiusInputT>({
|
||||||
projectPath: string,
|
name: 'get_blast_radius',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetBlastRadiusInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
return callCodecontext(
|
jsonParameters: {
|
||||||
{ toolName: 'get_blast_radius', args: { file_path: input.file_path }, projectPath },
|
type: 'object',
|
||||||
fetcher,
|
properties: {
|
||||||
);
|
file_path: {
|
||||||
}
|
type: 'string',
|
||||||
|
description: 'Absolute or project-relative path to the file to analyze.',
|
||||||
export const getBlastRadius: ToolDef<GetBlastRadiusInputT> = {
|
|
||||||
name: 'get_blast_radius',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
inputSchema: GetBlastRadiusInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'get_blast_radius',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
file_path: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Absolute or project-relative path to the file to analyze.',
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
required: ['file_path'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
required: ['file_path'],
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => ({ file_path: input.file_path }),
|
||||||
async execute(input, projectRoot) {
|
});
|
||||||
return await executeGetBlastRadius(input, projectRoot);
|
|
||||||
},
|
export { getBlastRadius, executeGetBlastRadius };
|
||||||
};
|
|
||||||
|
|||||||
@@ -1,10 +1,5 @@
|
|||||||
// v1.12 Track B.2: codecontext wrapper — get_codebase_overview.
|
|
||||||
// Pattern mirrors services/web_search.ts: pure executor + ToolDef wrapper.
|
|
||||||
// target_dir is supplied by callCodecontext from the resolved project root.
|
|
||||||
|
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetCodebaseOverviewInput = z.object({
|
export const GetCodebaseOverviewInput = z.object({
|
||||||
include_stats: z.boolean().optional(),
|
include_stats: z.boolean().optional(),
|
||||||
@@ -17,43 +12,22 @@ const DESCRIPTION =
|
|||||||
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript symbols are approximate (uses JS grammar). ' +
|
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript symbols are approximate (uses JS grammar). ' +
|
||||||
'PHP and SQL are not supported — fall back to view_file/grep for those.';
|
'PHP and SQL are not supported — fall back to view_file/grep for those.';
|
||||||
|
|
||||||
export async function executeGetCodebaseOverview(
|
const { toolDef: getCodebaseOverview, execute: executeGetCodebaseOverview } =
|
||||||
input: GetCodebaseOverviewInputT,
|
makeCodecontextTool<GetCodebaseOverviewInputT>({
|
||||||
projectPath: string,
|
name: 'get_codebase_overview',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetCodebaseOverviewInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
return callCodecontext(
|
jsonParameters: {
|
||||||
{
|
type: 'object',
|
||||||
toolName: 'get_codebase_overview',
|
properties: {
|
||||||
args: { include_stats: input.include_stats ?? true },
|
include_stats: {
|
||||||
projectPath,
|
type: 'boolean',
|
||||||
},
|
description: 'Include file count, symbol count, language stats. Defaults to true.',
|
||||||
fetcher,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
export const getCodebaseOverview: ToolDef<GetCodebaseOverviewInputT> = {
|
|
||||||
name: 'get_codebase_overview',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
inputSchema: GetCodebaseOverviewInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'get_codebase_overview',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
include_stats: {
|
|
||||||
type: 'boolean',
|
|
||||||
description: 'Include file count, symbol count, language stats. Defaults to true.',
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => ({ include_stats: input.include_stats ?? true }),
|
||||||
async execute(input, projectRoot) {
|
});
|
||||||
return await executeGetCodebaseOverview(input, projectRoot);
|
|
||||||
},
|
export { getCodebaseOverview, executeGetCodebaseOverview };
|
||||||
};
|
|
||||||
|
|||||||
@@ -1,8 +1,5 @@
|
|||||||
// v1.12 Track B.2: codecontext wrapper — get_dependencies.
|
|
||||||
|
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetDependenciesInput = z.object({
|
export const GetDependenciesInput = z.object({
|
||||||
file_path: z.string().trim().optional(),
|
file_path: z.string().trim().optional(),
|
||||||
@@ -16,45 +13,31 @@ const DESCRIPTION =
|
|||||||
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript dependencies are approximate. ' +
|
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript dependencies are approximate. ' +
|
||||||
'PHP and SQL are not supported.';
|
'PHP and SQL are not supported.';
|
||||||
|
|
||||||
export async function executeGetDependencies(
|
const { toolDef: getDependencies, execute: executeGetDependencies } =
|
||||||
input: GetDependenciesInputT,
|
makeCodecontextTool<GetDependenciesInputT>({
|
||||||
projectPath: string,
|
name: 'get_dependencies',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetDependenciesInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
const args: Record<string, unknown> = {
|
jsonParameters: {
|
||||||
direction: input.direction ?? 'both',
|
type: 'object',
|
||||||
};
|
properties: {
|
||||||
if (input.file_path) args['file_path'] = input.file_path;
|
file_path: {
|
||||||
return callCodecontext({ toolName: 'get_dependencies', args, projectPath }, fetcher);
|
type: 'string',
|
||||||
}
|
description: 'Narrow to a single file. Omit for a project-wide graph.',
|
||||||
|
},
|
||||||
export const getDependencies: ToolDef<GetDependenciesInputT> = {
|
direction: {
|
||||||
name: 'get_dependencies',
|
type: 'string',
|
||||||
description: DESCRIPTION,
|
enum: ['incoming', 'outgoing', 'both'],
|
||||||
inputSchema: GetDependenciesInput,
|
description: 'Which edges to include. Defaults to "both".',
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'get_dependencies',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
file_path: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Narrow to a single file. Omit for a project-wide graph.',
|
|
||||||
},
|
|
||||||
direction: {
|
|
||||||
type: 'string',
|
|
||||||
enum: ['incoming', 'outgoing', 'both'],
|
|
||||||
description: 'Which edges to include. Defaults to "both".',
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => {
|
||||||
async execute(input, projectRoot) {
|
const args: Record<string, unknown> = { direction: input.direction ?? 'both' };
|
||||||
return await executeGetDependencies(input, projectRoot);
|
if (input.file_path) args['file_path'] = input.file_path;
|
||||||
},
|
return args;
|
||||||
};
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
export { getDependencies, executeGetDependencies };
|
||||||
|
|||||||
@@ -1,8 +1,5 @@
|
|||||||
// v1.12 Track B.2: codecontext wrapper — get_file_analysis.
|
|
||||||
|
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetFileAnalysisInput = z.object({
|
export const GetFileAnalysisInput = z.object({
|
||||||
file_path: z.string().trim().min(1),
|
file_path: z.string().trim().min(1),
|
||||||
@@ -15,44 +12,23 @@ const DESCRIPTION =
|
|||||||
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript symbols are approximate. ' +
|
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript symbols are approximate. ' +
|
||||||
'PHP and SQL are not supported — fall back to view_file for those.';
|
'PHP and SQL are not supported — fall back to view_file for those.';
|
||||||
|
|
||||||
export async function executeGetFileAnalysis(
|
const { toolDef: getFileAnalysis, execute: executeGetFileAnalysis } =
|
||||||
input: GetFileAnalysisInputT,
|
makeCodecontextTool<GetFileAnalysisInputT>({
|
||||||
projectPath: string,
|
name: 'get_file_analysis',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetFileAnalysisInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
return callCodecontext(
|
jsonParameters: {
|
||||||
{
|
type: 'object',
|
||||||
toolName: 'get_file_analysis',
|
properties: {
|
||||||
args: { file_path: input.file_path },
|
file_path: {
|
||||||
projectPath,
|
type: 'string',
|
||||||
},
|
description: 'Absolute or project-relative path to the file.',
|
||||||
fetcher,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
export const getFileAnalysis: ToolDef<GetFileAnalysisInputT> = {
|
|
||||||
name: 'get_file_analysis',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
inputSchema: GetFileAnalysisInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'get_file_analysis',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
file_path: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Absolute or project-relative path to the file.',
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
required: ['file_path'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
required: ['file_path'],
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => ({ file_path: input.file_path }),
|
||||||
async execute(input, projectRoot) {
|
});
|
||||||
return await executeGetFileAnalysis(input, projectRoot);
|
|
||||||
},
|
export { getFileAnalysis, executeGetFileAnalysis };
|
||||||
};
|
|
||||||
|
|||||||
@@ -1,8 +1,5 @@
|
|||||||
// v1.12 Track B.2: codecontext wrapper — get_framework_analysis.
|
|
||||||
|
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetFrameworkAnalysisInput = z.object({
|
export const GetFrameworkAnalysisInput = z.object({
|
||||||
framework: z.string().optional(),
|
framework: z.string().optional(),
|
||||||
@@ -16,43 +13,31 @@ const DESCRIPTION =
|
|||||||
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript is approximate. ' +
|
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript is approximate. ' +
|
||||||
'PHP and SQL are not supported.';
|
'PHP and SQL are not supported.';
|
||||||
|
|
||||||
export async function executeGetFrameworkAnalysis(
|
const { toolDef: getFrameworkAnalysis, execute: executeGetFrameworkAnalysis } =
|
||||||
input: GetFrameworkAnalysisInputT,
|
makeCodecontextTool<GetFrameworkAnalysisInputT>({
|
||||||
projectPath: string,
|
name: 'get_framework_analysis',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetFrameworkAnalysisInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
const args: Record<string, unknown> = {};
|
jsonParameters: {
|
||||||
if (input.framework) args['framework'] = input.framework;
|
type: 'object',
|
||||||
if (input.include_stats !== undefined) args['include_stats'] = input.include_stats;
|
properties: {
|
||||||
return callCodecontext({ toolName: 'get_framework_analysis', args, projectPath }, fetcher);
|
framework: {
|
||||||
}
|
type: 'string',
|
||||||
|
description: 'Framework name. Auto-detected if omitted.',
|
||||||
export const getFrameworkAnalysis: ToolDef<GetFrameworkAnalysisInputT> = {
|
},
|
||||||
name: 'get_framework_analysis',
|
include_stats: {
|
||||||
description: DESCRIPTION,
|
type: 'boolean',
|
||||||
inputSchema: GetFrameworkAnalysisInput,
|
description: 'Include component/hook/service counts.',
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'get_framework_analysis',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
framework: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Framework name. Auto-detected if omitted.',
|
|
||||||
},
|
|
||||||
include_stats: {
|
|
||||||
type: 'boolean',
|
|
||||||
description: 'Include component/hook/service counts.',
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => {
|
||||||
async execute(input, projectRoot) {
|
const args: Record<string, unknown> = {};
|
||||||
return await executeGetFrameworkAnalysis(input, projectRoot);
|
if (input.framework) args['framework'] = input.framework;
|
||||||
},
|
if (input.include_stats !== undefined) args['include_stats'] = input.include_stats;
|
||||||
};
|
return args;
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
export { getFrameworkAnalysis, executeGetFrameworkAnalysis };
|
||||||
|
|||||||
@@ -1,6 +1,5 @@
|
|||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetHotFilesInput = z.object({
|
export const GetHotFilesInput = z.object({
|
||||||
limit: z.number().int().min(1).max(100).optional(),
|
limit: z.number().int().min(1).max(100).optional(),
|
||||||
@@ -12,39 +11,22 @@ const DESCRIPTION =
|
|||||||
'Hot files are high-risk change targets — many other files depend on them. ' +
|
'Hot files are high-risk change targets — many other files depend on them. ' +
|
||||||
'Use to identify core modules and assess refactoring risk.';
|
'Use to identify core modules and assess refactoring risk.';
|
||||||
|
|
||||||
export async function executeGetHotFiles(
|
const { toolDef: getHotFiles, execute: executeGetHotFiles } =
|
||||||
input: GetHotFilesInputT,
|
makeCodecontextTool<GetHotFilesInputT>({
|
||||||
projectPath: string,
|
name: 'get_hot_files',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetHotFilesInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
return callCodecontext(
|
jsonParameters: {
|
||||||
{ toolName: 'get_hot_files', args: input.limit != null ? { limit: input.limit } : {}, projectPath },
|
type: 'object',
|
||||||
fetcher,
|
properties: {
|
||||||
);
|
limit: {
|
||||||
}
|
type: 'number',
|
||||||
|
description: 'Maximum number of files to return (default 20, max 100).',
|
||||||
export const getHotFiles: ToolDef<GetHotFilesInputT> = {
|
|
||||||
name: 'get_hot_files',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
inputSchema: GetHotFilesInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'get_hot_files',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
limit: {
|
|
||||||
type: 'number',
|
|
||||||
description: 'Maximum number of files to return (default 20, max 100).',
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => (input.limit != null ? { limit: input.limit } : {}),
|
||||||
async execute(input, projectRoot) {
|
});
|
||||||
return await executeGetHotFiles(input, projectRoot);
|
|
||||||
},
|
export { getHotFiles, executeGetHotFiles };
|
||||||
};
|
|
||||||
|
|||||||
@@ -1,6 +1,5 @@
|
|||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetMiddlewareInput = z.object({});
|
export const GetMiddlewareInput = z.object({});
|
||||||
export type GetMiddlewareInputT = z.infer<typeof GetMiddlewareInput>;
|
export type GetMiddlewareInputT = z.infer<typeof GetMiddlewareInput>;
|
||||||
@@ -11,31 +10,17 @@ const DESCRIPTION =
|
|||||||
'import names (@fastify/cors, helmet, etc.) and registration patterns ' +
|
'import names (@fastify/cors, helmet, etc.) and registration patterns ' +
|
||||||
'(app.register, app.addHook, app.setErrorHandler).';
|
'(app.register, app.addHook, app.setErrorHandler).';
|
||||||
|
|
||||||
export async function executeGetMiddleware(
|
const { toolDef: getMiddleware, execute: executeGetMiddleware } =
|
||||||
_input: GetMiddlewareInputT,
|
makeCodecontextTool<GetMiddlewareInputT>({
|
||||||
projectPath: string,
|
name: 'get_middleware',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetMiddlewareInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
return callCodecontext({ toolName: 'get_middleware', args: {}, projectPath }, fetcher);
|
jsonParameters: {
|
||||||
}
|
type: 'object',
|
||||||
|
properties: {},
|
||||||
export const getMiddleware: ToolDef<GetMiddlewareInputT> = {
|
additionalProperties: false,
|
||||||
name: 'get_middleware',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
inputSchema: GetMiddlewareInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'get_middleware',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {},
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
},
|
mapArgs: () => ({}),
|
||||||
async execute(input, projectRoot) {
|
});
|
||||||
return await executeGetMiddleware(input, projectRoot);
|
|
||||||
},
|
export { getMiddleware, executeGetMiddleware };
|
||||||
};
|
|
||||||
|
|||||||
@@ -1,6 +1,5 @@
|
|||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetRoutesInput = z.object({
|
export const GetRoutesInput = z.object({
|
||||||
framework: z.string().trim().optional(),
|
framework: z.string().trim().optional(),
|
||||||
@@ -13,38 +12,26 @@ const DESCRIPTION =
|
|||||||
'with method, path, file, line number, and inferred tags (db, auth, cache). ' +
|
'with method, path, file, line number, and inferred tags (db, auth, cache). ' +
|
||||||
'Optional framework filter narrows to "fastify" or "express".';
|
'Optional framework filter narrows to "fastify" or "express".';
|
||||||
|
|
||||||
export async function executeGetRoutes(
|
const { toolDef: getRoutes, execute: executeGetRoutes } =
|
||||||
input: GetRoutesInputT,
|
makeCodecontextTool<GetRoutesInputT>({
|
||||||
projectPath: string,
|
name: 'get_routes',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetRoutesInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
const args: Record<string, unknown> = {};
|
jsonParameters: {
|
||||||
if (input.framework) args.framework = input.framework;
|
type: 'object',
|
||||||
return callCodecontext({ toolName: 'get_routes', args, projectPath }, fetcher);
|
properties: {
|
||||||
}
|
framework: {
|
||||||
|
type: 'string',
|
||||||
export const getRoutes: ToolDef<GetRoutesInputT> = {
|
description: 'Filter to a specific framework: "fastify" or "express". Omit for all.',
|
||||||
name: 'get_routes',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
inputSchema: GetRoutesInput,
|
|
||||||
jsonSchema: {
|
|
||||||
type: 'function',
|
|
||||||
function: {
|
|
||||||
name: 'get_routes',
|
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
framework: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Filter to a specific framework: "fastify" or "express". Omit for all.',
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => {
|
||||||
async execute(input, projectRoot) {
|
const args: Record<string, unknown> = {};
|
||||||
return await executeGetRoutes(input, projectRoot);
|
if (input.framework) args.framework = input.framework;
|
||||||
},
|
return args;
|
||||||
};
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
export { getRoutes, executeGetRoutes };
|
||||||
|
|||||||
@@ -1,8 +1,5 @@
|
|||||||
// v1.12 Track B.2: codecontext wrapper — get_semantic_neighborhoods.
|
|
||||||
|
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetSemanticNeighborhoodsInput = z.object({
|
export const GetSemanticNeighborhoodsInput = z.object({
|
||||||
file_path: z.string().trim().optional(),
|
file_path: z.string().trim().optional(),
|
||||||
@@ -20,54 +17,42 @@ const DESCRIPTION =
|
|||||||
|
|
||||||
const DEFAULT_MAX_RESULTS = 10;
|
const DEFAULT_MAX_RESULTS = 10;
|
||||||
|
|
||||||
export async function executeGetSemanticNeighborhoods(
|
const { toolDef: getSemanticNeighborhoods, execute: executeGetSemanticNeighborhoods } =
|
||||||
input: GetSemanticNeighborhoodsInputT,
|
makeCodecontextTool<GetSemanticNeighborhoodsInputT>({
|
||||||
projectPath: string,
|
name: 'get_semantic_neighborhoods',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetSemanticNeighborhoodsInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
const args: Record<string, unknown> = {
|
jsonParameters: {
|
||||||
max_results: input.max_results ?? DEFAULT_MAX_RESULTS,
|
type: 'object',
|
||||||
};
|
properties: {
|
||||||
if (input.file_path) args['file_path'] = input.file_path;
|
file_path: {
|
||||||
if (input.include_basic !== undefined) args['include_basic'] = input.include_basic;
|
type: 'string',
|
||||||
if (input.include_quality !== undefined) args['include_quality'] = input.include_quality;
|
description: 'Anchor file for the neighborhood query. Omit for a project-wide view.',
|
||||||
return callCodecontext({ toolName: 'get_semantic_neighborhoods', args, projectPath }, fetcher);
|
},
|
||||||
}
|
include_basic: {
|
||||||
|
type: 'boolean',
|
||||||
export const getSemanticNeighborhoods: ToolDef<GetSemanticNeighborhoodsInputT> = {
|
description: 'Include the basic (import-based) neighborhood. Default true.',
|
||||||
name: 'get_semantic_neighborhoods',
|
},
|
||||||
description: DESCRIPTION,
|
include_quality: {
|
||||||
inputSchema: GetSemanticNeighborhoodsInput,
|
type: 'boolean',
|
||||||
jsonSchema: {
|
description: 'Include code-quality metrics for the neighborhood. Default false.',
|
||||||
type: 'function',
|
},
|
||||||
function: {
|
max_results: {
|
||||||
name: 'get_semantic_neighborhoods',
|
type: 'integer',
|
||||||
description: DESCRIPTION,
|
description: `Cap on neighborhoods returned. Defaults to ${DEFAULT_MAX_RESULTS}.`,
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
file_path: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Anchor file for the neighborhood query. Omit for a project-wide view.',
|
|
||||||
},
|
|
||||||
include_basic: {
|
|
||||||
type: 'boolean',
|
|
||||||
description: 'Include the basic (import-based) neighborhood. Default true.',
|
|
||||||
},
|
|
||||||
include_quality: {
|
|
||||||
type: 'boolean',
|
|
||||||
description: 'Include code-quality metrics for the neighborhood. Default false.',
|
|
||||||
},
|
|
||||||
max_results: {
|
|
||||||
type: 'integer',
|
|
||||||
description: `Cap on neighborhoods returned. Defaults to ${DEFAULT_MAX_RESULTS}.`,
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => {
|
||||||
async execute(input, projectRoot) {
|
const args: Record<string, unknown> = {
|
||||||
return await executeGetSemanticNeighborhoods(input, projectRoot);
|
max_results: input.max_results ?? DEFAULT_MAX_RESULTS,
|
||||||
},
|
};
|
||||||
};
|
if (input.file_path) args['file_path'] = input.file_path;
|
||||||
|
if (input.include_basic !== undefined) args['include_basic'] = input.include_basic;
|
||||||
|
if (input.include_quality !== undefined) args['include_quality'] = input.include_quality;
|
||||||
|
return args;
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
export { getSemanticNeighborhoods, executeGetSemanticNeighborhoods };
|
||||||
|
|||||||
@@ -1,8 +1,5 @@
|
|||||||
// v1.12 Track B.2: codecontext wrapper — get_symbol_info.
|
|
||||||
|
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const GetSymbolInfoInput = z.object({
|
export const GetSymbolInfoInput = z.object({
|
||||||
symbol_name: z.string().min(1),
|
symbol_name: z.string().min(1),
|
||||||
@@ -16,48 +13,36 @@ const DESCRIPTION =
|
|||||||
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript symbols are approximate (uses JS grammar). ' +
|
'Tree-sitter coverage: full for JS/Python/Java/Go/Rust/C++. TypeScript symbols are approximate (uses JS grammar). ' +
|
||||||
'PHP and SQL are not supported — fall back to grep for those.';
|
'PHP and SQL are not supported — fall back to grep for those.';
|
||||||
|
|
||||||
export async function executeGetSymbolInfo(
|
const { toolDef: getSymbolInfo, execute: executeGetSymbolInfo } =
|
||||||
input: GetSymbolInfoInputT,
|
makeCodecontextTool<GetSymbolInfoInputT>({
|
||||||
projectPath: string,
|
name: 'get_symbol_info',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: GetSymbolInfoInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
const args: Record<string, unknown> = { symbol_name: input.symbol_name };
|
jsonParameters: {
|
||||||
if (input.file_path) args['file_path'] = input.file_path;
|
type: 'object',
|
||||||
if (input.framework_type) args['framework_type'] = input.framework_type;
|
properties: {
|
||||||
return callCodecontext({ toolName: 'get_symbol_info', args, projectPath }, fetcher);
|
symbol_name: {
|
||||||
}
|
type: 'string',
|
||||||
|
description: 'The symbol name to look up (case-sensitive).',
|
||||||
export const getSymbolInfo: ToolDef<GetSymbolInfoInputT> = {
|
},
|
||||||
name: 'get_symbol_info',
|
file_path: {
|
||||||
description: DESCRIPTION,
|
type: 'string',
|
||||||
inputSchema: GetSymbolInfoInput,
|
description: 'Narrow to a specific file when the symbol name is ambiguous.',
|
||||||
jsonSchema: {
|
},
|
||||||
type: 'function',
|
framework_type: {
|
||||||
function: {
|
type: 'string',
|
||||||
name: 'get_symbol_info',
|
description: 'Hint for framework-specific extraction (react|vue|svelte|django|fastapi|express|nest|…).',
|
||||||
description: DESCRIPTION,
|
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
symbol_name: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'The symbol name to look up (case-sensitive).',
|
|
||||||
},
|
|
||||||
file_path: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Narrow to a specific file when the symbol name is ambiguous.',
|
|
||||||
},
|
|
||||||
framework_type: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Hint for framework-specific extraction (react|vue|svelte|django|fastapi|express|nest|…).',
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
required: ['symbol_name'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
required: ['symbol_name'],
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => {
|
||||||
async execute(input, projectRoot) {
|
const args: Record<string, unknown> = { symbol_name: input.symbol_name };
|
||||||
return await executeGetSymbolInfo(input, projectRoot);
|
if (input.file_path) args['file_path'] = input.file_path;
|
||||||
},
|
if (input.framework_type) args['framework_type'] = input.framework_type;
|
||||||
};
|
return args;
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
export { getSymbolInfo, executeGetSymbolInfo };
|
||||||
|
|||||||
@@ -1,8 +1,5 @@
|
|||||||
// v1.12 Track B.2: codecontext wrapper — search_symbols.
|
|
||||||
|
|
||||||
import { z } from 'zod';
|
import { z } from 'zod';
|
||||||
import type { ToolDef } from '../../tools.js';
|
import { makeCodecontextTool } from './factory.js';
|
||||||
import { callCodecontext, type CodecontextResponse } from '../../codecontext_client.js';
|
|
||||||
|
|
||||||
export const SearchSymbolsInput = z.object({
|
export const SearchSymbolsInput = z.object({
|
||||||
query: z.string().min(1),
|
query: z.string().min(1),
|
||||||
@@ -21,57 +18,45 @@ const DESCRIPTION =
|
|||||||
|
|
||||||
const DEFAULT_LIMIT = 20;
|
const DEFAULT_LIMIT = 20;
|
||||||
|
|
||||||
export async function executeSearchSymbols(
|
const { toolDef: searchSymbols, execute: executeSearchSymbols } =
|
||||||
input: SearchSymbolsInputT,
|
makeCodecontextTool<SearchSymbolsInputT>({
|
||||||
projectPath: string,
|
name: 'search_symbols',
|
||||||
fetcher: typeof fetch = fetch,
|
schema: SearchSymbolsInput,
|
||||||
): Promise<CodecontextResponse> {
|
description: DESCRIPTION,
|
||||||
const args: Record<string, unknown> = {
|
jsonParameters: {
|
||||||
query: input.query,
|
type: 'object',
|
||||||
limit: input.limit ?? DEFAULT_LIMIT,
|
properties: {
|
||||||
};
|
query: { type: 'string', description: 'Substring or name fragment to match.' },
|
||||||
if (input.file_type) args['file_type'] = input.file_type;
|
file_type: {
|
||||||
if (input.symbol_type) args['symbol_type'] = input.symbol_type;
|
type: 'string',
|
||||||
if (input.framework_type) args['framework_type'] = input.framework_type;
|
description: 'Filter by file extension or language (e.g. "ts", "py", "go").',
|
||||||
return callCodecontext({ toolName: 'search_symbols', args, projectPath }, fetcher);
|
},
|
||||||
}
|
symbol_type: {
|
||||||
|
type: 'string',
|
||||||
export const searchSymbols: ToolDef<SearchSymbolsInputT> = {
|
description: 'Filter by kind: function|class|method|variable|type|interface.',
|
||||||
name: 'search_symbols',
|
},
|
||||||
description: DESCRIPTION,
|
framework_type: {
|
||||||
inputSchema: SearchSymbolsInput,
|
type: 'string',
|
||||||
jsonSchema: {
|
description: 'Filter by framework context (react|vue|svelte|…).',
|
||||||
type: 'function',
|
},
|
||||||
function: {
|
limit: {
|
||||||
name: 'search_symbols',
|
type: 'integer',
|
||||||
description: DESCRIPTION,
|
description: `Max matches to return. Defaults to ${DEFAULT_LIMIT}.`,
|
||||||
parameters: {
|
|
||||||
type: 'object',
|
|
||||||
properties: {
|
|
||||||
query: { type: 'string', description: 'Substring or name fragment to match.' },
|
|
||||||
file_type: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Filter by file extension or language (e.g. "ts", "py", "go").',
|
|
||||||
},
|
|
||||||
symbol_type: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Filter by kind: function|class|method|variable|type|interface.',
|
|
||||||
},
|
|
||||||
framework_type: {
|
|
||||||
type: 'string',
|
|
||||||
description: 'Filter by framework context (react|vue|svelte|…).',
|
|
||||||
},
|
|
||||||
limit: {
|
|
||||||
type: 'integer',
|
|
||||||
description: `Max matches to return. Defaults to ${DEFAULT_LIMIT}.`,
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
required: ['query'],
|
|
||||||
additionalProperties: false,
|
|
||||||
},
|
},
|
||||||
|
required: ['query'],
|
||||||
|
additionalProperties: false,
|
||||||
},
|
},
|
||||||
},
|
mapArgs: (input) => {
|
||||||
async execute(input, projectRoot) {
|
const args: Record<string, unknown> = {
|
||||||
return await executeSearchSymbols(input, projectRoot);
|
query: input.query,
|
||||||
},
|
limit: input.limit ?? DEFAULT_LIMIT,
|
||||||
};
|
};
|
||||||
|
if (input.file_type) args['file_type'] = input.file_type;
|
||||||
|
if (input.symbol_type) args['symbol_type'] = input.symbol_type;
|
||||||
|
if (input.framework_type) args['framework_type'] = input.framework_type;
|
||||||
|
return args;
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
export { searchSymbols, executeSearchSymbols };
|
||||||
|
|||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user