Multi-topic batch. The big-ticket item is the skills audit; the rest are smaller patches that compounded during the audit work. ## Skills audit (rules→recipes split) Vendored all 26 skills from /home/samkintop/opt/skills/ into data/skills/ (the boocode-repo-local skill library — see docker-compose change below). Audited via 5 parallel Claude Code agent-teams running the mgechev/skills-best-practices 4-step protocol (Discovery → Logic → Edge Case → self-Architecture-Refinement) per skill, ~2 min wall-clock vs the ~3.7-hour serial estimate. Result: 14 skills surviving (renamed to gerund form, frontmatter matched), 11 deleted (duplicates, BooCode-irrelevant patterns, Claude-already-does- natively), 1 migrated to BOOCHAT.md/BOOCODER.md as an always-true rule (verification-before-completion). Each surviving skill had its description refined to fix specific trigger gaps surfaced by the protocol — 4 real-bug findings landed (dead refs, stale tags, broken sub-file references in the original vendored content). Audit decisions documented in openspec/changes/v1.13.12-skills-audit/ audit-notes.md. Convention codified in BOOCHAT.md/BOOCODER.md "rules vs recipes" sections — future workflow rules go to those files (100% present), recipes stay in data/skills/ (~6% invoke rate in multi-turn per the Codeminer42 measurement). ## Token tracking + stale-stream banner fix (same root cause) ws-frames.ts IsoTimestamp was z.string().min(1) but postgres returns timestamp columns as JS Date objects. Every message_complete / session_updated / chat_updated frame was failing the v1.13.11 Zod gate and being silently dropped. Symptoms: token tracking blank in the UI (no usage frames landed); the 60s no-token-activity timer tripped the stale-stream banner because the frontend's local message state never saw status='streaming' flip to 'complete'. Fix: z.preprocess(v => v instanceof Date ? v.toISOString() : v, z.string().min(1)) applied to the IsoTimestamp primitive. Centralized, no publisher changes, works identically server + web (the parity test still passes). ## Codecontext .codecontextignore auto-install services/codecontext_client.ts now copies the codecontext/.codecontextignore.template into any project's root on the first call to that project if no .codecontextignore exists. One file written per project, idempotent (in-memory Set guard + access-check), silent fallback on read-only project. Stops the upstream empty-source- file parser crash on foreign projects' node_modules — previously required manually copying the template per project. ## Tool-call budget cap 30 → 50 services/inference/budget.ts: BUDGET_READ_ONLY and BUDGET_NO_AGENT bumped to 50 (from 30). BUDGET_NON_READ_ONLY stays at 10 (no write tools landed yet). Real recon sessions were hitting 30 with ~3 turns wasted on codecontext parse failures; legitimate need was ~27, and Architect-class system overviews want deeper recon. Headroom of 20 absorbs failure-retry turns without changing the safety floor — the doom-loop guard (3 identical calls → abort) catches the actual failure mode this cap was guarding against. v1.14 (Phase C outer agent loop) will supersede this via per-agent agent.steps. Throwaway-ish patch but unblocks deeper recon today. ## UI cleanups - ChatPane queued-message dropdown removed. Each queued message now has three buttons: edit (pop back into ChatInput via sendToChat event), force-send (was the dropdown's only useful action), and cancel. Default behavior (send when streaming completes) needs no UI — it's the implicit do-nothing path. - ChatThroughput removed from desktop tab strip (ChatTabBar.tsx). Mobile tab switcher still shows it. ## Plumbing - .gitignore: data/* + !data/AGENTS.md + !data/skills/ negation patterns so the vendored skill library + agent registry become git-tracked while session DB state stays out. - docker-compose.yml: removed /opt/skills:/data/skills override mount. Skills now live in the boocode repo at data/skills/, auditable per-batch. The host-level /opt/skills/ is preserved untouched for any other tools that read from it. - .codecontextignore at repo root: auto-installed when codecontext was first called against /opt/boocode itself; matches the template. - CLAUDE.md: updated to document the v1.13.11 publishFrame wrapper + message_parts table + tool_cost_stats view + DB-integration test pattern + host-side smoke endpoint quirk. (Pre-existing in working tree before this batch; shipped here for completeness.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
149 lines
4.5 KiB
Bash
Executable File
149 lines
4.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Start the brainstorm server and output connection info
|
|
# Usage: start-server.sh [--project-dir <path>] [--host <bind-host>] [--url-host <display-host>] [--foreground] [--background]
|
|
#
|
|
# Starts server on a random high port, outputs JSON with URL.
|
|
# Each session gets its own directory to avoid conflicts.
|
|
#
|
|
# Options:
|
|
# --project-dir <path> Store session files under <path>/.superpowers/brainstorm/
|
|
# instead of /tmp. Files persist after server stops.
|
|
# --host <bind-host> Host/interface to bind (default: 127.0.0.1).
|
|
# Use 0.0.0.0 in remote/containerized environments.
|
|
# --url-host <host> Hostname shown in returned URL JSON.
|
|
# --foreground Run server in the current terminal (no backgrounding).
|
|
# --background Force background mode (overrides Codex auto-foreground).
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
|
|
|
# Parse arguments
|
|
PROJECT_DIR=""
|
|
FOREGROUND="false"
|
|
FORCE_BACKGROUND="false"
|
|
BIND_HOST="127.0.0.1"
|
|
URL_HOST=""
|
|
while [[ $# -gt 0 ]]; do
|
|
case "$1" in
|
|
--project-dir)
|
|
PROJECT_DIR="$2"
|
|
shift 2
|
|
;;
|
|
--host)
|
|
BIND_HOST="$2"
|
|
shift 2
|
|
;;
|
|
--url-host)
|
|
URL_HOST="$2"
|
|
shift 2
|
|
;;
|
|
--foreground|--no-daemon)
|
|
FOREGROUND="true"
|
|
shift
|
|
;;
|
|
--background|--daemon)
|
|
FORCE_BACKGROUND="true"
|
|
shift
|
|
;;
|
|
*)
|
|
echo "{\"error\": \"Unknown argument: $1\"}"
|
|
exit 1
|
|
;;
|
|
esac
|
|
done
|
|
|
|
if [[ -z "$URL_HOST" ]]; then
|
|
if [[ "$BIND_HOST" == "127.0.0.1" || "$BIND_HOST" == "localhost" ]]; then
|
|
URL_HOST="localhost"
|
|
else
|
|
URL_HOST="$BIND_HOST"
|
|
fi
|
|
fi
|
|
|
|
# Some environments reap detached/background processes. Auto-foreground when detected.
|
|
if [[ -n "${CODEX_CI:-}" && "$FOREGROUND" != "true" && "$FORCE_BACKGROUND" != "true" ]]; then
|
|
FOREGROUND="true"
|
|
fi
|
|
|
|
# Windows/Git Bash reaps nohup background processes. Auto-foreground when detected.
|
|
if [[ "$FOREGROUND" != "true" && "$FORCE_BACKGROUND" != "true" ]]; then
|
|
case "${OSTYPE:-}" in
|
|
msys*|cygwin*|mingw*) FOREGROUND="true" ;;
|
|
esac
|
|
if [[ -n "${MSYSTEM:-}" ]]; then
|
|
FOREGROUND="true"
|
|
fi
|
|
fi
|
|
|
|
# Generate unique session directory
|
|
SESSION_ID="$$-$(date +%s)"
|
|
|
|
if [[ -n "$PROJECT_DIR" ]]; then
|
|
SESSION_DIR="${PROJECT_DIR}/.superpowers/brainstorm/${SESSION_ID}"
|
|
else
|
|
SESSION_DIR="/tmp/brainstorm-${SESSION_ID}"
|
|
fi
|
|
|
|
STATE_DIR="${SESSION_DIR}/state"
|
|
PID_FILE="${STATE_DIR}/server.pid"
|
|
LOG_FILE="${STATE_DIR}/server.log"
|
|
|
|
# Create fresh session directory with content and state peers
|
|
mkdir -p "${SESSION_DIR}/content" "$STATE_DIR"
|
|
|
|
# Kill any existing server
|
|
if [[ -f "$PID_FILE" ]]; then
|
|
old_pid=$(cat "$PID_FILE")
|
|
kill "$old_pid" 2>/dev/null
|
|
rm -f "$PID_FILE"
|
|
fi
|
|
|
|
cd "$SCRIPT_DIR"
|
|
|
|
# Resolve the harness PID (grandparent of this script).
|
|
# $PPID is the ephemeral shell the harness spawned to run us — it dies
|
|
# when this script exits. The harness itself is $PPID's parent.
|
|
OWNER_PID="$(ps -o ppid= -p "$PPID" 2>/dev/null | tr -d ' ')"
|
|
if [[ -z "$OWNER_PID" || "$OWNER_PID" == "1" ]]; then
|
|
OWNER_PID="$PPID"
|
|
fi
|
|
|
|
# Foreground mode for environments that reap detached/background processes.
|
|
if [[ "$FOREGROUND" == "true" ]]; then
|
|
echo "$$" > "$PID_FILE"
|
|
env BRAINSTORM_DIR="$SESSION_DIR" BRAINSTORM_HOST="$BIND_HOST" BRAINSTORM_URL_HOST="$URL_HOST" BRAINSTORM_OWNER_PID="$OWNER_PID" node server.cjs
|
|
exit $?
|
|
fi
|
|
|
|
# Start server, capturing output to log file
|
|
# Use nohup to survive shell exit; disown to remove from job table
|
|
nohup env BRAINSTORM_DIR="$SESSION_DIR" BRAINSTORM_HOST="$BIND_HOST" BRAINSTORM_URL_HOST="$URL_HOST" BRAINSTORM_OWNER_PID="$OWNER_PID" node server.cjs > "$LOG_FILE" 2>&1 &
|
|
SERVER_PID=$!
|
|
disown "$SERVER_PID" 2>/dev/null
|
|
echo "$SERVER_PID" > "$PID_FILE"
|
|
|
|
# Wait for server-started message (check log file)
|
|
for i in {1..50}; do
|
|
if grep -q "server-started" "$LOG_FILE" 2>/dev/null; then
|
|
# Verify server is still alive after a short window (catches process reapers)
|
|
alive="true"
|
|
for _ in {1..20}; do
|
|
if ! kill -0 "$SERVER_PID" 2>/dev/null; then
|
|
alive="false"
|
|
break
|
|
fi
|
|
sleep 0.1
|
|
done
|
|
if [[ "$alive" != "true" ]]; then
|
|
echo "{\"error\": \"Server started but was killed. Retry in a persistent terminal with: $SCRIPT_DIR/start-server.sh${PROJECT_DIR:+ --project-dir $PROJECT_DIR} --host $BIND_HOST --url-host $URL_HOST --foreground\"}"
|
|
exit 1
|
|
fi
|
|
grep "server-started" "$LOG_FILE" | head -1
|
|
exit 0
|
|
fi
|
|
sleep 0.1
|
|
done
|
|
|
|
# Timeout - server didn't start
|
|
echo '{"error": "Server failed to start within 5 seconds"}'
|
|
exit 1
|