Multi-topic batch. The big-ticket item is the skills audit; the rest are smaller patches that compounded during the audit work. ## Skills audit (rules→recipes split) Vendored all 26 skills from /home/samkintop/opt/skills/ into data/skills/ (the boocode-repo-local skill library — see docker-compose change below). Audited via 5 parallel Claude Code agent-teams running the mgechev/skills-best-practices 4-step protocol (Discovery → Logic → Edge Case → self-Architecture-Refinement) per skill, ~2 min wall-clock vs the ~3.7-hour serial estimate. Result: 14 skills surviving (renamed to gerund form, frontmatter matched), 11 deleted (duplicates, BooCode-irrelevant patterns, Claude-already-does- natively), 1 migrated to BOOCHAT.md/BOOCODER.md as an always-true rule (verification-before-completion). Each surviving skill had its description refined to fix specific trigger gaps surfaced by the protocol — 4 real-bug findings landed (dead refs, stale tags, broken sub-file references in the original vendored content). Audit decisions documented in openspec/changes/v1.13.12-skills-audit/ audit-notes.md. Convention codified in BOOCHAT.md/BOOCODER.md "rules vs recipes" sections — future workflow rules go to those files (100% present), recipes stay in data/skills/ (~6% invoke rate in multi-turn per the Codeminer42 measurement). ## Token tracking + stale-stream banner fix (same root cause) ws-frames.ts IsoTimestamp was z.string().min(1) but postgres returns timestamp columns as JS Date objects. Every message_complete / session_updated / chat_updated frame was failing the v1.13.11 Zod gate and being silently dropped. Symptoms: token tracking blank in the UI (no usage frames landed); the 60s no-token-activity timer tripped the stale-stream banner because the frontend's local message state never saw status='streaming' flip to 'complete'. Fix: z.preprocess(v => v instanceof Date ? v.toISOString() : v, z.string().min(1)) applied to the IsoTimestamp primitive. Centralized, no publisher changes, works identically server + web (the parity test still passes). ## Codecontext .codecontextignore auto-install services/codecontext_client.ts now copies the codecontext/.codecontextignore.template into any project's root on the first call to that project if no .codecontextignore exists. One file written per project, idempotent (in-memory Set guard + access-check), silent fallback on read-only project. Stops the upstream empty-source- file parser crash on foreign projects' node_modules — previously required manually copying the template per project. ## Tool-call budget cap 30 → 50 services/inference/budget.ts: BUDGET_READ_ONLY and BUDGET_NO_AGENT bumped to 50 (from 30). BUDGET_NON_READ_ONLY stays at 10 (no write tools landed yet). Real recon sessions were hitting 30 with ~3 turns wasted on codecontext parse failures; legitimate need was ~27, and Architect-class system overviews want deeper recon. Headroom of 20 absorbs failure-retry turns without changing the safety floor — the doom-loop guard (3 identical calls → abort) catches the actual failure mode this cap was guarding against. v1.14 (Phase C outer agent loop) will supersede this via per-agent agent.steps. Throwaway-ish patch but unblocks deeper recon today. ## UI cleanups - ChatPane queued-message dropdown removed. Each queued message now has three buttons: edit (pop back into ChatInput via sendToChat event), force-send (was the dropdown's only useful action), and cancel. Default behavior (send when streaming completes) needs no UI — it's the implicit do-nothing path. - ChatThroughput removed from desktop tab strip (ChatTabBar.tsx). Mobile tab switcher still shows it. ## Plumbing - .gitignore: data/* + !data/AGENTS.md + !data/skills/ negation patterns so the vendored skill library + agent registry become git-tracked while session DB state stays out. - docker-compose.yml: removed /opt/skills:/data/skills override mount. Skills now live in the boocode repo at data/skills/, auditable per-batch. The host-level /opt/skills/ is preserved untouched for any other tools that read from it. - .codecontextignore at repo root: auto-installed when codecontext was first called against /opt/boocode itself; matches the template. - CLAUDE.md: updated to document the v1.13.11 publishFrame wrapper + message_parts table + tool_cost_stats view + DB-integration test pattern + host-side smoke endpoint quirk. (Pre-existing in working tree before this batch; shipped here for completeness.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
294 lines
11 KiB
TypeScript
294 lines
11 KiB
TypeScript
import { useCallback, useEffect, useRef, useState } from 'react';
|
|
import { Pencil, Send, Square, X } from 'lucide-react';
|
|
import { toast } from 'sonner';
|
|
import { api } from '@/api/client';
|
|
import { useSessionStream } from '@/hooks/useSessionStream';
|
|
import { MessageList } from '@/components/MessageList';
|
|
import { ChatInput } from '@/components/ChatInput';
|
|
import { StaleStreamBanner } from '@/components/StaleStreamBanner';
|
|
import { sendToChat } from '@/lib/events';
|
|
|
|
interface Props {
|
|
sessionId: string;
|
|
chatId: string;
|
|
projectId: string;
|
|
// Batch 9: optional, threaded down to ChatInput's agent picker.
|
|
agentId?: string | null;
|
|
onAgentChange?: (agentId: string | null) => void | Promise<void>;
|
|
sessionChats?: import('@/api/types').Chat[];
|
|
// v1.9: threaded down to ChatInput's + menu (Web search quick toggle).
|
|
// null means "inherit project default" — ChatInput PATCHes with the
|
|
// opposite of the effective value.
|
|
webSearchEnabled?: boolean | null;
|
|
}
|
|
|
|
export function ChatPane({ sessionId, chatId, projectId, agentId, onAgentChange, sessionChats, webSearchEnabled }: Props) {
|
|
const stream = useSessionStream(sessionId);
|
|
const lastErrorRef = useRef<string | null>(null);
|
|
const [queue, setQueue] = useState<string[]>([]);
|
|
const processingRef = useRef(false);
|
|
|
|
useEffect(() => {
|
|
if (stream.error && stream.error !== lastErrorRef.current) {
|
|
lastErrorRef.current = stream.error;
|
|
toast.error(stream.error);
|
|
}
|
|
if (!stream.error) {
|
|
lastErrorRef.current = null;
|
|
}
|
|
}, [stream.error]);
|
|
|
|
const chatMessages = stream.messages.filter((m) => m.chat_id === chatId);
|
|
const streaming = chatMessages.some((m) => m.status === 'streaming');
|
|
|
|
// v1.12.3: stale-stream detection. Watches the (at most one) streaming
|
|
// assistant row. If its content length doesn't grow for STALE_THRESHOLD_MS,
|
|
// assume the upstream call is dead and surface the recovery banner. We use
|
|
// content length as the activity signal because every token delta extends
|
|
// it; last_seq isn't currently bumped per delta.
|
|
const STALE_THRESHOLD_MS = 60_000;
|
|
const streamingMsg = chatMessages.find((m) => m.status === 'streaming' && m.role === 'assistant');
|
|
const streamingId = streamingMsg?.id ?? null;
|
|
const streamingLen = streamingMsg?.content.length ?? 0;
|
|
const lastActivityRef = useRef<{ id: string; len: number; at: number } | null>(null);
|
|
const [stale, setStale] = useState(false);
|
|
useEffect(() => {
|
|
if (!streamingId) {
|
|
lastActivityRef.current = null;
|
|
setStale(false);
|
|
return;
|
|
}
|
|
const prev = lastActivityRef.current;
|
|
if (!prev || prev.id !== streamingId || prev.len !== streamingLen) {
|
|
lastActivityRef.current = { id: streamingId, len: streamingLen, at: Date.now() };
|
|
setStale(false);
|
|
}
|
|
const interval = setInterval(() => {
|
|
const a = lastActivityRef.current;
|
|
if (!a) return;
|
|
if (Date.now() - a.at >= STALE_THRESHOLD_MS) {
|
|
setStale(true);
|
|
}
|
|
}, 5_000);
|
|
return () => clearInterval(interval);
|
|
}, [streamingId, streamingLen]);
|
|
// v1.11.5: per-chat model context limit comes from chat.model_context_limit
|
|
// populated by GET /api/sessions/:id/chats. Threaded into ChatInput so
|
|
// ContextBar can render a zero-state before the first assistant message.
|
|
const modelContextLimit =
|
|
sessionChats?.find((c) => c.id === chatId)?.model_context_limit ?? null;
|
|
|
|
// Auto-send next queued message when streaming completes
|
|
useEffect(() => {
|
|
if (streaming || queue.length === 0 || processingRef.current) return;
|
|
processingRef.current = true;
|
|
const next = queue[0]!;
|
|
setQueue((prev) => prev.slice(1));
|
|
api.messages.send(chatId, next)
|
|
.catch((err) => toast.error(err instanceof Error ? err.message : 'queue send failed'))
|
|
.finally(() => { processingRef.current = false; });
|
|
}, [streaming, queue, chatId]);
|
|
|
|
const handleSend = useCallback(async (content: string) => {
|
|
const trimmed = content.trim();
|
|
if (!trimmed) return;
|
|
if (trimmed === '/compact') {
|
|
try {
|
|
await api.chats.compact(chatId);
|
|
} catch (err) {
|
|
toast.error(err instanceof Error ? err.message : 'compact failed');
|
|
}
|
|
return;
|
|
}
|
|
if (streaming) {
|
|
setQueue((prev) => [...prev, trimmed]);
|
|
return;
|
|
}
|
|
await api.messages.send(chatId, trimmed);
|
|
}, [chatId, streaming]);
|
|
|
|
async function handleStop() {
|
|
try {
|
|
await api.chats.stop(chatId);
|
|
} catch (err) {
|
|
toast.error(err instanceof Error ? err.message : 'stop failed');
|
|
}
|
|
}
|
|
|
|
const handleDiscardStale = useCallback(async () => {
|
|
if (!streamingId) return;
|
|
try {
|
|
await api.chats.discardStale(chatId, streamingId);
|
|
setStale(false);
|
|
lastActivityRef.current = null;
|
|
} catch (err) {
|
|
// 409 (race) is benign — the row already terminated some other way.
|
|
const msg = err instanceof Error ? err.message : 'discard failed';
|
|
if (!msg.includes('409')) toast.error(msg);
|
|
setStale(false);
|
|
}
|
|
}, [chatId, streamingId]);
|
|
|
|
const handleRetryStale = useCallback(async () => {
|
|
if (!streamingId) return;
|
|
const lastUser = [...chatMessages].reverse().find((m) => m.role === 'user' && m.kind === 'message');
|
|
if (!lastUser) {
|
|
toast.error('no prior user message to retry');
|
|
return;
|
|
}
|
|
try {
|
|
await api.chats.discardStale(chatId, streamingId);
|
|
} catch (err) {
|
|
const msg = err instanceof Error ? err.message : 'discard failed';
|
|
if (!msg.includes('409')) {
|
|
toast.error(msg);
|
|
return;
|
|
}
|
|
}
|
|
setStale(false);
|
|
lastActivityRef.current = null;
|
|
try {
|
|
await api.messages.send(chatId, lastUser.content);
|
|
} catch (err) {
|
|
toast.error(err instanceof Error ? err.message : 'retry send failed');
|
|
}
|
|
}, [chatId, streamingId, chatMessages]);
|
|
|
|
const handleForceSend = useCallback(async (content: string) => {
|
|
const trimmed = content.trim();
|
|
if (!trimmed) return;
|
|
try {
|
|
await api.chats.forceSend(chatId, trimmed);
|
|
setQueue([]);
|
|
} catch (err) {
|
|
toast.error(err instanceof Error ? err.message : 'force send failed');
|
|
}
|
|
}, [chatId]);
|
|
|
|
// Batch 9.6: slash-command dispatch. Sent regardless of streaming state —
|
|
// matches the existing /compact precedent (which also fires immediately).
|
|
// Empty args go to the server as null; the server fills in a default user
|
|
// message ("Apply this skill.") so the model has something to act on.
|
|
const handleSlashCommand = useCallback(async (skillName: string, userMessage: string) => {
|
|
try {
|
|
await api.chats.skillInvoke(chatId, skillName, userMessage.length > 0 ? userMessage : null);
|
|
} catch (err) {
|
|
toast.error(err instanceof Error ? err.message : `/${skillName} failed`);
|
|
}
|
|
}, [chatId]);
|
|
|
|
function removeQueued(idx: number) {
|
|
setQueue((prev) => prev.filter((_, i) => i !== idx));
|
|
}
|
|
|
|
// v1.13.12: edit a queued message — pop it off the queue and push its text
|
|
// into ChatInput via sendToChat. ChatInput appends (or sets, if empty) and
|
|
// focuses; user re-sends, which re-queues if streaming is still active.
|
|
function editQueued(idx: number) {
|
|
const msg = queue[idx];
|
|
if (!msg) return;
|
|
setQueue((prev) => prev.filter((_, i) => i !== idx));
|
|
sendToChat.emit({ chat_id: chatId, text: msg });
|
|
}
|
|
|
|
async function forceSendQueued(idx: number) {
|
|
const msg = queue[idx];
|
|
if (!msg) return;
|
|
setQueue((prev) => prev.filter((_, i) => i !== idx));
|
|
try {
|
|
await api.chats.forceSend(chatId, msg);
|
|
} catch (err) {
|
|
toast.error(err instanceof Error ? err.message : 'force send failed');
|
|
}
|
|
}
|
|
|
|
return (
|
|
<div className="flex flex-col h-full min-h-0">
|
|
{/* v1.11.5: ContextBar moved into ChatInput (above the agent picker). */}
|
|
<MessageList messages={chatMessages} sessionChats={sessionChats} />
|
|
|
|
{/* Queued messages */}
|
|
{queue.length > 0 && (
|
|
<div className="border-t">
|
|
<div className="max-w-[1000px] mx-auto w-full px-4 py-1 space-y-1">
|
|
{queue.map((msg, i) => (
|
|
<div key={i} className="flex items-center gap-2 text-xs text-muted-foreground bg-muted/30 rounded px-2 py-1">
|
|
<span className="font-medium shrink-0">Queued:</span>
|
|
<span className="truncate flex-1">{msg}</span>
|
|
<button
|
|
type="button"
|
|
onClick={() => editQueued(i)}
|
|
className="inline-flex items-center justify-center p-0.5 hover:bg-muted rounded shrink-0 max-md:min-h-[44px] max-md:min-w-[44px]"
|
|
aria-label="Edit queued message"
|
|
title="Edit"
|
|
>
|
|
<Pencil size={12} />
|
|
</button>
|
|
<button
|
|
type="button"
|
|
onClick={() => void forceSendQueued(i)}
|
|
className="inline-flex items-center justify-center p-0.5 hover:bg-muted rounded shrink-0 max-md:min-h-[44px] max-md:min-w-[44px]"
|
|
aria-label="Force send queued message now"
|
|
title="Force send now"
|
|
>
|
|
<Send size={12} />
|
|
</button>
|
|
<button
|
|
type="button"
|
|
onClick={() => removeQueued(i)}
|
|
className="inline-flex items-center justify-center p-0.5 hover:bg-muted rounded shrink-0 max-md:min-h-[44px] max-md:min-w-[44px]"
|
|
aria-label="Cancel queued message"
|
|
title="Cancel"
|
|
>
|
|
<X size={12} />
|
|
</button>
|
|
</div>
|
|
))}
|
|
</div>
|
|
</div>
|
|
)}
|
|
|
|
{/* Stop button when streaming */}
|
|
{streaming && (
|
|
<div className="border-t py-1">
|
|
<div className="max-w-[1000px] mx-auto w-full flex justify-center">
|
|
<button
|
|
type="button"
|
|
onClick={() => void handleStop()}
|
|
className="flex items-center gap-1.5 text-xs px-3 py-1 rounded-full border hover:bg-muted text-muted-foreground hover:text-foreground max-md:min-h-[44px] max-md:px-5"
|
|
>
|
|
<Square size={10} className="fill-current" />
|
|
Stop generating
|
|
</button>
|
|
</div>
|
|
</div>
|
|
)}
|
|
|
|
{stale && streamingId && (
|
|
<StaleStreamBanner
|
|
onRetry={() => void handleRetryStale()}
|
|
onDiscard={() => void handleDiscardStale()}
|
|
/>
|
|
)}
|
|
|
|
<ChatInput
|
|
disabled={false}
|
|
projectId={projectId}
|
|
sessionId={sessionId}
|
|
agentId={agentId}
|
|
onAgentChange={onAgentChange}
|
|
webSearchEnabled={webSearchEnabled}
|
|
onSend={handleSend}
|
|
onForceSend={streaming ? handleForceSend : undefined}
|
|
onSlashCommand={handleSlashCommand}
|
|
chatId={chatId}
|
|
chatLabel={sessionChats?.find((c) => c.id === chatId)?.name ?? 'Chat'}
|
|
// v1.11.5: feed ContextBar (mounted inside ChatInput). messages
|
|
// drives latest-pair walk; modelContextLimit powers the zero-state.
|
|
messages={chatMessages}
|
|
modelContextLimit={modelContextLimit}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|