indifferentketchup
5c61cc7281
Old hardcoded MAX_TOOL_LOOP_DEPTH=15 replaced by per-agent max_tool_calls (1-100, AGENTS.md frontmatter) with defaults: 30 for read-only-only agents, 10 for agents that include any non-read-only tool, 15 for raw chat. When the loop hits cap, fire one final summary call with tools disabled, stream the wrap-up into the in-flight assistant message, then insert a system sentinel with metadata.kind='cap_hit'. The sentinel renders an amber bubble with a Continue button (latest sentinel only) that POSTs to a new /api/chats/:id/continue route to extend. Hard ceiling: 3 cap-hits per chat (2 continues max) — third sentinel reports can_continue=false. Error frames carry a machine-readable reason code alongside human error text. Failed messages persist the reason via metadata.kind='error' so the bubble renders specifics on reload (WS error frame is one-shot). Tool call UI rewired: ToolCallLine renders inline (↳ name args spinner/check/✗, expand-on-tap for args+result); ToolCallGroup collapses 3+ consecutive same-tool runs into a compact card. MessageList owns a three-pass pre-render (flatten + fold tool results onto matching runs by id + group same-tool runs + number sentinels). MessageBubble drops tool rendering and adds the sentinel / error-reason branches. ToolCallCard deleted. Roadmap follow-up logged: add explicit max_tool_calls: 30 to the 6 agents in /data/AGENTS.md and /opt/boocode/AGENTS.md post-ship for discoverability (defaults handle behavior identically). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
65 lines
2.2 KiB
TypeScript
65 lines
2.2 KiB
TypeScript
import { useState } from 'react';
|
|
import { ChevronRight } from 'lucide-react';
|
|
import { ToolCallLine, runStatus, type ToolRun } from './ToolCallLine';
|
|
|
|
interface Props {
|
|
// All runs must share the same tool name. Caller (MessageList grouping
|
|
// pass) enforces that invariant.
|
|
runs: ToolRun[];
|
|
}
|
|
|
|
export function ToolCallGroup({ runs }: Props) {
|
|
const [open, setOpen] = useState(false);
|
|
if (runs.length === 0) return null;
|
|
const toolName = runs[0]!.call.name;
|
|
const count = runs.length;
|
|
|
|
// Group-level status: pending if any are still running, error if any
|
|
// finished with an error, otherwise success. Matches the visual the user
|
|
// gets when scanning a long run of greps / view_files.
|
|
let pending = 0;
|
|
let errored = 0;
|
|
for (const r of runs) {
|
|
const s = runStatus(r);
|
|
if (s === 'pending') pending += 1;
|
|
else if (s === 'error') errored += 1;
|
|
}
|
|
const summaryParts: string[] = [];
|
|
if (pending > 0) summaryParts.push(`${pending} running`);
|
|
if (errored > 0) summaryParts.push(`${errored} failed`);
|
|
const summary = summaryParts.length > 0 ? ` (${summaryParts.join(', ')})` : '';
|
|
|
|
return (
|
|
<div className="rounded border border-border/60 bg-muted/20 text-xs">
|
|
<button
|
|
type="button"
|
|
onClick={() => setOpen((v) => !v)}
|
|
className="w-full flex items-center gap-1.5 px-2 py-1 hover:bg-muted/40 text-left"
|
|
>
|
|
<ChevronRight
|
|
className={`size-3 text-muted-foreground/60 shrink-0 transition-transform ${open ? 'rotate-90' : ''}`}
|
|
/>
|
|
<span className="text-muted-foreground/60 select-none shrink-0">⊞</span>
|
|
<span className="font-mono text-foreground/90">
|
|
{count} {toolName} call{count === 1 ? '' : 's'}
|
|
</span>
|
|
{summary && (
|
|
<span className="text-muted-foreground truncate">{summary}</span>
|
|
)}
|
|
<span className="ml-auto text-muted-foreground/60 shrink-0">tap</span>
|
|
</button>
|
|
{open && (
|
|
<div className="border-t border-border/40 px-2 py-1 space-y-0.5">
|
|
{runs.map((run, i) => (
|
|
<ToolCallLine
|
|
key={`${run.call.id}-${i}`}
|
|
run={run}
|
|
insideGroup
|
|
/>
|
|
))}
|
|
</div>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|