simplify: prune dead code, dedup gmail send, drop neutered log stubs

- Remove no-op log stubs (logGmail, logAutomation, logSecurity, logSystem)
  and ~17 callsites; dead counters in tickets.js and gmail-poll.js go too
- Dedup three near-identical Gmail send paths into sendThreadedEmail helper
- Drop dead Mongoose fields: broccoliniTicketId, lastSyncedBroccoliniArticleId,
  renameCount, renameWindowStart, reminderSent, staffChannelId,
  unclaimedRemindersSent, lastMessageAuthorIsStaff
- Drop dead config fields and their .env.example entries
- Inline api/botClient.js (3-line wrapper, 2 callers)
- Trim unused exports across utils.js, tickets.js, configSchema.js, debugLog.js
- Fix handlers/messages.js to use isStaff() — old partial check ignored
  ADDITIONAL_STAFF_ROLES, so those members were treated as customers
- Drop unused deps p-queue + dotenv-expand; move mongodb to devDependencies

Net: -583 LOC source + -57 LOC lockfile. All 23 modules load clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

handlers/buttons.js

@@ -16,14 +16,14 @@ const {
 } = require('discord.js');
 const { mongoose } = require('../db-connection');
 const { CONFIG } = require('../config');
-const { makeTicketName, resolveCreatorNickname, getOrCreateTicketCategory, cleanupEmptyOverflowCategory, checkTicketCreationRateLimit, getSenderLocal, toDiscordSafeName } = require('../services/tickets');
+const { makeTicketName, resolveCreatorNickname, getOrCreateTicketCategory, cleanupEmptyOverflowCategory, checkTicketCreationRateLimit, toDiscordSafeName } = require('../services/tickets');
 const { sendTicketClosedEmail } = require('../services/gmail');
 const { getTicketActionRow } = require('../utils/ticketComponents');
-const { sanitizeEmbedText, truncateEmbedDescription, truncateEmbedField, enforceEmbedLimit } = require('../utils');
+const { sanitizeEmbedText, truncateEmbedDescription, enforceEmbedLimit } = require('../utils');
 const { enqueueRename, enqueueSend } = require('../services/channelQueue');
 const { runEscalation, runDeescalation } = require('./commands');
 const { pendingCloses } = require('./pendingCloses');
-const { logError, logSystem } = require('../services/debugLog');
+const { logError } = require('../services/debugLog');
 
 const Ticket = mongoose.model('Ticket');
 const Transcript = mongoose.model('Transcript');
@@ -328,8 +328,6 @@ async function handleClaim(interaction, ticket) {
   }
 
   if (isClaimed && !isClaimedByMe && !CONFIG.ALLOW_CLAIM_OVERWRITE) {
-    const { logSecurity } = require('../services/debugLog');
-    logSecurity('Unauthorized button attempt', interaction.user, interaction.customId).catch(() => {});
     return interaction.reply({
       content: `This ticket is already claimed by **${freshTicket.claimedBy}**.`,
       ephemeral: true
@@ -510,13 +508,8 @@ async function handleConfirmClose(interaction, ticket, sendEmail = true) {
           files: [dmFile]
         });
       } catch (dmErr) {
-        // 50007 = "Cannot send messages to this user" — user has DMs off. Expected class; debug-level only.
-        if (dmErr?.code === 50007) {
-          logSystem('Transcript DM skipped (recipient has DMs disabled)', [
-            { name: 'User', value: creatorId },
-            { name: 'Channel', value: channelName }
-          ]).catch(() => {});
-        } else {
+        // 50007 = "Cannot send messages to this user" — user has DMs off. Expected; ignore.
+        if (dmErr?.code !== 50007) {
           logError('transcript-dm', dmErr).catch(() => {});
         }
       }
@@ -662,8 +655,6 @@ async function handleTicketModal(interaction) {
       parentCategoryId: parentCategoryIdForTicket
     });
 
-    const displayName = interaction.member?.displayName || interaction.user.username;
-
     const descTrimmed = description.length > 500 ? description.slice(0, 497) + '…' : description;
 
     const welcomeEmbed = new EmbedBuilder()

handlers/commands.js

@@ -3,7 +3,6 @@
  */
 const {
   ChannelType,
-  ActionRowBuilder,
   ButtonBuilder,
   ButtonStyle,
   AttachmentBuilder,
@@ -18,7 +17,7 @@ const { sendTicketNotificationEmail } = require('../services/gmail');
 const { getTicketActionRow } = require('../utils/ticketComponents');
 const { enqueueRename, enqueueMove, enqueueSend } = require('../services/channelQueue');
 const { setNotifyDm } = require('../services/staffSettings');
-const { logTicketEvent, logSecurity, logError } = require('../services/debugLog');
+const { logError } = require('../services/debugLog');
 const { pendingCloses } = require('./pendingCloses');
 
 const Ticket = mongoose.model('Ticket');
@@ -51,7 +50,6 @@ async function requireStaffRole(interaction) {
     content: `This command is only available to the support team (${roleMention}).`,
     ephemeral: true
   });
-  logSecurity('Unauthorized command attempt', interaction.user, interaction.commandName).catch(() => {});
   return true;
 }
 
@@ -130,7 +128,6 @@ async function runEscalation(interaction, ticket, nextTier, reason) {
         ticket,
         null,
         emailBody,
-        escalatorName,
         interaction.user.id
       );
     } catch (emailErr) {

handlers/messages.js

@@ -3,7 +3,7 @@
  */
 const { mongoose } = require('../db-connection');
 const { CONFIG } = require('../config');
-const { extractRawEmail } = require('../utils');
+const { extractRawEmail, isStaff } = require('../utils');
 const { getGmailClient, sendGmailReply } = require('../services/gmail');
 const { updateTicketActivity } = require('../services/tickets');
 const { getNotifyDm } = require('../services/staffSettings');
@@ -19,12 +19,11 @@ async function handleDiscordReply(m) {
   const ticket = await Ticket.findOne({ discordThreadId: m.channel.id }).lean();
   if (!ticket) return;
 
-  // Track whether last message is from staff or customer
   const memberForCheck = await m.guild.members.fetch(m.author.id).catch(() => null);
-  const isStaffMember = memberForCheck && CONFIG.ROLE_ID_TO_PING && memberForCheck.roles.cache.has(CONFIG.ROLE_ID_TO_PING);
+  const isStaffMember = isStaff(memberForCheck);
   Ticket.updateOne(
     { discordThreadId: m.channel.id },
-    { $set: { lastMessageAuthorIsStaff: !!isStaffMember, lastActivity: new Date() } }
+    { $set: { lastActivity: new Date() } }
   ).catch(() => {});
 
   // DM the claimer if they have notifydm on and a non-staff user replied.