Commit Graph

16 Commits

Author SHA1 Message Date
2fab3b97bf Remove dead/stale code, dedup close+escalation paths
Dead/stale removals (grep-confirmed no consumers):
- config: drop 9 unread CONFIG keys (ROLE_TO_PING_ID, SIGNATURE,
  REMINDER_*, RENAME_LOG_CHANNEL_ID, SETTINGS_*); remove their
  ALLOWED_CONFIG_KEYS entries and the orphaned settings-site UI fields
- configSchema: delete unreachable json/string_or_json validators
- models: drop unused ticketTag field
- gmail-poll: remove unused isPollSuspended export
- utils: remove dead htmlToTextWithBlocks/decodeHtmlEntities/BLOCK_TAG_REGEX
- internalApi: remove router._allowedKeys (test it served is gone)
- discord client: drop unused GuildPresences privileged intent
- broccolini-discord: remove dormant /api 503 gate (no /api routes)

Fixes:
- context-menu ticket create now uses makeTicketName('unclaimed', ...)
  instead of the contract-violating ticket-<n> name
- drop write-only pending.userId from both close paths

Dedup / simplify:
- new services/transcript.js shares the transcript text/date/header
  builders between the button and force-close paths (had drifted)
- resolveEscalationCategoryId() replaces 3 copies of the category logic
- ticketChannelOverwrites() shares the create-permission array between
  the two interactive ticket-create paths
- finalizeBody() shares the email-cleanup tail in parseGmailMessage
- getTicketActionRow drops its never-passed options arg;
  sendTicketNotificationEmail drops its always-null subjectLine arg
- hoist invariant guild lookup out of the auto-close/unclaim loops
- drop redundant lastActivity write (and now-dead updateTicketActivity)
- /help lists all current commands and the right-click apps
2026-06-02 19:59:14 +00:00
2a04e3964c trim settings-site to match stripped bot
- delete public/js/notifications.js (521 LOC)
- remove notifications/patterns/surge/chat/priority/bosscord/accountinfo/threads UI sections
- remove 3 /api/notifications/* proxy routes from server.js
- untrack settings-site backup files from git
- ~926 LOC removed from settings-site
2026-04-21 19:34:10 +00:00
1a46fb696a cleanup: remove strip backup files 2026-04-21 15:57:51 +00:00
298cf13d5c settings site changes 2026-04-21 15:30:40 +00:00
8a45b59b28 phase 9 notification toggles (per-alert, per-category, master; default-disabled) 2026-04-18 23:51:59 +00:00
39a5482516 phase 8 server-side validation (configSchema, inline field errors, partial-success semantics) 2026-04-18 19:54:47 +00:00
23a02c87d9 settings-site: phase 6 accessibility (ARIA combobox/listbox pattern, keyboard nav, modal focus trap, toast a11y, contrast + typography fixes) 2026-04-18 19:30:15 +00:00
0f62fb9020 phase 5 dynamic alert registry (bot canonical, settings-site with fallback) 2026-04-18 19:14:51 +00:00
e2443fd94a settings-site: phase 4 client refactor (split app.js into focused modules, shared dropdown helper, strict-CSP-ready) 2026-04-18 18:04:46 +00:00
3e2bf919e9 settings-site: phase 2 correctness fixes (proxy helper, /healthz, datetime-local min, health polling) 2026-04-18 16:32:37 +00:00
84c7a50cc3 settings-site: phase 7 mobile responsiveness 2026-04-18 16:26:39 +00:00
21618efbad security hardening 2026-04-18 11:10:41 +00:00
indifferentketchup
7fff9192b4 queue 2026-04-09 09:49:19 -05:00
indifferentketchup
a4fb82620a notification changes 2026-04-08 09:22:47 -05:00
indifferentketchup
e93246cfde change escalation env 2026-04-07 10:43:15 -05:00
indifferentketchup
69c247ed1b huge changes 2026-04-07 01:43:06 -05:00