Add PvpDamageInformation insight

src/Analysis/ProjectZomboid/PvpDamageInformation.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace IndifferentKetchup\Codex\Analysis\ProjectZomboid;
+
+use IndifferentKetchup\Codex\Analysis\Information;
+use IndifferentKetchup\Codex\Analysis\PatternInsightInterface;
+use IndifferentKetchup\Codex\Pattern\ProjectZomboid\PvpPattern;
+
+class PvpDamageInformation extends Information implements PatternInsightInterface
+{
+    public static function getPatterns(): array
+    {
+        return [PvpPattern::COMBAT_REAL];
+    }
+
+    public function setMatches(array $matches, mixed $patternKey): void
+    {
+        $this->setLabel('PvP combat');
+        $this->setValue(sprintf(
+            '%s hit %s with %s',
+            $matches['attacker'],
+            $matches['victim'],
+            $matches['weapon']
+        ));
+    }
+}

src/Pattern/ProjectZomboid/PvpPattern.php

@@ -24,4 +24,12 @@ class PvpPattern
     public const string COMBAT = '/^Combat: "(?<attacker>[^"]+)" \((?<ax>\d+),(?<ay>\d+),(?<az>-?\d+)\) hit "(?<victim>[^"]+)" \((?<vx>\d+),(?<vy>\d+),(?<vz>-?\d+)\) weapon="(?<weapon>[^"]+)" damage=(?<damage>-?\d+\.\d+)\.$/';
 
     public const string SAFETY = '/^Safety: "(?<player>[^"]+)" \((?<x>\d+),(?<y>\d+),(?<z>-?\d+)\) (?<verb>\w+) (?<state>true|false)\.$/';
+
+    /**
+     * Real-PvP combat: weapon!="zombie" AND damage>0. Filtering is in the
+     * regex itself so PatternAnalyser produces no insights for zombie/zero
+     * rows. Damage clause matches any positive non-zero float (rejects
+     * 0.000000 and any leading-minus value).
+     */
+    public const string COMBAT_REAL = '/Combat: "(?<attacker>[^"]+)" \([^)]+\) hit "(?<victim>[^"]+)" \([^)]+\) weapon="(?<weapon>(?!zombie")[^"]+)" damage=(?<damage>0\.0*[1-9][0-9]*|[1-9][0-9]*\.[0-9]+)/';
 }

test/tests/Games/ProjectZomboid/Analysis/PvpDamageInformationTest.php

@@ -0,0 +1,66 @@
+<?php
+
+namespace IndifferentKetchup\Codex\Test\Tests\Games\ProjectZomboid\Analysis;
+
+use IndifferentKetchup\Codex\Analysis\ProjectZomboid\PvpDamageInformation;
+use IndifferentKetchup\Codex\Pattern\ProjectZomboid\PvpPattern;
+use PHPUnit\Framework\TestCase;
+
+class PvpDamageInformationTest extends TestCase
+{
+    public function testGetPatternsReturnsCombatRealRegex(): void
+    {
+        $this->assertSame([PvpPattern::COMBAT_REAL], PvpDamageInformation::getPatterns());
+    }
+
+    public function testCombatRealMatchesPositiveDamageRealWeapon(): void
+    {
+        $line = 'Combat: "Player1" (1005,2005,0) hit "Player2" (1006,2005,0) weapon="Tire Iron (Worn)" damage=0.112317.';
+        $this->assertSame(1, preg_match(PvpPattern::COMBAT_REAL, $line, $m));
+
+        $insight = new PvpDamageInformation();
+        $insight->setMatches($m, 0);
+
+        $this->assertSame('PvP combat', $insight->getLabel());
+        $this->assertSame('Player1 hit Player2 with Tire Iron (Worn)', $insight->getValue());
+    }
+
+    public function testCombatRealRejectsZombieWeapon(): void
+    {
+        $line = 'Combat: "Player1" (1005,2005,0) hit "Player1" (1005,2005,0) weapon="zombie" damage=-1.000000.';
+        $this->assertSame(0, preg_match(PvpPattern::COMBAT_REAL, $line));
+    }
+
+    public function testCombatRealRejectsZeroDamage(): void
+    {
+        $line = 'Combat: "Player1" (1100,2200,0) hit "Player2" (1100,2201,0) weapon="vehicle" damage=0.000000.';
+        $this->assertSame(0, preg_match(PvpPattern::COMBAT_REAL, $line));
+    }
+
+    public function testCombatRealRejectsNegativeDamage(): void
+    {
+        $line = 'Combat: "Player1" (1005,2005,0) hit "Player2" (1005,2005,0) weapon="Bare Hands" damage=-0.500000.';
+        $this->assertSame(0, preg_match(PvpPattern::COMBAT_REAL, $line));
+    }
+
+    public function testIsEqualCoalescesSameAttackerVictimWeapon(): void
+    {
+        $a = $this->insightFor('Player1', 'Player2', 'Bare Hands');
+        $b = $this->insightFor('Player1', 'Player2', 'Bare Hands');
+        $c = $this->insightFor('Player1', 'Player2', 'Tire Iron');
+
+        $this->assertTrue($a->isEqual($b));
+        $this->assertFalse($a->isEqual($c));
+    }
+
+    private function insightFor(string $attacker, string $victim, string $weapon): PvpDamageInformation
+    {
+        $insight = new PvpDamageInformation();
+        $insight->setMatches([
+            'attacker' => $attacker,
+            'victim' => $victim,
+            'weapon' => $weapon,
+        ], 0);
+        return $insight;
+    }
+}