Compare commits
7 Commits
0c90e40a28
...
v0.1.0
| Author | SHA1 | Date | |
|---|---|---|---|
| 52ff8cb3fe | |||
| 1485507c8f | |||
| ed920485dc | |||
| b99d8f3061 | |||
| 38fa1471ba | |||
| 1cdc78c54c | |||
| 60f12bc868 |
2
.github/workflows/tests.yaml
vendored
2
.github/workflows/tests.yaml
vendored
@@ -27,7 +27,7 @@ jobs:
|
|||||||
|
|
||||||
- name: Set composer cache directory
|
- name: Set composer cache directory
|
||||||
id: composer-cache
|
id: composer-cache
|
||||||
run: echo "::set-output name=dir::$(composer config cache-files-dir)"
|
run: echo "dir=$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT"
|
||||||
|
|
||||||
- name: Restore composer from cache
|
- name: Restore composer from cache
|
||||||
uses: actions/cache@v4
|
uses: actions/cache@v4
|
||||||
|
|||||||
39
CHANGELOG.md
Normal file
39
CHANGELOG.md
Normal file
@@ -0,0 +1,39 @@
|
|||||||
|
# Changelog
|
||||||
|
|
||||||
|
All notable changes to `indifferentketchup/codex` are documented here.
|
||||||
|
|
||||||
|
The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
||||||
|
|
||||||
|
## [0.1.0] — 2026-05-01
|
||||||
|
|
||||||
|
First public release. Codex is a generic PHP log parsing and analysis framework with full Project Zomboid server-log support across eight analysers. The Composer package name is `indifferentketchup/codex` (the repository directory and Gitea slug are `ik-codex`; the package name is not).
|
||||||
|
|
||||||
|
### Added
|
||||||
|
|
||||||
|
- **Framework foundation** — generic `Log` / `Entry` / `Line` / `Parser` / `Analyser` / `Detective` / `Insight` pipeline forked from upstream `aternos/codex` and renamed end-to-end to `IndifferentKetchup\Codex\*` in `66a2fcc`. Zero `Aternos\Codex\*` namespace references remain in `src/` or `test/`.
|
||||||
|
- **`FilenameDetector`** at `IndifferentKetchup\Codex\Detective\FilenameDetector` — path-based detector that uses the new `LogFileInterface::getPath()` accessor to dispatch on a filename hint. Falls back to `false` for path-less log files (`StringLogFile`, `StreamLogFile`).
|
||||||
|
- **Project Zomboid log subclasses (11)** under `IndifferentKetchup\Codex\Log\ProjectZomboid\*` covering every PZ server-log file type: a multi-line `ProjectZomboidServerLog` for `DebugLog-server.txt`, an abstract `ProjectZomboidEventLog` base for the ten single-line logs, and concrete subclasses for `admin.txt`, `BurdJournals.txt`, `chat.txt`, `ClientActionLog.txt`, `cmd.txt`, `item.txt`, `map.txt`, `PerkLog.txt`, `pvp.txt`, `user.txt`.
|
||||||
|
- **Pattern classes (11)** under `IndifferentKetchup\Codex\Pattern\ProjectZomboid\*` holding regex string constants. Each `<Type>Pattern` carries a `LINE` regex used by `PatternParser`, plus named-group extractor regexes (`FIELDS`, `COMBAT`, `MOD_LOAD`, etc.) used by analysers.
|
||||||
|
- **`ProjectZomboidDetective`** at `IndifferentKetchup\Codex\Detective\ProjectZomboid\ProjectZomboidDetective` — pre-registers all 11 log subclasses in its constructor with paired filename-hint plus content-signature detectors.
|
||||||
|
- **Phase B.1 ServerLog analysers (3)**: `EngineVersionAnalyser` (extracts engine version, build hash, and build date from the server banner), `ModLoadAnalyser` (mod load order plus missing-mod problems with attached `ModMissingSolution`), `ServerExceptionAnalyser` (Java exception type and stack-trace body, coalesced by exception type).
|
||||||
|
- **Phase B.2 PvP and Admin analysers (2)**: `PvpDamageAnalyser` (filters zombie hits and zero-damage rows at the regex itself), `AdminAuditAnalyser` (verb-pattern dispatch across six admin actions: added item, added xp, granted access, changed option, reloaded options, teleported).
|
||||||
|
- **Phase B.3 deferred analysers (3)** — first custom `Analyser` subclasses in the tree, addressing logic that vanilla `PatternAnalyser` cannot express: `ConnectionFailureAnalyser` (event pairing across the file), `ItemDuplicationAnalyser` (sliding-window heuristic with `THRESHOLD_COUNT=5`, `THRESHOLD_WINDOW_SECONDS=10`), `SkillProgressionAnomalyAnalyser` (consecutive-snapshot delta with `THRESHOLD_DELTA=3`). All three threshold constants ship with rationale docblocks and are tunable via subclass override.
|
||||||
|
- **Synthetic test fixtures** under `test/src/Games/ProjectZomboid/fixtures/`, hand-crafted from observed PZ log shapes with placeholder identifiers per the project's privacy rules: Steam IDs `76561198000000001`–`76561198000000004`, names `Player1` / `Player2` / `AdminUser` / `PlayerSuspect`, generic coords. No real-log content reaches the index.
|
||||||
|
- **End-to-end tests** validating each Log subclass's parser, each analyser's insight emission, and the Detective's dispatch behaviour against the synthetic fixtures. Final count: **195 tests, 412 assertions**.
|
||||||
|
- **Project documentation**: `CLAUDE.md` with framework architecture, pitfalls, and workflow conventions; `README.md` with worked Project Zomboid example and per-game support table; design specs and as-built plans for Phase B.1 / B.2 / B.3 plus a deferred-status spec for the codex `Redactor` utility, all under `docs/superpowers/`.
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
|
||||||
|
- **Layout: components-outer with game suffix.** Every game's code lives at `IndifferentKetchup\Codex\<Component>\<Game>\*` for the existing components (`Analyser`, `Analysis`, `Detective`, `Log`, `Parser`, `Pattern`). This is option 1 from the Phase A Step 2 layout decision; option 3 (a flat `IndifferentKetchup\Codex\Games\<Game>\*` tree) was originally proposed and was **not** selected.
|
||||||
|
- **`LICENSE`** retains the original `Copyright (c) 2019-2026 Aternos GmbH` line per MIT requirements; the LICENSE file is byte-for-byte unchanged from the upstream import.
|
||||||
|
- **`composer.json`** rewritten in `aae016d`: package name `indifferentketchup/codex`, MIT license, generic-framework description, single author entry, PSR-4 autoload roots set to `IndifferentKetchup\Codex\` and the test-fixture / test-suite namespaces, PHP `>=8.4` require constraint, PHPUnit `^12` dev dependency.
|
||||||
|
- **`tests.yaml`** uses the modern `$GITHUB_OUTPUT` workflow command instead of the deprecated `::set-output` (commit `60f12bc`). CI matrix runs PHP 8.4 and 8.5.
|
||||||
|
- **`.gitignore`** excludes `Logs.zip` (real production log fixtures) and `.scratch/` (extracted reference logs), plus `.claude/` and `.claude.local.md` for personal Claude Code artefacts.
|
||||||
|
|
||||||
|
### Deferred
|
||||||
|
|
||||||
|
- **Codex `Redactor` utility** — design captured in `docs/superpowers/specs/2026-04-30-redactor-design.md`. Not implemented in v0.1.0. iblogs (the downstream consumer) handles upload-time PII filtering for this release; codex itself ships no PII helper. The deferred spec exists so iblogs's privacy story has a referenced design to point at and so a future implementation pass has a clear contract to start from.
|
||||||
|
- **Other game implementations** — `Minecraft`, `Hytale`, and `SevenDaysToDie` are detective-stub-only. Each has a TODO `<Game>Detective` extending base `Detective`; their per-component subdirectories under `Analyser`, `Log`, `Parser`, and `Pattern` contain only `.gitkeep` placeholders. Real implementations land if and when fixtures and demand exist.
|
||||||
|
- **Packagist publication** — v0.1.0 is consumable via Composer's `vcs` repository entry pointing at the Gitea remote. Pushing to Packagist is a separate decision and is not in scope for this release.
|
||||||
|
|
||||||
|
[0.1.0]: https://git.indifferentketchup.com/indifferentketchup/ik-codex/releases/tag/v0.1.0
|
||||||
@@ -48,6 +48,7 @@ Analysis of Insight[]
|
|||||||
- **`Detective`** ranks candidate Log subclasses by running each candidate's `getDetectors()` and picking the highest-scoring result (`bool|float`). It receives a `LogFile`, returns a constructed `Log` subclass.
|
- **`Detective`** ranks candidate Log subclasses by running each candidate's `getDetectors()` and picking the highest-scoring result (`bool|float`). It receives a `LogFile`, returns a constructed `Log` subclass.
|
||||||
- **`PatternParser`** is regex-driven. Lines that don't match the LINE regex append to the previous `Entry` — this is the mechanism that handles multi-line records like Java stack traces under an ERROR header.
|
- **`PatternParser`** is regex-driven. Lines that don't match the LINE regex append to the previous `Entry` — this is the mechanism that handles multi-line records like Java stack traces under an ERROR header.
|
||||||
- **`PatternAnalyser`** walks entries, runs each registered insight class's static `getPatterns()` against entry text via `preg_match_all`, and emits coalesced insights (equal insights bump a counter instead of duplicating).
|
- **`PatternAnalyser`** walks entries, runs each registered insight class's static `getPatterns()` against entry text via `preg_match_all`, and emits coalesced insights (equal insights bump a counter instead of duplicating).
|
||||||
|
- **Custom `Analyser` subclasses** are the right move when analysis needs cross-entry state — pairing events, sliding-window thresholds, comparing consecutive snapshots. `PatternAnalyser` operates per-entry only and can't express those. Phase B.3 (`ConnectionFailureAnalyser`, `ItemDuplicationAnalyser`, `SkillProgressionAnomalyAnalyser`) shows the shape: extend `Analyser`, override `analyse()`, walk `$this->log` once, aggregate, then emit coalesced `Problem`/`Information` insights at the end. Tunable thresholds belong as `public const` constants on the subclass with the rationale in a docblock.
|
||||||
- Detectors available out of the box: `SinglePatternDetector`, `WeightedSinglePatternDetector`, `LinePatternDetector` (returns match ratio), `MultiPatternDetector` (AND), and the path-based `FilenameDetector` (uses `LogFileInterface::getPath()`, returns `false` when no path is available).
|
- Detectors available out of the box: `SinglePatternDetector`, `WeightedSinglePatternDetector`, `LinePatternDetector` (returns match ratio), `MultiPatternDetector` (AND), and the path-based `FilenameDetector` (uses `LogFileInterface::getPath()`, returns `false` when no path is available).
|
||||||
|
|
||||||
## Game subtrees
|
## Game subtrees
|
||||||
@@ -61,7 +62,7 @@ test/tests/Games/<Game>/...
|
|||||||
test/src/Games/<Game>/fixtures/<type>-minimal.txt (synthetic fixtures only)
|
test/src/Games/<Game>/fixtures/<type>-minimal.txt (synthetic fixtures only)
|
||||||
```
|
```
|
||||||
|
|
||||||
Scaffolded games: `Minecraft`, `Hytale`, `SevenDaysToDie` (stubs only — empty `.gitkeep`s plus a TODO `<Game>Detective` extending base `Detective`). `ProjectZomboid` is fully implemented (11 log subclasses, 11 pattern classes, detective wired with all 11, synthetic fixtures, dispatch tests).
|
Scaffolded games: `Minecraft`, `Hytale`, `SevenDaysToDie` (stubs only — empty `.gitkeep`s plus a TODO `<Game>Detective` extending base `Detective`). `ProjectZomboid` is fully implemented: 11 log subclasses, 11 pattern classes, detective wired with all 11, synthetic fixtures, dispatch tests, plus the analyser surface — 12 `PatternAnalyser`-driven Insight classes under `src/Analysis/ProjectZomboid/` and 3 custom `Analyser` subclasses under `src/Analyser/ProjectZomboid/` for cross-entry / threshold logic.
|
||||||
|
|
||||||
`src/Pattern/` is **not a framework abstraction** — patterns are plain `string` class constants. Each `<Type>Pattern` typically holds a `LINE` constant for the parser plus named-group extractor constants (`FIELDS`, `COMBAT`, `MOD_LOAD`, etc.) for analysers.
|
`src/Pattern/` is **not a framework abstraction** — patterns are plain `string` class constants. Each `<Type>Pattern` typically holds a `LINE` constant for the parser plus named-group extractor constants (`FIELDS`, `COMBAT`, `MOD_LOAD`, etc.) for analysers.
|
||||||
|
|
||||||
@@ -69,6 +70,10 @@ Scaffolded games: `Minecraft`, `Hytale`, `SevenDaysToDie` (stubs only — empty
|
|||||||
|
|
||||||
- Two abstract bases: `ProjectZomboidLog` (`TIME_FORMAT = 'd-m-y H:i:s.v'`, UTC default, `makePatternParser()` helper) and `ProjectZomboidEventLog` (marker for the ten single-line logs; `ProjectZomboidServerLog` extends the parent directly because it permits multi-line entries).
|
- Two abstract bases: `ProjectZomboidLog` (`TIME_FORMAT = 'd-m-y H:i:s.v'`, UTC default, `makePatternParser()` helper) and `ProjectZomboidEventLog` (marker for the ten single-line logs; `ProjectZomboidServerLog` extends the parent directly because it permits multi-line entries).
|
||||||
- `ProjectZomboidDetective::__construct()` pre-registers all 11 log classes — instantiate it and call `setLogFile(...)->detect()`.
|
- `ProjectZomboidDetective::__construct()` pre-registers all 11 log classes — instantiate it and call `setLogFile(...)->detect()`.
|
||||||
|
- Each Log subclass's `getDefaultAnalyser()` returns one of:
|
||||||
|
- A custom `Analyser` subclass (cross-entry logic): `UserLog → ConnectionFailureAnalyser`, `ItemLog → ItemDuplicationAnalyser`, `PerkLog → SkillProgressionAnomalyAnalyser`.
|
||||||
|
- A configured `PatternAnalyser` (per-entry pattern matching): `ServerLog`, `PvpLog`, `AdminLog` register their respective Insight classes.
|
||||||
|
- An empty `PatternAnalyser` for logs with no analysers yet: `ChatLog`, `ClientActionLog`, `CmdLog`, `MapLog`, `BurdJournalsLog`. These are wiring stubs awaiting future analysis work.
|
||||||
|
|
||||||
### Standard test template for a Log subclass
|
### Standard test template for a Log subclass
|
||||||
|
|
||||||
|
|||||||
88
README.md
88
README.md
@@ -1,13 +1,97 @@
|
|||||||
# IndifferentKetchup Codex
|
# IndifferentKetchup Codex
|
||||||
|
|
||||||
A generic PHP log parsing and analysis framework. Provides interfaces and base implementations for reading log files, detecting log types, parsing entries into structured form, analysing them for problems and information, and printing results.
|
Generic PHP log parsing and analysis framework. Reads a log file, detects which log type it is, parses entries (including multi-line records like Java stack traces), runs the type-specific analysers, and returns structured `Information` and `Problem` insights with attached `Solution`s where applicable.
|
||||||
|
|
||||||
## Installation
|
Originally a fork of [`aternos/codex`](https://github.com/aternosorg/codex); the framework is intentionally game-agnostic. The reference implementation in this tree is Project Zomboid server logs.
|
||||||
|
|
||||||
|
## Install
|
||||||
|
|
||||||
```
|
```
|
||||||
composer require indifferentketchup/codex
|
composer require indifferentketchup/codex
|
||||||
```
|
```
|
||||||
|
|
||||||
|
Requires PHP `>=8.4`. No third-party runtime dependencies.
|
||||||
|
|
||||||
|
## Quick start
|
||||||
|
|
||||||
|
Given a Project Zomboid `DebugLog-server.txt`:
|
||||||
|
|
||||||
|
```php
|
||||||
|
<?php
|
||||||
|
require __DIR__ . '/vendor/autoload.php';
|
||||||
|
|
||||||
|
use IndifferentKetchup\Codex\Detective\ProjectZomboid\ProjectZomboidDetective;
|
||||||
|
use IndifferentKetchup\Codex\Log\File\PathLogFile;
|
||||||
|
|
||||||
|
$detective = new ProjectZomboidDetective();
|
||||||
|
$detective->setLogFile(new PathLogFile('2026-04-30_14-00_DebugLog-server.txt'));
|
||||||
|
|
||||||
|
$log = $detective->detect();
|
||||||
|
$log->parse();
|
||||||
|
$analysis = $log->analyse();
|
||||||
|
|
||||||
|
echo $log->getTitle(), "\n\n";
|
||||||
|
|
||||||
|
foreach ($analysis->getInformation() as $info) {
|
||||||
|
echo "[INFO] ", $info->getMessage(), "\n";
|
||||||
|
}
|
||||||
|
|
||||||
|
foreach ($analysis->getProblems() as $problem) {
|
||||||
|
echo "[PROBLEM] ", $problem->getMessage(), "\n";
|
||||||
|
foreach ($problem->getSolutions() as $solution) {
|
||||||
|
echo " -> ", $solution->getMessage(), "\n";
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
For a session with mod issues and a server-side exception, output looks roughly like:
|
||||||
|
|
||||||
|
```
|
||||||
|
Project Zomboid Debug Server Log
|
||||||
|
|
||||||
|
[INFO] Engine version: 42.16.3 (build <hash>, <build date>)
|
||||||
|
[INFO] Mod loaded: <mod_id>
|
||||||
|
[INFO] Mod loaded: <other_mod_id>
|
||||||
|
[PROBLEM] Required mod "<missing>" not found.
|
||||||
|
-> Subscribe to mod "<missing>" or remove its ID from the Mods= line in serverconfig.ini.
|
||||||
|
[PROBLEM] Exception thrown: java.nio.file.NoSuchFileException
|
||||||
|
```
|
||||||
|
|
||||||
|
If the log content arrives without a filesystem path (clipboard paste, web upload, stream), use `StringLogFile` or `StreamLogFile` instead of `PathLogFile`. The detective falls back to content signatures when the filename hint is absent.
|
||||||
|
|
||||||
|
## Architecture
|
||||||
|
|
||||||
|
```
|
||||||
|
LogFile → Log → parse() → Entry[] of Line[] → analyse() → Analysis of Insight[]
|
||||||
|
└── Information | Problem(+Solutions)
|
||||||
|
```
|
||||||
|
|
||||||
|
- **`Detective`** ranks candidate `Log` subclasses by running each candidate's static `getDetectors()` and picking the highest-scoring result. Each game ships its own `<Game>Detective` that pre-registers its log classes.
|
||||||
|
- **`PatternParser`** is regex-driven; lines that don't match the entry-start regex append to the previous `Entry`, which is how multi-line records (Java stack traces, indented warnings) are kept intact.
|
||||||
|
- **Analysers** come in two flavours: configured `PatternAnalyser` instances for per-entry pattern matching, and custom subclasses of `Analyser` for cross-entry logic (pairing events, sliding-window thresholds, snapshot comparisons).
|
||||||
|
- **Insights** are either `Information` (label + value) or `Problem` (with attached `Solution`s). Equal insights coalesce via a counter, so repeated patterns don't produce duplicate output.
|
||||||
|
|
||||||
|
Patterns live as plain `string` constants under `src/Pattern/<Game>/` — there is no `PatternInterface`. Each game adds files under `src/<Component>/<Game>/` (components-outer, game-suffixed). Full extension guide and conventions in [`CLAUDE.md`](CLAUDE.md).
|
||||||
|
|
||||||
|
## Game support
|
||||||
|
|
||||||
|
| Game | State |
|
||||||
|
|---|---|
|
||||||
|
| Project Zomboid | Full: 11 log subclasses across all the file types a server emits; analysers covering engine version, mod loading, server exceptions, PvP combat, admin audit, connection failures, item duplication, skill progression anomalies |
|
||||||
|
| Minecraft | Stub only — `MinecraftDetective` skeleton, no log subclasses yet |
|
||||||
|
| Hytale | Stub only |
|
||||||
|
| Seven Days To Die | Stub only |
|
||||||
|
|
||||||
|
The framework itself is generic — adding a new game means writing the same shape of files Project Zomboid demonstrates, not modifying anything in `src/{Analyser,Analysis,Detective,Log,Parser,Printer,Pattern}/` outside the new game's subdirectory.
|
||||||
|
|
||||||
|
## Developing
|
||||||
|
|
||||||
|
`composer test` runs the suite. PHP and Composer are not required on the host — invocations wrap in the official `composer:latest` Docker image (PHP 8.5). See [`CLAUDE.md`](CLAUDE.md) for the wrapped command, file layout, and the workflow conventions used in this repo.
|
||||||
|
|
||||||
## Source
|
## Source
|
||||||
|
|
||||||
<https://git.indifferentketchup.com/indifferentketchup/ik-codex>
|
<https://git.indifferentketchup.com/indifferentketchup/ik-codex>
|
||||||
|
|
||||||
|
## License
|
||||||
|
|
||||||
|
MIT — see [`LICENSE`](LICENSE).
|
||||||
|
|||||||
74
docs/superpowers/plans/2026-04-30-pz-analysers-deferred.md
Normal file
74
docs/superpowers/plans/2026-04-30-pz-analysers-deferred.md
Normal file
@@ -0,0 +1,74 @@
|
|||||||
|
# ProjectZomboid Phase B.3 Deferred Analysers — As-Built Plan
|
||||||
|
|
||||||
|
> Retroactive: written 2026-05-01.
|
||||||
|
|
||||||
|
This document is a historical record of how Phase B.3 (the three deferred analysers from the original Step D candidate list) was implemented. The corresponding design spec is `docs/superpowers/specs/2026-04-30-pz-analysers-deferred-design.md`. The work is complete and merged to `master`; checkboxes are pre-checked.
|
||||||
|
|
||||||
|
**Goal:** Land three custom `Analyser` subclasses under `src/Analyser/ProjectZomboid/` (the first non-empty contents of that directory), three `Problem` subclasses under `src/Analysis/ProjectZomboid/`, threshold constants documented inline as `public const`, fixture extensions to exercise trigger and non-trigger paths, and e2e tests verifying the analysers' behaviour against the fixtures.
|
||||||
|
|
||||||
|
**Architecture:** Custom subclasses of the framework's abstract `Analyser`. Each overrides `analyse()` to walk `$this->log` once, aggregate cross-entry state, and emit coalesced `Problem` insights at the end. This is the first deviation from Phase B.1/B.2's vanilla-`PatternAnalyser` pattern; the reasoning is recorded in the design spec and in `CLAUDE.md`.
|
||||||
|
|
||||||
|
**Tech Stack:** PHP 8.4+, PHPUnit 12, Composer (root package: `indifferentketchup/codex`). PHP/Composer not installed on host — all command invocations wrap in `docker run --rm -v "$(pwd):/app" -w /app -u "$(id -u):$(id -g)" composer:latest …`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Tasks
|
||||||
|
|
||||||
|
### Task 0 — Pre-checkpoint
|
||||||
|
|
||||||
|
- [x] Empty checkpoint commit: `c444e85 pre-phase-B.3 checkpoint`
|
||||||
|
|
||||||
|
### Task 1 — `ConnectionFailureAnalyser` (UserLog)
|
||||||
|
|
||||||
|
Pairing logic: walk the log, count `attempting to join` and `allowed to join` events per Steam ID, emit a `ConnectionFailureProblem` for any Steam ID whose attempt count exceeds its allowed count.
|
||||||
|
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/ConnectionFailureProblem.php` (Steam ID, player, unmatched count; `isEqual` coalesces by Steam ID)
|
||||||
|
- [x] Add `src/Analyser/ProjectZomboid/ConnectionFailureAnalyser.php` — first file in this directory; the `.gitkeep` placeholder is removed in this commit
|
||||||
|
- [x] Wire `ProjectZomboidUserLog::getDefaultAnalyser()` to return `new ConnectionFailureAnalyser()` and drop the now-unused `PatternAnalyser` import
|
||||||
|
- [x] Add `test/tests/Games/ProjectZomboid/Analyser/UserLogAnalysisTest.php` — asserts Player1 (`76561198000000001`) is flagged with `unmatchedAttempts == 1` and Player2 (`76561198000000002`) is not flagged
|
||||||
|
- [x] `composer test` green: 188 tests, 392 assertions
|
||||||
|
- [x] Commit: `73e9ca6 Add ConnectionFailureAnalyser`
|
||||||
|
|
||||||
|
Design note inside the analyser docblock: "attempting to join used queue" rows are surfaced as failures in v1 because a long queue wait is indistinguishable from a real failure without timing context. Tunable in v2 if false positives become noisy.
|
||||||
|
|
||||||
|
### Task 2 — `ItemDuplicationAnalyser` (ItemLog)
|
||||||
|
|
||||||
|
Sliding-window heuristic over `(steamid, item)` groups, restricted to positive-delta events. Negative-delta rows (drops/transfers) are filtered out.
|
||||||
|
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/ItemDuplicationProblem.php` (Steam ID, player, item, event count; `isEqual` coalesces by `(steamid, item)`)
|
||||||
|
- [x] Add `src/Analyser/ProjectZomboid/ItemDuplicationAnalyser.php` with two threshold constants and rationale docblocks: `THRESHOLD_COUNT = 5`, `THRESHOLD_WINDOW_SECONDS = 10`
|
||||||
|
- [x] Wire `ProjectZomboidItemLog::getDefaultAnalyser()` to return `new ItemDuplicationAnalyser()`; drop unused `PatternAnalyser` import
|
||||||
|
- [x] Extend `test/src/Games/ProjectZomboid/fixtures/item-minimal.txt`: append 6 Bullets9mm events at sub-second timestamps `19:50:00.001`–`.006` for AdminUser (trigger), plus 4 Plank events scattered `20:00:00`–`20:03:00` for Player1 (sub-threshold)
|
||||||
|
- [x] Bump entry-count assertion in `ProjectZomboidItemLogTest::testParsesEachLineAsAnEntry`: 10 → 20
|
||||||
|
- [x] Add `test/tests/Games/ProjectZomboid/Analyser/ItemLogAnalysisTest.php` — asserts one `ItemDuplicationProblem` (AdminUser + Bullets9mm + 6 events), zero for the Plank group, and the threshold constants are positive
|
||||||
|
- [x] `composer test` green: 191 tests, 400 assertions
|
||||||
|
- [x] Commit: `ba3fae8 Add ItemDuplicationAnalyser`
|
||||||
|
|
||||||
|
Implementation note: the analyser uses a two-pointer sliding window per group, which is O(n) per group after the initial sort. `Entry::getTime()` returns integer Unix seconds (sub-second precision dropped); the burst events all collapse to the same Unix-second value so any positive window catches them.
|
||||||
|
|
||||||
|
### Task 3 — `SkillProgressionAnomalyAnalyser` (PerkLog)
|
||||||
|
|
||||||
|
Compare consecutive perks-snapshot rows per Steam ID; emit a problem for any single skill that gained more than `THRESHOLD_DELTA` levels between snapshots.
|
||||||
|
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/SkillProgressionAnomalyProblem.php` (Steam ID, player, skill, fromLevel, toLevel, delta; `isEqual` coalesces by `(steamid, skill)`)
|
||||||
|
- [x] Add `src/Analyser/ProjectZomboid/SkillProgressionAnomalyAnalyser.php` with `THRESHOLD_DELTA = 3` and a rationale docblock about PZ's slow skill leveling
|
||||||
|
- [x] Wire `ProjectZomboidPerkLog::getDefaultAnalyser()` to return `new SkillProgressionAnomalyAnalyser()`; drop unused `PatternAnalyser` import
|
||||||
|
- [x] Extend `test/src/Games/ProjectZomboid/fixtures/perk-minimal.txt`: append PlayerSuspect (Steam ID `76561198000000004`) with two snapshots — Strength 2→10 (+8 trigger), Fitness 2→8 (+6 trigger), Maintenance 0→3 (+3 boundary, does not trigger because comparison is strict `>`)
|
||||||
|
- [x] Bump entry-count assertion in `ProjectZomboidPerkLogTest::testParsesEachLineAsAnEntry`: 6 → 10
|
||||||
|
- [x] Add `test/tests/Games/ProjectZomboid/Analyser/PerkLogAnalysisTest.php` — asserts exactly two problems for PlayerSuspect (Strength + Fitness, sorted), no problem for Maintenance, no problems for single-snapshot Player1/Player2, and the threshold constant is positive
|
||||||
|
- [x] `composer test` green: 195 tests, 412 assertions
|
||||||
|
- [x] Commit: `0c90e40 Add SkillProgressionAnomalyAnalyser`
|
||||||
|
|
||||||
|
Filtering note: the analyser skips event-token rows (`Login`, `Logout`, `LevelUp`) by checking that the bracketed event field contains a `Skill=N` pair via `PerkPattern::PERK_PAIR`. Only true perks-snapshot rows enter the comparison.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Done condition (met)
|
||||||
|
|
||||||
|
After Task 3, `composer test` reports **195 tests, 412 assertions, all green** under PHPUnit 12.5.6 / PHP 8.5.5. All eight Step D candidate analysers (Phase B.1's three ServerLog + Phase B.2's seven PvP/Admin + Phase B.3's three deferred) are operational across their respective Log subclasses.
|
||||||
|
|
||||||
|
The directory `src/Analyser/ProjectZomboid/` now contains real code for the first time; its `.gitkeep` placeholder was removed in `73e9ca6`.
|
||||||
|
|
||||||
|
## Deviations from the original plan
|
||||||
|
|
||||||
|
None this phase. The 4-commit count and the per-analyser shape both match what was committed-to in chat before execution. No silent breakages, no missing closing braces. The only observation worth recording is that the planned commit count was inclusive of the pre-checkpoint, and the actual commit ordering matched the plan exactly.
|
||||||
116
docs/superpowers/plans/2026-04-30-pz-analysers-pvp-admin.md
Normal file
116
docs/superpowers/plans/2026-04-30-pz-analysers-pvp-admin.md
Normal file
@@ -0,0 +1,116 @@
|
|||||||
|
# ProjectZomboid Phase B.2 Analysers — As-Built Plan
|
||||||
|
|
||||||
|
> Retroactive: written 2026-05-01.
|
||||||
|
|
||||||
|
This document is a historical record of how Phase B.2 (PvP combat detection + admin verb dispatch) was implemented. The corresponding design spec is `docs/superpowers/specs/2026-04-30-pz-analysers-pvp-admin-design.md`. The work is complete and merged to `master`; checkboxes are pre-checked.
|
||||||
|
|
||||||
|
**Goal:** Land seven new `Information` insight classes (one for PvP combat, six for admin verbs) under `src/Analysis/ProjectZomboid/`, plus seven new pattern constants on `PvpPattern` / `AdminPattern`, then wire `ProjectZomboidPvpLog` and `ProjectZomboidAdminLog` default analysers to register them.
|
||||||
|
|
||||||
|
**Architecture:** Vanilla `PatternAnalyser` configured with the new insight classes. No custom `Analyser` subclasses (deferred to Phase B.3). `Entry::__toString()` joins lines with `\n`, but B.2 logs are single-line per entry so multi-line behaviour doesn't apply here.
|
||||||
|
|
||||||
|
**Tech Stack:** PHP 8.4+, PHPUnit 12, Composer (root package: `indifferentketchup/codex`). PHP/Composer not installed on host — all command invocations wrap in `docker run --rm -v "$(pwd):/app" -w /app -u "$(id -u):$(id -g)" composer:latest …`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Tasks
|
||||||
|
|
||||||
|
### Task 0 — Pre-checkpoint
|
||||||
|
|
||||||
|
- [x] Empty checkpoint commit: `df62da1 pre-phase-B.2 checkpoint`
|
||||||
|
|
||||||
|
### Task 1 — `PvpDamageInformation` + `PvpPattern::COMBAT_REAL`
|
||||||
|
|
||||||
|
- [x] Add `PvpPattern::COMBAT_REAL` constant (combat regex with negative lookahead on weapon and positive-non-zero damage clause)
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/PvpDamageInformation.php`
|
||||||
|
- [x] Add `test/tests/Games/ProjectZomboid/Analysis/PvpDamageInformationTest.php` covering pattern shape, match extraction, and three rejection cases (zombie weapon, zero damage, negative damage)
|
||||||
|
- [x] `composer test` green: 167 tests, 343 assertions
|
||||||
|
- [x] Commit: `55f769c Add PvpDamageInformation insight`
|
||||||
|
|
||||||
|
### Task 2 — `AdminAddedItemInformation` + `AdminPattern::ADDED_ITEM_ENTRY`
|
||||||
|
|
||||||
|
- [x] Add `AdminPattern::ADDED_ITEM_ENTRY` constant (entry-anchored variant; the body-only `ADDED_ITEM` from Phase A stays in place)
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/AdminAddedItemInformation.php`
|
||||||
|
- [x] Add `test/tests/Games/ProjectZomboid/Analysis/AdminAddedItemInformationTest.php`
|
||||||
|
- [x] Commit: `90c85a0 Add AdminAddedItemInformation insight` — **see Deviations section below**
|
||||||
|
- [x] Forward-fix: `0d85a05 Fix missing closing brace in AdminPattern`
|
||||||
|
- [x] `composer test` green after forward-fix: 170 tests
|
||||||
|
|
||||||
|
### Task 3 — `AdminAddedXpInformation` + `ADDED_XP_ENTRY`
|
||||||
|
|
||||||
|
- [x] Add `AdminPattern::ADDED_XP_ENTRY` constant
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/AdminAddedXpInformation.php`
|
||||||
|
- [x] Unit test
|
||||||
|
- [x] `composer test` green: 173 tests
|
||||||
|
- [x] Commit: `a2faa55 Add AdminAddedXpInformation insight`
|
||||||
|
|
||||||
|
### Task 4 — `AdminGrantedAccessInformation` + `GRANTED_ACCESS_ENTRY`
|
||||||
|
|
||||||
|
- [x] Add `AdminPattern::GRANTED_ACCESS_ENTRY` constant
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/AdminGrantedAccessInformation.php`
|
||||||
|
- [x] Unit test
|
||||||
|
- [x] `composer test` green: 175 tests
|
||||||
|
- [x] Commit: `caed04d Add AdminGrantedAccessInformation insight`
|
||||||
|
|
||||||
|
### Task 5 — `AdminChangedOptionInformation` + `CHANGED_OPTION_ENTRY`
|
||||||
|
|
||||||
|
- [x] Add `AdminPattern::CHANGED_OPTION_ENTRY` constant
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/AdminChangedOptionInformation.php`
|
||||||
|
- [x] Unit test
|
||||||
|
- [x] `composer test` green: 177 tests
|
||||||
|
- [x] Commit: `b7b89ef Add AdminChangedOptionInformation insight`
|
||||||
|
|
||||||
|
### Task 6 — `AdminReloadedOptionsInformation` + `RELOADED_OPTIONS_ENTRY`
|
||||||
|
|
||||||
|
- [x] Add `AdminPattern::RELOADED_OPTIONS_ENTRY` constant
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/AdminReloadedOptionsInformation.php`
|
||||||
|
- [x] Unit test
|
||||||
|
- [x] `composer test` green: 179 tests
|
||||||
|
- [x] Commit: `64641fa Add AdminReloadedOptionsInformation insight`
|
||||||
|
|
||||||
|
### Task 7 — `AdminTeleportedInformation` + `TELEPORTED_ENTRY`
|
||||||
|
|
||||||
|
- [x] Add `AdminPattern::TELEPORTED_ENTRY` constant (handles negative Z for basement coordinates)
|
||||||
|
- [x] Add `src/Analysis/ProjectZomboid/AdminTeleportedInformation.php`
|
||||||
|
- [x] Unit test (positive and negative Z cases)
|
||||||
|
- [x] `composer test` green: 182 tests
|
||||||
|
- [x] Commit: `d15fc81 Add AdminTeleportedInformation insight`
|
||||||
|
|
||||||
|
### Task 8 — Wire `ProjectZomboidPvpLog::getDefaultAnalyser()`
|
||||||
|
|
||||||
|
- [x] Replace `return new PatternAnalyser();` with `(new PatternAnalyser())->addPossibleInsightClass(PvpDamageInformation::class)`
|
||||||
|
- [x] Add `test/tests/Games/ProjectZomboid/Analyser/PvpLogAnalysisTest.php` — asserts three real-PvP insights (Bare Hands, Tire Iron, Hunting Knife) and zero zombie/vehicle insights
|
||||||
|
- [x] `composer test` green: 184 tests
|
||||||
|
- [x] Commit: `51eb2de Wire ProjectZomboidPvpLog default analyser`
|
||||||
|
|
||||||
|
### Task 9 — Wire `ProjectZomboidAdminLog::getDefaultAnalyser()`
|
||||||
|
|
||||||
|
- [x] Register all six `Admin<Verb>Information` classes
|
||||||
|
- [x] Add `test/tests/Games/ProjectZomboid/Analyser/AdminLogAnalysisTest.php` — asserts the 2+2+2+2+1+2 distribution and confirms the duplicate ShotgunShells row coalesces with `counter == 2`
|
||||||
|
- [x] `composer test` green: 186 tests
|
||||||
|
- [x] Commit: `c57d646 Wire ProjectZomboidAdminLog default analyser`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Deviations from the original plan
|
||||||
|
|
||||||
|
### The `90c85a0` brace-fix interlude
|
||||||
|
|
||||||
|
Task 2's commit (`90c85a0 Add AdminAddedItemInformation insight`) shipped broken. While adding the first `_ENTRY` constant to `AdminPattern.php`, the `Edit` tool's `old_string` was `<TELEPORTED line>\n}` and the `new_string` included a docblock plus the new constant but **dropped the closing brace** of the class body. The commit was made before the test result was inspected, so it landed with a `ParseError: Unclosed '{'` and 9 cascading test errors.
|
||||||
|
|
||||||
|
Forward-fix `0d85a05 Fix missing closing brace in AdminPattern` restored the brace as a separate commit (per the `CLAUDE.md` workflow rule: "Always create new commits rather than amending"). The broken intermediate commit remains in history; force-pushing master to clean it would have cost more than the cosmetic gain.
|
||||||
|
|
||||||
|
The remaining five admin commits (Tasks 3–7) used a deliberate practice change: every subsequent `Edit` to `AdminPattern.php` included the closing `}` in both `old_string` and `new_string` so it couldn't be dropped again. No further breakage.
|
||||||
|
|
||||||
|
### Total commit count
|
||||||
|
|
||||||
|
11 commits vs the 10 originally outlined in the spec's planning section. The extra commit is the brace-fix.
|
||||||
|
|
||||||
|
### Test-count divergence note (now resolved)
|
||||||
|
|
||||||
|
When Phase B.1's plan was written I projected a final count of 158 tests for B.1; the actual landed count was 161 (off by 3 — Task 5's contribution wasn't summed in the plan footer). For B.2 the planned and actual per-step counts match exactly. No projection error this phase.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Done condition (met)
|
||||||
|
|
||||||
|
After Task 9, `composer test` reports **186 tests, 387 assertions, all green** under PHPUnit 12.5.6 / PHP 8.5.5 (verified via the `composer:latest` Docker image). All five originally-planned analysers from the Step D Phase B scope (B.1's three plus B.2's two) are now operational on their respective Log subclasses.
|
||||||
@@ -0,0 +1,117 @@
|
|||||||
|
# ProjectZomboid analyser design (Phase B.3 — deferred analysers)
|
||||||
|
|
||||||
|
> Retroactive: written 2026-05-01.
|
||||||
|
|
||||||
|
## Summary
|
||||||
|
|
||||||
|
Add the three remaining Project Zomboid analysers from the original Step D candidate list — connection failure pairing, item duplication heuristic, and skill progression anomaly detection — by introducing custom `Analyser` subclasses under `src/Analyser/ProjectZomboid/`. These are the first analysers in the tree that cannot be expressed as configured `PatternAnalyser` instances; they require cross-entry state (event pairing, sliding windows, snapshot deltas) that `PatternAnalyser` does not provide.
|
||||||
|
|
||||||
|
This document covers Phase B.3. Phase B.1 / B.2 docs are at `2026-04-30-pz-analysers-design.md` / `2026-04-30-pz-analysers-pvp-admin-design.md`. With Phase B.3, the original eight-analyser candidate list from Step D is fully implemented.
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
|
||||||
|
- **In scope:** `ConnectionFailureAnalyser` + `ConnectionFailureProblem` (UserLog, event pairing); `ItemDuplicationAnalyser` + `ItemDuplicationProblem` (ItemLog, sliding-window heuristic); `SkillProgressionAnomalyAnalyser` + `SkillProgressionAnomalyProblem` (PerkLog, consecutive-snapshot delta); wiring three Log subclasses' `getDefaultAnalyser()`; extending two synthetic fixtures to exercise trigger and non-trigger cases; end-to-end tests.
|
||||||
|
- **Out of scope (B.3):** the five other PZ logs whose `getDefaultAnalyser()` continues returning an empty `PatternAnalyser` stub (Chat, ClientAction, Cmd, Map, BurdJournals); the codex-side `Redactor` utility; Hytale / Minecraft / Seven Days To Die analysers; v0.1.0 release plumbing.
|
||||||
|
|
||||||
|
## Architectural shift: custom `Analyser` subclasses
|
||||||
|
|
||||||
|
Phases B.1 and B.2 established the convention that vanilla `PatternAnalyser` plus `Insight::isEqual()` coalescing is sufficient for per-entry pattern matching, and a custom Analyser subclass is **not** needed even for multi-line records (PatternParser's continuation-line behaviour combined with `Entry::__toString()` joins solves multi-line capture without subclassing).
|
||||||
|
|
||||||
|
Phase B.3's three analysers genuinely require cross-entry state:
|
||||||
|
|
||||||
|
- **ConnectionFailureAnalyser** must count `attempting to join` and `allowed to join` events per Steam ID and report unmatched attempts. PatternAnalyser dispatches each entry independently and has no mechanism to compare counts across entries.
|
||||||
|
- **ItemDuplicationAnalyser** must group positive-delta item events by `(steamid, item)` tuple and slide a fixed-second window across each group. Sliding-window logic spans multiple entries by definition.
|
||||||
|
- **SkillProgressionAnomalyAnalyser** must collect all perks-row snapshots per Steam ID, sort them by time, then compute pairwise deltas between consecutive snapshots. Pairwise comparison spans entries.
|
||||||
|
|
||||||
|
Each subclass extends the framework's abstract `Analyser`, overrides `analyse(): AnalysisInterface`, walks `$this->log` once to aggregate state, and emits `Problem` insights at the end. The CLAUDE.md "Framework architecture" section was updated alongside Phase B.3 to document this pattern.
|
||||||
|
|
||||||
|
## Components
|
||||||
|
|
||||||
|
Three `Analyser` subclasses under `src/Analyser/ProjectZomboid/` (the directory's `.gitkeep` placeholder is removed in this phase):
|
||||||
|
|
||||||
|
| Analyser | Target Log | Logic shape | Threshold constants |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `ConnectionFailureAnalyser` | `ProjectZomboidUserLog` | Two-pass count of attempt vs allowed events per Steam ID; emits one Problem per Steam ID where attempts > allowed | None — strict pairing |
|
||||||
|
| `ItemDuplicationAnalyser` | `ProjectZomboidItemLog` | Sliding-window heuristic over `(steamid, item)` groups | `THRESHOLD_COUNT = 5`, `THRESHOLD_WINDOW_SECONDS = 10` |
|
||||||
|
| `SkillProgressionAnomalyAnalyser` | `ProjectZomboidPerkLog` | Consecutive-snapshot delta per `(steamid, skill)`; only positive-delta perks-row entries (Login/Logout/LevelUp event tokens are filtered out) | `THRESHOLD_DELTA = 3` |
|
||||||
|
|
||||||
|
Three `Problem` subclasses under `src/Analysis/ProjectZomboid/`:
|
||||||
|
|
||||||
|
| Problem | Coalescing |
|
||||||
|
|---|---|
|
||||||
|
| `ConnectionFailureProblem` | By Steam ID — one problem per player regardless of how many unmatched attempts |
|
||||||
|
| `ItemDuplicationProblem` | By `(steamid, item)` tuple — one problem per suspicious group |
|
||||||
|
| `SkillProgressionAnomalyProblem` | By `(steamid, skill)` — one problem per skill exceeding the delta threshold |
|
||||||
|
|
||||||
|
## Threshold rationale (recorded as docblocks)
|
||||||
|
|
||||||
|
The constants are first-pass heuristics expected to be tuned once production logs flow through codex. Each is documented inline in its analyser class:
|
||||||
|
|
||||||
|
- **`ItemDuplicationAnalyser::THRESHOLD_COUNT = 5`**: Five identical item gains in a fixed window. Legitimate gameplay rarely produces five identical items quickly — crafting has animation delays, looting is one-at-a-time, zombie drops are similarly serial. A burst of five suggests admin-spawn or exploit. Tune downward if false negatives appear.
|
||||||
|
- **`ItemDuplicationAnalyser::THRESHOLD_WINDOW_SECONDS = 10`**: Ten seconds covers a realistic burst-loot scenario (e.g. a crate full of identical items) without collapsing onto unrelated events. Combined with `THRESHOLD_COUNT` this means an effective rate of 0.5 same-item events per second.
|
||||||
|
- **`SkillProgressionAnomalyAnalyser::THRESHOLD_DELTA = 3`**: PZ skills require thousands of XP per level; even active grinding rarely produces four-or-more level jumps in a single session bridge. Set to 3 as baseline; modded XP servers may need to raise this via subclass override.
|
||||||
|
|
||||||
|
## Patterns
|
||||||
|
|
||||||
|
No new pattern constants. Existing constants from Phase A are reused inside the per-entry walks:
|
||||||
|
|
||||||
|
- `UserPattern::PLAYER_EVENT` — decode `[time] <steamid> "<player>" <event>` lines
|
||||||
|
- `ItemPattern::FIELDS` — decode `[time] <steamid> "<player>" <location> <delta> <coords> [<item>]` lines
|
||||||
|
- `PerkPattern::FIELDS` — decode the bracket-heavy perks log line
|
||||||
|
- `PerkPattern::PERK_PAIR` — extract individual `Skill=N` pairs from the perks-row event field
|
||||||
|
|
||||||
|
`Entry::getTime()` returns integer Unix seconds (sub-second precision is dropped by `DateTime::getTimestamp()`). For `ItemDuplicationAnalyser` this means events within the same second collapse to time-diff zero, which is acceptable for v1.
|
||||||
|
|
||||||
|
## Wiring
|
||||||
|
|
||||||
|
Three `getDefaultAnalyser()` overrides (each was previously `return new PatternAnalyser();`):
|
||||||
|
|
||||||
|
```php
|
||||||
|
// ProjectZomboidUserLog
|
||||||
|
return new ConnectionFailureAnalyser();
|
||||||
|
|
||||||
|
// ProjectZomboidItemLog
|
||||||
|
return new ItemDuplicationAnalyser();
|
||||||
|
|
||||||
|
// ProjectZomboidPerkLog
|
||||||
|
return new SkillProgressionAnomalyAnalyser();
|
||||||
|
```
|
||||||
|
|
||||||
|
The unused `PatternAnalyser` import is removed from each Log subclass.
|
||||||
|
|
||||||
|
## Test plan
|
||||||
|
|
||||||
|
End-to-end tests under `test/tests/Games/ProjectZomboid/Analyser/`, one per Log:
|
||||||
|
|
||||||
|
- **`UserLogAnalysisTest`** — drives `user-minimal.txt`. Asserts exactly one `ConnectionFailureProblem` for Player1 (Steam ID `76561198000000001`) with `unmatchedAttempts == 1` (Player1 has two `attempting to join` events, one of which is `attempting to join used queue`, and one `allowed to join`). Asserts that Player2 (matched 1+1) is not flagged.
|
||||||
|
- **`ItemLogAnalysisTest`** — drives the extended `item-minimal.txt`. Asserts one `ItemDuplicationProblem` for AdminUser + Base.Bullets9mm with `eventCount == 6`, and verifies the four-event Base.Plank group does not trigger. Also asserts the threshold constants are positive and documented.
|
||||||
|
- **`PerkLogAnalysisTest`** — drives the extended `perk-minimal.txt`. Asserts exactly two `SkillProgressionAnomalyProblem` insights for PlayerSuspect (Steam ID `76561198000000004`), one for Strength (delta +8) and one for Fitness (delta +6). Verifies that Maintenance (delta exactly +3) does not trigger because the comparison is strict `>`. Verifies that single-snapshot players (Player1, Player2) are not flagged. Asserts the threshold constant is positive and documented.
|
||||||
|
|
||||||
|
## Fixture changes
|
||||||
|
|
||||||
|
Two synthetic fixtures extended (no new files, no real-log content):
|
||||||
|
|
||||||
|
- **`item-minimal.txt`** — appended 10 lines: a 6-event Bullets9mm burst by AdminUser at sub-second timestamps `19:50:00.001`–`.006` (triggers the dupe heuristic), and a 4-event Plank group by Player1 scattered across 4 minutes (`20:00:00`–`20:03:00`, sub-threshold). The Phase A entry-count assertion in `ProjectZomboidItemLogTest` was bumped from 10 → 20.
|
||||||
|
- **`perk-minimal.txt`** — appended 4 lines: PlayerSuspect (Steam ID `76561198000000004`) with two perks snapshots — a low-stat baseline at `18:30:00.000` and an inflated set at `22:00:00.000` showing Strength 2→10, Fitness 2→8, and Maintenance 0→3 (boundary case). The Phase A entry-count assertion in `ProjectZomboidPerkLogTest` was bumped from 6 → 10.
|
||||||
|
|
||||||
|
All identifiers are placeholder per the Privacy / Fixture Rules in CLAUDE.md (`76561198000000001`–`76561198000000004` for Steam IDs, `Player1`/`Player2`/`AdminUser`/`PlayerSuspect` for names, coords in the `1000-1100, 2000-2200, 0` range).
|
||||||
|
|
||||||
|
## Commits (as-built, in order)
|
||||||
|
|
||||||
|
1. `c444e85` — `pre-phase-B.3 checkpoint` (`--allow-empty`)
|
||||||
|
2. `73e9ca6` — `Add ConnectionFailureAnalyser`
|
||||||
|
3. `ba3fae8` — `Add ItemDuplicationAnalyser`
|
||||||
|
4. `0c90e40` — `Add SkillProgressionAnomalyAnalyser`
|
||||||
|
|
||||||
|
4 commits total. Each non-checkpoint commit ships an Analyser + Problem + (optional) fixture extension + updated count assertion + e2e test in one logical unit, per the per-analyser commit shape requested up front.
|
||||||
|
|
||||||
|
## Open issues
|
||||||
|
|
||||||
|
None blocking. All three threshold constants are heuristic guesses pending production data calibration; tuning is expected once iblogs starts feeding real logs through codex. The values are tunable via subclass override and the rationale is in the source docblocks.
|
||||||
|
|
||||||
|
## Pointers
|
||||||
|
|
||||||
|
- Phase B.1 (foundation, ServerLog analysers): `2026-04-30-pz-analysers-design.md` and `2026-04-30-pz-analysers.md`.
|
||||||
|
- Phase B.2 (vanilla PatternAnalyser PvP/Admin coverage): `2026-04-30-pz-analysers-pvp-admin-design.md` and `2026-04-30-pz-analysers-pvp-admin.md`.
|
||||||
|
- Workflow conventions and architecture overview: `CLAUDE.md`.
|
||||||
|
- The Phase B.3 commit set begins at `c444e85` (pre-checkpoint) and ends at `0c90e40` (the third analyser).
|
||||||
@@ -0,0 +1,106 @@
|
|||||||
|
# ProjectZomboid analyser design (Phase B.2)
|
||||||
|
|
||||||
|
> Retroactive: written 2026-05-01.
|
||||||
|
|
||||||
|
## Summary
|
||||||
|
|
||||||
|
Add Project Zomboid PvP combat detection (filtering zombie hits and zero-damage events) and admin verb-dispatch coverage of six action types, by registering seven new `Information` insight classes onto the existing `PatternAnalyser`. No custom `Analyser` subclasses are introduced in this phase — all dispatch fits within `PatternAnalyser`'s per-entry pattern matching.
|
||||||
|
|
||||||
|
This document covers Phase B.2. Phase B.1 is in `2026-04-30-pz-analysers-design.md`. Phase B.3 (cross-entry / threshold analysers requiring custom `Analyser` subclasses) is in `2026-04-30-pz-analysers-deferred-design.md`.
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
|
||||||
|
- **In scope:** `PvpDamageInformation` + `PvpPattern::COMBAT_REAL` regex; six `Admin<Verb>Information` classes + six `AdminPattern::<VERB>_ENTRY` regex constants; wiring `ProjectZomboidPvpLog::getDefaultAnalyser()` and `ProjectZomboidAdminLog::getDefaultAnalyser()`; end-to-end tests for both logs.
|
||||||
|
- **Out of scope (B.2):** any cross-entry / threshold / pairing logic (deferred to B.3); the eight other PZ logs whose `getDefaultAnalyser()` continues returning an empty `PatternAnalyser` stub; the codex-side `Redactor` utility (deferred — see `2026-04-30-redactor-design.md`).
|
||||||
|
|
||||||
|
## Architectural decision: vanilla PatternAnalyser
|
||||||
|
|
||||||
|
Phase B.1 established that `PatternAnalyser` plus `Insight::isEqual()` coalescing covers single-entry pattern matching cleanly. Phase B.2's analysers (PvP damage rows, admin verb lines) all fit that mould — each interesting line is independent of the others, dispatch is per-entry, and counter-coalescing handles repeats. No `Analyser` subclassing required. (Phase B.3 will deviate from this when cross-entry logic enters the picture.)
|
||||||
|
|
||||||
|
## Components
|
||||||
|
|
||||||
|
All under `src/Analysis/ProjectZomboid/`:
|
||||||
|
|
||||||
|
| Class | Type | Pattern | Coalescing |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `PvpDamageInformation` | Information | `PvpPattern::COMBAT_REAL` | Default `Information::isEqual` (label + value) — same attacker/victim/weapon coalesces |
|
||||||
|
| `AdminAddedItemInformation` | Information | `AdminPattern::ADDED_ITEM_ENTRY` | Default — same admin/item/target coalesces |
|
||||||
|
| `AdminAddedXpInformation` | Information | `AdminPattern::ADDED_XP_ENTRY` | Default — same admin/amount/skill/target coalesces |
|
||||||
|
| `AdminGrantedAccessInformation` | Information | `AdminPattern::GRANTED_ACCESS_ENTRY` | Default — same admin/level/target coalesces |
|
||||||
|
| `AdminChangedOptionInformation` | Information | `AdminPattern::CHANGED_OPTION_ENTRY` | Default — same admin/option/value coalesces |
|
||||||
|
| `AdminReloadedOptionsInformation` | Information | `AdminPattern::RELOADED_OPTIONS_ENTRY` | Default — same admin coalesces |
|
||||||
|
| `AdminTeleportedInformation` | Information | `AdminPattern::TELEPORTED_ENTRY` | Default — same admin/target/coords coalesces |
|
||||||
|
|
||||||
|
## Patterns
|
||||||
|
|
||||||
|
Seven new constants total.
|
||||||
|
|
||||||
|
**`PvpPattern::COMBAT_REAL`** — combat regex with the noise filter baked in. The negative lookahead `(?!zombie")` rejects zombie weapon rows; the damage clause uses alternation to match only positive non-zero floats:
|
||||||
|
|
||||||
|
```
|
||||||
|
'/Combat: "(?<attacker>[^"]+)" \([^)]+\) hit "(?<victim>[^"]+)" \([^)]+\) weapon="(?<weapon>(?!zombie")[^"]+)" damage=(?<damage>0\.0*[1-9][0-9]*|[1-9][0-9]*\.[0-9]+)/'
|
||||||
|
```
|
||||||
|
|
||||||
|
The damage alternation explicitly rejects `0.000000` and any leading-minus value because both branches require either `0.<non-zero>` or `<non-zero>.<digits>`.
|
||||||
|
|
||||||
|
**`AdminPattern::<VERB>_ENTRY`** — six entry-anchored variants of the existing body-only verb constants. Necessary because `PatternAnalyser` calls `preg_match_all` against the full Entry text (including the `[time]` prefix), so the Phase A verb constants anchored at `^<admin>` would never match. The Phase A constants stay intact for direct-message use; new ones live alongside them on the same `AdminPattern` class.
|
||||||
|
|
||||||
|
## Wiring
|
||||||
|
|
||||||
|
Two `getDefaultAnalyser()` overrides (was `return new PatternAnalyser();` for both):
|
||||||
|
|
||||||
|
```php
|
||||||
|
// ProjectZomboidPvpLog
|
||||||
|
return (new PatternAnalyser())
|
||||||
|
->addPossibleInsightClass(PvpDamageInformation::class);
|
||||||
|
```
|
||||||
|
|
||||||
|
```php
|
||||||
|
// ProjectZomboidAdminLog
|
||||||
|
return (new PatternAnalyser())
|
||||||
|
->addPossibleInsightClass(AdminAddedItemInformation::class)
|
||||||
|
->addPossibleInsightClass(AdminAddedXpInformation::class)
|
||||||
|
->addPossibleInsightClass(AdminGrantedAccessInformation::class)
|
||||||
|
->addPossibleInsightClass(AdminChangedOptionInformation::class)
|
||||||
|
->addPossibleInsightClass(AdminReloadedOptionsInformation::class)
|
||||||
|
->addPossibleInsightClass(AdminTeleportedInformation::class);
|
||||||
|
```
|
||||||
|
|
||||||
|
## Test plan
|
||||||
|
|
||||||
|
Unit tests under `test/tests/Games/ProjectZomboid/Analysis/`, one per Insight class — exercises `getPatterns()` shape, `setMatches()` extraction, and at least one filter-rejection case for `PvpDamageInformation` (zombie weapon and zero-damage rejection).
|
||||||
|
|
||||||
|
End-to-end tests under `test/tests/Games/ProjectZomboid/Analyser/`:
|
||||||
|
|
||||||
|
- `PvpLogAnalysisTest` against `pvp-minimal.txt`: asserts exactly three `PvpDamageInformation` insights (Bare Hands, Tire Iron (Worn), Hunting Knife). Zombie and vehicle rows must be filtered out by the regex.
|
||||||
|
- `AdminLogAnalysisTest` against `admin-minimal.txt`: asserts 2 + 2 + 2 + 2 + 1 + 2 = 11 insights across the six admin classes, with the duplicate ShotgunShells row coalescing into a single insight at `counter == 2`.
|
||||||
|
|
||||||
|
## Fixture changes
|
||||||
|
|
||||||
|
None. The Phase A synthetic fixtures `pvp-minimal.txt` and `admin-minimal.txt` already cover every code path Phase B.2 exercises.
|
||||||
|
|
||||||
|
## Commits (as-built, in order)
|
||||||
|
|
||||||
|
1. `df62da1` — `pre-phase-B.2 checkpoint` (`--allow-empty`)
|
||||||
|
2. `55f769c` — `Add PvpDamageInformation insight`
|
||||||
|
3. `90c85a0` — `Add AdminAddedItemInformation insight` ⚠️ broken — see `2026-04-30-pz-analysers-pvp-admin.md` §Deviations
|
||||||
|
4. `0d85a05` — `Fix missing closing brace in AdminPattern` (forward-fix for #3)
|
||||||
|
5. `a2faa55` — `Add AdminAddedXpInformation insight`
|
||||||
|
6. `caed04d` — `Add AdminGrantedAccessInformation insight`
|
||||||
|
7. `b7b89ef` — `Add AdminChangedOptionInformation insight`
|
||||||
|
8. `64641fa` — `Add AdminReloadedOptionsInformation insight`
|
||||||
|
9. `d15fc81` — `Add AdminTeleportedInformation insight`
|
||||||
|
10. `51eb2de` — `Wire ProjectZomboidPvpLog default analyser`
|
||||||
|
11. `c57d646` — `Wire ProjectZomboidAdminLog default analyser`
|
||||||
|
|
||||||
|
11 commits total, vs 10 originally planned. The brace-fix commit accounts for the discrepancy.
|
||||||
|
|
||||||
|
## Open issues
|
||||||
|
|
||||||
|
None blocking. Phase A Q4 (admin verb scope) was settled before B.2 began. Phase B Q2 confirmed PvP fixtures contain real combat events worth analysing.
|
||||||
|
|
||||||
|
## Pointers
|
||||||
|
|
||||||
|
- Phase B.1 (foundation): `2026-04-30-pz-analysers-design.md` and `2026-04-30-pz-analysers.md`.
|
||||||
|
- Phase B.3 (deferred analysers requiring custom `Analyser` subclasses): `2026-04-30-pz-analysers-deferred-design.md`.
|
||||||
|
- Workflow conventions: `CLAUDE.md` § Workflow conventions and § Pitfalls.
|
||||||
150
docs/superpowers/specs/2026-04-30-redactor-design.md
Normal file
150
docs/superpowers/specs/2026-04-30-redactor-design.md
Normal file
@@ -0,0 +1,150 @@
|
|||||||
|
# Codex Redactor utility — design spec
|
||||||
|
|
||||||
|
> Retroactive: written 2026-05-01.
|
||||||
|
> **Status: deferred — not implemented.** This is a forward-looking design captured here for backfill symmetry and to inform iblogs's upload-time PII handling.
|
||||||
|
|
||||||
|
## Summary
|
||||||
|
|
||||||
|
Codex grows a small utility surface for redacting personally-identifying data from log content before it is stored, displayed, or analysed in environments where preservation of PII is unwanted. The shape is a thin generic interface plus per-game implementations that know each game's log format. iblogs is the primary line of defence (upload-time filter); codex's redactor is the optional helper consumers can call when they want codex itself to scrub data.
|
||||||
|
|
||||||
|
## Why deferred
|
||||||
|
|
||||||
|
The Phase A Step E open-questions table (Q5) marked the codex-side redactor as "defer to its own session" because the iblogs upload-time filter is the actual privacy boundary — anything codex does in this layer is a convenience, not a guarantee. Phase B (the analyser arc) shipped without the redactor and remains useful: synthetic fixtures use placeholder identifiers throughout, real Logs.zip never reaches the index, and the privacy story for codex's tests does not depend on this utility. Building it remains worthwhile when iblogs starts consuming codex output and wants a one-line option for "scrub before analyse."
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
|
||||||
|
- **In scope (when this spec is implemented):** a `RedactorInterface` under `src/Util/`, a `ProjectZomboidRedactor` implementation that handles the three PII categories observed in PZ logs (Steam IDs, player names, world coordinates), per-category toggles with a defaults-on stance, replacement-string conventions matching the synthetic fixture placeholders.
|
||||||
|
- **Out of scope:** non-PZ game redactors (those land alongside their respective game implementations); UI / CLI wrappers; redaction of mod-specific identifiers (e.g. BurdJournals scientific-notation Steam IDs) — handled by an extension of the PZ implementation if/when needed; storage / persistence of redaction maps.
|
||||||
|
|
||||||
|
## Architecture
|
||||||
|
|
||||||
|
```
|
||||||
|
+-------------------------+
|
||||||
|
| RedactorInterface |
|
||||||
|
| (src/Util/) |
|
||||||
|
| redact(string): string|
|
||||||
|
+-----------+-------------+
|
||||||
|
|
|
||||||
|
+-----------------------+-----------------------+
|
||||||
|
| |
|
||||||
|
+------------v-----------------+ +--------------v-------------+
|
||||||
|
| ProjectZomboidRedactor | | (Future) MinecraftRedactor |
|
||||||
|
| (src/Util/ProjectZomboid/) | | (src/Util/Minecraft/) |
|
||||||
|
+------------------------------+ +----------------------------+
|
||||||
|
```
|
||||||
|
|
||||||
|
A thin interface in the framework's `Util` namespace. One concrete implementation per supported game, mirroring the existing components-outer-with-game-suffix layout used everywhere else in the tree (Analyser, Analysis, Detective, Log, Parser, Pattern). Future games' redactors land alongside their analyser surface.
|
||||||
|
|
||||||
|
## Why per-game implementations rather than a single regex utility
|
||||||
|
|
||||||
|
PII detection in log text is **context-sensitive**, not just regex matching:
|
||||||
|
|
||||||
|
- **Steam IDs** are 17-digit decimal numbers. Almost regexable, but care is needed not to chew through unrelated long numbers (timestamps, build numbers, GUIDs that happen to be 17 digits).
|
||||||
|
- **Player names** are arbitrary strings. They cannot be detected from text alone — a redactor needs to know the lexical contexts where names appear (`<steamid> "Name"`, `ChatMessage{author='Name'}`, `Combat: "Name"`). Without that knowledge a naive `\w+`-style match would shred the entire log.
|
||||||
|
- **Coordinates** are number triples in specific shapes (`x,y,z` after `at`, `[x,y,z]` between brackets, `(x,y,z)` in PvP combat lines). Stripping every "two commas in a row" regex match would over-redact (e.g. `f:0, t:1776297642406, st:48,648,157,584` is server metadata, not coordinates).
|
||||||
|
|
||||||
|
Per-game implementations encode the lexical contexts. PZ's redactor uses the same regex shapes Phase A's Pattern classes encode for parsing, applied in a different direction (replacement instead of extraction).
|
||||||
|
|
||||||
|
## Components
|
||||||
|
|
||||||
|
### `src/Util/RedactorInterface.php`
|
||||||
|
|
||||||
|
```php
|
||||||
|
namespace IndifferentKetchup\Codex\Util;
|
||||||
|
|
||||||
|
interface RedactorInterface
|
||||||
|
{
|
||||||
|
/**
|
||||||
|
* Return a copy of $content with PII replaced by placeholder tokens
|
||||||
|
* according to the redactor's enabled toggles.
|
||||||
|
*/
|
||||||
|
public function redact(string $content): string;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
A single method. Stateless from the caller's perspective; toggles are configured on the concrete implementation before `redact()` is called.
|
||||||
|
|
||||||
|
### `src/Util/ProjectZomboid/ProjectZomboidRedactor.php`
|
||||||
|
|
||||||
|
Implements `RedactorInterface`. Three independent toggles (defaults all on) and three regex-driven replacement passes:
|
||||||
|
|
||||||
|
```php
|
||||||
|
namespace IndifferentKetchup\Codex\Util\ProjectZomboid;
|
||||||
|
|
||||||
|
use IndifferentKetchup\Codex\Util\RedactorInterface;
|
||||||
|
|
||||||
|
class ProjectZomboidRedactor implements RedactorInterface
|
||||||
|
{
|
||||||
|
private bool $redactSteamIds = true;
|
||||||
|
private bool $redactPlayerNames = true;
|
||||||
|
private bool $redactCoordinates = true;
|
||||||
|
|
||||||
|
public function redactSteamIds(bool $on): static { /* ... */ }
|
||||||
|
public function redactPlayerNames(bool $on): static { /* ... */ }
|
||||||
|
public function redactCoordinates(bool $on): static { /* ... */ }
|
||||||
|
|
||||||
|
public function redact(string $content): string
|
||||||
|
{
|
||||||
|
if ($this->redactSteamIds) { /* preg_replace */ }
|
||||||
|
if ($this->redactPlayerNames) { /* preg_replace */ }
|
||||||
|
if ($this->redactCoordinates) { /* preg_replace */ }
|
||||||
|
return $content;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
### Replacement conventions
|
||||||
|
|
||||||
|
To match the synthetic fixture placeholders already used throughout the test suite (per the Privacy / fixture rules in CLAUDE.md):
|
||||||
|
|
||||||
|
| PII category | Replacement |
|
||||||
|
|---|---|
|
||||||
|
| Steam ID (17 decimal digits in a Steam ID context) | `76561198000000000` |
|
||||||
|
| Player name (between `"..."` after a 17-digit Steam ID, between `'...'` in `ChatMessage{author='...'}`, between `"..."` after subsystem keywords like `Combat:` / `Safety:`) | `<player>` |
|
||||||
|
| World coordinates (the `x,y,z` or `(x,y,z)` triples in PZ log lines, distinguished by leading-context anchors so server metadata triples are not stripped) | `0,0,0` |
|
||||||
|
|
||||||
|
The replacements are deliberately not reversible — codex makes no attempt to maintain a map between original and redacted values. Reversibility is a different feature scope (encryption / tokenization) and is not what this utility provides.
|
||||||
|
|
||||||
|
### Lexical anchors for the regex passes
|
||||||
|
|
||||||
|
Steam ID: `(?<![\w])(?P<sid>76561198\d{9})(?![\w])` — the `76561198` prefix matches the SteamID64 universe prefix for Steam (region "Individual"); avoids matching unrelated 17-digit numbers. Boundary classes prevent matching inside a longer alphanumeric token.
|
||||||
|
|
||||||
|
Player name (PZ-specific contexts):
|
||||||
|
- After Steam ID quoted: `(?<sid>76561198000000000) "(?P<name>[^"]+)"` → preserve the redacted Steam ID, replace the quoted name. (Redaction order matters: SIDs first, names second.)
|
||||||
|
- ChatMessage author: `ChatMessage\{chat=\w+, author='(?P<name>[^']+)',` → replace the captured author.
|
||||||
|
- PvP / Safety subsystem: `(?P<sub>Combat|Safety): "(?P<name>[^"]+)"` → replace the captured name.
|
||||||
|
|
||||||
|
Coordinates:
|
||||||
|
- ItemLog / MapLog / CmdLog `at` clauses: `at (?P<coords>[\d.]+,[\d.]+,-?[\d.]+)\.` → replace with `0,0,0.`
|
||||||
|
- ClientActionLog / PerkLog bracketed coords: `\[(?P<coords>\d+,\d+,-?\d+)\]` → replace with `[0,0,0]`
|
||||||
|
- PvP combat parenthesised coords: `\((?P<coords>\d+,\d+,-?\d+)\) (?:hit|restore|store|true|false)` — the trailing context disambiguates from server metadata triples.
|
||||||
|
|
||||||
|
These regex shapes are not yet committed to the spec implementation; tuning is expected during the actual implementation pass against the real `Logs.zip` content under `.scratch/pz/Logs/`.
|
||||||
|
|
||||||
|
## Where this fits relative to iblogs
|
||||||
|
|
||||||
|
The Phase A Step D Section e split holds: **iblogs is the primary line of defence**. iblogs filters PII at upload time, before storage, mirroring the mclogs IP/token redaction approach. Stored logs in iblogs are pre-sanitised. The codex `Redactor` is the *option* iblogs (or any other consumer) reaches for if they want codex itself to do the scrubbing — for example in a preview pipeline that wants to render redacted output without writing the raw paste to disk first, or in a dev environment where the same code path runs without iblogs's upload filter.
|
||||||
|
|
||||||
|
This means the codex Redactor is **non-load-bearing** for the privacy story. iblogs implementing redaction independently is the actual safety guarantee; codex's helper is a convenience.
|
||||||
|
|
||||||
|
## Test plan (when implemented)
|
||||||
|
|
||||||
|
Synthetic-only fixtures, no real-log content:
|
||||||
|
|
||||||
|
1. Three pairs of fixture-input / expected-output strings exercising each category in isolation.
|
||||||
|
2. One combined-input fixture demonstrating that all three categories applied to the same content produce a fully-scrubbed output.
|
||||||
|
3. Toggle tests: each of the three booleans turned off in isolation produces partial scrubbing; all three off produces an unchanged copy of input (the redactor returns input verbatim).
|
||||||
|
4. Idempotence test: `redact(redact($x)) == redact($x)`.
|
||||||
|
5. A small "negative" test: server metadata triples (`f:0, t:1776297642406, st:48,648,157,584`) are not mistaken for coordinates.
|
||||||
|
|
||||||
|
## Open questions
|
||||||
|
|
||||||
|
1. **Should the redactor optionally preserve some structure for analysers downstream?** For example, after redaction the analysers can no longer correlate by Steam ID across events because every Steam ID is the same placeholder. Two paths: (a) accept the loss — redaction is done before storage and you don't analyse redacted content, or (b) provide a "tokenizing redactor" that maps each unique input value to a unique placeholder (`76561198000000001`, `76561198000000002`, ...) preserving cardinality. Recommend (a) for v1; (b) is its own design pass.
|
||||||
|
2. **What about `BurdJournals.txt`'s scientific-notation Steam IDs?** Phase A Step C noted these as `7.656119799341651E16` form. The PZ redactor's Steam ID regex doesn't match this shape. v1 leaves them intact (tag `[BurdJournals]` already disambiguates them as mod-internal). v2 could add a separate regex for the sci-notation form.
|
||||||
|
3. **Should `coords` redaction try to preserve relative location** (e.g. round to the nearest 1000-tile chunk so the *region* is visible without giving precise base coords)? Out of scope for v1.
|
||||||
|
|
||||||
|
## Pointers
|
||||||
|
|
||||||
|
- Phase A original Q5 deferral: `2026-04-30-pz-analysers-design.md` referenced this; the explicit deferral lived in chat (Phase A Step E open-questions table).
|
||||||
|
- iblogs upload-time filtering decisions: see the iblogs bootstrap spec at `2026-05-01-iblogs-bootstrap-design.md`.
|
||||||
|
- Existing Pattern classes that the regex shapes will mirror in reverse: `src/Pattern/ProjectZomboid/{CmdPattern,ItemPattern,MapPattern,PerkPattern,ClientActionPattern,ChatPattern,PvpPattern,UserPattern}.php`.
|
||||||
Reference in New Issue
Block a user