indifferentketchup/boocode
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

batch3 T8 review fix: preserve cloneElement key in linkifyChildren

Browse Source 
cloneElement does not carry el.key through unless explicitly passed.
Without it, react-markdown's inline-element siblings (strong/em/text)
lose their reconciler keys on every render, causing potential diffing
churn. Pass el.key (with fallback) explicitly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
indifferentketchup
2026-05-15 15:58:45 +00:00
parent eca4aa8382
commit 89d685105a
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
apps/web/src/components/MessageBubble.tsx
View File

@@ -74,6 +74,7 @@ function linkifyChildren(children: ReactNode, keyPrefix = 'l'): ReactNode {
const grandchildren = el.props.children; const grandchildren = el.props.children;
if (grandchildren === undefined) return child; if (grandchildren === undefined) return child;
return cloneElement(el, { return cloneElement(el, {
key: el.key ?? `linkified-${i}`,
children: linkifyChildren(grandchildren, `${keyPrefix}-${i}`), children: linkifyChildren(grandchildren, `${keyPrefix}-${i}`),
}); });
} }