Compare commits
19 Commits
024ffc0b92
...
v2.6.3-cha
| Author | SHA1 | Date | |
|---|---|---|---|
| 30b6f70f95 | |||
| c2b3e0a013 | |||
| cb1846c0d5 | |||
| f1a85627e4 | |||
| c65daba5dd | |||
| c9e302da37 | |||
| f69ea5f494 | |||
| 3a26563be2 | |||
| 937920df06 | |||
| e05469c6ae | |||
| 0e026be5f8 | |||
| 315cdd23e2 | |||
| 6d24726c3a | |||
| 1bbeaf95c7 | |||
| e30a9e8b23 | |||
| 140ff26204 | |||
| a97293b5d9 | |||
| 63adb218e6 | |||
| d0334ca544 |
2
.gitignore
vendored
2
.gitignore
vendored
@@ -16,5 +16,5 @@ data/*
|
|||||||
!data/AGENTS.md
|
!data/AGENTS.md
|
||||||
!data/skills/
|
!data/skills/
|
||||||
!data/mcp.json
|
!data/mcp.json
|
||||||
!data/coder-providers.json
|
!data/coder-providers.example.json
|
||||||
codecontext/fork.tar.gz
|
codecontext/fork.tar.gz
|
||||||
|
|||||||
@@ -44,7 +44,7 @@ BooCoder's coding agents are a **config-backed registry**: built-ins live in `pr
|
|||||||
|
|
||||||
### Config file: `data/coder-providers.json`
|
### Config file: `data/coder-providers.json`
|
||||||
|
|
||||||
Resolved from `CODER_PROVIDERS_PATH` (default `/data/coder-providers.json`; dev/host path `/opt/boocode/data/coder-providers.json`). It is **tracked in git** via a `.gitignore` exception (the rest of `data/*` is ignored). A missing file, invalid JSON, or a schema mismatch all fall back to built-ins-only — loading never throws at startup.
|
Resolved from `CODER_PROVIDERS_PATH` (default `/data/coder-providers.json`; dev/host path `/opt/boocode/data/coder-providers.json`). It is **gitignored** — it's live runtime config that the coder reads *and writes* (UI toggles `PATCH` it), so tracking it would churn `git status`. The tracked reference is `data/coder-providers.example.json`; copy it to `coder-providers.json` to seed overrides. A missing file, invalid JSON, or a schema mismatch all fall back to built-ins-only — loading never throws at startup.
|
||||||
|
|
||||||
```json
|
```json
|
||||||
{
|
{
|
||||||
|
|||||||
16
CHANGELOG.md
16
CHANGELOG.md
@@ -2,6 +2,22 @@
|
|||||||
|
|
||||||
All notable changes per release tag. Most recent on top, ordered by tag creation date (which matches the git history). Tag names follow `vMAJOR.MINOR.PATCH-slug` — the slug describes what shipped, so the tag name alone is enough to recall the batch.
|
All notable changes per release tag. Most recent on top, ordered by tag creation date (which matches the git history). Tag names follow `vMAJOR.MINOR.PATCH-slug` — the slug describes what shipped, so the tag name alone is enough to recall the batch.
|
||||||
|
|
||||||
|
## v2.6.3-chatkey-and-skills — 2026-05-31
|
||||||
|
|
||||||
|
Three threads. **agent_sessions re-keyed to `(chat_id, agent)` (P1.5-b):** the tab (a chat) is now the agent-context unit, so two opencode tabs in one BooCode session are two independent contexts that share one worktree. `chat_id` is threaded end-to-end — `tasks.chat_id` added, stamped by the coder message + skills routes from the frontend tab, read by `runOpenCodeServerTask` which falls back to resolve-or-create a chat for session-less creators (arena/MCP/new_task/generic `/api/tasks`) so `ensureSession` never receives a degenerate `(null, agent)` key. A new first-class `worktrees` table (one-per-session, survives session delete via `session_id ON DELETE SET NULL`) supersedes `session_worktrees`, which is defanged (CASCADE dropped, not yet removed); `agent_sessions.chat_id` CASCADEs from `chats` (closing a tab ends its context) while `worktree_id`/`session_id` are informational `SET NULL`. The migration is idempotent with a backfill-verify gate; the live re-key was applied against an empty table after the 35-chat test session `20d28876` was deleted (backed up first). This corrects and supersedes an earlier draft that wrongly keyed on `(worktree_id, agent)`; the delete-guard from `v2.6.2-delete-guard-and-sse` is repointed here from `session_worktrees` to `worktrees` (`worktree_path`→`path`). **dcp-strip cross-chunk fix:** the `<dcp-message-id>` tag streams split across SSE deltas, which the per-chunk strip from `v2.6.1-phase1-opencode` missed — a stateful `makeDcpStreamStripper` at the dispatcher boundary holds back partial-tag tails so neither live frames nor persisted content carry the tag (11 unit tests). **Agent-judgment skills:** `committing-changes` (segment by concern, stage explicitly, present-and-stop, never push) and `using-worktrees` (the when-to-isolate heuristic, autonomous-when-clear vs committing's command-gate) land in `data/skills/boocode/` with eval.yamls, plus a parser-safe `data/AGENTS.md` preamble pointing at both.
|
||||||
|
|
||||||
|
## v2.6.2-delete-guard-and-sse — 2026-05-30
|
||||||
|
|
||||||
|
Two coder-side batches under one tag. **Session-delete work-loss guard:** deleting a BooChat session CASCADE-wipes its `session_worktrees` row, which would silently orphan uncommitted/unpushed/unmerged work — so the server's `DELETE /api/sessions/:id` now gates before the delete. It reads `session_worktrees` from the shared DB first (no row → chat-only session → delete immediately, zero round-trip), and for worktree-backed sessions calls a new BooCoder endpoint (`/worktree-risk`) that runs git on the host, since the container can't see `/tmp/booworktrees` — only the host systemd service can. `checkWorktreeWorkAtRisk` reports dirty/unpushed/unmerged via the audited `hostExec`+`shellEscape` path, default branch detected from `refs/remotes/origin/HEAD` (never the worktree's own branch, never hardcoded); any at-risk worktree returns 409 with per-worktree `RiskReport[]`, `force=true` bypasses, and the check is fail-closed (BooCoder unreachable also blocks — force still escapes). The sidebar renders a block dialog distinguishing work-at-risk (Commit/Stash/Force; stash uses `-u` and re-blocks on remaining commits) from couldn't-verify (Cancel/Force), and Commit never auto-commits. A follow-up fix gates the `unpushed` arm behind an actual upstream (`atRisk = dirty || unmerged > 0 || (hasUpstream && unpushed > 0)`) so the no-upstream `session-<id>` branches stop flagging every pristine worktree-backed session — no protection lost, since real local work always also surfaces as `unmerged > 0`. **Per-session SSE (P1.5-a):** replaces the single global SSE loop scoped to the most-recent worktree directory — the known limit flagged in `v2.6.1-phase1-opencode` — with one `event.subscribe({directory})` per live opencode session, so sessions in different worktrees stream concurrently instead of the second silently dropping the first's events. Each session owns an `AbortController` wired into `subscribe(…, {signal})`, which also fixes a latent Phase-1 bug where switching directories left the old loop parked forever in its `for await` (zombie loops); a `sessionID` demux guard drops cross-session events so two sessions sharing a worktree (possible after P1.5-b) don't double-process deltas. The opencode SDK was confirmed to open an independent SSE connection per `subscribe()` call, so N concurrent dir-scoped streams are supported.
|
||||||
|
|
||||||
|
## v2.6.1-phase1-opencode — 2026-05-30
|
||||||
|
|
||||||
|
v2.6 Phase 1: opencode runs as a warm HTTP server (`apps/coder/src/services/backends/opencode-server.ts`) — one `opencode serve` per BooCoder process, one opencode session per BooCode session resumed across turns via the new `agent_sessions` table, with a single SSE read loop, reasoning dedup ported from Paseo, an inactivity watchdog, and a stale-session guard (crashed-not-resumed + a `config_hash` fingerprint over `opencode_server|<model>`, deliberately excluding the ephemeral server port so cross-restart resume survives). Builds on the `v2.6.0-phase0-foundations` schema/interface scaffold. The batch's hard-won fixes: opencode streams `session.next.*` events (not `message.part.*`), and `event.subscribe()` must pass the session's worktree `directory` or events route to the server CWD and turns come back empty; model strings must be `llama-swap/`-prefixed and present in opencode's own config, with `agent-probe` now populating `available_agents.models` via `mergeLlamaSwap` so the frontend stops sending an empty model; `session_worktrees`/`agent_sessions` FKs are `ON DELETE CASCADE` so session deletion no longer 500s. Also bundled: dcp-message-id tag stripping from opencode text output, a reopen-closed-pane control, the `[+]`/split-pane button separation, auto-name using the session's loaded model, and a `systematic-debugging` slash command. Smoke 1 verified end-to-end (two turns, session reuse, turn 2 ~9x faster). Known Phase 1 limit: one SSE stream scoped to the most-recent session's directory — concurrent opencode sessions in different worktrees collide (warns; per-session SSE is Phase 2).
|
||||||
|
|
||||||
|
## v2.5.15-acp-path-guard — 2026-05-29
|
||||||
|
|
||||||
|
Security fix + repo hygiene. Fixes a path-traversal in the ACP filesystem bridge (`acp-client-fs.ts`, flagged by the automated push security review): the worktree guard used an unbounded `startsWith(resolve(worktreePath))`, so a sibling path sharing the worktree as a string prefix (`<worktree>-evil/…`) escaped the scope — and `writeWorktreeTextFile` writes to disk directly (no `pending_changes` gate), so a confused/buggy ACP agent could write outside its worktree. Now uses a separator-bounded check matching `write_guard.ts` (`resolve()` + `startsWith(root + sep)` / `=== root`) via a shared `resolveInWorktree`, with a regression test covering `../` traversal and the sibling-prefix bug. Symlink-swap/`O_NOFOLLOW` hardening was intentionally skipped — consistent with `write_guard`'s no-realpath stance, and the agent already runs with host FS access so this is a containment guard, not a trust boundary. Separately, stops tracking the live `data/coder-providers.json` (it's runtime config the UI reads *and writes* on provider toggles, which churned `git status`) — it's now gitignored with a tracked `data/coder-providers.example.json` reference; the loader falls back to built-ins-only when the live file is absent. The provider-type duplication (coder ↔ web) stays guarded by the existing text-identity `provider-types-parity.test.ts` — a shared package was considered and declined (drift is already prevented; not worth the Docker/build-order risk at solo scale).
|
||||||
|
|
||||||
## v2.5.14-claude-md — 2026-05-29
|
## v2.5.14-claude-md — 2026-05-29
|
||||||
|
|
||||||
Docs-only — CLAUDE.md session-learnings update, no code. Adds gotchas surfaced while shipping the v2.3 provider-lifecycle batch: the host `boocoder.service` keeps running the old process after `pnpm -C apps/coder build` (stale-process tell = new routes 404 while old routes 200, restart don't re-debug); the `boocode` container `build: .` deploys the working tree, so web edits are live on the Vite dev server but not production until `docker compose up --build -d boocode`; `PATCH /api/providers/config` replaces a provider's override wholesale (send `{...existing, enabled}` or a custom ACP entry's command is wiped) and `data/coder-providers.json` is live config not to be committed as code; external agents dispatch one-shot with no context/token tracking (only native `boocode` tracks ctx; OpenCode-as-server is the unshipped `v2-6-persistent-agent-sessions` plan); the `ui/` primitive inventory with `button role=switch` / Dialog fallbacks for the absent switch/sheet; and the mobile Dialog-with-list scroll-containment recipe. Also backfills previously-uncommitted doc bullets for the `v2.5.7`–`v2.5.11` coder work (provider-type parity test, async ACP command discovery, AgentComposerBar `installed` filter, provider-registry path disambiguation).
|
Docs-only — CLAUDE.md session-learnings update, no code. Adds gotchas surfaced while shipping the v2.3 provider-lifecycle batch: the host `boocoder.service` keeps running the old process after `pnpm -C apps/coder build` (stale-process tell = new routes 404 while old routes 200, restart don't re-debug); the `boocode` container `build: .` deploys the working tree, so web edits are live on the Vite dev server but not production until `docker compose up --build -d boocode`; `PATCH /api/providers/config` replaces a provider's override wholesale (send `{...existing, enabled}` or a custom ACP entry's command is wiped) and `data/coder-providers.json` is live config not to be committed as code; external agents dispatch one-shot with no context/token tracking (only native `boocode` tracks ctx; OpenCode-as-server is the unshipped `v2-6-persistent-agent-sessions` plan); the `ui/` primitive inventory with `button role=switch` / Dialog fallbacks for the absent switch/sheet; and the mobile Dialog-with-list scroll-containment recipe. Also backfills previously-uncommitted doc bullets for the `v2.5.7`–`v2.5.11` coder work (provider-type parity test, async ACP command discovery, AgentComposerBar `installed` filter, provider-registry path disambiguation).
|
||||||
|
|||||||
@@ -88,8 +88,11 @@ Route registration: all routes registered in `index.ts` via `register*Routes(app
|
|||||||
- Frontend: NOT a separate SPA. BooCoder is a `'coder'` pane type within BooChat's SPA (`apps/web/`). `CoderPane.tsx` in `apps/web/src/components/panes/`. API requests go through `/api/coder/*` proxy (Vite dev + Fastify production) which rewrites to the boocoder host service (`BOOCODER_URL` env var, default `http://100.114.205.53:9502`). WS connects directly to `:9502`.
|
- Frontend: NOT a separate SPA. BooCoder is a `'coder'` pane type within BooChat's SPA (`apps/web/`). `CoderPane.tsx` in `apps/web/src/components/panes/`. API requests go through `/api/coder/*` proxy (Vite dev + Fastify production) which rewrites to the boocoder host service (`BOOCODER_URL` env var, default `http://100.114.205.53:9502`). WS connects directly to `:9502`.
|
||||||
- `apps/coder/web/` is a STANDALONE fallback SPA served at `:9502` directly. The PRIMARY BooCoder frontend is the `CoderPane` in BooChat's SPA (`apps/web/src/components/panes/CoderPane.tsx`), accessible via the "Coder" pane in the workspace at `code.indifferentketchup.com`. Both exist; the pane is what Sam uses.
|
- `apps/coder/web/` is a STANDALONE fallback SPA served at `:9502` directly. The PRIMARY BooCoder frontend is the `CoderPane` in BooChat's SPA (`apps/web/src/components/panes/CoderPane.tsx`), accessible via the "Coder" pane in the workspace at `code.indifferentketchup.com`. Both exist; the pane is what Sam uses.
|
||||||
- **Provider snapshot lifecycle** (`apps/coder/src/services/`): `provider-config.ts` (Zod config, never-throws on bad input) → `provider-config-registry.ts` (`buildResolvedRegistry`, singleton) → `provider-snapshot.ts` (two-tier probe: tier-1 fast presence, tier-2 cold ACP probe skipped unless force / stale `PROVIDER_PROBE_TTL_MS` 24h / dbEmpty; cached). Verify live: `curl http://100.114.205.53:9502/api/providers/snapshot` — returns providers + models + commands, the exact shape `AgentComposerBar` renders.
|
- **Provider snapshot lifecycle** (`apps/coder/src/services/`): `provider-config.ts` (Zod config, never-throws on bad input) → `provider-config-registry.ts` (`buildResolvedRegistry`, singleton) → `provider-snapshot.ts` (two-tier probe: tier-1 fast presence, tier-2 cold ACP probe skipped unless force / stale `PROVIDER_PROBE_TTL_MS` 24h / dbEmpty; cached). Verify live: `curl http://100.114.205.53:9502/api/providers/snapshot` — returns providers + models + commands, the exact shape `AgentComposerBar` renders.
|
||||||
- `PATCH /api/providers/config` replaces a provider id's override object **wholesale** (per-id shallow merge) — to flip one field send `{...existing, enabled}`, or a custom ACP entry's `command`/`label` is wiped and it drops out of the resolved registry. `data/coder-providers.json` is the live config (tracked via a `.gitignore` exception, bind-mounted); UI toggles mutate it on disk → working-tree drift, don't commit it as a code change.
|
- `PATCH /api/providers/config` replaces a provider id's override object **wholesale** (per-id shallow merge) — to flip one field send `{...existing, enabled}`, or a custom ACP entry's `command`/`label` is wiped and it drops out of the resolved registry. `data/coder-providers.json` is **gitignored** (it's live runtime config — the coder reads AND writes it on UI toggles); the tracked reference is `data/coder-providers.example.json`. The loader falls back to `{providers:{}}` (built-ins only) when the live file is absent, so a fresh checkout needs no copy.
|
||||||
- External agents dispatch **one-shot** (`opencode acp` / `goose acp` / `qwen --acp`) and report no context-window/token usage; only native `boocode` (llama-swap engine) tracks ctx. OpenCode-as-HTTP-server (warm process + `@opencode-ai/sdk`, the source of a real context bar) is the **planned, unshipped** `openspec/changes/v2-6-persistent-agent-sessions` batch; Paseo's per-provider native clients (design §12) were deliberately not ported.
|
- **opencode** runs as a warm HTTP server (v2.6 Phase 1, `services/backends/opencode-server.ts` — `opencode serve` per BooCoder process, one opencode session per BooCode session, resumed via `agent_sessions`). goose/qwen/claude still dispatch **one-shot** ACP/PTY with no ctx/token usage; only native `boocode` (llama-swap engine) tracks ctx. Paseo's per-provider native clients (design §12) deliberately not ported.
|
||||||
|
- **opencode SSE** (`opencode-server.ts`): live streaming arrives as `session.next.text.delta` / `session.next.reasoning.delta` / `session.next.tool.{called,success,failed}` — NOT `message.part.*` (those are terminal/post-hoc). `client.event.subscribe({ directory })` MUST pass the session's worktree directory; omit it and opencode scopes events to the server's `process.cwd()` → zero session events (empty turns, 180s watchdog timeout). One SSE stream at a time scoped to the last session's dir — concurrent opencode sessions in different worktrees collide (known Phase 1 limit, warns). Turn completes on `session.idle`; `promptAsync` is fire-and-forget (204).
|
||||||
|
- **opencode model strings** must be provider-prefixed (`llama-swap/<model>`) AND exist in `~/.config/opencode/opencode.json` `provider.llama-swap.models` — not merely loadable by llama-swap. `parseModel` infers `llama-swap/` for a bare id; the dispatcher coalesces empty→DEFAULT_MODEL then prefixes. `agent-probe` populates opencode's `available_agents.models` via `mergeLlamaSwap` (fetches `/v1/models`); empty model list → frontend sends `''` → no inference (`input:0`, empty turn).
|
||||||
|
- **agent_sessions resume**: `config_hash = sha256('opencode_server|<model>')` — must NOT include the server port (random per boot; including it breaks cross-restart resume). `session_worktrees` + `agent_sessions` FKs to `sessions(id)` are `ON DELETE CASCADE` (else DELETE /api/sessions/:id 500s on FK violation). The `@opencode-ai/sdk` v2 client takes flattened params (`{sessionID, directory, parts, model:{providerID,modelID}}`), imports `createOpencodeClient` from `@opencode-ai/sdk/v2/client`.
|
||||||
|
|
||||||
### Frontend (`apps/web/src/`)
|
### Frontend (`apps/web/src/`)
|
||||||
|
|
||||||
|
|||||||
@@ -16,6 +16,7 @@
|
|||||||
"@agentclientprotocol/sdk": "^0.22.1",
|
"@agentclientprotocol/sdk": "^0.22.1",
|
||||||
"@boocode/server": "workspace:*",
|
"@boocode/server": "workspace:*",
|
||||||
"@fastify/static": "^7.0.4",
|
"@fastify/static": "^7.0.4",
|
||||||
|
"@opencode-ai/sdk": "~1.15.0",
|
||||||
"@fastify/websocket": "^10.0.1",
|
"@fastify/websocket": "^10.0.1",
|
||||||
"@modelcontextprotocol/sdk": "^1.29.0",
|
"@modelcontextprotocol/sdk": "^1.29.0",
|
||||||
"fastify": "^4.28.1",
|
"fastify": "^4.28.1",
|
||||||
|
|||||||
@@ -30,9 +30,11 @@ import { registerInboxRoutes } from './routes/inbox.js';
|
|||||||
import { registerStatsRoutes } from './routes/stats.js';
|
import { registerStatsRoutes } from './routes/stats.js';
|
||||||
import { registerArenaRoutes } from './routes/arena.js';
|
import { registerArenaRoutes } from './routes/arena.js';
|
||||||
import { registerProviderRoutes } from './routes/providers.js';
|
import { registerProviderRoutes } from './routes/providers.js';
|
||||||
|
import { registerWorktreeSafetyRoutes } from './routes/worktree-safety.js';
|
||||||
import { registerWebSocket } from './routes/ws.js';
|
import { registerWebSocket } from './routes/ws.js';
|
||||||
// Phase 4: dispatcher + agent probe
|
// Phase 4: dispatcher + agent probe
|
||||||
import { createDispatcher } from './services/dispatcher.js';
|
import { createDispatcher } from './services/dispatcher.js';
|
||||||
|
import { agentPool } from './services/agent-pool.js';
|
||||||
import { probeAgents } from './services/agent-probe.js';
|
import { probeAgents } from './services/agent-probe.js';
|
||||||
import { getProviderSnapshot, persistProbedModels } from './services/provider-snapshot.js';
|
import { getProviderSnapshot, persistProbedModels } from './services/provider-snapshot.js';
|
||||||
import { setPermissionHooks } from './services/permission-waiter.js';
|
import { setPermissionHooks } from './services/permission-waiter.js';
|
||||||
@@ -178,7 +180,12 @@ async function main() {
|
|||||||
// Phase 4: dispatcher — polls tasks table and runs inference
|
// Phase 4: dispatcher — polls tasks table and runs inference
|
||||||
const dispatcher = createDispatcher({ sql, inference: inferenceApi, broker, log: app.log, config });
|
const dispatcher = createDispatcher({ sql, inference: inferenceApi, broker, log: app.log, config });
|
||||||
dispatcher.start();
|
dispatcher.start();
|
||||||
app.addHook('onClose', () => dispatcher.stop());
|
app.addHook('onClose', async () => {
|
||||||
|
// stop() first so in-flight dispatcher turns settle, then drain the pool.
|
||||||
|
// Pool is empty in Phase 0 (nothing spawns yet) — dispose() is inert.
|
||||||
|
await dispatcher.stop();
|
||||||
|
await agentPool.dispose();
|
||||||
|
});
|
||||||
|
|
||||||
// Register routes
|
// Register routes
|
||||||
registerMessageRoutes(app, sql, broker, inferenceApi);
|
registerMessageRoutes(app, sql, broker, inferenceApi);
|
||||||
@@ -189,6 +196,7 @@ async function main() {
|
|||||||
registerStatsRoutes(app, sql);
|
registerStatsRoutes(app, sql);
|
||||||
registerArenaRoutes(app, sql);
|
registerArenaRoutes(app, sql);
|
||||||
registerProviderRoutes(app, sql, config);
|
registerProviderRoutes(app, sql, config);
|
||||||
|
registerWorktreeSafetyRoutes(app, sql);
|
||||||
registerWebSocket(app, sql, broker);
|
registerWebSocket(app, sql, broker);
|
||||||
|
|
||||||
// Serve static frontend (built web app). In production, the dist/ is
|
// Serve static frontend (built web app). In production, the dist/ is
|
||||||
|
|||||||
@@ -224,8 +224,8 @@ export function registerMessageRoutes(
|
|||||||
// External provider: create a task for the dispatcher
|
// External provider: create a task for the dispatcher
|
||||||
const projectId = sessionRows[0]!.project_id;
|
const projectId = sessionRows[0]!.project_id;
|
||||||
const [task] = await sql<{ id: string; state: string }[]>`
|
const [task] = await sql<{ id: string; state: string }[]>`
|
||||||
INSERT INTO tasks (project_id, input, agent, model, mode_id, thinking_option_id, session_id)
|
INSERT INTO tasks (project_id, input, agent, model, mode_id, thinking_option_id, session_id, chat_id)
|
||||||
VALUES (${projectId}, ${content}, ${provider}, ${model ?? null}, ${mode_id ?? null}, ${thinking_option_id ?? null}, ${sessionId})
|
VALUES (${projectId}, ${content}, ${provider}, ${model ?? null}, ${mode_id ?? null}, ${thinking_option_id ?? null}, ${sessionId}, ${chatId})
|
||||||
RETURNING id, state
|
RETURNING id, state
|
||||||
`;
|
`;
|
||||||
reply.code(202);
|
reply.code(202);
|
||||||
|
|||||||
@@ -91,8 +91,8 @@ export function registerSkillRoutes(
|
|||||||
|
|
||||||
const taskInput = `${body}\n\n---\n\n${userText}`;
|
const taskInput = `${body}\n\n---\n\n${userText}`;
|
||||||
const [task] = await sql<{ id: string; state: string }[]>`
|
const [task] = await sql<{ id: string; state: string }[]>`
|
||||||
INSERT INTO tasks (project_id, input, agent, model, mode_id, thinking_option_id, session_id)
|
INSERT INTO tasks (project_id, input, agent, model, mode_id, thinking_option_id, session_id, chat_id)
|
||||||
VALUES (${sessionRows[0]!.project_id}, ${taskInput}, ${provider}, ${model ?? null}, ${mode_id ?? null}, ${thinking_option_id ?? null}, ${sessionId})
|
VALUES (${sessionRows[0]!.project_id}, ${taskInput}, ${provider}, ${model ?? null}, ${mode_id ?? null}, ${thinking_option_id ?? null}, ${sessionId}, ${chatId})
|
||||||
RETURNING id, state
|
RETURNING id, state
|
||||||
`;
|
`;
|
||||||
await sql`UPDATE chats SET updated_at = clock_timestamp() WHERE id = ${chatId}`;
|
await sql`UPDATE chats SET updated_at = clock_timestamp() WHERE id = ${chatId}`;
|
||||||
|
|||||||
45
apps/coder/src/routes/worktree-safety.ts
Normal file
45
apps/coder/src/routes/worktree-safety.ts
Normal file
@@ -0,0 +1,45 @@
|
|||||||
|
/**
|
||||||
|
* Session-delete work-loss guard (coder side).
|
||||||
|
*
|
||||||
|
* Session delete itself lives in apps/server (Docker), which CANNOT see the
|
||||||
|
* host worktree dirs (/tmp/booworktrees) or run git on them. Only BooCoder
|
||||||
|
* (host systemd) can. So the server's DELETE route calls these endpoints
|
||||||
|
* pre-delete to learn whether a session's worktree holds work at risk, and to
|
||||||
|
* stash it. The server owns the gate; coder owns the git truth.
|
||||||
|
*/
|
||||||
|
import type { FastifyInstance } from 'fastify';
|
||||||
|
import type { Sql } from '../db.js';
|
||||||
|
import { checkWorktreeWorkAtRisk, stashWorktree } from '../services/worktrees.js';
|
||||||
|
|
||||||
|
export function registerWorktreeSafetyRoutes(app: FastifyInstance, sql: Sql): void {
|
||||||
|
// GET risk for a session's worktree(s). One row per session today (PK on
|
||||||
|
// session_id); the loop already handles the Phase-1.5 multi-worktree case.
|
||||||
|
app.get<{ Params: { sessionId: string } }>(
|
||||||
|
'/api/sessions/:sessionId/worktree-risk',
|
||||||
|
async (req) => {
|
||||||
|
const rows = await sql<{ worktree_path: string }[]>`
|
||||||
|
SELECT path AS worktree_path FROM worktrees WHERE session_id = ${req.params.sessionId}
|
||||||
|
`;
|
||||||
|
const reports = [];
|
||||||
|
for (const row of rows) {
|
||||||
|
reports.push(await checkWorktreeWorkAtRisk(row.worktree_path));
|
||||||
|
}
|
||||||
|
return { reports };
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
// Stash a session's worktree(s) — clears the dirty risk; recoverable.
|
||||||
|
app.post<{ Params: { sessionId: string } }>(
|
||||||
|
'/api/sessions/:sessionId/worktree-stash',
|
||||||
|
async (req) => {
|
||||||
|
const rows = await sql<{ worktree_path: string }[]>`
|
||||||
|
SELECT path AS worktree_path FROM worktrees WHERE session_id = ${req.params.sessionId}
|
||||||
|
`;
|
||||||
|
const results = [];
|
||||||
|
for (const row of rows) {
|
||||||
|
results.push({ worktreePath: row.worktree_path, ...(await stashWorktree(row.worktree_path)) });
|
||||||
|
}
|
||||||
|
return { results };
|
||||||
|
},
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -76,6 +76,138 @@ ALTER TABLE tasks ADD COLUMN IF NOT EXISTS mode_id TEXT;
|
|||||||
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS thinking_option_id TEXT;
|
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS thinking_option_id TEXT;
|
||||||
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS feature_values JSONB;
|
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS feature_values JSONB;
|
||||||
|
|
||||||
|
-- v2.6: one shared worktree per session (all agents/panes in the session operate in it).
|
||||||
|
CREATE TABLE IF NOT EXISTS session_worktrees (
|
||||||
|
session_id UUID PRIMARY KEY REFERENCES sessions(id) ON DELETE CASCADE,
|
||||||
|
worktree_path TEXT NOT NULL,
|
||||||
|
base_commit TEXT,
|
||||||
|
created_at TIMESTAMPTZ NOT NULL DEFAULT clock_timestamp()
|
||||||
|
);
|
||||||
|
-- P1.5-b: DEFANG the CASCADE — a session delete must no longer wipe its worktree
|
||||||
|
-- row. This table is SUPERSEDED by `worktrees` below; all readers are repointed
|
||||||
|
-- this phase, so the row just persists (dead) on session delete until a later
|
||||||
|
-- cleanup drops the table. session_id is this table's PRIMARY KEY, so it cannot be
|
||||||
|
-- nullable → SET NULL is invalid and NO ACTION/RESTRICT would block deletes; the
|
||||||
|
-- only valid defang is to drop the FK with no replacement. Idempotent: only fires
|
||||||
|
-- while the FK is still ON DELETE CASCADE ('c').
|
||||||
|
DO $$ BEGIN
|
||||||
|
IF EXISTS (
|
||||||
|
SELECT 1 FROM pg_constraint
|
||||||
|
WHERE conname = 'session_worktrees_session_id_fkey'
|
||||||
|
AND confdeltype = 'c'
|
||||||
|
) THEN
|
||||||
|
ALTER TABLE session_worktrees DROP CONSTRAINT session_worktrees_session_id_fkey;
|
||||||
|
END IF;
|
||||||
|
END $$;
|
||||||
|
|
||||||
|
-- v2.6: one backend session per (session, agent); resumed on switch-back.
|
||||||
|
CREATE TABLE IF NOT EXISTS agent_sessions (
|
||||||
|
session_id UUID NOT NULL REFERENCES sessions(id) ON DELETE CASCADE,
|
||||||
|
agent TEXT NOT NULL,
|
||||||
|
backend TEXT NOT NULL,
|
||||||
|
agent_session_id TEXT,
|
||||||
|
server_port INTEGER,
|
||||||
|
status TEXT NOT NULL DEFAULT 'idle',
|
||||||
|
last_active_at TIMESTAMPTZ,
|
||||||
|
created_at TIMESTAMPTZ NOT NULL DEFAULT clock_timestamp(),
|
||||||
|
PRIMARY KEY (session_id, agent),
|
||||||
|
CONSTRAINT agent_sessions_backend_chk CHECK (backend IN ('opencode_server', 'acp_warm')),
|
||||||
|
CONSTRAINT agent_sessions_status_chk CHECK (status IN ('idle', 'active', 'crashed', 'closed'))
|
||||||
|
);
|
||||||
|
|
||||||
|
-- Migrate existing agent_sessions FK to CASCADE.
|
||||||
|
DO $$ BEGIN
|
||||||
|
IF EXISTS (
|
||||||
|
SELECT 1 FROM pg_constraint
|
||||||
|
WHERE conname = 'agent_sessions_session_id_fkey'
|
||||||
|
AND confdeltype <> 'c'
|
||||||
|
) THEN
|
||||||
|
ALTER TABLE agent_sessions DROP CONSTRAINT agent_sessions_session_id_fkey;
|
||||||
|
ALTER TABLE agent_sessions ADD CONSTRAINT agent_sessions_session_id_fkey
|
||||||
|
FOREIGN KEY (session_id) REFERENCES sessions(id) ON DELETE CASCADE;
|
||||||
|
END IF;
|
||||||
|
END $$;
|
||||||
|
|
||||||
|
-- v2.6: config fingerprint for stale-session detection (auto-recover on model change).
|
||||||
|
ALTER TABLE agent_sessions ADD COLUMN IF NOT EXISTS config_hash TEXT;
|
||||||
|
|
||||||
|
-- ─── P1.5-b (corrected): worktrees entity + re-key agent_sessions to (chat_id, agent) ───
|
||||||
|
-- The TAB (a chat) is the context unit: two opencode tabs in one session = two
|
||||||
|
-- independent contexts sharing one worktree. So agent_sessions keys on
|
||||||
|
-- (chat_id, agent), NOT (worktree_id, agent) or (session_id, agent). The
|
||||||
|
-- `worktrees` table is one-per-session (selectable later) and only referenced
|
||||||
|
-- informationally by agent_sessions.worktree_id (SET NULL); chat_id is the key.
|
||||||
|
--
|
||||||
|
-- PREREQUISITE: the unmigratable test session (35 chats, 1 agent_sessions row that
|
||||||
|
-- maps to no single chat) is DELETED before this runs, so agent_sessions is empty
|
||||||
|
-- and the chat_id backfill is N/A. If a row with NULL chat_id remains, the verify
|
||||||
|
-- gate below RAISEs and aborts — delete the offending session first.
|
||||||
|
|
||||||
|
-- worktree as a first-class entity; survives session delete (session_id SET NULL).
|
||||||
|
CREATE TABLE IF NOT EXISTS worktrees (
|
||||||
|
id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
|
||||||
|
session_id UUID REFERENCES sessions(id) ON DELETE SET NULL,
|
||||||
|
project_id UUID,
|
||||||
|
path TEXT NOT NULL,
|
||||||
|
branch TEXT,
|
||||||
|
base_commit TEXT,
|
||||||
|
slug TEXT,
|
||||||
|
status TEXT NOT NULL DEFAULT 'active' CHECK (status IN ('active','archived')),
|
||||||
|
created_at TIMESTAMPTZ NOT NULL DEFAULT clock_timestamp()
|
||||||
|
);
|
||||||
|
CREATE UNIQUE INDEX IF NOT EXISTS worktrees_active_path_uidx ON worktrees(path) WHERE status='active';
|
||||||
|
|
||||||
|
-- Migrate any surviving session_worktrees rows → worktrees (idempotent; 0 rows
|
||||||
|
-- after the test-session delete, kept for generality / fresh-DB safety).
|
||||||
|
INSERT INTO worktrees (session_id, path, branch, base_commit, status)
|
||||||
|
SELECT sw.session_id, sw.worktree_path, 'session-' || sw.session_id, sw.base_commit, 'active'
|
||||||
|
FROM session_worktrees sw
|
||||||
|
WHERE NOT EXISTS (SELECT 1 FROM worktrees w WHERE w.session_id = sw.session_id AND w.status='active');
|
||||||
|
|
||||||
|
-- Dispatch hint: which chat (tab) a task belongs to. The coder message route and
|
||||||
|
-- skills route set it from the frontend tab; session-less creators (arena, MCP,
|
||||||
|
-- new_task, generic /api/tasks) leave it NULL and the dispatcher creates a chat.
|
||||||
|
ALTER TABLE tasks ADD COLUMN IF NOT EXISTS chat_id UUID REFERENCES chats(id) ON DELETE SET NULL;
|
||||||
|
|
||||||
|
-- Re-key columns on agent_sessions.
|
||||||
|
ALTER TABLE agent_sessions ADD COLUMN IF NOT EXISTS chat_id UUID;
|
||||||
|
ALTER TABLE agent_sessions ADD COLUMN IF NOT EXISTS worktree_id UUID;
|
||||||
|
|
||||||
|
-- BACKFILL-VERIFY GATE: the new PK is (chat_id, agent), so chat_id must be
|
||||||
|
-- non-null on every row before the swap. With the test session deleted this is a
|
||||||
|
-- 0-row assertion; if any row has NULL chat_id (an unmigratable pre-existing row),
|
||||||
|
-- abort loudly rather than create a degenerate (NULL, agent) key.
|
||||||
|
DO $$
|
||||||
|
DECLARE n int;
|
||||||
|
BEGIN
|
||||||
|
SELECT count(*) INTO n FROM agent_sessions WHERE chat_id IS NULL;
|
||||||
|
IF n > 0 THEN
|
||||||
|
RAISE EXCEPTION 'P1.5-b: % agent_sessions row(s) have NULL chat_id — delete the unmigratable session(s) before applying', n;
|
||||||
|
END IF;
|
||||||
|
END $$;
|
||||||
|
|
||||||
|
-- Swap PK (session_id,agent) → (chat_id,agent) + FKs (run-once, guarded on the new
|
||||||
|
-- FK's absence). chat_id CASCADEs from chats (closing a tab ends its context);
|
||||||
|
-- worktree_id is informational SET NULL; session_id defanged to nullable SET NULL.
|
||||||
|
DO $$ BEGIN
|
||||||
|
IF NOT EXISTS (SELECT 1 FROM pg_constraint WHERE conname = 'agent_sessions_chat_id_fkey') THEN
|
||||||
|
ALTER TABLE agent_sessions DROP CONSTRAINT IF EXISTS agent_sessions_pkey;
|
||||||
|
ALTER TABLE agent_sessions DROP CONSTRAINT IF EXISTS agent_sessions_session_id_fkey;
|
||||||
|
ALTER TABLE agent_sessions ALTER COLUMN session_id DROP NOT NULL;
|
||||||
|
ALTER TABLE agent_sessions ALTER COLUMN chat_id SET NOT NULL;
|
||||||
|
ALTER TABLE agent_sessions ADD CONSTRAINT agent_sessions_pkey PRIMARY KEY (chat_id, agent);
|
||||||
|
ALTER TABLE agent_sessions ADD CONSTRAINT agent_sessions_chat_id_fkey
|
||||||
|
FOREIGN KEY (chat_id) REFERENCES chats(id) ON DELETE CASCADE;
|
||||||
|
ALTER TABLE agent_sessions ADD CONSTRAINT agent_sessions_session_id_fkey
|
||||||
|
FOREIGN KEY (session_id) REFERENCES sessions(id) ON DELETE SET NULL;
|
||||||
|
ALTER TABLE agent_sessions ADD CONSTRAINT agent_sessions_worktree_id_fkey
|
||||||
|
FOREIGN KEY (worktree_id) REFERENCES worktrees(id) ON DELETE SET NULL;
|
||||||
|
END IF;
|
||||||
|
END $$;
|
||||||
|
|
||||||
|
-- v2.6: attribution for DiffPanel badges (Phase 1 UX reads this).
|
||||||
|
ALTER TABLE pending_changes ADD COLUMN IF NOT EXISTS agent TEXT;
|
||||||
|
|
||||||
-- LISTEN/NOTIFY fast path: every tasks INSERT (from any call site — routes,
|
-- LISTEN/NOTIFY fast path: every tasks INSERT (from any call site — routes,
|
||||||
-- new_task tool, arena, MCP server) fires pg_notify('tasks_new') in the same
|
-- new_task tool, arena, MCP server) fires pg_notify('tasks_new') in the same
|
||||||
-- transaction, so the dispatcher reacts immediately instead of waiting for the
|
-- transaction, so the dispatcher reacts immediately instead of waiting for the
|
||||||
|
|||||||
50
apps/coder/src/services/__tests__/acp-client-fs.test.ts
Normal file
50
apps/coder/src/services/__tests__/acp-client-fs.test.ts
Normal file
@@ -0,0 +1,50 @@
|
|||||||
|
import { describe, it, expect, afterEach } from 'vitest';
|
||||||
|
import { mkdtempSync, rmSync } from 'node:fs';
|
||||||
|
import { tmpdir } from 'node:os';
|
||||||
|
import { join } from 'node:path';
|
||||||
|
import { readWorktreeTextFile, writeWorktreeTextFile } from '../acp-client-fs.js';
|
||||||
|
|
||||||
|
const created: string[] = [];
|
||||||
|
function freshWorktree(): string {
|
||||||
|
const wt = mkdtempSync(join(tmpdir(), 'acp-wt-'));
|
||||||
|
created.push(wt);
|
||||||
|
return wt;
|
||||||
|
}
|
||||||
|
afterEach(() => {
|
||||||
|
for (const d of created.splice(0)) {
|
||||||
|
try {
|
||||||
|
rmSync(d, { recursive: true, force: true });
|
||||||
|
rmSync(`${d}-evil`, { recursive: true, force: true });
|
||||||
|
} catch {
|
||||||
|
/* ignore */
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('acp-client-fs worktree scoping', () => {
|
||||||
|
it('writes then reads a file inside the worktree', async () => {
|
||||||
|
const wt = freshWorktree();
|
||||||
|
await writeWorktreeTextFile(wt, 'sub/dir/note.txt', 'hello');
|
||||||
|
expect(await readWorktreeTextFile(wt, 'sub/dir/note.txt')).toBe('hello');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('rejects ../ traversal on read', async () => {
|
||||||
|
const wt = freshWorktree();
|
||||||
|
await expect(readWorktreeTextFile(wt, '../../etc/passwd')).rejects.toThrow(/escapes worktree/);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('rejects ../ traversal on write', async () => {
|
||||||
|
const wt = freshWorktree();
|
||||||
|
await expect(writeWorktreeTextFile(wt, '../escape.txt', 'x')).rejects.toThrow(/escapes worktree/);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('rejects a sibling-prefix path (the unbounded-startsWith bug)', async () => {
|
||||||
|
const wt = freshWorktree();
|
||||||
|
// Absolute path that shares the worktree as a STRING prefix but is a sibling
|
||||||
|
// dir: `<wt>-evil/...`. A bare `startsWith(<wt>)` wrongly admits it.
|
||||||
|
await expect(readWorktreeTextFile(wt, `${wt}-evil/secret.txt`)).rejects.toThrow(/escapes worktree/);
|
||||||
|
await expect(writeWorktreeTextFile(wt, `${wt}-evil/secret.txt`, 'x')).rejects.toThrow(
|
||||||
|
/escapes worktree/,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
73
apps/coder/src/services/__tests__/dcp-strip.test.ts
Normal file
73
apps/coder/src/services/__tests__/dcp-strip.test.ts
Normal file
@@ -0,0 +1,73 @@
|
|||||||
|
import { describe, it, expect } from 'vitest';
|
||||||
|
import { stripDcpTags, makeDcpStreamStripper } from '../dcp-strip.js';
|
||||||
|
|
||||||
|
// Feed chunks through a fresh stripper and return the fully reassembled output
|
||||||
|
// (everything emitted during streaming + the final flush) — i.e. what the
|
||||||
|
// dispatcher would accumulate into the persisted message content.
|
||||||
|
function run(chunks: string[]): string {
|
||||||
|
const s = makeDcpStreamStripper();
|
||||||
|
let out = '';
|
||||||
|
for (const c of chunks) out += s.push(c);
|
||||||
|
out += s.flush();
|
||||||
|
return out;
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('stripDcpTags (one-shot)', () => {
|
||||||
|
it('removes a complete tag', () => {
|
||||||
|
expect(stripDcpTags('Yes — "Test".\n\n<dcp-message-id>m0019</dcp-message-id>')).toBe(
|
||||||
|
'Yes — "Test".\n\n',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
it('leaves text without a tag untouched', () => {
|
||||||
|
expect(stripDcpTags('no tag here')).toBe('no tag here');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('per-chunk strip is INSUFFICIENT (documents the bug)', () => {
|
||||||
|
it('a tag split across chunks survives a naive per-chunk .replace()', () => {
|
||||||
|
const chunks = ['Yes.\n\n<dcp', '-message', '-id>m0019</dcp', '-message-id>'];
|
||||||
|
const naive = chunks.map(stripDcpTags).join('');
|
||||||
|
// The reassembled content still contains the tag — this is the screenshot bug.
|
||||||
|
expect(naive).toContain('<dcp-message-id>m0019</dcp-message-id>');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('makeDcpStreamStripper (cross-chunk fix)', () => {
|
||||||
|
it('strips a tag split across chunks (the real opencode case)', () => {
|
||||||
|
expect(run(['Yes.\n\n<dcp', '-message', '-id>m0019</dcp', '-message-id>'])).toBe('Yes.\n\n');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('strips a tag split at EVERY character boundary', () => {
|
||||||
|
const full = 'Answer.<dcp-message-id>m0019</dcp-message-id>';
|
||||||
|
expect(run([...full])).toBe('Answer.');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('strips a tag delivered whole in one chunk', () => {
|
||||||
|
expect(run(['Answer.<dcp-message-id>m0019</dcp-message-id>'])).toBe('Answer.');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('passes through text with no tag', () => {
|
||||||
|
expect(run(['hello ', 'world'])).toBe('hello world');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does NOT swallow legitimate < content (code/HTML/generics)', () => {
|
||||||
|
expect(run(['use ', '<div>', ' and ', 'Array<', 'string>'])).toBe('use <div> and Array<string>');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('handles a lone < that is not a dcp tag, split across chunks', () => {
|
||||||
|
expect(run(['a <', 'b c'])).toBe('a <b c');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('emits surrounding text and strips a mid-text tag', () => {
|
||||||
|
expect(run(['before ', '<dcp-message-id>', 'm1', '</dcp-message-id>', ' after'])).toBe(
|
||||||
|
'before after',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('flushes a truncated/never-closed partial tag without leaking it as a complete tag', () => {
|
||||||
|
// If the stream ends mid-tag, flush strips complete tags; an incomplete
|
||||||
|
// remnant is returned as-is (no complete tag ever existed to render).
|
||||||
|
const out = run(['done.<dcp-message-id>m00']);
|
||||||
|
expect(out).not.toContain('</dcp-message-id>');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,5 +1,25 @@
|
|||||||
import { promises as fs } from 'node:fs';
|
import { promises as fs } from 'node:fs';
|
||||||
import { dirname, isAbsolute, join, resolve } from 'node:path';
|
import { dirname, isAbsolute, resolve, sep } from 'node:path';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Resolve an ACP-supplied path against the agent worktree and reject anything
|
||||||
|
* that escapes it. Mirrors `write_guard.ts`'s check: `resolve()` to normalize
|
||||||
|
* `../` segments, then a **separator-bounded** prefix test — a bare
|
||||||
|
* `startsWith(root)` wrongly admits a sibling dir like `<root>-evil/...`.
|
||||||
|
*
|
||||||
|
* No realpath (consistent with `write_guard.ts`: the target may not exist yet on
|
||||||
|
* write). This is a containment guard for the ACP fs bridge, not a hard trust
|
||||||
|
* boundary — the agent process already runs with host FS access; symlink-swap
|
||||||
|
* hardening (`O_NOFOLLOW`/realpath) is out of scope here.
|
||||||
|
*/
|
||||||
|
function resolveInWorktree(worktreePath: string, filePath: string): string {
|
||||||
|
const root = resolve(worktreePath);
|
||||||
|
const absolute = isAbsolute(filePath) ? resolve(filePath) : resolve(root, filePath);
|
||||||
|
if (absolute !== root && !absolute.startsWith(root + sep)) {
|
||||||
|
throw new Error(`path escapes worktree: ${filePath}`);
|
||||||
|
}
|
||||||
|
return absolute;
|
||||||
|
}
|
||||||
|
|
||||||
/** Resolve an ACP path against the agent worktree and read a slice of lines. */
|
/** Resolve an ACP path against the agent worktree and read a slice of lines. */
|
||||||
export async function readWorktreeTextFile(
|
export async function readWorktreeTextFile(
|
||||||
@@ -8,10 +28,7 @@ export async function readWorktreeTextFile(
|
|||||||
line?: number | null,
|
line?: number | null,
|
||||||
limit?: number | null,
|
limit?: number | null,
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
const absolute = isAbsolute(filePath) ? filePath : resolve(worktreePath, filePath);
|
const absolute = resolveInWorktree(worktreePath, filePath);
|
||||||
if (!absolute.startsWith(resolve(worktreePath))) {
|
|
||||||
throw new Error(`path escapes worktree: ${filePath}`);
|
|
||||||
}
|
|
||||||
const raw = await fs.readFile(absolute, 'utf8');
|
const raw = await fs.readFile(absolute, 'utf8');
|
||||||
if (!line && !limit) return raw;
|
if (!line && !limit) return raw;
|
||||||
const lines = raw.split(/\r?\n/);
|
const lines = raw.split(/\r?\n/);
|
||||||
@@ -26,10 +43,7 @@ export async function writeWorktreeTextFile(
|
|||||||
filePath: string,
|
filePath: string,
|
||||||
content: string,
|
content: string,
|
||||||
): Promise<void> {
|
): Promise<void> {
|
||||||
const absolute = isAbsolute(filePath) ? filePath : resolve(worktreePath, filePath);
|
const absolute = resolveInWorktree(worktreePath, filePath);
|
||||||
if (!absolute.startsWith(resolve(worktreePath))) {
|
|
||||||
throw new Error(`path escapes worktree: ${filePath}`);
|
|
||||||
}
|
|
||||||
await fs.mkdir(dirname(absolute), { recursive: true });
|
await fs.mkdir(dirname(absolute), { recursive: true });
|
||||||
await fs.writeFile(absolute, content, 'utf8');
|
await fs.writeFile(absolute, content, 'utf8');
|
||||||
}
|
}
|
||||||
|
|||||||
96
apps/coder/src/services/agent-backend.ts
Normal file
96
apps/coder/src/services/agent-backend.ts
Normal file
@@ -0,0 +1,96 @@
|
|||||||
|
/**
|
||||||
|
* v2.6 — AgentBackend abstraction (Phase 0 scaffold; types only, zero runtime logic).
|
||||||
|
*
|
||||||
|
* The core abstraction for persistent agent sessions. Two implementations land
|
||||||
|
* later: `OpenCodeServerBackend` (Phase 1, opencode HTTP server) and
|
||||||
|
* `WarmAcpBackend` (Phase 2, long-lived ACP process). Backends emit
|
||||||
|
* transport-agnostic `AgentEvent`s; the dispatcher maps them to WS frames.
|
||||||
|
*
|
||||||
|
* Nothing imports this file yet — it must compile standalone.
|
||||||
|
* Spec: openspec/changes/v2-6-persistent-agent-sessions/design.md §2.
|
||||||
|
*/
|
||||||
|
import type { AcpToolSnapshot } from './acp-tool-snapshot.js';
|
||||||
|
import type { AgentCommand } from './provider-types.js';
|
||||||
|
|
||||||
|
/** Backend transport kind. Mirrors `agent_sessions.backend` CHECK in schema.sql. */
|
||||||
|
export type AgentBackendKind = 'opencode_server' | 'acp_warm';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Normalized, transport-agnostic events a backend emits during a turn (§2).
|
||||||
|
* Derived from acp-dispatch's session-update handling, but WITHOUT the WS
|
||||||
|
* envelope (message_id/chat_id) — the dispatcher owns frame mapping.
|
||||||
|
*
|
||||||
|
* `tool_call` vs `tool_update` are kept distinct on purpose: acp-dispatch
|
||||||
|
* currently merges both into one snapshot frame, but opencode's SSE
|
||||||
|
* distinguishes tool-start from tool-result, so the contract carries both.
|
||||||
|
* `commands` mirrors the ACP `available_commands_update` path (v2.5.10).
|
||||||
|
*/
|
||||||
|
export type AgentEvent =
|
||||||
|
| { type: 'text'; text: string }
|
||||||
|
| { type: 'reasoning'; text: string }
|
||||||
|
| { type: 'tool_call'; toolCall: AcpToolSnapshot }
|
||||||
|
| { type: 'tool_update'; toolCall: AcpToolSnapshot }
|
||||||
|
| { type: 'commands'; commands: AgentCommand[] };
|
||||||
|
|
||||||
|
/** Params to establish (or look up) a backend session (§2). */
|
||||||
|
export interface EnsureSessionOpts {
|
||||||
|
agent: string;
|
||||||
|
/** Resolved model id. */
|
||||||
|
model: string;
|
||||||
|
/** P1.5-b: the chat (tab) this turn belongs to. agent_sessions is keyed
|
||||||
|
* (chat_id, agent) — the tab/chat is the context unit. Always non-null:
|
||||||
|
* the dispatcher creates a chat for session-less tasks before calling. */
|
||||||
|
chatId: string;
|
||||||
|
/** Shared per-session worktree (one per `sessions.id`, not per pane). */
|
||||||
|
worktreePath: string;
|
||||||
|
/** P1.5-b: the `worktrees.id` for this session's worktree — stored on the
|
||||||
|
* agent_sessions row informationally (NOT the key). */
|
||||||
|
worktreeId: string;
|
||||||
|
projectId: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Opaque handle to a live backend session, persisted to `agent_sessions` (§2). */
|
||||||
|
export interface AgentSessionHandle {
|
||||||
|
sessionId: string;
|
||||||
|
agent: string;
|
||||||
|
backend: AgentBackendKind;
|
||||||
|
/** P1.5-b: the chat (tab) this session is keyed on (with agent). */
|
||||||
|
chatId: string;
|
||||||
|
/** P1.5-b: the worktree this session's chat runs in (informational link). */
|
||||||
|
worktreeId: string;
|
||||||
|
/** Provider's own session id (resume token); null until the backend assigns one. */
|
||||||
|
agentSessionId: string | null;
|
||||||
|
/** opencode HTTP server port; null for ACP backends. */
|
||||||
|
serverPort: number | null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Per-turn context passed to `prompt` (§2). */
|
||||||
|
export interface PromptCtx {
|
||||||
|
worktreePath: string;
|
||||||
|
model: string;
|
||||||
|
signal: AbortSignal;
|
||||||
|
onEvent: (e: AgentEvent) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Result of a completed turn (§2). Diff/persist happen outside the backend. */
|
||||||
|
export interface TurnResult {
|
||||||
|
ok: boolean;
|
||||||
|
error?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The core backend abstraction (§2). Implementations: OpenCodeServerBackend
|
||||||
|
* (Phase 1), WarmAcpBackend (Phase 2).
|
||||||
|
*/
|
||||||
|
export interface AgentBackend {
|
||||||
|
/** Lazy: spawn server / warm process if not already up for this (session, agent). §2 */
|
||||||
|
ensureSession(sessionId: string, opts: EnsureSessionOpts): Promise<AgentSessionHandle>;
|
||||||
|
/** Send a prompt; stream events via ctx.onEvent; resolves when the turn completes. §2 */
|
||||||
|
prompt(handle: AgentSessionHandle, input: string, ctx: PromptCtx): Promise<TurnResult>;
|
||||||
|
/** Graceful teardown of one session (session close or idle timeout). §2 */
|
||||||
|
closeSession(handle: AgentSessionHandle): Promise<void>;
|
||||||
|
/** Full teardown — kills all spawned servers/processes. §2 */
|
||||||
|
dispose(): Promise<void>;
|
||||||
|
/** Liveness for health endpoint + dispatcher fallback decision. §2 */
|
||||||
|
health(): 'up' | 'down';
|
||||||
|
}
|
||||||
44
apps/coder/src/services/agent-pool.ts
Normal file
44
apps/coder/src/services/agent-pool.ts
Normal file
@@ -0,0 +1,44 @@
|
|||||||
|
/**
|
||||||
|
* v2.6 — AgentPool (Phase 0 scaffold).
|
||||||
|
*
|
||||||
|
* Lazy get-or-create registry of `AgentBackend` instances keyed by
|
||||||
|
* `${sessionId}:${agent}`. Phase 0 ships the skeleton only: an in-memory Map,
|
||||||
|
* lookup / register / health, and clean disposal wired to the server's onClose.
|
||||||
|
* Spawning lands in Phase 1/2; nothing populates the map yet.
|
||||||
|
*
|
||||||
|
* Spec: openspec/changes/v2-6-persistent-agent-sessions/design.md §2.
|
||||||
|
*/
|
||||||
|
import type { AgentBackend } from './agent-backend.js';
|
||||||
|
|
||||||
|
export class AgentPool {
|
||||||
|
private readonly backends = new Map<string, AgentBackend>();
|
||||||
|
|
||||||
|
private key(sessionId: string, agent: string): string {
|
||||||
|
return `${sessionId}:${agent}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Map lookup only. Spawning is Phase 1/2 — never creates here. */
|
||||||
|
get(sessionId: string, agent: string): AgentBackend | undefined {
|
||||||
|
return this.backends.get(this.key(sessionId, agent));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Store a backend instance for this (session, agent). */
|
||||||
|
register(sessionId: string, agent: string, backend: AgentBackend): void {
|
||||||
|
this.backends.set(this.key(sessionId, agent), backend);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Summary for the health endpoint. */
|
||||||
|
health(): { size: number } {
|
||||||
|
return { size: this.backends.size };
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Dispose every backend and clear the map. Tolerates throwing backends. */
|
||||||
|
async dispose(): Promise<void> {
|
||||||
|
const entries = [...this.backends.values()];
|
||||||
|
this.backends.clear();
|
||||||
|
await Promise.allSettled(entries.map((b) => b.dispose()));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Single shared instance — referenced only by the server's onClose hook in Phase 0. */
|
||||||
|
export const agentPool = new AgentPool();
|
||||||
@@ -4,7 +4,7 @@ import { exec as execCb, execFile as execFileCb } from 'node:child_process';
|
|||||||
import { promisify } from 'node:util';
|
import { promisify } from 'node:util';
|
||||||
import { PROVIDERS_BY_NAME } from './provider-registry.js';
|
import { PROVIDERS_BY_NAME } from './provider-registry.js';
|
||||||
import { resolveAcpProbeBinaries } from './acp-spawn.js';
|
import { resolveAcpProbeBinaries } from './acp-spawn.js';
|
||||||
import { clearProviderSnapshotCache } from './provider-snapshot.js';
|
import { clearProviderSnapshotCache, fetchLlamaSwapModels, prefixLlamaSwapModels } from './provider-snapshot.js';
|
||||||
import { readQwenSettingsModels } from './qwen-settings.js';
|
import { readQwenSettingsModels } from './qwen-settings.js';
|
||||||
import { loadConfig } from '../config.js';
|
import { loadConfig } from '../config.js';
|
||||||
import { loadProviderConfig } from './provider-config-registry.js';
|
import { loadProviderConfig } from './provider-config-registry.js';
|
||||||
@@ -117,6 +117,15 @@ export async function probeAgents(sql: Sql, log: FastifyBaseLogger): Promise<voi
|
|||||||
if (agentName === 'qwen') {
|
if (agentName === 'qwen') {
|
||||||
models = await readQwenSettingsModels();
|
models = await readQwenSettingsModels();
|
||||||
}
|
}
|
||||||
|
if (providerDef?.mergeLlamaSwap) {
|
||||||
|
try {
|
||||||
|
const config = loadConfig();
|
||||||
|
const llamaModels = prefixLlamaSwapModels(await fetchLlamaSwapModels(config));
|
||||||
|
models = [...models, ...llamaModels];
|
||||||
|
} catch (err) {
|
||||||
|
log.warn({ agent: agentName, err: err instanceof Error ? err.message : String(err) }, 'agent-probe: llama-swap model fetch failed (non-fatal)');
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const label = resolved.configLabel ?? resolved.label;
|
const label = resolved.configLabel ?? resolved.label;
|
||||||
|
|||||||
784
apps/coder/src/services/backends/opencode-server.ts
Normal file
784
apps/coder/src/services/backends/opencode-server.ts
Normal file
@@ -0,0 +1,784 @@
|
|||||||
|
/**
|
||||||
|
* v2.6 Phase 1 — OpenCodeServerBackend.
|
||||||
|
*
|
||||||
|
* Warm, multi-turn backend for the `opencode` agent. One `opencode serve` HTTP
|
||||||
|
* server per BooCoder process; one opencode session per BooCode session (resumed
|
||||||
|
* on switch-back); one SSE read loop PER session, each scoped to that session's
|
||||||
|
* worktree directory so sessions in different directories stream concurrently
|
||||||
|
* (P1.5-a — replaced the Phase-1 single-stream-last-directory model).
|
||||||
|
*
|
||||||
|
* Implements the Phase 0 `AgentBackend` interface. Emits transport-agnostic
|
||||||
|
* `AgentEvent`s — the dispatcher (Phase 1.7, NOT wired in this batch) maps them
|
||||||
|
* to WS frames. No dispatcher/route references this file yet.
|
||||||
|
*
|
||||||
|
* Spec: openspec/changes/v2-6-persistent-agent-sessions/design.md §2 / §2a.
|
||||||
|
* SDK shapes verified by direct read of @opencode-ai/sdk@1.15.12 dist .d.ts:
|
||||||
|
* - client methods take FLATTENED params (sessionID/directory/body all inline),
|
||||||
|
* not {path,query,body}. create→{directory}, promptAsync→{sessionID,directory,
|
||||||
|
* parts,model}, abort→{sessionID,directory}. model is {providerID,modelID}.
|
||||||
|
* - client.event() resolves to { stream: AsyncGenerator<GlobalEvent> }; the
|
||||||
|
* real event is chunk.payload (discriminate on chunk.payload.type).
|
||||||
|
* - promptAsync is fire-and-forget (204); the turn completes via a
|
||||||
|
* 'session.idle' event for that opencode session id.
|
||||||
|
*/
|
||||||
|
import { spawn, type ChildProcess } from 'node:child_process';
|
||||||
|
import { createHash } from 'node:crypto';
|
||||||
|
import { createServer } from 'node:net';
|
||||||
|
import type { FastifyBaseLogger } from 'fastify';
|
||||||
|
import {
|
||||||
|
createOpencodeClient,
|
||||||
|
type OpencodeClient,
|
||||||
|
type Event,
|
||||||
|
type Part,
|
||||||
|
type ToolPart,
|
||||||
|
type ToolState,
|
||||||
|
type AssistantMessage,
|
||||||
|
} from '@opencode-ai/sdk/v2/client';
|
||||||
|
import type { ToolCallStatus } from '@agentclientprotocol/sdk';
|
||||||
|
import type { Sql } from '../../db.js';
|
||||||
|
import type { AcpToolSnapshot } from '../acp-tool-snapshot.js';
|
||||||
|
import type {
|
||||||
|
AgentBackend,
|
||||||
|
AgentEvent,
|
||||||
|
AgentSessionHandle,
|
||||||
|
EnsureSessionOpts,
|
||||||
|
PromptCtx,
|
||||||
|
TurnResult,
|
||||||
|
} from '../agent-backend.js';
|
||||||
|
|
||||||
|
const READY_TIMEOUT_MS = 30_000;
|
||||||
|
const SSE_RECONNECT_DELAY_MS = 1_000;
|
||||||
|
/**
|
||||||
|
* No-activity backstop for an in-flight turn. opencode streams reasoning/text/tool
|
||||||
|
* deltas continuously while working, so "zero events for this long" means the turn
|
||||||
|
* is wedged or its terminal event (session.idle) was lost (see the reconnect race
|
||||||
|
* below). Generous so a legitimately slow turn never trips it.
|
||||||
|
*/
|
||||||
|
const TURN_INACTIVITY_MS = 180_000;
|
||||||
|
|
||||||
|
/** One in-flight turn's emitter + completion settler. */
|
||||||
|
interface TurnState {
|
||||||
|
onEvent: (e: AgentEvent) => void;
|
||||||
|
settle: (r: TurnResult) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Per-(opencode session) demux state. dedup sets scoped here, cleared per turn. */
|
||||||
|
interface SessionState {
|
||||||
|
boocodeSessionId: string;
|
||||||
|
agentSessionId: string;
|
||||||
|
/** Worktree directory for SDK `directory` routing; refreshed each turn from ctx. */
|
||||||
|
worktreePath: string;
|
||||||
|
/** dedup gate: `${type}:${id}` added on delta, deleted-and-tested on updated. Cleared at turn end. */
|
||||||
|
streamedPartKeys: Set<string>;
|
||||||
|
/** partID → 'text' | 'reasoning', so a delta with a non-'reasoning' field is still classed right. Cleared at turn end. */
|
||||||
|
partTypeById: Map<string, string>;
|
||||||
|
activeTurn: TurnState | null;
|
||||||
|
/** Inactivity backstop timer for the active turn; null when no turn in flight. */
|
||||||
|
watchdog: ReturnType<typeof setTimeout> | null;
|
||||||
|
/** Per-session SSE subscription handle. Non-null while the loop is running;
|
||||||
|
* aborting it tears down the underlying fetch and exits the loop. */
|
||||||
|
sseAbort: AbortController | null;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface OpenCodeServerBackendDeps {
|
||||||
|
sql: Sql;
|
||||||
|
log: FastifyBaseLogger;
|
||||||
|
/** Absolute path to the opencode binary (resolved from available_agents at wiring time, Phase 1.7). */
|
||||||
|
opencodeBinary: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export class OpenCodeServerBackend implements AgentBackend {
|
||||||
|
readonly backend = 'opencode_server' as const;
|
||||||
|
|
||||||
|
private readonly sql: Sql;
|
||||||
|
private readonly log: FastifyBaseLogger;
|
||||||
|
private readonly opencodeBinary: string;
|
||||||
|
|
||||||
|
private child: ChildProcess | null = null;
|
||||||
|
private client: OpencodeClient | null = null;
|
||||||
|
private port: number | null = null;
|
||||||
|
private up = false;
|
||||||
|
private serverStarting: Promise<void> | null = null;
|
||||||
|
|
||||||
|
/** opencode session id → demux state. Maintained by ensureSession; read by the SSE loop. */
|
||||||
|
private readonly byOpencodeId = new Map<string, SessionState>();
|
||||||
|
|
||||||
|
constructor(deps: OpenCodeServerBackendDeps) {
|
||||||
|
this.sql = deps.sql;
|
||||||
|
this.log = deps.log;
|
||||||
|
this.opencodeBinary = deps.opencodeBinary;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** §2: liveness for the health endpoint + dispatcher fallback decision. */
|
||||||
|
health(): 'up' | 'down' {
|
||||||
|
return this.up ? 'up' : 'down';
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── Server lifecycle (1.2: spawn once + client + ready) ─────────────────────
|
||||||
|
|
||||||
|
/** Lazy: start the single server on first use. Idempotent — one server per backend. */
|
||||||
|
private ensureServer(): Promise<void> {
|
||||||
|
if (!this.serverStarting) this.serverStarting = this.startServer();
|
||||||
|
return this.serverStarting;
|
||||||
|
}
|
||||||
|
|
||||||
|
private async startServer(): Promise<void> {
|
||||||
|
const port = await freePort();
|
||||||
|
|
||||||
|
// Phase 1: run unsecured on loopback (opencode's documented default — serve.ts
|
||||||
|
// only WARNS when OPENCODE_SERVER_PASSWORD is unset). The real boundary is the
|
||||||
|
// 127.0.0.1 bind. Defense-in-depth basic-auth is deferred: the hey-api client's
|
||||||
|
// auth wiring + opencode's exact scheme must be confirmed against a live server
|
||||||
|
// first, else every request 401s. Recon explicitly said "do NOT block on it".
|
||||||
|
const child = spawn(this.opencodeBinary, ['serve', '--hostname', '127.0.0.1', '--port', String(port)], {
|
||||||
|
stdio: ['ignore', 'pipe', 'pipe'],
|
||||||
|
env: { ...process.env },
|
||||||
|
});
|
||||||
|
this.child = child;
|
||||||
|
this.port = port;
|
||||||
|
|
||||||
|
// Child lifetime is the backend's (the pool's), NOT a request's. We never tie
|
||||||
|
// it to a per-turn abort signal. On unexpected exit we mark down + log; crash
|
||||||
|
// recovery is Phase 3.
|
||||||
|
child.on('exit', (code, signal) => {
|
||||||
|
this.up = false;
|
||||||
|
this.log.warn({ code, signal, port }, 'opencode-server: child exited (recovery is Phase 3)');
|
||||||
|
});
|
||||||
|
|
||||||
|
await waitForReady(child, READY_TIMEOUT_MS);
|
||||||
|
|
||||||
|
this.client = createOpencodeClient({ baseUrl: `http://127.0.0.1:${port}` });
|
||||||
|
this.up = true;
|
||||||
|
this.log.info({ port }, 'opencode-server: ready');
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── SSE read loop + demux + translate (1.3) + dedup (1.4) ───────────────────
|
||||||
|
|
||||||
|
/** Per-session SSE subscription, scoped to the session's worktree directory.
|
||||||
|
* opencode scopes events by the `directory` query param (defaults to the
|
||||||
|
* server's cwd if omitted), so two sessions in different worktrees each get
|
||||||
|
* their own dir-scoped stream and never drop each other's events. Idempotent:
|
||||||
|
* a no-op if this session's loop is already running. Started from ensureSession
|
||||||
|
* (and defensively from prompt) once worktreePath is known. */
|
||||||
|
private startSessionEventLoop(state: SessionState): void {
|
||||||
|
if (state.sseAbort) return; // already running
|
||||||
|
const abort = new AbortController();
|
||||||
|
state.sseAbort = abort;
|
||||||
|
void this.runSessionEventLoop(state, abort).finally(() => {
|
||||||
|
// Only clear if this controller is still the live one (a later restart may
|
||||||
|
// have already installed a new one).
|
||||||
|
if (state.sseAbort === abort) state.sseAbort = null;
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
private async runSessionEventLoop(state: SessionState, abort: AbortController): Promise<void> {
|
||||||
|
const signal = abort.signal;
|
||||||
|
while (this.up && this.client && !signal.aborted) {
|
||||||
|
try {
|
||||||
|
// Re-read worktreePath each (re)subscribe so a directory refresh is picked
|
||||||
|
// up on reconnect. Passing `signal` lets close/dispose tear down a stream
|
||||||
|
// that's parked in `for await` between events.
|
||||||
|
const sub = await this.client.event.subscribe(
|
||||||
|
{ directory: state.worktreePath },
|
||||||
|
{ signal },
|
||||||
|
);
|
||||||
|
for await (const ev of sub.stream) {
|
||||||
|
if (signal.aborted) break;
|
||||||
|
// Dir-scoped streams should only carry this session's events, but two
|
||||||
|
// sessions sharing a worktree (possible post-P1.5-b) each receive BOTH
|
||||||
|
// sessions' events — so drop anything that isn't ours, else the other
|
||||||
|
// session's deltas get processed twice (once per loop).
|
||||||
|
const sid = eventSessionId(ev);
|
||||||
|
if (sid != null && sid !== state.agentSessionId) continue;
|
||||||
|
this.dispatchEvent(ev);
|
||||||
|
}
|
||||||
|
if (this.up && !signal.aborted) {
|
||||||
|
await this.reconcile(state); // recover an idle/error lost during the gap
|
||||||
|
await sleep(SSE_RECONNECT_DELAY_MS);
|
||||||
|
}
|
||||||
|
} catch (err) {
|
||||||
|
if (!this.up || signal.aborted) break;
|
||||||
|
this.log.warn(
|
||||||
|
{ err: errMsg(err), agentSessionId: state.agentSessionId },
|
||||||
|
'opencode-server: session event loop error; reconnecting',
|
||||||
|
);
|
||||||
|
await this.reconcile(state);
|
||||||
|
await sleep(SSE_RECONNECT_DELAY_MS);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Demux one event to the owning session's active turn. Unknown/between-turns → drop. */
|
||||||
|
private dispatchEvent(ev: Event): void {
|
||||||
|
switch (ev.type) {
|
||||||
|
// ─── session.next.* — live streaming events (the primary path) ─────────
|
||||||
|
case 'session.next.text.delta': {
|
||||||
|
const p = ev.properties;
|
||||||
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
|
if (!st?.activeTurn) return;
|
||||||
|
this.bumpActivity(st);
|
||||||
|
const cleaned = stripDcpTags(p.delta);
|
||||||
|
if (cleaned) st.activeTurn.onEvent({ type: 'text', text: cleaned });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
case 'session.next.reasoning.delta': {
|
||||||
|
const p = ev.properties;
|
||||||
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
|
if (!st?.activeTurn) return;
|
||||||
|
this.bumpActivity(st);
|
||||||
|
st.activeTurn.onEvent({ type: 'reasoning', text: p.delta });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
case 'session.next.tool.called': {
|
||||||
|
const p = ev.properties;
|
||||||
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
|
if (!st?.activeTurn) return;
|
||||||
|
this.bumpActivity(st);
|
||||||
|
const snap: AcpToolSnapshot = {
|
||||||
|
toolCallId: p.callID,
|
||||||
|
title: p.tool,
|
||||||
|
kind: null,
|
||||||
|
status: 'in_progress',
|
||||||
|
rawInput: p.input,
|
||||||
|
rawOutput: undefined,
|
||||||
|
};
|
||||||
|
st.activeTurn.onEvent({ type: 'tool_call', toolCall: snap });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
case 'session.next.tool.success': {
|
||||||
|
const p = ev.properties;
|
||||||
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
|
if (!st?.activeTurn) return;
|
||||||
|
this.bumpActivity(st);
|
||||||
|
const output = p.content?.map((c) => ('text' in c ? (c as { text: string }).text : '')).join('') ?? '';
|
||||||
|
const snap: AcpToolSnapshot = {
|
||||||
|
toolCallId: p.callID,
|
||||||
|
title: p.callID,
|
||||||
|
kind: null,
|
||||||
|
status: 'completed',
|
||||||
|
rawInput: undefined,
|
||||||
|
rawOutput: output,
|
||||||
|
};
|
||||||
|
st.activeTurn.onEvent({ type: 'tool_update', toolCall: snap });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
case 'session.next.tool.failed': {
|
||||||
|
const p = ev.properties;
|
||||||
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
|
if (!st?.activeTurn) return;
|
||||||
|
this.bumpActivity(st);
|
||||||
|
const snap: AcpToolSnapshot = {
|
||||||
|
toolCallId: p.callID,
|
||||||
|
title: p.callID,
|
||||||
|
kind: null,
|
||||||
|
status: 'failed',
|
||||||
|
rawInput: undefined,
|
||||||
|
rawOutput: errToString(p.error),
|
||||||
|
};
|
||||||
|
st.activeTurn.onEvent({ type: 'tool_update', toolCall: snap });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
// ─── message.part.* — terminal/post-hoc events (dedup gate) ────────────
|
||||||
|
case 'message.part.delta': {
|
||||||
|
const p = ev.properties;
|
||||||
|
const st = this.byOpencodeId.get(p.sessionID);
|
||||||
|
if (!st?.activeTurn) return;
|
||||||
|
this.bumpActivity(st);
|
||||||
|
const isReasoning = p.field === 'reasoning' || st.partTypeById.get(p.partID) === 'reasoning';
|
||||||
|
if (isReasoning) {
|
||||||
|
st.streamedPartKeys.add(`reasoning:${p.partID}`);
|
||||||
|
st.activeTurn.onEvent({ type: 'reasoning', text: p.delta });
|
||||||
|
} else if (p.field === 'text') {
|
||||||
|
st.streamedPartKeys.add(`text:${p.partID}`);
|
||||||
|
const cleaned = stripDcpTags(p.delta);
|
||||||
|
if (cleaned) st.activeTurn.onEvent({ type: 'text', text: cleaned });
|
||||||
|
}
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
case 'message.part.updated': {
|
||||||
|
const part = ev.properties.part;
|
||||||
|
const st = this.byOpencodeId.get(part.sessionID);
|
||||||
|
if (!st?.activeTurn) return;
|
||||||
|
this.bumpActivity(st);
|
||||||
|
this.handleUpdatedPart(part, st);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
// ─── lifecycle ─────────────────────────────────────────────────────────
|
||||||
|
case 'session.idle': {
|
||||||
|
this.byOpencodeId.get(ev.properties.sessionID)?.activeTurn?.settle({ ok: true });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
case 'session.error': {
|
||||||
|
const sid = ev.properties.sessionID;
|
||||||
|
if (!sid) return;
|
||||||
|
this.byOpencodeId.get(sid)?.activeTurn?.settle({ ok: false, error: errToString(ev.properties.error) });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
default:
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Terminal part: dedup gate for text/reasoning; tool parts → tool_call/tool_update. */
|
||||||
|
private handleUpdatedPart(part: Part, st: SessionState): void {
|
||||||
|
const turn = st.activeTurn;
|
||||||
|
if (!turn) return;
|
||||||
|
|
||||||
|
if (part.type === 'text' || part.type === 'reasoning') {
|
||||||
|
st.partTypeById.set(part.id, part.type);
|
||||||
|
const key = resolvePartDedupeKey(part, part.type);
|
||||||
|
if (key && st.streamedPartKeys.delete(key)) return; // already streamed via delta
|
||||||
|
const raw = part.text ?? '';
|
||||||
|
const text = part.type === 'text' ? stripDcpTags(raw) : raw;
|
||||||
|
if (text && part.time?.end != null) {
|
||||||
|
turn.onEvent({ type: part.type, text });
|
||||||
|
}
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (part.type === 'tool') {
|
||||||
|
const snap = toolPartToSnapshot(part);
|
||||||
|
const status = part.state?.status;
|
||||||
|
// tool_call on start (pending/running), tool_update on terminal (completed/error).
|
||||||
|
// The current ACP path merges both into one frame; the contract keeps them
|
||||||
|
// distinct because opencode's SSE distinguishes start from result.
|
||||||
|
const event: AgentEvent =
|
||||||
|
status === 'completed' || status === 'error'
|
||||||
|
? { type: 'tool_update', toolCall: snap }
|
||||||
|
: { type: 'tool_call', toolCall: snap };
|
||||||
|
turn.onEvent(event);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
// NOTE: opencode's SSE payload union carries no available-commands event, so the
|
||||||
|
// AgentEvent 'commands' arm is intentionally never emitted here (1.3).
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── turn-completion resilience (watchdog + reconnect reconcile) ─────────────
|
||||||
|
|
||||||
|
/** Reset the inactivity backstop on any event routed to a session's active turn. */
|
||||||
|
private bumpActivity(st: SessionState): void {
|
||||||
|
if (!st.activeTurn) return;
|
||||||
|
if (st.watchdog) clearTimeout(st.watchdog);
|
||||||
|
st.watchdog = setTimeout(() => {
|
||||||
|
void this.onTurnStall(st);
|
||||||
|
}, TURN_INACTIVITY_MS);
|
||||||
|
st.watchdog.unref?.();
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Watchdog fired: reconcile once; if the server says still-running we can't tell, so fail closed.
|
||||||
|
* Also mark the agent_sessions row crashed so a stale session isn't resumed next turn. */
|
||||||
|
private async onTurnStall(st: SessionState): Promise<void> {
|
||||||
|
const settled = await this.reconcile(st);
|
||||||
|
if (!settled) {
|
||||||
|
this.log.warn({ agentSessionId: st.agentSessionId }, 'opencode-server: turn stalled (no activity), failing + marking crashed');
|
||||||
|
await this.sql`
|
||||||
|
UPDATE agent_sessions SET status = 'crashed'
|
||||||
|
WHERE agent_session_id = ${st.agentSessionId}
|
||||||
|
`.catch(() => {});
|
||||||
|
st.activeTurn?.settle({ ok: false, error: 'turn timed out (no activity)' });
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Ask the server whether this session's turn already finished — recovers a
|
||||||
|
* session.idle/error lost during an SSE gap. Returns true if it settled the turn.
|
||||||
|
* Inconclusive (still running / call failed) → false; the watchdog covers that.
|
||||||
|
*/
|
||||||
|
private async reconcile(st: SessionState): Promise<boolean> {
|
||||||
|
const turn = st.activeTurn;
|
||||||
|
if (!turn || !this.client) return false;
|
||||||
|
try {
|
||||||
|
const res = await this.client.session.messages({
|
||||||
|
sessionID: st.agentSessionId,
|
||||||
|
directory: st.worktreePath,
|
||||||
|
});
|
||||||
|
if (res.error || !res.data) return false;
|
||||||
|
let lastAssistant: AssistantMessage | undefined;
|
||||||
|
for (let i = res.data.length - 1; i >= 0; i--) {
|
||||||
|
const info = res.data[i]!.info;
|
||||||
|
if (info.role === 'assistant') {
|
||||||
|
lastAssistant = info;
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (!lastAssistant) return false;
|
||||||
|
if (lastAssistant.error != null) {
|
||||||
|
turn.settle({ ok: false, error: errToString(lastAssistant.error) });
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
if (lastAssistant.time.completed != null) {
|
||||||
|
turn.settle({ ok: true });
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
return false; // still running — the live stream will deliver session.idle
|
||||||
|
} catch {
|
||||||
|
return false; // inconclusive — watchdog backstop covers it
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── ensureSession: create-or-resume against agent_sessions (1.5) ────────────
|
||||||
|
|
||||||
|
async ensureSession(sessionId: string, opts: EnsureSessionOpts): Promise<AgentSessionHandle> {
|
||||||
|
await this.ensureServer();
|
||||||
|
if (!this.client) throw new Error('opencode-server: client not ready after ensureServer');
|
||||||
|
|
||||||
|
const configHash = sessionConfigHash(opts.model);
|
||||||
|
// P1.5-b: agent_sessions is keyed (chat_id, agent) — the tab/chat is the
|
||||||
|
// context unit (two tabs in one session = two contexts sharing one worktree).
|
||||||
|
// session_id + worktree_id are retained as informational (SET NULL) columns.
|
||||||
|
const [row] = await this.sql<{ agent_session_id: string | null; status: string; config_hash: string | null }[]>`
|
||||||
|
SELECT agent_session_id, status, config_hash FROM agent_sessions
|
||||||
|
WHERE chat_id = ${opts.chatId} AND agent = ${opts.agent}
|
||||||
|
`;
|
||||||
|
let agentSessionId = row?.agent_session_id ?? null;
|
||||||
|
|
||||||
|
// Don't resume crashed sessions or sessions whose config drifted (model change).
|
||||||
|
const shouldResume = agentSessionId
|
||||||
|
&& row!.status !== 'crashed'
|
||||||
|
&& (row!.config_hash == null || row!.config_hash === configHash);
|
||||||
|
|
||||||
|
if (!shouldResume) {
|
||||||
|
if (agentSessionId) {
|
||||||
|
this.log.info({ sessionId, oldStatus: row!.status, hashMatch: row!.config_hash === configHash },
|
||||||
|
'opencode-server: not resuming stale session, creating fresh');
|
||||||
|
this.byOpencodeId.delete(agentSessionId);
|
||||||
|
}
|
||||||
|
const created = await this.client.session.create({ directory: opts.worktreePath });
|
||||||
|
if (created.error || !created.data) {
|
||||||
|
throw new Error(`opencode-server: session.create failed: ${errToString(created.error)}`);
|
||||||
|
}
|
||||||
|
agentSessionId = created.data.id;
|
||||||
|
await this.sql`
|
||||||
|
INSERT INTO agent_sessions
|
||||||
|
(chat_id, session_id, worktree_id, agent, backend, agent_session_id, server_port, status, last_active_at, config_hash)
|
||||||
|
VALUES
|
||||||
|
(${opts.chatId}, ${sessionId}, ${opts.worktreeId}, ${opts.agent}, 'opencode_server', ${agentSessionId}, ${this.port}, 'active', clock_timestamp(), ${configHash})
|
||||||
|
ON CONFLICT (chat_id, agent) DO UPDATE SET
|
||||||
|
session_id = EXCLUDED.session_id,
|
||||||
|
worktree_id = EXCLUDED.worktree_id,
|
||||||
|
backend = 'opencode_server',
|
||||||
|
agent_session_id = EXCLUDED.agent_session_id,
|
||||||
|
server_port = EXCLUDED.server_port,
|
||||||
|
status = 'active',
|
||||||
|
last_active_at = clock_timestamp(),
|
||||||
|
config_hash = EXCLUDED.config_hash
|
||||||
|
`;
|
||||||
|
} else {
|
||||||
|
await this.sql`
|
||||||
|
UPDATE agent_sessions
|
||||||
|
SET status = 'active', last_active_at = clock_timestamp(), server_port = ${this.port}, config_hash = ${configHash}
|
||||||
|
WHERE chat_id = ${opts.chatId} AND agent = ${opts.agent}
|
||||||
|
`;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Both branches above guarantee agentSessionId is non-null.
|
||||||
|
const ocSessionId = agentSessionId!;
|
||||||
|
|
||||||
|
// Register / refresh the demux entry the SSE loop keys on. Preserve an existing
|
||||||
|
// entry (and any in-flight turn) — just refresh the routing fields.
|
||||||
|
let state = this.byOpencodeId.get(ocSessionId);
|
||||||
|
if (state) {
|
||||||
|
state.boocodeSessionId = sessionId;
|
||||||
|
state.worktreePath = opts.worktreePath;
|
||||||
|
} else {
|
||||||
|
state = {
|
||||||
|
boocodeSessionId: sessionId,
|
||||||
|
agentSessionId: ocSessionId,
|
||||||
|
worktreePath: opts.worktreePath,
|
||||||
|
streamedPartKeys: new Set(),
|
||||||
|
partTypeById: new Map(),
|
||||||
|
activeTurn: null,
|
||||||
|
watchdog: null,
|
||||||
|
sseAbort: null,
|
||||||
|
};
|
||||||
|
this.byOpencodeId.set(ocSessionId, state);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Start this session's own SSE loop, scoped to its worktree directory. Both
|
||||||
|
// fresh-create and resume reach here; idempotent, so a re-ensure (e.g. a
|
||||||
|
// second turn) won't spawn a duplicate loop.
|
||||||
|
this.startSessionEventLoop(state);
|
||||||
|
|
||||||
|
return {
|
||||||
|
sessionId,
|
||||||
|
agent: opts.agent,
|
||||||
|
backend: 'opencode_server',
|
||||||
|
chatId: opts.chatId,
|
||||||
|
worktreeId: opts.worktreeId,
|
||||||
|
agentSessionId: ocSessionId,
|
||||||
|
serverPort: this.port,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── prompt: send one turn (1.6) ─────────────────────────────────────────────
|
||||||
|
|
||||||
|
async prompt(handle: AgentSessionHandle, input: string, ctx: PromptCtx): Promise<TurnResult> {
|
||||||
|
if (!this.client) throw new Error('opencode-server: client not ready');
|
||||||
|
const oc = handle.agentSessionId;
|
||||||
|
if (!oc) throw new Error('opencode-server: handle has no agentSessionId');
|
||||||
|
|
||||||
|
let state = this.byOpencodeId.get(oc);
|
||||||
|
if (!state) {
|
||||||
|
state = {
|
||||||
|
boocodeSessionId: handle.sessionId,
|
||||||
|
agentSessionId: oc,
|
||||||
|
worktreePath: ctx.worktreePath,
|
||||||
|
streamedPartKeys: new Set(),
|
||||||
|
partTypeById: new Map(),
|
||||||
|
activeTurn: null,
|
||||||
|
watchdog: null,
|
||||||
|
sseAbort: null,
|
||||||
|
};
|
||||||
|
this.byOpencodeId.set(oc, state);
|
||||||
|
}
|
||||||
|
const session = state;
|
||||||
|
// Authoritative per-turn directory for SDK routing + reconcile.
|
||||||
|
session.worktreePath = ctx.worktreePath;
|
||||||
|
// Defensive: ensureSession normally starts the loop, but if prompt is reached
|
||||||
|
// with a freshly-created state (no loop yet), start it so the turn streams.
|
||||||
|
// Idempotent when ensureSession already started one.
|
||||||
|
this.startSessionEventLoop(session);
|
||||||
|
const client = this.client;
|
||||||
|
|
||||||
|
return await new Promise<TurnResult>((resolve) => {
|
||||||
|
let settled = false;
|
||||||
|
const cleanup = () => {
|
||||||
|
session.activeTurn = null;
|
||||||
|
if (session.watchdog) {
|
||||||
|
clearTimeout(session.watchdog);
|
||||||
|
session.watchdog = null;
|
||||||
|
}
|
||||||
|
session.streamedPartKeys.clear();
|
||||||
|
session.partTypeById.clear();
|
||||||
|
ctx.signal.removeEventListener('abort', onAbort);
|
||||||
|
};
|
||||||
|
const settle = (r: TurnResult) => {
|
||||||
|
if (settled) return;
|
||||||
|
settled = true;
|
||||||
|
cleanup();
|
||||||
|
resolve(r);
|
||||||
|
};
|
||||||
|
const onAbort = () => {
|
||||||
|
// Abort the turn only — never the server.
|
||||||
|
client.session.abort({ sessionID: oc, directory: ctx.worktreePath }).catch(() => {});
|
||||||
|
settle({ ok: false, error: 'aborted' });
|
||||||
|
};
|
||||||
|
|
||||||
|
session.activeTurn = { onEvent: ctx.onEvent, settle };
|
||||||
|
this.bumpActivity(session); // arm the inactivity backstop
|
||||||
|
|
||||||
|
if (ctx.signal.aborted) {
|
||||||
|
onAbort();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
ctx.signal.addEventListener('abort', onAbort, { once: true });
|
||||||
|
|
||||||
|
const model = parseModel(ctx.model);
|
||||||
|
client.session
|
||||||
|
.promptAsync({
|
||||||
|
sessionID: oc,
|
||||||
|
directory: ctx.worktreePath,
|
||||||
|
parts: [{ type: 'text', text: input }],
|
||||||
|
...(model ? { model } : {}),
|
||||||
|
})
|
||||||
|
.then((res) => {
|
||||||
|
// promptAsync is fire-and-forget (204); the turn completes via session.idle.
|
||||||
|
// Only a submission error settles here.
|
||||||
|
if (res.error) settle({ ok: false, error: errToString(res.error) });
|
||||||
|
})
|
||||||
|
.catch((err) => settle({ ok: false, error: errMsg(err) }));
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── teardown ────────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
async closeSession(handle: AgentSessionHandle): Promise<void> {
|
||||||
|
if (handle.agentSessionId) {
|
||||||
|
// Stop this session's SSE loop before dropping its demux entry.
|
||||||
|
this.byOpencodeId.get(handle.agentSessionId)?.sseAbort?.abort();
|
||||||
|
this.byOpencodeId.delete(handle.agentSessionId);
|
||||||
|
}
|
||||||
|
await this.sql`
|
||||||
|
UPDATE agent_sessions SET status = 'closed'
|
||||||
|
WHERE chat_id = ${handle.chatId} AND agent = ${handle.agent}
|
||||||
|
`.catch(() => {});
|
||||||
|
}
|
||||||
|
|
||||||
|
async dispose(): Promise<void> {
|
||||||
|
this.up = false;
|
||||||
|
// Abort every per-session SSE loop so none survive the teardown.
|
||||||
|
for (const st of this.byOpencodeId.values()) st.sseAbort?.abort();
|
||||||
|
const child = this.child;
|
||||||
|
this.child = null;
|
||||||
|
this.client = null;
|
||||||
|
this.byOpencodeId.clear();
|
||||||
|
if (child && !child.killed) {
|
||||||
|
child.kill('SIGTERM');
|
||||||
|
const t = setTimeout(() => {
|
||||||
|
if (!child.killed) child.kill('SIGKILL');
|
||||||
|
}, 5_000);
|
||||||
|
t.unref();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── helpers ──────────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
/** Extract the opencode sessionID an event belongs to, across event shapes.
|
||||||
|
* Most carry `properties.sessionID`; `message.part.updated` nests it under
|
||||||
|
* `properties.part.sessionID`. Returns null when the event has no session
|
||||||
|
* (the per-session loop then leaves it to dispatchEvent, which drops it). */
|
||||||
|
function eventSessionId(ev: Event): string | null {
|
||||||
|
const props = (ev as { properties?: unknown }).properties;
|
||||||
|
if (!props || typeof props !== 'object') return null;
|
||||||
|
if (ev.type === 'message.part.updated') {
|
||||||
|
const part = (props as { part?: { sessionID?: string } }).part;
|
||||||
|
return part?.sessionID ?? null;
|
||||||
|
}
|
||||||
|
return (props as { sessionID?: string }).sessionID ?? null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** BooCoder model string "provider/model" → opencode's structured {providerID, modelID}. */
|
||||||
|
function parseModel(model: string | undefined): { providerID: string; modelID: string } | undefined {
|
||||||
|
if (!model || !model.trim()) return undefined;
|
||||||
|
const trimmed = model.trim();
|
||||||
|
const idx = trimmed.indexOf('/');
|
||||||
|
if (idx > 0 && idx < trimmed.length - 1) {
|
||||||
|
return { providerID: trimmed.slice(0, idx), modelID: trimmed.slice(idx + 1) };
|
||||||
|
}
|
||||||
|
// No slash but non-empty → infer llama-swap (the only configured provider).
|
||||||
|
// Guard against bare '/' or trailing/leading slash.
|
||||||
|
if (idx < 0 && trimmed.length > 0) {
|
||||||
|
return { providerID: 'llama-swap', modelID: trimmed };
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Ported verbatim from Paseo opencode-agent.ts: id → message-id fallback → null. */
|
||||||
|
function resolvePartDedupeKey(part: { id: string; messageID: string }, type: string): string | null {
|
||||||
|
if (part.id.trim().length > 0) return `${type}:${part.id}`;
|
||||||
|
if (part.messageID.trim().length > 0) return `${type}:message:${part.messageID}`;
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** opencode ToolPart → ACP-shaped snapshot (reuses the existing persist/render path). */
|
||||||
|
function toolPartToSnapshot(part: ToolPart): AcpToolSnapshot {
|
||||||
|
const state = part.state;
|
||||||
|
let rawInput: unknown;
|
||||||
|
let rawOutput: unknown;
|
||||||
|
let title: string | undefined;
|
||||||
|
if (state) {
|
||||||
|
if ('input' in state) rawInput = (state as { input?: unknown }).input;
|
||||||
|
if ('output' in state) rawOutput = (state as { output?: unknown }).output;
|
||||||
|
else if ('error' in state) rawOutput = (state as { error?: unknown }).error;
|
||||||
|
if ('title' in state) title = (state as { title?: string }).title;
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
toolCallId: part.callID,
|
||||||
|
title: title ?? part.tool,
|
||||||
|
kind: null,
|
||||||
|
status: mapToolStatus(state?.status),
|
||||||
|
rawInput,
|
||||||
|
rawOutput,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function mapToolStatus(s: ToolState['status'] | undefined): ToolCallStatus | null {
|
||||||
|
switch (s) {
|
||||||
|
case 'pending':
|
||||||
|
return 'pending';
|
||||||
|
case 'running':
|
||||||
|
return 'in_progress';
|
||||||
|
case 'completed':
|
||||||
|
return 'completed';
|
||||||
|
case 'error':
|
||||||
|
return 'failed';
|
||||||
|
default:
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Bind-probe an ephemeral port on loopback. */
|
||||||
|
function freePort(): Promise<number> {
|
||||||
|
return new Promise((resolve, reject) => {
|
||||||
|
const srv = createServer();
|
||||||
|
srv.unref();
|
||||||
|
srv.on('error', reject);
|
||||||
|
srv.listen(0, '127.0.0.1', () => {
|
||||||
|
const addr = srv.address();
|
||||||
|
if (addr && typeof addr === 'object') {
|
||||||
|
const { port } = addr;
|
||||||
|
srv.close(() => resolve(port));
|
||||||
|
} else {
|
||||||
|
srv.close(() => reject(new Error('opencode-server: could not determine a free port')));
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Resolve when the child prints the ready line; reject on timeout or early exit. */
|
||||||
|
function waitForReady(child: ChildProcess, timeoutMs: number): Promise<void> {
|
||||||
|
return new Promise((resolve, reject) => {
|
||||||
|
let done = false;
|
||||||
|
let stderrBuf = '';
|
||||||
|
|
||||||
|
const finish = (err?: Error) => {
|
||||||
|
if (done) return;
|
||||||
|
done = true;
|
||||||
|
clearTimeout(timer);
|
||||||
|
child.stdout?.off('data', onOut);
|
||||||
|
child.stderr?.off('data', onErr);
|
||||||
|
child.off('exit', onExit);
|
||||||
|
if (err) reject(err);
|
||||||
|
else resolve();
|
||||||
|
};
|
||||||
|
|
||||||
|
const onOut = (buf: Buffer) => {
|
||||||
|
if (buf.toString().includes('opencode server listening on')) finish();
|
||||||
|
};
|
||||||
|
const onErr = (buf: Buffer) => {
|
||||||
|
stderrBuf += buf.toString();
|
||||||
|
};
|
||||||
|
const onExit = (code: number | null) =>
|
||||||
|
finish(new Error(`opencode serve exited before ready (code ${code}); stderr: ${stderrBuf.slice(-2000)}`));
|
||||||
|
const timer = setTimeout(
|
||||||
|
() => finish(new Error(`opencode serve not ready in ${timeoutMs}ms; stderr: ${stderrBuf.slice(-2000)}`)),
|
||||||
|
timeoutMs,
|
||||||
|
);
|
||||||
|
|
||||||
|
child.stdout?.on('data', onOut);
|
||||||
|
child.stderr?.on('data', onErr);
|
||||||
|
child.on('exit', onExit);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function sleep(ms: number): Promise<void> {
|
||||||
|
return new Promise((r) => setTimeout(r, ms));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Strip opencode-dcp plugin tags that render as literal text in the UI. */
|
||||||
|
function stripDcpTags(s: string): string {
|
||||||
|
return s.replace(/<dcp-message-id>[^<]*<\/dcp-message-id>/g, '');
|
||||||
|
}
|
||||||
|
|
||||||
|
function errMsg(e: unknown): string {
|
||||||
|
return e instanceof Error ? e.message : String(e);
|
||||||
|
}
|
||||||
|
|
||||||
|
function errToString(e: unknown): string {
|
||||||
|
if (e == null) return 'unknown error';
|
||||||
|
if (typeof e === 'string') return e;
|
||||||
|
if (e instanceof Error) return e.message;
|
||||||
|
try {
|
||||||
|
return JSON.stringify(e);
|
||||||
|
} catch {
|
||||||
|
return String(e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Hash of stable config — detects model changes across sessions without
|
||||||
|
* invalidating on ephemeral state like the random server port (which changes
|
||||||
|
* every BooCoder restart). */
|
||||||
|
function sessionConfigHash(model: string): string {
|
||||||
|
return createHash('sha256').update(`opencode_server|${model}`).digest('hex').slice(0, 16);
|
||||||
|
}
|
||||||
77
apps/coder/src/services/dcp-strip.ts
Normal file
77
apps/coder/src/services/dcp-strip.ts
Normal file
@@ -0,0 +1,77 @@
|
|||||||
|
/**
|
||||||
|
* Strip opencode-dcp plugin tags (`<dcp-message-id>mNNNN</dcp-message-id>`) that
|
||||||
|
* the @tarquinen/opencode-dcp plugin appends to assistant text and which
|
||||||
|
* otherwise render as literal text in the UI.
|
||||||
|
*
|
||||||
|
* Why a streaming stripper and not a per-chunk `.replace()`: opencode streams
|
||||||
|
* assistant text token-by-token, so the tag arrives SPLIT across many SSE deltas
|
||||||
|
* (`<dcp`, `-message`, `-id>`, `m0019`, `</dcp`, …). A per-chunk regex never sees
|
||||||
|
* a complete tag in any single fragment, so the fragments pass through and the
|
||||||
|
* dispatcher reassembles the full tag in the persisted/displayed content. The
|
||||||
|
* stripper below buffers across chunks: it emits everything that cannot be part
|
||||||
|
* of a forming tag and holds back only a trailing partial-tag prefix until the
|
||||||
|
* next chunk resolves it — without holding back legitimate `<…>` content.
|
||||||
|
*/
|
||||||
|
|
||||||
|
const DCP_TAG_RE = /<dcp-message-id>[^<]*<\/dcp-message-id>/g;
|
||||||
|
const OPEN = '<dcp-message-id>';
|
||||||
|
const CLOSE = '</dcp-message-id>';
|
||||||
|
|
||||||
|
/** One-shot strip of COMPLETE tags. Safe for non-streaming / final content. */
|
||||||
|
export function stripDcpTags(s: string): string {
|
||||||
|
return s.replace(DCP_TAG_RE, '');
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Could `tail` (a substring starting at a `<`) still grow into a complete dcp
|
||||||
|
* tag on a future chunk? If so the caller must hold it back rather than emit it.
|
||||||
|
* Returns false for unrelated `<` content (`<div>`, `<T>`, …) so those stream
|
||||||
|
* normally.
|
||||||
|
*/
|
||||||
|
function isPartialDcp(tail: string): boolean {
|
||||||
|
// A prefix of the opening marker: '<', '<d', …, '<dcp-message-id'.
|
||||||
|
if (OPEN.startsWith(tail)) return true;
|
||||||
|
// Opening marker fully seen — content (and maybe a forming close) still streaming.
|
||||||
|
if (tail.startsWith(OPEN)) {
|
||||||
|
const rest = tail.slice(OPEN.length);
|
||||||
|
const lt = rest.indexOf('<');
|
||||||
|
if (lt === -1) return true; // still inside the [^<]* content run
|
||||||
|
return CLOSE.startsWith(rest.slice(lt)); // a partial close marker forming
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface DcpStreamStripper {
|
||||||
|
/** Feed one text chunk; returns the portion safe to emit now (may be ''). */
|
||||||
|
push(chunk: string): string;
|
||||||
|
/** Stream end: returns whatever was held back, with complete tags stripped. */
|
||||||
|
flush(): string;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Stateful, cross-chunk-safe dcp stripper. One instance per turn. */
|
||||||
|
export function makeDcpStreamStripper(): DcpStreamStripper {
|
||||||
|
let buf = '';
|
||||||
|
return {
|
||||||
|
push(chunk: string): string {
|
||||||
|
buf += chunk;
|
||||||
|
buf = buf.replace(DCP_TAG_RE, ''); // drop any now-complete tags
|
||||||
|
// Find the earliest `<` whose suffix is a forming dcp tag; hold from there,
|
||||||
|
// emit everything before it (real text, including unrelated `<…>`).
|
||||||
|
for (let i = buf.indexOf('<'); i !== -1; i = buf.indexOf('<', i + 1)) {
|
||||||
|
if (isPartialDcp(buf.slice(i))) {
|
||||||
|
const emit = buf.slice(0, i);
|
||||||
|
buf = buf.slice(i);
|
||||||
|
return emit;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
const emit = buf;
|
||||||
|
buf = '';
|
||||||
|
return emit;
|
||||||
|
},
|
||||||
|
flush(): string {
|
||||||
|
const out = stripDcpTags(buf);
|
||||||
|
buf = '';
|
||||||
|
return out;
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -3,13 +3,18 @@ import type { FastifyBaseLogger } from 'fastify';
|
|||||||
import type { Broker } from '@boocode/server/broker';
|
import type { Broker } from '@boocode/server/broker';
|
||||||
import type { WsFrame } from '@boocode/server/ws-frames';
|
import type { WsFrame } from '@boocode/server/ws-frames';
|
||||||
import type { Config } from '../config.js';
|
import type { Config } from '../config.js';
|
||||||
import { createWorktree, diffWorktree, cleanupWorktree } from './worktrees.js';
|
import { createWorktree, diffWorktree, cleanupWorktree, ensureSessionWorktree } from './worktrees.js';
|
||||||
|
import { makeDcpStreamStripper } from './dcp-strip.js';
|
||||||
import { dispatchViaAcp } from './acp-dispatch.js';
|
import { dispatchViaAcp } from './acp-dispatch.js';
|
||||||
import { getResolvedRegistry } from './provider-config-registry.js';
|
import { getResolvedRegistry } from './provider-config-registry.js';
|
||||||
import { dispatchViaPty } from './pty-dispatch.js';
|
import { dispatchViaPty } from './pty-dispatch.js';
|
||||||
import { clearTaskCommands, setTaskCommands } from './agent-commands-cache.js';
|
import { clearTaskCommands, setTaskCommands } from './agent-commands-cache.js';
|
||||||
import { getManifestCommands } from './provider-commands.js';
|
import { getManifestCommands } from './provider-commands.js';
|
||||||
import { persistExternalAgentTurn } from './agent-turn-persist.js';
|
import { persistExternalAgentTurn } from './agent-turn-persist.js';
|
||||||
|
import { snapshotToWireToolCall, type AcpToolSnapshot } from './acp-tool-snapshot.js';
|
||||||
|
import { agentPool } from './agent-pool.js';
|
||||||
|
import { OpenCodeServerBackend } from './backends/opencode-server.js';
|
||||||
|
import type { AgentBackend, AgentEvent } from './agent-backend.js';
|
||||||
|
|
||||||
interface InferenceRunner {
|
interface InferenceRunner {
|
||||||
enqueue: (sessionId: string, chatId: string, assistantId: string, user: string) => void;
|
enqueue: (sessionId: string, chatId: string, assistantId: string, user: string) => void;
|
||||||
@@ -35,23 +40,35 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
const { sql, inference, broker, log, config } = deps;
|
const { sql, inference, broker, log, config } = deps;
|
||||||
let timer: ReturnType<typeof setInterval> | null = null;
|
let timer: ReturnType<typeof setInterval> | null = null;
|
||||||
let listener: { unlisten: () => Promise<void> } | null = null;
|
let listener: { unlisten: () => Promise<void> } | null = null;
|
||||||
let running = false;
|
let polling = false;
|
||||||
let stopping = false;
|
let stopping = false;
|
||||||
let inflightPromise: Promise<void> | null = null;
|
// v2.6 (1.9): per-session in-flight registry replaces the global `running`
|
||||||
|
// boolean. Key = session_id (or `task:<id>` for sessionless tasks). Sessions
|
||||||
|
// without an in-flight turn run concurrently; within a session, strictly one
|
||||||
|
// turn at a time.
|
||||||
|
const inflight = new Map<string, Promise<void>>();
|
||||||
|
|
||||||
// Shared entry point for both the poll timer and the NOTIFY listener. poll()'s
|
// Shared entry point for both the poll timer and the NOTIFY listener. poll()'s
|
||||||
// `running`/`stopping` guard makes this safe to call concurrently — a notify
|
// `polling`/`stopping` guard makes this safe to call concurrently — a notify
|
||||||
// arriving mid-task returns immediately and never double-dispatches.
|
// arriving mid-poll returns immediately and never double-dispatches.
|
||||||
function triggerPoll(reason: string): void {
|
function triggerPoll(reason: string): void {
|
||||||
poll().catch((err) => {
|
poll().catch((err) => {
|
||||||
log.error({ err, reason }, 'dispatcher: poll error');
|
log.error({ err, reason }, 'dispatcher: poll error');
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
async function poll(): Promise<void> {
|
function concurrencyKey(task: { id: string; session_id: string | null }): string {
|
||||||
if (running || stopping) return;
|
return task.session_id ?? `task:${task.id}`;
|
||||||
|
}
|
||||||
|
|
||||||
// Grab one pending task
|
async function poll(): Promise<void> {
|
||||||
|
// `polling` serializes poll() execution itself (timer + NOTIFY can fire
|
||||||
|
// concurrently) so we never double-select a task. It does NOT serialize task
|
||||||
|
// execution — that's what `inflight` (keyed per session) governs.
|
||||||
|
if (polling || stopping) return;
|
||||||
|
polling = true;
|
||||||
|
try {
|
||||||
|
// Oldest-first; start every pending task whose session isn't already busy.
|
||||||
const rows = await sql<{
|
const rows = await sql<{
|
||||||
id: string;
|
id: string;
|
||||||
project_id: string;
|
project_id: string;
|
||||||
@@ -61,21 +78,28 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
mode_id: string | null;
|
mode_id: string | null;
|
||||||
thinking_option_id: string | null;
|
thinking_option_id: string | null;
|
||||||
session_id: string | null;
|
session_id: string | null;
|
||||||
|
chat_id: string | null;
|
||||||
}[]>`
|
}[]>`
|
||||||
SELECT id, project_id, input, agent, model, mode_id, thinking_option_id, session_id
|
SELECT id, project_id, input, agent, model, mode_id, thinking_option_id, session_id, chat_id
|
||||||
FROM tasks
|
FROM tasks
|
||||||
WHERE state = 'pending'
|
WHERE state = 'pending'
|
||||||
ORDER BY created_at
|
ORDER BY created_at
|
||||||
LIMIT 1
|
LIMIT 50
|
||||||
`;
|
`;
|
||||||
if (rows.length === 0) return;
|
for (const task of rows) {
|
||||||
|
if (stopping) break;
|
||||||
const task = rows[0]!;
|
const key = concurrencyKey(task);
|
||||||
running = true;
|
if (inflight.has(key)) continue; // this session already has an in-flight turn
|
||||||
inflightPromise = runTask(task).finally(() => {
|
// Register synchronously (before any await) so a later row in this pass
|
||||||
running = false;
|
// with the same key is skipped and a concurrent poll can't re-pick it.
|
||||||
inflightPromise = null;
|
const p = runTask(task).finally(() => {
|
||||||
|
inflight.delete(key);
|
||||||
});
|
});
|
||||||
|
inflight.set(key, p);
|
||||||
|
}
|
||||||
|
} finally {
|
||||||
|
polling = false;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async function runTask(task: {
|
async function runTask(task: {
|
||||||
@@ -87,6 +111,7 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
mode_id: string | null;
|
mode_id: string | null;
|
||||||
thinking_option_id: string | null;
|
thinking_option_id: string | null;
|
||||||
session_id: string | null;
|
session_id: string | null;
|
||||||
|
chat_id: string | null;
|
||||||
}): Promise<void> {
|
}): Promise<void> {
|
||||||
const taskId = task.id;
|
const taskId = task.id;
|
||||||
|
|
||||||
@@ -96,7 +121,13 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
SELECT name, supports_acp, install_path FROM available_agents WHERE name = ${task.agent}
|
SELECT name, supports_acp, install_path FROM available_agents WHERE name = ${task.agent}
|
||||||
`;
|
`;
|
||||||
if (agentRow) {
|
if (agentRow) {
|
||||||
|
// v2.6 (1.7): opencode routes to the warm pool backend; every other
|
||||||
|
// external agent keeps the existing one-shot ACP/PTY path untouched.
|
||||||
|
if (task.agent === 'opencode') {
|
||||||
|
await runOpenCodeServerTask(task, agentRow.install_path);
|
||||||
|
} else {
|
||||||
await runExternalAgent(task, agentRow.supports_acp, agentRow.install_path);
|
await runExternalAgent(task, agentRow.supports_acp, agentRow.install_path);
|
||||||
|
}
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
// Agent specified but not available — fall through to Path A with a warning
|
// Agent specified but not available — fall through to Path A with a warning
|
||||||
@@ -456,6 +487,306 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ─── Path B (opencode): warm OpenCode server backend (v2.6 1.7 + 1.10) ───────
|
||||||
|
|
||||||
|
// OpenCode runs ONE server per BooCoder process, shared across all sessions
|
||||||
|
// (the backend multiplexes sessions internally), so it's pooled under a fixed
|
||||||
|
// key rather than per-session. Warm ACP backends (Phase 2) will be per-session.
|
||||||
|
const OPENCODE_POOL_KEY = '__opencode_server__';
|
||||||
|
|
||||||
|
function getOpenCodeBackend(installPath: string | null): AgentBackend {
|
||||||
|
let backend = agentPool.get(OPENCODE_POOL_KEY, 'opencode');
|
||||||
|
if (!backend) {
|
||||||
|
backend = new OpenCodeServerBackend({ sql, log, opencodeBinary: installPath ?? 'opencode' });
|
||||||
|
agentPool.register(OPENCODE_POOL_KEY, 'opencode', backend);
|
||||||
|
}
|
||||||
|
return backend;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function runOpenCodeServerTask(
|
||||||
|
task: {
|
||||||
|
id: string;
|
||||||
|
project_id: string;
|
||||||
|
input: string;
|
||||||
|
agent: string | null;
|
||||||
|
model: string | null;
|
||||||
|
mode_id: string | null;
|
||||||
|
thinking_option_id: string | null;
|
||||||
|
session_id: string | null;
|
||||||
|
chat_id: string | null;
|
||||||
|
},
|
||||||
|
installPath: string | null,
|
||||||
|
): Promise<void> {
|
||||||
|
const taskId = task.id;
|
||||||
|
const agent = 'opencode';
|
||||||
|
log.info({ taskId, agent }, 'dispatcher: starting task (path B — opencode server)');
|
||||||
|
|
||||||
|
const [project] = await sql<{ path: string | null }[]>`
|
||||||
|
SELECT path FROM projects WHERE id = ${task.project_id}
|
||||||
|
`;
|
||||||
|
const projectPath = project?.path;
|
||||||
|
if (!projectPath) {
|
||||||
|
await sql`
|
||||||
|
UPDATE tasks
|
||||||
|
SET state = 'failed', ended_at = clock_timestamp(), output_summary = 'Project has no path — cannot create worktree'
|
||||||
|
WHERE id = ${taskId}
|
||||||
|
`;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const ac = new AbortController();
|
||||||
|
|
||||||
|
try {
|
||||||
|
// execution_path = 'acp' — the schema CHECK has no 'opencode_server' value
|
||||||
|
// (schema is frozen at Phase 0); the warm-vs-one-shot distinction lives in
|
||||||
|
// agent_sessions.backend. Reuse the closest existing value.
|
||||||
|
await sql`
|
||||||
|
UPDATE tasks
|
||||||
|
SET state = 'running', started_at = clock_timestamp(), execution_path = 'acp'
|
||||||
|
WHERE id = ${taskId}
|
||||||
|
`;
|
||||||
|
|
||||||
|
// Resolve session + chat. P1.5-b: the chat (tab) is the context key, so the
|
||||||
|
// chat_id MUST be non-null and stable before ensureSession. The coder message
|
||||||
|
// route + skills route stamp task.chat_id with the frontend tab's chat — use
|
||||||
|
// it directly. Session-less creators (arena, MCP, new_task, generic
|
||||||
|
// /api/tasks) leave it null; fall back to resolving/creating a real chat so
|
||||||
|
// ensureSession never receives a degenerate (null, agent) key.
|
||||||
|
let sessionId: string;
|
||||||
|
let chatId: string;
|
||||||
|
if (task.chat_id && task.session_id) {
|
||||||
|
sessionId = task.session_id;
|
||||||
|
chatId = task.chat_id;
|
||||||
|
} else if (task.session_id) {
|
||||||
|
sessionId = task.session_id;
|
||||||
|
const chats = await sql<{ id: string }[]>`
|
||||||
|
SELECT id FROM chats WHERE session_id = ${sessionId} AND status = 'open' ORDER BY created_at DESC LIMIT 1
|
||||||
|
`;
|
||||||
|
if (chats.length === 0) {
|
||||||
|
const [chat] = await sql<{ id: string }[]>`
|
||||||
|
INSERT INTO chats (session_id, name, status)
|
||||||
|
VALUES (${sessionId}, 'External agent execution', 'open')
|
||||||
|
RETURNING id
|
||||||
|
`;
|
||||||
|
chatId = chat!.id;
|
||||||
|
} else {
|
||||||
|
chatId = chats[0]!.id;
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
const sessionName = `Task [${agent}]: ${task.input.slice(0, 30)}`;
|
||||||
|
const [session] = await sql<{ id: string }[]>`
|
||||||
|
INSERT INTO sessions (project_id, name, model, status)
|
||||||
|
VALUES (${task.project_id}, ${sessionName}, ${task.model ?? config.DEFAULT_MODEL}, 'open')
|
||||||
|
RETURNING id
|
||||||
|
`;
|
||||||
|
sessionId = session!.id;
|
||||||
|
const [chat] = await sql<{ id: string }[]>`
|
||||||
|
INSERT INTO chats (session_id, name, status)
|
||||||
|
VALUES (${sessionId}, 'External agent execution', 'open')
|
||||||
|
RETURNING id
|
||||||
|
`;
|
||||||
|
chatId = chat!.id;
|
||||||
|
await sql`UPDATE tasks SET session_id = ${sessionId} WHERE id = ${taskId}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!task.session_id) {
|
||||||
|
await sql`
|
||||||
|
INSERT INTO messages (session_id, chat_id, role, content, status, created_at)
|
||||||
|
VALUES (${sessionId}, ${chatId}, 'user', ${task.input}, 'complete', clock_timestamp())
|
||||||
|
`;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Persistent, session-keyed worktree (shared across turns; NOT torn down
|
||||||
|
// per turn — Phase 3 reaps it). Captures base_commit for a stable diff.
|
||||||
|
const { worktreeId, worktreePath, baseCommit } = await ensureSessionWorktree(sql, projectPath, sessionId, {
|
||||||
|
signal: ac.signal,
|
||||||
|
});
|
||||||
|
log.info({ taskId, worktreePath }, 'dispatcher: session worktree ready');
|
||||||
|
|
||||||
|
const [assistantMsg] = await sql<{ id: string }[]>`
|
||||||
|
INSERT INTO messages (session_id, chat_id, role, content, status, created_at)
|
||||||
|
VALUES (${sessionId}, ${chatId}, 'assistant', '', 'streaming', clock_timestamp())
|
||||||
|
RETURNING id
|
||||||
|
`;
|
||||||
|
const assistantId = assistantMsg!.id;
|
||||||
|
|
||||||
|
broker.publishFrame(sessionId, {
|
||||||
|
type: 'message_started',
|
||||||
|
message_id: assistantId,
|
||||||
|
chat_id: chatId,
|
||||||
|
role: 'assistant',
|
||||||
|
} as WsFrame);
|
||||||
|
|
||||||
|
const manifestCommands = getManifestCommands(agent);
|
||||||
|
if (manifestCommands.length > 0) {
|
||||||
|
setTaskCommands(taskId, manifestCommands);
|
||||||
|
broker.publishFrame(sessionId, {
|
||||||
|
type: 'agent_commands',
|
||||||
|
task_id: taskId,
|
||||||
|
session_id: sessionId,
|
||||||
|
commands: manifestCommands,
|
||||||
|
} as WsFrame);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Accumulate the turn's stream for persistence + the final message content.
|
||||||
|
const textChunks: string[] = [];
|
||||||
|
const reasoningChunks: string[] = [];
|
||||||
|
const toolSnaps = new Map<string, AcpToolSnapshot>();
|
||||||
|
// opencode's dcp plugin appends <dcp-message-id>…</dcp-message-id> to the
|
||||||
|
// text, streamed split across deltas — a per-chunk regex misses it (see
|
||||||
|
// dcp-strip.ts). Buffer text through a cross-chunk stripper so neither the
|
||||||
|
// live `delta` frames nor the persisted content ever carry the tag.
|
||||||
|
const dcp = makeDcpStreamStripper();
|
||||||
|
|
||||||
|
// Map transport-agnostic AgentEvents → the SAME WS frames the ACP path emits.
|
||||||
|
// This boundary is where message_id/chat_id get attached (the backend never
|
||||||
|
// owns them).
|
||||||
|
const onEvent = (e: AgentEvent): void => {
|
||||||
|
switch (e.type) {
|
||||||
|
case 'text': {
|
||||||
|
const safe = dcp.push(e.text);
|
||||||
|
if (safe) {
|
||||||
|
textChunks.push(safe);
|
||||||
|
broker.publishFrame(sessionId, {
|
||||||
|
type: 'delta',
|
||||||
|
message_id: assistantId,
|
||||||
|
chat_id: chatId,
|
||||||
|
content: safe,
|
||||||
|
} as WsFrame);
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
case 'reasoning':
|
||||||
|
reasoningChunks.push(e.text);
|
||||||
|
broker.publishFrame(sessionId, {
|
||||||
|
type: 'reasoning_delta',
|
||||||
|
message_id: assistantId,
|
||||||
|
chat_id: chatId,
|
||||||
|
content: e.text,
|
||||||
|
} as WsFrame);
|
||||||
|
break;
|
||||||
|
case 'tool_call':
|
||||||
|
case 'tool_update':
|
||||||
|
toolSnaps.set(e.toolCall.toolCallId, e.toolCall);
|
||||||
|
broker.publishFrame(sessionId, {
|
||||||
|
type: 'tool_call',
|
||||||
|
message_id: assistantId,
|
||||||
|
chat_id: chatId,
|
||||||
|
tool_call: snapshotToWireToolCall(e.toolCall),
|
||||||
|
} as WsFrame);
|
||||||
|
break;
|
||||||
|
case 'commands':
|
||||||
|
// opencode-server doesn't emit these today; ignore if it ever does.
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
// opencode expects provider-prefixed model ids (e.g. 'llama-swap/qwen3.6-35b…').
|
||||||
|
// DEFAULT_MODEL is bare (no prefix) because native inference uses it directly
|
||||||
|
// against llama-swap. Coalesce empty string (frontend sends '' when no models
|
||||||
|
// listed) and prefix bare ids so parseModel always succeeds.
|
||||||
|
const rawModel = (task.model && task.model.trim()) || config.DEFAULT_MODEL;
|
||||||
|
const model = rawModel.includes('/') ? rawModel : `llama-swap/${rawModel}`;
|
||||||
|
const backend = getOpenCodeBackend(installPath);
|
||||||
|
const handle = await backend.ensureSession(sessionId, {
|
||||||
|
agent,
|
||||||
|
model,
|
||||||
|
chatId,
|
||||||
|
worktreePath,
|
||||||
|
worktreeId,
|
||||||
|
projectId: task.project_id,
|
||||||
|
});
|
||||||
|
const result = await backend.prompt(handle, task.input, {
|
||||||
|
worktreePath,
|
||||||
|
model,
|
||||||
|
signal: ac.signal,
|
||||||
|
onEvent,
|
||||||
|
});
|
||||||
|
|
||||||
|
// Flush any text held back mid-tag at stream end (complete tags stripped).
|
||||||
|
const dcpTail = dcp.flush();
|
||||||
|
if (dcpTail) {
|
||||||
|
textChunks.push(dcpTail);
|
||||||
|
broker.publishFrame(sessionId, {
|
||||||
|
type: 'delta',
|
||||||
|
message_id: assistantId,
|
||||||
|
chat_id: chatId,
|
||||||
|
content: dcpTail,
|
||||||
|
} as WsFrame);
|
||||||
|
}
|
||||||
|
|
||||||
|
const assistantContent = textChunks.join('').slice(0, 50_000);
|
||||||
|
const reasoningText = reasoningChunks.join('').slice(0, 200_000);
|
||||||
|
const outputSummary = (result.ok ? textChunks.join('') : result.error ?? 'opencode turn failed').slice(0, 500);
|
||||||
|
|
||||||
|
await persistExternalAgentTurn(sql, assistantId, [...toolSnaps.values()], reasoningText);
|
||||||
|
|
||||||
|
await sql`
|
||||||
|
UPDATE messages
|
||||||
|
SET content = ${assistantContent}, status = 'complete', finished_at = clock_timestamp()
|
||||||
|
WHERE id = ${assistantId}
|
||||||
|
`;
|
||||||
|
broker.publishFrame(sessionId, {
|
||||||
|
type: 'message_complete',
|
||||||
|
message_id: assistantId,
|
||||||
|
chat_id: chatId,
|
||||||
|
} as WsFrame);
|
||||||
|
|
||||||
|
if (stopping) {
|
||||||
|
await sql`UPDATE tasks SET state = 'cancelled', ended_at = clock_timestamp() WHERE id = ${taskId}`;
|
||||||
|
return; // worktree persists (no cleanup); backend stays warm
|
||||||
|
}
|
||||||
|
|
||||||
|
// 1.10: diff the persistent worktree against its captured baseline and
|
||||||
|
// SUPERSEDE the session's prior pending row (latest-wins, one accumulating
|
||||||
|
// diff) instead of stacking. Stamp agent for DiffPanel attribution.
|
||||||
|
const diff = await diffWorktree(worktreePath, projectPath, {
|
||||||
|
signal: ac.signal,
|
||||||
|
baseRef: baseCommit ?? 'HEAD',
|
||||||
|
});
|
||||||
|
if (diff) {
|
||||||
|
await sql`
|
||||||
|
DELETE FROM pending_changes WHERE session_id = ${sessionId} AND status = 'pending'
|
||||||
|
`;
|
||||||
|
await sql`
|
||||||
|
INSERT INTO pending_changes (session_id, task_id, file_path, operation, diff, agent)
|
||||||
|
VALUES (${sessionId}, ${taskId}, ${projectPath}, 'edit', ${diff}, ${agent})
|
||||||
|
`;
|
||||||
|
log.info({ taskId, diffLength: diff.length }, 'dispatcher: diff superseded prior pending change');
|
||||||
|
} else {
|
||||||
|
log.info({ taskId }, 'dispatcher: no changes detected in session worktree');
|
||||||
|
}
|
||||||
|
|
||||||
|
// NO worktree cleanup — it's persistent (Phase 3 reaps it). Backend stays warm.
|
||||||
|
|
||||||
|
const [extCostRow] = await sql<{ total: number | null }[]>`
|
||||||
|
SELECT SUM(tokens_used)::int AS total
|
||||||
|
FROM messages
|
||||||
|
WHERE session_id = ${sessionId} AND tokens_used IS NOT NULL
|
||||||
|
`;
|
||||||
|
const extCostTokens = extCostRow?.total ?? null;
|
||||||
|
|
||||||
|
const finalState = result.ok ? 'completed' : 'failed';
|
||||||
|
await sql`
|
||||||
|
UPDATE tasks
|
||||||
|
SET state = ${finalState}, ended_at = clock_timestamp(), output_summary = ${outputSummary}, cost_tokens = ${extCostTokens}
|
||||||
|
WHERE id = ${taskId}
|
||||||
|
`;
|
||||||
|
log.info({ taskId, agent, finalState, costTokens: extCostTokens }, 'dispatcher: task finished (opencode server)');
|
||||||
|
clearTaskCommands(taskId);
|
||||||
|
} catch (err) {
|
||||||
|
const errMsg = err instanceof Error ? err.message : String(err);
|
||||||
|
log.error({ taskId, agent, err: errMsg }, 'dispatcher: opencode server error');
|
||||||
|
await sql`
|
||||||
|
UPDATE tasks
|
||||||
|
SET state = 'failed', ended_at = clock_timestamp(), output_summary = ${errMsg.slice(0, 500)}
|
||||||
|
WHERE id = ${taskId}
|
||||||
|
`.catch(() => {});
|
||||||
|
clearTaskCommands(taskId);
|
||||||
|
// No worktree cleanup (persistent); backend stays warm for the next turn.
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// ─── Helpers ────────────────────────────────────────────────────────────────
|
// ─── Helpers ────────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
async function waitForCompletion(assistantId: string): Promise<string> {
|
async function waitForCompletion(assistantId: string): Promise<string> {
|
||||||
@@ -514,9 +845,9 @@ export function createDispatcher(deps: Deps): { start(): void; stop(): Promise<v
|
|||||||
});
|
});
|
||||||
listener = null;
|
listener = null;
|
||||||
}
|
}
|
||||||
if (inflightPromise) {
|
if (inflight.size > 0) {
|
||||||
log.info('dispatcher: waiting for in-flight task');
|
log.info({ count: inflight.size }, 'dispatcher: waiting for in-flight tasks');
|
||||||
await inflightPromise;
|
await Promise.allSettled([...inflight.values()]);
|
||||||
}
|
}
|
||||||
log.info('dispatcher: stopped');
|
log.info('dispatcher: stopped');
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -29,7 +29,7 @@ interface AgentRow {
|
|||||||
last_probed_at: string | Date | null;
|
last_probed_at: string | Date | null;
|
||||||
}
|
}
|
||||||
|
|
||||||
async function fetchLlamaSwapModels(config: Config): Promise<ProviderModel[]> {
|
export async function fetchLlamaSwapModels(config: Config): Promise<ProviderModel[]> {
|
||||||
try {
|
try {
|
||||||
const res = await fetch(`${config.LLAMA_SWAP_URL}/v1/models`);
|
const res = await fetch(`${config.LLAMA_SWAP_URL}/v1/models`);
|
||||||
if (!res.ok) return [];
|
if (!res.ok) return [];
|
||||||
|
|||||||
@@ -6,6 +6,7 @@
|
|||||||
* After the agent completes, we diff the worktree against HEAD and
|
* After the agent completes, we diff the worktree against HEAD and
|
||||||
* queue the diff into pending_changes.
|
* queue the diff into pending_changes.
|
||||||
*/
|
*/
|
||||||
|
import type { Sql } from '../db.js';
|
||||||
import { hostExec } from './host-exec.js';
|
import { hostExec } from './host-exec.js';
|
||||||
|
|
||||||
const WORKTREE_BASE = '/tmp/booworktrees';
|
const WORKTREE_BASE = '/tmp/booworktrees';
|
||||||
@@ -45,7 +46,7 @@ export async function createWorktree(
|
|||||||
export async function diffWorktree(
|
export async function diffWorktree(
|
||||||
worktreePath: string,
|
worktreePath: string,
|
||||||
projectPath: string,
|
projectPath: string,
|
||||||
opts?: { signal?: AbortSignal },
|
opts?: { signal?: AbortSignal; baseRef?: string },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
// First, commit any uncommitted changes in the worktree so we can diff branches
|
// First, commit any uncommitted changes in the worktree so we can diff branches
|
||||||
// Stage all changes
|
// Stage all changes
|
||||||
@@ -74,9 +75,13 @@ export async function diffWorktree(
|
|||||||
{ signal: opts?.signal, timeoutMs: 15_000 },
|
{ signal: opts?.signal, timeoutMs: 15_000 },
|
||||||
);
|
);
|
||||||
|
|
||||||
// Diff the worktree branch against the parent commit (HEAD of main tree)
|
// Diff the worktree branch against the baseline. Per-task callers default to the
|
||||||
|
// main tree's current HEAD; the session-worktree (opencode) path passes the
|
||||||
|
// captured base_commit so the accumulated diff is stable across turns even if
|
||||||
|
// project HEAD advances.
|
||||||
|
const baseRef = opts?.baseRef ?? 'HEAD';
|
||||||
const diffResult = await hostExec(
|
const diffResult = await hostExec(
|
||||||
`git -C ${shellEscape(projectPath)} diff HEAD...$(git -C ${shellEscape(worktreePath)} rev-parse HEAD)`,
|
`git -C ${shellEscape(projectPath)} diff ${shellEscape(baseRef)}...$(git -C ${shellEscape(worktreePath)} rev-parse HEAD)`,
|
||||||
{ signal: opts?.signal, timeoutMs: 60_000 },
|
{ signal: opts?.signal, timeoutMs: 60_000 },
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -111,6 +116,246 @@ export async function cleanupWorktree(
|
|||||||
).catch(() => {});
|
).catch(() => {});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ─── v2.6: session-keyed persistent worktree ────────────────────────────────
|
||||||
|
|
||||||
|
export interface SessionWorktree {
|
||||||
|
/** P1.5-b: the `worktrees.id` — stored on agent_sessions informationally. */
|
||||||
|
worktreeId: string;
|
||||||
|
worktreePath: string;
|
||||||
|
baseCommit: string | null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* v2.6 / P1.5-b: create-or-reuse ONE worktree per BooCode session (shared across
|
||||||
|
* all tabs/agents in the session), recorded in `worktrees` (was the superseded
|
||||||
|
* `session_worktrees`). Persists — NOT torn down per turn (cleanup is Phase 3) —
|
||||||
|
* and now survives session delete (`worktrees.session_id` is ON DELETE SET NULL).
|
||||||
|
* Captures the project's current HEAD as `base_commit` for a stable diff baseline.
|
||||||
|
*
|
||||||
|
* Distinct path namespace (`session-<id>` branch, `/sess-<id>` dir) so it never
|
||||||
|
* collides with the per-task worktrees that arena/new_task/MCP still use.
|
||||||
|
*/
|
||||||
|
export async function ensureSessionWorktree(
|
||||||
|
sql: Sql,
|
||||||
|
projectPath: string,
|
||||||
|
sessionId: string,
|
||||||
|
opts?: { signal?: AbortSignal },
|
||||||
|
): Promise<SessionWorktree> {
|
||||||
|
const [existing] = await sql<{ id: string; path: string; base_commit: string | null }[]>`
|
||||||
|
SELECT id, path, base_commit FROM worktrees
|
||||||
|
WHERE session_id = ${sessionId} AND status = 'active'
|
||||||
|
LIMIT 1
|
||||||
|
`;
|
||||||
|
if (existing) {
|
||||||
|
return { worktreeId: existing.id, worktreePath: existing.path, baseCommit: existing.base_commit };
|
||||||
|
}
|
||||||
|
|
||||||
|
const worktreePath = `${WORKTREE_BASE}/sess-${sessionId}`;
|
||||||
|
const branchName = `session-${sessionId}`;
|
||||||
|
|
||||||
|
await hostExec(`mkdir -p ${WORKTREE_BASE}`, { signal: opts?.signal });
|
||||||
|
|
||||||
|
// Capture the baseline commit BEFORE branching, so the diff is stable even if
|
||||||
|
// project HEAD later advances.
|
||||||
|
const headResult = await hostExec(
|
||||||
|
`git -C ${shellEscape(projectPath)} rev-parse HEAD`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
const baseCommit = headResult.exitCode === 0 ? headResult.stdout.trim() || null : null;
|
||||||
|
|
||||||
|
const result = await hostExec(
|
||||||
|
`git -C ${shellEscape(projectPath)} worktree add ${shellEscape(worktreePath)} -b ${shellEscape(branchName)} HEAD`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 30_000 },
|
||||||
|
);
|
||||||
|
if (result.exitCode !== 0) {
|
||||||
|
throw new Error(`Failed to create session worktree: ${result.stderr.trim() || result.stdout.trim()}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Insert-or-get: WHERE NOT EXISTS keeps the first writer's row if two turns race
|
||||||
|
// the create (the partial unique on active path also backstops it).
|
||||||
|
const [inserted] = await sql<{ id: string; path: string; base_commit: string | null }[]>`
|
||||||
|
INSERT INTO worktrees (session_id, path, branch, base_commit, status)
|
||||||
|
SELECT ${sessionId}, ${worktreePath}, ${branchName}, ${baseCommit}, 'active'
|
||||||
|
WHERE NOT EXISTS (
|
||||||
|
SELECT 1 FROM worktrees WHERE session_id = ${sessionId} AND status = 'active'
|
||||||
|
)
|
||||||
|
RETURNING id, path, base_commit
|
||||||
|
`;
|
||||||
|
if (inserted) {
|
||||||
|
return { worktreeId: inserted.id, worktreePath: inserted.path, baseCommit: inserted.base_commit };
|
||||||
|
}
|
||||||
|
// Lost the race — another turn inserted first; read its row.
|
||||||
|
const [row] = await sql<{ id: string; path: string; base_commit: string | null }[]>`
|
||||||
|
SELECT id, path, base_commit FROM worktrees
|
||||||
|
WHERE session_id = ${sessionId} AND status = 'active'
|
||||||
|
LIMIT 1
|
||||||
|
`;
|
||||||
|
return {
|
||||||
|
worktreeId: row!.id,
|
||||||
|
worktreePath: row?.path ?? worktreePath,
|
||||||
|
baseCommit: row?.base_commit ?? baseCommit,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── Session-delete work-loss guard ─────────────────────────────────────────
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Risk report for a single worktree, returned by checkWorktreeWorkAtRisk.
|
||||||
|
* `atRisk` is the gate the server reads before allowing a session delete.
|
||||||
|
* A git error never silently passes — it forces `atRisk` true and surfaces
|
||||||
|
* the message in `error` (fail-closed).
|
||||||
|
*/
|
||||||
|
export interface RiskReport {
|
||||||
|
worktreePath: string;
|
||||||
|
branch: string;
|
||||||
|
dirty: boolean; // uncommitted working-tree changes (incl. untracked)
|
||||||
|
unpushed: number; // commits ahead of upstream, or -1 if no upstream is set
|
||||||
|
unmerged: number; // commits on this branch not in the project default branch
|
||||||
|
atRisk: boolean; // dirty || unmerged > 0 || (upstream && unpushed > 0) || git error
|
||||||
|
error?: string; // populated on a git failure; presence forces atRisk
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Resolve the project's default branch as a git-usable ref (e.g. "origin/main").
|
||||||
|
*
|
||||||
|
* `refs/remotes/origin/HEAD` lives in the repo's COMMON git dir and is shared
|
||||||
|
* across every linked worktree, so reading it from the session worktree returns
|
||||||
|
* the REMOTE's default branch — never this worktree's own `session-<id>` branch
|
||||||
|
* (that would be `symbolic-ref HEAD`, a different ref). Falls back to probing
|
||||||
|
* common defaults by verified existence when origin/HEAD isn't set (e.g. a repo
|
||||||
|
* that never ran `git remote set-head`). Returns null if none resolve, in which
|
||||||
|
* case the unmerged check is skipped (dirty + unpushed still protect the work).
|
||||||
|
*/
|
||||||
|
async function detectDefaultBranchRef(
|
||||||
|
worktreePath: string,
|
||||||
|
opts?: { signal?: AbortSignal },
|
||||||
|
): Promise<string | null> {
|
||||||
|
const head = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} symbolic-ref --short refs/remotes/origin/HEAD`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
if (head.exitCode === 0) {
|
||||||
|
const ref = head.stdout.trim(); // e.g. "origin/main"
|
||||||
|
if (ref) {
|
||||||
|
const verify = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-parse --verify --quiet ${shellEscape(ref + '^{commit}')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
if (verify.exitCode === 0 && verify.stdout.trim()) return ref;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// origin/HEAD unset or unresolvable — probe common defaults. Prefer the
|
||||||
|
// remote-tracking ref (always resolvable in a fresh worktree) over the local
|
||||||
|
// head, which may not exist if the default branch lives only in the main tree.
|
||||||
|
for (const cand of ['origin/main', 'origin/master', 'main', 'master']) {
|
||||||
|
const verify = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-parse --verify --quiet ${shellEscape(cand + '^{commit}')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
if (verify.exitCode === 0 && verify.stdout.trim()) return cand;
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Inspect a worktree for work that would be lost if its session were deleted.
|
||||||
|
* Three checks, all via the audited hostExec + shellEscape path (every
|
||||||
|
* interpolated value — paths, refs — is single-quote-escaped; no bare
|
||||||
|
* interpolation). Any unexpected git failure is treated as at-risk, never a
|
||||||
|
* silent pass.
|
||||||
|
*/
|
||||||
|
export async function checkWorktreeWorkAtRisk(
|
||||||
|
worktreePath: string,
|
||||||
|
opts?: { signal?: AbortSignal },
|
||||||
|
): Promise<RiskReport> {
|
||||||
|
// Branch name — also doubles as the "is this still a git worktree?" probe.
|
||||||
|
const br = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-parse --abbrev-ref HEAD`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 10_000 },
|
||||||
|
);
|
||||||
|
if (br.exitCode !== 0) {
|
||||||
|
return {
|
||||||
|
worktreePath,
|
||||||
|
branch: '',
|
||||||
|
dirty: false,
|
||||||
|
unpushed: 0,
|
||||||
|
unmerged: 0,
|
||||||
|
atRisk: true,
|
||||||
|
error: `git rev-parse failed: ${br.stderr.trim() || 'not a git worktree'}`,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
const branch = br.stdout.trim();
|
||||||
|
|
||||||
|
// (a) Uncommitted (dirty working tree, including untracked files).
|
||||||
|
const st = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} status --porcelain`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 15_000 },
|
||||||
|
);
|
||||||
|
if (st.exitCode !== 0) {
|
||||||
|
return {
|
||||||
|
worktreePath,
|
||||||
|
branch,
|
||||||
|
dirty: false,
|
||||||
|
unpushed: 0,
|
||||||
|
unmerged: 0,
|
||||||
|
atRisk: true,
|
||||||
|
error: `git status failed: ${st.stderr.trim()}`,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
const dirty = st.stdout.trim().length > 0;
|
||||||
|
|
||||||
|
// (b) Unpushed commits. No upstream configured => work exists only locally;
|
||||||
|
// treat as unpushed-by-definition (-1) rather than an error.
|
||||||
|
const up = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-list --count ${shellEscape('@{u}..HEAD')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 15_000 },
|
||||||
|
);
|
||||||
|
const unpushed = up.exitCode === 0 ? (parseInt(up.stdout.trim() || '0', 10) || 0) : -1;
|
||||||
|
|
||||||
|
// (c) Unmerged commits — on this branch but not in the project default branch.
|
||||||
|
const defaultRef = await detectDefaultBranchRef(worktreePath, opts);
|
||||||
|
let unmerged = 0;
|
||||||
|
if (defaultRef) {
|
||||||
|
const rl = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} rev-list --count ${shellEscape(defaultRef + '..HEAD')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 15_000 },
|
||||||
|
);
|
||||||
|
if (rl.exitCode === 0) unmerged = parseInt(rl.stdout.trim() || '0', 10) || 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
// unpushed only contributes when an upstream actually exists. Session branches
|
||||||
|
// (session-<id>) never have one (unpushed === -1), and any real local-only work
|
||||||
|
// there already surfaces as unmerged > 0 — so the no-upstream case adds no
|
||||||
|
// protection, only friction (it flagged every pristine worktree-backed session).
|
||||||
|
// The unpushed > 0 arm stays forward-compatible with P1.5 pushable branches.
|
||||||
|
const hasUpstream = unpushed !== -1;
|
||||||
|
const atRisk = dirty || unmerged > 0 || (hasUpstream && unpushed > 0);
|
||||||
|
return { worktreePath, branch, dirty, unpushed, unmerged, atRisk };
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Stash a worktree's uncommitted changes (including untracked, via -u) so the
|
||||||
|
* working tree is clean. Stash entries live in the repo's common git dir, so
|
||||||
|
* they survive worktree-dir removal — this is the recoverable, safe-by-default
|
||||||
|
* escape. Note it only clears the *dirty* risk; unpushed/unmerged commits
|
||||||
|
* remain on the branch, so a re-attempted delete may still block on those.
|
||||||
|
*/
|
||||||
|
export async function stashWorktree(
|
||||||
|
worktreePath: string,
|
||||||
|
opts?: { signal?: AbortSignal },
|
||||||
|
): Promise<{ stashed: boolean; error?: string }> {
|
||||||
|
const r = await hostExec(
|
||||||
|
`git -C ${shellEscape(worktreePath)} stash push -u -m ${shellEscape('boocode: pre-delete stash')}`,
|
||||||
|
{ signal: opts?.signal, timeoutMs: 30_000 },
|
||||||
|
);
|
||||||
|
if (r.exitCode !== 0) {
|
||||||
|
return { stashed: false, error: r.stderr.trim() || r.stdout.trim() };
|
||||||
|
}
|
||||||
|
// "No local changes to save" => exit 0, nothing stashed — not an error.
|
||||||
|
const stashed = !/no local changes to save/i.test(r.stdout);
|
||||||
|
return { stashed };
|
||||||
|
}
|
||||||
|
|
||||||
/** Minimal shell escape for paths (single-quote wrapping). */
|
/** Minimal shell escape for paths (single-quote wrapping). */
|
||||||
function shellEscape(s: string): string {
|
function shellEscape(s: string): string {
|
||||||
// Replace single quotes with escaped version, wrap in single quotes
|
// Replace single quotes with escaped version, wrap in single quotes
|
||||||
|
|||||||
@@ -3,7 +3,7 @@ import { z } from 'zod';
|
|||||||
import type { Sql } from '../db.js';
|
import type { Sql } from '../db.js';
|
||||||
import type { Config } from '../config.js';
|
import type { Config } from '../config.js';
|
||||||
import type { Broker } from '../services/broker.js';
|
import type { Broker } from '../services/broker.js';
|
||||||
import type { Session } from '../types/api.js';
|
import type { Session, WorktreeRiskReport } from '../types/api.js';
|
||||||
import { getSetting } from './settings.js';
|
import { getSetting } from './settings.js';
|
||||||
|
|
||||||
const CreateBody = z.object({
|
const CreateBody = z.object({
|
||||||
@@ -426,10 +426,55 @@ export function registerSessionRoutes(
|
|||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|
||||||
app.delete<{ Params: { id: string } }>(
|
app.delete<{ Params: { id: string }; Querystring: { force?: string } }>(
|
||||||
'/api/sessions/:id',
|
'/api/sessions/:id',
|
||||||
async (req, reply) => {
|
async (req, reply) => {
|
||||||
const id = req.params.id;
|
const id = req.params.id;
|
||||||
|
const force = req.query.force === 'true' || req.query.force === '1';
|
||||||
|
|
||||||
|
// Session-delete work-loss guard. The check MUST run BEFORE the DELETE:
|
||||||
|
// worktrees.session_id is ON DELETE SET NULL (P1.5-b), so once the session
|
||||||
|
// is gone the worktree rows no longer point back to it — read them while
|
||||||
|
// the link still exists.
|
||||||
|
//
|
||||||
|
// Optimization: read worktrees (P1.5-b — was session_worktrees) from our
|
||||||
|
// own (shared) DB first. No row => chat-only session => nothing on disk =>
|
||||||
|
// delete immediately, zero round-trip. Only worktree-backed sessions pay
|
||||||
|
// the host git check.
|
||||||
|
if (!force) {
|
||||||
|
const worktrees = await sql<{ path: string }[]>`
|
||||||
|
SELECT path FROM worktrees WHERE session_id = ${id}
|
||||||
|
`;
|
||||||
|
if (worktrees.length > 0) {
|
||||||
|
// Worktree dirs live on the host; only BooCoder can run git on them.
|
||||||
|
const origin = process.env.BOOCODER_URL ?? 'http://boocoder:3000';
|
||||||
|
let reports: WorktreeRiskReport[];
|
||||||
|
try {
|
||||||
|
const res = await fetch(`${origin}/api/sessions/${id}/worktree-risk`);
|
||||||
|
if (!res.ok) {
|
||||||
|
// Fail-closed: can't verify => don't risk silent loss. Force escapes.
|
||||||
|
reply.code(409);
|
||||||
|
return {
|
||||||
|
error: 'could not verify worktree safety (BooCoder check failed). Use force to delete anyway.',
|
||||||
|
reports: [] as WorktreeRiskReport[],
|
||||||
|
};
|
||||||
|
}
|
||||||
|
reports = ((await res.json()) as { reports?: WorktreeRiskReport[] }).reports ?? [];
|
||||||
|
} catch {
|
||||||
|
// Fail-closed: BooCoder unreachable. Force bypasses this path entirely.
|
||||||
|
reply.code(409);
|
||||||
|
return {
|
||||||
|
error: 'BooCoder unreachable; cannot verify worktree safety. Use force to delete anyway.',
|
||||||
|
reports: [] as WorktreeRiskReport[],
|
||||||
|
};
|
||||||
|
}
|
||||||
|
if (reports.some((r) => r.atRisk)) {
|
||||||
|
reply.code(409);
|
||||||
|
return { error: 'This session has work at risk in its worktree.', reports };
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
const deleted = await sql<{ project_id: string }[]>`
|
const deleted = await sql<{ project_id: string }[]>`
|
||||||
DELETE FROM sessions WHERE id = ${id} RETURNING project_id
|
DELETE FROM sessions WHERE id = ${id} RETURNING project_id
|
||||||
`;
|
`;
|
||||||
|
|||||||
@@ -37,9 +37,11 @@ export async function maybeAutoNameChat(
|
|||||||
if ((counts[0]?.n ?? 0) < 1) return;
|
if ((counts[0]?.n ?? 0) < 1) return;
|
||||||
|
|
||||||
const chatRows = await ctx.sql<
|
const chatRows = await ctx.sql<
|
||||||
{ id: string; name: string | null; session_id: string }[]
|
{ id: string; name: string | null; session_id: string; model: string | null }[]
|
||||||
>`
|
>`
|
||||||
SELECT id, name, session_id FROM chats WHERE id = ${chatId}
|
SELECT c.id, c.name, c.session_id, s.model
|
||||||
|
FROM chats c JOIN sessions s ON s.id = c.session_id
|
||||||
|
WHERE c.id = ${chatId}
|
||||||
`;
|
`;
|
||||||
const chat = chatRows[0];
|
const chat = chatRows[0];
|
||||||
if (!chat) return;
|
if (!chat) return;
|
||||||
@@ -67,6 +69,7 @@ export async function maybeAutoNameChat(
|
|||||||
user: namingInput,
|
user: namingInput,
|
||||||
maxTokens: 30,
|
maxTokens: 30,
|
||||||
temperature: 0.3,
|
temperature: 0.3,
|
||||||
|
fallbackModel: chat.model ?? undefined,
|
||||||
});
|
});
|
||||||
const name = cleanTitle(raw);
|
const name = cleanTitle(raw);
|
||||||
if (!name) {
|
if (!name) {
|
||||||
|
|||||||
@@ -25,6 +25,20 @@ export interface AvailableProject {
|
|||||||
|
|
||||||
export type SessionStatus = 'open' | 'archived';
|
export type SessionStatus = 'open' | 'archived';
|
||||||
|
|
||||||
|
// Session-delete work-loss guard. Returned (as `reports`) in the 409 body when
|
||||||
|
// a delete is blocked because the session's worktree holds work at risk. The
|
||||||
|
// shape is produced by BooCoder's checkWorktreeWorkAtRisk and passed through
|
||||||
|
// verbatim; mirrored byte-for-byte in apps/web/src/api/types.ts for the dialog.
|
||||||
|
export interface WorktreeRiskReport {
|
||||||
|
worktreePath: string;
|
||||||
|
branch: string;
|
||||||
|
dirty: boolean;
|
||||||
|
unpushed: number; // commits ahead of upstream, or -1 if no upstream
|
||||||
|
unmerged: number; // commits not in the project default branch
|
||||||
|
atRisk: boolean;
|
||||||
|
error?: string;
|
||||||
|
}
|
||||||
|
|
||||||
export interface Session {
|
export interface Session {
|
||||||
id: string;
|
id: string;
|
||||||
project_id: string;
|
project_id: string;
|
||||||
|
|||||||
@@ -151,8 +151,17 @@ export const api = {
|
|||||||
method: 'PATCH',
|
method: 'PATCH',
|
||||||
body: JSON.stringify(body),
|
body: JSON.stringify(body),
|
||||||
}),
|
}),
|
||||||
remove: (id: string) =>
|
// force=true bypasses the server-side worktree work-loss guard. A blocked
|
||||||
request<void>(`/api/sessions/${id}`, { method: 'DELETE' }),
|
// delete throws ApiError(409) whose body carries { error, reports }.
|
||||||
|
remove: (id: string, force = false) =>
|
||||||
|
request<void>(`/api/sessions/${id}${force ? '?force=true' : ''}`, { method: 'DELETE' }),
|
||||||
|
// Stash the session's worktree (uncommitted changes) on the host, via the
|
||||||
|
// BooCoder proxy. Recoverable escape from the work-at-risk dialog.
|
||||||
|
worktreeStash: (id: string) =>
|
||||||
|
request<{ results: { worktreePath: string; stashed: boolean; error?: string }[] }>(
|
||||||
|
`/api/coder/sessions/${id}/worktree-stash`,
|
||||||
|
{ method: 'POST' },
|
||||||
|
),
|
||||||
archive: (id: string) =>
|
archive: (id: string) =>
|
||||||
request<void>(`/api/sessions/${id}/archive`, { method: 'POST' }),
|
request<void>(`/api/sessions/${id}/archive`, { method: 'POST' }),
|
||||||
unarchive: (id: string) =>
|
unarchive: (id: string) =>
|
||||||
|
|||||||
@@ -34,6 +34,19 @@ export interface AvailableProject {
|
|||||||
|
|
||||||
export type SessionStatus = 'open' | 'archived';
|
export type SessionStatus = 'open' | 'archived';
|
||||||
|
|
||||||
|
// Session-delete work-loss guard. Mirror of WorktreeRiskReport in
|
||||||
|
// apps/server/src/types/api.ts — edit both copies together. Arrives as the
|
||||||
|
// `reports` field of the 409 body when a delete is blocked.
|
||||||
|
export interface WorktreeRiskReport {
|
||||||
|
worktreePath: string;
|
||||||
|
branch: string;
|
||||||
|
dirty: boolean;
|
||||||
|
unpushed: number; // commits ahead of upstream, or -1 if no upstream
|
||||||
|
unmerged: number; // commits not in the project default branch
|
||||||
|
atRisk: boolean;
|
||||||
|
error?: string;
|
||||||
|
}
|
||||||
|
|
||||||
export interface Session {
|
export interface Session {
|
||||||
id: string;
|
id: string;
|
||||||
project_id: string;
|
project_id: string;
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
import { useState } from 'react';
|
import { useState } from 'react';
|
||||||
import { Code, History, MessageSquare, Plus, Terminal, X } from 'lucide-react';
|
import { Code, Columns2, History, MessageSquare, Plus, RotateCcw, Terminal, X } from 'lucide-react';
|
||||||
import type { Chat, WorkspacePane } from '@/api/types';
|
import type { Chat, WorkspacePane } from '@/api/types';
|
||||||
import { StatusDot } from '@/components/StatusDot';
|
import { StatusDot } from '@/components/StatusDot';
|
||||||
import {
|
import {
|
||||||
@@ -26,7 +26,9 @@ interface Props {
|
|||||||
onCloseOthers: (chatId: string) => void;
|
onCloseOthers: (chatId: string) => void;
|
||||||
onCloseToRight: (chatId: string) => void;
|
onCloseToRight: (chatId: string) => void;
|
||||||
onCloseAll: () => void;
|
onCloseAll: () => void;
|
||||||
onAddPane: (kind: 'chat' | 'terminal' | 'coder') => void;
|
onNewTab: () => void;
|
||||||
|
onSplitPane: (kind: 'chat' | 'terminal' | 'coder') => void;
|
||||||
|
onReopenPane?: () => void;
|
||||||
onShowHistory: () => void;
|
onShowHistory: () => void;
|
||||||
onRename: (chatId: string, name: string) => Promise<void>;
|
onRename: (chatId: string, name: string) => Promise<void>;
|
||||||
onRemovePane?: () => void;
|
onRemovePane?: () => void;
|
||||||
@@ -40,7 +42,9 @@ export function ChatTabBar({
|
|||||||
onCloseOthers,
|
onCloseOthers,
|
||||||
onCloseToRight,
|
onCloseToRight,
|
||||||
onCloseAll,
|
onCloseAll,
|
||||||
onAddPane,
|
onNewTab,
|
||||||
|
onSplitPane,
|
||||||
|
onReopenPane,
|
||||||
onShowHistory,
|
onShowHistory,
|
||||||
onRename,
|
onRename,
|
||||||
onRemovePane,
|
onRemovePane,
|
||||||
@@ -131,7 +135,7 @@ export function ChatTabBar({
|
|||||||
</div>
|
</div>
|
||||||
</ContextMenuTrigger>
|
</ContextMenuTrigger>
|
||||||
<ContextMenuContent>
|
<ContextMenuContent>
|
||||||
<ContextMenuItem onSelect={() => onAddPane('chat')}>
|
<ContextMenuItem onSelect={onNewTab}>
|
||||||
New chat
|
New chat
|
||||||
</ContextMenuItem>
|
</ContextMenuItem>
|
||||||
<ContextMenuSeparator />
|
<ContextMenuSeparator />
|
||||||
@@ -170,29 +174,49 @@ export function ChatTabBar({
|
|||||||
)}
|
)}
|
||||||
|
|
||||||
<div className="flex items-center ml-auto gap-0.5 px-1 shrink-0">
|
<div className="flex items-center ml-auto gap-0.5 px-1 shrink-0">
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={onNewTab}
|
||||||
|
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
||||||
|
aria-label="New tab"
|
||||||
|
title="New tab"
|
||||||
|
>
|
||||||
|
<Plus size={12} />
|
||||||
|
</button>
|
||||||
<DropdownMenu>
|
<DropdownMenu>
|
||||||
<DropdownMenuTrigger asChild>
|
<DropdownMenuTrigger asChild>
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
||||||
aria-label="New pane"
|
aria-label="Split pane"
|
||||||
title="New pane"
|
title="Split pane"
|
||||||
>
|
>
|
||||||
<Plus size={12} />
|
<Columns2 size={12} />
|
||||||
</button>
|
</button>
|
||||||
</DropdownMenuTrigger>
|
</DropdownMenuTrigger>
|
||||||
<DropdownMenuContent align="end" className="w-fit">
|
<DropdownMenuContent align="end" className="w-fit">
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('chat')}>
|
<DropdownMenuItem onSelect={() => onSplitPane('chat')}>
|
||||||
<MessageSquare size={14} /> New BooChat
|
<MessageSquare size={14} /> New BooChat
|
||||||
</DropdownMenuItem>
|
</DropdownMenuItem>
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('terminal')}>
|
<DropdownMenuItem onSelect={() => onSplitPane('terminal')}>
|
||||||
<Terminal size={14} /> New BooTerm
|
<Terminal size={14} /> New BooTerm
|
||||||
</DropdownMenuItem>
|
</DropdownMenuItem>
|
||||||
<DropdownMenuItem onSelect={() => onAddPane('coder')}>
|
<DropdownMenuItem onSelect={() => onSplitPane('coder')}>
|
||||||
<Code size={14} /> New BooCode
|
<Code size={14} /> New BooCode
|
||||||
</DropdownMenuItem>
|
</DropdownMenuItem>
|
||||||
</DropdownMenuContent>
|
</DropdownMenuContent>
|
||||||
</DropdownMenu>
|
</DropdownMenu>
|
||||||
|
{onReopenPane && (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={onReopenPane}
|
||||||
|
className="inline-flex items-center justify-center p-1 rounded text-muted-foreground hover:bg-muted hover:text-foreground max-md:min-h-[44px] max-md:min-w-[44px]"
|
||||||
|
aria-label="Reopen closed pane"
|
||||||
|
title="Reopen closed pane"
|
||||||
|
>
|
||||||
|
<RotateCcw size={12} />
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
onClick={onShowHistory}
|
onClick={onShowHistory}
|
||||||
|
|||||||
@@ -19,12 +19,12 @@ import {
|
|||||||
DialogDescription,
|
DialogDescription,
|
||||||
} from '@/components/ui/dialog';
|
} from '@/components/ui/dialog';
|
||||||
import { AddProjectModal } from './AddProjectModal';
|
import { AddProjectModal } from './AddProjectModal';
|
||||||
import { api } from '@/api/client';
|
import { api, ApiError } from '@/api/client';
|
||||||
import { useSidebar } from '@/hooks/useSidebar';
|
import { useSidebar } from '@/hooks/useSidebar';
|
||||||
import { useSidebarDrawer } from '@/hooks/useSidebarDrawer';
|
import { useSidebarDrawer } from '@/hooks/useSidebarDrawer';
|
||||||
import { useViewport } from '@/hooks/useViewport';
|
import { useViewport } from '@/hooks/useViewport';
|
||||||
import { usePullToRefresh } from '@/hooks/usePullToRefresh';
|
import { usePullToRefresh } from '@/hooks/usePullToRefresh';
|
||||||
import type { SidebarProject } from '@/api/types';
|
import type { SidebarProject, WorktreeRiskReport } from '@/api/types';
|
||||||
import { giteaUrlFor } from '@/lib/projectUrls';
|
import { giteaUrlFor } from '@/lib/projectUrls';
|
||||||
import { isCoderSessionName } from '@/lib/coder-session';
|
import { isCoderSessionName } from '@/lib/coder-session';
|
||||||
import { cn } from '@/lib/utils';
|
import { cn } from '@/lib/utils';
|
||||||
@@ -110,6 +110,16 @@ export function ProjectSidebar() {
|
|||||||
const [renamingProject, setRenamingProject] = useState<string | null>(null);
|
const [renamingProject, setRenamingProject] = useState<string | null>(null);
|
||||||
const [renameProjectValue, setRenameProjectValue] = useState('');
|
const [renameProjectValue, setRenameProjectValue] = useState('');
|
||||||
const [archiveProjectConfirm, setArchiveProjectConfirm] = useState<{ id: string; name: string } | null>(null);
|
const [archiveProjectConfirm, setArchiveProjectConfirm] = useState<{ id: string; name: string } | null>(null);
|
||||||
|
// Work-at-risk dialog: shown when a delete is blocked (409) because the
|
||||||
|
// session's worktree holds uncommitted/unpushed/unmerged work.
|
||||||
|
const [riskState, setRiskState] = useState<{
|
||||||
|
sessionId: string;
|
||||||
|
projectId: string;
|
||||||
|
name: string;
|
||||||
|
message: string;
|
||||||
|
reports: WorktreeRiskReport[];
|
||||||
|
} | null>(null);
|
||||||
|
const [riskBusy, setRiskBusy] = useState(false);
|
||||||
const navigate = useNavigate();
|
const navigate = useNavigate();
|
||||||
const location = useLocation();
|
const location = useLocation();
|
||||||
const lastToastedError = useRef<string | null>(null);
|
const lastToastedError = useRef<string | null>(null);
|
||||||
@@ -174,16 +184,81 @@ export function ProjectSidebar() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async function handleDeleteSession(sessionId: string, projectId: string) {
|
async function handleDeleteSession(
|
||||||
|
sessionId: string,
|
||||||
|
projectId: string,
|
||||||
|
name: string,
|
||||||
|
force = false,
|
||||||
|
) {
|
||||||
try {
|
try {
|
||||||
await api.sessions.remove(sessionId);
|
await api.sessions.remove(sessionId, force);
|
||||||
// Server publishes session_deleted via WS; useUserEvents delivers it.
|
// Server publishes session_deleted via WS; useUserEvents delivers it.
|
||||||
|
setRiskState(null);
|
||||||
if (activeSession === sessionId) navigate(`/project/${projectId}`);
|
if (activeSession === sessionId) navigate(`/project/${projectId}`);
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
|
// 409 => the server's work-loss guard blocked the delete. Open the
|
||||||
|
// work-at-risk dialog with the per-worktree reports instead of toasting.
|
||||||
|
if (
|
||||||
|
err instanceof ApiError &&
|
||||||
|
err.status === 409 &&
|
||||||
|
err.body && typeof err.body === 'object' && 'reports' in err.body
|
||||||
|
) {
|
||||||
|
const body = err.body as { error?: string; reports?: WorktreeRiskReport[] };
|
||||||
|
setRiskState({
|
||||||
|
sessionId,
|
||||||
|
projectId,
|
||||||
|
name,
|
||||||
|
message: body.error ?? 'This session has work at risk.',
|
||||||
|
reports: body.reports ?? [],
|
||||||
|
});
|
||||||
|
return;
|
||||||
|
}
|
||||||
toast.error(err instanceof Error ? err.message : 'failed to delete session');
|
toast.error(err instanceof Error ? err.message : 'failed to delete session');
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Stash the worktree's uncommitted changes (recoverable), then re-attempt the
|
||||||
|
// delete. If unpushed/unmerged commits remain, the retry 409s again and the
|
||||||
|
// dialog re-renders with the narrowed risk.
|
||||||
|
async function handleStashAndRetry() {
|
||||||
|
if (!riskState || riskBusy) return;
|
||||||
|
setRiskBusy(true);
|
||||||
|
try {
|
||||||
|
const { results } = await api.sessions.worktreeStash(riskState.sessionId);
|
||||||
|
const failed = results.find((r) => r.error);
|
||||||
|
if (failed) {
|
||||||
|
toast.error(`stash failed: ${failed.error}`);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
await handleDeleteSession(riskState.sessionId, riskState.projectId, riskState.name, false);
|
||||||
|
} catch (err) {
|
||||||
|
toast.error(err instanceof Error ? err.message : 'stash failed');
|
||||||
|
} finally {
|
||||||
|
setRiskBusy(false);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Explicit, destructive override — deletes despite work at risk.
|
||||||
|
async function handleForceDelete() {
|
||||||
|
if (!riskState || riskBusy) return;
|
||||||
|
setRiskBusy(true);
|
||||||
|
try {
|
||||||
|
await handleDeleteSession(riskState.sessionId, riskState.projectId, riskState.name, true);
|
||||||
|
} finally {
|
||||||
|
setRiskBusy(false);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Route the user to commit it themselves — never auto-commit. Opens the
|
||||||
|
// session workspace where they can use a terminal or agent pane.
|
||||||
|
function handleGoCommit() {
|
||||||
|
if (!riskState) return;
|
||||||
|
const sessionId = riskState.sessionId;
|
||||||
|
setRiskState(null);
|
||||||
|
navigate(`/session/${sessionId}`);
|
||||||
|
toast.info('Open a terminal or agent in this session, commit and push your work, then delete again.');
|
||||||
|
}
|
||||||
|
|
||||||
async function handleRenameSession(sessionId: string) {
|
async function handleRenameSession(sessionId: string) {
|
||||||
const trimmed = renameValue.trim();
|
const trimmed = renameValue.trim();
|
||||||
setRenamingSession(null);
|
setRenamingSession(null);
|
||||||
@@ -216,6 +291,20 @@ export function ProjectSidebar() {
|
|||||||
)
|
)
|
||||||
: 'w-60 shrink-0 border-r bg-sidebar text-sidebar-foreground flex flex-col h-screen';
|
: 'w-60 shrink-0 border-r bg-sidebar text-sidebar-foreground flex flex-col h-screen';
|
||||||
|
|
||||||
|
// Work-at-risk dialog framing. The server returns 409 in two distinct
|
||||||
|
// situations: (1) work genuinely at risk (reports has ≥1 atRisk entry), or
|
||||||
|
// (2) it couldn't verify (BooCoder down/errored → reports is empty). These
|
||||||
|
// are different user stories — "your work is in danger" vs "the checker is
|
||||||
|
// offline" — so the dialog must not show one generic message for both.
|
||||||
|
const atRiskReports = riskState?.reports.filter((r) => r.atRisk) ?? [];
|
||||||
|
const verifyFailed = riskState !== null && atRiskReports.length === 0;
|
||||||
|
const anyDirty = atRiskReports.some((r) => r.dirty);
|
||||||
|
// Commit-based risk (unpushed/unmerged) that stash can NOT clear. When this is
|
||||||
|
// all that remains (e.g. after a stash cleared the dirty changes), the dialog
|
||||||
|
// explains why it re-blocked and hides the Stash button so it doesn't look
|
||||||
|
// like stash "didn't work".
|
||||||
|
const anyCommits = atRiskReports.some((r) => r.unpushed !== 0 || r.unmerged > 0);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<aside className={asideCls}>
|
<aside className={asideCls}>
|
||||||
<div className="px-4 py-3 border-b flex items-center justify-between">
|
<div className="px-4 py-3 border-b flex items-center justify-between">
|
||||||
@@ -499,7 +588,7 @@ export function ProjectSidebar() {
|
|||||||
const projectId = projects.find((p) =>
|
const projectId = projects.find((p) =>
|
||||||
p.recent_sessions.some((s) => s.id === deleteConfirm.id)
|
p.recent_sessions.some((s) => s.id === deleteConfirm.id)
|
||||||
)?.id;
|
)?.id;
|
||||||
if (projectId) void handleDeleteSession(deleteConfirm.id, projectId);
|
if (projectId) void handleDeleteSession(deleteConfirm.id, projectId, deleteConfirm.name);
|
||||||
}
|
}
|
||||||
setDeleteConfirm(null);
|
setDeleteConfirm(null);
|
||||||
}}
|
}}
|
||||||
@@ -509,6 +598,77 @@ export function ProjectSidebar() {
|
|||||||
</div>
|
</div>
|
||||||
</DialogContent>
|
</DialogContent>
|
||||||
</Dialog>
|
</Dialog>
|
||||||
|
|
||||||
|
<Dialog open={riskState !== null} onOpenChange={(open) => { if (!open && !riskBusy) setRiskState(null); }}>
|
||||||
|
<DialogContent>
|
||||||
|
<DialogHeader>
|
||||||
|
<DialogTitle>
|
||||||
|
{verifyFailed ? 'Could not verify worktree safety' : 'This session has work at risk'}
|
||||||
|
</DialogTitle>
|
||||||
|
<DialogDescription>
|
||||||
|
{verifyFailed ? (
|
||||||
|
<>
|
||||||
|
{riskState?.message ?? 'The worktree safety check is unavailable.'} Your work may be
|
||||||
|
fine, but it couldn't be checked — only force-delete if you're sure.
|
||||||
|
</>
|
||||||
|
) : anyDirty && anyCommits ? (
|
||||||
|
<>
|
||||||
|
Deleting {riskState ? `"${riskState.name}"` : 'this session'} would orphan uncommitted
|
||||||
|
changes <em>and</em> commits that aren't pushed or merged. Stash clears the
|
||||||
|
changes (recoverable), but the commits will still block — push them or force-delete.
|
||||||
|
</>
|
||||||
|
) : anyDirty ? (
|
||||||
|
<>
|
||||||
|
Deleting {riskState ? `"${riskState.name}"` : 'this session'} would orphan uncommitted
|
||||||
|
changes in its worktree. Stash them (recoverable), commit them, or force-delete.
|
||||||
|
</>
|
||||||
|
) : (
|
||||||
|
<>
|
||||||
|
Deleting {riskState ? `"${riskState.name}"` : 'this session'} would orphan commits that
|
||||||
|
aren't pushed or merged. Stashing won't recover these — push them, or
|
||||||
|
force-delete.
|
||||||
|
</>
|
||||||
|
)}
|
||||||
|
</DialogDescription>
|
||||||
|
</DialogHeader>
|
||||||
|
{!verifyFailed && (
|
||||||
|
<div className="flex flex-col gap-2 py-1 text-sm">
|
||||||
|
{atRiskReports.map((r) => (
|
||||||
|
<div key={r.worktreePath} className="rounded border border-border/60 px-3 py-2">
|
||||||
|
<div className="font-mono text-xs text-muted-foreground truncate" title={r.worktreePath}>
|
||||||
|
{r.branch || r.worktreePath}
|
||||||
|
</div>
|
||||||
|
<ul className="mt-1 list-disc pl-5 text-foreground/90">
|
||||||
|
{r.error && <li className="text-destructive">git error: {r.error}</li>}
|
||||||
|
{r.dirty && <li>uncommitted changes</li>}
|
||||||
|
{r.unpushed === -1 && <li>local-only branch (no upstream)</li>}
|
||||||
|
{r.unpushed > 0 && <li>{r.unpushed} unpushed commit{r.unpushed === 1 ? '' : 's'}</li>}
|
||||||
|
{r.unmerged > 0 && <li>{r.unmerged} unmerged commit{r.unmerged === 1 ? '' : 's'}</li>}
|
||||||
|
</ul>
|
||||||
|
</div>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
<div className="flex flex-wrap gap-2 justify-end pt-2">
|
||||||
|
<Button variant="outline" disabled={riskBusy} onClick={() => setRiskState(null)}>
|
||||||
|
Cancel
|
||||||
|
</Button>
|
||||||
|
{!verifyFailed && (
|
||||||
|
<Button variant="outline" disabled={riskBusy} onClick={handleGoCommit}>
|
||||||
|
Commit…
|
||||||
|
</Button>
|
||||||
|
)}
|
||||||
|
{!verifyFailed && anyDirty && (
|
||||||
|
<Button variant="outline" disabled={riskBusy} onClick={() => void handleStashAndRetry()}>
|
||||||
|
Stash & delete
|
||||||
|
</Button>
|
||||||
|
)}
|
||||||
|
<Button variant="destructive" disabled={riskBusy} onClick={() => void handleForceDelete()}>
|
||||||
|
Force delete
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
</DialogContent>
|
||||||
|
</Dialog>
|
||||||
</aside>
|
</aside>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -65,6 +65,8 @@ export function Workspace({
|
|||||||
showLandingPage,
|
showLandingPage,
|
||||||
addSplitPane,
|
addSplitPane,
|
||||||
removePane,
|
removePane,
|
||||||
|
reopenPane,
|
||||||
|
hasClosedPanes,
|
||||||
isPaneChatPending,
|
isPaneChatPending,
|
||||||
handlePaneDragStart,
|
handlePaneDragStart,
|
||||||
handlePaneDragOver,
|
handlePaneDragOver,
|
||||||
@@ -207,10 +209,9 @@ export function Workspace({
|
|||||||
onCloseOthers={(chatId) => closeOtherTabs(idx, chatId)}
|
onCloseOthers={(chatId) => closeOtherTabs(idx, chatId)}
|
||||||
onCloseToRight={(chatId) => closeTabsToRight(idx, chatId)}
|
onCloseToRight={(chatId) => closeTabsToRight(idx, chatId)}
|
||||||
onCloseAll={() => closeAllTabs(idx)}
|
onCloseAll={() => closeAllTabs(idx)}
|
||||||
onAddPane={(kind) => {
|
onNewTab={() => void createChat(idx)}
|
||||||
if (kind === 'chat') void createChat(idx);
|
onSplitPane={(kind) => onAddPane(kind)}
|
||||||
else onAddPane(kind);
|
onReopenPane={hasClosedPanes ? reopenPane : undefined}
|
||||||
}}
|
|
||||||
onShowHistory={() => showLandingPage(idx)}
|
onShowHistory={() => showLandingPage(idx)}
|
||||||
onRename={renameChat}
|
onRename={renameChat}
|
||||||
onRemovePane={panes.length > 1 ? () => removePane(idx) : undefined}
|
onRemovePane={panes.length > 1 ? () => removePane(idx) : undefined}
|
||||||
|
|||||||
@@ -32,6 +32,21 @@ function chatPane(chatId: string): WorkspacePane {
|
|||||||
return { id: generateId(), kind: 'chat', chatId, chatIds: [chatId], activeChatIdx: 0 };
|
return { id: generateId(), kind: 'chat', chatId, chatIds: [chatId], activeChatIdx: 0 };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
interface ClosedPaneEntry {
|
||||||
|
kind: WorkspacePane['kind'];
|
||||||
|
chatIds: string[];
|
||||||
|
activeChatIdx: number;
|
||||||
|
}
|
||||||
|
const MAX_CLOSED = 10;
|
||||||
|
const closedPaneStack: ClosedPaneEntry[] = [];
|
||||||
|
|
||||||
|
function pushClosed(pane: WorkspacePane): void {
|
||||||
|
if (pane.kind === 'empty' || pane.kind === 'settings') return;
|
||||||
|
if (pane.chatIds.length === 0) return;
|
||||||
|
closedPaneStack.push({ kind: pane.kind, chatIds: [...pane.chatIds], activeChatIdx: pane.activeChatIdx });
|
||||||
|
if (closedPaneStack.length > MAX_CLOSED) closedPaneStack.shift();
|
||||||
|
}
|
||||||
|
|
||||||
function chatNameForPaneKind(kind: 'coder' | 'terminal'): string {
|
function chatNameForPaneKind(kind: 'coder' | 'terminal'): string {
|
||||||
return kind === 'coder' ? 'BooCoder' : 'Terminal';
|
return kind === 'coder' ? 'BooCoder' : 'Terminal';
|
||||||
}
|
}
|
||||||
@@ -137,6 +152,8 @@ export interface UseWorkspacePanesResult {
|
|||||||
// falls back to an empty pane to preserve the "always one pane" invariant.
|
// falls back to an empty pane to preserve the "always one pane" invariant.
|
||||||
toggleSettingsPane: () => string | null;
|
toggleSettingsPane: () => string | null;
|
||||||
removePane: (idx: number) => void;
|
removePane: (idx: number) => void;
|
||||||
|
reopenPane: () => void;
|
||||||
|
hasClosedPanes: boolean;
|
||||||
removeChatFromPanes: (chatId: string) => void;
|
removeChatFromPanes: (chatId: string) => void;
|
||||||
initializeFirstChatIfEmpty: (chatId: string) => void;
|
initializeFirstChatIfEmpty: (chatId: string) => void;
|
||||||
validatePanes: (validChatIds: Set<string>) => void;
|
validatePanes: (validChatIds: Set<string>) => void;
|
||||||
@@ -391,6 +408,14 @@ export function useWorkspacePanes(sessionId: string): UseWorkspacePanesResult {
|
|||||||
const pane = next[paneIdx]!;
|
const pane = next[paneIdx]!;
|
||||||
const nextIds = pane.chatIds.filter((id) => id !== chatId);
|
const nextIds = pane.chatIds.filter((id) => id !== chatId);
|
||||||
if (nextIds.length === 0) {
|
if (nextIds.length === 0) {
|
||||||
|
if (next.length > 1) {
|
||||||
|
// Last tab closed and other panes exist — remove the whole pane
|
||||||
|
// instead of leaving an orphaned empty panel.
|
||||||
|
pushClosed(pane); setHasClosedPanes(true);
|
||||||
|
const spliced = next.filter((_, i) => i !== paneIdx);
|
||||||
|
setActivePaneIdx((ai) => Math.min(ai, spliced.length - 1));
|
||||||
|
return spliced;
|
||||||
|
}
|
||||||
next[paneIdx] = { ...pane, kind: 'empty', chatId: undefined, chatIds: [], activeChatIdx: -1 };
|
next[paneIdx] = { ...pane, kind: 'empty', chatId: undefined, chatIds: [], activeChatIdx: -1 };
|
||||||
} else {
|
} else {
|
||||||
const nextActiveIdx = Math.min(pane.activeChatIdx, nextIds.length - 1);
|
const nextActiveIdx = Math.min(pane.activeChatIdx, nextIds.length - 1);
|
||||||
@@ -534,6 +559,7 @@ export function useWorkspacePanes(sessionId: string): UseWorkspacePanesResult {
|
|||||||
// The endpoint is idempotent (404 on missing session) so a strict-mode
|
// The endpoint is idempotent (404 on missing session) so a strict-mode
|
||||||
// double-invoke of the updater is safe.
|
// double-invoke of the updater is safe.
|
||||||
const removed = prev[idx];
|
const removed = prev[idx];
|
||||||
|
if (removed) { pushClosed(removed); setHasClosedPanes(true); }
|
||||||
if (removed?.kind === 'terminal') {
|
if (removed?.kind === 'terminal') {
|
||||||
api.terminals.kill(sessionId, removed.id).catch(() => { /* non-fatal */ });
|
api.terminals.kill(sessionId, removed.id).catch(() => { /* non-fatal */ });
|
||||||
}
|
}
|
||||||
@@ -543,6 +569,26 @@ export function useWorkspacePanes(sessionId: string): UseWorkspacePanesResult {
|
|||||||
});
|
});
|
||||||
}, [sessionId]);
|
}, [sessionId]);
|
||||||
|
|
||||||
|
const [hasClosedPanes, setHasClosedPanes] = useState(closedPaneStack.length > 0);
|
||||||
|
|
||||||
|
const reopenPane = useCallback(() => {
|
||||||
|
const entry = closedPaneStack.pop();
|
||||||
|
setHasClosedPanes(closedPaneStack.length > 0);
|
||||||
|
if (!entry) return;
|
||||||
|
setPanes((prev) => {
|
||||||
|
const restored: WorkspacePane = {
|
||||||
|
id: generateId(),
|
||||||
|
kind: entry.kind,
|
||||||
|
chatId: entry.chatIds[entry.activeChatIdx] ?? entry.chatIds[0],
|
||||||
|
chatIds: entry.chatIds,
|
||||||
|
activeChatIdx: Math.min(entry.activeChatIdx, entry.chatIds.length - 1),
|
||||||
|
};
|
||||||
|
const next = [...prev, restored];
|
||||||
|
setActivePaneIdx(next.length - 1);
|
||||||
|
return next;
|
||||||
|
});
|
||||||
|
}, []);
|
||||||
|
|
||||||
// Replaces a single empty default pane with a chat pane. Used by the initial
|
// Replaces a single empty default pane with a chat pane. Used by the initial
|
||||||
// chat fetch to land on the most-recent open chat if no saved pane state.
|
// chat fetch to land on the most-recent open chat if no saved pane state.
|
||||||
const initializeFirstChatIfEmpty = useCallback((chatId: string) => {
|
const initializeFirstChatIfEmpty = useCallback((chatId: string) => {
|
||||||
@@ -672,6 +718,8 @@ export function useWorkspacePanes(sessionId: string): UseWorkspacePanesResult {
|
|||||||
addSplitPane,
|
addSplitPane,
|
||||||
toggleSettingsPane,
|
toggleSettingsPane,
|
||||||
removePane,
|
removePane,
|
||||||
|
reopenPane,
|
||||||
|
hasClosedPanes,
|
||||||
removeChatFromPanes,
|
removeChatFromPanes,
|
||||||
initializeFirstChatIfEmpty,
|
initializeFirstChatIfEmpty,
|
||||||
validatePanes,
|
validatePanes,
|
||||||
|
|||||||
@@ -1,5 +1,11 @@
|
|||||||
# Agents
|
# Agents
|
||||||
|
|
||||||
|
Operating rules for every agent in this registry. Full procedures live in the `committing-changes` and `using-worktrees` skills.
|
||||||
|
|
||||||
|
**Committing** — Commit only on Sam's explicit command, never autonomously and never on apply; never `git push` (Sam pushes manually, Gitea + GitHub mirror). Stage by concern (named files or `git add -p`), never `git add -A`; never stage Sam's unrelated work. Identity `indifferentketchup` / `sam@indifferentketchup.com`, never a personal Gmail. Freeform scope-prefix messages, explain *why* for non-obvious changes, no emojis. Full workflow: invoke `committing-changes`.
|
||||||
|
|
||||||
|
**Worktrees** — Isolate work in a worktree when it is parallel to in-progress work, risky/experimental, a hotfix interrupting other work, or splits into independent units — just create when clear, propose in one line when ambiguous, skip quick/small single-stream work. Branch from a stable base (default branch); worktrees persist (never auto-remove or auto-merge); they isolate code state, not runtime (ports/DBs/services still collide). Full heuristic: invoke `using-worktrees`.
|
||||||
|
|
||||||
## Code Reviewer
|
## Code Reviewer
|
||||||
---
|
---
|
||||||
temperature: 0.6
|
temperature: 0.6
|
||||||
|
|||||||
12
data/coder-providers.example.json
Normal file
12
data/coder-providers.example.json
Normal file
@@ -0,0 +1,12 @@
|
|||||||
|
{
|
||||||
|
"providers": {
|
||||||
|
"goose": { "enabled": false },
|
||||||
|
"amp-acp": {
|
||||||
|
"extends": "acp",
|
||||||
|
"label": "Amp",
|
||||||
|
"description": "ACP wrapper for Amp",
|
||||||
|
"command": ["amp-acp"],
|
||||||
|
"enabled": true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,3 +0,0 @@
|
|||||||
{
|
|
||||||
"providers": {}
|
|
||||||
}
|
|
||||||
60
data/skills/boocode/committing-changes/SKILL.md
Normal file
60
data/skills/boocode/committing-changes/SKILL.md
Normal file
@@ -0,0 +1,60 @@
|
|||||||
|
---
|
||||||
|
name: committing-changes
|
||||||
|
description: This skill should be used when the user asks to commit, stage, split, or prepare changes for a commit. Examples: "commit this", "stage these", "split this into commits", "help me commit", "prepare a commit", "make a commit for the dcp fix".
|
||||||
|
---
|
||||||
|
|
||||||
|
# Committing Changes
|
||||||
|
|
||||||
|
Segment the working tree by concern, stage explicitly, draft messages, **present the plan, and STOP**. Commit only on the user's explicit command for this turn. Never push — the user pushes manually (Gitea + GitHub mirror).
|
||||||
|
|
||||||
|
**The default is to prepare and propose, not to commit.** A request to "commit X" is a request to get X *ready* and show the plan, unless the user has, in this turn, told you to actually run the commit. When in doubt, present and wait.
|
||||||
|
|
||||||
|
## Workflow
|
||||||
|
|
||||||
|
1. **Inspect.** `git status` then `git diff` (and `git diff --staged` if anything is already staged). Read what actually changed — do not commit from memory of what you wrote.
|
||||||
|
2. **Segment by concern.** Group the changes into buckets, one per coherent concern. State the grouping in plain language before staging anything (e.g. "two concerns: (a) the SSE fix in opencode-server.ts, (b) an unrelated typo in README").
|
||||||
|
3. **Safety scan.** Before staging, scan the diff for: secrets / keys / tokens, debug code, stray `console.log`/`print`/`dbg!`, commented-out experiments, and edits to files the user did not ask you to touch (their in-progress work). Flag anything found; do not silently stage it.
|
||||||
|
4. **Stage explicitly, per bucket.** Stage named files (`git add path/a path/b`) or hunks (`git add -p`). **Never `git add -A`, `git add .`, or `git add -u`** — those sweep up unrelated work. If `-p` can't cleanly split adjacent hunks, hand-edit the patch (`git add -e`) or revert the unrelated hunk in the working tree first.
|
||||||
|
5. **Draft messages.** One message per bucket, in the repo's scope-prefix style (see `references/message-style.md`). Explain *why* for anything non-obvious — the diff already shows *what*. Imperative mood. No emojis. Do not impose Conventional-Commits ceremony (type enums, `BREAKING CHANGE:` footers) unless the user asks.
|
||||||
|
6. **Present the plan + STOP.** Show: the buckets, the files in each, the drafted message for each, and the current staged state. Then wait. **Do not run `git commit`.**
|
||||||
|
7. **On the user's command**, execute the agreed `git add` / `git commit` exactly as presented, using the identity below. Then report the resulting hashes. Still do not push.
|
||||||
|
|
||||||
|
## Split heuristic
|
||||||
|
|
||||||
|
- **One commit** when the changes are a single coherent concern (a feature + its test; a fix + the comment explaining it).
|
||||||
|
- **Multiple commits** when concerns are independently revertable or reviewable — a bug fix and an unrelated refactor that happen to share the working tree should be two commits even if they touch the same file.
|
||||||
|
- A migration/schema change and the code that uses it are usually *one* concern (they're not independently revertable). A doc/changelog update alongside code is usually a *separate* concern.
|
||||||
|
|
||||||
|
## Identity (always)
|
||||||
|
|
||||||
|
Commit as:
|
||||||
|
|
||||||
|
```
|
||||||
|
user.name = indifferentketchup
|
||||||
|
user.email = sam@indifferentketchup.com
|
||||||
|
```
|
||||||
|
|
||||||
|
Never use a personal Gmail or the host's default git identity. If unsure the repo config is right, pass it inline: `git -c user.name=indifferentketchup -c user.email=sam@indifferentketchup.com commit -m "..."`.
|
||||||
|
|
||||||
|
## DO-NOT
|
||||||
|
|
||||||
|
- **Never push.** No `git push` under any circumstances — that is the user's manual step (dual remote: Gitea + GitHub mirror).
|
||||||
|
- **Never auto-commit.** Preparing ≠ committing. Commit only when told to, this turn.
|
||||||
|
- **Never `git add -A` / `git add .` / `git add -u`.** Stage by name or by hunk.
|
||||||
|
- **Never commit the user's unrelated/in-progress files.** If a file changed that the task didn't touch, leave it; surface it.
|
||||||
|
- **No emojis** in messages.
|
||||||
|
- **No amending or rebasing** published or shared commits without an explicit instruction.
|
||||||
|
|
||||||
|
## Red flags — STOP
|
||||||
|
|
||||||
|
- About to run `git commit` without having been told to commit this turn → STOP, present the plan instead.
|
||||||
|
- About to `git add -A` "to save time" → STOP, stage by concern.
|
||||||
|
- About to `git push` "to finish the job" → STOP, that is never part of this skill.
|
||||||
|
- A secret or debug line is in the diff and you're staging anyway → STOP, surface it.
|
||||||
|
|
||||||
|
## Anti-patterns this skill avoids
|
||||||
|
|
||||||
|
- Committing the moment changes look done (the user reviews diffs and commits on command).
|
||||||
|
- Collapsing several concerns into one "WIP" commit because staging separately is tedious.
|
||||||
|
- Pushing after committing because the work "feels finished."
|
||||||
|
- Reformatting the message into strict Conventional Commits when the repo uses freeform scope-prefixes.
|
||||||
31
data/skills/boocode/committing-changes/eval.yaml
Normal file
31
data/skills/boocode/committing-changes/eval.yaml
Normal file
@@ -0,0 +1,31 @@
|
|||||||
|
skill: committing-changes
|
||||||
|
tasks:
|
||||||
|
- prompt: "Commit this for me"
|
||||||
|
grader:
|
||||||
|
- the response invokes the committing-changes skill
|
||||||
|
- the response inspects the working tree (git status / git diff) before staging
|
||||||
|
- the response segments the changes by concern and states the grouping
|
||||||
|
- the response stages explicitly (named files or git add -p), never git add -A / git add . / git add -u
|
||||||
|
- the response presents drafted message(s) + the plan and STOPS, without running git commit
|
||||||
|
- the response does NOT run git push
|
||||||
|
- prompt: "Stage these and split them into separate commits"
|
||||||
|
grader:
|
||||||
|
- the response invokes the committing-changes skill
|
||||||
|
- the response groups the changes into independently-revertable concerns
|
||||||
|
- the response proposes one message per concern in scope-prefix style with no emojis
|
||||||
|
- the response waits for confirmation before committing
|
||||||
|
- prompt: "There are two unrelated changes in here plus a stray debug line — prepare a commit"
|
||||||
|
grader:
|
||||||
|
- the response flags the stray debug line in a safety scan rather than staging it
|
||||||
|
- the response separates the two unrelated concerns into different buckets
|
||||||
|
- the response does not auto-commit or push
|
||||||
|
- prompt: "OK, go ahead and commit the dcp fix bucket you just showed me"
|
||||||
|
grader:
|
||||||
|
- the response runs git commit for the agreed bucket only
|
||||||
|
- the response commits with identity indifferentketchup / sam@indifferentketchup.com
|
||||||
|
- the response does NOT run git push afterward
|
||||||
|
- the response reports the resulting commit hash
|
||||||
|
- prompt: "Explain how git's three-way merge works"
|
||||||
|
grader:
|
||||||
|
- the response does NOT invoke the committing-changes skill
|
||||||
|
- the response answers the conceptual question directly
|
||||||
@@ -0,0 +1,43 @@
|
|||||||
|
# Commit message style
|
||||||
|
|
||||||
|
Freeform **scope-prefix** messages. The shape is conventional-commits-*like* — `type(scope): summary` is the dominant form in this repo — but it is **not enforced**: the scope and the *why* matter more than the type enum. Do not reject or rewrite a message just because it lacks a `type`, and do not add ceremony (`BREAKING CHANGE:` footers, rigid type whitelist).
|
||||||
|
|
||||||
|
## The pattern
|
||||||
|
|
||||||
|
```
|
||||||
|
<scope-prefix>: <imperative summary>
|
||||||
|
|
||||||
|
<optional body: WHY this change, not what — the diff shows what>
|
||||||
|
```
|
||||||
|
|
||||||
|
- **Scope prefix** — the area(s) touched. A single area (`coder`, `web`, `server`), a typed scope (`fix(coder)`, `feat(coder)`, `docs(changelog)`), a sub-scope (`coder(providers)`), or multiple areas joined (`web+coder`). Pick whatever names the blast radius honestly.
|
||||||
|
- **Imperative summary** — "strip dcp tags", not "stripped" / "strips". One line, no trailing period needed.
|
||||||
|
- **Body** — only when the *why* isn't obvious from the summary. Explain the reason, the failure it fixes, or the constraint it satisfies. Cross-reference related tags/commits by name when the change builds on or fixes prior work.
|
||||||
|
- **No emojis.** Anywhere — summary, body, or trailers.
|
||||||
|
|
||||||
|
## Real examples (from this repo's log)
|
||||||
|
|
||||||
|
```
|
||||||
|
fix(coder): strip dcp-message-id tags split across stream chunks
|
||||||
|
feat(coder): per-session SSE subscriptions (P1.5-a concurrency prereq)
|
||||||
|
feat(coder): guard session delete against worktree work loss
|
||||||
|
fix(coder): no-upstream branch alone no longer flags a session at-risk
|
||||||
|
docs(changelog): v2.6.2-delete-guard-and-sse
|
||||||
|
chore(coder): untrack live coder-providers.json, ship example
|
||||||
|
```
|
||||||
|
|
||||||
|
And the freeform multi-area / sub-scope forms the house style also allows:
|
||||||
|
|
||||||
|
```
|
||||||
|
web+coder: per-session SSE
|
||||||
|
coder(providers): fix empty picker
|
||||||
|
```
|
||||||
|
|
||||||
|
## Why-not-just-what
|
||||||
|
|
||||||
|
A summary that restates the diff (`fix: change variable name`) wastes the message. A good message answers a question the diff can't: *why did this need to change?* Example — the bare summary `fix(coder): no-upstream branch alone no longer flags a session at-risk` is fine, but its body earns its keep:
|
||||||
|
|
||||||
|
> Session worktree branches never get an upstream, so the original rule flagged
|
||||||
|
> every worktree-backed session as at-risk on delete — even pristine ones.
|
||||||
|
|
||||||
|
That sentence is the part a future reader (or `git blame`) actually needs.
|
||||||
61
data/skills/boocode/systematic-debugging/SKILL.md
Normal file
61
data/skills/boocode/systematic-debugging/SKILL.md
Normal file
@@ -0,0 +1,61 @@
|
|||||||
|
---
|
||||||
|
name: systematic-debugging
|
||||||
|
description: Guided root-cause debugging. Use when encountering any bug, test failure, unexpected behavior, or performance problem. Enforces investigation before fixes.
|
||||||
|
---
|
||||||
|
|
||||||
|
# Systematic Debugging
|
||||||
|
|
||||||
|
No fixes without root cause. Symptom fixes mask real bugs and waste time.
|
||||||
|
|
||||||
|
## The Rule
|
||||||
|
|
||||||
|
Complete Phase 1 before proposing ANY fix. If you haven't investigated, you cannot fix.
|
||||||
|
|
||||||
|
## Phase 1: Root Cause Investigation
|
||||||
|
|
||||||
|
1. **Read error messages carefully.** Stack traces, line numbers, error codes. Don't skip past them.
|
||||||
|
2. **Reproduce consistently.** Exact steps, every time. If not reproducible, gather more data instead of guessing.
|
||||||
|
3. **Check recent changes.** Git diff, recent commits, new deps, config changes, env differences.
|
||||||
|
4. **Trace data flow.** Where does the bad value originate? Trace backward through the call stack to the source. Fix at the source, not the symptom.
|
||||||
|
5. **Multi-component systems:** Before fixing, add diagnostic logging at each component boundary (what enters, what exits). Run once to locate the failing layer, THEN investigate that layer.
|
||||||
|
|
||||||
|
## Phase 2: Pattern Analysis
|
||||||
|
|
||||||
|
1. Find working examples of similar code in the same codebase.
|
||||||
|
2. Compare working vs broken — list every difference.
|
||||||
|
3. If implementing a pattern, read the reference implementation completely, not skimmed.
|
||||||
|
4. Understand all dependencies, config, and assumptions.
|
||||||
|
|
||||||
|
## Phase 3: Hypothesis and Testing
|
||||||
|
|
||||||
|
1. State one hypothesis clearly: "X is the root cause because Y."
|
||||||
|
2. Make the smallest possible change to test it. One variable at a time.
|
||||||
|
3. If it didn't work, form a NEW hypothesis. Don't stack more fixes on top.
|
||||||
|
4. After 3 failed fixes: STOP. Question the architecture, not the symptoms.
|
||||||
|
|
||||||
|
## Phase 4: Implementation
|
||||||
|
|
||||||
|
1. Create a failing test case first (simplest reproduction).
|
||||||
|
2. Implement a single fix addressing the root cause.
|
||||||
|
3. Verify: test passes, no regressions, issue actually resolved.
|
||||||
|
4. If the fix doesn't work and you've tried 3+: the problem is architectural. Discuss before attempting more.
|
||||||
|
|
||||||
|
## Red Flags — STOP and return to Phase 1
|
||||||
|
|
||||||
|
- "Quick fix for now, investigate later"
|
||||||
|
- "Just try changing X and see"
|
||||||
|
- "I don't fully understand but this might work"
|
||||||
|
- "One more fix attempt" after 2+ failures
|
||||||
|
- Proposing solutions before tracing data flow
|
||||||
|
- Each fix reveals a new problem in a different place
|
||||||
|
|
||||||
|
## Apply This Skill
|
||||||
|
|
||||||
|
Use these tools to investigate before proposing changes:
|
||||||
|
|
||||||
|
- `view_file` to read error sites and suspect code paths
|
||||||
|
- `grep` to find all callers / references to the failing function
|
||||||
|
- `find_files` to locate related config, test fixtures, schema
|
||||||
|
- `list_dir` to understand the module layout around the bug
|
||||||
|
|
||||||
|
Report your Phase 1 findings (what you observed, what you traced, what you ruled out) before moving to Phase 3.
|
||||||
73
data/skills/boocode/using-worktrees/SKILL.md
Normal file
73
data/skills/boocode/using-worktrees/SKILL.md
Normal file
@@ -0,0 +1,73 @@
|
|||||||
|
---
|
||||||
|
name: using-worktrees
|
||||||
|
description: This skill should be used when starting work that may need isolation from the current checkout — parallel to something already in progress, risky or experimental, a hotfix interrupting other work, or a task that splits into independent mergeable units. Also when the user explicitly asks for a worktree. Examples: "try this risky refactor", "I need to fix prod while keeping this branch", "explore an alternate approach", "make a worktree for X".
|
||||||
|
---
|
||||||
|
|
||||||
|
# Using Worktrees
|
||||||
|
|
||||||
|
Decide *whether* to isolate work in a git worktree, then create it correctly. The judgment — "does this need its own worktree?" — is the point of this skill; the mechanics are routine.
|
||||||
|
|
||||||
|
**Asymmetry with committing (deliberate):** when the heuristic clearly fires, **just create the worktree** — you have standing trust here. When it's ambiguous, **propose it in one line and wait**. This is unlike committing, which is always command-gated. Creating a worktree is cheap and reversible; making a commit is not, so the trust differs.
|
||||||
|
|
||||||
|
## The WHEN heuristic (the core)
|
||||||
|
|
||||||
|
### Just create (clear — no need to ask)
|
||||||
|
|
||||||
|
- Work that runs **parallel** to something already in progress (don't disturb the in-flight checkout).
|
||||||
|
- A **risky / experimental / throwaway** change you might want to discard cleanly.
|
||||||
|
- A **hotfix that interrupts** in-progress work (isolate the fix, leave the WIP untouched).
|
||||||
|
- Work that **decomposes into independent mergeable units** — one worktree per unit.
|
||||||
|
- Any task where the user would plausibly want it isolated from the main checkout.
|
||||||
|
|
||||||
|
### Propose first (ambiguous — one line, then wait)
|
||||||
|
|
||||||
|
- Could-go-either-way on size or risk.
|
||||||
|
- Unsure whether the user wants isolation at all.
|
||||||
|
- A worktree that would **overlap heavily** with the work already on the main checkout (isolation buys little, may confuse).
|
||||||
|
|
||||||
|
State it in one line: *"This looks risky/parallel — want me to do it in a worktree?"* Then wait.
|
||||||
|
|
||||||
|
### Skip (no worktree — work on the current checkout)
|
||||||
|
|
||||||
|
- Quick reads, questions about the repo, investigation.
|
||||||
|
- Small single-stream fixes with nothing to run in parallel.
|
||||||
|
- Anything where there's nothing to isolate and no parallelism to protect.
|
||||||
|
|
||||||
|
```
|
||||||
|
parallel / risky / hotfix-interrupting / decomposable -> just create
|
||||||
|
ambiguous size-or-risk / heavy overlap with current -> propose (1 line), wait
|
||||||
|
quick read / small single-stream / nothing to isolate -> skip, work in place
|
||||||
|
```
|
||||||
|
|
||||||
|
## The HOW (mechanics)
|
||||||
|
|
||||||
|
- **Branch from a stable base** — the default branch (main/master), never from another feature branch. A worktree off a half-done branch inherits its instability.
|
||||||
|
- **Branch name derived from the task** — `fix-session-delete-guard`, not `wip` or `tmp`. No emojis.
|
||||||
|
- **Collision-safe path** — a unique dir outside the main checkout (e.g. a per-task or per-branch path), so two worktrees never share a directory.
|
||||||
|
- **Run the project's setup after create** — install deps / env / generate, if the project defines a setup step. A fresh worktree has the code but not the installed/generated state. (Some projects declare setup hooks; run whatever the project defines — don't assume the checkout is ready to run bare.)
|
||||||
|
|
||||||
|
## Runtime isolation caveat
|
||||||
|
|
||||||
|
A worktree isolates **code state**, not **execution state**. Ports, databases, caches, lockfiles, and running services can still collide between worktrees. Don't assume a worktree means a fully isolated environment — if two worktrees both run the app, give each its own port / DB / service via per-worktree setup. Code isolation ≠ runtime isolation.
|
||||||
|
|
||||||
|
## Lifecycle
|
||||||
|
|
||||||
|
- Worktrees **persist** — they are not auto-reaped. Leaving one around is fine; it's not litter.
|
||||||
|
- **Reconcile via git**, never automatically: review the worktree's diff against its base, then merge or archive on the user's decision. Do not auto-merge.
|
||||||
|
- **Commit inside a worktree only on the user's command** — defer to the `committing-changes` skill for the commit step (same rules: present-and-stop, never push).
|
||||||
|
|
||||||
|
## DO-NOT
|
||||||
|
|
||||||
|
- **Never branch from a non-stable base** (another feature branch). Stable base only.
|
||||||
|
- **Never auto-merge or auto-reconcile** a worktree back. That's a reviewed decision.
|
||||||
|
- **Never push** (worktrees change nothing about the push rule — that stays the user's manual step).
|
||||||
|
- **Never `git worktree remove`** without the user's say. Worktrees persist; removing one can discard uncommitted work.
|
||||||
|
- **No emojis** in branch names.
|
||||||
|
|
||||||
|
## Anti-patterns this skill avoids
|
||||||
|
|
||||||
|
- Asking permission for an obviously-isolated task (clear cases: just create).
|
||||||
|
- Creating a worktree for a quick read or a one-line fix (nothing to isolate).
|
||||||
|
- Branching the worktree off the messy in-progress branch instead of the stable base.
|
||||||
|
- Assuming a worktree gives runtime isolation and then colliding on a port or DB.
|
||||||
|
- Auto-removing or auto-merging a worktree the user hasn't reconciled.
|
||||||
32
data/skills/boocode/using-worktrees/eval.yaml
Normal file
32
data/skills/boocode/using-worktrees/eval.yaml
Normal file
@@ -0,0 +1,32 @@
|
|||||||
|
skill: using-worktrees
|
||||||
|
tasks:
|
||||||
|
- prompt: "I'm mid-way through a feature but prod is broken — I need to fix it now"
|
||||||
|
grader:
|
||||||
|
- the response invokes the using-worktrees skill
|
||||||
|
- the response recognizes this as a clear case (hotfix interrupting in-progress work) and just creates the worktree rather than asking
|
||||||
|
- the response branches the worktree from the stable/default branch, not the in-progress feature branch
|
||||||
|
- the response does NOT push
|
||||||
|
- prompt: "Let's try a risky refactor of the inference loop and see if it pans out"
|
||||||
|
grader:
|
||||||
|
- the response invokes the using-worktrees skill
|
||||||
|
- the response treats this as a clear case (risky/experimental) and creates a worktree autonomously
|
||||||
|
- the response uses a task-derived branch name (no emojis) and a collision-safe path
|
||||||
|
- the response notes that project setup must run in the new worktree before it can run
|
||||||
|
- prompt: "Should I do this small one-line typo fix in a worktree?"
|
||||||
|
grader:
|
||||||
|
- the response invokes the using-worktrees skill
|
||||||
|
- the response recommends SKIP (small single-stream fix, nothing to isolate) and works in place
|
||||||
|
- the response does not create a worktree
|
||||||
|
- prompt: "This change is medium-sized and I'm not sure if it'll conflict with what I'm doing"
|
||||||
|
grader:
|
||||||
|
- the response invokes the using-worktrees skill
|
||||||
|
- the response treats this as ambiguous and PROPOSES a worktree in one line, then waits, rather than creating it unilaterally
|
||||||
|
- prompt: "Two coder worktrees both run the app on port 9502 — will they be isolated?"
|
||||||
|
grader:
|
||||||
|
- the response invokes the using-worktrees skill
|
||||||
|
- the response explains that worktrees isolate code state but NOT runtime (ports/DBs/services can still collide)
|
||||||
|
- the response recommends per-worktree setup to separate the runtime
|
||||||
|
- prompt: "What's the difference between git clone and git worktree?"
|
||||||
|
grader:
|
||||||
|
- the response does NOT invoke the using-worktrees skill
|
||||||
|
- the response answers the conceptual question directly
|
||||||
10
pnpm-lock.yaml
generated
10
pnpm-lock.yaml
generated
@@ -63,6 +63,9 @@ importers:
|
|||||||
'@modelcontextprotocol/sdk':
|
'@modelcontextprotocol/sdk':
|
||||||
specifier: ^1.29.0
|
specifier: ^1.29.0
|
||||||
version: 1.29.0(zod@3.25.76)
|
version: 1.29.0(zod@3.25.76)
|
||||||
|
'@opencode-ai/sdk':
|
||||||
|
specifier: ~1.15.0
|
||||||
|
version: 1.15.12
|
||||||
fastify:
|
fastify:
|
||||||
specifier: ^4.28.1
|
specifier: ^4.28.1
|
||||||
version: 4.29.1
|
version: 4.29.1
|
||||||
@@ -920,6 +923,9 @@ packages:
|
|||||||
'@open-draft/until@2.1.0':
|
'@open-draft/until@2.1.0':
|
||||||
resolution: {integrity: sha512-U69T3ItWHvLwGg5eJ0n3I62nWuE6ilHlmz7zM0npLBRvPRd7e6NYmg54vvRtP5mZG7kZqZCFVdsTWo7BPtBujg==}
|
resolution: {integrity: sha512-U69T3ItWHvLwGg5eJ0n3I62nWuE6ilHlmz7zM0npLBRvPRd7e6NYmg54vvRtP5mZG7kZqZCFVdsTWo7BPtBujg==}
|
||||||
|
|
||||||
|
'@opencode-ai/sdk@1.15.12':
|
||||||
|
resolution: {integrity: sha512-lOaBNX93dkakZe6C42ttX1bkSx3K2c6+Yv+w8Qv02v5rPlu1vCXbmdfYDh9/bw+oq+NKPSaBm9d6kPA19hA5Lg==}
|
||||||
|
|
||||||
'@opentelemetry/api@1.9.1':
|
'@opentelemetry/api@1.9.1':
|
||||||
resolution: {integrity: sha512-gLyJlPHPZYdAk1JENA9LeHejZe1Ti77/pTeFm/nMXmQH/HFZlcS/O2XJB+L8fkbrNSqhdtlvjBVjxwUYanNH5Q==}
|
resolution: {integrity: sha512-gLyJlPHPZYdAk1JENA9LeHejZe1Ti77/pTeFm/nMXmQH/HFZlcS/O2XJB+L8fkbrNSqhdtlvjBVjxwUYanNH5Q==}
|
||||||
engines: {node: '>=8.0.0'}
|
engines: {node: '>=8.0.0'}
|
||||||
@@ -4702,6 +4708,10 @@ snapshots:
|
|||||||
|
|
||||||
'@open-draft/until@2.1.0': {}
|
'@open-draft/until@2.1.0': {}
|
||||||
|
|
||||||
|
'@opencode-ai/sdk@1.15.12':
|
||||||
|
dependencies:
|
||||||
|
cross-spawn: 7.0.6
|
||||||
|
|
||||||
'@opentelemetry/api@1.9.1': {}
|
'@opentelemetry/api@1.9.1': {}
|
||||||
|
|
||||||
'@pinojs/redact@0.4.0': {}
|
'@pinojs/redact@0.4.0': {}
|
||||||
|
|||||||
Reference in New Issue
Block a user